29347 Commits

Author SHA1 Message Date
skia-flutter-autoroll
f47b40cd19 Roll Dart SDK from bbce07ad3944 to 9e633e463902 (3 revisions) (flutter/engine#42646)
https://dart.googlesource.com/sdk.git/+log/bbce07ad3944..9e633e463902

2023-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-183.0.dev
2023-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-182.0.dev
2023-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-181.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-08 00:46:37 +00:00
Alexander Aprelev
f3c26172de Roll dart to 3.1.0-180.0.dev (flutter/engine#42638)
Roll dart to 3.1.0-180.0.dev
    
    Changes since last roll
    ```
    bbce07ad394 (tag: 3.1.0-180.0.dev) Version 3.1.0-180.0.dev
    81fc5e710d8 (tag: 3.1.0-179.0.dev) Version 3.1.0-179.0.dev
3b850bb1ace [js-rti] Support legacy types in `is FutureOr` specializer.
    dcac7808518 Update PULL_REQUEST_TEMPLATE.md
    5b3a57908d5 [dart:js_interop] Remove ObjectLiteral
30b9ac9f873 [dds/dap] Don't show skipped tests as passes in debug
adapter output
    79b71c789f6 Use ParameterReference for ChangeParameterType.
bc94e7662be [analyzer] Refactor visitConditionExpression in the const
evaluator.
    cf5168ea339 (tag: 3.1.0-178.0.dev) Version 3.1.0-178.0.dev
7071c65b8c7 Change TransformSetParser.singleKey() to avoid null asserts.
a3399e3616f [analysis_server] Add support for adding imports with
show/hide + update Move to File
    463c7cb5a2f [vm] Support unchecked AsExpressions in the VM
3a598b4c031 [vm, gc] Honor kAllocatablePageSize during promotion and
snapshot reading.
    b84077426ab (tag: 3.1.0-177.0.dev) Version 3.1.0-177.0.dev
    9421ca07994 Delete old debianpackage-linux builder.
    d4c2d659075 Remove unnecessary null check on `initializerType`.
26fd946904e Run CFE presubmit lints with scanner configured for null
safety mode.
    cbd1b8d4943 (tag: 3.1.0-176.0.dev) Version 3.1.0-176.0.dev
    033fa5e684d [build] Remove unused pipes import from vs_toolchain.py
b5ee6fa8885 [vm/ffi] Support native assets in `dart build` with relative
path
    5e8c29e7b68 (tag: 3.1.0-175.0.dev) Version 3.1.0-175.0.dev
    7335116e08a (tag: 3.1.0-174.0.dev) Version 3.1.0-174.0.dev
07f587504b1 Reland "[vm] Migrate FFI callbacks to the new metadata
system."
    369a8312aa4 [ddc] Fix types of constants in legacy libraries
    105f7e17222 (tag: 3.1.0-173.0.dev) Version 3.1.0-173.0.dev
526ce3aba48 Issue 52005. Convert non-exhaustive returning
SwitchStatement to SwitchExpression when followed by throw.
    cc18b250ae8 Bump github/codeql-action from 2.3.5 to 2.3.6
5ff0821b274 [kernel,vm] First-class kernel serialization of FutureOrType
and NullType
8d298292719 Use 'coveringNode' name in RefactoringContext, as it is in
Selection.
    97ec9e95bf8 Convert imported reference completion tests
f92c6da7bf4 [analyzer] Refactor visitAsExpression and visitIsExpression
in the constant evaluator.
    9e196bc7118 Roll gn from 5a004f9427a0 to e3978de3e8da
    7c63a493a22 (tag: 3.1.0-172.0.dev) Version 3.1.0-172.0.dev
88f05965ac4 Issue 52606. Fix AstNodeExtension.nodeCovering() when
selection if at the end of Comment.
09df4e5200b [ddc] Fix dynamic calls of generic methods with new types
    1e1266f8e6c [ddc] Sync dart_library.js from internal
56cb8de9736 Make ParsedUnitResult and ParsedLibraryResult superclasses
of ResolvedUnitResult and ResolvedLibraryResult respectively.
03b2abf78f2 [deps] rev async, dartdoc, ffi, http, leak_tracker, lints,
mockito, test, tools, webdev
29f121126ba [analysis_server] Allow skipping slow benchmarks with env
variable
    ```
2023-06-07 16:28:03 -07:00
skia-flutter-autoroll
e2ea5e6410 Roll Skia from 156542f8bf13 to 1a3adf848e61 (1 revision) (flutter/engine#42644)
https://skia.googlesource.com/skia.git/+log/156542f8bf13..1a3adf848e61

2023-06-07 michaelludwig@google.com [skif] Improve magnifier zoom window with missing content

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 23:19:50 +00:00
skia-flutter-autoroll
93b0156c27 Roll Skia from c5a8c4547f59 to 156542f8bf13 (4 revisions) (flutter/engine#42641)
https://skia.googlesource.com/skia.git/+log/c5a8c4547f59..156542f8bf13

2023-06-07 robertphillips@google.com Disable rotated nearest-neighbor testing in the big image test
2023-06-07 johnstiles@google.com Emit simpler WGSL for-loops when the loop-count is known.
2023-06-07 johnstiles@google.com Add WGSL support for the discard statement.
2023-06-07 johnstiles@google.com Allow assignment to function parameters in WGSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 22:10:20 +00:00
Jason Simmons
08f35fa586 Roll HarfBuzz to 7.3.0 (flutter/engine#42629) 2023-06-07 21:51:10 +00:00
ColdPaleLight
437cbb1154 [Impeller] Corrected the 'texture_coords' computation in 'Geometry::GetPositionUVBuffer' (flutter/engine#42619)
fix https://github.com/flutter/flutter/issues/128328

We need to transform the 'position' first and then divide 'texture_coverage', otherwise the result will be incorrect.

without patch
![66WTKLw7fY](https://github.com/flutter/engine/assets/31977171/6d31138e-0595-4d9c-883e-70a50a5e228d)
with patch
![VAHrQB0HLk](https://github.com/flutter/engine/assets/31977171/0d75e2f8-126e-4ba0-8867-187a311249f4)
2023-06-07 21:44:54 +00:00
Alexander Aprelev
80314e1c95 Roll dart to 3.1.0-171.0.dev (flutter/engine#42636)
Changes since last dart-sdk roll
```
5144119b99c (tag: 3.1.0-171.0.dev) Version 3.1.0-171.0.dev
39de3f2e5bd Field promotion: track field accesses via SSA node.
f180b7037c0 Shared analysis: remove bogus support for late variable patterns.
5e5fe2aa773 [analyzer_cli] [dartdev] Fix several tests on Windows
c739cbfd7b0 [analysis_server] Fix generation tests on Windows
f984411eac1 [analysis_server] Fix split_multiple_declarations to use \r\n on Windows
f2b845a77f4 (tag: 3.1.0-170.0.dev) Version 3.1.0-170.0.dev
2a705d8612f [analysis_server] Extract base server functionality from protocol-specific callbacks
```
2023-06-07 14:26:00 -07:00
skia-flutter-autoroll
6e6dfee6de Roll Skia from 773765ca1dd2 to c5a8c4547f59 (4 revisions) (flutter/engine#42633)
https://skia.googlesource.com/skia.git/+log/773765ca1dd2..c5a8c4547f59

2023-06-07 robertphillips@google.com Expand big image unit test
2023-06-07 jvanverth@google.com [graphite] Clean up BackendTexture.
2023-06-07 michaelludwig@google.com [skif] Update SkLocalMatrixImageFilter to FilterResult system
2023-06-07 robertphillips@google.com Add unit test for large images (take 2)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 20:59:35 +00:00
godofredoc
ed776ac512 Add global test docs. (flutter/engine#42531)
Adds documentation for the use cases supported by global tests along with their respective configurations.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-07 20:52:51 +00:00
skia-flutter-autoroll
281c830a68 Roll Fuchsia Mac SDK from ojwVlxZWrbsG4WGSE... to DL1QQ5eZRVNARqLx-... (flutter/engine#42632)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 20:29:40 +00:00
skia-flutter-autoroll
1e59a11be1 Roll Fuchsia Linux SDK from sEHtHM1iFt79roP-x... to aMTaMP0DdKdJnxSbc... (flutter/engine#42631)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 20:16:52 +00:00
Casey Hillers
7507e8dc16 [labeler] Fix to run on flutter/engine (flutter/engine#42634)
Fixes https://github.com/flutter/flutter/issues/128448#issuecomment-1581353250
2023-06-07 20:11:49 +00:00
Bruno Leroux
a3843d747d [iOS] Fix TextInputAction.continueAction sends wrong action to framework (flutter/engine#42615)
## Description

This PR fixes an issue related to text input plugin, on IOS, sending a wrong action string to the engine for `FlutterTextInputActionContinue`.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/126922

## Tests

Adds 1 test.
2023-06-07 20:11:47 +00:00
Jonah Williams
02591dca4d [Impeller] fix missing assignment of embedder render target. (flutter/engine#42630)
Otherwise we can't render 😄
2023-06-07 19:57:57 +00:00
Jonah Williams
50626db959 [Impeller] Add buffer to texture blit for Vulkan. (flutter/engine#41706)
Work towards https://github.com/flutter/flutter/issues/123468

In order to support the usage of BufferView, I generalized the tracked buffer type from DeviceBuffer to Buffer. Should be mostly safe!

I confirmed that this runs correctly under moltenvk but I'm uncertain if there are additional ways to validate.
2023-06-07 19:32:48 +00:00
Chris Bracken
e7a44a64a7 [macOS] Add platformview creation parameter support (flutter/engine#42607)
Previously, when creating native platform views on macOS, we ignored any parameters passed via the framework side "params" argument in the "create" method call, and instead always passed a nil value to the FlutterPlatformViewFactory. This made it impossible for users of macOS platform views to pass constructor arguments to the NSView subclass implementing the platform view.

We now decode the arguments data using the codec specified by the `FlutterPlatformViewFactory` and pass them through to the `[FlutterPlatformViewFactory createWithIdentifier:arguments:]` method where the platform view author can make use of them.

Fixes: https://github.com/flutter/flutter/issues/124723

This is a part of the broader macOS platform view support effort: https://github.com/flutter/flutter/issues/41722

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-07 19:16:56 +00:00
gaaclarke
01f6db8882 [Impeller] Added a switch to turn on vulkan (flutter/engine#42585)
fixes https://github.com/flutter/flutter/issues/128286

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-07 19:08:04 +00:00
skia-flutter-autoroll
ece46cca0a Roll ANGLE from f8220fa3a729 to 15a29438b099 (1 revision) (flutter/engine#42627)
f8220fa3a7..15a29438b0

2023-06-07 prashanthsw@google.com Migrate Android NDK to CIPD [1/2]

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 18:35:13 +00:00
Jackson Gardner
6fdcec7af7 Bump Chrome version to 114 for testing (flutter/engine#42623) 2023-06-07 17:55:20 +00:00
skia-flutter-autoroll
aaad533dda Roll Skia from d607cbb0db78 to 773765ca1dd2 (7 revisions) (flutter/engine#42624)
https://skia.googlesource.com/skia.git/+log/d607cbb0db78..773765ca1dd2

2023-06-07 drott@chromium.org [Fontations] Support makeClone() for variations
2023-06-07 johnstiles@google.com Demonstrate function-parameter assignment issue in unit test.
2023-06-07 johnstiles@google.com Add unit tests to WGSL that rely on dead-return synthesis.
2023-06-07 johnstiles@google.com Add trailing `return` to functions that lack an unconditional return.
2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c520912239f0 to 5c35de42bbc6 (2 revisions)
2023-06-07 johnstiles@google.com Fix test disable for OutParamsDoubleSwizzle.
2023-06-07 kjlubick@google.com Remove some spaces from the gainmap sksl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 17:43:26 +00:00
J-P Nurmi
42b7de838e [Linux][a11y] implement AtkText::get_text/string_at_offset() (flutter/engine#38144)
This PR implements `AtkText::get_string_at_offset()` (and the deprecated `AtkText::get_text_at_offset()` still used by e.g. Orca) for `FlAccessibleTextField` to allow Orca to read out loud the current character while moving the text cursor around.

### Before (unmute to hear the screen reader)

[textfield-a11y-before.webm](https://user-images.githubusercontent.com/140617/206556644-fb4f4df8-acca-4d97-86d5-7120f0a4871d.webm)

### After (unmute to hear the screen reader)

[textfield-a11y-after.webm](https://user-images.githubusercontent.com/140617/206556678-4fbf9112-291e-4518-a258-e9ca33469430.webm)

Fixes: flutter/flutter#113049

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-07 17:18:04 +00:00
skia-flutter-autoroll
ab31deab67 Roll ANGLE from 176989ad00cc to f8220fa3a729 (1 revision) (flutter/engine#42621)
176989ad00..f8220fa3a7

2023-06-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 0c2e936905ea to f7613775cdc7 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 15:46:19 +00:00
skia-flutter-autoroll
c69ef0e6e7 Roll Skia from ee90e9ae2e62 to d607cbb0db78 (1 revision) (flutter/engine#42618)
https://skia.googlesource.com/skia.git/+log/ee90e9ae2e62..d607cbb0db78

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b8f3bbf465f8 to b54c2bdc9713 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 14:53:23 +00:00
skia-flutter-autoroll
7949774945 Roll ANGLE from 1ad4ae4d63bf to 176989ad00cc (1 revision) (flutter/engine#42617)
1ad4ae4d63..176989ad00

2023-06-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 9e0b5e8b8a85 to fe5f79e217c4 (537 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 14:45:57 +00:00
Tong Mu
fdadd4c99e Revert "[Android] Return keyboard pressed state" (flutter/engine#42616)
Reverts flutter/engine#41695 due to internal bug report b/284945818.

cc @bleroux let's investigate some day.
2023-06-07 01:38:45 -07:00
skia-flutter-autoroll
0a726f3493 Roll Skia from bde894438f29 to ee90e9ae2e62 (1 revision) (flutter/engine#42614)
https://skia.googlesource.com/skia.git/+log/bde894438f29..ee90e9ae2e62

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b54c2bdc9713 to bb33478c7dad

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 07:43:06 +00:00
skia-flutter-autoroll
a7ba47faac Roll Fuchsia Linux SDK from lpbkSRJBMkPs0FM7_... to sEHtHM1iFt79roP-x... (flutter/engine#42613)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 07:20:25 +00:00
skia-flutter-autoroll
eafdc20bfa Roll Skia from cd3e1665dcd1 to bde894438f29 (1 revision) (flutter/engine#42612)
https://skia.googlesource.com/skia.git/+log/cd3e1665dcd1..bde894438f29

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 721c15efaa70 to 1ad4ae4d63bf (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 06:44:12 +00:00
skia-flutter-autoroll
60a48fff60 Roll ANGLE from 16841d6256da to 1ad4ae4d63bf (1 revision) (flutter/engine#42611)
16841d6256..1ad4ae4d63

2023-06-06 yuxinhu@google.com Clean up EGLPreRotation Test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 06:08:12 +00:00
Brandon DeRosier
72a1fea6e2 [Impeller] Reland 2: Add Impeller Metal support in the embedder API (#42411) (flutter/engine#42597)
This reverts commit
8d6f091751
+ fixes bugs.

Reworked the surface wrapping to use a valid descriptor when wrapping
the drawable.
2023-06-06 23:02:02 -07:00
skia-flutter-autoroll
d5adc1154e Roll Skia from a01f49f539ab to cd3e1665dcd1 (1 revision) (flutter/engine#42610)
https://skia.googlesource.com/skia.git/+log/a01f49f539ab..cd3e1665dcd1

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3e5c6411ba05 to fd2d24b01b67 (21 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 05:55:04 +00:00
skia-flutter-autoroll
6a13668263 Roll Fuchsia Mac SDK from atrYtfHWi2cmV9B_C... to ojwVlxZWrbsG4WGSE... (flutter/engine#42609)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 05:17:38 +00:00
skia-flutter-autoroll
0974bef6df Roll Skia from 521b8c4bb011 to a01f49f539ab (4 revisions) (flutter/engine#42608)
https://skia.googlesource.com/skia.git/+log/521b8c4bb011..a01f49f539ab

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 521ddd00b973 to c520912239f0 (4 revisions)
2023-06-06 johnstiles@google.com Allow WGSL code with warnings to compile successfully.
2023-06-06 johnstiles@google.com Change WGSL indentation level to 2 spaces.
2023-06-06 johnstiles@google.com Add WGSL support for do-while loops.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 05:05:05 +00:00
skia-flutter-autoroll
306354e4a2 Roll Skia from cef18d10b363 to 521b8c4bb011 (1 revision) (flutter/engine#42605)
https://skia.googlesource.com/skia.git/+log/cef18d10b363..521b8c4bb011

2023-06-06 robertphillips@google.com Revert "Add unit test for large images"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 03:08:49 +00:00
Alexander Aprelev
a4fc8c761e Roll dart to 3.1.0-169.0.dev (flutter/engine#42602)
Dart changes since last roll
```
d00a370c1fd (HEAD, tag: 3.1.0-169.0.dev) Version 3.1.0-169.0.dev
00d63e7bf96 [ddc] Fix covariant bound checks with new types
ff3117ac474 (tag: 3.1.0-168.0.dev) Version 3.1.0-168.0.dev
4f2f3405fb5 [analyzer] Refactor visitInterpolationExpression in constant evaluator.
41c17e0b015 [vm, gc] Remembered cards tweaks.
d4adfcccaf1 [dart:js_interop/ddc] Lower static interop using call-site and omit tear-offs
c98ec26c910 [dart:js_interop] Disallow external extension members with 'static'
46d9f76f7e6 Add postEvent to dds client.
25c0ae1c423 Link to dart.dev for linter rules
605e89d3bd1 [analyzer_utilities] Find pkg folder from working directory
32977d8f436 [infra] Setup Windows ARM64.
808b4d5bf6a [vm/aot/tfa] Cleanup _FallthroughDetector
e0ced74e154 [gardening] Marking evaluate_activation_test as slow.
3a15031b183 (tag: 3.1.0-167.0.dev) Version 3.1.0-167.0.dev
d198f84f5e4 (tag: 3.1.0-166.0.dev) Version 3.1.0-166.0.dev
486b3b380e0 [vm/aot/tfa] Fix building of data flow summary in case of break from try/finally
8091581e720 [cfe] Use unchecked AsExpression instead of promoted VariableGet
17781dbc364 [frontend/dds] Enable frontend server and dds to pass through types, method and class information for expression evaluation.
877fe38f0ce [dart2wasm] Fix runtime type tests
8dfd80486e6 [infra] Rename dart2wasm configurations and builders
33fd4933304 [cfe] Constant evaluate string interpolation
9d8df2a5210 (tag: 3.1.0-165.0.dev) Version 3.1.0-165.0.dev
b7ea982bea6 Flow analysis: Simplify ExpressionInfo class hierarchy.
b1134039940 use switch cases where it makes sense in the macro code
b43d95a942d [test] Re-establish at least some Fuchsia testing.
79e67836378 Typing tweaks for ExecuteCommandHandler.
2c9bc7b9586 (tag: 3.1.0-164.0.dev) Version 3.1.0-164.0.dev
7b3305ebee9 [deps] rev args, bazel_worker, dartdoc, http, leak_tracker, mockito, native, protobuf, pub_semver, shelf, stack_trace, tools, vector_math, webdev
247ca91bb89 [analysis_server] Tweak "ignore diagnostic" text for file
475240d2346 Reland "[VM/Timeline] Make timestamp1_or_id variables more understandable"
310baf27375 mark all public interfaces as abstract interface classes
63d856d4878 [test] Avoid quadratic complexity in vm/dart/unobfuscated_static_symbols_test
e316fb84a11 [js] Add inlining hints to js patch files.
0d1a9df087f [analyzer] Refactor visitAdjacentStrings and visitStringInterpolation for the constant evaluator.
709c0e4ccd3 Flow analysis: combine ExpressionInfo, ReferenceWithType, and EqualityInfo.
990fdea1d50 [cfe] Fix for transforming record literals to const records with unevaluated const elements.
52791b4e0d3 [build] Decide in one place between using app-jit and kernel for the SDK snapshots.
2023-06-06 19:59:34 -07:00
Jason Simmons
92064621b7 Convert pixel formats for animated PNG frames using the source blend mode (flutter/engine#42581)
The destination buffer format may not exactly match the source format. In particular, the alpha type of the source may need to be converted to the alpha type of the destination.

Fixes https://github.com/flutter/flutter/issues/128102
2023-06-07 00:02:03 +00:00
skia-flutter-autoroll
5834a9e8c4 Roll ANGLE from e21ecd1b59f7 to 16841d6256da (24 revisions) (flutter/engine#42601)
e21ecd1b59..16841d6256

2023-06-06 kkinnunen@apple.com Reland "Remove SPIRV_METAL references from .gn and tests"
2023-06-06 romanl@google.com Resolve circular dependency android_helper <-> angle_test_util
2023-06-06 lexa.knyazev@gmail.com Disallow 'depth_unchanged' qualifier for WebGL contexts
2023-06-06 ynovikov@chromium.org Revert "Remove SPIRV_METAL references from .gn and tests"
2023-06-06 sokcevic@chromium.org Add kwargs to specialized error message
2023-06-06 rafael.cintron@microsoft.com Refactor D3D device creation to make adapter selection explicit
2023-06-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d6f22a2a164b to 9e0b5e8b8a85 (1063 revisions)
2023-06-06 kkinnunen@apple.com Remove SPIRV_METAL references from .gn and tests
2023-06-06 senorblanco@chromium.org D3D11: fix for atomic assigned to an SSBO.
2023-06-06 kbr@chromium.org Metal: Remove OS info from renderer string for WebGL contexts.
2023-06-05 geofflang@chromium.org Do not call postResolveLink in Program::deserialize.
2023-06-05 romanl@google.com Make run_code_generation faster using python3 for auto_script
2023-06-04 syoussefi@chromium.org Vulkan: Declare common SPIR-V ids in the compiler
2023-06-04 syoussefi@chromium.org Vulkan: Pass non-semantic info from translator to transformer
2023-06-03 yuxinhu@google.com Revert "Enable usePrimitiveRestartEnableDynamicState on ARM driver 43"
2023-06-02 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from aac4d6a34cf9 to d6f22a2a164b (285 revisions)
2023-06-02 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll VK-GL-CTS from 356e6d2f8796 to 0c2e936905ea (9 revisions)
2023-06-02 romanl@google.com Add all of tools/android to DEPS
2023-06-02 bsheedy@chromium.org Update vpython3 requests
2023-06-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f549d5e6c663 to ae667fe96db9 (2 revisions)
2023-06-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 069f9924f967 to aac4d6a34cf9 (715 revisions)
2023-06-01 yuxinhu@google.com Enable usePrimitiveRestartEnableDynamicState on ARM driver 43
2023-06-01 abdolrashidi@google.com Vulkan: Add version to pipeline cache header
2023-06-01 cclao@google.com Vulkan: Move some bufferRead logic into CommandBufferHelperCommon

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-06 22:16:02 +00:00
skia-flutter-autoroll
a30e718193 Roll Skia from 4065e92bf577 to cef18d10b363 (18 revisions) (flutter/engine#42600)
https://skia.googlesource.com/skia.git/+log/4065e92bf577..cef18d10b363

2023-06-06 robertphillips@google.com Add unit test for large images
2023-06-06 johnstiles@google.com Rename OutParamsTricky to OutParamsDoubleSwizzle.
2023-06-06 herb@google.com Do not return infinities as roots
2023-06-06 cmumford@google.com Revert "[infra] temporarily remove RadeonHD8870M-x86_64-Debug-All-Graphite_Metal from CQ"
2023-06-06 johnstiles@google.com Remove out-param helper functions from WGSL.
2023-06-06 rmistry@google.com Revert "Whitespace change to test GitWatcher"
2023-06-06 cmumford@google.com Revert "[infra] temp remove Release-All-Graphite_Metal from CQ"
2023-06-06 johnstiles@google.com Fix ternary paren-handling code.
2023-06-06 michaelludwig@google.com Revert "Rename ColorTable in public.bzl"
2023-06-06 kjlubick@google.com Remove old GrRectanizer file
2023-06-06 kjlubick@google.com Rename ColorTable in public.bzl
2023-06-06 johnstiles@google.com Remove special case for inverse-hyperbolic intrinsic tests.
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3c250b5ab450 to 521ddd00b973 (1 revision)
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b8f3bbf465f8 to 0daeddfa6f24
2023-06-06 drott@chromium.org [Fontations] Variations support for fontations backend
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4ff41604e769 to 721c15efaa70 (3 revisions)
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ac4876bcdcc3 to b8f3bbf465f8 (9 revisions)
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f44e26b8163c to 3e5c6411ba05 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-06 22:02:19 +00:00
Mouad Debbar
1574da58fb [web] Remove /#/ from home page URL (flutter/engine#42598)
To make the `HashUrlStrategy` a bit cleaner (at least for the home page), let's get rid of the notorious `/#/` when the app is in the home page.

Non-home pages continue to have a hash in them. After this PR, here are some example URL changes:

- `http://domain.com/#/` => `http://domain.com/`
- `http://domain.com/#/page1` => (remains the same)

This change is backwards compatible, i.e. if you write `http://domain.com/#/` in the address bar, the app will load and open the home page correctly; and flutter will automatically change the URL to `http://domain.com/`.

Fixes https://github.com/flutter/flutter/issues/127608
2023-06-06 21:33:34 +00:00
Casey Hillers
1baefb4e90 [labeler] Add engine workflow (flutter/engine#42566)
https://github.com/flutter/flutter/issues/126002
2023-06-06 19:39:40 +00:00
Jackson Gardner
1f3fc87375 Use proper sampling options in Skwasm's drawAtlas. (flutter/engine#42595)
Make Skwasm consistent with the CanvasKit backend's sampling options in `drawAtlas`. Also, fix the atlas rendering tests so the sprites don't bleed into each other.
2023-06-06 18:23:54 +00:00
Zachary Anderson
8d6f091751 Revert "[Impeller] Reland: Add Impeller Metal support in the embedder API (#42411)" (flutter/engine#42593)
Reverts flutter/engine#42545

Not sure if this is needed, but getting a revert started for the
regression noted here:
https://github.com/flutter/engine/pull/42545#issuecomment-1579034704.
2023-06-06 10:57:57 -07:00
Zachary Anderson
a4677d34f6 Fix raster cache optional value check logic (flutter/engine#42592)
Possible fix for https://github.com/flutter/flutter/issues/128308
2023-06-06 09:35:50 -07:00
ColdPaleLight
ef42a7d173 [Impeller] Fix the rendering issue when the tile mode of gradient is set to 'decal' (flutter/engine#42591)
fix issue https://github.com/flutter/flutter/issues/128327
without patch 
![oOFhefzmN6](https://github.com/flutter/engine/assets/31977171/9d219ba8-b808-4de6-87ae-cc21e3b1411f)

with patch
![a5A81re5tD](https://github.com/flutter/engine/assets/31977171/7010b7b6-0d3b-481f-ac3b-36aeb1da1785)
2023-06-06 16:31:17 +00:00
skia-flutter-autoroll
a208719197 Roll Skia from e8a71c76b88f to 4065e92bf577 (1 revision) (flutter/engine#42587)
https://skia.googlesource.com/skia.git/+log/e8a71c76b88f..4065e92bf577

2023-06-06 michaelludwig@google.com Add SkColorTable to share memory for SkColorFilters::Table

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-06 16:28:30 +00:00
skia-flutter-autoroll
3235ab593e Roll Fuchsia Linux SDK from vAwdggqMrL1yoH_Zn... to lpbkSRJBMkPs0FM7_... (flutter/engine#42590)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-06 16:27:52 +00:00
skia-flutter-autoroll
b01a102dd8 Roll Fuchsia Mac SDK from tCxDcZ3yi0rnKGVHt... to atrYtfHWi2cmV9B_C... (flutter/engine#42589)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-06 16:26:00 +00:00
ColdPaleLight
56a384d9da [Impeller] Make conical gradient work as expected (flutter/engine#42567)
fix https://github.com/flutter/flutter/issues/128012

In many instances (https://github.com/flutter/flutter/issues/128012#issuecomment-1577029031), the current implementation of conical gradient in impeller produces incorrect results. This pull request proposes to migrate the conical gradient algorithm from skia to impeller.

Please see ddf987d2ab/src/sksl/sksl_graphite_frag.sksl (L541-L666)

Test result
![FGcZZRCQZJ](https://github.com/flutter/engine/assets/31977171/4127e73d-81a9-4d3e-8430-cf511367362c)
2023-06-06 03:55:39 +00:00
Matej Knopp
5ef190cc5c [macOS] Force clipping to path when platform view clip rect is rotated (flutter/engine#42539)
Normally when platform view is clipped to a simple rect we rely on
clipping to container layer bounds. However when the clip rect is
rotated the container layer is expanded accordingly and clipping to path
must be used instead.

Fixes https://github.com/flutter/flutter/issues/128175
2023-06-05 18:14:16 -07:00
skia-flutter-autoroll
c4ebcfb931 Roll Skia from 7db361be474b to e8a71c76b88f (4 revisions) (flutter/engine#42582)
https://skia.googlesource.com/skia.git/+log/7db361be474b..e8a71c76b88f

2023-06-05 johnstiles@google.com Remove compound-constructor helper functions from WGSL.
2023-06-05 johnstiles@google.com Remove mat2-to-vec4-cast helper function from WGSL.
2023-06-05 johnstiles@google.com Remove matrix-resize helper functions from WGSL.
2023-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0dbc9230a24f to 3c250b5ab450 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-06 00:06:22 +00:00