This changes Paragraph::Layout to iterate line-by-line through the text.
For each line, Layout scans for word boundaries and adds extra space between
words if the line is justified.
This reverts commit d43d35347594c893687dec7402a525d83f57db10.
Clear regression to the flutter_gallery_ios__transition_perf benchmarks:
* average_frame_build_time_millis: 1.4x
* missed_frame_build_budget_count: 1.2x
No regression seen for other iOS benchmarks (e.g. scrolling).
* Change to new SkFontMgr API
These changes clarify ownership rules and work today. They will be
necessary once SK_SUPPORT_LEGACY_FONTMGR_API goes away.
* Fix spacing
* Formatting
When checking whether render buffer size has changed, apply the device
scale factor used to convert points to pixels to ensure we're not
needlessly re-allocating render buffer storage.
Adds trace + debug log to make this easier to detect in future.
Originally introduced in 2d530daeca438ca24562d290616c0aec5ab76b88, but
rolled back in 0a6e415b60581ef7934032df20401da1fae9ea9f to test whether
it was responsible for regressions to
flutter_gallery_ios__transition_perf benchmarks:
* average_frame_build_time_millis
* missed_frame_build_budget_count
This reverts commit 0d2f0cb64819f7669b6134994a4ba6d7211480fa.
Attempting to roll into the framework causes analysis errors with
mock classes implementing HTTP-related classes previously in dart:io:
[error] Classes can only implement other classes. (packages/flutter_tools/test/base/net_test.dart, line 94, col 41)
[error] Classes can only implement other classes. (packages/flutter_tools/test/base/net_test.dart, line 62, col 33)
[error] Classes can only implement other classes. (packages/flutter_tools/test/base/net_test.dart, line 78, col 40)
[error] Classes can only implement other classes. (packages/flutter_tools/test/src/context.dart, line 249, col 46)
and dartdoc failures:
dartdoc:stdout: [error] Target of URI doesn't exist: 'dart:_http'. at /home/travis/build/flutter/flutter/bin/cache/pkg/sky_engine/lib/io/io.dart, line 206.
- Remove linking of dart_debugger.cc as this is not used
(all debugging is done using the service API, this debugger implementation uses the deprecated dart debugger API)
* Revert "Include _http into sky_engine libraries for analyzer (#4154)"
This reverts commit b930f107c3d6648423c42ed10b54f36a92edcbc8.
It is dependent upon the Dart roll, which breaks the engine.
* Revert "Roll dart to ade37f931e90b0fdb8fe16d6bf6f089545da55b6 (#4151)"
This reverts commit 6f1264fb3e11d25a26bc7c44246110ecb5159011.
This Dart roll breaks the engine build on Travis.
Previously, cases like:
```dart
Color.lerp(const Color(0xFF00FF7F), const Color(0xFF00FFFF), 1.1)
```
...would result in unexpected effects (in this instance, lerping
between these colors with a curve that overshoots would take what
should be a simple animation from pale green to blue and add some
flickering bright green whenever it overshoots).
* Remove padding values in line_heights and glyph_position_x. Each value
in glyph_position_x now represents an actual glyph in the layout.
* Remove code intended to handle extra characters beyond the end of the
last line. The LineBreaker should ensure that the end of the last run
matches the end of the last line.
* Return the upstream/downstream affinity of the cursor position in
GetGlyphPositionAtCoordinate.
* Account for the space at the end of a word wrapped line in
GetGlyphPositionAtCoordinate / GetCoordinatesForGlyphPosition
This reverts commit 2d530daeca438ca24562d290616c0aec5ab76b88 as it looks
like a potential cause of performance benchmark regressions on
https://flutter-dashboard.appspot.com/benchmarks.html:
- flutter_gallery_ios__transition_perf average_frame_build_time_millis
- flutter_gallery_ios__transition_perf missed_frame_build_budget_count
