Ahmed Mohamed Sameh
f07d882efb
Make sure that a PopupMenuItem doesn't crash in 0x0 environment ( #177533 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the PopupMenuItem
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-03 06:40:30 +00:00
Ahmed Mohamed Sameh
50d03ed339
Make sure that a RefreshProgressIndicator doesn't crash in 0x0 enviro… ( #177556 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
RefreshProgressIndicator widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-03 06:36:25 +00:00
Ahmed Mohamed Sameh
902a697692
Make sure that a PopupMenuButton doesn't crash in 0x0 environment ( #177493 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the PopupMenuButton
widget.
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-03 01:25:24 +00:00
Ahmed Mohamed Sameh
4499cf6e89
Make sure that a CircularProgressIndicator doesn't crash in 0x0 envir… ( #177555 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CircularProgressIndicator widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-03 01:21:38 +00:00
Ahmed Mohamed Sameh
518722ab1a
Make sure that a Radio doesn't crash in 0x0 environment ( #177580 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the Radio widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 22:18:03 +00:00
Ahmed Mohamed Sameh
f311a23424
Make sure that a RadioListTile doesn't crash in 0x0 environment ( #177576 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the RadioListTile
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 20:40:50 +00:00
Ahmed Mohamed Sameh
9c056ed84e
Make sure that an ExpandIcon doesn't crash in 0x0 envrionment ( #175042 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the ExpandIcon
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 20:39:35 +00:00
Ahmed Mohamed Sameh
ab479438cf
Make sure that a RangeSlider doesn't crash in 0x0 environment ( #177642 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the RangeSlider
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 20:25:57 +00:00
Ahmed Mohamed Sameh
b0f5cda78e
Make sure that a GridTileBar doesn't crash in 0x0 environment ( #177546 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the GridTileBar
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 20:25:57 +00:00
Ahmed Mohamed Sameh
647ce0c00a
Make sure that a LinearProgressIndicator doesn't crash in 0x0 environ… ( #177553 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
LinearProgressIndicator widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 20:25:56 +00:00
Ahmed Mohamed Sameh
6a3011b4e1
Make sure that a PopupMenuDivider doesn't crash in 0x0 environment ( #177445 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the PopupMenuDivider
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 20:05:34 +00:00
Ahmed Mohamed Sameh
71ac4b2fdb
Make sure that a PaginatedDataTable doesn't crash in 0x0 environment ( #177389 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
PaginatedDataTable widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 20:04:03 +00:00
Ahmed Mohamed Sameh
a52e28e0cd
Make sure that an OutlinedButton doesn't crash in 0x0 environment ( #177340 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the OutlinedButton
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 20:01:55 +00:00
Ahmed Mohamed Sameh
285e6f06ad
Make sure that a MenuAnchor doesn't crash in 0x0 environment ( #176302 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the MenuAnchor
widget.
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 19:59:05 +00:00
Ahmed Mohamed Sameh
604bc866a4
Make sure that a CheckboxListTile doesn't crash in 0x0 environment ( #173151 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the CheckboxListTile
UI control.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 19:57:01 +00:00
Ahmed Mohamed Sameh
93999e1edb
Make sure that an IconButton doesn't crash in 0x0 environment ( #175372 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the IconButton
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 19:55:45 +00:00
Ahmed Mohamed Sameh
95900da253
Make sure that an ElevatedButton doesn't crash in 0x0 environment ( #175006 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the ElevatedButton
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 19:55:45 +00:00
Ahmed Mohamed Sameh
c30e5d4161
Make sure that a FilledButton doesn't crash in 0x0 environment ( #175110 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the FilledButton
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-02 19:54:57 +00:00
Ahmed Mohamed Sameh
46c3f84370
Make sure that a SegmentedButton doesn't crash in 0x0 environment ( #177773 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the SegmentedButton
widget.
2025-11-02 19:53:57 +00:00
Ahmed Mohamed Sameh
15d2e56b4e
Make sure that a SearchBar doesn't crash in 0x0 environment ( #177761 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the SearchBar widget.
2025-11-02 19:52:00 +00:00
Ahmed Mohamed Sameh
5e348fd892
Make sure that a Scaffold doesn't crash in 0x0 environment ( #177722 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the Scaffold widget.
2025-11-02 19:33:46 +00:00
Ahmed Mohamed Sameh
dc7da2b3fe
Make sure that a Scrollbar doesn't crash in 0x0 environment ( #177724 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the Scrollbar widget.
2025-11-02 19:33:46 +00:00
Bui Dai Duong
7efa2aed3c
Colored box optimization ( #176028 ) ( #176073 )
...
This PR fixed visual bug when placing multiple `ColoredBox`s together.
(Fixes #176028 )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-02 18:59:19 +00:00
engine-flutter-autoroll
02d6e8fff6
Roll Fuchsia Linux SDK from qrSMgeeLme59noqy-... to Ynp3qiXocK8WLTjlb... ( #177897 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-02 14:26:29 +00:00
engine-flutter-autoroll
5ff0839f89
Roll Skia from 7a5b34ce9bbf to 25e1e4e96980 (1 revision) ( #177894 )
...
https://skia.googlesource.com/skia.git/+log/7a5b34ce9bbf..25e1e4e96980
2025-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SKP
CIPD package from 537 to 538
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-02 10:53:43 +00:00
engine-flutter-autoroll
677bdc8e09
Roll Skia from 5ed21229cdd9 to 7a5b34ce9bbf (1 revision) ( #177890 )
...
https://skia.googlesource.com/skia.git/+log/5ed21229cdd9..7a5b34ce9bbf
2025-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 93bfb7f59e39 to f618974690bc (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-02 01:56:40 +00:00
Zachary Anderson
590a783995
[engine,build] Fix Fuchsia RBE build ( #177865 )
...
As in the Dart build here:
fc8b3d7927/build/toolchain/fuchsia/fuchsia_toolchain.gni (L24)
2025-11-02 00:05:24 +00:00
Pierre
f234d26926
Clean up links to docs website ( #177792 )
...
- remove link without use (PowerShell version minimum not reached, this
is not mentionned anywhere in Windows installation / troubleshooting
documentation)
- clean up API docs root
- clean up app template links, add `Learn Flutter` link
- update get started links
- replace `flutter.dev/docs` with `docs.flutter.dev`
- fix embedder descriptions
- fix broken API `docs.flutter.io` links
- http → https
- remove `/install` from `/get-started` links
- fix Android Studio link
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Parker Lougheed <parlough@gmail.com>
2025-11-01 18:38:27 +00:00
engine-flutter-autoroll
c567dc33d4
Roll Dart SDK from eceb37860450 to 2d3aa1d5cb9f (1 revision) ( #177885 )
...
https://dart.googlesource.com/sdk.git/+log/eceb37860450..2d3aa1d5cb9f
2025-11-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-88.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-01 17:50:42 +00:00
engine-flutter-autoroll
df70ab759d
Roll Fuchsia Linux SDK from O-OoG6j4wHXd1ThNM... to qrSMgeeLme59noqy-... ( #177881 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-01 12:04:40 +00:00
engine-flutter-autoroll
6696f5ebef
Roll Skia from c5cd862d6fa5 to 5ed21229cdd9 (1 revision) ( #177877 )
...
https://skia.googlesource.com/skia.git/+log/c5cd862d6fa5..5ed21229cdd9
2025-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ca45bb2eb745 to 93bfb7f59e39 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-01 09:07:26 +00:00
Jonathan Gilbert
7b1bafec82
Add support for Visual Studio 2026 ( #177458 )
...
Adds a mapping for Visual Studio 2026 to the `cmakeGenerator` property
used to drive Windows builds, enabling Flutter to be used for
development on a system with Visual Studio 2026 installed and not Visual
Studio 2022 or Visual Studio 2019.
Closes : #176399
Related-To: #93426
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-11-01 06:01:35 +00:00
engine-flutter-autoroll
26100b7d0a
Roll Dart SDK from 1c6960e5cd79 to eceb37860450 (2 revisions) ( #177871 )
...
https://dart.googlesource.com/sdk.git/+log/1c6960e5cd79..eceb37860450
2025-11-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-87.0.dev
2025-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-86.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-01 04:30:28 +00:00
engine-flutter-autoroll
9ef662cefb
Roll Skia from 770b8a835e73 to c5cd862d6fa5 (2 revisions) ( #177864 )
...
https://skia.googlesource.com/skia.git/+log/770b8a835e73..c5cd862d6fa5
2025-10-31
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-31 borenet@google.com [infra] Roll infra repo
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 23:58:28 +00:00
engine-flutter-autoroll
26404ad8ab
Roll Dart SDK from db168d9e7471 to 1c6960e5cd79 (1 revision) ( #177862 )
...
https://dart.googlesource.com/sdk.git/+log/db168d9e7471..1c6960e5cd79
2025-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-85.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 22:53:27 +00:00
Bruno Leroux
be736e19e7
Fix default value for DateRangePickerDialog currentDate ( #177448 )
...
## Description
This PR fixes the default value for `DateRangePickerDialog.currentDate`.
Before this PR, the comment mentions that `currentDate` defaults to
`DateTime.now()` but this is not the case (the value is not
initialised).
After this PR, `currentDate` defaults to `calendarDelegate.now()`.
## Related Issue
Fixes [DateRangePickerDialog crashes when currentDate is
omitted](https://github.com/flutter/flutter/issues/177441 )
## Tests
- Adds 1 test
2025-10-31 22:16:21 +00:00
engine-flutter-autoroll
8c55555d38
Roll Skia from 2cf9a1923078 to 770b8a835e73 (3 revisions) ( #177856 )
...
https://skia.googlesource.com/skia.git/+log/2cf9a1923078..770b8a835e73
2025-10-31 nbilling@google.com trackResource->traceCommandBufferResource
for DawnCommandBuffer/MtlCommandBuffer
2025-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7197b08a9ac7 to ca45bb2eb745 (5 revisions)
2025-10-31 sergiog@microsoft.com [rust png] Move UtilsForFFI.h to
SpanUtils.h in root rust folder
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 21:10:41 +00:00
Gray Mackall
48c77daf85
Re-enable android verified input devicelab test ( #177804 )
...
This was originally landed in
https://github.com/flutter/flutter/pull/140836/
but the pr did not hook it up to ci. It was then removed in
https://github.com/flutter/flutter/pull/162895/
First got the driver test running:
`flutter drive -t lib/main.dart --driver test_driver/main_test.dart`
from the directory of the test app
then got the devicelab harness working via
`../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t
android_verified_input_test` from the `dev/devicelab` directory
and then finally hooked up to ci with the configuration in the
`.ci.yaml`
Restoring in a passing state, in advance of landing
https://github.com/flutter/flutter/pull/177572/
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-10-31 19:40:14 +00:00
engine-flutter-autoroll
027f2e4102
Roll Dart SDK from bb45c4186fb2 to db168d9e7471 (1 revision) ( #177839 )
...
https://dart.googlesource.com/sdk.git/+log/bb45c4186fb2..db168d9e7471
2025-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-84.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 17:16:17 +00:00
Loïc Sharma
5c42d7af92
Hide "waiting for customer" issues from text input triage ( #177524 )
...
This better aligns with other team's triage queries.
2025-10-31 16:14:25 +00:00
Matthew Kosarek
de56adb817
Making the multiple_windows example app demonstrate dialogs of dialogs ( #177786 )
...
## What's new?
- Users can now create a dialog whose parent is a dialog in the example
app
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-10-31 15:54:05 +00:00
Bruno Leroux
46b6f40982
Fix ElevatedButton.icon breaks focus traversal and VoiceOver when toggling icon ( #177579 )
...
## Description
This PR changes `ElevatedButton.icon` to avoid building a different
widget. When a different widget is created the whole subtree is
recreated which leads to various issues (Focus and A11y issues for
instance).
The change is similar to https://github.com/flutter/flutter/pull/175810
which fixed the exact same problem for `OutlinedButton.icon`.
## Related Issue
[TextButton.icon breaks focus traversal and ink effect when toggling
icon](https://github.com/flutter/flutter/issues/173944 )
[Voiceover focus traversal breaks if a button's state changes to include
an icon](https://github.com/flutter/flutter/pull/175810 )
## Tests
- Adds 2 tests
2025-10-31 15:01:19 +00:00
Bruno Leroux
46733c69fb
Fix FilledButton.icon and FilledButton.tonalIcon break focus traversal and VoiceOver ( #177593 )
...
## Description
This PR changes `FilledButton.icon` and `FilledButton.tonalIcon` to
avoid building a different widget. When a different widget is created
the whole subtree is recreated which leads to various issues (Focus and
A11y issues for instance).
The change is similar to https://github.com/flutter/flutter/pull/175810
which fixed the exact same problem for `OutlinedButton.icon`.
## Related Issue
[TextButton.icon breaks focus traversal and ink effect when toggling
icon](https://github.com/flutter/flutter/issues/173944 )
[Voiceover focus traversal breaks if a button's state changes to include
an icon](https://github.com/flutter/flutter/pull/175810 )
## Tests
- Adds 4 tests
2025-10-31 13:06:24 +00:00
ColdPaleLight
290d0f87a9
Fix cubic subdivision estimation using correct Wang’s formula ( #177758 )
...
Replaced the incorrect Abs()/Max() operations with squared magnitude
checks via dot products
2025-10-31 10:52:25 +00:00
engine-flutter-autoroll
1ac7b01ae3
Roll Skia from ccbd7697791f to 2cf9a1923078 (1 revision) ( #177832 )
...
https://skia.googlesource.com/skia.git/+log/ccbd7697791f..2cf9a1923078
2025-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from d763609022a4 to 7934556e26c1 (10 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 10:16:25 +00:00
engine-flutter-autoroll
fdcc55acfc
Roll Fuchsia Linux SDK from ksXeDDo2yYBXJ4uEu... to O-OoG6j4wHXd1ThNM... ( #177831 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 09:58:15 +00:00
engine-flutter-autoroll
a30979034d
Roll Skia from 1532fabb4b7d to ccbd7697791f (4 revisions) ( #177828 )
...
https://skia.googlesource.com/skia.git/+log/1532fabb4b7d..ccbd7697791f
2025-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 0b3b8a8cbc26 to e13d18f9806c (5 revisions)
2025-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 4e1fe2e715a8 to 7197b08a9ac7 (11 revisions)
2025-10-31
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 07:56:36 +00:00
engine-flutter-autoroll
d1660b722f
Roll Dart SDK from cf24b43cb643 to bb45c4186fb2 (2 revisions) ( #177824 )
...
https://dart.googlesource.com/sdk.git/+log/cf24b43cb643..bb45c4186fb2
2025-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-83.0.dev
2025-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-82.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 06:26:28 +00:00
engine-flutter-autoroll
6af38a904a
Roll Skia from 825d5c854302 to 1532fabb4b7d (3 revisions) ( #177808 )
...
https://skia.googlesource.com/skia.git/+log/825d5c854302..1532fabb4b7d
2025-10-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 00:48:25 +00:00
engine-flutter-autoroll
7518b6b884
Roll Dart SDK from da663596bf6d to cf24b43cb643 (2 revisions) ( #177798 )
...
https://dart.googlesource.com/sdk.git/+log/da663596bf6d..cf24b43cb643
2025-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-81.0.dev
2025-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-80.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-30 23:00:24 +00:00
