DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,030 Commits 882 Branches 1,069 Tags
Commit Graph

24308 Commits

Author SHA1 Message Date
Kevin Lubick
efc265b5e9 Fix forward declare and some deprecated enums (flutter/engine#46882) 
There was a compile error when trying to roll in
http://review.skia.org/764970, and this addresses that.

While I was here, I noticed some uses of the old-named `GrBackend` enum
and updated it to the non-deprecated enum class.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-13 10:56:27 -04:00
skia-flutter-autoroll
339526485c Roll Skia from c640eeed2695 to e566db061ce8 (1 revision) (flutter/engine#46881) 
https://skia.googlesource.com/skia.git/+log/c640eeed2695..e566db061ce8

2023-10-13 michaelludwig@google.com [skif] Skip auto saveLayer for most drawImageRect() calls

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 14:51:06 +00:00
Kevin Lubick
a6761a95ea Update to use GrDirectContexts::MakeVulkan (flutter/engine#46878) 
In http://review.skia.org/764516, Skia moved the way to make a Vulkan
context. This updates Flutter to use that new way.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-13 10:41:25 -04:00
Zachary Anderson
7922a335e8 Don't use objcopy to embed Android icudtl (flutter/engine#46862) 
When objcopy is used to embed data into a linkable object file, that
object file will only have default bits set in its header for ABI etc..
If the linker doesn't cooperate by ignoring ABI mismatches on object
files without code, then linking will fail. This PR stops using objcopy
to create an object file that embeds icudtl.dat into the Android
embedder, and instead uses the `bin_to_assembly.py` script that we're
already using for Dart VM snapshot data.

Context in https://github.com/llvm/llvm-project/issues/68915
 2023-10-13 07:33:24 -07:00
skia-flutter-autoroll
a6abdb4565 Roll Dart SDK from 54ef02480719 to 95e2ecee106a (1 revision) (flutter/engine#46877) 
https://dart.googlesource.com/sdk.git/+log/54ef02480719..95e2ecee106a

2023-10-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-23.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 13:33:06 +00:00
skia-flutter-autoroll
6d31e5591a Roll Fuchsia Linux SDK from QLiomHC9D-GWh_gyK... to pI1BVH08V0eG0M7sw... (flutter/engine#46867) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 06:29:52 +00:00
skia-flutter-autoroll
8cbb338d74 Roll Skia from bf557aeaaef8 to aee708412bec (1 revision) (flutter/engine#46865) 
https://skia.googlesource.com/skia.git/+log/bf557aeaaef8..aee708412bec

2023-10-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 7ab058e00df4 to 77ae6a2042d8 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 05:35:05 +00:00
Zachary Anderson
35f53fe500 Revert "Remove the frontend server wrapper" (flutter/engine#46863) 
Reverts flutter/engine#46440

For b/305121780
 2023-10-12 20:42:35 -07:00
skia-flutter-autoroll
2f8358efe4 Roll Dart SDK from 34c06f0bcb29 to b0d65ad14354 (3 revisions) (flutter/engine#46859) 
https://dart.googlesource.com/sdk.git/+log/34c06f0bcb29..b0d65ad14354

2023-10-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-19.0.dev
2023-10-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-18.0.dev
2023-10-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-17.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 00:48:21 +00:00
Jason Simmons
e7da0b1c5a Temporarily remove the runs of the engine Dart tests with Impeller enabled (flutter/engine#46854) 
These tests are sometimes hanging when the flutter_tester deletes the ContextVK and ConcurrentMessageLoop during shutdown.
 2023-10-12 23:47:08 +00:00
skia-flutter-autoroll
9d63adb09b Roll Skia from 8b110fd65de9 to bf557aeaaef8 (1 revision) (flutter/engine#46853) 
https://skia.googlesource.com/skia.git/+log/8b110fd65de9..bf557aeaaef8

2023-10-12 michaelludwig@google.com Revert "[graphite] Use hardware image tiling when not subsetting"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 21:21:07 +00:00
Emircan Uysaler
218a4e9870 [fuchsia] Add fatal error for Vulkan failure (flutter/engine#46831) 
This CL changes vkWaitForFences to cause a FATAL failure as we can't
recover from these errors.

Bug: b/297198565
 2023-10-12 17:11:14 -04:00
Mouad Debbar
5c9deddce2 [web] Stop using flutterViewEmbedder for platform views (flutter/engine#46046) 
As of right now, there is an indirect link between `flutter/platform_views` messages and `flutterViewEmbedder`, expressed by the callback that's being passed to the `PlatformViewMessageHandler`.

This PR proposed making this relationship clear between `flutter/platform_views` and `implicitView` (i.e. the singleton `window`).

This PR also opens the path for each view to have its own `PlatformViewMessageHandler` instance.

Depends on https://github.com/flutter/engine/pull/46044

Part of https://github.com/flutter/flutter/issues/134443
 2023-10-12 21:05:41 +00:00
skia-flutter-autoroll
4290e9a9c7 Roll Skia from fdcbbc4d5c25 to 222fe6b9b0eb (2 revisions) (flutter/engine#46849) 
https://skia.googlesource.com/skia.git/+log/fdcbbc4d5c25..222fe6b9b0eb

2023-10-12 bungeman@google.com Reland "[pdf] Simplify filled paths"
2023-10-12 kjlubick@google.com [bazel] Update taskdrvier used for BazelBuild

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 19:52:15 +00:00
skia-flutter-autoroll
a800992dc8 Roll Skia from 1d134a8f3ae2 to fdcbbc4d5c25 (7 revisions) (flutter/engine#46844) 
https://skia.googlesource.com/skia.git/+log/1d134a8f3ae2..fdcbbc4d5c25

2023-10-12 kjlubick@google.com Fix missing filegroup in opts:legacy_hsw
2023-10-12 jvanverth@google.com [graphite] Add multitexture support to RasterPathAtlas
2023-10-12 johnstiles@google.com Fix inlining of calls with unused inout params.
2023-10-12 kjlubick@google.com Add empty filegroups to appease G3
2023-10-12 michaelludwig@google.com [skif] Use content bounds for leaf input layer sizing
2023-10-12 jamesgk@google.com [graphite] Use hardware image tiling when not subsetting
2023-10-12 kjlubick@google.com Deploy CanvasKit 0.39.1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 18:41:59 +00:00
Chinmay Garde
d54a923ca4 [Impeller] Specify default border color for texture wrap mode that clamps. (flutter/engine#46806) 
Fixes https://github.com/flutter/flutter/issues/136153
 2023-10-12 18:19:35 +00:00
skia-flutter-autoroll
6005e6a0f6 Roll Fuchsia Linux SDK from giQtXxdSj6NdIViCw... to QLiomHC9D-GWh_gyK... (flutter/engine#46838) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 17:41:56 +00:00
Zachary Anderson
23b6f6116f Remove the frontend server wrapper (flutter/engine#46440) 
Instead, this PR copies the frontend server from the Dart SDK (whether prebuilt or not) into the location expected by internal engine tests and artifact construction. This PR also consolidates the three GN templates that invoked the frontend server down to one.

Framework presubs: https://github.com/flutter/flutter/pull/135836

Related: https://github.com/flutter/flutter/issues/60007
 2023-10-12 15:40:50 +00:00
skia-flutter-autoroll
374c7243f8 Roll Skia from 2dd1579c6921 to 1d134a8f3ae2 (5 revisions) (flutter/engine#46824) 
https://skia.googlesource.com/skia.git/+log/2dd1579c6921..1d134a8f3ae2

2023-10-12 kjlubick@google.com Remove 4 files from include/private/gpu/ganesh
2023-10-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ea332c715575 to 24dabdbbeee2 (5 revisions)
2023-10-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from baab66a8258b to 37653f7c343e (12 revisions)
2023-10-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 7ab058e00df4 to a1666bf633a8
2023-10-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ab3b6d0185b0 to 7ab058e00df4 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 12:53:07 +00:00
skia-flutter-autoroll
da39704579 Roll Dart SDK from db2465f106ad to 9afac395dfb1 (1 revision) (flutter/engine#46812) 
https://dart.googlesource.com/sdk.git/+log/db2465f106ad..9afac395dfb1

2023-10-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-15.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 05:54:24 +00:00
skia-flutter-autoroll
8ae9fb5d92 Roll Fuchsia Linux SDK from hMA99PoacaRZVXHgr... to giQtXxdSj6NdIViCw... (flutter/engine#46811) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 04:46:25 +00:00
skia-flutter-autoroll
a8e99c22a9 Roll Skia from ff3c2e3d45bd to 9f5080c58aac (1 revision) (flutter/engine#46809) 
https://skia.googlesource.com/skia.git/+log/ff3c2e3d45bd..9f5080c58aac

2023-10-12 bungeman@google.com [pathops] Remove SK_IGNORE_PATHOPS_SIMPLIFY_TRIVIAL_FIX

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 03:31:13 +00:00
skia-flutter-autoroll
cb0aa5396d Roll Skia from 924df8d87766 to ff3c2e3d45bd (1 revision) (flutter/engine#46807) 
https://skia.googlesource.com/skia.git/+log/924df8d87766..ff3c2e3d45bd

2023-10-12 jamesgk@google.com [graphite] Track image size uniforms separately from proxies

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 02:03:20 +00:00
skia-flutter-autoroll
79a02292fb Roll Dart SDK from 0732be6b823a to db2465f106ad (8 revisions) (flutter/engine#46797) 
https://dart.googlesource.com/sdk.git/+log/0732be6b823a..db2465f106ad

2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-14.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-13.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-12.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-11.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-10.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-9.0.dev
2023-10-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-8.0.dev
2023-10-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-7.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 22:43:38 +00:00
Brandon DeRosier
a91d13dd87 [Impeller] Use triangle strips to dedupe rectangle vertices. (flutter/engine#46610) 
Remove a couple of duplicate verts in a bunch of situations.

Pedantic improvements: "Brandon, why are you like this" edition.
 2023-10-11 15:42:10 -07:00
skia-flutter-autoroll
b064072eef Roll Skia from 2459d71707e0 to 924df8d87766 (7 revisions) (flutter/engine#46798) 
https://skia.googlesource.com/skia.git/+log/2459d71707e0..924df8d87766

2023-10-11 robertphillips@google.com [graphite] Add PipelineDataGatherer to the precompilation path
2023-10-11 johnstiles@google.com Fix comment.
2023-10-11 kjlubick@google.com Minor fixes for buffet build
2023-10-11 lovisolo@google.com Reland "[bazel] Move test runners under //tools/testrunners.".
2023-10-11 egdaniel@google.com When waiting on client provided semaphores, only block fragment stage work.
2023-10-11 johnstiles@google.com Disallow layout(builtin=xxx) in non-module code.
2023-10-11 kjlubick@google.com Deploy CanvasKit 0.39.0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 22:40:52 +00:00
Jason Simmons
9f6f5d03cf Run the binary size treemap script from the buildroot directory (flutter/engine#46740) 
This will produce a treemap where navigation starts from the buildroot
and the flutter and third_party source directories are shown as
siblings.
 2023-10-11 15:18:39 -07:00
Dan Field
1e318d57d4 [Impeller] flutter_tester --enable-impeller (flutter/engine#46389) 
This patch does the following:

- Updates `flutter_tester` to set up an Impeller rendering context and surface if `--enable-impeller` is set to true, using the Vulkan backend with Swiftshader.
- Updates `run_tests.py` to run all tests except the smoke test (that one really has no rendering impact whatsoever) with and without `--enable-impeller`.
- Updates a few tests to work that were trivial:
  - A couple tests needed updated goldens for very minor rendering differences. Filed https://github.com/flutter/flutter/issues/135684 to track using Skia gold for this instead.
  - Disabled SKP screenshotting if Impeller is enabled, and updated the test checking that to verify an error is thrown if an SKP is requested.
  - The Dart GPU based test now asserts that the gpu context is available if Impeller is enabled, and does not deadlock if run in a single threaded mode.
  - We were missing some trace events around `Canvas::SaveLayer` for Impeller as compared to Skia.
  - A couple other tests had strict checks about exception messages that are slightly different between Skia and Impeller.
- I've filed bugs for other tests that may require a little more work, and skipped them for now. For FragmentProgram on Vulkan I reused an existing bug.

This is part of my attempt to address https://github.com/flutter/flutter/issues/135693, although @chinmaygarde and I had slightly different ideas about how to do this.

The goals here are:

- Run the Dart unit tests we already have with Impeller enabled.
- Enable running more of the framework tests (including gold tests) with Impeller enabled.
- Run all of these tests via public `dart:ui` API rather than mucking around in C++ internals in the engine.
 2023-10-11 21:42:24 +00:00
Jackson Gardner
99de03845c Switch to Chrome For Testing instead of Chromium (flutter/engine#46683) 
This switches over to using Chrome for Testing instead of Chromium. This requires some changes from the recipes repo (https://flutter-review.googlesource.com/c/recipes/+/51482) in order to coordinate the change in filestructure on the mac versions.
 2023-10-11 21:24:11 +00:00
Gray Mackall
0d5c0a660f Revert "[Android] Add support for text processing actions (#44579)" (flutter/engine#46788) 
This reverts commit 01345c3ce8c06f09625ea2e1a971187e7ed9c049.

This change is causing integration tests to fail on attempts to roll the latest master version of flutter into the packages repo.

See a sample failure here: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8767521956894285553/+/u/Run_package_tests/native_integration_tests/stdout

The root cause seems to be that we are getting request codes in `onActivityResult` that we never added to the `requestsByCode` map, so the call to remove returns null (and we then call success getting a NPE).

More info: 
1. There is a [discussion in discord here](https://discord.com/channels/608014603317936148/1161718667566919761/1161721935927980052)
2. And the failure can be reproduced by running `dart run script/tool/bin/flutter_plugin_tools.dart native-test --android --packages file_selector` from the root of the packages repo (with a flutter checkout that contains these changes).

cc @bleroux 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-11 20:49:51 +00:00
Daniel Chevalier
94df47fedc [web] Adds Noto Music fallback font (flutter/engine#46720) 
Adds `Noto Music` font as a fallback font, and updates DEPS and font definitions after running the font roller script.

### Issues

Fixes: https://github.com/flutter/devtools/issues/6149

----

![](https://media.giphy.com/media/3ohzAv6kdQ4tukSNK8/giphy-downsized.gif)

I used [the developer API](https://developers.google.com/fonts/docs/developer_api?apix_params=%7B%22family%22%3A%5B%22Noto%20Music%22%5D%7D) to make sure the api works with this font.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-11 20:46:16 +00:00
Jason Simmons
3dcce9d779 Fix some image_external_texture entries in the license golden file (flutter/engine#46790) 2023-10-11 13:31:39 -07:00
John McCutchan
3bd2efe1d3 Rename HardwareBufferExternalTexture* to ImageExternalTexture* (flutter/engine#46786) 
Image is the more accurate name and we will eventually have a
HardwareBufferExternalTexture in the future (see
https://developer.android.com/reference/android/graphics/HardwareBufferRenderer
available on Android >= 34).
 2023-10-11 12:35:36 -07:00
John McCutchan
da447b9297 Fix 303652511 and add a regression test (flutter/engine#46743) 
Fixes internal bug b/303652511 and includes a regression test.

The TL;DR of the bug is that when re-launching a singleton-cached-engine
Flutter activity using FLAG_ACTIVITY_CLEAR_TASK, the teardown of the
previous Flutter activity interleaves with the creation of the new
Flutter activity, resulting in the Flutter engine ending up incorrectly
in the AppLifecycleState.detached state. This then results in the app
being completely unresponsive because Flutter doesn't draw frames in
this state. I don't know if the issue is reproducible in production
under normal user operation, but I'm concerned it very easily could be.
There's also nothing stopping other apps or Android system code from
launching an app using this flag.
 2023-10-11 11:29:04 -07:00
skia-flutter-autoroll
dc0c2f4503 Roll Skia from bfd9af01b785 to 6cc9f73ea54e (1 revision) (flutter/engine#46784) 
https://skia.googlesource.com/skia.git/+log/bfd9af01b785..6cc9f73ea54e

2023-10-11 johnstiles@google.com Avoid symbol-shadowing when inlining functions.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 18:21:49 +00:00
Brandon DeRosier
739db9f5b5 [Impeller] Avoid invalid GL depth calls on macOS desktop. (flutter/engine#46758) 
The macOS desktop driver doesn't support ES profiles, and
`glClearDepthf` + `glDepthRangef` are throwing `GL_INVALID_OPERATION`
and doing nothing. Noticed this while updating impeller-cmake past
@matanlurey's recent changes to make `GL_INVALID_OPERATION` fatal.
Impeller-cmake-example uses a depth buffer, whereas Impeller's 2D
renderer currently does not.

Added a follow-up bug to make these calls work on macOS desktop:
https://github.com/flutter/flutter/issues/136322.
Both Impeller Scene and the impeller-cmake-example currently just rely
on the default state for clearing depth.
 2023-10-11 10:47:51 -07:00
Zachary Anderson
0a20e6f0f6 Roll goldctl forward (flutter/engine#46771) 
For https://github.com/flutter/flutter/issues/135620
 2023-10-11 16:10:05 +00:00
skia-flutter-autoroll
0cff2cdf88 Roll Skia from 60d51fd2c6bd to bfd9af01b785 (2 revisions) (flutter/engine#46774) 
https://skia.googlesource.com/skia.git/+log/60d51fd2c6bd..bfd9af01b785

2023-10-11 johnstiles@google.com Revert "[bazel] Move test runners under //tools/testrunners."
2023-10-11 jvanverth@google.com [graphite] Move RasterPathAtlas into AtlasProvider.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 16:02:00 +00:00
skia-flutter-autoroll
f6855a9d3e Roll Skia from c05effecb081 to 60d51fd2c6bd (3 revisions) (flutter/engine#46772) 
https://skia.googlesource.com/skia.git/+log/c05effecb081..60d51fd2c6bd

2023-10-11 jvanverth@google.com [graphite] Fix bugs in RasterPathAtlas caching.
2023-10-11 kjlubick@google.com Annotate third_party imports
2023-10-11 bclayton@chromium.org [tint][gn] Disable GLSL validation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 15:17:47 +00:00
skia-flutter-autoroll
fc4a70902e Roll Fuchsia Linux SDK from FX5YzwP_ZEnPP0b3v... to hMA99PoacaRZVXHgr... (flutter/engine#46762) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 09:44:17 +00:00
Bruno Leroux
01345c3ce8 [Android] Add support for text processing actions (flutter/engine#44579) 
## Description

This Android related PR adds a channel buffer and a plugin to interact with Android 'process text' feature. It makes it possible to query text processing actions and to run those actions (for instance 'calling' Google translate).
Text actions that outputs a processed text are supported.

The implementation is based on the great sample provided by @gualse , see https://github.com/flutter/flutter/issues/107603#issuecomment-1646629158. 

In order to return a non empty list of text actions, the implementation will require adding a section to the Android manifest file (see https://github.com/flutter/flutter/issues/107603#issuecomment-1683487087).
Adding this section automatically to new or existing Flutter apps is not part of this PR but will be tackled in a future PR.

## Related Issue

Android engine side for https://github.com/flutter/flutter/issues/107603

## Tests

Adds 3 tests.
 2023-10-11 09:33:00 +00:00
skia-flutter-autoroll
95538e3760 Roll Skia from 4935bed4260d to 11e41e0e2f9f (3 revisions) (flutter/engine#46759) 
https://skia.googlesource.com/skia.git/+log/4935bed4260d..11e41e0e2f9f

2023-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from ab3b6d0185b0 to bed7bfb7376c
2023-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 457fc7591f3c to bd2d26113aa7 (10 revisions)
2023-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f9f3328bcef8 to ab3b6d0185b0 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 06:13:22 +00:00
Brandon DeRosier
3e50aae2f7 [Impeller] Allow pipeline variant sets to have differing defaults. (flutter/engine#46751) 
Track default prototype options along side pipeline variant sets, allowing differing defaults to be assigned during ContentContext construction.
 2023-10-11 02:22:10 +00:00
Matan Lurey
2b54d1a9e6 Remove support for Paint.enableDithering=false in dart:ui. (flutter/engine#46745) 
Work towards https://github.com/flutter/flutter/issues/112498.

No behavioral changes to existing code, except `Paint.enableDithering = false` will no longer be an option.
 2023-10-11 01:24:16 +00:00
Chris Bracken
ee313fa40f Move //third_party/glfw to //flutter/third_party/glfw (flutter/engine#46733) 
As part of eliminating the Flutter buildroot (#67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

This is the engine-side follow-up to flutter/buildroot#777.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

Issue: https://github.com/flutter/flutter/issues/136284

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.
 2023-10-10 18:21:54 -07:00
skia-flutter-autoroll
e433db253c Roll Skia from 06145491fd17 to 4935bed4260d (3 revisions) (flutter/engine#46748) 
https://skia.googlesource.com/skia.git/+log/06145491fd17..4935bed4260d

2023-10-11 lovisolo@google.com [bazel] Move test runners under //tools/testrunners.
2023-10-10 vigneshv@google.com SkAvifCodec: Do not use libavif internal headers
2023-10-10 johnstiles@google.com Move SwizzleComponent::Type into Swizzle header.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 00:58:16 +00:00
Brandon DeRosier
e8e13de094 [Impeller] Guard calls to extension proc DebugMessageControlKHR. (flutter/engine#46747) 
Quick fix to unblock the `impeller-cmake-example` build. Calls to ES3 and extension procs need to be guarded.
 2023-10-11 00:53:33 +00:00
Jonah Williams
e76a91f169 [Impeller] log specific framebuffer incomplete error. (flutter/engine#46692) 
This is much easier to debug if we know the actual error code.
 2023-10-10 23:04:13 +00:00
Brandon DeRosier
30fe68f402 [Impeller] Don't cull readbacks outside the damage rect. (flutter/engine#46705) 
Resolves https://github.com/flutter/flutter/issues/136058.

The damage rect properly expands to include the backdrop filter readback area to a certain extent, but it suddenly gets excluded once it no longer partially overlaps with the damage rect. This caused the illusion of EntityPass improperly culling the backdrop entity, leading me into a bit of a wild goose chase.

Before:

https://github.com/flutter/engine/assets/919017/94b8c077-0945-4a2c-96e0-27230d980c38

After:

https://github.com/flutter/engine/assets/919017/f1c78365-6e9b-46cb-9e69-33472d488831
 2023-10-10 20:55:05 +00:00
John McCutchan
d9469ed169 Fix high FPS screen flicker of Platform Views when using ImageReaderPlatformViewRenderTarget (flutter/engine#46724) 
The root bug (b/300627634) was that we were holding onto HardwareBuffers
after the owning Image was closed. This CL refactors the C++ code to
properly hold a reference to the Image until it is safe to dispose of.

This CL also refactors the Impeller GL and Skia GL code paths to share
more code.
 2023-10-10 13:36:56 -07:00