DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,030 Commits 882 Branches 1,069 Tags
Commit Graph

32030 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kevin Lubick
efc265b5e9 Fix forward declare and some deprecated enums (flutter/engine#46882) 
There was a compile error when trying to roll in
http://review.skia.org/764970, and this addresses that.

While I was here, I noticed some uses of the old-named `GrBackend` enum
and updated it to the non-deprecated enum class.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-13 10:56:27 -04:00
skia-flutter-autoroll
339526485c Roll Skia from c640eeed2695 to e566db061ce8 (1 revision) (flutter/engine#46881) 
https://skia.googlesource.com/skia.git/+log/c640eeed2695..e566db061ce8

2023-10-13 michaelludwig@google.com [skif] Skip auto saveLayer for most drawImageRect() calls

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 14:51:06 +00:00
Kevin Lubick
a6761a95ea Update to use GrDirectContexts::MakeVulkan (flutter/engine#46878) 
In http://review.skia.org/764516, Skia moved the way to make a Vulkan
context. This updates Flutter to use that new way.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-13 10:41:25 -04:00
Zachary Anderson
7922a335e8 Don't use objcopy to embed Android icudtl (flutter/engine#46862) 
When objcopy is used to embed data into a linkable object file, that
object file will only have default bits set in its header for ABI etc..
If the linker doesn't cooperate by ignoring ABI mismatches on object
files without code, then linking will fail. This PR stops using objcopy
to create an object file that embeds icudtl.dat into the Android
embedder, and instead uses the `bin_to_assembly.py` script that we're
already using for Dart VM snapshot data.

Context in https://github.com/llvm/llvm-project/issues/68915
 2023-10-13 07:33:24 -07:00
skia-flutter-autoroll
a6abdb4565 Roll Dart SDK from 54ef02480719 to 95e2ecee106a (1 revision) (flutter/engine#46877) 
https://dart.googlesource.com/sdk.git/+log/54ef02480719..95e2ecee106a

2023-10-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-23.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 13:33:06 +00:00
skia-flutter-autoroll
f008495a75 Roll Skia from f27c0f222320 to c640eeed2695 (1 revision) (flutter/engine#46874) 
https://skia.googlesource.com/skia.git/+log/f27c0f222320..c640eeed2695

2023-10-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2fd751b2af6e to e96a768f1028 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 12:06:05 +00:00
skia-flutter-autoroll
314f8f170c Roll ICU from 995db880cff2 to a622de35ac31 (1 revision) (flutter/engine#46873) 
995db880cf..a622de35ac

2023-10-11 dayeung@chromium.org Revert fetching tz names with realpath.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter-engine
Please CC jsimmons@google.com,tq-i18n-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 11:51:21 +00:00
skia-flutter-autoroll
f25039def9 Roll Dart SDK from 849253fd69b6 to 54ef02480719 (2 revisions) (flutter/engine#46871) 
https://dart.googlesource.com/sdk.git/+log/849253fd69b6..54ef02480719

2023-10-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-22.0.dev
2023-10-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-21.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 09:24:25 +00:00
skia-flutter-autoroll
5660426024 Roll Fuchsia Mac SDK from XnH2CtqEH7byTHna7... to SDPa6SfaKvRRSUCij... (flutter/engine#46868) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 07:29:05 +00:00
skia-flutter-autoroll
ed6685cc7e Roll Skia from faad330e7120 to f27c0f222320 (1 revision) (flutter/engine#46869) 
https://skia.googlesource.com/skia.git/+log/faad330e7120..f27c0f222320

2023-10-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 24dabdbbeee2 to 5b7763f9d427 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 07:16:54 +00:00
skia-flutter-autoroll
6d31e5591a Roll Fuchsia Linux SDK from QLiomHC9D-GWh_gyK... to pI1BVH08V0eG0M7sw... (flutter/engine#46867) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 06:29:52 +00:00
skia-flutter-autoroll
1f34e6e2ea Roll Skia from aee708412bec to faad330e7120 (1 revision) (flutter/engine#46866) 
https://skia.googlesource.com/skia.git/+log/aee708412bec..faad330e7120

2023-10-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 77ae6a2042d8 to ce6d56ef3f03

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 06:18:53 +00:00
skia-flutter-autoroll
8cbb338d74 Roll Skia from bf557aeaaef8 to aee708412bec (1 revision) (flutter/engine#46865) 
https://skia.googlesource.com/skia.git/+log/bf557aeaaef8..aee708412bec

2023-10-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 7ab058e00df4 to 77ae6a2042d8 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 05:35:05 +00:00
skia-flutter-autoroll
a17f548d98 Roll Dart SDK from b0d65ad14354 to 849253fd69b6 (1 revision) (flutter/engine#46864) 
https://dart.googlesource.com/sdk.git/+log/b0d65ad14354..849253fd69b6

2023-10-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-20.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 04:27:18 +00:00
Zachary Anderson
35f53fe500 Revert "Remove the frontend server wrapper" (flutter/engine#46863) 
Reverts flutter/engine#46440

For b/305121780
 2023-10-12 20:42:35 -07:00
skia-flutter-autoroll
2f8358efe4 Roll Dart SDK from 34c06f0bcb29 to b0d65ad14354 (3 revisions) (flutter/engine#46859) 
https://dart.googlesource.com/sdk.git/+log/34c06f0bcb29..b0d65ad14354

2023-10-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-19.0.dev
2023-10-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-18.0.dev
2023-10-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-17.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 00:48:21 +00:00
Jason Simmons
e7da0b1c5a Temporarily remove the runs of the engine Dart tests with Impeller enabled (flutter/engine#46854) 
These tests are sometimes hanging when the flutter_tester deletes the ContextVK and ConcurrentMessageLoop during shutdown.
 2023-10-12 23:47:08 +00:00
skia-flutter-autoroll
9d63adb09b Roll Skia from 8b110fd65de9 to bf557aeaaef8 (1 revision) (flutter/engine#46853) 
https://skia.googlesource.com/skia.git/+log/8b110fd65de9..bf557aeaaef8

2023-10-12 michaelludwig@google.com Revert "[graphite] Use hardware image tiling when not subsetting"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 21:21:07 +00:00
Emircan Uysaler
218a4e9870 [fuchsia] Add fatal error for Vulkan failure (flutter/engine#46831) 
This CL changes vkWaitForFences to cause a FATAL failure as we can't
recover from these errors.

Bug: b/297198565
 2023-10-12 17:11:14 -04:00
Mouad Debbar
5c9deddce2 [web] Stop using flutterViewEmbedder for platform views (flutter/engine#46046) 
As of right now, there is an indirect link between `flutter/platform_views` messages and `flutterViewEmbedder`, expressed by the callback that's being passed to the `PlatformViewMessageHandler`.

This PR proposed making this relationship clear between `flutter/platform_views` and `implicitView` (i.e. the singleton `window`).

This PR also opens the path for each view to have its own `PlatformViewMessageHandler` instance.

Depends on https://github.com/flutter/engine/pull/46044

Part of https://github.com/flutter/flutter/issues/134443
 2023-10-12 21:05:41 +00:00
skia-flutter-autoroll
a819a56b1c Roll Skia from 222fe6b9b0eb to 8b110fd65de9 (1 revision) (flutter/engine#46852) 
https://skia.googlesource.com/skia.git/+log/222fe6b9b0eb..8b110fd65de9

2023-10-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 37653f7c343e to 2fd751b2af6e (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 20:30:56 +00:00
skia-flutter-autoroll
4290e9a9c7 Roll Skia from fdcbbc4d5c25 to 222fe6b9b0eb (2 revisions) (flutter/engine#46849) 
https://skia.googlesource.com/skia.git/+log/fdcbbc4d5c25..222fe6b9b0eb

2023-10-12 bungeman@google.com Reland "[pdf] Simplify filled paths"
2023-10-12 kjlubick@google.com [bazel] Update taskdrvier used for BazelBuild

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 19:52:15 +00:00
skia-flutter-autoroll
a800992dc8 Roll Skia from 1d134a8f3ae2 to fdcbbc4d5c25 (7 revisions) (flutter/engine#46844) 
https://skia.googlesource.com/skia.git/+log/1d134a8f3ae2..fdcbbc4d5c25

2023-10-12 kjlubick@google.com Fix missing filegroup in opts:legacy_hsw
2023-10-12 jvanverth@google.com [graphite] Add multitexture support to RasterPathAtlas
2023-10-12 johnstiles@google.com Fix inlining of calls with unused inout params.
2023-10-12 kjlubick@google.com Add empty filegroups to appease G3
2023-10-12 michaelludwig@google.com [skif] Use content bounds for leaf input layer sizing
2023-10-12 jamesgk@google.com [graphite] Use hardware image tiling when not subsetting
2023-10-12 kjlubick@google.com Deploy CanvasKit 0.39.1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 18:41:59 +00:00
skia-flutter-autoroll
0fe3238759 Roll Fuchsia Mac SDK from 8AXhoo-MMME8NMKt0... to XnH2CtqEH7byTHna7... (flutter/engine#46843) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 18:34:58 +00:00
Chinmay Garde
d54a923ca4 [Impeller] Specify default border color for texture wrap mode that clamps. (flutter/engine#46806) 
Fixes https://github.com/flutter/flutter/issues/136153
 2023-10-12 18:19:35 +00:00
skia-flutter-autoroll
6005e6a0f6 Roll Fuchsia Linux SDK from giQtXxdSj6NdIViCw... to QLiomHC9D-GWh_gyK... (flutter/engine#46838) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 17:41:56 +00:00
Zachary Anderson
23b6f6116f Remove the frontend server wrapper (flutter/engine#46440) 
Instead, this PR copies the frontend server from the Dart SDK (whether prebuilt or not) into the location expected by internal engine tests and artifact construction. This PR also consolidates the three GN templates that invoked the frontend server down to one.

Framework presubs: https://github.com/flutter/flutter/pull/135836

Related: https://github.com/flutter/flutter/issues/60007
 2023-10-12 15:40:50 +00:00
Jason Simmons
e3b5dc601d Roll SwiftShader to include a fix required by the latest Clang toolchain (flutter/engine#46803) 2023-10-12 14:38:13 +00:00
skia-flutter-autoroll
374c7243f8 Roll Skia from 2dd1579c6921 to 1d134a8f3ae2 (5 revisions) (flutter/engine#46824) 
https://skia.googlesource.com/skia.git/+log/2dd1579c6921..1d134a8f3ae2

2023-10-12 kjlubick@google.com Remove 4 files from include/private/gpu/ganesh
2023-10-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ea332c715575 to 24dabdbbeee2 (5 revisions)
2023-10-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from baab66a8258b to 37653f7c343e (12 revisions)
2023-10-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 7ab058e00df4 to a1666bf633a8
2023-10-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ab3b6d0185b0 to 7ab058e00df4 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 12:53:07 +00:00
skia-flutter-autoroll
f2b5d4b1e9 Roll Dart SDK from 9afac395dfb1 to 34c06f0bcb29 (1 revision) (flutter/engine#46820) 
https://dart.googlesource.com/sdk.git/+log/9afac395dfb1..34c06f0bcb29

2023-10-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-16.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 09:32:23 +00:00
skia-flutter-autoroll
3887368afe Roll ICU from 985b9a6f70e1 to 995db880cff2 (1 revision) (flutter/engine#46818) 
985b9a6f70..995db880cf

2023-10-06 ftang@chromium.org Add support for TimeZone GMT-16:00 ... GMT-23:59

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter-engine
Please CC jsimmons@google.com,tq-i18n-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 08:21:19 +00:00
skia-flutter-autoroll
2293408d9a Roll Fuchsia Mac SDK from Qjz4zE4Oe0AO_7T3f... to 8AXhoo-MMME8NMKt0... (flutter/engine#46814) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 06:00:51 +00:00
skia-flutter-autoroll
92e708a051 Roll Skia from 9f5080c58aac to 2dd1579c6921 (1 revision) (flutter/engine#46813) 
https://skia.googlesource.com/skia.git/+log/9f5080c58aac..2dd1579c6921

2023-10-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3b1bca8c657b to 5784a4bd7a0c (40 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 06:00:49 +00:00
skia-flutter-autoroll
da39704579 Roll Dart SDK from db2465f106ad to 9afac395dfb1 (1 revision) (flutter/engine#46812) 
https://dart.googlesource.com/sdk.git/+log/db2465f106ad..9afac395dfb1

2023-10-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-15.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 05:54:24 +00:00
skia-flutter-autoroll
8ae9fb5d92 Roll Fuchsia Linux SDK from hMA99PoacaRZVXHgr... to giQtXxdSj6NdIViCw... (flutter/engine#46811) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 04:46:25 +00:00
skia-flutter-autoroll
a8e99c22a9 Roll Skia from ff3c2e3d45bd to 9f5080c58aac (1 revision) (flutter/engine#46809) 
https://skia.googlesource.com/skia.git/+log/ff3c2e3d45bd..9f5080c58aac

2023-10-12 bungeman@google.com [pathops] Remove SK_IGNORE_PATHOPS_SIMPLIFY_TRIVIAL_FIX

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 03:31:13 +00:00
skia-flutter-autoroll
cb0aa5396d Roll Skia from 924df8d87766 to ff3c2e3d45bd (1 revision) (flutter/engine#46807) 
https://skia.googlesource.com/skia.git/+log/924df8d87766..ff3c2e3d45bd

2023-10-12 jamesgk@google.com [graphite] Track image size uniforms separately from proxies

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 02:03:20 +00:00
skia-flutter-autoroll
79a02292fb Roll Dart SDK from 0732be6b823a to db2465f106ad (8 revisions) (flutter/engine#46797) 
https://dart.googlesource.com/sdk.git/+log/0732be6b823a..db2465f106ad

2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-14.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-13.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-12.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-11.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-10.0.dev
2023-10-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-9.0.dev
2023-10-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-8.0.dev
2023-10-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-7.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 22:43:38 +00:00
Brandon DeRosier
a91d13dd87 [Impeller] Use triangle strips to dedupe rectangle vertices. (flutter/engine#46610) 
Remove a couple of duplicate verts in a bunch of situations.

Pedantic improvements: "Brandon, why are you like this" edition.
 2023-10-11 15:42:10 -07:00
Brandon DeRosier
f5191e99c1 [Impeller] Bump impeller-cmake (flutter/engine#46764) 
Bump with build fixes.
 2023-10-11 15:42:03 -07:00
skia-flutter-autoroll
b064072eef Roll Skia from 2459d71707e0 to 924df8d87766 (7 revisions) (flutter/engine#46798) 
https://skia.googlesource.com/skia.git/+log/2459d71707e0..924df8d87766

2023-10-11 robertphillips@google.com [graphite] Add PipelineDataGatherer to the precompilation path
2023-10-11 johnstiles@google.com Fix comment.
2023-10-11 kjlubick@google.com Minor fixes for buffet build
2023-10-11 lovisolo@google.com Reland "[bazel] Move test runners under //tools/testrunners.".
2023-10-11 egdaniel@google.com When waiting on client provided semaphores, only block fragment stage work.
2023-10-11 johnstiles@google.com Disallow layout(builtin=xxx) in non-module code.
2023-10-11 kjlubick@google.com Deploy CanvasKit 0.39.0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 22:40:52 +00:00
Jason Simmons
9f6f5d03cf Run the binary size treemap script from the buildroot directory (flutter/engine#46740) 
This will produce a treemap where navigation starts from the buildroot
and the flutter and third_party source directories are shown as
siblings.
 2023-10-11 15:18:39 -07:00
Dan Field
1e318d57d4 [Impeller] flutter_tester --enable-impeller (flutter/engine#46389) 
This patch does the following:

- Updates `flutter_tester` to set up an Impeller rendering context and surface if `--enable-impeller` is set to true, using the Vulkan backend with Swiftshader.
- Updates `run_tests.py` to run all tests except the smoke test (that one really has no rendering impact whatsoever) with and without `--enable-impeller`.
- Updates a few tests to work that were trivial:
  - A couple tests needed updated goldens for very minor rendering differences. Filed https://github.com/flutter/flutter/issues/135684 to track using Skia gold for this instead.
  - Disabled SKP screenshotting if Impeller is enabled, and updated the test checking that to verify an error is thrown if an SKP is requested.
  - The Dart GPU based test now asserts that the gpu context is available if Impeller is enabled, and does not deadlock if run in a single threaded mode.
  - We were missing some trace events around `Canvas::SaveLayer` for Impeller as compared to Skia.
  - A couple other tests had strict checks about exception messages that are slightly different between Skia and Impeller.
- I've filed bugs for other tests that may require a little more work, and skipped them for now. For FragmentProgram on Vulkan I reused an existing bug.

This is part of my attempt to address https://github.com/flutter/flutter/issues/135693, although @chinmaygarde and I had slightly different ideas about how to do this.

The goals here are:

- Run the Dart unit tests we already have with Impeller enabled.
- Enable running more of the framework tests (including gold tests) with Impeller enabled.
- Run all of these tests via public `dart:ui` API rather than mucking around in C++ internals in the engine.
 2023-10-11 21:42:24 +00:00
Jackson Gardner
99de03845c Switch to Chrome For Testing instead of Chromium (flutter/engine#46683) 
This switches over to using Chrome for Testing instead of Chromium. This requires some changes from the recipes repo (https://flutter-review.googlesource.com/c/recipes/+/51482) in order to coordinate the change in filestructure on the mac versions.
 2023-10-11 21:24:11 +00:00
Gray Mackall
0d5c0a660f Revert "[Android] Add support for text processing actions (#44579)" (flutter/engine#46788) 
This reverts commit 01345c3ce8c06f09625ea2e1a971187e7ed9c049.

This change is causing integration tests to fail on attempts to roll the latest master version of flutter into the packages repo.

See a sample failure here: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8767521956894285553/+/u/Run_package_tests/native_integration_tests/stdout

The root cause seems to be that we are getting request codes in `onActivityResult` that we never added to the `requestsByCode` map, so the call to remove returns null (and we then call success getting a NPE).

More info: 
1. There is a [discussion in discord here](https://discord.com/channels/608014603317936148/1161718667566919761/1161721935927980052)
2. And the failure can be reproduced by running `dart run script/tool/bin/flutter_plugin_tools.dart native-test --android --packages file_selector` from the root of the packages repo (with a flutter checkout that contains these changes).

cc @bleroux 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-11 20:49:51 +00:00
Daniel Chevalier
94df47fedc [web] Adds Noto Music fallback font (flutter/engine#46720) 
Adds `Noto Music` font as a fallback font, and updates DEPS and font definitions after running the font roller script.

### Issues

Fixes: https://github.com/flutter/devtools/issues/6149

----

![](https://media.giphy.com/media/3ohzAv6kdQ4tukSNK8/giphy-downsized.gif)

I used [the developer API](https://developers.google.com/fonts/docs/developer_api?apix_params=%7B%22family%22%3A%5B%22Noto%20Music%22%5D%7D) to make sure the api works with this font.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-11 20:46:16 +00:00
Jason Simmons
3dcce9d779 Fix some image_external_texture entries in the license golden file (flutter/engine#46790) 2023-10-11 13:31:39 -07:00
John McCutchan
3bd2efe1d3 Rename HardwareBufferExternalTexture* to ImageExternalTexture* (flutter/engine#46786) 
Image is the more accurate name and we will eventually have a
HardwareBufferExternalTexture in the future (see
https://developer.android.com/reference/android/graphics/HardwareBufferRenderer
available on Android >= 34).
 2023-10-11 12:35:36 -07:00
skia-flutter-autoroll
50c5e1a989 Roll Skia from 6cc9f73ea54e to 2459d71707e0 (1 revision) (flutter/engine#46787) 
https://skia.googlesource.com/skia.git/+log/6cc9f73ea54e..2459d71707e0

2023-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bd2d26113aa7 to baab66a8258b (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 19:16:06 +00:00
John McCutchan
da447b9297 Fix 303652511 and add a regression test (flutter/engine#46743) 
Fixes internal bug b/303652511 and includes a regression test.

The TL;DR of the bug is that when re-launching a singleton-cached-engine
Flutter activity using FLAG_ACTIVITY_CLEAR_TASK, the teardown of the
previous Flutter activity interleaves with the creation of the new
Flutter activity, resulting in the Flutter engine ending up incorrectly
in the AppLifecycleState.detached state. This then results in the app
being completely unresponsive because Flutter doesn't draw frames in
this state. I don't know if the issue is reproducible in production
under normal user operation, but I'm concerned it very easily could be.
There's also nothing stopping other apps or Android system code from
launching an app using this flag.
 2023-10-11 11:29:04 -07:00