engine-flutter-autoroll
ef54879b48
Roll Flutter Engine from c641f6307f08 to 9ba461efd3fe (6 revisions) ( #127536 )
...
c641f6307f...9ba461efd3mdebbar@google.com [web] Remove comment about dart:html migration (flutter/engine#42290 )
2023-05-24 mdebbar@google.com [web] Hide JS types from dart:ui_web (flutter/engine#42252 )
2023-05-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qoLy9E5PjnAlICjUb... to RSSC61ubl9JXmn4JO... (flutter/engine#42287 )
2023-05-24 marcianx@gmail.com [web] Update a11y announcements to append divs instead of setting content. (flutter/engine#42258 )
2023-05-24 jonahwilliams@google.com [Impeller] fix Xcode frame capture. (flutter/engine#42289 )
2023-05-24 jason-simmons@users.noreply.github.com [Impeller] Create an autorelease pool for Impeller tests running on macOS. (flutter/engine#42265 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from qoLy9E5PjnAl to RSSC61ubl9JX
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 23:18:49 +00:00
lsaudon
7827a24207
Add missing parameters in TextFormField ( #127020 )
...
`TextFormField` does not have all the parameters of `TextField`.
Added:
```dart
UndoHistoryController? undoController,
AppPrivateCommandCallback? onAppPrivateCommand,
bool? cursorOpacityAnimates,
ui.BoxHeightStyle selectionHeightStyle = ui.BoxHeightStyle.tight,
ui.BoxWidthStyle selectionWidthStyle = ui.BoxWidthStyle.tight,
DragStartBehavior dragStartBehavior = DragStartBehavior.start,
ContentInsertionConfiguration? contentInsertionConfiguration,
Clip clipBehavior = Clip.hardEdge,
bool scribbleEnabled = true,
bool canRequestFocus = true,
```
2023-05-24 23:06:52 +00:00
Casey Hillers
99f792e085
Update labeler action wildcards ( #127524 )
...
https://github.com/flutter/flutter/issues/126002
2023-05-24 23:06:50 +00:00
LongCatIsLooong
62e78bf143
Improve TextPainter.layout caching ( #118128 )
...
Improves `TextPainter.layout` caching when only the input constraints change:
- removes the double layout calls in `TextPainter._layoutParagraph`: now double layout is only needed when `TextAlign` is not left, and the input `maxWidth == double.infinity`.
- skip calls to `ui.Paragraph.layout` when it's guaranteed that there's no soft line breaks before/after the layout call.
This doesn't introduce new APIs but may slightly shift text rendered on screen.
This reduces the number of `layout` calls but since shaping results are already cached so it only skips the relatively cheap line-breaking process when possible.
528 scuba failures but all of them seem reasonable.
2023-05-24 22:38:52 +00:00
dependabot[bot]
4d1c6a4346
Bump actions/labeler from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327 ( #127533 )
...
Bumps [actions/labeler](https://github.com/actions/labeler ) from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327.
<details>
<summary>Commits</summary>
<ul>
<li><a href="0776a67936https://redirect.github.com/actions/labeler/issues/571 ">#571</a> from akv-platform/remove-implicit-dependencies</li>
<li><a href="08382d15cbd1dd326ccc91076827ed2713f7303c...0776a67936
2023-05-24 22:36:58 +00:00
Bruno Leroux
2b105ac6dd
Fix ScrollPosition overscroll precision error ( #127321 )
...
## Description
This PR fixes a precision error in ~~`ClampingScrollPhysics`~~ `ScrollPosition` that leads to `StretchingOverscrollIndicator` stretching its content unexpectedly in some devices (see https://github.com/flutter/flutter/issues/126561 where this is visible in `TabBarView` and the test added in this PR where it reproduces with a `PageView`).
~~This PR also contains a change to `nested_scroll_view.dart` because the first change (the one in `ClampingScrollPhysics`) breaks the precision error test added by https://github.com/flutter/flutter/pull/87801.~~
## Related Issue
Fixes https://github.com/flutter/flutter/issues/126561
## Tests
Adds 1 test.
2023-05-24 22:34:06 +00:00
Devin
5451ea6e8f
Slider.onChangeStart & Slider.onChangeEnd are not called on keyboard shortcuts (#126896 )
...
fixes https://github.com/flutter/flutter/issues/123315
--------
This PR makes changes to the _actionHandler function used on the Slider.Dart Widget for Key Events. It ensures onChangeStart is called at the beginning of a Key Event and onChangeEnd at the end of one. This PR includes a test for the changes made.
I ran all existing tests after my changes were made and they passed.
2023-05-24 22:13:15 +00:00
Brandon DeRosier
982e00527c
Manually roll Flutter Engine from 0c41b02cd5a6 to c641f6307f08 ( #127514 )
...
Rolls engine to head with
[fixes](https://github.com/flutter/flutter/pull/127505 ) corresponding to
the [latest Dart roll](https://github.com/flutter/engine/pull/42286 ).
2023-05-24 14:35:23 -07:00
Casey Hillers
eea12df3a9
Update CP template to include timeline and changelog ( #127507 )
...
Based on recent feedback. Give more information in the CP template.
2023-05-24 21:32:10 +00:00
Sun Jiao
7b67aa587a
make suggestionsBuilder in SearchAnchor asyncable ( #127019 )
2023-05-24 13:12:47 -07:00
Victoria Ashworth
a19b3436ee
Log all lines from ios-deploy ( #127502 )
...
Reland https://github.com/flutter/flutter/pull/127222 that was reverted in https://github.com/flutter/flutter/pull/127405 .
Fixed `Mac_ios microbenchmarks_ios` test failure by not echoing logs twice.
2023-05-24 19:46:16 +00:00
Victoria Ashworth
555326b228
Revert "Replace rsync when unzipping artifacts on a Mac ( #126703 )" ( #127430 )
...
This reverts commit 2b3cd7f4d9fd522e2e691fbd169c0c0e1fd7c9e8.
Fixes https://github.com/flutter/flutter/issues/127281 .
2023-05-24 19:21:05 +00:00
Chris Yang
9232834ef8
test owners: cyanglaz -> vashworth ( #127391 )
...
Changes the test owners to @vashworth while I'm OOO.
2023-05-24 19:17:44 +00:00
Chris Bracken
edf4a91f5f
[Linux] Ignore deprecation of libupower call in example ( #127503 )
...
The Linux platform channels sample makes a call to the libupower
function `up_client_get_devices`, which was deprecated in libupower
0.99.8 in favour of `up_client_get_devices2`.
The prod bots have been migrated to focal, which ships libupower 0.99.11
in which the old function is deprecated and the new one is available.
The try bots have not yet been migrated and remain on bionic, which
ships libupower 0.99.7 in which the old function is not deprecated and
the new one is not available.
This marks the line in question to ignore deprecation warnings. Once all
bots have migrated to focal, we'll migrate to the new function. See
tracking issue below.
See:
https://upower.freedesktop.org/docs/UpClient.html#up-client-get-devices
Issue: https://github.com/flutter/flutter/issues/127506
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-24 11:44:05 -07:00
engine-flutter-autoroll
ff8411d896
Roll Packages from d449a17f8706 to fba97fa4cc86 (4 revisions) ( #127492 )
...
d449a17f87...fba97fa4ccgodofredoc@google.com Update infra reviewers and add label. (flutter/packages#4068 )
2023-05-23 JeroenWeener@users.noreply.github.com [in_app_purchase] Bump `in_app_purchase_android` dependency to 3.0.0 (flutter/packages#4065 )
2023-05-23 stuartmorgan@google.com [in_app_purchase] Fix Java lints (flutter/packages#4032 )
2023-05-23 engine-flutter-autoroll@skia.org Roll Flutter from 343718945bcb to f86c529b2cd2 (22 revisions) (flutter/packages#4066 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 15:52:54 +00:00
engine-flutter-autoroll
e2ae260b42
Roll Flutter Engine from eebcf36cd38f to 0c41b02cd5a6 (1 revision) ( #127461 )
...
eebcf36cd3...0c41b02cd5bdero@google.com [Impeller] Set the coverage hint on everything (flutter/engine#42264 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 15:51:26 +00:00
engine-flutter-autoroll
216605b60f
Roll Flutter Engine from aba9dc4640c2 to eebcf36cd38f (3 revisions) ( #127458 )
...
aba9dc4640...eebcf36cd3bdero@google.com [Impeller] Limit rrect blur kernel to 1000x1000 (flutter/engine#42269 )
2023-05-24 godofredoc@google.com Add builders for second level cache of builders. (flutter/engine#42271 )
2023-05-24 jonahwilliams@google.com [Impeller] remove framebuffer blending from atlas, fix transform scale (flutter/engine#42254 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 03:40:27 +00:00
engine-flutter-autoroll
90cf8d1dd4
Roll Flutter Engine from 76afb431a740 to aba9dc4640c2 (1 revision) ( #127453 )
...
76afb431a7...aba9dc464030870216+gaaclarke@users.noreply.github.com Turned back on debug unit tests (flutter/engine#42261 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 01:51:25 +00:00
engine-flutter-autoroll
81971c961b
Roll Flutter Engine from fc6df9512aa2 to 76afb431a740 (3 revisions) ( #127445 )
...
fc6df9512a...76afb431a7skia-flutter-autoroll@skia.org Roll Dart SDK from 90b4df96e9dc to 7546e99f8a50 (3 revisions) (flutter/engine#42260 )
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 28946eda0f6d to 69f7860093b4 (6 revisions) (flutter/engine#42262 )
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 292879d286e9 to 28946eda0f6d (5 revisions) (flutter/engine#42257 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 00:49:25 +00:00
dependabot[bot]
23fe4fca59
Bump actions/labeler from 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb to 2713f7303c96cb1e69627957ec16eea0fd7f94a4 ( #127438 )
...
Bumps [actions/labeler](https://github.com/actions/labeler ) from 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb to 2713f7303c96cb1e69627957ec16eea0fd7f94a4.
<details>
<summary>Commits</summary>
<ul>
<li><a href="2713f7303chttps://redirect.github.com/actions/labeler/issues/572 ">#572</a>)</li>
<li><a href="a4eda65d3dhttps://redirect.github.com/actions/labeler/issues/573 ">#573</a>)</li>
<li><a href="5c4deb8a24https://redirect.github.com/actions/labeler/issues/480 ">#480</a>)" (<a href="https://redirect.github.com/actions/labeler/issues/564 ">#564</a>)</li>
<li><a href="61662e8f41https://redirect.github.com/actions/labeler/issues/569 ">#569</a>)</li>
<li>See full diff in <a href="6b107e7a7e...2713f7303c
2023-05-23 23:26:05 +00:00
engine-flutter-autoroll
df281bb193
Roll Flutter Engine from 3535e0d301dd to fc6df9512aa2 (1 revision) ( #127440 )
...
3535e0d301...fc6df9512ajonahwilliams@google.com [Impeller] Encode render passes concurrently on iOS. (flutter/engine#42028 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 23:24:14 +00:00
chunhtai
c687dcd56f
Migrates android semanitcs integration to integration test ( #127128 )
...
I think the flake is due to setclipboard or semantics update race condition. I migrated the test to use integration test package which relies less on timing
fixes https://github.com/flutter/flutter/issues/124636
2023-05-23 22:33:19 +00:00
engine-flutter-autoroll
8c086d0171
Roll Flutter Engine from 23b04314d5d2 to 3535e0d301dd (3 revisions) ( #127428 )
...
23b04314d5...3535e0d301103135467+sealesj@users.noreply.github.com Revert "Vuln scan on 3p deps triggered by label on PR" (flutter/engine#42256 )
2023-05-23 103135467+sealesj@users.noreply.github.com Vuln scan on 3p deps triggered by label on PR (flutter/engine#42247 )
2023-05-23 jonahwilliams@google.com Revert "[Impeller] use host image upload path on simulator" (flutter/engine#42212 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 22:23:19 +00:00
engine-flutter-autoroll
6f00846866
Roll Flutter Engine from ccf50f344d5d to 23b04314d5d2 (2 revisions) ( #127421 )
...
ccf50f344d...23b04314d5aam@google.com Roll buildroot to 5cab8e095066d8f3de063943af26b7336aa52662 (flutter/engine#42251 )
2023-05-23 103135467+sealesj@users.noreply.github.com Vulnerability scanning print failed command in case of error (flutter/engine#42190 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 20:19:35 +00:00
Ian Hickson
9c7a9e779f
Give channel descriptions in flutter channel, use branch instead of upstream for channel name ( #126936 )
...
## How we determine the channel name
Historically, we used the current branch's upstream to figure out the current channel name. I have no idea why. I traced it back to https://github.com/flutter/flutter/pull/446/files where @abarth implement this and I reviewed that PR and left no comment on it at the time.
I think this is confusing. You can be on a branch and it tells you that your channel is different. That seems weird.
This PR changes the logic to uses the current branch as the channel name.
## How we display channels
The main reason this PR exists is to add channel descriptions to the `flutter channel` list:
```
ianh@burmese:~/dev/flutter/packages/flutter_tools$ flutter channel
Flutter channels:
master (tip of tree, for contributors)
main (tip of tree, follows master channel)
beta (updated monthly, recommended for experienced users)
stable (updated quarterly, for new users and for production app releases)
* foo_bar
Currently not on an official channel.
ianh@burmese:~/dev/flutter/packages/flutter_tools$
```
## Other changes
I made a few other changes while I was at it:
* If you're not on an official channel, we used to imply `--show-all`, but now we don't, we just show the official channels plus yours. This avoids flooding the screen in the case the user is on a weird channel and just wants to know what channel they're on.
* I made the tool more consistent about how it handles unofficial branches. Now it's always `[user branch]`.
* I slightly adjusted how unknown versions are rendered so it's clearer the version is unknown rather than just having the word "Unknown" floating in the output without context.
* Simplified some of the code.
* Made some of the tests more strict (checking all output rather than just some aspects of it).
* Changed the MockFlutterVersion to implement the FlutterVersion API more strictly.
* I made sure we escape the output to `.metadata` to avoid potential injection bugs (previously we just inlined the version and channel name verbatim with no escaping, which is super sketchy).
* Tweaked the help text for the `downgrade` command to be clearer.
* Removed some misleading text in some error messages.
* Made the `.metadata` generator consistent with the template file.
* Removed some obsolete code to do with the `dev` branch.
## Reviewer notes
I'm worried that there are implications to some of these changes that I am not aware of, so please don't assume I know what I'm doing when reviewing this code. :-)
2023-05-23 19:59:20 +00:00
Tomasz Gucio
25d2f90a59
Avoid catching errors in TextPainter tests ( #127307 )
2023-05-23 21:20:59 +02:00
Christopher Fujino
11cb29174f
[flutter_tools] delete entitlements files after copying to macos build dir ( #127417 )
...
Fixes https://github.com/flutter/flutter/issues/126705
Follow up fix after https://github.com/flutter/flutter/pull/126875 did NOT work.
2023-05-23 19:12:11 +00:00
engine-flutter-autoroll
3518d69d2a
Roll Flutter Engine from a6e37bde65fd to ccf50f344d5d (7 revisions) ( #127416 )
...
a6e37bde65...ccf50f344dskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
Zbd3haNY2Idcdu1Fj... to -dXJ_pnUVwmjscIYm... (flutter/engine#42250 )
2023-05-23 30870216+gaaclarke@users.noreply.github.com [Impeller]
Removed last ivars to raw vk::Device's. (flutter/engine#42215 )
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 225d51031ad0 to
292879d286e9 (5 revisions) (flutter/engine#42249 )
2023-05-23 zanderso@users.noreply.github.com Build arm64
FlutterEmbedder.framework and lipo the result (flutter/engine#42233 )
2023-05-23 aam@google.com Roll watcher dependency for web_ui to 1.1.0.
(flutter/engine#42248 )
2023-05-23 mdebbar@google.com [web] Move platformViewRegistry to ui_web
(flutter/engine#41877 )
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 3ded22186598 to
225d51031ad0 (1 revision) (flutter/engine#42246 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Zbd3haNY2Idc to -dXJ_pnUVwmj
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 12:08:28 -07:00
NikolajHarderNota
c84b10474c
modal bottom sheet barrier label ( #126431 )
...
Adds barrierLabel as optional param in showModalBottomSheet
Fixes #83180
2023-05-23 18:59:49 +00:00
Justin McCandless
4341ed4229
Fix the breaking of multi-code-unit characters in obscure mode ( #123366 )
...
This PR changes the character boundary behavior of obscured fields to be based on code points instead of code units.
So it used to be possible to traverse and delete obscured text inside of code points (and breaking a code point like that would cause a crash):
But now moving the cursor and deleting is based on code points:
### Native behavior
Native iOS deletes part of the emoji, native Mac deletes the whole emoji. See https://github.com/flutter/flutter/issues/122381#issuecomment-1482042620 . So it's unclear what the desired behavior should actually be.
### Resources
Fixes https://github.com/flutter/flutter/issues/122381
I thought this might not fix the case where a broken emoji is directly pasted into the field, but it seems to work by trying this: �âð©âð¦âð¦
CC @LongCatIsLooong
2023-05-23 18:21:10 +00:00
engine-flutter-autoroll
ffbeb72336
Roll Flutter Engine from 168b0bf3f70d to a6e37bde65fd (1 revision) ( #127397 )
...
168b0bf3f7...a6e37bde65skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DzmjiSg6XC0JUfbKP... to aAjEDVse7qfMt0NqE... (flutter/engine#42245 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from DzmjiSg6XC0J to aAjEDVse7qfM
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 17:26:27 +00:00
Victoria Ashworth
d452ce9635
Revert "Log all output of ios-deploy" ( #127405 )
...
Reverts flutter/flutter#127222
2023-05-23 16:37:36 +00:00
engine-flutter-autoroll
20ccf0904d
Roll Packages from 83959fb7de37 to d449a17f8706 (6 revisions) ( #127394 )
...
83959fb7de...d449a17f87stuartmorgan@google.com [various] Remove unnecessary null checks (flutter/packages#4060 )
2023-05-22 stuartmorgan@google.com [ci] Add a legacy Android build-all test (flutter/packages#4005 )
2023-05-22 engine-flutter-autoroll@skia.org Roll Flutter from ab573048e74d to 343718945bcb (5 revisions) (flutter/packages#4062 )
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650 )
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650 )
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 15:55:15 +00:00
Victoria Ashworth
7fa45ea486
Log all output of ios-deploy ( #127222 )
...
Log all output of `ios-deploy` to try and determine if the issue of https://github.com/flutter/flutter/issues/121231 is with stream or with `ios-deploy`.
Note: This will cause some duplicate logs like example below but only in verbose mode
```
(lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend.
(lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend.
2023-05-19 13:48:19.156866-0500 Runner[2521:390612] flutter: The Dart VM service is listening on http://127.0.0.1:63508/IsFnhXJykCM=/
VM Service URL on device: http://127.0.0.1:63508/IsFnhXJykCM=/
```
2023-05-23 15:25:10 +00:00
engine-flutter-autoroll
f86c529b2c
Roll Flutter Engine from 431ed51c6415 to 168b0bf3f70d (1 revision) ( #127382 )
...
431ed51c64...168b0bf3f7skia-flutter-autoroll@skia.org Roll Skia from 4d0166106722 to 3ded22186598 (2 revisions) (flutter/engine#42242 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 12:01:25 +00:00
engine-flutter-autoroll
8e3319fd8e
Roll Flutter Engine from cc79ae858591 to 431ed51c6415 (1 revision) ( #127381 )
...
cc79ae8585...431ed51c64whesse@google.com Add leak_tracker package from Dart DEPS to DEPS (flutter/engine#42241 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 11:07:26 +00:00
engine-flutter-autoroll
b83c82f710
Roll Flutter Engine from 311438399a45 to cc79ae858591 (1 revision) ( #127377 )
...
311438399a...cc79ae8585skia-flutter-autoroll@skia.org Roll Dart SDK from 1ca8f8368ecc to 90b4df96e9dc (2 revisions) (flutter/engine#42239 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 10:13:41 +00:00
engine-flutter-autoroll
1811828042
Roll Flutter Engine from c284cd10e7ab to 311438399a45 (1 revision) ( #127376 )
...
c284cd10e7...311438399askia-flutter-autoroll@skia.org Roll Skia from 1c3d1e200d72 to 4d0166106722 (2 revisions) (flutter/engine#42238 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 09:25:27 +00:00
engine-flutter-autoroll
fca152f2f1
Roll Flutter Engine from 8d6602b030be to c284cd10e7ab (2 revisions) ( #127372 )
...
8d6602b030...c284cd10e7bdero@google.com [Impeller] Place Entity Geometry classes in separate TUs (flutter/engine#42236 )
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from fc369d15070f to 1c3d1e200d72 (1 revision) (flutter/engine#42235 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 08:21:36 +00:00
Taha Tesser
fe32675b54
Add M3 date picker tests and fix divider ( #127197 )
...
partial fix https://github.com/flutter/flutter/issues/126826 (date range picker is another PR)
fixes https://github.com/flutter/flutter/issues/126597
### Description
1. This PR adds a bunch of M3 date picker tests
2. Fixes divider taking more space than it should
3. Added dividerColor theme value to allow users to customise divider color just for the date pickers from date picker theme
<details>
<summary>code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(
datePickerTheme: DatePickerThemeData(
headerBackgroundColor: Colors.amber,
),
useMaterial3: true,
),
home: Scaffold(
body: Builder(builder: (BuildContext context) {
return Center(
child: ElevatedButton(
onPressed: () async {
showDatePicker(
context: context,
initialDate: DateTime(2016, DateTime.january, 15),
firstDate: DateTime(2001),
lastDate: DateTime(2031, DateTime.december, 31),
);
},
child: const Text('Show Date Picker'),
),
);
}),
),
);
}
}
```
</details>
### Before
### After
2023-05-23 07:29:20 +00:00
engine-flutter-autoroll
d9045f0268
Roll Flutter Engine from 2586cbeeae37 to 8d6602b030be (2 revisions) ( #127370 )
...
2586cbeeae...8d6602b030skia-flutter-autoroll@skia.org Roll Skia from 6a57876d0e44 to fc369d15070f (1 revision) (flutter/engine#42234 )
2023-05-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LrfeC0dLk8ToJVik5... to Zbd3haNY2Idcdu1Fj... (flutter/engine#42232 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from LrfeC0dLk8To to Zbd3haNY2Idc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 06:45:12 +00:00
engine-flutter-autoroll
dd07c61e98
Manual roll Flutter Engine from a342a9186e69 to 2586cbeeae37 (14 revisions) ( #127369 )
...
Manual roll requested by zra@google.com
a342a9186e...2586cbeeaezanderso@users.noreply.github.com Revert "[ios_platform_view]
only recycle maskView when the view is applying mutators #41573 "
(flutter/engine#42231 )
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from ac87929b3d2e to
6a57876d0e44 (2 revisions) (flutter/engine#42230 )
2023-05-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... (flutter/engine#42227 )
2023-05-23 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42229 )
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from d448fe07ea46 to
ac87929b3d2e (8 revisions) (flutter/engine#42226 )
2023-05-23 dnfield@google.com Make FML_LOG safe from static
initialization (flutter/engine#42219 )
2023-05-23 uysalere@gmail.com [fuchsia] Bind ChildViewWatcher on
platform thread (flutter/engine#42222 )
2023-05-22 skia-flutter-autoroll@skia.org Roll Dart SDK from
b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224 )
2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Return
image decoder error messages to the Dart API (flutter/engine#42175 )
2023-05-22 5236035+fzyzcjy@users.noreply.github.com Again a two-word
super tiny typo (flutter/engine#42181 )
2023-05-22 ychris@google.com Reland "[ios_platform_view] only recycle
maskView when the view is applying mutators #41573 "
(flutter/engine#42115 )
2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Use
untransformed text bounds to calculate the size of
ColorSourceTextContents (flutter/engine#42142 )
2023-05-22 jonahwilliams@google.com [Impeller] Add UV compute shader.
(flutter/engine#42192 )
2023-05-22 jonahwilliams@google.com [Impeller] remove final cmd buffer
waitUntilScheduled on physical iOS (flutter/engine#42160 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from QAwORJOkyNl4 to DzmjiSg6XC0J
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-22 21:04:11 -07:00
Camille Simon
31a665c3eb
[Android] Adds namespace to module build file templates ( #126963 )
...
Adds `namespace` to module `build.gradle` file templates.
Fixes https://github.com/flutter/flutter/issues/126403 .
2023-05-23 02:48:40 +00:00
Zachary Anderson
bc14fedb77
Revert Engine to a342a9186e69 ( #127368 )
...
Reverts Engine rolls for bad commit in
https://github.com/flutter/engine/pull/42115
6549765296194d30a8cdhttps://github.com/flutter/engine/pull/42231
2023-05-22 19:41:20 -07:00
engine-flutter-autoroll
6549765296
Roll Flutter Engine from 2a325eed77d0 to 41e8d52a006a (2 revisions) ( #127365 )
...
2a325eed77...41e8d52a00dnfield@google.com Make FML_LOG safe from static initialization (flutter/engine#42219 )
2023-05-23 uysalere@gmail.com [fuchsia] Bind ChildViewWatcher on platform thread (flutter/engine#42222 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 02:03:02 +00:00
engine-flutter-autoroll
194d30a8cd
Roll Flutter Engine from a342a9186e69 to 2a325eed77d0 (7 revisions) ( #127364 )
...
a342a9186e...2a325eed77skia-flutter-autoroll@skia.org Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224 )
2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175 )
2023-05-22 5236035+fzyzcjy@users.noreply.github.com Again a two-word super tiny typo (flutter/engine#42181 )
2023-05-22 ychris@google.com Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573 " (flutter/engine#42115 )
2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142 )
2023-05-22 jonahwilliams@google.com [Impeller] Add UV compute shader. (flutter/engine#42192 )
2023-05-22 jonahwilliams@google.com [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-23 01:13:35 +00:00
Parker Lougheed
c313083a88
Remove null-safety argument from DartPad doc samples ( #127345 )
...
Removes the `null_safety=true` query parameter from DartPad samples in the API docs, since all DartPad channels only support null safety now and the parameter does nothing.
## Test
Removing code, but updates the check in the dartdoc tool for the removal.
2023-05-23 00:10:11 +00:00
Daniel Iglesia
a6d62ca8de
Support keeping a bottom sheet with a DraggableScrollableSheet from closing on drag/fling to min extent ( #127339 )
2023-05-22 16:14:35 -07:00
Jackson Gardner
758ea6c096
Fix wasm-opt location when using local_web_sdk ( #127355 )
...
We were looking up the wrong path for `wasm-opt` previously when using the `local-web-sdk` flag.
2023-05-22 23:08:11 +00:00
engine-flutter-autoroll
7a12d825e2
Roll Flutter Engine from 1ed9fc0caf55 to a342a9186e69 (3 revisions) ( #127352 )
...
1ed9fc0caf...a342a9186eskia-flutter-autoroll@skia.org Roll Skia from 2612bb159848 to d448fe07ea46 (5 revisions) (flutter/engine#42213 )
2023-05-22 aam@google.com Skip and ignore boringssl/src/rust when looking for the licenses. (flutter/engine#42210 )
2023-05-22 jonahwilliams@google.com [Impeller] Create reusable prefix sum. (flutter/engine#42167 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-22 22:26:25 +00:00
