Jonah Williams
edf62bb82b
[Impeller] use host image upload path on simulator ( flutter/engine#42161 )
...
This might help with https://github.com/flutter/flutter/issues/126768#issuecomment-1554469333
2023-05-19 16:51:51 +00:00
hellohuanlin
ebe810b435
[floating_cursor_selection]add some comments on the tricky part ( flutter/engine#42136 )
...
Many parts of the floating cursor selection feature is pretty tricky. Some took me a while to figure out. So I added some comments to explain a bit for future readers.
*List which issues are fixed by this PR. You must list at least one issue.*
https://github.com/flutter/flutter/issues/30476
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-19 16:42:58 +00:00
skia-flutter-autoroll
17085a8d3d
Roll Skia from 9cc604b2c3ed to 0a63dbe8cd15 (1 revision) ( flutter/engine#42159 )
...
https://skia.googlesource.com/skia.git/+log/9cc604b2c3ed..0a63dbe8cd15
2023-05-19 ccameron@chromium.org SkJpegCodec: Fix error in gainmap extraction
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 15:08:05 +00:00
Mouad Debbar
281dea65ad
[web] Cleanup Vector3 ( flutter/engine#42096 )
...
We have limited use of `Vector3` in the engine, so I converted it into a record and removed almost all of its methods.
Converting it to a record also means it's not mutable anymore, which is a positive in my book. That required a few minor changes in `Matrix4` but nothing major.
2023-05-19 14:05:29 +00:00
skia-flutter-autoroll
2cccd8f28a
Roll Dart SDK from 4a2e45ecfc50 to f5716102efe8 (2 revisions) ( flutter/engine#42156 )
...
https://dart.googlesource.com/sdk.git/+log/4a2e45ecfc50..f5716102efe8
2023-05-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-128.0.dev
2023-05-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-127.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 12:09:20 +00:00
skia-flutter-autoroll
ce837d7d3e
Roll Skia from aac83f59bbba to 9cc604b2c3ed (1 revision) ( flutter/engine#42152 )
...
https://skia.googlesource.com/skia.git/+log/aac83f59bbba..9cc604b2c3ed
2023-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b6ae2e881c8b to 999cfc1546e2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 10:47:35 +00:00
skia-flutter-autoroll
567e8d5aaf
Roll Skia from 9e38597c3757 to aac83f59bbba (1 revision) ( flutter/engine#42150 )
...
https://skia.googlesource.com/skia.git/+log/9e38597c3757..aac83f59bbba
2023-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bcbf23c5f184 to b76166d0275a (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 08:12:10 +00:00
skia-flutter-autoroll
af002e45ee
Roll Fuchsia Linux SDK from zqkH0qb9GQ3jO24Bh... to eal6a4HeaQon_Y4ml... ( flutter/engine#42149 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 07:41:05 +00:00
skia-flutter-autoroll
df8fa2a9aa
Roll Skia from 37e853069c04 to 9e38597c3757 (1 revision) ( flutter/engine#42148 )
...
https://skia.googlesource.com/skia.git/+log/37e853069c04..9e38597c3757
2023-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 588114bc957f to b6ae2e881c8b (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 07:25:01 +00:00
skia-flutter-autoroll
db28d1b30b
Roll Skia from 09d8a47a1f65 to 37e853069c04 (1 revision) ( flutter/engine#42147 )
...
https://skia.googlesource.com/skia.git/+log/09d8a47a1f65..37e853069c04
2023-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 97ab6a3a7061 to 34fd751bd753 (16 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 05:32:03 +00:00
skia-flutter-autoroll
306245f066
Roll Fuchsia Mac SDK from Tl371NrGBEHFYPxHQ... to IGeTvUK2wkajmQQ2k... ( flutter/engine#42145 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 05:26:13 +00:00
skia-flutter-autoroll
0bb3e90541
Roll Dart SDK from 95b96a9f498a to 4a2e45ecfc50 (1 revision) ( flutter/engine#42143 )
...
https://dart.googlesource.com/sdk.git/+log/95b96a9f498a..4a2e45ecfc50
2023-05-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-126.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 04:32:57 +00:00
skia-flutter-autoroll
c6aa417e6c
Roll Skia from 8931359a74f1 to 09d8a47a1f65 (1 revision) ( flutter/engine#42141 )
...
https://skia.googlesource.com/skia.git/+log/8931359a74f1..09d8a47a1f65
2023-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f7b24ac464f9 to 3600ed906bb4 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 03:58:22 +00:00
Bruno Leroux
72e6f7f567
[Android] Fix BasicMessageChannel.resizeChannelBuffer ( flutter/engine#41982 )
...
## Description
This PR updates `BasicMessageChannel.resizeChannelBuffer` implementation. Previous implementation builds a wrong `ByteBuffer` and was not tested so it is difficult to know when it stopped working.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/126632
## Tests
Adds 1 test.
2023-05-19 03:46:05 +00:00
Yegor
1811689d04
[web:a11y] support dialogs described by descendants ( flutter/engine#42108 )
...
Add a new `RouteName` semantic role for nodes with `namesRoute` set without a `scopesRoute`. Such nodes provide a description for the nearest ancestor dialog node. The web equivalent of this is when an element `role="dialog"` is described by pointing to one of its children using `aria-labelledby` and `aria-describedby`. Here's an example:
```
<div
role="dialog"
aria-labelledby="dialog1Title"
aria-describedby="dialog1Desc">
<h2 id="dialog1Title">Your personal details were successfully updated</h2>
<p id="dialog1Desc">
You can change your details at any time in the user account section.
</p>
<button>Close</button>
</div>
```
([Source](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role ))
Flutter currently does not distinguish between "labelled by" and "described by". In my testing, only `aria-describedby` resulted in an announcement of the dialog's description upon opening. `aria-labelledby` required that the dialog element itself be focusable, which is not the case. So I went with `aria-describedby`.
Fixes https://github.com/flutter/flutter/issues/126030
2023-05-19 00:25:19 +00:00
chunhtai
750599021c
Makes android embedding to send full uri ( flutter/engine#41836 )
...
related https://github.com/flutter/flutter/issues/100624
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-18 23:38:17 +00:00
skia-flutter-autoroll
899c5f2304
Roll Skia from 2ffed2e4c6f8 to 8931359a74f1 (4 revisions) ( flutter/engine#42139 )
...
https://skia.googlesource.com/skia.git/+log/2ffed2e4c6f8..8931359a74f1
2023-05-18 johnstiles@google.com Always add braces when writing child statements in WGSL.
2023-05-18 johnstiles@google.com Eliminate DSLFunction entirely.
2023-05-18 michaelludwig@google.com [skif] Delete legacy SkColorFilterImageFilter impl
2023-05-18 michaelludwig@google.com [skif] Don't evaluate empty-source filters for SkNoDrawCanvases
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 23:32:30 +00:00
skia-flutter-autoroll
2edf1e765f
Roll Dart SDK from 7bc022c51215 to 95b96a9f498a (2 revisions) ( flutter/engine#42138 )
...
https://dart.googlesource.com/sdk.git/+log/7bc022c51215..95b96a9f498a
2023-05-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-125.0.dev
2023-05-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-124.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 22:52:55 +00:00
skia-flutter-autoroll
a8b4c20910
Roll Skia from ac47a05bf253 to 2ffed2e4c6f8 (8 revisions) ( flutter/engine#42137 )
...
https://skia.googlesource.com/skia.git/+log/ac47a05bf253..2ffed2e4c6f8
2023-05-18 lovisolo@google.com [bazel] Add "label" part to "BazelTest" task schema.
2023-05-18 robertphillips@google.com Expand Protected content tests
2023-05-18 brianosman@google.com Fix some anti-patterns in SkIcoCodec, unique_ptr assignment
2023-05-18 johnstiles@google.com Eliminate DSLVar.h entirely.
2023-05-18 johnstiles@google.com Remove unused DSLVar types.
2023-05-18 jvanverth@google.com [graphite] Add premul to alpha YUV images
2023-05-18 johnstiles@google.com Remove DSLCore entirely.
2023-05-18 johnstiles@google.com Remove ErrorReporter functions from DSLCore.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 21:37:48 +00:00
Chris Bracken
49afcc0101
[macOS] Refactor PlatformView mutators ( flutter/engine#42130 )
...
This refactors `[FlutterMutatorView applyLayer:]` to split out orthogonal behaviour into smaller functions for better readability/maintainability.
Extracts:
* General transform composition to CATransformFromMutations
* Opacity handling
* MasterClip computation
* RoundedRectClip computation
This change is a cleanup change for readability and makes no semantic changes to how mutator views are applied. Existing unit tests in [FlutterMutatorViewTest.mm](https://github.com/flutter/engine/blob/main/shell/platform/darwin/macos/framework/Source/FlutterMutatorViewTest.mm ) are expected to pass without changes.
This is refactoring prior to applying a fix for rotation handling.
Issue: https://github.com/flutter/flutter/issues/124490
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-18 20:41:05 +00:00
Bruno Leroux
d35d4dc958
[Android] Return keyboard pressed state ( flutter/engine#41695 )
...
## Description
This PR updates the Android engine in order to answer to keyboard pressed state queries from the framework (as implemented in https://github.com/flutter/flutter/pull/122885 ).
## Related Issue
Fixes https://github.com/flutter/flutter/issues/122441
Android engine implementation for https://github.com/flutter/flutter/issues/87391
## Tests
Adds 2 tests.
2023-05-18 20:35:21 +00:00
chunhtai
d21dc12d2f
Make iOS embedding to send full uri for deeplinks ( flutter/engine#41992 )
...
related https://github.com/flutter/flutter/issues/100624
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-18 20:31:17 +00:00
Kevin Chisholm
0c46b09bbf
Add configuration for automating release notes ( flutter/engine#42132 )
...
GitHub's automated changelog generation allows teams to setup a configuration file to determine how these changelogs will be generated.
A similar file is available in flutter/flutter for release note generation. As tags have been added to flutter/engine, we now have the ability to generate release notes in the same fashion.
2023-05-18 18:01:06 +00:00
skia-flutter-autoroll
fa4aa93e8d
Roll Skia from 62841fa33e95 to ac47a05bf253 (9 revisions) ( flutter/engine#42131 )
...
https://skia.googlesource.com/skia.git/+log/62841fa33e95..ac47a05bf253
2023-05-18 jamesgk@google.com [graphite] Enable dual-src blending in Metal
2023-05-18 lovisolo@google.com [bazel] Add skia_android_unit_test macro.
2023-05-18 lovisolo@google.com [bazel] Reland reverted CLs due to broken G3 roll.
2023-05-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b35367eac089 to f7b24ac464f9 (4 revisions)
2023-05-18 brianosman@google.com Fix SkString's move constructor
2023-05-18 ccameron@chromium.org HDR gainmaps: Require Version 1.0
2023-05-18 herb@google.com Split the cubic and quad into separate fuzzers
2023-05-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 588114bc957f to 64efc3ca9c0e
2023-05-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9de2cfb06593 to bcbf23c5f184 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 17:59:18 +00:00
skia-flutter-autoroll
34f1cfb7e2
Roll Fuchsia Mac SDK from jNFpQ1gTCMNbzSZCw... to Tl371NrGBEHFYPxHQ... ( flutter/engine#42128 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 16:38:16 +00:00
Jesse Seales
6e5c919f89
Vuln scan github actions permissions ( flutter/engine#42099 )
...
The lack of permissions on the vulnerability scanning github actions
yaml will cause all runs to fail at the upload SARIF to security tab
stage. This change adds the permissions for that stage to succeed.
A successful test run is can be seen here:
https://github.com/flutter/engine/actions/runs/5006551387/jobs/8971979211
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-18 12:08:56 -04:00
skia-flutter-autoroll
23016509fe
Roll Dart SDK from 1991015ad460 to 7bc022c51215 (1 revision) ( flutter/engine#42125 )
...
https://dart.googlesource.com/sdk.git/+log/1991015ad460..7bc022c51215
2023-05-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-123.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 16:07:11 +00:00
skia-flutter-autoroll
b761a2d297
Roll Skia from ad8fa4a38668 to 62841fa33e95 (2 revisions) ( flutter/engine#42123 )
...
https://skia.googlesource.com/skia.git/+log/ad8fa4a38668..62841fa33e95
2023-05-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 28718d8b4108 to f549d5e6c663 (1 revision)
2023-05-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8e2c784328a9 to 588114bc957f (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 16:05:51 +00:00
skia-flutter-autoroll
e8059895ca
Roll Fuchsia Linux SDK from SDKw1RvH0dWiJXERo... to zqkH0qb9GQ3jO24Bh... ( flutter/engine#42124 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 16:04:47 +00:00
skia-flutter-autoroll
4d6655dd51
Roll Skia from a3a9fb5f4a31 to ad8fa4a38668 (1 revision) ( flutter/engine#42121 )
...
https://skia.googlesource.com/skia.git/+log/a3a9fb5f4a31..ad8fa4a38668
2023-05-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 83c5c8b15157 to 97ab6a3a7061 (36 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 05:38:22 +00:00
skia-flutter-autoroll
43091842f1
Roll Dart SDK from 7f6fabbe9fba to 1991015ad460 (4 revisions) ( flutter/engine#42120 )
...
https://dart.googlesource.com/sdk.git/+log/7f6fabbe9fba..1991015ad460
2023-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-122.0.dev
2023-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-121.0.dev
2023-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-120.0.dev
2023-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-119.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 04:24:22 +00:00
skia-flutter-autoroll
b3447d9c05
Roll Fuchsia Mac SDK from wNfsef5we4l8hxEII... to jNFpQ1gTCMNbzSZCw... ( flutter/engine#42118 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 03:54:07 +00:00
skia-flutter-autoroll
ba7ce87738
Roll Skia from caff30d16ae7 to a3a9fb5f4a31 (1 revision) ( flutter/engine#42117 )
...
https://skia.googlesource.com/skia.git/+log/caff30d16ae7..a3a9fb5f4a31
2023-05-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7d17e63c2439 to b35367eac089 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 03:25:04 +00:00
skia-flutter-autoroll
c3335ebe05
Roll Skia from ffa425bacfc4 to caff30d16ae7 (29 revisions) ( flutter/engine#42116 )
...
https://skia.googlesource.com/skia.git/+log/ffa425bacfc4..caff30d16ae7
2023-05-17 johnstiles@google.com Simplify if-else chain in releaseProgram.
2023-05-17 johnstiles@google.com Move Parser::Checkpoint out of the header.
2023-05-17 bungeman@google.com Regularize DirectWrite format handling
2023-05-17 bungeman@google.com Reorganize DirectWrite glyph representation selection
2023-05-17 michaelludwig@google.com [skif] Don't intersect against desired output unnecessarily
2023-05-17 johnstiles@google.com Migrate DSLCore::ReleaseProgram into Compiler.
2023-05-17 johnstiles@google.com Remove Declare(DSLGlobalVar) from DSLCore.
2023-05-17 johnstiles@google.com Eliminate src/sksl/dsl/priv directory.
2023-05-17 johnstiles@google.com Eliminate DSLWriter entirely.
2023-05-17 johnstiles@google.com Migrate DSLWriter::Var to VarDeclaration::Convert.
2023-05-17 nicolettep@google.com [graphite] Create & cache descriptor sets
2023-05-17 michaelludwig@google.com [skif] Update SkShaderImageFilter to use FilterResult
2023-05-17 jmbetancourt@google.com [skottie] add proxy to PropertyObserver
2023-05-17 brianosman@google.com Revert "Add src/cityhash"
2023-05-17 johnstiles@google.com Remove unreferenced header DSL.h.
2023-05-17 jamesgk@google.com [graphite] Enable framebuffer fetch on Metal
2023-05-17 jamesgk@google.com [graphite] Use framebuffer fetch when available
2023-05-17 kjlubick@google.com Move SkStrikeSpec::MakeSDFT to src/text/gpu
2023-05-17 kjlubick@google.com Enforce IWYU on SkStrike* and src/text/*
2023-05-17 brianosman@google.com Add src/cityhash
2023-05-17 jvanverth@google.com [graphite] Fix YV12 colors.
2023-05-17 johnstiles@google.com Disallow calling DSLWriter::Var more than once.
2023-05-17 jmbetancourt@google.com [skottie] accept a proxy for SlotManager's ResourceProvider
2023-05-17 johnstiles@google.com Delete dead code in DSLWriter.
2023-05-17 brianosman@google.com Move SkChecksum.h from include/private to src/core
2023-05-17 johnstiles@google.com Add TArray::reserve_exact for exact-fit sizing.
2023-05-17 kjlubick@google.com Delete unused shim image factory code
2023-05-17 jvanverth@google.com [graphite] Fix encoded origin for YUVA textures.
2023-05-17 johnstiles@google.com Move symbol-table parameter setup inside FunctionDeclaration.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 02:25:22 +00:00
Chris Bracken
871632b29b
[macOS] Clean up PlatformView mutator scaling ( flutter/engine#42110 )
...
When applying platform view mutators, the mutations array includes a
transform from logical to physical coordinates. Since Cocoa deals only
in logical points, we inject a physical to logical coordinate transform
to counteract this.
Rather than applying this multiple times throughout the
`[FlutterMutatorView applyFlutterLayer]` method we gather a list of
transforms that includes the additional physical to logical scale
transform.
This change is a cleanup change for readability and makes no semantic
changes to how mutator views are applied. Existing unit tests in
[FlutterMutatorViewTest.mm](https://github.com/flutter/engine/blob/main/shell/platform/darwin/macos/framework/Source/FlutterMutatorViewTest.mm )
are expected to pass without changes.
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-17 17:11:51 -07:00
Xilai Zhang
3b3f315061
[g3 roll] Revert "add non-rendering operation culling to DisplayListBuilder" ( flutter/engine#42097 )
...
temporary revert of flutter/engine#41463
context: b/283038609
2023-05-17 23:48:04 +00:00
skia-flutter-autoroll
be1a1d5cfe
Roll Fuchsia Linux SDK from YrEDYUB9NKhirgo5s... to SDKw1RvH0dWiJXERo... ( flutter/engine#42100 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 19:56:04 +00:00
Jonah Williams
0b212a6348
[Impelller] fix flickering due to synchronization issues in compute tessellator. ( flutter/engine#42076 )
...
We must wait until the compute command buffer has completed before its safe to use the contents of that buffer. THis fixes the flickering I've observed when running the unit test locally.
Test only change, no impact to shipped code.
2023-05-17 18:57:15 +00:00
Renzo Olivares
79df264a52
[Android] Do not collapse text selection on shift key up ( flutter/engine#42075 )
...
Fixes https://github.com/flutter/flutter/issues/101569
This block of code was originally introduced in https://github.com/flutter/engine/pull/15560 , but removing it does not have any affect on the software text editing controls in GBoard.
Before this change
* shift + arrow right/left selection would collapse after releasing the shift key.
* shift + mouse click to expand selection would collapse after releasing the shift key.
After this change
* shift key up no longer collapses the selection.
2023-05-17 18:53:03 +00:00
Mouad Debbar
46598122f7
[web] Simplify handling of custom url strategy ( flutter/engine#42043 )
...
Issue: https://github.com/flutter/flutter/issues/126831
2023-05-17 18:27:14 +00:00
Dan Field
ae728938fc
Report displays for macOS ( flutter/engine#41998 )
...
https://github.com/flutter/flutter/issues/125939 and https://github.com/flutter/flutter/issues/125938 for macOS
fixes https://github.com/flutter/flutter/issues/121352
2023-05-17 17:17:23 +00:00
Dan Field
85ba96cbbb
Fix bounds when painting style is stroke width for image shaders ( flutter/engine#42052 )
...
Fixes https://github.com/flutter/flutter/issues/126739
When we're sampling from the texture, we need to sample from its origin regardless of how much offset the stroke width gives to the path.
2023-05-17 17:02:18 +00:00
Jesse Seales
d41a0690bc
Re-Enable Vulnerability 3p Scanning Workflow ( flutter/engine#42049 )
...
After migrating to standalone yaml (rather than included as a part of the scorecards yaml), the vuln scanning workflow needs to be re-enabled with sarif results uploading to the dashboard under the security tab. A successful test run of this workflow can be seen at https://github.com/flutter/engine/actions/runs/4982210161 (in linked run, fails to upload SARIF file given lack of permissions on any branch besides default)
This change also adds use of cwd in python subprocess commands rather than using directory prefix in command string.
Addresses b/280294707
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-17 16:22:58 +00:00
skia-flutter-autoroll
d0f2fadc93
Roll Skia from c3473c32bb35 to ffa425bacfc4 (14 revisions) ( flutter/engine#42095 )
...
https://skia.googlesource.com/skia.git/+log/c3473c32bb35..ffa425bacfc4
2023-05-17 robertphillips@google.com Create Protected EGL contexts when possible on Android
2023-05-17 johnstiles@google.com Delete dead code in DSLStatement.
2023-05-17 johnstiles@google.com Add Block::MakeCompoundStatement.
2023-05-17 jvanverth@google.com [graphite] Remove spurious text method.
2023-05-17 kjlubick@google.com Manually Roll Dawn from 89a3dac88297 to 83c5c8b15157 (41 revisions)
2023-05-17 johnstiles@google.com Remove unnecessary return value from Parser::structVarDeclaration.
2023-05-17 johnstiles@google.com Restructure AddVarDeclaration to not require friendship.
2023-05-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 32a999c86b9c to 7d17e63c2439 (11 revisions)
2023-05-17 michaelludwig@google.com [skif] Shore up getOutputLayerBounds() for old filter definitions
2023-05-17 johnstiles@google.com Move force-noinline support out of DSL.
2023-05-17 michaelludwig@google.com [skif] Update SkPictureImageFilter to use FilterResult
2023-05-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 25def1a0da1c to 9de2cfb06593 (17 revisions)
2023-05-17 jvanverth@google.com [graphite] Add YUVA shader.
2023-05-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a62e8dbc3467 to 28718d8b4108 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 16:20:09 +00:00
gaaclarke
837b7df872
[Impeller] Turned on wide gamut support by default. ( #39801 ) ( flutter/engine#41965 )
...
relands flutter/engine#39801
forward fix for internal customers at cl/531288297
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-17 09:11:42 -07:00
skia-flutter-autoroll
bfb1029c9d
Roll Fuchsia Mac SDK from dIATtSiPf8KE25MMF... to wNfsef5we4l8hxEII... ( flutter/engine#42094 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 15:04:08 +00:00
skia-flutter-autoroll
8bda466119
Roll Skia from 88d7a68694d9 to c3473c32bb35 (2 revisions) ( flutter/engine#42093 )
...
https://skia.googlesource.com/skia.git/+log/88d7a68694d9..c3473c32bb35
2023-05-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 8e2c784328a9 to ee89bbd2db69
2023-05-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from cbe6e1312c42 to 8e2c784328a9 (22 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 14:24:10 +00:00
skia-flutter-autoroll
e3d34d9192
Roll Dart SDK from 2fc9f4dd9623 to 7f6fabbe9fba (1 revision) ( flutter/engine#42090 )
...
https://dart.googlesource.com/sdk.git/+log/2fc9f4dd9623..7f6fabbe9fba
2023-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-118.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 07:12:34 +00:00
skia-flutter-autoroll
a9dec00215
Roll Fuchsia Linux SDK from D_EOM3rJ8AMk3-Wex... to YrEDYUB9NKhirgo5s... ( flutter/engine#42086 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 03:50:24 +00:00
skia-flutter-autoroll
31b74077a0
Roll Dart SDK from dbbb8a6d79a3 to 2fc9f4dd9623 (1 revision) ( flutter/engine#42085 )
...
https://dart.googlesource.com/sdk.git/+log/dbbb8a6d79a3..2fc9f4dd9623
2023-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-117.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 03:20:02 +00:00