21053 Commits

Author SHA1 Message Date
skia-flutter-autoroll
ed291418bd Roll Skia from b7508e2f2577 to 5974e36ea190 (4 revisions) (flutter/engine#39639)
https://skia.googlesource.com/skia.git/+log/b7508e2f2577..5974e36ea190

2023-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bb14a2634243 to 0e098d4e3f1d (4 revisions)
2023-02-14 herb@google.com Move path and drawable to simpler buffers
2023-02-14 lovisolo@google.com Fix the Skia Infra -> Skia roller.
2023-02-14 brianosman@google.com Disable all unit tests on Spin513

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-15 02:15:35 +00:00
Brandon DeRosier
229f0f82c1 [Impeller] Make RenderTarget::CreateOffscreen utilities have a stencil by default (flutter/engine#39636) 2023-02-14 17:04:39 -08:00
skia-flutter-autoroll
b833a44acf Roll Skia from a3fe5233eb10 to b7508e2f2577 (3 revisions) (flutter/engine#39634)
https://skia.googlesource.com/skia.git/+log/a3fe5233eb10..b7508e2f2577

2023-02-14 jmbetancourt@google.com add window context tooling uncoupled from sk_app
2023-02-14 nicolettep@google.com [graphite] Add VulkanTexture::setImageLayout and associated methods
2023-02-14 johnstiles@google.com Remove Xoogler from SkSL owners.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-14 22:34:05 +00:00
Zachary Anderson
994d61bbcf Fix build output path of the malioc core list (flutter/engine#39629) 2023-02-14 13:57:46 -08:00
Jonah Williams
0ecfed28d3 [Impeller] read from framebuffer for advanced blends on iOS. (flutter/engine#39567)
* [impeller] read from framebuffer for advanced blends

* ++

* update to contents

* move to separate contents

* ++

* set stencil depth duh

* ++

* ++

* remove debug info

* update licenses

* Add FML_OS_PHYSICAL_IOS

* ++

* ++
2023-02-14 21:27:07 +00:00
Michael Goderbauer
2693ea12a5 Add app anatomy diagram (flutter/engine#39628) 2023-02-14 20:34:00 +00:00
skia-flutter-autoroll
5a5c15bba3 Roll Skia from 67a8177742e6 to a3fe5233eb10 (9 revisions) (flutter/engine#39627)
https://skia.googlesource.com/skia.git/+log/67a8177742e6..a3fe5233eb10

2023-02-14 brianosman@google.com Disable failing tests on Spin513
2023-02-14 brianosman@google.com Skip (flaky) cartman.svg on iPhone + mtltestprecompile
2023-02-14 brianosman@google.com Ignore more flaky tests on Intel + Linux + gltestthreading
2023-02-14 jamesgk@google.com Revert "Define GraphiteGM whose onDraw method takes a graphite Context"
2023-02-14 jvanverth@google.com Update CanvasKit to use new gpuSetup signature
2023-02-14 lehoangquyen@chromium.org [graphite-dawn] Correctly set the binding size of uniform buffers
2023-02-14 herb@google.com Make paintMasks take a simpler buffer
2023-02-14 brianosman@google.com Remove SwiftShader GL support
2023-02-14 kjlubick@google.com Address some clang-tidy warnings

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-14 19:44:24 +00:00
Jonah Williams
e0a3218055 [Impeller] Special case color filter in tiled texture. (flutter/engine#39445)
* [impeller] special case color filter in tiled texture

* stdmove

* add texture size testing

* comments and exact size

* enable/disable

* remove test in release mode

* remove stencil attachment

* back out allocator change

* ++

* more comment
2023-02-14 19:25:50 +00:00
Jason Simmons
cf1add3a71 [impellerc] Generate GLSL output for the runtime-stage-gles target (flutter/engine#39602) 2023-02-14 19:24:33 +00:00
Kaushik Iska
4beb3bd963 [impeller] Refactored backend specific feature checks to capabilities (flutter/engine#39598)
part of https://github.com/flutter/flutter/issues/120498
2023-02-14 14:19:38 -05:00
Jason Simmons
239f32f794 Fix a flake in EmbedderTest.CompositorRenderTargetsNotRecycledWhenAvoidsCacheSet (flutter/engine#39596)
The test assumes that the fixture app has scheduled a specific number
of frames.  The fixture should stop scheduling after that point.

See https://github.com/flutter/flutter/issues/106589
2023-02-14 19:10:33 +00:00
Jason Simmons
086ad21bfb [Impeller] Avoid stringstream usage in CreateUniformMemberKey (flutter/engine#39606)
Also fix a typo in the function name
2023-02-14 19:10:30 +00:00
Zachary Anderson
4674b2ac34 Add more info to malioc_diff.py output (flutter/engine#39625) 2023-02-14 18:57:17 +00:00
Jason Simmons
cc7053c793 Remove libpng dependency in the APNG decoder (flutter/engine#39622) 2023-02-14 10:20:15 -08:00
skia-flutter-autoroll
4504361bdb Roll Skia from 8de7f68a3661 to 67a8177742e6 (4 revisions) (flutter/engine#39623)
https://skia.googlesource.com/skia.git/+log/8de7f68a3661..67a8177742e6

2023-02-14 michaelludwig@google.com [graphite] Remove unnecessary vertices/triangles from AnalyticRRectRenderStep mesh
2023-02-14 jamesgk@google.com [graphite] Replay recordings with integer translations
2023-02-14 ccameron@chromium.org SkJpegMultiPicture: Add encoding support (part 1)
2023-02-14 jvanverth@google.com [graphite] Make GM:gpuSetup() more backend agnostic.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-14 17:49:40 +00:00
skia-flutter-autoroll
b5afe268da Roll Skia from 38e363bbf0e4 to 53f66167d9cb (4 revisions) (flutter/engine#39615)
https://skia.googlesource.com/skia.git/+log/38e363bbf0e4..53f66167d9cb

2023-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 62d35a602258 to 5c2a60102596 (9 revisions)
2023-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 938d3a1fac4d to a36600f98b9b (2 revisions)
2023-02-13 jlavrova@google.com Fix for RTL ellipsis
2023-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 428c60617e42 to 2405a8767ae1 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-14 07:26:25 +00:00
godofredoc
acd9548b0f Remove bringup from builds. (flutter/engine#39605)
* Remove bringup from builds.

Windows arm, Linux Fuchsia FEMU and Linux Fuchsia FEMU arm64 have been
passing consistently.

* Set fuchsia back to bringup.
2023-02-14 05:34:05 +00:00
skia-flutter-autoroll
9002ee903b Roll Skia from f27efe15433d to 38e363bbf0e4 (8 revisions) (flutter/engine#39611)
https://skia.googlesource.com/skia.git/+log/f27efe15433d..38e363bbf0e4

2023-02-13 johnstiles@google.com Fix ASAN issue with shuffle ops.
2023-02-13 thakis@chromium.org SkICC: Write valid date in ICC header
2023-02-13 johnstiles@google.com Remove unused SkRP load/store ops.
2023-02-13 johnstiles@google.com Remove unused SkRP op immediate_f.
2023-02-13 michaelludwig@google.com [graphite] Fully enable AnalyticRRectRenderStep
2023-02-13 jvanverth@google.com [graphite] Add support for Vulkan barriers
2023-02-13 lehoangquyen@chromium.org [graphite-dawn] Implement loading MSAA from resolve.
2023-02-13 johnstiles@google.com Disable short-circuit tests on iOS OpenGL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-14 03:16:19 +00:00
Chris Yang
3752de518f Revert "[ios_platform_view] MaskView pool to reuse maskViews." (flutter/engine#39608)
* Revert "Revert "Revert "[ios_platform_view] MaskView pool to reuse maskViews. (#38989)" (#39490)" (#39498)"

This reverts commit d1a1fc6b9005519f7b9c09330a5f30d9c974c35a.

* fix build error
2023-02-14 02:14:33 +00:00
Jonah Williams
f112c452b8 Revert "Add support for double tap action from Apple Pencil 2 (#39267)" (flutter/engine#39607)
This reverts commit adb83f7d563aaaa44148f7b6a6c76846feb17cb3.
2023-02-14 02:04:06 +00:00
Dan Field
c741516473 Fix multi-function compute (flutter/engine#39603) 2023-02-14 00:34:28 +00:00
Jim Graham
90f2be70dd remove use of SkCanvas and DLCanvasRecorder from ui.Canvas native code (flutter/engine#39599) 2023-02-14 00:12:36 +00:00
Kate Lovett
c4ab739105 Add unique device id for trackpad on web (flutter/engine#39260)
* Unique device id for trackpad on web

* ++
2023-02-13 23:49:28 +00:00
LouiseHsu
adb83f7d56 Add support for double tap action from Apple Pencil 2 (flutter/engine#39267)
* working commit

* some clean up

* white space fixes

* whitespace

* remove unused import

* Addressing PR comment, fix tests, update touch packet on Andriod

* formatting n whitespace again

* add new field to web ui pointer.dart

* update test

* whitespace

* fix test

* PR comments

* fix test

* whitespace

* fix test by factoring out logic into helper function

* whitespace

* fix malformed string

* pr comments

* fix type issue

* sigh whitespace

* revert test changes :)

* pr comments + separate out tests

* extra space

* change test name
2023-02-13 21:52:45 +00:00
Brandon DeRosier
b060a89a91 [Impeller] Fix unsafe access for clip stencil coverage (flutter/engine#39595) 2023-02-13 21:51:05 +00:00
skia-flutter-autoroll
7859fad7f3 Roll Skia from 9cc86b2a4f27 to f27efe15433d (17 revisions) (flutter/engine#39593)
https://skia.googlesource.com/skia.git/+log/9cc86b2a4f27..f27efe15433d

2023-02-13 johnstiles@google.com Replace very simple ternaries with mix.
2023-02-13 jiulongw@vibe.us Remove index mappings from SkParagraphCache
2023-02-13 kjlubick@google.com [base] Move SkMSAN into base
2023-02-13 fmalita@chromium.org [skottie] Visual text valign
2023-02-13 johnstiles@google.com Implement fixed-value indexing into temporary values.
2023-02-13 brianosman@google.com Validate SkBlendMode in serialized drawAtlas and drawEdgeAAQuad
2023-02-13 jvanverth@google.com [graphite] Add Dawn Windows job.
2023-02-13 jcgregorio@google.com Add -prune to gazelle_update_repo run of gazelle.
2023-02-13 johnstiles@google.com Reorder the inputs to RP mix() stage.
2023-02-13 herb@google.com Scale strike width for SDFT
2023-02-13 johnstiles@google.com Disable short-circuit tests on Mac OpenGL.
2023-02-13 johnstiles@google.com Convert TernarySideEffects test to a shared SkSL test.
2023-02-13 kjlubick@google.com Add presubmit to generate error if private API is used in named fiddles
2023-02-13 kjlubick@google.com Move SkRandom and SkFixed into base
2023-02-13 johnstiles@google.com Disable test SkSLIntrinsicMixFloatES3_GPU on Win + RTX3060.
2023-02-13 johnstiles@google.com Convert ShortCircuitLogicalAnd test to a shared SkSL test.
2023-02-13 johnstiles@google.com Convert ShortCircuitLogicalOr test to a shared SkSL test.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-13 21:11:45 +00:00
Matthias Nehlsen
c10f7f2705 [Impeller] Fix grammatical issues in faq.md. (flutter/engine#39582) 2023-02-13 12:45:24 -08:00
Brandon DeRosier
625740144c [Impeller] Return entity from filters instead of a snapshot (flutter/engine#39560) 2023-02-13 11:56:46 -08:00
Tong Mu
0c61f95c3f Reland [macOS] Make FlutterEngine support multiple views (flutter/engine#39576) 2023-02-13 10:21:53 -08:00
Chinmay Garde
c05592f533 [Impeller] Get rid of message about prototype status. (flutter/engine#39566) 2023-02-13 10:10:30 -08:00
Jason Simmons
5f09e0fdf0 Remove Libtxt and Minikin (flutter/engine#39499) 2023-02-13 17:16:04 +00:00
William Hesse
39f9c3374b Change run_tests.sh to use python3 (flutter/engine#39586) 2023-02-13 16:57:16 +00:00
skia-flutter-autoroll
015d40f56b Roll Fuchsia Linux SDK from R6oclCbqlvHdyGgut... to 5b_BYTPWG1E7qx1I8... (flutter/engine#39590)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-13 16:11:04 +00:00
skia-flutter-autoroll
0eaa1aaac4 Roll Skia from d85501fa487d to 9cc86b2a4f27 (2 revisions) (flutter/engine#39589)
https://skia.googlesource.com/skia.git/+log/d85501fa487d..9cc86b2a4f27

2023-02-13 kjlubick@google.com Add fall-back binary search for cubic roots when splitting
2023-02-13 kjlubick@google.com Add test cases in preparation for porting binary search cubic solution

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-13 15:47:18 +00:00
dependabot[bot]
ac7218fdbe Bump github/codeql-action from 2.1.39 to 2.2.4 (flutter/engine#39584)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.39 to 2.2.4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](a34ca99b46...17573ee1cc)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-13 09:45:23 +00:00
Brandon DeRosier
4e5f649aa4 [Impeller] Source the pipeline color attachment pixel format from RenderPass textures (flutter/engine#39556) 2023-02-12 18:48:53 -08:00
skia-flutter-autoroll
bf3853e85b Roll Fuchsia Linux SDK from MVMTNxWJaWdwPWstz... to arbaBzyUE2ok1bGl5... (flutter/engine#39563)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-11 20:49:05 +00:00
skia-flutter-autoroll
3698fdf5fd Roll Fuchsia Linux SDK from 482Njb1v72P7fNyj4... to MVMTNxWJaWdwPWstz... (flutter/engine#39559)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-11 07:00:16 +00:00
skia-flutter-autoroll
88fa8fb206 Roll Skia from 6c3097e6f833 to ac09a28afd34 (1 revision) (flutter/engine#39558)
https://skia.googlesource.com/skia.git/+log/6c3097e6f833..ac09a28afd34

2023-02-11 michaelludwig@google.com [graphite] Handle complex rrect coverage in fragment shader

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-11 05:11:19 +00:00
skia-flutter-autoroll
a93f03c643 Roll Skia from 5230650dc096 to 70a3a194ec98 (2 revisions) (flutter/engine#39554)
https://skia.googlesource.com/skia.git/+log/5230650dc096..70a3a194ec98

2023-02-10 johnstiles@google.com Add RP support for mix(vec, vec, bvec).
2023-02-10 johnstiles@google.com Add ES3 test for mix intrinsic.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-11 02:22:20 +00:00
skia-flutter-autoroll
2ed3ed5657 Roll Skia from f0fc6aa4d797 to 5230650dc096 (4 revisions) (flutter/engine#39551)
https://skia.googlesource.com/skia.git/+log/f0fc6aa4d797..5230650dc096

2023-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from e416854f1271 to ba39d81f9797 (1 revision)
2023-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 00e3edd6b635 to e780219ed8ba (2 revisions)
2023-02-10 bungeman@google.com Remove SetVariableColrV1EnabledFunc
2023-02-10 jvanverth@google.com GenDistanceFieldFromVector: use midpoint of quad for calculating bounds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-11 00:27:53 +00:00
gaaclarke
f51ea3b01f [Impeller] Adds wide gamut support for iOS. (flutter/engine#39111)
* Implemented wide gamut images for iOS

Moved the surface to an extended range color format.

* wrong gamma but default pixel format set to bgra10_xr

* BGR10_XR add

* format

* updated todos

* updated todo with information about pixel formats

* switched logic for determining if we have a wide gamut image

* cleaned up gamut math to match style and linked source

* made the color attachment pixel format match the surface

* updated vulkan format switch

* removed comment

* added enable disable switch

* moved default to bgr10 for now since there is a bug where someone is still reading this, msaa?

* fixed the decoder settings to make sure we don't lose wide gamut colors

* fixed stored srgb gamut variable

* fixed false lint

* updated test

* added ability to grab the surface data for tests

* made the screenshot utility return the format

* added width and height to the platform channel payload

* fixed a couple of broken targets

* moved back the default pixel buffer format

* cleanup and add docstrings

* made the surfacedata feature only available in debug builds

* added decoding unit test

* fixed objc tests

* turned off by default

* bdero feedback1

* bdero2

* bdero3

* fixed merge issue

* removed using std::shared_ptr
2023-02-11 00:08:20 +00:00
Chris Bracken
93ef23fca0 [macOS] Add XCode marks for TextInputPlugin (flutter/engine#39550)
Adds marks to cleanly separate the sections of TextInputPlugin when
viewing in XCode and other IDEs that recognise #pragma mark. This file
is getting pretty long.

No tests since this is a cleanup with no functional changes.
2023-02-10 23:46:07 +00:00
Brandon DeRosier
6bac0673e3 [Impeller] Don't use unnecessary stencil attachments (flutter/engine#39537) 2023-02-10 14:16:13 -08:00
skia-flutter-autoroll
9022713f48 Roll Skia from 640fa258fc75 to f0fc6aa4d797 (1 revision) (flutter/engine#39548)
https://skia.googlesource.com/skia.git/+log/640fa258fc75..f0fc6aa4d797

2023-02-10 herb@google.com Add preparing images, paths, and drawables to API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-10 21:55:17 +00:00
Matej Knopp
066c6c6d8f Use DisplayListMatrixClipTracker in DiffContext (flutter/engine#38010) 2023-02-10 20:50:28 +00:00
Jim Graham
99de2ca94b add support to run dl_canvas_unittests on GPU surfaces (off by default) (flutter/engine#38993)
* add support to run dl_canvas_unittests on GPU surfaces (off by default)

* empty commit to trigger build

* conditionally include platform-specific surface provider headers

* ignore DL test files during license checks

* typo

* add dependencies to rendertests to hopefully build on Windows

* remove benchmarking deps from dl_rendertests

* more changes to get Windows rendertests to link

* add --enable-gl synonym and prevent non-SW surface provider dest on Windows

* fix gn formatting

* review feedback
2023-02-10 20:43:13 +00:00
skia-flutter-autoroll
dd59597ec7 Roll Skia from 54342413f5c0 to 640fa258fc75 (3 revisions) (flutter/engine#39544)
https://skia.googlesource.com/skia.git/+log/54342413f5c0..640fa258fc75

2023-02-10 brianosman@google.com Implement SkWorkingFormatColorFilter in Raster Pipeline
2023-02-10 herb@google.com Disable drawing stroked glyphs with SDFT
2023-02-10 bungeman@google.com Remove GetVariableColrV1Enabled

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-02-10 19:54:10 +00:00
Justin McCandless
2e0bee3e44 Revert "Remove deprecated TextInputClient scribble method code" (flutter/engine#39516)
Fixes the scribble feature (iPad handwriting input via Apple Pencil).
2023-02-10 11:48:43 -08:00
David Iglesias
65625a017b [web] Fixes invisible platform view compositing edge cases. (flutter/engine#39506)
* Somewhat works... Remove first overlay though.

* needNewOverlay is equivalent to isVisible in the algorithm.

* Only consider groups with a visible view to need an overlay.

* Update tests with new logic. Make test output easier to understand and find in the test file.

* Introduce OverlayGroup helper class.
2023-02-10 19:17:12 +00:00