DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Impeller] Avoid stringstream usage in CreateUniformMemberKey (flutter/engine#39606)

Browse Source 
Also fix a typo in the function name
This commit is contained in:
Jason Simmons 2023-02-14 11:10:30 -08:00 committed by GitHub
parent f1426b7583
commit 086ad21bfb
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
engine/src/flutter/impeller/renderer/backend/gles/buffer_bindings_gles.cc
View File

@ -6,7 +6,6 @@
#include <algorithm>
#include <cstring>
#include <sstream>
#include <vector>
#include "impeller/base/config.h"
@ -70,18 +69,21 @@ static std::string NormalizeUniformKey(const std::string& key) {
return result;
}
static std::string CreateUnifiormMemberKey(const std::string& struct_name,
const std::string& member,
bool is_array) {
std::stringstream stream;
stream << struct_name << "." << member;
static std::string CreateUniformMemberKey(const std::string& struct_name,
const std::string& member,
bool is_array) {
std::string result;
result.reserve(struct_name.length() + member.length() + (is_array ? 4 : 1));
result += struct_name;
result += '.';
result += member;
if (is_array) {
stream << "[0]";
result += "[0]";
}
return NormalizeUniformKey(stream.str());
return NormalizeUniformKey(result);
}
static std::string CreateUnifiormMemberKey(
static std::string CreateUniformMemberKey(
const std::string& non_struct_member) {
return NormalizeUniformKey(non_struct_member);
}
@ -216,7 +218,7 @@ bool BufferBindingsGLES::BindUniformBuffer(const ProcTableGLES& gl,
size_t element_count = member.array_elements.value_or(1);
const auto member_key =
CreateUnifiormMemberKey(metadata->name, member.name, element_count > 1);
CreateUniformMemberKey(metadata->name, member.name, element_count > 1);
const auto location = uniform_locations_.find(member_key);
if (location == uniform_locations_.end()) {
// The list of uniform locations only contains "active" uniforms that are
@ -318,7 +320,7 @@ bool BufferBindingsGLES::BindTextures(const ProcTableGLES& gl,
return false;
}
const auto uniform_key = CreateUnifiormMemberKey(texture.second.isa->name);
const auto uniform_key = CreateUniformMemberKey(texture.second.isa->name);
auto uniform = uniform_locations_.find(uniform_key);
if (uniform == uniform_locations_.end()) {
VALIDATION_LOG << "Could not find uniform for key: " << uniform_key;