6516 Commits

Author SHA1 Message Date
Ben Konyi
ecaf99929c Roll src/third_party/dart ac1bf656c4..2e5453ddb4 (42 commits)
2e5453ddb4 [ VM ] Updated licenses to match other licenses in project
3d71abcada Prepare to publish a new version of the analyzer_plugin package with an updated dependency on analyzer
ebf319b64b Clean up some lingering references to type propogation
be47aad327 [VM/Compiler/AOT] Bare instructions 9: Improve write barrier on ARM/ARM64/X64
10f63f806d [gardening] Mark io/stdout_stderr_non_blocking_test flaky on x64
8b214f4d72 Restore type parser from reify project
65dde13f1b Don't check formatting of Front-End test cases
53217e6eb1 [kernel] Add ability to (de)serialize DirectMethodInvocation
5048889c54 [kernel] Add ability to (de)serialize StaticInvocation
7ea2dfad20 [kernel] Add ability to (de)serialize DirectPropertySet
50c06c55ba [kernel] Add ability to (de)serialize DirectPropertyGet
793fbc0d4a [kernel] Add ability to (de)serialize StaticSet
581af6eb56 [co19] DEPS and status file updated
b0017d758c Refer to correct locations in SDK (and other dill files)
da6938a5b2 After some more `git cl uploads`, this fixes a bunch of little problems in the spec that we have noted over time.
c9a55b437a [Kernel] Remove the dedicated fromEnvironment constants
1a0367a373 Create test which demonstrates issues 35558 and 35559
6205d7e82c [kernel] Add ability to (de)serialize StaticGet
e529988474 [kernel] Rename ScopedReference to ScopedUse
f437fa02c2 [kernel] Nest *Environment into *State for (de)serialization
0dea413d94 Tests for reachability, fix for try/finally.
e3302cdb8f Follow-up to storing problems in the ast
dd04c374b8 [vm,dart:io] On Linux, Android, and Fuchsia the getsockopt parameter is incorrect.
e64428a839 Revert "[vm] Cleanup Dart_Get/Set/HasStickyError API and use isolate's sticky error only as a backup for thread's sticky error"
324718fadd [vm] Revert "Restore TLABs."
5a607755b2 [ VM / dart:io ] Fixed issue where writing to a socket after it has been closed would raise SIGPIPE and crash the process.
6b5e8603d5 Reland "[vm/compiler] AOT inline heuristics improvements"
06a1e6e9e3 [vm] Enable timeline on Fuchsia even in product mode.
2faab1d4c0 Update AstBuilder to build spread collection AST structures
b10f179608 [vm] Cleanup Dart_Get/Set/HasStickyError API and use isolate's sticky error only as a backup for thread's sticky error
5b1daaac6c Exposes a thin layer over getsockopt/setsockopt for supported platforms.
c701e76506 [vm/compiler] handle non-nullable null situation better
b692a6d183 Improvements for flow analysis.
fc62cf0373 [infra] Fix co19 git URL in DEPS
e7bd3edc9f [vm] Assert callback state for all Dart_Set*ReturnValue, take 2.
ddce2824fa Add more spread collection fasta test cases
6639cbd6c3 Add AstBuilder spread-collections and control-flow-collections flags
1020a22290 [dart2js] Do more native method inlining
f353719b08 Ignore unnecessary_cast hint.
3513f872ce Extract DartFileEditBuilder.importLibrary() into separate file.
46080dd886 Update DEPS to check out co19 tests from dart.googlesource.com
ca2db2ad53 [VM/Compiler/AOT] Bare instructions 8: Improve AOT code by using pc-relative calls
2019-01-18 13:42:29 -08:00
Chinmay Garde
00fc057d88 Configure the embedder in AOT in "profile" and "release" runtime modes. (flutter/engine#7533) 2019-01-18 12:24:21 -08:00
Ben Konyi
1322806e2c Roll src/third_party/dart da09945643..ac1bf656c4 (22 commits) (flutter/engine#7527)
ac1bf656c4 Non-breaking changes to add code-as-ui support
3919491d3e Improvements for flow analysis.
17a439633d Add a custom LSP method dart/diagnosticServer to start server/return port
7e05c2cd62 Add ability to generate custom classes for custom LSP methods
cf24135753 [Gardening] Skip vm/dart/bare_instructions_trampolines_test on android
b00193fa5f [Kernel] Signal an error for invalid native invocations
d51a847891 Integrating generic-function-instantiation.md into dartLangSpec.tex
21c42e914e Compute supertypes
181b3898eb Follow up on review comments
660c33fde6 Add TypeBuilder.declaration
3e24b60516 Hierarchy expectation files
ef2e000a52 Share expectation matching
f3cee0147c Fast versions of legacy and strong tests.
e3d6709289 Error message for circular constant expressions
16ddc23a57 [VM/Compiler/AOT] Bare instructions 7: Trampolines for out-of-range calls
37e06d34b2 Create breaking-changes.md
6dfb3e9f60 [vm/tools] Add pkg/vm/bin/compare_sizes.dart
dab228e55f Save problems in ast - fasta changes
1c82f6757c Save problems in ast - kernel format changes
ddc1de50d6 Use ClassHierarchyBuilder in all modes.
430560d928 Track parameter use in invocations in MemberUsage
e36ad1dad0 [Kernel] Build an invalid constant for evaluation errors
2019-01-17 16:13:48 -08:00
skia-flutter-autoroll
e094a6822b Roll src/third_party/skia 31972f889641..57263c2e0ccd (3 commits) (flutter/engine#7529)
https://skia.googlesource.com/skia.git/%2Blog/31972f889641..57263c2e0ccd

git log 31972f889641ee4e34d30ed5c6c61c5b21a0ecb1..57263c2e0ccddf4dd62814c427a39d9d615acbe5 --date=short --no-merges --format=%ad %ae %s
2019-01-17 jvanverth@google.com Add compressed data support for SkImage.
2019-01-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 296aa2513448..739a7fbe086b (3 commits)
2019-01-07 halcanary@google.com SkDocument: use `auto` for MakeDocument().

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-17 17:40:40 -05:00
Dan Field
e53df3e546 Ensure the ResourceContext is not ripped out from under dart (flutter/engine#7528)
* Ensure the ResourceContext is not ripped out from under dart
2019-01-17 13:55:44 -08:00
skia-flutter-autoroll
2e1ac7c8a0 Roll src/third_party/skia a4e46804946c..31972f889641 (8 commits) (flutter/engine#7526)
https://skia.googlesource.com/skia.git/%2Blog/a4e46804946c..31972f889641

git log a4e46804946c5f9554068ba7adfee7376697d77a..31972f889641ee4e34d30ed5c6c61c5b21a0ecb1 --date=short --no-merges --format=%ad %ae %s
2019-01-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader af4ed53dab6b..296aa2513448 (1 commits)
2019-01-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 dd34b3b9b707..d46165e3db5a (9 commits)
2019-01-17 reed@google.com remove empty skia_for_chromium_defines
2019-01-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 57378335838c..af4ed53dab6b (1 commits)
2019-01-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e04d9b0f138d..57378335838c (2 commits)
2019-01-17 scroggo@google.com Update libwebp to 1.0.2-rc1
2019-01-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader fed67899a7b4..e04d9b0f138d (1 commits)
2019-01-16 halcanary@google.com SkQP: branching tools updated.

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-17 13:57:53 -05:00
skia-flutter-autoroll
eb33218bf2 Roll src/third_party/skia 33b4b4908b7a..a4e46804946c (1 commits) (flutter/engine#7524)
https://skia.googlesource.com/skia.git/%2Blog/33b4b4908b7a..a4e46804946c

git log 33b4b4908b7acb9913707d1a4a9d8dfe83fb26fb..a4e46804946c5f9554068ba7adfee7376697d77a --date=short --no-merges --format=%ad %ae %s
2019-01-17 brianosman@google.com Fix variable shadowing in Viewer's ImGui code

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-17 10:15:58 -05:00
Vyacheslav Egorov
32ae75d884 Revert "Wrap the user entrypoint function in a zone with native exception callback. (#7512)" (flutter/engine#7522)
This reverts commit 524a12d0468e1a536d74f866796e1cdd7ccaa35e.

Reason for revert: broken in AOT mode.

@pragma('vm:entry-point') placed on a function only instructs
the compiler to retain the function itself, but does not tell
compiler to generate and retain tear-off for this function.

In this PR _runMainZoned was marked as an entry-point but C++
code was trying to tear it off and use a closure, instead of
invoking it directly, which is not supported.
2019-01-17 11:49:20 +01:00
Ben Konyi
aaf3f0921d Roll src/third_party/dart 700254996f..da09945643 (14 commits)
da09945643 Update dartfix pubspec before publishing
b81c1b2095 Parse spread collections in map literals
1b0d93366d Add list literal spread collection fasta test cases
6c2ea4936a Clean up several deprecation hints
07f95e7761 Revert "[vm] Enable timeline on Fuchsia even in product mode."
9cdce03e16 [dart2js] Improve null receiver guard removal near JS code
c3599a9d8c Revert "[vm, isolate] Fix length truncation in message snapshots."
95e10c336f Revert "[vm] Assert callback state for all Dart_Set*ReturnValue."
3f7b371f2c [vm] Enable timeline on Fuchsia even in product mode.
4b22195ea1 [vm, isolate] Fix length truncation in message snapshots.
a353b1172a [vm, compiler] Remove TAG_IC_DATA, which has since been subsumed by RebindRule.
ca12afec50 [vm] Assert callback state for all Dart_Set*ReturnValue.
2028006a25 [Observatory] Updated Dart icon to new colour scheme
84273b9f36 Improvements for flow analysis.
2019-01-17 01:07:30 -08:00
skia-flutter-autoroll
0592f42cd4 Roll src/third_party/skia 25b9f192ed8c..33b4b4908b7a (1 commits) (flutter/engine#7520)
https://skia.googlesource.com/skia.git/%2Blog/25b9f192ed8c..33b4b4908b7a

git log 25b9f192ed8c0bbe3762bd3d7e5654988ad846b8..33b4b4908b7acb9913707d1a4a9d8dfe83fb26fb --date=short --no-merges --format=%ad %ae %s
2019-01-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-17 03:55:18 -05:00
skia-flutter-autoroll
38ba327169 Roll src/third_party/skia 1ce80fb351a2..25b9f192ed8c (5 commits) (flutter/engine#7517)
https://skia.googlesource.com/skia.git/%2Blog/1ce80fb351a2..25b9f192ed8c

git log 1ce80fb351a2aa785751e73078fec601714e4235..25b9f192ed8c0bbe3762bd3d7e5654988ad846b8 --date=short --no-merges --format=%ad %ae %s
2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-16 bsalomon@google.com Exclude PromiseImageTextureReuseDifferentConfig from Metal bots
2019-01-17 rmistry@google.com Revert "Reland "Remove android framework compile bots from CQ""
2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-17 reed@google.com Reland "remove SK_SUPPORT_LEGACY_CANVAS_DRAW_TEXT flag"

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-16 23:58:01 -05:00
skia-flutter-autoroll
b9b24c10cc Roll src/third_party/skia 081e6f375497..1ce80fb351a2 (12 commits) (flutter/engine#7514)
https://skia.googlesource.com/skia.git/%2Blog/081e6f375497..1ce80fb351a2

git log 081e6f375497131f74ef7baaaf24db815906903d..1ce80fb351a2aa785751e73078fec601714e4235 --date=short --no-merges --format=%ad %ae %s
2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-16 reed@google.com hide SkPaint::getFlags/setFlags, use bool acessors instead
2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-16 herb@google.com Remove findOrCreateGlyphCache
2019-01-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 84497a910c68..a9f87d1e43bb (53 commits)
2019-01-16 bsalomon@google.com Make GrTexture caching for SkPromiseImageTexture work when same texture fulfills a different SkImage.
2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-15 csmartdalton@google.com Return GrProcessorSet::Analysis from GrDrawOp::finalize
2019-01-15 michaelludwig@google.com Implement optimization to convert filled rects to scissored clears
2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-16 rmistry@google.com Reland "Remove android framework compile bots from CQ"
2019-01-16 robertphillips@google.com Manually roll Chrome for CommandBuffer

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-16 20:10:05 -05:00
Chinmay Garde
524a12d046 Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512) 2019-01-16 16:08:51 -08:00
Ben Konyi
99c41c1957 Roll src/third_party/dart f701e11756..700254996f (5 commits)
700254996f [ Observatory / Dartium ] Updated observatory documentation and tests to remove references to Dartium.
78abb98ee7 [vm/bytecode] Fix AST removal for package-split kernel files with bytecode
0075b58bb8 CHANGELOG entry for DEPRECATED_MEMBER_USE split
a5f102a7d1 Analyzer: first pass at reporting unchecked nullable value usage.
a10ddca1b1 [ VM / Service ] Allow for `profile_period` flag to be set via the service protocol
2019-01-16 15:58:38 -08:00
liyuqian
1333bde411 Remove unused headers (flutter/engine#7511) 2019-01-17 07:18:43 +08:00
skia-flutter-autoroll
7cb92f377d Roll src/third_party/skia 1374c85fbf53..081e6f375497 (6 commits) (flutter/engine#7510)
https://skia.googlesource.com/skia.git/%2Blog/1374c85fbf53..081e6f375497

git log 1374c85fbf53947e0f826bc721ef561750518092..081e6f375497131f74ef7baaaf24db815906903d --date=short --no-merges --format=%ad %ae %s
2019-01-16 herb@google.com Rename GrGlyphCache -> GrStrikeCache
2019-01-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 ab2bfa814cee..dd34b3b9b707 (2 commits)
2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-16 reed@google.com Revert "remove SK_SUPPORT_LEGACY_CANVAS_DRAW_TEXT flag"
2019-01-16 herb@google.com Rename SkGlyphCache -> SkStrike
2019-01-15 michaelludwig@google.com Implement generic draw-as-clear fallback for color and stencil

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-16 16:28:55 -05:00
Ben Konyi
0376196907 Roll src/third_party/dart 9b5eabdaca..f701e11756 (10 commits)
f701e11756 [ VM / Debugger ] Fix issue where a 'Step' command issued when there's no stack caused a crash.
c5bfccc6fb Make downloading the LSP spec a flag and commit the version parsed locally
dbeec3bbf3 Fix formatting in generated LSP file header
bfe15d87d8 Fix LSP exceptions serializing ResponseErrors with Uris
7984dc4fcc Prepare to publish analyzer version 0.34.2.
4b1b2f9176 Switch LSP formatter to not fetch resolved ASTs that aren't used
5ce5d697da Implement LSP code folding
b47524d5b0 Ensure all unhandled exceptions are recorded on the server
8ba2de2344 Sort context for conflicting inherited members
215f6620e7 [Kernel] Signal errors on static fields in constant contexts
2019-01-16 13:06:27 -08:00
Chris Bracken
86d1e4f835 Deprecate FlutterProjectArgs.main_path, packages_path (flutter/engine#7497)
As of Dart 2, running from Dart source is no longer supported.  Dart
code should now be compiled to kernel form and will be loaded by from
kernel.blob in the assets directory. We retain the struct members for ABI
stability. package_path is also not required since kernel blobs are
self-contained.
2019-01-16 12:47:39 -08:00
KyleWong
8c111d9e25 Edit the bundleid so that it conform to UIT specifications. (flutter/engine#7503) 2019-01-16 11:35:39 -08:00
skia-flutter-autoroll
1145658695 Roll src/third_party/skia 2c379d8e27e6..1374c85fbf53 (4 commits) (flutter/engine#7508)
https://skia.googlesource.com/skia.git/%2Blog/2c379d8e27e6..1374c85fbf53

git log 2c379d8e27e649d1444631a02daea08213688c71..1374c85fbf53947e0f826bc721ef561750518092 --date=short --no-merges --format=%ad %ae %s
2019-01-16 michaelludwig@google.com Prevent op batching in clear benchmark
2019-01-16 halcanary@google.com Documentation: SkFont::textToGlyphs()
2019-01-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 939adc5b9dc7..fed67899a7b4 (1 commits)
2019-01-16 reed@google.com remove SK_SUPPORT_LEGACY_CANVAS_DRAW_TEXT flag

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-16 12:46:57 -05:00
Ben Konyi
0ceff53c02 Roll src/third_party/dart 492df72739..9b5eabdaca (8 commits)
9b5eabdaca Fix crash in color support
a533753bec Remove --fast-startup flag support from testing scripts and status files
5f10aed19c [Kernel] Don't print static fields in instance constants
bdb51e2837 Improve input path handling and remove extra schemas.
0604110806 Reduce expectations on thrown exception
966e007b63 Pass CallStructure on dynamic and static use in ResolutionWorldBuilder
3e7801294e Remove unneeded code in OrderedTypeSet
8a91948c03 [Kernel] Properly signal compilation errors for constants
2019-01-16 06:57:54 -08:00
skia-flutter-autoroll
96980b80cb Roll src/third_party/skia a8694cc150a1..2c379d8e27e6 (1 commits) (flutter/engine#7506)
https://skia.googlesource.com/skia.git/%2Blog/a8694cc150a1..2c379d8e27e6

git log a8694cc150a14149d889537d489558fb7c99ff76..2c379d8e27e649d1444631a02daea08213688c71 --date=short --no-merges --format=%ad %ae %s
2019-01-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c8be560bbabe..ab2bfa814cee (3 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-16 09:02:34 -05:00
skia-flutter-autoroll
01a5c3aa13 Roll src/third_party/skia 47b7cd9a6baf..a8694cc150a1 (1 commits) (flutter/engine#7504)
https://skia.googlesource.com/skia.git/%2Blog/47b7cd9a6baf..a8694cc150a1

git log 47b7cd9a6baf46a3e77a07f91df5f8961b7a82c7..a8694cc150a14149d889537d489558fb7c99ff76 --date=short --no-merges --format=%ad %ae %s
2019-01-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-16 04:45:47 -05:00
Ben Konyi
7e8ae0f284 Roll src/third_party/dart 2195a70249..492df72739 (2 commits)
492df72739 Fix fasta test under windows
4ec9dbf1d0 Add set literal spread collection parsing support
2019-01-16 00:59:12 -08:00
skia-flutter-autoroll
396337ef37 Roll src/third_party/skia 98c65fc9558f..47b7cd9a6baf (4 commits) (flutter/engine#7501)
https://skia.googlesource.com/skia.git/%2Blog/98c65fc9558f..47b7cd9a6baf

git log 98c65fc9558ff78a192709c8467e65a05b09293d..47b7cd9a6baf46a3e77a07f91df5f8961b7a82c7 --date=short --no-merges --format=%ad %ae %s
2019-01-15 reed@google.com remove paint::glyphsToUnichars
2019-01-15 reed@google.com remove SK_SUPPORT_LEGACY_PAINT_FONT_FIELDS for flutter
2019-01-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2019-01-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d3e0e84ce7e1..c8be560bbabe (2 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-16 01:01:20 -05:00
Ben Konyi
bbd3420ffd Roll src/third_party/dart d9944433af..2195a70249 (28 commits)
2195a70249 Make sure that path is correct on all test platforms
56f87f409e [dart:io,fuchsia] Pass Isolate namespace to child process. Fix double free.
b55bc09f1f Add list literal spread collection parsing support
4074ebd0a0 Partial implementation of the unified specification of definite assignment, type promotion, and reachability analysis.
43a96d49af Revert "[vm/compiler] AOT inline heuristics improvements"
a55b6fc183 Remove unused import
2908e61f2a [vm/compiler] AOT inline heuristics improvements
3154bb0d37 Stop using external deprecated members in front_end
ff06d233aa Set CompletionSuggestion.elementUri everywhere in analysis server that element is already being set.
23f427b1a7 Reland [VM/Compiler] Removing definition status from Store{Indexed,InstanceField}.
edca6169c1 Fixed a number of dart:html P1 issues.
ff5e5b6896 Regenerate LSP classes from spec + update README
116f678a69 [build] Enable mitigations for Cortex-A53 Erratum #843419 bug.
21edbbbac6 Add spread collection token to scanner
030fa85cea Fix windows tests
23b5aee978 Update dartfix NNBD to handle more situations
fe6b384ff5 revise dartfix protocol version check
61e81217f0 Update LSP status doc (rename is complete + tested in VS Code)
daead8dff8 Add test for LSP rename that edits multiple files
bdade89081 Improve testing of document versions in LSP renames
ecc1411685 Print constant table when printing libraries.
999c2a7582 Check for conflict with static members
3f44bd1bf9 Check for conflicts in mixins
aa59b20b4b Don't report conflicts twice
3ef8c296bd Improve detection of conflicts with inherited members and setters
50fa633c4a Report InheritedMembersConflict correctly
c25c30dc32 Remove some unused imports
c6ab52c9f9 Using the right conjunction
2019-01-15 19:02:34 -08:00
Michael Goderbauer
4b8cfb84e5 Revert "Revert "Add elevation and thickness to SemanticsNode (#7282)" (#7483)" (flutter/engine#7484)
This reverts commit ba3b5d9c9e5d275b1f1be4a77d961750a2857dc6.
2019-01-15 18:56:21 -08:00
skia-flutter-autoroll
c701495c45 Roll src/third_party/skia cb7149e05864..98c65fc9558f (3 commits) (flutter/engine#7498)
https://skia.googlesource.com/skia.git/%2Blog/cb7149e05864..98c65fc9558f

git log cb7149e0586409f25fa76f3a8f9fcd7ecbb8029d..98c65fc9558ff78a192709c8467e65a05b09293d --date=short --no-merges --format=%ad %ae %s
2019-01-15 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-15 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-07 herb@google.com Switch to bulk api for GPU mask (BMP) drawing.

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-15 21:17:21 -05:00
Stanislav Baranov
6d7e4f6eaf Validate dynamic patches before attempting to install (flutter/engine#7496)
This change adds explicit validation of dynamic patches in all places
where they're used, instead of only validating it in some places which
wasn't as reliable because some of the code paths were missed.

This change also moves utility functions that deal with validating
patches from ResourceExtractor to ResourceUpdater, to make them
available as API for other places in code that need this validation.
2019-01-15 18:09:25 -08:00
Chinmay Garde
a28c25617c Add unittest that runs Dart code synchronously. (flutter/engine#7495) 2019-01-15 16:22:57 -08:00
Chinmay Garde
dad7c0ddf2 Add runttime unittest that loads and runs an isolate from the kernel. (flutter/engine#7493) 2019-01-15 15:28:30 -08:00
Alexander Markov
b96edf5b9d Cleanup Dart sticky errors API and roll tonic to 4634b29a24ccfc0fcfafcc8196ef30131185ad88 (flutter/engine#7492)
This PR prepares Flutter engine for the cleanup of Dart API Dart_GetStickyError/Dart_SetStickyError/Dart_HasStickyError.
2019-01-15 15:26:20 -08:00
skia-flutter-autoroll
d5fd46487d Roll src/third_party/skia 553610d7928d..cb7149e05864 (6 commits) (flutter/engine#7491)
https://skia.googlesource.com/skia.git/%2Blog/553610d7928d..cb7149e05864

git log 553610d7928ddda999a88122423b38350b374e67..cb7149e0586409f25fa76f3a8f9fcd7ecbb8029d --date=short --no-merges --format=%ad %ae %s
2019-01-15 jvanverth@google.com Temporarily disable etc1 GM on Google3
2019-01-15 michaelludwig@google.com Revert "Force flush in clear benchmarks"
2019-01-15 jvanverth@google.com Fix etc1 GM in preReleaseGpuContext mode.
2019-01-15 borenet@google.com [infra] Update upstream CIPD dependencies, roll recipes
2019-01-15 jvanverth@google.com Restore ETC1 compressed texture support.
2019-01-15 mtklein@google.com remove superfluous skia_vulkan_sdk

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-15 17:34:42 -05:00
Ben Konyi
deb1414a2e Roll src/third_party/dart 1c9eb3cef8..d9944433af (36 commits)
d9944433af [Kernel] Clean up error reporting in constant evaluation
59300164af Remove test flakiness records with misspelled field
04131e7fa0 Implement some more LSP rename tests
9d9f467195 Revert "[infra] Blacklist android device id in attempt to make buildbot builder more stable"
c54bc11770 Split DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE off; fixes #30084 and fixes https://github.com/dart-lang/linter/issues/1349
3a4294963c Resolve type names and set nullability for other types.
e4b26e7978 [ VM / dart:io ] Update documentation for  to warn '--pause-isolates-on-exit' is not respected when `exit` is called
df0671d664 [VM] Experimental flags in the dart CLI
3e5e05d14f [infra] Trigger bots after outage.
7e1aa67855 Restore TLABs.
387a644008 Issue 33930. Fix resynthesizing function typed field formal parameter types.
b58aa3bcb2 Add PubWorkspace, integrate it into ContextBuilder, and therefore fix sealed test
a60a06ff7d Update pkg:expect to use @alwaysThrows annotation on fail functions
fafd3d0f18 Make bottom, dynamic, void types nullable. Add withNullability() method. Apply proposed substitution rules for type parameters.
7bac8e631f Issue 35551. Log more information to debug the issue.
957f3e239e Restore including transitive files into exception dumps.
9df4f42a2f [dartdevc] handle a null stack trace passed to async errors
4d77c7b3a6 [vm] Remove redundant type-checks from core libraries.
6c76fe21b5 Issue 25860. Fix for changeFile() directly after removeFile().
02b1658f59 Revert "[VM/Compiler] Revoke definition status of certain instructions."
8cddcd20cd Handle deserialising sub-classes in the super-classes fromJson
19dbf07ea2 [infra] Update checked in SDKs to 2.1.1-dev.1.0
0d6402c1ec Remove faststartup from the test matrix
28fe86d70f Add implementation/tests for LSP rename
f5c69070af Minor LSP refactors/tidy up
3104aea6f7 [release] Add changelog entry for breaking mirrors change
37fba56cdc [release] Update changelog with changes from dev branch
a8777149a7 [VM/Compiler] Revoke definition status of certain instructions.
32eea54390 Extract rename element logic to allow sharing with LSP server
4f160558b3 Extract inline interfaces from `results` definitions in LSP spec
085f31ac5f Library import quick-fix: support calls to top-level function variables
eac2e0f012 [gardening] mark standalone_2/io/http_bind_test as flaky
1c83d8d096 [Kernel] Allow invalid expressions in constant contexts
950b92104d Extract method reportInheritanceConflict
6e13f3334d Abstract noSuchMethod might not be an error.
b2224dbec6 API documentation update to address #35399
2019-01-15 13:51:41 -08:00
Jason Simmons
b628eb5785 Execute Picture.toImage on the current thread in the test environment (flutter/engine#7485) 2019-01-15 12:02:29 -08:00
skia-flutter-autoroll
0e0a919818 Roll src/third_party/skia d1537036a175..553610d7928d (5 commits) (flutter/engine#7482)
https://skia.googlesource.com/skia.git/%2Blog/d1537036a175..553610d7928d

git log d1537036a1751e4af4ceabfc1d886857461eb416..553610d7928ddda999a88122423b38350b374e67 --date=short --no-merges --format=%ad %ae %s
2019-01-14 bsalomon@google.com Change how PromiseLazyInstantiationCallback calls Done proc.
2019-01-15 michaelludwig@google.com Bugfix for Nexus 5 mipmap+scissor generation failure
2019-01-15 halcanary@google.com Documentation: fix drawSimpleText
2019-01-15 michaelludwig@google.com Force flush in clear benchmarks
2019-01-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f3179a6a1763..d3e0e84ce7e1 (1 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-15 13:58:46 -05:00
Michael Goderbauer
ba3b5d9c9e Revert "Add elevation and thickness to SemanticsNode (#7282)" (flutter/engine#7483)
This reverts commit c1ab82c7d556013ca8dc33b2fc8179994f5be29a.
2019-01-15 10:45:49 -08:00
Michael Goderbauer
c1ab82c7d5 Add elevation and thickness to SemanticsNode (flutter/engine#7282) 2019-01-15 09:59:44 -08:00
skia-flutter-autoroll
7e559d73b6 Roll src/third_party/skia 1b45db6642d1..d1537036a175 (1 commits) (flutter/engine#7481)
https://skia.googlesource.com/skia.git/%2Blog/1b45db6642d1..d1537036a175

git log 1b45db6642d1a24751b6a5e2e94c6ea02ff032c9..d1537036a1751e4af4ceabfc1d886857461eb416 --date=short --no-merges --format=%ad %ae %s
2019-01-14 halcanary@google.com Documentation: be explicit about non-shaping

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-15 10:26:31 -05:00
Vyacheslav Egorov
692952dfd0 Pass operator_new_alignment value through gn script into GN args. (flutter/engine#7031)
Background:

Some allocators (tcmalloc) don't provide alignment guarantees that
match clang's default expectations, which causes crashes when using
clang compiled binary with such allocators.

For example clang can produce movaps instructions to initialize newly
allocated object - which would crash if result of ::operator new() is
not 16 bytes aligned.
2019-01-15 16:09:46 +01:00
Brian Osman
16d11f7649 Switch to new SkColorSpace factory (flutter/engine#7480) 2019-01-15 09:50:46 -05:00
skia-flutter-autoroll
162b525189 Roll src/third_party/skia e9fd7ab76ec0..1b45db6642d1 (2 commits) (flutter/engine#7479)
https://skia.googlesource.com/skia.git/%2Blog/e9fd7ab76ec0..1b45db6642d1

git log e9fd7ab76ec0d84a449b82448f9062ad567466db..1b45db6642d1a24751b6a5e2e94c6ea02ff032c9 --date=short --no-merges --format=%ad %ae %s
2019-01-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2019-01-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 17a50e17004b..f3179a6a1763 (7 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-15 04:17:06 -05:00
skia-flutter-autoroll
b9356bb67f Roll src/third_party/skia 31ba6feaf6b3..e9fd7ab76ec0 (3 commits) (flutter/engine#7478)
https://skia.googlesource.com/skia.git/%2Blog/31ba6feaf6b3..e9fd7ab76ec0

git log 31ba6feaf6b34019c0869edf3ae3b02c19731022..e9fd7ab76ec0d84a449b82448f9062ad567466db --date=short --no-merges --format=%ad %ae %s
2019-01-14 reed@google.com don't say experimental if its documented in bmh
2019-01-15 reed@google.com Reland "remove SK_SUPPORT_LEGACY_PAINT_FONT_FIELDS"
2019-01-14 csmartdalton@google.com Remove "canCombineOverlappedStencilAndCover"

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-15 00:44:12 -05:00
skia-flutter-autoroll
f0c1cd8932 Roll src/third_party/skia e99e8dae066a..31ba6feaf6b3 (3 commits) (flutter/engine#7477)
https://skia.googlesource.com/skia.git/%2Blog/e99e8dae066a..31ba6feaf6b3

git log e99e8dae066a1db6c52669ea26a3f6076953fba4..31ba6feaf6b34019c0869edf3ae3b02c19731022 --date=short --no-merges --format=%ad %ae %s
2019-01-14 reed@google.com unflatten directly to font for legacy skps
2019-01-14 herb@google.com Add buffers for Mask drawing in preparation for bulk API
2019-01-07 halcanary@google.com Documentation: SkCanvas

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (halcanary@google.com), and stop
the roller if necessary.
2019-01-14 21:11:48 -05:00
Jason Simmons
700bd140a2 Log errors returned from method channel invocations in the text input plugin (flutter/engine#7476)
See https://github.com/flutter/flutter/issues/25715
2019-01-14 17:26:05 -08:00
Dan Field
ea0b78bc5d Allow FlutterViewController to be released when not initialized with an engine (flutter/engine#6879)
* Break cycle between FlutterViewController and FlutterEngine
2019-01-14 16:58:09 -08:00
Dan Field
60a0e7aeb4 iOS A11y memory leak (flutter/engine#7244)
* fix memory leak in a11y bridge
2019-01-14 16:47:19 -08:00
Greg Spencer
da656186ed Add hover event support to the engine (flutter/engine#6961)
This adds support for passing ACTION_HOVER_MOVE events to the framework, in preparation for supporting mouse hover events on Android and ChromeOS.
2019-01-14 16:15:20 -08:00
liyuqian
a4bf143f24 Avg ms/frame instead of FPS in performance overlay (flutter/engine#7443)
Computing FPS from max ms/frame is misleading and we're no longer
just using 60 FPS displays.
2019-01-15 07:16:24 +08:00
Gary Qian
b3fd686c29 Add Ahem to LibTxt testing fonts. (flutter/engine#7435) 2019-01-14 18:02:29 -05:00