13307 Commits

Author SHA1 Message Date
xster
ec00e974d0
Add long-press-move support for text fields 2 (#28242) 2019-02-25 14:34:54 -08:00
jslavitz
47724f97fa
Breaks the moveBy call from drag and dragFrom into two separate calls and changes the default behavior of DragStartBehavior to DragStartBehavior.start (#26438)
* Breaking change which sets the default DragStartBehavior to DragStartBehavior.start and changes WidgetTester.drag and WidgetTester.dragFrom by breaking the moveBy function call into multiple pieces.
2019-02-25 14:15:31 -08:00
stuartmorgan
62e55a45d4
Convert PointerEvent's toString to Diagnosticable (#27904)
Rather than building a description string by hand, use Diagnosticable
properties. Simplifies output, since many fields have uninteresting
default values in many cases, and makes it easier to add more loggable
properties in subclasses.

Issue #28014
2019-02-25 11:42:50 -08:00
Jason Simmons
9406ebcbaf
Only call Activity.reportFullyDrawn on Lollipop or above (#28175)
This API requires the UPDATE_DEVICE_STATS permission on KitKat
2019-02-25 11:39:17 -08:00
Hans Muller
751f119c93
Ensure that the DropdownButton menu respects its parents bounds (#28371) 2019-02-25 10:58:17 -08:00
rami-a
fc6079a24f
[Material] Add the ability to theme trailing app bar actions independently from leading (#28214)
* Allow app bar actions to be themed independently if needed

* Update SliverAppBar docs that were out of date

* Clarify fallback behavior in a comment

* Analyzer

* Address PR feedback

* Address PR feedback

* Put back checks on actions icon theme

* Address PR feedback

* Retrigger CI
2019-02-25 13:47:05 -05:00
Brandon Rodriguez
c26a69e9cf [Typo] Update 'use' to 'user' (#28245) 2019-02-25 10:32:23 -08:00
Reece Dunham
910638b0a4 Removed trailing whitespace from the end of the CI config (#28370) 2019-02-25 10:29:24 -08:00
Michael Goderbauer
b7f29f2b32
Add more docs to BackdropFilter (#28017) 2019-02-25 10:27:20 -08:00
liyuqian
2e3d9ea253
Mark non-flaky test as such (#28373) 2019-02-25 10:19:49 -08:00
engine-flutter-autoroll
dc6295ec50
f7306394e fix sendLocales on old android versions (flutter/engine#7937) (#28450)
502c9c4002...f7306394e3

git log 502c9c4002a6b456f829f79bfbd2ff61d075d1d7..f7306394e303a210a9971acb60f9ba11d7c64ec8 --no-merges --oneline
f7306394e fix sendLocales on old android versions (flutter/engine#7937)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.
2019-02-25 12:57:32 -05:00
engine-flutter-autoroll
1a182bf7bf
Roll engine 0546e1e5e901..502c9c4002a6 (2 commits) (#28446)
0546e1e5e9...502c9c4002

git log 0546e1e5e9015e7a597c9e59cf89ee614a260251..502c9c4002a6b456f829f79bfbd2ff61d075d1d7 --no-merges --oneline
502c9c400 Android Embedding PR 6: Introduce FlutterView structure with FlutterSurfaceView and FlutterTextureView. (flutter/engine#7896)
687229e70 Roll src/third_party/skia 52d8a5976a23..e1636a4b56aa (1 commits) (flutter/engine#7943)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.
2019-02-25 02:40:28 -05:00
Will Larche
3423c831b9
[Gallery] Fix fortnightly analysis for consts. (#28431) 2019-02-24 21:48:50 +01:00
engine-flutter-autoroll
746d5f7676
0546e1e5e Roll src/third_party/skia 33c1b315265c..52d8a5976a23 (1 commits) (flutter/engine#7941) (#28422)
90fcaff900...0546e1e5e9

git log 90fcaff9008e04b71c00cd6ce27ae335c299c8a6..0546e1e5e9015e7a597c9e59cf89ee614a260251 --no-merges --oneline
0546e1e5e Roll src/third_party/skia 33c1b315265c..52d8a5976a23 (1 commits) (flutter/engine#7941)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.
2019-02-24 14:14:31 -05:00
Will Larche
57a8b03c5e
[Gallery] Fortnightly demo moved from flutter/samples. (#28125)
* [Gallery] Fortnightly demo moved from flutter/samples.

* [Gallery] Fortnightly analysis corrections.

* [Gallery] Minor rename.

* [Gallery] Making floats ints.

* [Gallery] Fortnightly minor visual polish.

* [Gallery] Formatting.

* [Gallery] Upping package version for gallery to support fortnightly demo.

* [Gallery] Fortnightly copy correction.

* [Gallery] Fortnightly study polish.

* [Gallery] Fortnightly polish.

* [Gallery] Fortnightly copy correction.

* [Gallery] Fortnightly copy now held in '''.

* [Gallery] Fortnightly comment.

* [Gallery] Updates necessary when flutter_gallery_assets updates.

* [Gallery] Updating macrobenchmarks because we updated flutter_gallery_assets.

* [Gallery] Moving spaces to beginning of copy lines.

* [Gallery] Copy correction.

* [Gallery] Adding tooltip to satisfy smoke test.

* [Gallery] Minor pr feedback.

* [Gallery] Forced upgrade.
2019-02-24 11:53:43 +01:00
engine-flutter-autoroll
89f206a67b
90fcaff90 Roll src/third_party/skia 2ed90e152d47..33c1b315265c (1 commits) (flutter/engine#7940) (#28413)
b1779e7d95...90fcaff900

git log b1779e7d95ea812ced2f4993932bdb2325f5a8ba..90fcaff9008e04b71c00cd6ce27ae335c299c8a6 --no-merges --oneline
90fcaff90 Roll src/third_party/skia 2ed90e152d47..33c1b315265c (1 commits) (flutter/engine#7940)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.
2019-02-24 04:30:28 -05:00
engine-flutter-autoroll
db0c655110
Roll engine 0d777b947e4c..b1779e7d95ea (2 commits) (#28410)
0d777b947e...b1779e7d95

git log 0d777b947e4cc52a0bc17566f3e450f869ca00c9..b1779e7d95ea812ced2f4993932bdb2325f5a8ba --no-merges --oneline
b1779e7d9 Roll src/third_party/skia 867da4b96e8e..2ed90e152d47 (1 commits) (flutter/engine#7939)
018a4f783 Roll src/third_party/skia 12f1fecea947..867da4b96e8e (1 commits) (flutter/engine#7936)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.
2019-02-23 20:59:28 -05:00
Dan Field
0e984fb237
update packages (#28400) 2019-02-23 10:08:53 -08:00
engine-flutter-autoroll
456ceb1ac1
0d777b947 Roll src/third_party/skia 72f6f044cc73..12f1fecea947 (1 commits) (flutter/engine#7935) (#28392)
3efc9f5099...0d777b947e

git log 3efc9f5099e537b3885aacfe3506903c23c4e1ca..0d777b947e4cc52a0bc17566f3e450f869ca00c9 --no-merges --oneline
0d777b947 Roll src/third_party/skia 72f6f044cc73..12f1fecea947 (1 commits) (flutter/engine#7935)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.
2019-02-23 12:58:28 -05:00
Dan Field
15f2119f2c
Reland "Allow for gradle downloading missing SDK assets" (#28097) (#28355)
* Allow for gradle downloading missing SDK assets if SDK licenses are present.

*  Improvements for windows testing
2019-02-23 09:56:57 -08:00
Dan Field
b484a9129c
add2app test (#27712)
* add2app test
2019-02-23 09:56:27 -08:00
Dan Field
ad68ba303b
fix red build for analysis (#28398) 2019-02-23 09:39:36 -08:00
Gary Qian
7b5a769b31
Force line height in TextFields with strut (#27612) 2019-02-23 03:35:37 -08:00
engine-flutter-autoroll
84d4d41352
3efc9f509 Roll src/third_party/skia 2a5511307d34..72f6f044cc73 (2 commits) (flutter/engine#7934) (#28387)
1741497a57...3efc9f5099

git log 1741497a574fb5b23a32d11f7f499a3065009585..3efc9f5099e537b3885aacfe3506903c23c4e1ca --no-merges --oneline
3efc9f509 Roll src/third_party/skia 2a5511307d34..72f6f044cc73 (2 commits) (flutter/engine#7934)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.
2019-02-23 06:23:28 -05:00
Bryan Henry
e3b2007c08 Clean up flutter_gallery.cmx's sandbox (#28193)
Delete unused 'persistent-storage' feature (which is being removed from
Fuchsia) and inclusion of '/system/data' in namepsace
2019-02-22 23:21:52 -08:00
engine-flutter-autoroll
e0c373b3eb
Roll engine 5809adea4156..1741497a574f (5 commits) (#28378)
5809adea41...1741497a57

git log 5809adea415605b821704967cd9e0b0fc05ce34a..1741497a574fb5b23a32d11f7f499a3065009585 --no-merges --oneline
1741497a5 Roll src/third_party/skia a753d1a3475d..2a5511307d34 (3 commits) (flutter/engine#7933)
0a50e0846 Roll src/third_party/skia ee1c8a733e5b..a753d1a3475d (16 commits) (flutter/engine#7930)
204e7da36 New setting to decide whether we want the engine to load ICU mapping. (flutter/engine#7928)
36d495d57 Dynamic patching support for native code libraries. (flutter/engine#7927)
21c59197e [re-land] Use all font managers to discover fonts for strut. (flutter/engine#7803)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.
2019-02-23 02:03:28 -05:00
engine-flutter-autoroll
7e36c8716d
Roll engine f80928a9e403..5809adea4156 (3 commits) (#28367)
f80928a9e4...5809adea41

git log f80928a9e403c6b2fc1b8de6a00bf6189b715c40..5809adea415605b821704967cd9e0b0fc05ce34a --no-merges --oneline
5809adea4 Make the layout of dynamic patch bundle similar to APK. (flutter/engine#7925)
e2a449a51 Move canvas clear after preroll (flutter/engine#7923)
8529dbc86 Remove unused FML file export.h (flutter/engine#7926)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.
2019-02-22 22:49:28 -05:00
Jonah Williams
0d6bb6aee8
only perform multi-root mapping if there are multiple roots (#28352) 2019-02-22 19:25:24 -08:00
Stanislav Baranov
7baffa6e72
Dynamic patching support for native code libraries. (#28349) 2019-02-22 17:51:05 -08:00
liyuqian
adc8e159a5
Revert "Shader warm up (#27660)" (#28376)
This reverts commit a44f174efc218ac1b4b94b9d77dafdb5dfea1432.

Reason: start_up tests become flaky.

See https://github.com/flutter/flutter/issues/28374

TBR: xster

Merge on red to fix the tree
2019-02-22 17:32:37 -08:00
liyuqian
a44f174efc
Shader warm up (#27660)
This patch adds a default shader warm up process which moves shader compilation from the animation time to the startup time. This also provides an extension for `runApp` so developers can customize the warm up process.

This should reduce our worst_frame_rasterizer_time_millis from ~100ms to ~20-30ms for both flutter_gallery and complex_layout benchmarks. Besides, this should also have a significant improvement on 90th and 99th percentile time (50%-100% speedup in some cases, but I haven't tested them thoroughly; I'll let our device lab collect the data afterwards).

The tradeoff the is the startup time (time to first frame). Our `flutter run --profile --trace-startup` seems to be a little noisy and I see about 100ms-200ms increase in that measurement for complex_layout and flutter_gallery. Note that this only happens on the first run after install or data wipe. Later the Skia persistent cache will remove the overhead.

This also adds a cubic_bezier benchmark to test the custom shader warm up process.

This should fix https://github.com/flutter/flutter/issues/813 (either by `defaultShaderWarmUp`, or a `customShaderWarmUp`).
2019-02-22 15:37:02 -08:00
engine-flutter-autoroll
50b4849b7c
Roll engine 33bb91cc1591..f80928a9e403 (4 commits) (#28353)
33bb91cc15...f80928a9e4

git log 33bb91cc15916610261097eb971ec8a11b804d06..f80928a9e403c6b2fc1b8de6a00bf6189b715c40 --no-merges --oneline
f80928a9e Roll src/third_party/skia fdd15284affe..ee1c8a733e5b (15 commits) (flutter/engine#7924)
93f339fb6 fix Memory leak when using PlatformView [IOS] #24714 (flutter/engine#7919)
2d33e775f Roll src/third_party/skia 969659dbb313..fdd15284affe (2 commits) (flutter/engine#7922)
6d4edf235 Roll src/third_party/skia 9431161ca973..969659dbb313 (3 commits) (flutter/engine#7921)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.
2019-02-22 18:28:28 -05:00
Zachary Anderson
824fe4dfcd
[flutter_tool,fuchsia] Add missing dep to flutter_tool (#28346)
Needed for Fuchsia roll.
2019-02-22 14:31:59 -08:00
rami-a
b28bdabc63
Minor UI tweaks to Cards demo based on internal feedback (#28215)
* Minor UI tweaks to Cards demo based on internal feedback

* Analyzer

* Tweak ink ripple opacity

* Address PR feedback
2019-02-22 15:50:58 -05:00
rami-a
b73dd0e81e
[Material] Add ability to set shadow color and selected shadow color for chips and for chip themes (#28163)
* Add ability to set shadow color for chips and for chip themes

* Add selected shadow color as a property as well

* Update phrasing of documentation

* Address PR feedback
2019-02-22 15:50:39 -05:00
ocavue
0f218e427c Make extended FAB's icon optional (#27711) 2019-02-22 12:47:52 -08:00
Chris Bracken
97b113586d
Roll engine to 33bb91cc15916610261097eb971ec8a11b804d06 (#28315)
flutter/engine@33bb91c Allow embedders to specify a vsync waiter. (flutter/engine#7914)
flutter/engine@4cb9a14 Allow embedders to add events to the timeline. (flutter/engine#7917)
2019-02-22 11:07:17 -08:00
Zachary Anderson
ea4cffde60
[fuchsia] Fix paths to find and ls (#28280) 2019-02-22 08:38:02 -08:00
Chris Bracken
b7711d0f9b
Roll engine to cb0f7ece1f251c78a07550db89d0fcb3edf61e3c (#28309)
flutter/engine@cb0f7ece1 Roll src/third_party/skia 63c4d3596915..e9912ca049a0 (8 commits) (flutter/engine#7918)
2019-02-21 23:18:22 -08:00
Chris Bracken
2348651272
Roll engine to 043d92c48abdebdad926569bc204a59c5cf20a11 (#28308)
flutter/engine@043d92c48 Embedder API for setting the persistent cache path (flutter/engine#7915)
2019-02-21 23:15:24 -08:00
xster
d749e0b573
Add some more CupertinoPicker doc (#28166) 2019-02-21 22:16:29 -08:00
Stanislav Baranov
3837ec9e96
Reland #27754, now that bsdiff has moved to flutter/packages. (#28291) 2019-02-21 21:59:41 -08:00
Ray Rischpater, KF6GPE
d39a72516a
deploy to .dev firebase projects. (#28171)
* deploy to .dev firebase projects.

* Updated secrets for .dev web sites.

* Fixed missing docs.*.io references.
2019-02-21 21:21:43 -08:00
Chris Bracken
007a415c2a
Roll the engine to 5db4b377244bae48bc21e449e616417e68c9a6b9 (#28296)
flutter/engine@f1f19bba8 Revert "Revert "Revert "Reland PerformanceOverlayLayer golden test (flutter/engine#7863)" (flutter/engine#7895)" (flutter/engine#7911)" (flutter/engine#7916)
flutter/engine@5db4b3772 Revert dart rolls (flutter/engine#7913)
flutter/engine@0053c1d50 Roll src/third_party/dart 75ee523f91..4cff5a4fd6 (6 commits)
flutter/engine@8620579cf Roll src/third_party/skia 9a049e6ce39d..63c4d3596915 (8 commits) (flutter/engine#7909)
flutter/engine@aa2b287cb Reland flutter/engine#7777 with proper LICENSE (flutter/engine#7888)
flutter/engine@a5773d121 Do not add ghost runs for trailing whitespace if the text is ellipsized (flutter/engine#7906)
flutter/engine@93eeb48ba Revert "Revert "Remove unnecessary entry-point closurization. (flutter/engine#7827)" (flutter/engine#7876)" (flutter/engine#7904)
flutter/engine@bbaeba3f3 Roll src/third_party/skia 05ff93c43ea5..9a049e6ce39d (11 commits) (flutter/engine#7903)
flutter/engine@1cf6b8b64 Roll src/third_party/dart 5ddd157809..75ee523f91 (19 commits)
flutter/engine@be32040ef Roll src/third_party/skia 348227b89430..05ff93c43ea5 (2 commits) (flutter/engine#7901)
flutter/engine@293b3de98 Roll src/third_party/skia 20ebd0cb3882..348227b89430 (4 commits) (flutter/engine#7900)
flutter/engine@6e6020d29 Eliminate .member = foo struct initialization (flutter/engine#7899)
flutter/engine@6d8bd99af Revert "Reland PerformanceOverlayLayer golden test (flutter/engine#7863)" (flutter/engine#7895)
flutter/engine@39f7066b6 Test profile and release build and unit tests (flutter/engine#7880)
flutter/engine@abe9826a9 Add accessibility semantics support to embedder (flutter/engine#7891)
flutter/engine@ce7016e1f Roll src/third_party/skia e471c05f92e8..20ebd0cb3882 (4 commits) (flutter/engine#7894)
flutter/engine@684c9394c Respect the custom GL proc table when creating the resource context on the IO thread. (flutter/engine#7893)
flutter/engine@e11d0e96f Android embedding refactor pr5 add flutterengine impl (flutter/engine#7878)
flutter/engine@2f4a38dbd Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7892)
flutter/engine@8427d73c8 Reland PerformanceOverlayLayer golden test (flutter/engine#7863)
flutter/engine@61fc1786f Roll src/third_party/dart c92d5ca288..5ddd157809 (153 commits)
flutter/engine@b0671145a Roll src/third_party/skia 7738736f9622..e471c05f92e8 (23 commits) (flutter/engine#7889)
flutter/engine@6d7eb5218 Revert "Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7874)" (flutter/engine#7886)
flutter/engine@dad6ec01c Correct onAccessibilityFeaturesChanged docs (flutter/engine#7883)
v1.2.2
2019-02-21 20:22:47 -08:00
Dan Field
74a9086037
Revert "Allow for gradle downloading missing SDK assets (#28097)" (#28295)
This reverts commit 6f5e88a59f5ac01fd55b5c3a11b7c2ddc6c7402c.
2019-02-21 16:53:45 -08:00
xster
98455df459
Add slight clarification to debugDeterministicCursor (#27898) 2019-02-21 16:18:42 -08:00
Hans Muller
617ca62709
[Material] Expand BottomNavigationBar API (reprise) (#28159) 2019-02-21 16:05:36 -08:00
Michael Goderbauer
b96ae03b42
Add backgroundColor argument to TextStyle for convenience (#28172) 2019-02-21 15:58:30 -08:00
Dan Field
6f5e88a59f
Allow for gradle downloading missing SDK assets (#28097)
* Allow for gradle downloading missing SDK assets if SDK licenses are present.

* Fix license path for missing sdkmanager

* Cirrus re-run...

* Fix condition check

* rename props, add docs, rename method

* fix tests after param changes

* Fix weird path for flutter run and add tests

* remove print, fix tests
2019-02-21 15:57:20 -08:00
Greg Spencer
b316940051
Fix the length of the valueHelp on the --sample option for the create command, and turn on wrapping. (#28264)
The wrapping for some commands was never actually turned on, so this turns it on.

Also, it shortens the `valueHelp` for the `--sample` option to be just "id" instead of "the sample ID of the desired sample from the API documentation website (http://docs.flutter.io)", which was causing the line to get far too long.

Fixes #23074
2019-02-21 15:56:59 -08:00