42196 Commits

Author SHA1 Message Date
Loïc Sharma
ebfaa45c7d
[Windows] Improve symlink ERROR_ACCESS_DENIED error message (#154030)
Currently, if creating a symlink on Windows fails due to `ERROR_ACCESS_DENIED`, you'll get an error message like:

```
Error: ERROR_ACCESS_DENIED file system exception thrown while trying to create a symlink from source to dest
```

The `source` and `dest` paths are incorrect.

This will help us debug: https://github.com/flutter/flutter/issues/153758
2024-08-26 17:52:11 +00:00
Lau Ching Jun
9032717eac
Add ability to provide selectableDayPredicate for showDateRangePicker (#154090)
This PR is a reland of #150355

The PR was reverted due to a failing test, but it was later determined that the test was flaky.
2024-08-26 17:52:08 +00:00
Gray Mackall
7362d07cb0
Make the pub roller bot re-generate gradle lockfiles (#149355)
Fixes https://github.com/flutter/flutter/issues/142475
2024-08-26 16:44:19 +00:00
auto-submit[bot]
6608936e6d
Reverts "Roll pub packages (#154044)" (#154113)
Reverts: flutter/flutter#154044
Initiated by: zanderso
Reason for reverting: Version does not exist.
Original PR Author: flutter-pub-roller-bot

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-26 15:49:25 +00:00
Husnul Aman
0fe1239314
Added missing test for SelectionArea example (#151585)
Added missing test for SelectionArea example. Issue #130459
2024-08-26 11:29:33 +00:00
auto-submit[bot]
a7eaca934d
Reverts "Add ability to provide selectableDayPredicate for showDateRangePicker (#150355)" (#154089)
Reverts: flutter/flutter#150355
Initiated by: chingjun
Reason for reverting: this is breaking an internal test.
Original PR Author: Chuckame

Reviewed By: {victorsanni, MitchellGoodwin}

This change reverts the following previous change:
- Closes #63973
- Now able to provide a `selectableDayPredicate`
- No breaking change (same behavior as before if not set)
- Reuse the same feature as the DatePicker: non-selectable days are greyed and not clickable
- Reuse the same error message as if the user set a wrong date range
- Made public `CalendarDateRangePicker`, actually the same for `CalendarDatePicker`, to allow using the range picker outside the `showDateRangePicker` bottom sheet modal

## Examples
- Disable days after the next non selectable day when start day has been selected

https://github.com/flutter/flutter/assets/16419143/2a2be325-1e2f-470c-8b17-b4ed5b2ad43e

- Select a range including non-selectable days

<img width="363" alt="image" src="https://github.com/flutter/flutter/assets/16419143/21e32def-46f0-41d6-974f-281a0405e28e">
2024-08-26 04:33:30 +00:00
flutter-pub-roller-bot
9308a799c6
Roll pub packages (#154044)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-25 20:58:24 +00:00
engine-flutter-autoroll
1fc43d62bd
Roll Flutter Engine from 571403d88131 to 365b0c70faf5 (1 revision) (#154043)
571403d881...365b0c70fa

2024-08-24 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from 2TaLkdJNlAIbDYccn... to oGxqx29_HA1eEBnt9... (flutter/engine#54751)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-25 20:14:09 +00:00
Chuckame
950af9515a
Add ability to provide selectableDayPredicate for showDateRangePicker (#150355)
- Closes #63973
- Now able to provide a `selectableDayPredicate`
- No breaking change (same behavior as before if not set)
- Reuse the same feature as the DatePicker: non-selectable days are greyed and not clickable
- Reuse the same error message as if the user set a wrong date range
- Made public `CalendarDateRangePicker`, actually the same for `CalendarDatePicker`, to allow using the range picker outside the `showDateRangePicker` bottom sheet modal

## Examples
- Disable days after the next non selectable day when start day has been selected

https://github.com/flutter/flutter/assets/16419143/2a2be325-1e2f-470c-8b17-b4ed5b2ad43e

- Select a range including non-selectable days

<img width="363" alt="image" src="https://github.com/flutter/flutter/assets/16419143/21e32def-46f0-41d6-974f-281a0405e28e">
2024-08-25 20:14:06 +00:00
engine-flutter-autoroll
5ae678bdfb
Roll Flutter Engine from a821b8790c9f to 571403d88131 (1 revision) (#154042)
a821b8790c...571403d881

2024-08-24 chris@bracken.jp iOS: don't bundle simulator dSYMs in xcframework (flutter/engine#54746)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-24 02:02:20 +00:00
Chris Bracken
915b499228
iOS: Remove simulator dSYMs from codesign test (#154041)
In https://github.com/flutter/engine/pull/54746, we removed iOS simulator dSYMs from both the regular framework build and the extension-safe build.

Since these artifacts are no longer bundled in Flutter.xcframework, they are no longer codesigned and thus need to be removed from this list.

Issue: https://github.com/flutter/flutter/issues/154019
2024-08-24 02:00:29 +00:00
Chris Bracken
11ab37ee81
macOS: Copy macOS framwork dSYM into build outputs (#153975)
As of Xcode 16, App Store validation now requires that apps uploaded to the App store bundle dSYM debug information bundles for each Framework they embed.

dSYM bundles are packaged in the FlutterMacOS.xcframework shipped in the `darwin-x64-release` tools archive as of engine patches:
* https://github.com/flutter/engine/pull/54696

This copies the FlutterMacOS.framework.dSYM bundle from the tools cache to the build outputs produced by `flutter build macOS`.

Fixes: https://github.com/flutter/flutter/issues/153879
2024-08-24 00:14:15 +00:00
engine-flutter-autoroll
a09941dcf1
Roll Flutter Engine from ba1168fe0275 to a821b8790c9f (1 revision) (#154032)
ba1168fe02...a821b8790c

2024-08-23 skia-flutter-autoroll@skia.org Roll Dart SDK from ca8ee3f5f266 to b81b344a194f (3 revisions) (flutter/engine#54738)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-23 21:54:20 +00:00
flutter-pub-roller-bot
53805d5ba9
Roll pub packages (#154026)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-23 21:46:04 +00:00
Chris Bracken
74e250428c
iOS: Update codesigned binaries list to match cache (#154027)
This was partially fixed in flutter/flutter#153787, which added just the extension-safe simulator dSYM, but we also bundle:

* arm64 release dSYM
* arm64 release extension-safe dSYM
* arm64_x86_64 simulator dSYM

In a followup engine patch, we'll stop bundling both the regular and extension-safe simulator dSYMs, but this gets the test passing at tip-of-tree.

Issue: https://github.com/flutter/flutter/issues/116493
2024-08-23 21:36:13 +00:00
Andrew Kolos
31da240b97
add -v to flutter install invocation when setting up android run tests (#153894)
Experiment to help troubleshoot https://github.com/flutter/flutter/issues/153367
2024-08-23 20:51:07 +00:00
yim
37ba70cef5
Fix Cupertino route animation. (#153765)
Fixes: #48225 
Fixes: #73026 
Fixes: #62848

After some research, I found that the issue might simply be that our animation curve is too steep, causing the animation to continue while the page visually appears very close to popping. This PR modifies the animation curve and duration after the drag gesture is released (iOS native animation duration is not related to swipe distance). I recorded a video comparing the curves. From top to bottom, the video shows the iOS native curve, the curve modified by this PR, and the original curve. The animation duration is slowed down by 10 times.

1/2

https://github.com/user-attachments/assets/77d0a782-b56d-431b-b925-8ff4e825c14a

1/4

https://github.com/user-attachments/assets/a4c50219-e86d-4cce-8a92-b266eb6260a8

forward  1/2

https://github.com/user-attachments/assets/067fffc2-203b-4686-ba4c-3b61a2c98cf8

forward  1/4

https://github.com/user-attachments/assets/c1ae938f-76ab-42f8-a832-d2d0e6c0758d
2024-08-23 20:45:22 +00:00
engine-flutter-autoroll
81e418dd20
Roll Flutter Engine from 41f539f0866b to ba1168fe0275 (3 revisions) (#154020)
41f539f086...ba1168fe02

2024-08-23 jonahwilliams@google.com [Engine] Add no op surface (flutter/engine#54694)
2024-08-23 jonahwilliams@google.com [engine] make Platform thread the UI thread for iOS Impeller. (flutter/engine#54655)
2024-08-23 mdebbar@google.com [web] Multi-view support for Skwasm (flutter/engine#48893)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-23 20:41:25 +00:00
Pavlo Kochylo
a4b0d973fb
Added new constructor RefreshIndicator.noSpinner() (#152075)
This PR adds a new constructor to the RefreshIndicator's class, which is `noSpinner`.
The purpose of this new constructor is to create a RefreshIndicator that doesn't show a spinner when the user arms it by pulling.

The work is based on a partial that is here: https://github.com/flutter/flutter/pull/133507

I addressed the following issues reported in the PR above:
- in the example for `noSpinner`, arming the RefreshIndicator now shows a CircularProgressIndicator, instead of just printing text to the console;
- added a test for the new example;
- added a doc comment on the new constructor;

Fixes https://github.com/flutter/flutter/issues/132775
2024-08-23 20:37:24 +00:00
Matan Lurey
5e194383af
Add a test of an Android platform view that draws a gradient (#153878)
Closes https://github.com/flutter/flutter/issues/152376.

The gradient, for posterity, looks like this:

<img src="https://github.com/user-attachments/assets/bed9599a-4e16-499c-af79-b51980095e89" width="150">

Let's see if CI agrees!

/cc @johnmccutchan
2024-08-23 18:25:40 +00:00
Andrew Kolos
327193af9a
override Analytics in TestBed defaults (#153990)
Fixes https://github.com/flutter/flutter/issues/150663
2024-08-23 18:13:10 +00:00
Jonah Williams
df3d35eedb
[devicelan] opt android devices into fixed performance mode. (#154016)
See also: https://developer.android.com/games/optimize/adpf/fixed-performance-mode

Should keep benchmarks more stable so A/B comparisons are appropriate without accounting for CPU/GPU throttling.
2024-08-23 18:11:25 +00:00
Chris Bracken
7f77e19f6b
macOS: Add dSYM to binariesWithoutEntitlements (#153977)
In https://github.com/flutter/engine/pull/54696, we started bundling `FlutterMacOS.framework.dSYM` within `FlutterMacOS.xcframework` in the framework artifacts cache. This updates the list of expected codesigned binaries to include this file.

Issue: https://github.com/flutter/flutter/issues/153879
2024-08-23 17:57:11 +00:00
chunhtai
dde2328185
Android analyze command should run pub (#153953)
The android command will build the android project partially and thus will need to run pub
2024-08-23 17:57:07 +00:00
hangyu
454908185f
Add app bar and tab bar to a11y assessment app (#152904)
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-08-23 17:57:04 +00:00
Taha Tesser
d7b092e42d
Fix TimePicker hour and minute inputs are resized on error (#154008)
Fixes [Defining inputDecorationTheme in TimePickerThemeData Causes Misalignment of Hour and Minute Input Boxes](https://github.com/flutter/flutter/issues/153549)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        timePickerTheme: const TimePickerThemeData(
          inputDecorationTheme: InputDecorationTheme(),
        ),
      ),
      home: Scaffold(
        body: Center(
          child: Builder(builder: (BuildContext context) {
            return ElevatedButton(
              onPressed: () async {
                await showTimePicker(
                  context: context,
                  initialEntryMode: TimePickerEntryMode.input,
                  initialTime: TimeOfDay.now(),
                );
              },
              child: const Text('Show Time Picker'),
            );
          }),
        ),
      ),
    );
  }
}

```

</details>

### Before

<img width="578" alt="Screenshot 2024-08-23 at 16 49 25" src="https://github.com/user-attachments/assets/f5da2495-551e-4110-85ea-120323cd38d2">

### After

<img width="578" alt="Screenshot 2024-08-23 at 16 51 03" src="https://github.com/user-attachments/assets/80224a10-e9d2-46d1-b2eb-f16358699744">
2024-08-23 17:15:36 +00:00
Gray Mackall
b2de4dfc2b
Re-land "Ensure flutter build apk --release optimizes+shrinks platform code" (#153868)
Re-lands https://github.com/flutter/flutter/pull/136880, fixes https://github.com/flutter/flutter/issues/136879.

Additions to/things that are different from the original PR:
- Adds an entry to `gradle_errors.dart` that tells people when they run into the R8 bug because of using AGP 7.3.0 (https://issuetracker.google.com/issues/242308990).
- Previous PR moved templates off of AGP 7.3.0.
- Packages repo has been moved off AGP 7.3.0 (https://github.com/flutter/packages/pull/7432).

Also, unrelatedly:
- Deletes an entry in `gradle_errors.dart` that informed people to build with `--no-shrink`. This flag [doesn't do anything](https://github.com/flutter/website/pull/11022#issuecomment-2297294421), so it can't be the solution to any error.
- Uniquely lowers the priority of the `incompatibleKotlinVersionHandler`. This is necessary because the ordering of the errors doesn't fully determine the priority of which handler we decide to use, but also the order of the log lines. The kotlin error lines often print before the other error lines, so putting it last in the list of handlers isn't sufficient to lower it to be the lowest priority handler.
2024-08-23 16:44:08 +00:00
engine-flutter-autoroll
1cdff3616e
Roll Packages from c5d03ee2f2db to d862279f291f (9 revisions) (#154006)
c5d03ee2f2...d862279f29

2024-08-22 jacksongardner@google.com Serve benchmarks with COOP/COEP headers in wasm mode. (flutter/packages#7423)
2024-08-21 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformPolygon` and `PlatformPolyline` to Pigeon (flutter/packages#7406)
2024-08-21 tarrinneal@gmail.com [pigeon] simplifies int handling across the codec, verifies ints in collections (flutter/packages#7392)
2024-08-21 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 80c2e84975bb to 5874a72aa4c7 (9 revisions) (flutter/packages#7472)
2024-08-21 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/interactive_media_ads/android (flutter/packages#7384)
2024-08-21 engine-flutter-autoroll@skia.org Roll Flutter from e7da16df76cd to b8f89f70bf4e (28 revisions) (flutter/packages#7471)
2024-08-21 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds a contribution doc (flutter/packages#7460)
2024-08-21 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#7373)
2024-08-21 paulberry@google.com [script] Remove unnecessary breaks in default clauses of switch statements (flutter/packages#7469)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-23 15:50:34 +00:00
engine-flutter-autoroll
43495d6f2d
Roll Flutter Engine from 3d6a3de6eed4 to 41f539f0866b (1 revision) (#154004)
3d6a3de6ee...41f539f086

2024-08-23 skia-flutter-autoroll@skia.org Roll Skia from 7d96b8516e8d to 0086a17e0d4c (2 revisions) (flutter/engine#54732)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-23 14:18:30 +00:00
engine-flutter-autoroll
cc74b1812c
Roll Flutter Engine from def82269fa8c to 3d6a3de6eed4 (1 revision) (#154003)
def82269fa...3d6a3de6ee

2024-08-23 skia-flutter-autoroll@skia.org Roll Dart SDK from f9e6abb21ac7 to ca8ee3f5f266 (1 revision) (flutter/engine#54734)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-23 12:32:26 +00:00
engine-flutter-autoroll
dd76da8070
Roll Flutter Engine from e4fac7881666 to def82269fa8c (1 revision) (#153998)
e4fac78816...def82269fa

2024-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from s8Qn72-dRInu0Avzn... to 0d2McFgsNwG-5r1Rb... (flutter/engine#54733)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from s8Qn72-dRInu to 0d2McFgsNwG-

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-23 11:20:36 +00:00
engine-flutter-autoroll
88d22c4e58
Roll Flutter Engine from 67a7fe18c014 to e4fac7881666 (22 revisions) (#153994)
67a7fe18c0...e4fac78816

2024-08-23 flar@google.com Revert "Framework wide color" (flutter/engine#54728)
2024-08-23 skia-flutter-autoroll@skia.org Roll Skia from 7ac776072577 to 7d96b8516e8d (3 revisions) (flutter/engine#54731)
2024-08-23 skia-flutter-autoroll@skia.org Roll Skia from 789f5cb0b9c2 to 7ac776072577 (1 revision) (flutter/engine#54729)
2024-08-23 skia-flutter-autoroll@skia.org Roll Skia from b25553b2fb9f to 789f5cb0b9c2 (1 revision) (flutter/engine#54726)
2024-08-23 skia-flutter-autoroll@skia.org Roll Dart SDK from ca009736fb3e to f9e6abb21ac7 (1 revision) (flutter/engine#54725)
2024-08-23 bdero@google.com [Impeller] Reland 3: Implement draw order optimization. (flutter/engine#54673)
2024-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from 2fOjXGNxdSoRSGCL7... to 2TaLkdJNlAIbDYccn... (flutter/engine#54721)
2024-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from sbh76PYVTMxav4ACT... to OKGFjciA5Vd0TQks4... (flutter/engine#54722)
2024-08-22 magder@google.com Test running the macOS engine has no stray logging (flutter/engine#54716)
2024-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 937389f7bc48 to ca009736fb3e (1 revision) (flutter/engine#54719)
2024-08-22 matanlurey@users.noreply.github.com More diagnostic clean ups (flutter/engine#54265)
2024-08-22 30870216+gaaclarke@users.noreply.github.com Framework wide color (flutter/engine#54415)
2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 10e9072dcea0 to b25553b2fb9f (2 revisions) (flutter/engine#54717)
2024-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from ce160bf13347 to 937389f7bc48 (1 revision) (flutter/engine#54715)
2024-08-22 yjbanov@google.com [web:semantics] fix double click due to long-press (flutter/engine#54697)
2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 04ce2e2bfc35 to 10e9072dcea0 (1 revision) (flutter/engine#54713)
2024-08-22 zanderso@users.noreply.github.com Pin mac host and iOS builds to arm64 builders (flutter/engine#54711)
2024-08-22 chris@bracken.jp macOS: Bundle dSYM packages in FlutterMacOS.xcframework (flutter/engine#54696)
2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 7611984dc27b to 04ce2e2bfc35 (2 revisions) (flutter/engine#54712)
2024-08-22 joel.winarske@gmail.com vulkan_glfw validation layer logging (flutter/engine#54607)
2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 4c66b7e42027 to 7611984dc27b (1 revision) (flutter/engine#54710)
2024-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 025bf8d376d3 to ce160bf13347 (1 revision) (flutter/engine#54709)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-23 10:17:27 +00:00
Bruno Leroux
402ed6c503
Fix DropdownMenu focus traversal (#153931)
## Description

This PR fixes `DropdownMenu` focus traversal.

Before this PR, if a `DropdownMenu` contains several items, the 'tab' key had to be pressed many times before the focus move to the inner text field.

This fix is based on https://github.com/flutter/flutter/issues/131120#issuecomment-1654233358.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/131120.

## Tests

Adds 1 test.
2024-08-23 07:57:08 +00:00
miechoo
b6c14d783a
Test of CustomScrollViewExampleApp (#152431)
CustomScrollViewExampleApp 
Part of https://github.com/flutter/flutter/issues/130459

The test is checking: 
- if all crucial Widgets are initially visible
- if IconButton click will expand existing SliverList
- if IconButton click and mouse scroll will reveal additional SliverList
2024-08-23 06:57:28 +00:00
Greg Spencer
aa934ac119
Fix broken macro reference (#153881)
## Description

This fixes a bogus macro reference.  It's in the doc comment for a private function, so it's unlikely to ever see the docs website, but still, it shouldn't reference a non-existent template.

## Tests
 - Doc only change.
2024-08-22 22:54:20 +00:00
Jason Simmons
30fc10d602
Update the web test suite runner to use the correct flutter_driver output path if FLUTTER_TEST_OUTPUTS_DIR is set (#153966)
A pending change to the flutter_drone LUCI recipe is using a logging library that sets the FLUTTER_TEST_OUTPUTS_DIR environment variable (see https://flutter.googlesource.com/recipes/+/b111cd3ef2297e66905cc48c2cfedce0cf1ba46f)

flutter_driver uses FLUTTER_TEST_OUTPUTS_DIR as its output directory if it is set.  run_web_tests invokes flutter_driver and needs to look for outputs in that directory.
2024-08-22 22:32:02 +00:00
Jenn Magder
acaccda08d
Update iOS/macOS triage doc links (#153963)
Combine iOS and macOS triage links since it's completed in the same meeting. 
1. Remove `no:assignee` from both incoming issue links, as these should still be triaged.
2. Combine P0 issue and packages PR links. Other links are harder to combine. For example, macOS PRs looks for `"affects: desktop"` but iOS PRs do not.
2024-08-22 22:31:59 +00:00
Michael Goderbauer
41c2f550ce
Manual pub roll (#153961)
Supersedes https://github.com/flutter/flutter/pull/153869
2024-08-22 22:28:19 +00:00
Loïc Sharma
56fcc724e0
[Windows] Add a flutter-dev script to run the f lutter CLI from source (#153892)
Follow-up to https://github.com/flutter/flutter/pull/153599, adds support for the objectively better OS 👼
2024-08-22 22:02:36 +00:00
Joy Serquiña
5fad2bea2a
fix(material/a11y_assessments): add unique page title (#152148)
Adds usage of SystemChrome.setAPplicationSwitcherDescription to update the page title for the AutoComplete demo page.

[Before screenshot: example AutoComplete](https://screenshot.googleplex.com/8DpESj4QrQA2YrW)
[After screenshot: example AutoComplete](https://screenshot.googleplex.com/6AdfSA8a8VwUaXM)

Fixes b/338056490

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-08-22 21:28:22 +00:00
PurplePolyhedron
8e50a17d94
Stop DropdownMenu internal scrolling from moving parent Scrollable (#153360)
fixes https://github.com/flutter/flutter/issues/151854
fixes #139113

The regression test uses nested `ListView` because I could not reproduce the issue without using nested `Scrollable`.

The issue is masked when there is only one `Scrollable` outside `DropdownMenu`. While `Scrollable.ensureVisible` can find all the `Scrollable`, the actual scrolling is performed by `ScrollPosition.ensureVisible` , which uses the `RenderObject` tree to find nearest Viewport but it could not find one due to `OverlayPortal` putting the target `RenderObject` at different point. So no scrolling will occur.

However when there are nested `Scrollable`, `Scrollable.ensureVisible` can scroll the outside `Scrollable` normally since no `RenderObject` tree gap exist between the two `Scrollable`
2024-08-22 21:14:22 +00:00
August
e0cd56b52b
fix: A referenced default package must be a plugin package (#152134)
Clarify that a referenced default package must also be a plugin package (one, which provides a pluginClass or a dartPluginClass).

Fixes #152037
More precisely https://github.com/flutter/flutter/issues/152037#issuecomment-2239909463.
Introduced in #137040
2024-08-22 21:02:25 +00:00
Seth Ladd
1b234858f2
Update README.md to clarify who flutter-dev is for and what the trade-offs are (#153947)
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-08-22 17:49:50 +00:00
RamonFarizel
ef098c2aa4
Document scale parameter for Image and RawImage (#153728)
This PR documents the scale parameter for Image and RawImage.
It adds the quote from the [Image.memory](https://main-api.flutter.dev/flutter/widgets/Image/Image.memory.html) for other constructors like: `Image.asset`, `Image.new`, `Image.network`, `Image.file` and `RawImage`

> The scale argument specifies the linear scale factor for drawing this image at its intended size and applies to both the width and the height. For example, if this is 2.0, it means that there are four image pixels for every one logical pixel, and the image's actual width and height (as given by the [dart:ui.Image.width](https://main-api.flutter.dev/flutter/dart-ui/Image/width.html) and [dart:ui.Image.height](https://main-api.flutter.dev/flutter/dart-ui/Image/height.html) properties) are double the height and width that should be used when painting the image (e.g. in the arguments given to [Canvas.drawImage](https://main-api.flutter.dev/flutter/dart-ui/Canvas/drawImage.html)).

#148623
2024-08-22 16:42:18 +00:00
Slava Egorov
4a6fbef83f
Use "run --resident" for flutter-dev. (#153905)
This makes subsequent runs much faster by allowing to skip compilation to Kernel at the cost of introducing a bit of spam into the output when it starts resident compiler for the first time. Seems like a fine trade-off for dev-mode command.

```console
$ time flutter-dev -h
...
________________________________________________________
Executed in    5.32 secs      fish           external
   usr time  438.69 millis    0.09 millis  438.60 millis
   sys time  111.91 millis    2.42 millis  109.48 millis

$ time flutter-dev -h
...
________________________________________________________
Executed in  579.14 millis    fish           external
   usr time  433.87 millis    0.08 millis  433.79 millis
   sys time  109.27 millis    2.57 millis  106.70 millis

```
2024-08-22 16:19:03 +00:00
Matan Lurey
a9e94d9045
Do not silently fail pub get even if output-mode is "none" (#153596)
I am making an assumption `OutputMode.none` should _really_ mean
`OutputMode.failuresOnly`, that is, if we ever get a non-zero exit code,
we still want to know why. If I've somehow misunderstood that, LMK and
I'm happy to revert this PR or make adjustments.

This fixes the bug where if you were to do:

```sh
git clone https://github.com/myuser/fork-of-flutter
cd fork-of-flutter
./bin/flutter update-packages
```

You now get:

1. An actual error message, versus no output at all.
2. A warning that a common reason is not tracking a remote, with
instructions to fix it.

Closes https://github.com/flutter/flutter/issues/148569.
2024-08-22 09:12:54 -07:00
engine-flutter-autoroll
544ce7cd34
Roll Flutter Engine from 3125a760ad61 to 67a7fe18c014 (1 revision) (#153932)
3125a760ad...67a7fe18c0

2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 0429e894d3f6 to 4c66b7e42027 (1 revision) (flutter/engine#54708)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-22 15:21:57 +00:00
engine-flutter-autoroll
59e6c8d52f
Roll Flutter Engine from 9891efea6966 to 3125a760ad61 (1 revision) (#153923)
9891efea69...3125a760ad

2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from a9af6f466355 to 0429e894d3f6 (1 revision) (flutter/engine#54707)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-22 13:37:09 +00:00
Sigurd Meldgaard
dfdd5f80f2
Fix flutter test in workspace (#153919)
Follow-up to #153754.
2024-08-22 15:34:47 +02:00
engine-flutter-autoroll
2ed3dab361
Roll Flutter Engine from 8aab0da84aba to 9891efea6966 (1 revision) (#153915)
8aab0da84a...9891efea69

2024-08-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from XGzE3idakwfQZ68pb... to s8Qn72-dRInu0Avzn... (flutter/engine#54706)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from XGzE3idakwfQ to s8Qn72-dRInu

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-22 10:05:27 +00:00