skia-flutter-autoroll
eb75c4337d
Roll Skia from 0756b4606e6f to 21563606e32d (2 revisions) ( flutter/engine#52325 )
...
https://skia.googlesource.com/skia.git/+log/0756b4606e6f..21563606e32d
2024-04-23 egdaniel@google.com Remove crashing Linux Graphite Dawn Vulkan perf task.
2024-04-23 nicolettep@google.com Transition magic numbers in VulkanSamplerYcbcrConversion to static values and add convenience method
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 16:32:13 +00:00
skia-flutter-autoroll
47035e2abd
Roll Skia from a373bf46bffb to 0756b4606e6f (3 revisions) ( flutter/engine#52323 )
...
https://skia.googlesource.com/skia.git/+log/a373bf46bffb..0756b4606e6f
2024-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from afa5f1b307bd to 99fa81c4c166
2024-04-23 michaelludwig@google.com [graphite] Handle failed buffer mappings in DrawWriter
2024-04-23 brianosman@google.com Revert "Reland "Restore affine bitmap procs""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 15:37:59 +00:00
Jonah Williams
efbf913cc0
[Impeller] add test case for path that explicitly closes at origin. ( flutter/engine#52314 )
...
Follow up from https://github.com/flutter/engine/pull/52290#discussion_r1575451249
2024-04-23 15:01:15 +00:00
skia-flutter-autoroll
ac3c768679
Roll Dart SDK from b340d0f393b6 to acd54f86bdbb (1 revision) ( flutter/engine#52321 )
...
https://dart.googlesource.com/sdk.git/+log/b340d0f393b6..acd54f86bdbb
2024-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-90.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 14:08:31 +00:00
Jonny Wang
b6195c24e7
[fuchsia] Update Fuchsia API version to 17 ( flutter/engine#52266 )
...
Update Fuchsia API version to 17
b/328121174
Changes are tested on device and in google3 in cl/626319415.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-23 13:38:47 +01:00
Kaylee Lubick
17a78534c6
[skia] Remove no-op GN flag ( flutter/engine#52121 )
...
After <https://skia-review.googlesource.com/c/skia/+/826440 > this flag
does nothing.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-23 07:57:59 -04:00
dependabot[bot]
44991beb19
Bump actions/checkout from 4.1.2 to 4.1.3 ( flutter/engine#52318 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.2 to 4.1.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases ">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.1.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Update <code>actions/checkout</code> version in <code>update-main-version.yml</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1650 ">actions/checkout#1650</a></li>
<li>Check git version before attempting to disable <code>sparse-checkout</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1656 ">actions/checkout#1656</a></li>
<li>Add SSH user parameter by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1685 ">actions/checkout#1685</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.2...v4.1.3 ">https://github.com/actions/checkout/compare/v4.1.2...v4.1.3 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1d96c772d1https://redirect.github.com/actions/checkout/issues/1685 ">#1685</a>)</li>
<li><a href="cd7d8d697ehttps://redirect.github.com/actions/checkout/issues/1656 ">#1656</a>)</li>
<li><a href="8410ad0602https://redirect.github.com/actions/checkout/issues/1650 ">#1650</a>)</li>
<li>See full diff in <a href="9bb56186c3...1d96c772d1https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4.1.2&new-version=4.1.3 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-04-23 06:22:30 +00:00
dependabot[bot]
9cf0d27e56
Bump actions/upload-artifact from 4.3.1 to 4.3.3 ( flutter/engine#52319 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.1 to 4.3.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases ">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.3.3</h2>
<h2>What's Changed</h2>
<ul>
<li>updating <code>@actions/artifact</code> dependency to v2.1.6 by <a href="https://github.com/eggyhead "><code>@âeggyhead</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/565 ">actions/upload-artifact#565</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.3.2...v4.3.3 ">https://github.com/actions/upload-artifact/compare/v4.3.2...v4.3.3 </a></p>
<h2>v4.3.2</h2>
<h2>What's Changed</h2>
<ul>
<li>Update release-new-action-version.yml by <a href="https://github.com/konradpabjan "><code>@âkonradpabjan</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/516 ">actions/upload-artifact#516</a></li>
<li>Minor fix to the migration readme by <a href="https://github.com/andrewakim "><code>@âandrewakim</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/523 ">actions/upload-artifact#523</a></li>
<li>Update readme with v3/v2/v1 deprecation notice by <a href="https://github.com/robherley "><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/561 ">actions/upload-artifact#561</a></li>
<li>updating <code>@actions/artifact</code> dependency to v2.1.5 and <code>@actions/core</code> to v1.0.1 by <a href="https://github.com/eggyhead "><code>@âeggyhead</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/562 ">actions/upload-artifact#562</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/andrewakim "><code>@âandrewakim</code></a> made their first contribution in <a href="https://redirect.github.com/actions/upload-artifact/pull/523 ">actions/upload-artifact#523</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.3.1...v4.3.2 ">https://github.com/actions/upload-artifact/compare/v4.3.1...v4.3.2 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="65462800fdc004fb4bf690aba496fcb06cde36fchttps://redirect.github.com/actions/upload-artifact/issues/563 ">#563</a> from actions/eggyhead/release-4.3.2</li>
<li><a href="1746f4ab6531685d04a018bf333cd2https://redirect.github.com/actions/upload-artifact/issues/562 ">#562</a> from actions/eggyhead/update-artifact-v215</li>
<li><a href="dac413befabb3b4a3cdb3e3da837d25d5d22a312...65462800fdhttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.3.1&new-version=4.3.3 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-04-23 06:19:23 +00:00
skia-flutter-autoroll
c66cffd767
Roll Skia from fe545a316f68 to a373bf46bffb (3 revisions) ( flutter/engine#52317 )
...
https://skia.googlesource.com/skia.git/+log/fe545a316f68..a373bf46bffb
2024-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from eb81b28b0318 to 6f21ddc207d7
2024-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b7e3beee69a5 to 91b20c9cf5fd (11 revisions)
2024-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b7cc986dba6d to eb81b28b0318 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 06:15:31 +00:00
skia-flutter-autoroll
2c2d1c3c66
Roll Dart SDK from 9f64eecc8cf3 to b340d0f393b6 (1 revision) ( flutter/engine#52316 )
...
https://dart.googlesource.com/sdk.git/+log/9f64eecc8cf3..b340d0f393b6
2024-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-89.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 05:45:54 +00:00
skia-flutter-autoroll
0627f01acf
Roll Skia from db21ce8d0f28 to fe545a316f68 (1 revision) ( flutter/engine#52313 )
...
https://skia.googlesource.com/skia.git/+log/db21ce8d0f28..fe545a316f68
2024-04-23 johnstiles@google.com Fix signedness of format string.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 03:03:15 +00:00
skia-flutter-autoroll
c56d6c787e
Roll Dart SDK from 95f95b3118fe to 9f64eecc8cf3 (2 revisions) ( flutter/engine#52312 )
...
https://dart.googlesource.com/sdk.git/+log/95f95b3118fe..9f64eecc8cf3
2024-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-88.0.dev
2024-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-87.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 01:58:20 +00:00
skia-flutter-autoroll
9b45fe38f1
Roll Skia from e6de04b82b57 to db21ce8d0f28 (1 revision) ( flutter/engine#52309 )
...
https://skia.googlesource.com/skia.git/+log/e6de04b82b57..db21ce8d0f28
2024-04-22 penghuang@chromium.org graphite: add slice in DawnTextureInfo and DawnTextureSpec
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 00:51:18 +00:00
hellohuanlin
cabd4fcacd
[ios_edit_menu]add native edit menu ( flutter/engine#50095 )
...
Support native edit menu on the engine side.
Design doc: https://docs.google.com/document/d/16-8kn58h_oD902e7vPSh6W20aHRBJKyNOdSe5rbAe_g/edit?resourcekey=0-gVdJ3fbOybV70ZKeHU7fkQ&tab=t.0
*List which issues are fixed by this PR. You must list at least one issue.*
https://github.com/flutter/flutter/issues/103163
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-22 23:36:18 +00:00
Matan Lurey
627238cc93
Fail run_impeller_golden_tests if LUCI_CONTEXT && !GOLDCTL ( flutter/engine#52300 )
...
Works to prevent future outages like https://github.com/flutter/flutter/issues/147180 .
Also added an explicit `--no-skia-gold` flag to use when we don't want Skia Gold used, and used it in the one place we decided (in internal chat) it made sense, `mac_unopt.json` (was added in 674874e613
2024-04-22 23:17:41 +00:00
Jonah Williams
1fd38c8986
[Impeller] skip lineTo for empty contours. ( flutter/engine#52290 )
...
If we close an empty contour, don't insert a lineTo
Fixes https://github.com/flutter/flutter/issues/146648
2024-04-22 23:00:04 +00:00
skia-flutter-autoroll
1d7d365284
Roll Skia from 3b32e3280b67 to e6de04b82b57 (6 revisions) ( flutter/engine#52304 )
...
https://skia.googlesource.com/skia.git/+log/3b32e3280b67..e6de04b82b57
2024-04-22 brianosman@google.com Remove assert in Slug deserialization
2024-04-22 brianosman@google.com Reland "Restore affine bitmap procs"
2024-04-22 armansito@google.com [graphite] Remove stale TODO comment re r8unorm storage
2024-04-22 armansito@google.com [graphite] Use analytic rrect renderer in all path strategies
2024-04-22 kjlubick@google.com Sort load order
2024-04-22 jamesgk@google.com [graphite] Analytic blur for circles
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-22 22:15:27 +00:00
Jonah Williams
dbd72955e4
[Impeller] re-enable gold CTL. ( flutter/engine#52299 )
...
Add goldctl dependency to arm64
Fixes https://github.com/flutter/flutter/issues/147180
2024-04-22 21:01:23 +00:00
skia-flutter-autoroll
af82a28849
Roll Dart SDK from 0ed66a4d77cb to 95f95b3118fe (1 revision) ( flutter/engine#52301 )
...
https://dart.googlesource.com/sdk.git/+log/0ed66a4d77cb..95f95b3118fe
2024-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-86.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-22 20:55:17 +00:00
skia-flutter-autoroll
9e540e1b5e
Roll Skia from eb29b46236e6 to 3b32e3280b67 (1 revision) ( flutter/engine#52298 )
...
https://skia.googlesource.com/skia.git/+log/eb29b46236e6..3b32e3280b67
2024-04-22 kjlubick@google.com Add default_applicable_licenses to all BUILD.bazel files
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-22 20:15:55 +00:00
Jenn Magder
80cd050cae
Break dependency cycle of FlutterViewController <-> FlutterPlatformView ( flutter/engine#52271 )
...
Trying to migrate the iOS embedder MRC to ARC, I'm attempting to break some dependency cycles so it's easier to migrate the "leaf" dependencies to ARC, working my way up.
The cycle is:
**`FlutterViewController`** -> `FlutterView` -> `FlutterPlatformView` -> (Before this PR)**`FlutterViewController`**
`FlutterViewController` depends on many other large MRC classes, like FlutterEngine., so I'd like to pull that one out so `FlutterView`, `FlutterPlatformView`, and `FlutterOverlayView` can be migrated to ARC in a smaller PR.
`FlutterPlatformView` only depends on `FlutterViewController` in this one place, casting a `UIViewController` and calling `-forceTouchesCancelled:`.
0e6143504c/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm (L1201)https://github.com/flutter/flutter/issues/137801 , though this doesn't actually migrate anything to ARC.
2024-04-22 19:03:49 +00:00
Chris Bracken
0ce6126c47
[et] Lookup output filesystem path, not label ( flutter/engine#52248 )
...
Sets BuildTarget.executable to the `root_out_dir`-relative path of the
executable (e.g. `displaylist_unittests`) instead of its label (e.g.
`//out/host_debug/displaylist_unittests`). This is required since, in
the lines following the output lookup, we assume it to be a path
relative to the build output directory.
Also breaks out functions for:
* `_runGnDesc`: returns the JSON output of `gn desc buildDir target`
* `_runGnOutputs`: returns the output files listed by `gn outputs
buildDir target`
Noticed while working on:
https://github.com/flutter/flutter/issues/147071
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-22 11:13:16 -07:00
skia-flutter-autoroll
42f644f9aa
Roll Skia from 975859a96f8f to eb29b46236e6 (9 revisions) ( flutter/engine#52297 )
...
https://skia.googlesource.com/skia.git/+log/975859a96f8f..eb29b46236e6
2024-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 71b11532ed72 to b7e3beee69a5 (1 revision)
2024-04-22 armansito@google.com [graphite] Fix canvaskit build
2024-04-22 michaelludwig@google.com [graphite] Relax fLastTask assert in Device::flushPendingWorkToRecorder
2024-04-22 jamesgk@google.com [graphite] Rename RectBlurData to AnalyticBlurMask
2024-04-22 johnstiles@google.com Remove calls to SkScalarToFloat and SkFloatToScalar.
2024-04-22 johnstiles@google.com Remove SkScalarIsFinite/NaN from public API.
2024-04-22 michaelludwig@google.com [graphite] Don't store unmappable buffer as reusable
2024-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b7cc986dba6d to 2bc8bf46657d
2024-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from dcb627bc133f to b7cc986dba6d (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-22 18:11:06 +00:00
Harry Terkelsen
37db59763d
[canvaskit] Add configuration for maximum canvases ( flutter/engine#51735 )
...
Allows developers to customize the maximum amount of overlay canvases.
Fixes https://github.com/flutter/flutter/issues/144589
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-22 10:56:26 -07:00
PurplePolyhedron
2ae24d260d
Fix link in BlendMode.saturation ( flutter/engine#52156 )
...
Fix typo in the document of `BlendMode.saturation`. It has a link to image https://flutter.github.io/assets-for-api-docs/assets/dart-ui/blend_mode_hue.png , while it should be `blend_mode_saturation.png`
https://github.com/flutter/flutter/issues/146820
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-22 17:48:26 +00:00
Jenn Magder
286b611779
Refactor and migrate FlutterUndoManagerPlugin to ARC ( flutter/engine#52234 )
...
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612 , and the unit tests were migrated in https://github.com/flutter/engine/pull/48162 .
Migrate `FlutterUndoManagerPlugin` from MRC to ARC.
1. Refactor so the plugin and its tests don't need to understand the details of `FlutterViewController` or `FlutterEngine` (its delegate). This decouples the plugin, and means it doesn't depend on any MRC classes.
2. Change the delegate so conforming only requires the objects the undo plugin actually needs.
Part of https://github.com/flutter/flutter/issues/137801 .
2024-04-22 17:14:35 +00:00
skia-flutter-autoroll
076e72215a
Roll Fuchsia Linux SDK from Rr9lFiKCPhMXDGa89... to L533ubzhjWwW7jxbc... ( flutter/engine#52293 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-22 17:11:53 +00:00
skia-flutter-autoroll
c2c0ca89c0
Roll Dart SDK from 0a83dd7e61b1 to 0ed66a4d77cb (1 revision) ( flutter/engine#52294 )
...
https://dart.googlesource.com/sdk.git/+log/0a83dd7e61b1..0ed66a4d77cb
2024-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-85.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-22 17:05:25 +00:00
skia-flutter-autoroll
be1d72fdb6
Roll Dart SDK from d4c5d9c92e4d to 0a83dd7e61b1 (1 revision) ( flutter/engine#52291 )
...
https://dart.googlesource.com/sdk.git/+log/d4c5d9c92e4d..0a83dd7e61b1
2024-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-84.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-21 21:52:34 +00:00
skia-flutter-autoroll
fc847b4506
Roll Fuchsia Linux SDK from 3cyVJn1037SXTT5qT... to Rr9lFiKCPhMXDGa89... ( flutter/engine#52289 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-21 08:48:25 +00:00
skia-flutter-autoroll
a681c5af39
Roll Skia from dec629b762ec to 975859a96f8f (1 revision) ( flutter/engine#52288 )
...
https://skia.googlesource.com/skia.git/+log/dec629b762ec..975859a96f8f
2024-04-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e8d0ea559f94 to b7cc986dba6d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-21 07:49:36 +00:00
skia-flutter-autoroll
81f712a930
Roll Dart SDK from 95e0894dc8e6 to d4c5d9c92e4d (1 revision) ( flutter/engine#52287 )
...
https://dart.googlesource.com/sdk.git/+log/95e0894dc8e6..d4c5d9c92e4d
2024-04-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-83.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-21 03:21:23 +00:00
Jonah Williams
c657c7f7f4
[Impeller] compute UVs in vertex stage. ( flutter/engine#52106 )
...
Split the functionality of texture_fill and tiled_texture_fill vertex stages:
* The former will accept uvs as part of the vertex data and pass it to the fragment stage.
* The latter will compute the uv geometry in the vertex stage from the position and the normalizing transform.
With this functionality, we can delete all of the CPU based uv computation code. Additionally, there is some clean up to remove support for external textures (which use the tiled texture mode) from the texture contents. The external textures are used with an image shader/draw rect by internal engine code and won't go down the drawImageRect path anymore.
2024-04-20 19:41:19 +00:00
skia-flutter-autoroll
3af46f1395
Roll Fuchsia Linux SDK from RruZA4WorQDkGpz25... to 3cyVJn1037SXTT5qT... ( flutter/engine#52283 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-20 07:44:23 +00:00
skia-flutter-autoroll
7544f4e8ee
Roll Skia from 9735c573e7e9 to dec629b762ec (1 revision) ( flutter/engine#52282 )
...
https://skia.googlesource.com/skia.git/+log/9735c573e7e9..dec629b762ec
2024-04-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from dcb627bc133f to fd7f30873028
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-20 05:31:23 +00:00
skia-flutter-autoroll
b5f7f7731e
Roll Skia from 7be6fe3150fc to 9735c573e7e9 (2 revisions) ( flutter/engine#52281 )
...
https://skia.googlesource.com/skia.git/+log/7be6fe3150fc..9735c573e7e9
2024-04-20 michaelludwig@google.com [graphite] Track failed Buffer mappings to cause snap() to return null Recording
2024-04-20 armansito@google.com [graphite][vello] Use R8UnormStorage feature in compute path atlas
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-20 04:41:22 +00:00
Chris Bracken
c9f3a89bf4
[et] Fix concurrent modification exception ( flutter/engine#52247 )
...
We cannot modify the list of build targets as we're iterating over it. Instead of removing non-test/non-executable elements, instead we add executable test targets to a separate testTargets list and use that.
Noticed while working on: https://github.com/flutter/flutter/issues/147071
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-20 03:40:59 +00:00
John Stiles
a439829bf6
Remove SkScalarIsFinite from Flutter Engine. ( flutter/engine#52270 )
...
SkScalarIsFinite is deprecated. Use `std::isfinite` instead.
2024-04-20 03:37:06 +00:00
skia-flutter-autoroll
c5b677c1d4
Roll Skia from 514d7fc627b3 to 7be6fe3150fc (1 revision) ( flutter/engine#52280 )
...
https://skia.googlesource.com/skia.git/+log/514d7fc627b3..7be6fe3150fc
2024-04-20 armansito@google.com Roll vello from 74715ee4650e to 6c1e8b815b1e (19 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-20 03:04:30 +00:00
Chris Bracken
f5b84d2125
[et] Simplify path canonicalisation logic ( flutter/engine#52275 )
...
In order to canonicalise paths, previously we were doing an iterative
computation to resolve symlinks to a canonical path, directory by
directory. This was because on macOS and other BSDs, readlink doesn't
support the `-f` (follow symlinks) option. However, macOS and other
BSD-based systems *do* bundle the `realpath` utility, which resolves
symlinks.
This patch is stacked on top of #52274 and is the second commit
(dec38dda38d1ef0bc3a548ef1f750c5855e9d9f4).
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-19 19:21:58 -07:00
skia-flutter-autoroll
7793174797
Roll Dart SDK from d882ce089110 to 95e0894dc8e6 (1 revision) ( flutter/engine#52279 )
...
https://dart.googlesource.com/sdk.git/+log/d882ce089110..95e0894dc8e6
2024-04-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-82.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-20 02:04:23 +00:00
skia-flutter-autoroll
296824d8b5
Roll Skia from 1910252ea26a to 514d7fc627b3 (6 revisions) ( flutter/engine#52277 )
...
https://skia.googlesource.com/skia.git/+log/1910252ea26a..514d7fc627b3
2024-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4737535cad1a to 71b11532ed72 (6 revisions)
2024-04-19 bungeman@google.com [paragraph] Only load typefaces once in tests
2024-04-19 michaelludwig@google.com Revert "Restore affine bitmap procs"
2024-04-19 bungeman@google.com Make sysopen python3
2024-04-19 johnstiles@google.com Replace SkIsFinite with a parameter-pack implementation.
2024-04-19 michaelludwig@google.com [graphite] One-time uploads can be discarded
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-20 00:50:12 +00:00
Chris Bracken
d0cef3ee8a
[et] Fix path canonicalization ( flutter/engine#52274 )
...
Previously we were getting the enclosing directory path of the `et` tool
(via the `dirname` builtin), then canonicalising the path by resolving
symlinks. This doesn't work if the `et` on the path is itself a symlink.
For example, if a user created a symlink `et` in a concrete directory at
`~/.local/bin`:
```
~/.local/bin/et -> ~/src/flutter/engines/src/flutter/bin/et
```
first we'd compute the dirname of the script:
```
~/.local/bin
```
then we'd resolve symlinks:
```
~/.local/bin
```
and incorrectly assume that was the engine directory.
Instead, we now resolve symlinks, then compute the enclosing directory.
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-19 17:24:26 -07:00
skia-flutter-autoroll
c13825e3b1
Roll Dart SDK from 2ff00e4eb759 to d882ce089110 (1 revision) ( flutter/engine#52272 )
...
https://dart.googlesource.com/sdk.git/+log/2ff00e4eb759..d882ce089110
2024-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-81.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 22:12:12 +00:00
Tong Mu
83414d7856
[macOS] Consolidate view management ( flutter/engine#52254 )
...
This PR improves view management logic of the macOS `FlutterEngine`
class.
* View operation assertions are now centralized in
`registerViewController:` and `deregisterViewControllerForIdentifier:`.
* `addViewController` now directly calls `.viewController =` on implicit
views, so that it matches its verbatim description.
* The doc for `addViewController` correctly reflects the fact that it
doesn't support multiple views yet.
Additionally, a useless (for now) member variable is removed.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-19 14:25:49 -07:00
skia-flutter-autoroll
7731c03636
Roll Skia from f4a214ecf197 to 1910252ea26a (3 revisions) ( flutter/engine#52269 )
...
https://skia.googlesource.com/skia.git/+log/f4a214ecf197..1910252ea26a
2024-04-19 michaelludwig@google.com [graphite] Add Swizzle::selectChannelInR(i) helper
2024-04-19 brianosman@google.com Tweak RescaleWithTransform test expectations
2024-04-19 brianosman@google.com Add SkArc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 21:24:12 +00:00
Jonah Williams
9aeeb27d88
[Impeller] add non-emulated advanced blend support to experimental canvas ( flutter/engine#52245 )
...
Adds support for non-emulated advnaced blends (Android Vulkan and iOS devices). Still need to add support for emulation when we do backdrop filters.
2024-04-19 21:24:09 +00:00
Jonah Williams
0e6143504c
[Impeller] organize texture shaders / delete blend.frag + external_texture_fill ( flutter/engine#52137 )
...
* Deletes blend.frag/vert . This was identical to the existing texture_fill shader.
* Move alpha to frag info and stop passing as varying.
~~* Deletes strict src rect fragment shader. We should be able to compute the UVs on the CPU, which is trivial since this is only used for rectangular draws.~~
* Deletes external texture fill in favor of tiled texture external fill. The former shader is marginally faster, but we don't use it since we don't correctly check for the right extensions needed for non-emulated sampling modes with external textures on GLES. Easier to just always use emulated tile modes
2024-04-19 20:48:18 +00:00
skia-flutter-autoroll
a3573b1f91
Roll Skia from 0689969ffaee to f4a214ecf197 (1 revision) ( flutter/engine#52265 )
...
https://skia.googlesource.com/skia.git/+log/0689969ffaee..f4a214ecf197
2024-04-19 johnstiles@google.com Switch std::isfinite to SkIsFinite throughout Skia.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 18:50:20 +00:00
Jim Graham
2f1254623a
[Impeller] Use the new DisplayList depth info in the experimental canvas prototype ( flutter/engine#52214 )
...
Plumbing the new DL depth data into the experimental direct rendering Impeller canvas prototype.
2024-04-19 18:35:06 +00:00
