Chris Bracken
eaffc462ae
[License] Enable avoid_positional_boolean_parameters lint ( #7275 )
2018-12-20 16:05:43 -08:00
Chris Bracken
b07753badc
[License] Sync analysis_options.yaml from framework ( #7273 )
...
Updates to the framework analysis_options.yaml, but enables a few more lints that
(a) seem sensible and
(b) don't require any code changes.
2018-12-20 15:36:35 -08:00
Chris Bracken
233c100b69
[License] Enable always_require_non_null_named_parameters
...
Adds dependency on package:meta.
2018-12-20 14:56:23 -08:00
Chris Bracken
f4b348f779
[License] Enable flutter_style_todos lint
2018-12-20 14:56:23 -08:00
Chris Bracken
48be433ce2
[License] Enable prefer_is_empty lint
2018-12-20 14:56:23 -08:00
Chris Bracken
bd648bad6e
[License] Enable prefer_const_constructors lint
2018-12-20 14:56:23 -08:00
Chris Bracken
2b207a51c7
[License] Enable unnecessary_parenthesis lint
2018-12-20 14:56:23 -08:00
Chris Bracken
97ae27164e
[License] Enable prefer_initializing_formals lint
2018-12-20 14:56:23 -08:00
Chris Bracken
c8f83fbea2
[License] Enable prefer_collection_literals lint
2018-12-20 14:56:23 -08:00
Chris Bracken
d120e15af6
[License] Enable prefer_void_to_null lint
2018-12-20 14:56:23 -08:00
Chris Bracken
e2ab3780a3
[License] Enable directives_ordering lint
2018-12-20 14:56:23 -08:00
Chris Bracken
5f2e6cd419
[License] Enable unnecessary_overrides lint
2018-12-20 14:56:23 -08:00
Chris Bracken
bd955d78a7
[License] Enable avoid_function_literals_in_foreach_calls lint
2018-12-20 14:56:23 -08:00
Chris Bracken
392df65f69
[License] Enable prefer_const_declarations lint
2018-12-20 14:56:23 -08:00
Chris Bracken
06e35912da
[License] Enable prefer_final_fields lint
2018-12-20 14:56:23 -08:00
Chris Bracken
32423ef386
[License] Enable prefer_asserts_in_initializer_lists lint
2018-12-20 14:56:23 -08:00
Chris Bracken
4703a7f108
[License] Enable prefer_equal_for_default_values lint
2018-12-20 14:56:23 -08:00
Chris Bracken
1d7285beac
[License] Enable empty_catches lint
2018-12-20 14:56:23 -08:00
Chris Bracken
68fadca0e1
[License] Enable unnecessary_this lint
2018-12-20 14:56:23 -08:00
Chris Bracken
c6f5e67cbe
[License] Enable prefer_single_quotes lint
2018-12-20 14:56:23 -08:00
Justin McCandless
cc51731d82
Clarify TextAffinity docs ( #7238 )
...
* Clarify TextAffinity docs
* Clarify TextPosition and the definition of upstream/downstream
* Docs fixes from code review, less redundant with 'string in code'
2018-12-20 14:14:04 -08:00
Chris Bracken
6a9041853c
[License] Assert license filename is non-null, non-empty ( #7270 )
2018-12-20 13:50:21 -08:00
Chris Bracken
72aa378428
[License] Eliminate duplicate case in switch ( #7269 )
...
This changes behaviour, but we should treat diffs as binary for the
reasons outlined in the comment on the remaining diff case.
2018-12-20 13:22:30 -08:00
Chris Bracken
74af4429a5
Mark all unreassigned locals final in license tool ( #7267 )
...
Marks locals final where possible, and enables the prefer_final_locals
lint.
2018-12-20 12:27:50 -08:00
skia-flutter-autoroll
0310e910d6
Roll src/third_party/skia 44539be30ef8..b03e024a4034 (7 commits) ( #7268 )
...
https://skia.googlesource.com/skia.git/+log/44539be30ef8..b03e024a4034
Created with:
gclient setdep -r src/third_party/skia@b03e024a4034
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-20 15:19:47 -05:00
Stanislav Baranov
e859296b71
Document native functions for compilation trace ( #7256 )
2018-12-20 11:48:59 -08:00
Chris Bracken
b81d1b4736
Eliminate use of new keyword in licence tool ( #7266 )
...
This eliminates the use of the now-optional new keyword and enforces the
unnecessary_new lint.
2018-12-20 11:29:28 -08:00
skia-flutter-autoroll
dbdb5e6f8c
Roll src/third_party/skia 428ec1e55c05..44539be30ef8 (1 commits) ( #7265 )
...
https://skia.googlesource.com/skia.git/+log/428ec1e55c05..44539be30ef8
Created with:
gclient setdep -r src/third_party/skia@44539be30ef8
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-20 10:44:33 -05:00
skia-flutter-autoroll
cf11d86bf7
Roll src/third_party/skia 21ee517391bc..428ec1e55c05 (3 commits) ( #7264 )
...
https://skia.googlesource.com/skia.git/+log/21ee517391bc..428ec1e55c05
Created with:
gclient setdep -r src/third_party/skia@428ec1e55c05
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-20 05:57:53 -05:00
Chris Bracken
2d2b9d753c
Re-run license tool on all source when it changes ( #7260 )
...
The license tool includes an optimization whereby it skips re-running on
components (flutter, third_party, skia, currently) when it detects that
no changes have occurred to the sources in that component.
When the license script itself changes, we now force re-run it on all
components in order to verify the tool still works and output is as
expected.
2018-12-19 23:15:44 -08:00
skia-flutter-autoroll
5fa1d59809
Roll src/third_party/skia 7757bba636d8..21ee517391bc (1 commits) ( #7263 )
...
https://skia.googlesource.com/skia.git/+log/7757bba636d8..21ee517391bc
Created with:
gclient setdep -r src/third_party/skia@21ee517391bc
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-20 01:35:24 -05:00
skia-flutter-autoroll
6a1f01724c
Roll src/third_party/skia ce9a901a76eb..7757bba636d8 (4 commits) ( #7262 )
...
https://skia.googlesource.com/skia.git/+log/ce9a901a76eb..7757bba636d8
Created with:
gclient setdep -r src/third_party/skia@7757bba636d8
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-19 21:31:15 -05:00
Jason Simmons
079d604523
Add a system message channel for controlling the Skia resource cache size ( #7257 )
...
See https://github.com/flutter/flutter/issues/25244
2018-12-19 17:40:16 -08:00
Jason Simmons
41222d0555
Update usage of some Android APIs that are deprecated in API level 28 ( #7261 )
2018-12-19 17:39:53 -08:00
Jason Simmons
5ec8ef8509
Remove unused GrContext in AndroidSurfaceGL ( #7258 )
2018-12-19 15:06:58 -08:00
skia-flutter-autoroll
c08a80ada6
Roll src/third_party/skia 8d23a584fc43..ce9a901a76eb (10 commits) ( #7259 )
...
https://skia.googlesource.com/skia.git/+log/8d23a584fc43..ce9a901a76eb
Created with:
gclient setdep -r src/third_party/skia@ce9a901a76eb
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-19 17:24:44 -05:00
Stanislav Baranov
9edb4f72b9
Update dynamic patching terminilogy to match that of the flutter tool ( #7248 )
2018-12-19 10:31:54 -08:00
skia-flutter-autoroll
2c9fc872db
Roll src/third_party/skia 1a237195b527..8d23a584fc43 (8 commits) ( #7255 )
...
https://skia.googlesource.com/skia.git/+log/1a237195b527..8d23a584fc43
Created with:
gclient setdep -r src/third_party/skia@8d23a584fc43
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-19 13:31:02 -05:00
Dan Field
8b73b9d42c
Fix javadoc for Android-28 ( #7254 )
...
* Fix javadoc for Android-28
* build javadoc as part of pre-submit
2018-12-19 09:24:02 -08:00
skia-flutter-autoroll
2e4a02719d
Roll src/third_party/skia 192d66440910..1a237195b527 (1 commits) ( #7253 )
...
https://skia.googlesource.com/skia.git/+log/192d66440910..1a237195b527
Created with:
gclient setdep -r src/third_party/skia@1a237195b527
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-19 08:29:05 -05:00
skia-flutter-autoroll
ccaac1af35
Roll src/third_party/skia b933285ebb4e..192d66440910 (3 commits) ( #7252 )
...
https://skia.googlesource.com/skia.git/+log/b933285ebb4e..192d66440910
Created with:
gclient setdep -r src/third_party/skia@192d66440910
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-19 03:05:23 -05:00
Chris Bracken
8939e2abeb
Fix a misspelling ( #7234 )
...
Change funciton to function in a doc comment.
2018-12-18 20:08:46 -08:00
Chris Bracken
ada6748d0c
Extract function to collect licenses for component ( #7250 )
...
Extracts _collectLicensesForComponent() from main, which collects the
licenses for the specified component (e.g. flutter, third_party, skia).
This is pre-factoring related to a fix for flutter/flutter#25519 .
2018-12-18 20:08:15 -08:00
skia-flutter-autoroll
9f10b10a0f
Roll src/third_party/skia 67761eb35f97..b933285ebb4e (1 commits) ( #7251 )
...
https://skia.googlesource.com/skia.git/+log/67761eb35f97..b933285ebb4e
Created with:
gclient setdep -r src/third_party/skia@b933285ebb4e
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-18 22:56:43 -05:00
Dan Field
cfbc948647
Roll buildroot to support Android SDK 28 ( #7245 )
...
* Roll to buildroot and support Android SDK 28
* Ubuntu 16 for android build test
2018-12-18 19:38:28 -08:00
skia-flutter-autoroll
526e0e3afb
Roll src/third_party/skia 4b75254560d4..67761eb35f97 (6 commits) ( #7249 )
...
https://skia.googlesource.com/skia.git/+log/4b75254560d4..67761eb35f97
Created with:
gclient setdep -r src/third_party/skia@67761eb35f97
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-18 18:40:26 -05:00
skia-flutter-autoroll
370cc67d94
Roll src/third_party/skia e6f635476da3..4b75254560d4 (61 commits) ( #7247 )
...
https://skia.googlesource.com/skia.git/+log/e6f635476da3..4b75254560d4
Created with:
gclient setdep -r src/third_party/skia@4b75254560d4
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-18 16:07:27 -05:00
Jason Simmons
e8f4968d64
Update iOS unit test for the removal of hex string encoding of uint64 data ( #7246 )
2018-12-18 11:16:38 -08:00
liyuqian
ba117366ef
Compute cull_rect and optimize in Layer::Preroll ( #6923 )
...
This PR replaces the unused `PrerollContext::child_paint_bounds` with `PrerollContext::cull_rect` so we can prune unnecessary preroll tasks (especially cache) based on clips. This PR fixes https://github.com/flutter/flutter/issues/24712
Performance test has been added (https://github.com/flutter/flutter/pull/25381 ) to make sure that we won't regress again in the future.
Note that the cull_rect here is very similar to those removed in https://github.com/flutter/engine/pull/6352 . We can't compute cull rects in SceneBuilder because of retained layers. But we can still compute and use them to optimize performance in Preroll.
2018-12-18 09:54:52 -08:00
Todd Volkert
fbce2bf145
Fix linter errors in ResourceUpdater ( #7240 )
2018-12-18 07:40:57 -08:00