DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
29,131 Commits 882 Branches 1,069 Tags
Commit Graph

29131 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Renzo Olivares
ea95b85e63 [macOS] Do not bounce editing state back to framework on setEditState (flutter/engine#42091) 
Some context for this change https://github.com/flutter/flutter/issues/118642#issuecomment-1550864240 and https://github.com/flutter/flutter/issues/118759#issuecomment-1551906489 . Tldr, the use-case that this bouncing was originally introduced for in #13702 is no longer an issue.

This ack response is also not present on other desktop platforms or iOS.

Fixes [#118759](https://github.com/flutter/flutter/issues/118759) and [#118642](https://github.com/flutter/flutter/issues/118642)
 2023-05-26 21:07:02 +00:00
Mouad Debbar
ad6f346f5f [web] Correct JS property name for baseUri (flutter/engine#42357) 
Up to this point, whenever users use the `PathUrlStrategy`, they would be using `flutter_web_plugins`'s copy of `BrowserPlatformLocation` which has a [different implementation for `getBaseHref()`](9376a2ac60/packages/flutter_web_plugins/lib/src/navigation/url_strategy.dart (L235)). So we never hit the [implementation in the engine](d73aac2434/lib/web_ui/lib/ui_web/src/ui_web/navigation/platform_location.dart (L138)), meaning the bug was invisible.

Now that we are [removing](https://github.com/flutter/flutter/pull/126851) `BrowserPlatformLocation` from `flutter_web_plugins`, we are hitting the engine's implementation which contains the bug being solved in this PR.
 2023-05-26 20:16:59 +00:00
gaaclarke
d73aac2434 Started executing vulkan unit tests with validation on macos (flutter/engine#42337) 
fixes https://github.com/flutter/flutter/issues/127634

This PR depends on a buildroot change at https://github.com/flutter/buildroot/pull/737

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-26 19:05:19 +00:00
Dan Field
83b6fa4ff7 [Impeller] Avoid encoding metal commands while the GPU is unavailable when decoding images. (flutter/engine#42349) 
Fixes https://github.com/flutter/flutter/issues/126878

This disables device private upload on iOS when backgrounded, and disables mipmap generation when backgrounded.

We don't have a good way to test the core problem in this repo because it only reproduces on physical iOS hardware - simulators don't really care if you do this stuff in the background.

I'll write a devicelab test in the framework to capture this. In the mean time it can be reviewed.

We could consider making the IOManager a shared_ptr instead of having an fml::WeakPtr and that'd clean up some of the extra arguments to engine construction - or we could consider vending the sync switch from impeller::Context unconditionally, but it's pretty iOS specific...
 2023-05-26 18:46:33 +00:00
Mouad Debbar
8259db4b30 [web] Use the new js_util.callMethod(Object, Object) (flutter/engine#42352) 
Now that `js_util.callMethod` can take an `Object` as a method name, we can use it directly for methods that are accessed through a `Symbol`.
 2023-05-26 18:31:47 +00:00
Jackson Gardner
30a56394c9 Don't use a factory constructor on the finalization registry. (flutter/engine#42350) 
The factory constructor breaks the Google3 build for some reason. See b/284478971
 2023-05-26 17:56:05 +00:00
godofredoc
afe56803a3 Checkout android and emsdk deps in linux. (flutter/engine#42339) 
This is to optimize the caches for builders that require those dependencies.

Bug: https://github.com/flutter/flutter/issues/127627

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-26 17:20:38 +00:00
Hassan
f0e2596c5c [web] - Fix autofill group input ordering (flutter/engine#42268) 
Ordering of input elements inside of the DOM tree for autofill groups does not reflect the order of the form rendered on screen.  This is causing some issues with password managers and autofill, specifically Bitwarden.

We are currently always appending the currently focused input element to the end of the form. 

This leads to a tree that appears out of order:
<img width="354" alt="Screenshot 2023-05-23 at 2 57 37 PM" src="https://github.com/flutter/engine/assets/110993981/7e90a93f-5522-4482-8fb6-a1607b403d10">

This fix is tracking the position of where the focused input node should be inserted and inserting it there, rather than always at the end of the form.  Once the tree is ordered correctly, Bitwarden's autofill logic works in Flutter forms. 

Tree order after fix:
<img width="502" alt="Screenshot 2023-05-23 at 6 01 05 PM" src="https://github.com/flutter/engine/assets/110993981/bd15a8a1-71f4-4f28-a86e-1903953bf030">

Fixes https://github.com/flutter/flutter/issues/61301
 2023-05-26 16:17:18 +00:00
skia-flutter-autoroll
b6e8bd6234 Roll Skia from 1622df035714 to ac897edeb16a (1 revision) (flutter/engine#42348) 
https://skia.googlesource.com/skia.git/+log/1622df035714..ac897edeb16a

2023-05-26 brianosman@google.com Revert "Omit frame pointers in SkOpts code."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-26 15:44:29 +00:00
Zachary Anderson
dc511a362b Revert Dart SDK to 398e847c0b24ad2e57194844410613b7dadcb74f (flutter/engine#42347) 
Revert for https://github.com/flutter/flutter/issues/127666
 2023-05-26 08:07:25 -07:00
Jason Simmons
6bd25a9256 Apply the drawShadow bounds workaround to the Web HTML backend (flutter/engine#42304) 
Previously the Flutter framework had been inflating the rectangle computed for the bounds of a drawShadow operation in order to work around potential inaccuracies in the SkPicture's bounds calculation.

That workaround is now obsolete for most platforms and was removed from the framework (see https://github.com/flutter/flutter/pull/127052). But the Web HTML backend is using different code for computing shadow bounds.  This PR restores the workaround for Web HTML for consistency with the old behavior.
 2023-05-26 14:31:26 +00:00
skia-flutter-autoroll
916a526271 Roll Dart SDK from f17b745f5c3c to 398e847c0b24 (1 revision) (flutter/engine#42345) 
https://dart.googlesource.com/sdk.git/+log/f17b745f5c3c..398e847c0b24

2023-05-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-151.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-26 14:13:22 +00:00
skia-flutter-autoroll
2d4c5d60db Roll Fuchsia Mac SDK from AgIKKqtBtb6RJnyI9... to c6-zqvlx2YtyGwGzJ... (flutter/engine#42344) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-26 10:32:08 +00:00
skia-flutter-autoroll
da13fc6c28 Roll Fuchsia Linux SDK from DNwJQMQZladAsKTjv... to 9aZkaKhX4GslPUnbX... (flutter/engine#42343) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-26 08:56:13 +00:00
skia-flutter-autoroll
f8190203c2 Roll Skia from 7e20e6679785 to 1622df035714 (1 revision) (flutter/engine#42342) 
https://skia.googlesource.com/skia.git/+log/7e20e6679785..1622df035714

2023-05-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c18972fdef08 to 388a184dd781 (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-26 08:14:58 +00:00
skia-flutter-autoroll
19236e29e3 Roll Dart SDK from bc65e3f5efa0 to f17b745f5c3c (1 revision) (flutter/engine#42341) 
https://dart.googlesource.com/sdk.git/+log/bc65e3f5efa0..f17b745f5c3c

2023-05-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-150.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-26 07:42:04 +00:00
skia-flutter-autoroll
2bdf483ebd Roll Skia from a47a68da8291 to 7e20e6679785 (1 revision) (flutter/engine#42340) 
https://skia.googlesource.com/skia.git/+log/a47a68da8291..7e20e6679785

2023-05-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2b787917e4a3 to 9b8f1aed38ff (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-26 07:24:39 +00:00
skia-flutter-autoroll
d33199bde2 Roll Skia from be337bef2ad5 to a47a68da8291 (1 revision) (flutter/engine#42338) 
https://skia.googlesource.com/skia.git/+log/be337bef2ad5..a47a68da8291

2023-05-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 4b35f52f9b33 to ab6a9b9906ca (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-26 05:30:23 +00:00
Jackson Gardner
387666e22f Proper memory management in Skwasm (flutter/engine#42328) 
This fixes https://github.com/flutter/flutter/issues/127243.

This ensures that native skwasm objects are cleaned up when their associated dart-side objects are garbage collected.
 2023-05-26 03:46:26 +00:00
skia-flutter-autoroll
d58d802fce Roll Skia from f2de22b5f0f6 to be337bef2ad5 (1 revision) (flutter/engine#42336) 
https://skia.googlesource.com/skia.git/+log/f2de22b5f0f6..be337bef2ad5

2023-05-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 354eac3ca8c8 to 7fd101e2d93d (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-26 03:18:51 +00:00
skia-flutter-autoroll
fdcf37ef3f Roll Skia from bd677c195886 to f2de22b5f0f6 (1 revision) (flutter/engine#42335) 
https://skia.googlesource.com/skia.git/+log/bd677c195886..f2de22b5f0f6

2023-05-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 2b787917e4a3 to 9b8f1aed38ff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-26 02:25:20 +00:00
skia-flutter-autoroll
affd16ab85 Roll Dart SDK from 5697e9123611 to bc65e3f5efa0 (2 revisions) (flutter/engine#42334) 
https://dart.googlesource.com/sdk.git/+log/5697e9123611..bc65e3f5efa0

2023-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-149.0.dev
2023-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-148.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-26 01:52:15 +00:00
Jason Simmons
ff27c6d7a5 [Impeller] Disable the wide gamut settings flag on iOS simulators (flutter/engine#42331) 
Wide gamut is not supported on the iOS simulator, and the iOS platform's FlutterView.isWideGamutSupported checked for this.  However, the ImageDecoder decides whether to enable wide gamut based on the engine's settings, so the flag in the settings needs to be modified for the simulator.
 2023-05-26 00:31:10 +00:00
Tong Mu
3a4bdfa370 [macOS] Multi-view thread synchronizer (flutter/engine#41915) 
This PR adapts `FlutterThreadSynchronizer` to multi-view.

### Problem
The `FlutterThreadSynchronizer` is a macOS engine class to ensure that, if the current window is resized, nothing will not be presented until the layer tree is drawn with the up-to-date size. 

This class is not compatible with multiview. A simple way to realize it is: while the class is owned by `FlutterView`, it blocks the _global_ platform thread and rasterizer thread - there is got to be some problems. Indeed, when I was testing with multiple windows (https://github.com/flutter/engine/pull/40399), the app freezes as soon as I resize a window.

The problem is because Flutter only have one rasterizer thread. When I'm resizing window A, A's synchronizer detects that the size mismatches, so it blocks the rasterizer thread to wait for an updated content with the updated size. However, window B is to be rendered next, and B's size matches and will try to rasterize, and will be blocked due to the blocked rasterizer thread, window A's updated content will never arrive, causing a deadlock.

### Changes
This PR removes the single-view assumption of `FlutterThreadSynchronizer` by making it created by `FlutterEngine` and shared by all `FlutterView`s, and that it prevents rasterization for all views if any view has a mismatched size.

The synchronizer is assigned to the view controller in the `attachToEngine:withId` method (now renamed to `setUpWithEngine:viewId:threadSynchronizer:`.

This PR also adds unit tests for `FlutterThreadSynchronizer`, which didn't have any unit tests at all.
* To achieve this, the `beginResizeForView:` method no longer checks whether  is called on the main thread, but whether it's called on the main queue. These are equivalent for the real main queue, since the documentation promises that the main queue always executes on the main thread. However, this change allows substituting the queue with a custom one for unit tests.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-25 22:37:35 +00:00
skia-flutter-autoroll
792d3bafcb Roll Dart SDK from 0e78305875a4 to 5697e9123611 (1 revision) (flutter/engine#42327) 
https://dart.googlesource.com/sdk.git/+log/0e78305875a4..5697e9123611

2023-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-147.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 21:59:49 +00:00
Jim Graham
de4939288a Move checkerboard unit tests onto DisplayList mechanism (flutter/engine#41951) 
Part of an ongoing set of efforts to address https://github.com/flutter/flutter/issues/106448

Move the checkerboard layer unit tests onto the DisplayList version of the paint contexts and fix some bugs in the reusability of the DisplayListBuilder that this migration uncovered.
 2023-05-25 21:56:25 +00:00
Jackson Gardner
8719978821 [Skwasm] Implement miscellaneous drawing APIs (flutter/engine#42324) 
Implements `drawVertices`, `drawPoints`, and `drawAtlas`.

These are the last rendering APIs that are unimplemented in Skwasm! (Although we still need to add platform view support).
 2023-05-25 21:53:23 +00:00
skia-flutter-autoroll
61720177c6 Roll Fuchsia Mac SDK from X4uS4T6_J-VUh9M4A... to AgIKKqtBtb6RJnyI9... (flutter/engine#42326) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 21:47:01 +00:00
skia-flutter-autoroll
edd719200e Roll Skia from e648bf802cd2 to bd677c195886 (2 revisions) (flutter/engine#42325) 
https://skia.googlesource.com/skia.git/+log/e648bf802cd2..bd677c195886

2023-05-25 kjlubick@google.com Make test tags configurable
2023-05-25 michaelludwig@google.com [skif] Fix required input recursion for Runtime image filters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 21:11:05 +00:00
Tong Mu
3b00b85da8 [Rasterizer] Make resubmit information temporary (flutter/engine#42001) 
This PR refactors `Rasterizer` so that the resubmit information is
returned as a temporary struct instead of stored permanently as class
member. This limits the lifetime of these values and reduces class
members.

Additionally, this benefits the multi-view project: if the rasterizer is
going to store multiple surfaces, what variables should be stored in a
map from view IDs? Should all surfaces have a to-be-submitted record?
The answer is "no", because these information is only temporary.

This PR should not need unit tests since it's only a refactor.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-25 13:11:23 -07:00
Jackson Gardner
23cd1255b9 Implement Web Codecs for Skwasm (flutter/engine#42184) 
This implements making images from web browser codecs.

This implements a JS support library as well, which allows both the main thread and the background thread to keep a registry of JS objects that can be referenced by a numeric ID and transferred between each other.
 2023-05-25 19:51:06 +00:00
godofredoc
c62ef76f75 Move linux clang tidy to engine_v2. (flutter/engine#42112) 
This PR moves the v2 from staging to prod and it also moves linux android | host clang tidy to staging.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-25 19:35:18 +00:00
skia-flutter-autoroll
96c5092177 Roll Skia from 69d0aa065992 to e648bf802cd2 (11 revisions) (flutter/engine#42323) 
https://skia.googlesource.com/skia.git/+log/69d0aa065992..e648bf802cd2

2023-05-25 robertphillips@google.com Improve units tests a little bit
2023-05-25 robertphillips@google.com Fix DMSAA RRectOp bug with skew matrices
2023-05-25 robertphillips@google.com [graphite] Move tiled image drawing utilities to their own file(s)
2023-05-25 drott@chromium.org [Fontations] Don't assert scaler understands all outlines
2023-05-25 brianosman@google.com Remove all ARM CPU feature detection
2023-05-25 nicolettep@google.com [graphite] Create & bind descriptor sets in VulkanCommandBuffer
2023-05-25 jvanverth@google.com [graphite] Add begin/endRenderPass for Vulkan backend.
2023-05-25 kjlubick@google.com Remove Ganesh code from SkBlenderBase and SkBlendModeBlender
2023-05-25 jvanverth@google.com [graphite] Patch up some Vulkan shader issues
2023-05-25 michaelludwig@google.com [skif] Simplify new input/output bounds recursion
2023-05-25 michaelludwig@google.com [skif] FilterResult::Builder can bind FilterResults to sksl shaders

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 19:23:23 +00:00
Jackson Gardner
aa7b3fcf98 Only use 8 cores for web test compilation. (flutter/engine#42321) 2023-05-25 19:14:06 +00:00
skia-flutter-autoroll
d5faba4008 Roll Fuchsia Linux SDK from nLnQzTesaABpgroOl... to DNwJQMQZladAsKTjv... (flutter/engine#42322) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 19:08:08 +00:00
Valentin Hăloiu
7fa6d7123c Dynamically link against system fontconfig (flutter/engine#40725) 
This is the engine counterpart for https://github.com/flutter/buildroot/pull/701. That pull-request contains more context and the main motivation for this change.

This should fix some startup performance issues related to font loading on desktop linux: https://github.com/flutter/flutter/issues/118911.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-25 18:43:06 +00:00
Matej Knopp
634c40bf03 [macOS] Fix FlutterViewController retain cycle (flutter/engine#42317) 
Fixes https://github.com/flutter/flutter/issues/127572

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-25 16:49:05 +00:00
Dan Field
45c1fe4348 Implement PlatformDispatcher.displays on web (flutter/engine#42297) 
I missed this before.
 2023-05-25 16:46:58 +00:00
skia-flutter-autoroll
57fb0c0135 Roll Skia from b80e74dc4cda to 69d0aa065992 (3 revisions) (flutter/engine#42319) 
https://skia.googlesource.com/skia.git/+log/b80e74dc4cda..69d0aa065992

2023-05-25 kjlubick@google.com Manually Roll Dawn from 028726497ad3 to 4b35f52f9b33 (32 revisions)
2023-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9ad20521dc02 to 354eac3ca8c8 (2 revisions)
2023-05-25 michaelludwig@google.com [skif] Remove legacy Merge filter implementation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 16:37:47 +00:00
Brandon DeRosier
be73e88f17 [Impeller] Safely access snapshot in the pipeline blend filter (flutter/engine#42314) 
Spotted by @zanderso.
 2023-05-25 09:32:23 -07:00
Brandon DeRosier
273bb77b61 [Impeller] Add generic path for mask blurring (flutter/engine#42308) 
Resolves https://github.com/flutter/flutter/issues/127013.

Makes mask blurs work for most color source + geometry combinations.
Crucially, this doesn't interfere with the fast paths for solid color
RRect blurs (used for shadows).

I'll be addressing mask blurs for text in a follow-up.
 2023-05-25 09:31:20 -07:00
skia-flutter-autoroll
fee0534882 Roll Skia from fbba25f66405 to b80e74dc4cda (2 revisions) (flutter/engine#42316) 
https://skia.googlesource.com/skia.git/+log/fbba25f66405..b80e74dc4cda

2023-05-25 kjlubick@google.com Fix Bazel viewer build
2023-05-25 kjlubick@google.com Move SkJpegInfo impls to src/pdf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 14:39:15 +00:00
skia-flutter-autoroll
c47c2586ad Roll Dart SDK from be01f9fdac37 to 0e78305875a4 (1 revision) (flutter/engine#42313) 
https://dart.googlesource.com/sdk.git/+log/be01f9fdac37..0e78305875a4

2023-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-146.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 12:05:27 +00:00
skia-flutter-autoroll
c9637c663b Roll Fuchsia Mac SDK from RSSC61ubl9JXmn4JO... to X4uS4T6_J-VUh9M4A... (flutter/engine#42311) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 08:58:10 +00:00
skia-flutter-autoroll
cdda3795e8 Roll Dart SDK from 96e29af6e0c6 to be01f9fdac37 (2 revisions) (flutter/engine#42310) 
https://dart.googlesource.com/sdk.git/+log/96e29af6e0c6..be01f9fdac37

2023-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-145.0.dev
2023-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-144.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 07:42:20 +00:00
skia-flutter-autoroll
456de7c6fb Roll Skia from 7ec172b433f1 to fbba25f66405 (2 revisions) (flutter/engine#42309) 
https://skia.googlesource.com/skia.git/+log/7ec172b433f1..fbba25f66405

2023-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c74dae154363 to c18972fdef08 (13 revisions)
2023-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 881cfa15a343 to 2b787917e4a3 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 07:11:23 +00:00
skia-flutter-autoroll
c6616feef5 Roll Fuchsia Linux SDK from UYN_Tk7M6_5d2aGIj... to nLnQzTesaABpgroOl... (flutter/engine#42307) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 03:59:31 +00:00
Brandon DeRosier
810607e52c [Impeller] Simplify CreateContentsForGeometry overloads (flutter/engine#42306) 
Came across this while working on generic fallbacks for mask blurs. For
the unique_ptr case, we always capture ownership and convert to a
shared_ptr anyhow. For the shared_ptr case, we always need to capture a
copy, and so better to not take a const ref and allow the caller to move
if possible.
 2023-05-24 20:54:45 -07:00
skia-flutter-autoroll
c9a0208693 Roll Skia from 150d534341a4 to 7ec172b433f1 (1 revision) (flutter/engine#42305) 
https://skia.googlesource.com/skia.git/+log/150d534341a4..7ec172b433f1

2023-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 881cfa15a343 to 2b787917e4a3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-25 03:43:22 +00:00
keyonghan
795a726b5f Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/engine#42299) 
Part of https://github.com/flutter/flutter/issues/127534
 2023-05-25 01:37:29 +00:00