skia-flutter-autoroll
e9faeddd45
Roll Skia from 9086788fc341 to 994558cd1fae (1 revision) ( flutter/engine#48322 )
...
https://skia.googlesource.com/skia.git/+log/9086788fc341..994558cd1fae
2023-11-22 johnstiles@google.com Disable [[clang::musttail]] on clang-cl.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 18:19:51 +00:00
LongCatIsLooong
59a5579465
Expose a few more glyph apis from ui.Paragraph ( flutter/engine#47698 )
...
Add 2 methods for querying glyph-related metrics
```dart
GlyphInfo? getClosestGlyphInfoForOffset(Offset offset);
GlyphInfo? getGlyphInfoAt(int codeUnitOffset);
```
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-22 18:04:13 +00:00
skia-flutter-autoroll
c39c4f24d8
Roll Skia from efdec1f459ce to 9086788fc341 (2 revisions) ( flutter/engine#48317 )
...
https://skia.googlesource.com/skia.git/+log/efdec1f459ce..9086788fc341
2023-11-22 jvanverth@google.com Use sk_ieee_float_divide in SkMatrix::setRectToRect.
2023-11-22 kjlubick@google.com Reland "Reland "Remove other uses of SkFontMgr::RefDefault""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 17:29:09 +00:00
skia-flutter-autoroll
925d1e8cb4
Manual roll Dart SDK from f1fd14505782 to df958dc1ca7b (6 revisions) ( flutter/engine#48316 )
...
Manual roll requested by jacksongardner@google.com
https://dart.googlesource.com/sdk.git/+log/f1fd14505782..df958dc1ca7b
2023-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-158.0.dev
2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-157.0.dev
2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-156.0.dev
2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-155.0.dev
2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-154.0.dev
2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-153.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 17:03:14 +00:00
skia-flutter-autoroll
f44004197c
Roll Skia from 2c68a803f497 to efdec1f459ce (2 revisions) ( flutter/engine#48315 )
...
https://skia.googlesource.com/skia.git/+log/2c68a803f497..efdec1f459ce
2023-11-22 jvanverth@google.com [graphite] Multiply by inverse texture size to normalize image localCoords
2023-11-22 nicolettep@google.com Revert "[graphite] Implement AHardwareBuffer BackendTexture creation for Vulkan"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 16:31:05 +00:00
skia-flutter-autoroll
679d6bec5d
Roll Skia from af2bd26a3a5e to 2c68a803f497 (1 revision) ( flutter/engine#48311 )
...
https://skia.googlesource.com/skia.git/+log/af2bd26a3a5e..2c68a803f497
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 302d72df3db0 to fe7ac4762e47 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 14:17:31 +00:00
skia-flutter-autoroll
6a87533f61
Roll Skia from cc9006085362 to af2bd26a3a5e (1 revision) ( flutter/engine#48307 )
...
https://skia.googlesource.com/skia.git/+log/cc9006085362..af2bd26a3a5e
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1169f6b4ae5c to 20eff9db7dc8 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 08:19:06 +00:00
skia-flutter-autoroll
1e1dc3258d
Roll Skia from 143b6b5b91a5 to cc9006085362 (1 revision) ( flutter/engine#48306 )
...
https://skia.googlesource.com/skia.git/+log/143b6b5b91a5..cc9006085362
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 7fa8c0ca8784 to 4141c194eb05
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 06:34:48 +00:00
skia-flutter-autoroll
3ef86f89a4
Roll Skia from cebd44423589 to 143b6b5b91a5 (1 revision) ( flutter/engine#48305 )
...
https://skia.googlesource.com/skia.git/+log/cebd44423589..143b6b5b91a5
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b61659d71d46 to bd6600c1bba7 (18 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 05:36:25 +00:00
skia-flutter-autoroll
e663563c6e
Roll Skia from 23b9316efd20 to cebd44423589 (1 revision) ( flutter/engine#48304 )
...
https://skia.googlesource.com/skia.git/+log/23b9316efd20..cebd44423589
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from c0be9bb8bc17 to 111d4246b357 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 03:42:23 +00:00
Jonah Williams
811d365669
[Impeller] make host buffer state internally ref counted. ( flutter/engine#48303 )
...
std::shared_from_this is actually incredibly slow, and dominates the cost of host buffer allocation at 20x more expensive than the memcpy. We can remove the usage of shared_from_this by making an internal class hold the actual allocation/buffer state instead.
### Before
146 ms / 647ms = ~20%
### After
33 ms / 540 ms = ~6%
2023-11-22 03:24:18 +00:00
skia-flutter-autoroll
5fc94087d5
Roll Skia from b6f33389cefa to 23b9316efd20 (2 revisions) ( flutter/engine#48302 )
...
https://skia.googlesource.com/skia.git/+log/b6f33389cefa..23b9316efd20
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from f23b91844a05 to ba1e7f5c1e82
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 856d90fb41aa to 302d72df3db0 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 01:52:11 +00:00
skia-flutter-autoroll
651c54111c
Roll Skia from cac28f3634a3 to b6f33389cefa (1 revision) ( flutter/engine#48299 )
...
https://skia.googlesource.com/skia.git/+log/cac28f3634a3..b6f33389cefa
2023-11-22 johnstiles@google.com Revert "Reland "Remove other uses of SkFontMgr::RefDefault""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 01:00:05 +00:00
Jonah Williams
330c06a4f2
[Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. ( flutter/engine#48298 )
...
Extremely minor micro optimization. Dont copy the paint too early.
Before
13/269 = ~5%
After:
3/262 = ~1%
2023-11-22 00:24:06 +00:00
Matan Lurey
d5b171165f
Finish making shell/platform/linux/... compatible with .clang-tidy. ( flutter/engine#48297 )
2023-11-21 15:35:36 -08:00
Matan Lurey
aa6fdad4cd
Finish making shell/platform/android/... compatible with .clang-tidy. ( flutter/engine#48296 )
2023-11-21 15:34:06 -08:00
Matan Lurey
b6f162e8b3
Finish making shell/common/... compatible with .clang-tidy. ( flutter/engine#48295 )
2023-11-21 15:33:43 -08:00
skia-flutter-autoroll
29e3f2edc7
Roll Fuchsia Linux SDK from Q3HcTitDF90ZOPWDa... to IK4xyRtZkDwqT6pXA... ( flutter/engine#48294 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 23:12:38 +00:00
skia-flutter-autoroll
f1f8c59fdf
Roll Skia from c6d971f87d12 to cac28f3634a3 (12 revisions) ( flutter/engine#48293 )
...
https://skia.googlesource.com/skia.git/+log/c6d971f87d12..cac28f3634a3
2023-11-21 jvanverth@google.com Revert "[graphite] Use colorspace matrix to handle RGB swizzle."
2023-11-21 jvanverth@google.com [graphite] Use colorspace matrix to handle RGB swizzle.
2023-11-21 nicolettep@google.com [graphite] Implement AHardwareBuffer BackendTexture creation for Vulkan
2023-11-21 nicolettep@google.com [graphite] Add public Recorder method to create a BackendTexture from an AHardwareBuffer
2023-11-21 johnstiles@google.com Revert "[graphite] Add no-yield option to ContextOptions."
2023-11-21 kjlubick@google.com Remove MutableTextureStateRef and sketch out Vulkan-specific functions
2023-11-21 kjlubick@google.com Reland "Remove other uses of SkFontMgr::RefDefault"
2023-11-21 kjlubick@google.com Assert if null fallbackMgr used in FontMgrRunIterator
2023-11-21 johnstiles@google.com Enable individual feature flags in skcms with clang-cl.
2023-11-21 jvanverth@google.com [graphite] Remove RRRR swizzle.
2023-11-21 briansalomon@gmail.com [graphite] Add no-yield option to ContextOptions.
2023-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 02a8c0638601 to c0be9bb8bc17 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 22:57:05 +00:00
gaaclarke
e80ecd9194
[Impeller] Switched to static linked libc++ in vulkan validation layers. ( flutter/engine#48290 )
...
fixes https://github.com/flutter/flutter/issues/138535
test coverage: existing integration tests in flutter repo which look for validation layers
I also verified locally that the `libc++.so` is no longer present and that it runs correctly.
```
$ find lib/arm64-v8a/
lib/arm64-v8a/
lib/arm64-v8a//libflutter.so
lib/arm64-v8a//libVkLayer_khronos_validation.so
```
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-21 22:06:05 +00:00
Matan Lurey
0b7f44c8c4
Yet more compliance with .clang_tidy, stragglers edition. ( flutter/engine#48291 )
...
Based off the
[failures](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8763786250936903249/+/u/test:_test:_lint_host_debug/stdout )
in https://github.com/flutter/engine/pull/48145 .
Nothing particularly interesting.
2023-11-21 13:39:18 -08:00
Jackson Gardner
4dacd0341d
Update skia build file to account for new skcms changes. ( flutter/engine#48286 )
...
This should address https://github.com/flutter/flutter/issues/138838 which is blocking the skia roll.
This basically ports over the build rule changes from https://skia-review.googlesource.com/c/skia/+/777538
2023-11-21 21:12:05 +00:00
Matan Lurey
edb665c82d
Make {shell|lib/ui}/... compatible with .clang_tidy. ( flutter/engine#48242 )
...
This is mostly just rename `ThreadHost::Type::{IDENTIFIER}` to
`kIdentifier`.
I also ignored some enum violations that are in public APIs.
2023-11-21 12:29:14 -08:00
Jonah Williams
753e9e6ac7
[Impeller] Ensure that overlay surfaces are constructed with wide gamut settings. ( flutter/engine#48190 )
...
Fixes https://github.com/flutter/flutter/issues/138373
When constructing overlay layers when there are platform views, make sure the same pixel format and color space as the main view is used.
Add validation to impeller HAL about blitting different pixel formats.
2023-11-21 20:29:05 +00:00
Matan Lurey
b1a29657a9
Make {flow|fml|impeller}/... compatible with .clang_tidy. ( flutter/engine#48241 )
...
Another few stragglers.
2023-11-21 18:53:06 +00:00
Jonah Williams
260ec88f60
[Impeller] preallocate command buffer to next power of two of entity list. ( flutter/engine#48185 )
...
Commands are massive 500 byte objects, re-allocating this vector while recording them can actually add a substantial amount of overhead to applications with lots of drawing commands. Sizing to npot so that underestimating by a few commands doesn't force us to immediately copy all command objects.
This is still a herustic driven approach. An alternative exact approach would have entities/contents describe how many commands they would add. This may be more important for stencil then cover (depending on how we do it) since some contents would need to create two commands.
2023-11-21 18:12:20 +00:00
gaaclarke
e18e1d286c
[Impeller] implements gaussian "blur halo" ( flutter/engine#48149 )
...
This makes the blurred item have a halo effect that is rendered outside of the bounds of the original thing that was rendered.
issue: https://github.com/flutter/flutter/issues/131580
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-21 16:47:24 +00:00
Zachary Anderson
e42d4109db
Revert Dart SDK to 3.3.0-152.0.dev ( flutter/engine#48272 )
...
Revert for https://github.com/flutter/flutter/issues/138813
2023-11-21 08:07:11 -08:00
David Iglesias
b6a14724a8
[web] Add add/removeView JS methods. ( flutter/engine#48106 )
...
This PR adds:
* JS-interop types to expose addView/removeView from the running FlutterApp object on JavaScript.
* Also, the options object that can be passed to `addView`.
### Issues:
* Fixes: https://github.com/flutter/flutter/issues/137377
### Info
Most interesting files:
* `app_bootstrap.dart` -> Adds the implementation for JS add/remove view.
* `js_app.dart` -> Adds the js-interop layer for the FlutterApp object, and the configuration type. (Two options: `hostElement` and `initialData`).
* `flutter_view_manager.dart` -> An abstraction over the `viewData` map that keeps related things together: viewData, js configuration options, register/unregister methods and a Stream<void> of modification events.
The rest of the changes were ""required"" to have a small demo that does anything (currently it lets me "register" views from javascript). I didn't add much in there, because probably it's already being worked on by @mdebbar; just fiddled with the constructor of the EngineFlutterView to create views from JS Config, and added a wrapper around the `viewData` map (`FlutterViewManager`) to prevent direct access to the Map.
## Usage
This is how I'm currently initializing my Flutter App, so I can "leak" the `flutterApp` to window and do things asynchronously after flutter loads:
```html
<script>
window.addEventListener('load', async function(ev) {
_flutter.loader.loadEntrypoint({
onEntrypointLoaded: function(engineInitializer) {
engineInitializer.initializeEngine({
multiViewEnabled: true,
}).then(function(appRunner) {
return appRunner.runApp();
}).then(onAppRunning);
}
});
// Leak flutterApp to window so we can do async things...
function onAppRunning(flutterApp) {
console.log('Running app', flutterApp);
window.flutterApp = flutterApp;
}
});
</script>
```
This to test:
* Go on your JS console and use `flutterApp.addView({})` and see how that returns a Promise for the viewId it just added,
* Now do `flutterApp.removeView(0)` (removes the implicitView), and see how everything starts crashing! (as expected)
* Get out of this weird state with a hot reload ð¥³
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-21 15:30:07 +00:00
skia-flutter-autoroll
1a7fb0fac9
Roll Skia from c244996e79d6 to c6d971f87d12 (1 revision) ( flutter/engine#48268 )
...
https://skia.googlesource.com/skia.git/+log/c244996e79d6..c6d971f87d12
2023-11-21 briansalomon@gmail.com Fix Graphite-Dawn wasm build
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 14:53:29 +00:00
skia-flutter-autoroll
418ffafcaa
Roll Skia from 516357c42907 to c244996e79d6 (1 revision) ( flutter/engine#48266 )
...
https://skia.googlesource.com/skia.git/+log/516357c42907..c244996e79d6
2023-11-21 kjlubick@google.com Revert "Remove other uses of SkFontMgr::RefDefault"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 14:00:18 +00:00
skia-flutter-autoroll
11e100c56f
Roll Dart SDK from 99d9cf9bd05a to 5e7b22caba8a (1 revision) ( flutter/engine#48264 )
...
https://dart.googlesource.com/sdk.git/+log/99d9cf9bd05a..5e7b22caba8a
2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-155.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 13:39:22 +00:00
skia-flutter-autoroll
97fda7e694
Roll Dart SDK from 64cbfa6c51e6 to 99d9cf9bd05a (1 revision) ( flutter/engine#48261 )
...
https://dart.googlesource.com/sdk.git/+log/64cbfa6c51e6..99d9cf9bd05a
2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-154.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 09:37:05 +00:00
skia-flutter-autoroll
7662e2fdbf
Roll Skia from 88a9e6328f93 to 516357c42907 (1 revision) ( flutter/engine#48260 )
...
https://skia.googlesource.com/skia.git/+log/88a9e6328f93..516357c42907
2023-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ac8158a19e0b to 856d90fb41aa (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 08:24:05 +00:00
skia-flutter-autoroll
f508c00d32
Roll Skia from a26e5a5771c8 to 88a9e6328f93 (1 revision) ( flutter/engine#48259 )
...
https://skia.googlesource.com/skia.git/+log/a26e5a5771c8..88a9e6328f93
2023-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 98d79260fa0e to 1169f6b4ae5c (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 07:36:26 +00:00
skia-flutter-autoroll
a0ad6a60c2
Roll Skia from f8daeeb7f092 to a26e5a5771c8 (2 revisions) ( flutter/engine#48258 )
...
https://skia.googlesource.com/skia.git/+log/f8daeeb7f092..a26e5a5771c8
2023-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from bc36c8dc442c to da550068f28d
2023-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ff937f71a801 to b61659d71d46 (20 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 06:16:09 +00:00
skia-flutter-autoroll
3d2401779a
Roll Dart SDK from f1fd14505782 to 64cbfa6c51e6 (1 revision) ( flutter/engine#48257 )
...
https://dart.googlesource.com/sdk.git/+log/f1fd14505782..64cbfa6c51e6
2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-153.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 05:46:23 +00:00
YaTang
950ec4aed6
[PlatformView][Android]VirtualDisplay resize on Android31 and above ( flutter/engine#47946 )
...
Resolves: https://github.com/flutter/flutter/issues/128920
2023-11-20 19:16:02 -08:00
Matan Lurey
f0ccf7a9a3
[Impeller] Try replacing *desc with value/is_valid checks. ( flutter/engine#48194 )
...
Some discussion here:
https://discord.com/channels/608014603317936148/1175215129135153202 .
In short, `*<std::optional>` is [undefined
behavior](https://en.cppreference.com/w/cpp/utility/optional/operator *).
After talking to @bdero we are considering that this should never
happen.
I thought of a few different approaches here, none of them are great.
However given that this class is used quite minimally, this seems to
jive with similar patterns we're using in scene/scene_context.
---
Feel free to push back or suggest alternatives, mostly proposing this to
get brain juices flowing.
2023-11-20 16:43:28 -08:00
skia-flutter-autoroll
1cfb9254d4
Roll Dart SDK from ee7aaca9adcc to f1fd14505782 (1 revision) ( flutter/engine#48250 )
...
https://dart.googlesource.com/sdk.git/+log/ee7aaca9adcc..f1fd14505782
2023-11-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-152.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 00:10:23 +00:00
skia-flutter-autoroll
c8d8eaf0f4
Roll Skia from 3876e576a38e to f8daeeb7f092 (1 revision) ( flutter/engine#48249 )
...
https://skia.googlesource.com/skia.git/+log/3876e576a38e..f8daeeb7f092
2023-11-20 briansalomon@gmail.com [graphite] Expose Dawn async buffer mapping through Buffer class
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 00:03:24 +00:00
skia-flutter-autoroll
4cd10d0a1b
Roll Skia from c9943f14039f to 3876e576a38e (3 revisions) ( flutter/engine#48246 )
...
https://skia.googlesource.com/skia.git/+log/c9943f14039f..3876e576a38e
2023-11-20 kjlubick@google.com Pass TestFontMgr in when deserializing skps in dm
2023-11-20 kjlubick@google.com Remove other uses of SkFontMgr::RefDefault
2023-11-20 johnstiles@google.com Replace -march= with -mfeature toggles.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-20 22:50:21 +00:00
Matan Lurey
f9adfbc62c
Make runtime/... and shell/common/... compatible with .clang-tidy. ( flutter/engine#48158 )
2023-11-20 14:31:49 -08:00
sunhongjie
13f3bd212b
Fix embedder glfw examples cmake subdirectory path error ( flutter/engine#48013 )
...
Fix just a cmake glfw subdirectory path error in embedder examples.
Fix: https://github.com/flutter/flutter/issues/138340
2023-11-20 22:18:37 +00:00
Matan Lurey
93104224e3
Silence a lint in common/settings.h in order to turn on clang_tidy. ( flutter/engine#48239 )
...
See https://github.com/flutter/flutter/issues/138750 .
2023-11-20 22:12:53 +00:00
skia-flutter-autoroll
d9dcf0228b
Roll Fuchsia Linux SDK from LnToEykA8o68jv58K... to Q3HcTitDF90ZOPWDa... ( flutter/engine#48244 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-20 22:12:50 +00:00
skia-flutter-autoroll
a6a706cdad
Roll Skia from 2bcc2e8682a6 to c9943f14039f (1 revision) ( flutter/engine#48243 )
...
https://skia.googlesource.com/skia.git/+log/2bcc2e8682a6..c9943f14039f
2023-11-20 brianosman@google.com Fix numerous cases of casting away const
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-20 21:46:29 +00:00
Matan Lurey
fcd9c27649
Make vulkan/... compatible with .clang_tidy. ( flutter/engine#48240 )
...
Missed this straggler in a previous PR. Ezpz.
2023-11-20 21:30:07 +00:00
Matan Lurey
7cc1f2f98c
[Impeller] Write a text-decoration test at the dart:ui layer ( flutter/engine#48101 )
...
Closes https://github.com/flutter/flutter/issues/138501 .
---
It would be nice to turn this into a test-fixture, and create a better local environment.
Here is how to run it locally:
```bash
# The test expects you to be PWD in the `src` directory or it crashes.
cd $ENGINE_SRC
out/host_debug_unopt_arm64/flutter_tester \
--force-multithreading \
--disable-observatory \
--use-test-fonts \
--icu-data-file-path=out/host_debug_unopt_arm64/icudtl.dat \
--flutter-assets-dir=out/host_debug_unopt_arm64/gen/flutter/lib/ui/assets \
--disable-asset-fonts \
--enable-impeller \
out/host_debug_unopt_arm64/gen/canvas_test.dart.dill
# "See" the output goldens.
open out/host_debug_unopt_arm64/gen/skia_gold_canvas_test.dart
```
2023-11-20 21:07:05 +00:00
skia-flutter-autoroll
fc50f4cca5
Roll Skia from 69213ba6f68a to 2bcc2e8682a6 (1 revision) ( flutter/engine#48238 )
...
https://skia.googlesource.com/skia.git/+log/69213ba6f68a..2bcc2e8682a6
2023-11-20 kjlubick@google.com Re-enable legacy SkFontMgr factory for Android
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-20 20:44:16 +00:00
