skia-flutter-autoroll
e95110fbd6
Roll Fuchsia Linux SDK from 1ODZdNPvGxBrgnCzf... to pd1VfyK_WEW6tu8WI... ( flutter/engine#42723 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-10 10:28:30 +00:00
gaaclarke
36730c35a9
[Impeller] Added helper messaging around validation usage ( flutter/engine#42708 )
...
Adds some helper messages around using validation layers.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-09 23:07:51 +00:00
keyonghan
a24de2eaef
Fix an archive name in windows_host_engine config ( flutter/engine#42709 )
...
Use the correct archive name.
2023-06-09 22:37:59 +00:00
Dan Field
d33b2d4288
Delete WeakPtrFactory from GPUSurfaceVulkanImpeller ( flutter/engine#42710 )
...
Should fix https://github.com/flutter/flutter/issues/128618 .
This is unused - if it were used we'd have to be careful about deleting the object on the same thread it's created on.
2023-06-09 22:27:46 +00:00
gaaclarke
bf5c52d8af
[Impeller] Reland: Added a switch to turn on vulkan ( flutter/engine#42669 )
...
relands https://github.com/flutter/engine/pull/42585
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-06-09 11:35:29 -07:00
Brandon DeRosier
9d1159855f
[Impeller] Add CPU implementations for all color filters ( flutter/engine#42692 )
...
Part of https://github.com/flutter/flutter/issues/127232 .
Adds a CPU implementation for ColorMatrix and the color space
conversions. Also changes the blend signature for consistency.
These will be necessary to make the mask blur fast path continue working
in the presence of color filters. In general, we can use these to
eliminate a needlessly expensive image-based color filter for the
non-image color sources.
2023-06-09 11:13:05 -07:00
Jonah Williams
71009220e0
[Impeller] add explicit VMA flush to device memory writes. ( flutter/engine#42685 )
...
According to my read of the documentation for VMA/Vulkan allocation docs, setting VK_MEMORY_PROPERTY_HOST_COHERENT_BIT means we shouldn't need to flush the memory. nevertheless, this fixes the corruption of host buffers observed in https://github.com/flutter/flutter/issues/124040
Fixes https://github.com/flutter/flutter/issues/124040
> VK_MEMORY_PROPERTY_HOST_COHERENT_BIT bit specifies that the host cache management commands [vkFlushMappedMemoryRanges](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkFlushMappedMemoryRanges.html ) and [vkInvalidateMappedMemoryRanges](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkInvalidateMappedMemoryRanges.html ) are not needed to flush host writes to the device or make device writes visible to the host, respectively.
ð¤·ââï¸
2023-06-09 17:23:09 +00:00
gaaclarke
2097506136
[Impeller] Makes validation layers flag work for android ( flutter/engine#42625 )
...
This builds and links in the validation layers for android. They then
can be turned on or off with a manifest field.
fixes https://github.com/flutter/flutter/issues/123788
depends on https://github.com/flutter/buildroot/pull/741
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-06-09 10:22:21 -07:00
Justin McCandless
986c173094
Platform channel for predictive back ( flutter/engine#39208 )
...
Adds a platform channel method for enabling/disabling Android's predictive back feature.
2023-06-09 10:06:33 -07:00
Jonah Williams
fb0c47c6ec
[Impeller] disable buffer to texture blit for Vulkan. ( flutter/engine#42686 )
...
This fixes some f'd up ness in the images. Will need to debug this separately on Android. For now, we can just turn it off in the caps.
2023-06-09 15:53:56 +00:00
Bruno Leroux
0445311a23
[Linux] Return keyboard pressed state ( flutter/engine#42346 )
...
## Description
This PR updates the Linux engine in order to answer to keyboard pressed state queries from the framework (as implemented in https://github.com/flutter/flutter/pull/122885 ).
## Related Issue
Linux engine implementation for https://github.com/flutter/flutter/issues/87391
## Tests
Adds 2 tests.
2023-06-09 11:28:15 +00:00
skia-flutter-autoroll
17cf5bf08b
Roll Fuchsia Linux SDK from lPCv1NshK-tvjtLgC... to xqQPG9jnWgD1Dj3FL... ( flutter/engine#42694 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-09 08:01:09 +00:00
Mitchell Kember
b1fa42d81e
[fuchsia] Bump the target API level to 12, and pass it to fidlc ( flutter/engine#42667 )
...
This makes the GN build pass the target Fuchsia API level to fidlc.
Currently it relies on the default of HEAD, meaning all FIDL changes are
immediately visible when the SDK rolls. This was never the intention:
flutter should be targeting a specific API level.
This unblocks https://fxrev.dev/864297 which makes the fidlc --available
flag required, and which uncovered this problem.
I also copied the changes to gen_response_file.py from
https://fxrev.dev/865020 to make it forward --available to fidlc.
2023-06-09 11:56:49 +10:00
Brandon DeRosier
320a689d5e
[Impeller] Add tests for foreground blends with mask blurs ( flutter/engine#42687 )
...
Part of https://github.com/flutter/flutter/issues/127232 .
Both of these tests should be rendering as a clipped and blurred green circle. Making mask blurs interact correctly with color filters is not going to be trivial... These bugs extend beyond the filter graph itself. Want to get some goldens in to compare against.
ForegroundPorterDuffBlend:
ForegroundAdvancedBlend:
2023-06-09 01:15:07 +00:00
godofredoc
dcb764b1d3
Document the use of realm in archives. ( flutter/engine#42682 )
...
Add docs for realm propery in the archives of build configuration files.
Bug: https://github.com/flutter/flutter/issues/126121
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-09 00:43:12 +00:00
godofredoc
0f80fdedc2
Prevent double upload of benchmarks. ( flutter/engine#42683 )
...
The benchmarks have been migrated to v2 but the legacy build is uploading benchmarks even when running on staging.
Bug: https://github.com/flutter/flutter/issues/127678
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-08 23:38:03 +00:00
godofredoc
834380cdfa
Remove all the uses of master branch in the .ci.yaml file. ( flutter/engine#42679 )
...
Master branch is not the default branch in the engine anymore and we should not run any builds on it.
Bug: https://github.com/flutter/flutter/issues/90476
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-08 22:31:52 +00:00
godofredoc
b58192e6b1
Replace benchmarks with its v2 version. ( flutter/engine#42677 )
...
Benchmarks has been migrated to engine v2 and it is ready to replace the legacy version.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-08 22:18:11 +00:00
Brandon DeRosier
3dd6e55e45
[Impeller] Reorder blend filter checks to avoid unnecessary destination snapshot ( flutter/engine#42678 )
...
Side quest of https://github.com/flutter/flutter/issues/127232 .
Tiny reordering to avoid unnecessary input resolution. :) Happened to notice we were hitting this case while going through some frame captures of reported fidelity issues.
Before:
After:
2023-06-08 22:00:56 +00:00
Brandon DeRosier
81a4a5e34b
[Impeller] Specify blend mode on blend filter commands ( flutter/engine#42676 )
...
Side quest of https://github.com/flutter/flutter/issues/127232 .
This is particularly useful for debugging pipeline blend variations of the blend filter, since we otherwise have to look at the raw pipeline blend ops and figure out and piece together what the blend mode must've been.
2023-06-08 21:58:59 +00:00
Renzo Olivares
8b7818b946
[Linux] composing delta fixes ( flutter/engine#42648 )
...
Fixes a few issues with the Linux text editing delta implementation that was causing some issues when composing CJK text.
`im_preedit_changed_cb` dispatches a delta with the delta range set as the current composing region causing a crash when composing because the new composing region range might not yet exist in the `oldText` that the delta is applied to. We should instead send the composing region before the change to the text as that will be the correct range that is being modified in the `oldText`.
`im_preedit_end_cb` dispatches a delta with an empty `oldText`, a not empty `deltaText`, and a delta range of `(-1,-1)` causing a crash when composing ends because the delta range will never be within the range of the text. We should instead send the current text value as the `oldText` and not send a `deltaRange` or `deltaText` since a `(-1,-1)` range essentially means nothing in the text changed.
`im_commit_cb` does not account for the case when we were previously composing when the text was committed. This causes the dispatched delta to have a delta range that always inserts at the current the selection, when it should instead replace the previous composing range. We should account for the case when we are previously composing before committing the text, and dispatch a delta with the previous composing region.
Fixes https://github.com/flutter/flutter/issues/113909
2023-06-08 21:14:01 +00:00
toneyzeng
c659b9a590
Fix: invalid time-point comparison between each from different clock source ( flutter/engine#42409 )
...
Sometimes the time point created late will less than the time point create earlier since the CLOCK SOURCE has changed.
We must make sure the CLOCK SOURCE (fml::TimePoint) is always keep the same while we are testing.
Corrects the test case is needed before we fix the problem completely.
2023-06-08 21:12:12 +00:00
Jonah Williams
e448fff0da
[Impeller] sort all vertex inputs by location. ( flutter/engine#42664 )
...
Fixes https://github.com/flutter/flutter/issues/128283
Why doesn't this happen elsewhere? might depend on how spirv compiles shaders or the order they run in. Long term fix is https://github.com/flutter/engine/pull/42628 which computes all offset data in the compiler
2023-06-08 17:23:52 +00:00
Zachary Anderson
8e7fbbb8a7
Revert "[Impeller] Added a switch to turn on vulkan" ( flutter/engine#42660 )
...
Reverts flutter/engine#42585
Reverting to investigate
https://github.com/flutter/flutter/issues/128484
2023-06-08 09:04:17 -07:00
godofredoc
3539afcbb8
Benchmarks configurations for engine v2. ( flutter/engine#42622 )
...
This configuration migrates benchmarks to engine_v2.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-08 03:47:34 +00:00
skia-flutter-autoroll
aad7a69125
Roll Skia from 1a3adf848e61 to 8fdbbca7d35d (1 revision) ( flutter/engine#42645 )
...
https://skia.googlesource.com/skia.git/+log/1a3adf848e61..8fdbbca7d35d
2023-06-07 kjlubick@google.com Decouple SkShaders from Ganesh backend
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com ,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-08 00:46:39 +00:00
Alexander Aprelev
f3c26172de
Roll dart to 3.1.0-180.0.dev ( flutter/engine#42638 )
...
Roll dart to 3.1.0-180.0.dev
Changes since last roll
```
bbce07ad394 (tag: 3.1.0-180.0.dev) Version 3.1.0-180.0.dev
81fc5e710d8 (tag: 3.1.0-179.0.dev) Version 3.1.0-179.0.dev
3b850bb1ace [js-rti] Support legacy types in `is FutureOr` specializer.
dcac7808518 Update PULL_REQUEST_TEMPLATE.md
5b3a57908d5 [dart:js_interop] Remove ObjectLiteral
30b9ac9f873 [dds/dap] Don't show skipped tests as passes in debug
adapter output
79b71c789f6 Use ParameterReference for ChangeParameterType.
bc94e7662be [analyzer] Refactor visitConditionExpression in the const
evaluator.
cf5168ea339 (tag: 3.1.0-178.0.dev) Version 3.1.0-178.0.dev
7071c65b8c7 Change TransformSetParser.singleKey() to avoid null asserts.
a3399e3616f [analysis_server] Add support for adding imports with
show/hide + update Move to File
463c7cb5a2f [vm] Support unchecked AsExpressions in the VM
3a598b4c031 [vm, gc] Honor kAllocatablePageSize during promotion and
snapshot reading.
b84077426ab (tag: 3.1.0-177.0.dev) Version 3.1.0-177.0.dev
9421ca07994 Delete old debianpackage-linux builder.
d4c2d659075 Remove unnecessary null check on `initializerType`.
26fd946904e Run CFE presubmit lints with scanner configured for null
safety mode.
cbd1b8d4943 (tag: 3.1.0-176.0.dev) Version 3.1.0-176.0.dev
033fa5e684d [build] Remove unused pipes import from vs_toolchain.py
b5ee6fa8885 [vm/ffi] Support native assets in `dart build` with relative
path
5e8c29e7b68 (tag: 3.1.0-175.0.dev) Version 3.1.0-175.0.dev
7335116e08a (tag: 3.1.0-174.0.dev) Version 3.1.0-174.0.dev
07f587504b1 Reland "[vm] Migrate FFI callbacks to the new metadata
system."
369a8312aa4 [ddc] Fix types of constants in legacy libraries
105f7e17222 (tag: 3.1.0-173.0.dev) Version 3.1.0-173.0.dev
526ce3aba48 Issue 52005. Convert non-exhaustive returning
SwitchStatement to SwitchExpression when followed by throw.
cc18b250ae8 Bump github/codeql-action from 2.3.5 to 2.3.6
5ff0821b274 [kernel,vm] First-class kernel serialization of FutureOrType
and NullType
8d298292719 Use 'coveringNode' name in RefactoringContext, as it is in
Selection.
97ec9e95bf8 Convert imported reference completion tests
f92c6da7bf4 [analyzer] Refactor visitAsExpression and visitIsExpression
in the constant evaluator.
9e196bc7118 Roll gn from 5a004f9427a0 to e3978de3e8da
7c63a493a22 (tag: 3.1.0-172.0.dev) Version 3.1.0-172.0.dev
88f05965ac4 Issue 52606. Fix AstNodeExtension.nodeCovering() when
selection if at the end of Comment.
09df4e5200b [ddc] Fix dynamic calls of generic methods with new types
1e1266f8e6c [ddc] Sync dart_library.js from internal
56cb8de9736 Make ParsedUnitResult and ParsedLibraryResult superclasses
of ResolvedUnitResult and ResolvedLibraryResult respectively.
03b2abf78f2 [deps] rev async, dartdoc, ffi, http, leak_tracker, lints,
mockito, test, tools, webdev
29f121126ba [analysis_server] Allow skipping slow benchmarks with env
variable
```
2023-06-07 16:28:03 -07:00
skia-flutter-autoroll
e2ea5e6410
Roll Skia from 156542f8bf13 to 1a3adf848e61 (1 revision) ( flutter/engine#42644 )
...
https://skia.googlesource.com/skia.git/+log/156542f8bf13..1a3adf848e61
2023-06-07 michaelludwig@google.com [skif] Improve magnifier zoom window with missing content
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com ,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 23:19:50 +00:00
skia-flutter-autoroll
93b0156c27
Roll Skia from c5a8c4547f59 to 156542f8bf13 (4 revisions) ( flutter/engine#42641 )
...
https://skia.googlesource.com/skia.git/+log/c5a8c4547f59..156542f8bf13
2023-06-07 robertphillips@google.com Disable rotated nearest-neighbor testing in the big image test
2023-06-07 johnstiles@google.com Emit simpler WGSL for-loops when the loop-count is known.
2023-06-07 johnstiles@google.com Add WGSL support for the discard statement.
2023-06-07 johnstiles@google.com Allow assignment to function parameters in WGSL.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com ,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 22:10:20 +00:00
Jason Simmons
08f35fa586
Roll HarfBuzz to 7.3.0 ( flutter/engine#42629 )
2023-06-07 21:51:10 +00:00
ColdPaleLight
437cbb1154
[Impeller] Corrected the 'texture_coords' computation in 'Geometry::GetPositionUVBuffer' ( flutter/engine#42619 )
...
fix https://github.com/flutter/flutter/issues/128328
We need to transform the 'position' first and then divide 'texture_coverage', otherwise the result will be incorrect.
without patch
with patch
2023-06-07 21:44:54 +00:00
skia-flutter-autoroll
6e6dfee6de
Roll Skia from 773765ca1dd2 to c5a8c4547f59 (4 revisions) ( flutter/engine#42633 )
...
https://skia.googlesource.com/skia.git/+log/773765ca1dd2..c5a8c4547f59
2023-06-07 robertphillips@google.com Expand big image unit test
2023-06-07 jvanverth@google.com [graphite] Clean up BackendTexture.
2023-06-07 michaelludwig@google.com [skif] Update SkLocalMatrixImageFilter to FilterResult system
2023-06-07 robertphillips@google.com Add unit test for large images (take 2)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com ,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 20:59:35 +00:00
godofredoc
ed776ac512
Add global test docs. ( flutter/engine#42531 )
...
Adds documentation for the use cases supported by global tests along with their respective configurations.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-07 20:52:51 +00:00
Casey Hillers
7507e8dc16
[labeler] Fix to run on flutter/engine ( flutter/engine#42634 )
...
Fixes https://github.com/flutter/flutter/issues/128448#issuecomment-1581353250
2023-06-07 20:11:49 +00:00
Bruno Leroux
a3843d747d
[iOS] Fix TextInputAction.continueAction sends wrong action to framework ( flutter/engine#42615 )
...
## Description
This PR fixes an issue related to text input plugin, on IOS, sending a wrong action string to the engine for `FlutterTextInputActionContinue`.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/126922
## Tests
Adds 1 test.
2023-06-07 20:11:47 +00:00
Jonah Williams
02591dca4d
[Impeller] fix missing assignment of embedder render target. ( flutter/engine#42630 )
...
Otherwise we can't render ð
2023-06-07 19:57:57 +00:00
Jonah Williams
50626db959
[Impeller] Add buffer to texture blit for Vulkan. ( flutter/engine#41706 )
...
Work towards https://github.com/flutter/flutter/issues/123468
In order to support the usage of BufferView, I generalized the tracked buffer type from DeviceBuffer to Buffer. Should be mostly safe!
I confirmed that this runs correctly under moltenvk but I'm uncertain if there are additional ways to validate.
2023-06-07 19:32:48 +00:00
Chris Bracken
e7a44a64a7
[macOS] Add platformview creation parameter support ( flutter/engine#42607 )
...
Previously, when creating native platform views on macOS, we ignored any parameters passed via the framework side "params" argument in the "create" method call, and instead always passed a nil value to the FlutterPlatformViewFactory. This made it impossible for users of macOS platform views to pass constructor arguments to the NSView subclass implementing the platform view.
We now decode the arguments data using the codec specified by the `FlutterPlatformViewFactory` and pass them through to the `[FlutterPlatformViewFactory createWithIdentifier:arguments:]` method where the platform view author can make use of them.
Fixes: https://github.com/flutter/flutter/issues/124723
This is a part of the broader macOS platform view support effort: https://github.com/flutter/flutter/issues/41722
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-07 19:16:56 +00:00
gaaclarke
01f6db8882
[Impeller] Added a switch to turn on vulkan ( flutter/engine#42585 )
...
fixes https://github.com/flutter/flutter/issues/128286
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-07 19:08:04 +00:00
Jackson Gardner
6fdcec7af7
Bump Chrome version to 114 for testing ( flutter/engine#42623 )
2023-06-07 17:55:20 +00:00
skia-flutter-autoroll
aaad533dda
Roll Skia from d607cbb0db78 to 773765ca1dd2 (7 revisions) ( flutter/engine#42624 )
...
https://skia.googlesource.com/skia.git/+log/d607cbb0db78..773765ca1dd2
2023-06-07 drott@chromium.org [Fontations] Support makeClone() for variations
2023-06-07 johnstiles@google.com Demonstrate function-parameter assignment issue in unit test.
2023-06-07 johnstiles@google.com Add unit tests to WGSL that rely on dead-return synthesis.
2023-06-07 johnstiles@google.com Add trailing `return` to functions that lack an unconditional return.
2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c520912239f0 to 5c35de42bbc6 (2 revisions)
2023-06-07 johnstiles@google.com Fix test disable for OutParamsDoubleSwizzle.
2023-06-07 kjlubick@google.com Remove some spaces from the gainmap sksl
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com ,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 17:43:26 +00:00
J-P Nurmi
42b7de838e
[Linux][a11y] implement AtkText::get_text/string_at_offset() ( flutter/engine#38144 )
...
This PR implements `AtkText::get_string_at_offset()` (and the deprecated `AtkText::get_text_at_offset()` still used by e.g. Orca) for `FlAccessibleTextField` to allow Orca to read out loud the current character while moving the text cursor around.
### Before (unmute to hear the screen reader)
[textfield-a11y-before.webm](https://user-images.githubusercontent.com/140617/206556644-fb4f4df8-acca-4d97-86d5-7120f0a4871d.webm )
### After (unmute to hear the screen reader)
[textfield-a11y-after.webm](https://user-images.githubusercontent.com/140617/206556678-4fbf9112-291e-4518-a258-e9ca33469430.webm )
Fixes : flutter/flutter#113049
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-07 17:18:04 +00:00
skia-flutter-autoroll
c69ef0e6e7
Roll Skia from ee90e9ae2e62 to d607cbb0db78 (1 revision) ( flutter/engine#42618 )
...
https://skia.googlesource.com/skia.git/+log/ee90e9ae2e62..d607cbb0db78
2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b8f3bbf465f8 to b54c2bdc9713 (10 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com ,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 14:53:23 +00:00
Tong Mu
fdadd4c99e
Revert "[Android] Return keyboard pressed state" ( flutter/engine#42616 )
...
Reverts flutter/engine#41695 due to internal bug report b/284945818.
cc @bleroux let's investigate some day.
2023-06-07 01:38:45 -07:00
skia-flutter-autoroll
a7ba47faac
Roll Fuchsia Linux SDK from lpbkSRJBMkPs0FM7_... to sEHtHM1iFt79roP-x... ( flutter/engine#42613 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 07:20:25 +00:00
Brandon DeRosier
72a1fea6e2
[Impeller] Reland 2: Add Impeller Metal support in the embedder API ( #42411 ) ( flutter/engine#42597 )
...
This reverts commit
8d6f091751
2023-06-06 23:02:02 -07:00
skia-flutter-autoroll
0974bef6df
Roll Skia from 521b8c4bb011 to a01f49f539ab (4 revisions) ( flutter/engine#42608 )
...
https://skia.googlesource.com/skia.git/+log/521b8c4bb011..a01f49f539ab
2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 521ddd00b973 to c520912239f0 (4 revisions)
2023-06-06 johnstiles@google.com Allow WGSL code with warnings to compile successfully.
2023-06-06 johnstiles@google.com Change WGSL indentation level to 2 spaces.
2023-06-06 johnstiles@google.com Add WGSL support for do-while loops.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com ,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 05:05:05 +00:00
skia-flutter-autoroll
306354e4a2
Roll Skia from cef18d10b363 to 521b8c4bb011 (1 revision) ( flutter/engine#42605 )
...
https://skia.googlesource.com/skia.git/+log/cef18d10b363..521b8c4bb011
2023-06-06 robertphillips@google.com Revert "Add unit test for large images"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com ,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-07 03:08:49 +00:00
Jason Simmons
92064621b7
Convert pixel formats for animated PNG frames using the source blend mode ( flutter/engine#42581 )
...
The destination buffer format may not exactly match the source format. In particular, the alpha type of the source may need to be converted to the alpha type of the destination.
Fixes https://github.com/flutter/flutter/issues/128102
2023-06-07 00:02:03 +00:00
skia-flutter-autoroll
a30e718193
Roll Skia from 4065e92bf577 to cef18d10b363 (18 revisions) ( flutter/engine#42600 )
...
https://skia.googlesource.com/skia.git/+log/4065e92bf577..cef18d10b363
2023-06-06 robertphillips@google.com Add unit test for large images
2023-06-06 johnstiles@google.com Rename OutParamsTricky to OutParamsDoubleSwizzle.
2023-06-06 herb@google.com Do not return infinities as roots
2023-06-06 cmumford@google.com Revert "[infra] temporarily remove RadeonHD8870M-x86_64-Debug-All-Graphite_Metal from CQ"
2023-06-06 johnstiles@google.com Remove out-param helper functions from WGSL.
2023-06-06 rmistry@google.com Revert "Whitespace change to test GitWatcher"
2023-06-06 cmumford@google.com Revert "[infra] temp remove Release-All-Graphite_Metal from CQ"
2023-06-06 johnstiles@google.com Fix ternary paren-handling code.
2023-06-06 michaelludwig@google.com Revert "Rename ColorTable in public.bzl"
2023-06-06 kjlubick@google.com Remove old GrRectanizer file
2023-06-06 kjlubick@google.com Rename ColorTable in public.bzl
2023-06-06 johnstiles@google.com Remove special case for inverse-hyperbolic intrinsic tests.
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3c250b5ab450 to 521ddd00b973 (1 revision)
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b8f3bbf465f8 to 0daeddfa6f24
2023-06-06 drott@chromium.org [Fontations] Variations support for fontations backend
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4ff41604e769 to 721c15efaa70 (3 revisions)
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ac4876bcdcc3 to b8f3bbf465f8 (9 revisions)
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f44e26b8163c to 3e5c6411ba05 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com ,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-06 22:02:19 +00:00
