Zachary Anderson
e94a2c04c1
Shift mac Pixel 7 Pro tests to prod ( #141142 )
...
Related https://github.com/flutter/flutter/issues/140893
2024-01-08 18:33:47 -08:00
engine-flutter-autoroll
7a5cc2a01e
Roll Flutter Engine from 3f0f8913169e to d13479968b8f (2 revisions) ( #141147 )
...
3f0f891316...d13479968bskia-flutter-autoroll@skia.org Roll Skia from cb8e8fa79132 to f4626a2e3293 (3 revisions) (flutter/engine#49610 )
2024-01-09 bdero@google.com [Impeller] Document mip bias. (flutter/engine#49602 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-09 02:18:25 +00:00
engine-flutter-autoroll
cc0c88f230
Roll Flutter Engine from 09a74a08c819 to 3f0f8913169e (2 revisions) ( #141146 )
...
09a74a08c8...3f0f891316skia-flutter-autoroll@skia.org Roll Skia from 5497d5a53ae2 to cb8e8fa79132 (5 revisions) (flutter/engine#49608 )
2024-01-08 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 7f2523c2fa9a to e8aa66f435ae (5 revisions) (flutter/engine#49604 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-09 01:13:39 +00:00
engine-flutter-autoroll
8e7dfac998
Roll Flutter Engine from ee1ded6d1c44 to 09a74a08c819 (3 revisions) ( #141144 )
...
ee1ded6d1c...09a74a08c8jason-simmons@users.noreply.github.com When building clang-tidy commands, filter out the sed command that may be appended to each compile command (flutter/engine#49605 )
2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from af845097acae to 5497d5a53ae2 (6 revisions) (flutter/engine#49606 )
2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from a0aba842460c to af845097acae (3 revisions) (flutter/engine#49601 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-09 00:28:53 +00:00
asci
3b7ed0006c
[docs] Add document content related to chip shape ( #140015 )
...
(#139572 ) I would like to request an update to the document to resolve confusion.
I actually modified the code by applying priority as in the comment in [#139572 ](https://github.com/flutter/flutter/issues/139572 ) as shown below, but I thought that if 'OutlinedBorder' was used for 'shape', the default value of side for 'OutlinedBorder' was also the developer's intention.
```
OutlinedBorder _getShape(ThemeData theme, ChipThemeData chipTheme, ChipThemeData chipDefaults) {
final BorderSide? resolvedSide =
MaterialStateProperty.resolveAs<BorderSide?>(widget.side, materialStates)
?? MaterialStateProperty.resolveAs<BorderSide?>(chipTheme.side, materialStates);
final BorderSide? resolvedShapeSide =
MaterialStateProperty.resolveAs<BorderSide?>(widget.shape?.side, materialStates)
?? MaterialStateProperty.resolveAs<BorderSide?>(chipTheme.shape?.side, materialStates);
final OutlinedBorder resolvedShape =
MaterialStateProperty.resolveAs<OutlinedBorder?>(widget.shape, materialStates)
?? MaterialStateProperty.resolveAs<OutlinedBorder?>( chipTheme.shape, materialStates)
?? MaterialStateProperty.resolveAs<OutlinedBorder?>(chipDefaults.shape, materialStates)
// TODO(tahatesser): Remove this fallback when Material 2 is deprecated.
?? const StadiumBorder();
// If the side is provided, shape uses the provided side.
if (resolvedSide != null) {
return resolvedShape.copyWith(side: resolvedSide);
}
if (resolvedShapeSide != null) {
return resolvedShape.copyWith(side: resolvedShapeSide);
}
// If the side is not provided
// then the shape's side is used. Otherwise, the default side is used.
return resolvedShape.copyWith(side: chipDefaults.side);
}
```
(in `chip.dart`)
However, (#133856 ) PR seems to be intended to ignore this and use the aspect of `chipDefault.side` even if the developer specifies `shape.side` as [Border.none] without explicitly applying `side` .
This is probably because the default value of OutlinedBorder is [Border.none].
I think this is an area that can cause enough confusion, but there are a lot of things that need to be modified to reduce confusion through code changes, and the impact on existing code is likely to be significant.
I also confirmed that this is not accurately explained in the API Docs.
So rather than modifying the code, I decided to add additional explanation to the `shape` comment.
If the results are different from what you intended or the updated content is strange, please review. ð
2024-01-08 23:06:10 +00:00
engine-flutter-autoroll
1e8714277a
Roll Flutter Engine from 00ff33274fc0 to ee1ded6d1c44 (2 revisions) ( #141133 )
...
00ff33274f...ee1ded6d1cjason-simmons@users.noreply.github.com Fix memory leaks in some embedder unit tests that send key events (flutter/engine#49548 )
2024-01-08 jason-simmons@users.noreply.github.com [Impeller] Start and end a frame in the RenderTargetCache for each rendering of an entity in the playgrounds (flutter/engine#49576 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-08 23:02:22 +00:00
engine-flutter-autoroll
a7aca4b995
Roll Flutter Engine from 70c45157c60a to 00ff33274fc0 (2 revisions) ( #141128 )
...
70c45157c6...00ff33274fbdero@google.com [Flutter GPU] Shader bundle improvements: Uniform structs & member offset reflection, GLES metadata, separate from runtime stage. (flutter/engine#49485 )
2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from 88b7612add02 to a0aba842460c (4 revisions) (flutter/engine#49600 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-08 21:04:57 +00:00
engine-flutter-autoroll
501071bcc4
Roll Flutter Engine from b57c899aefd7 to 70c45157c60a (1 revision) ( #141125 )
...
b57c899aef...70c45157c630870216+gaaclarke@users.noreply.github.com [Impeller] new blur: chop off blur extremities (flutter/engine#49574 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-08 20:06:23 +00:00
engine-flutter-autoroll
f6f4ba4f73
Roll Flutter Engine from db564ffb3549 to b57c899aefd7 (1 revision) ( #141114 )
...
db564ffb35...b57c899aefskia-flutter-autoroll@skia.org Roll Skia from 4b7cab157b50 to 88b7612add02 (2 revisions) (flutter/engine#49595 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-08 18:33:26 +00:00
engine-flutter-autoroll
18b362cf6b
Roll Packages from b9b6d38e012b to 5aef49b1c1d8 (2 revisions) ( #141117 )
...
b9b6d38e01...5aef49b1c1ditman@gmail.com [ci] Revert #5793 + Manual flutter roll to c6ddb73f971edd8210893db9f26ae665906cd6be (flutter/packages#5812 )
2024-01-05 goderbauer@google.com Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 (flutter/packages#5793 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-08 18:28:04 +00:00
engine-flutter-autoroll
b3b5d89ce5
Roll Flutter Engine from bbebee146508 to db564ffb3549 (5 revisions) ( #141112 )
...
bbebee1465...db564ffb35skia-flutter-autoroll@skia.org Roll Skia from 272281e56cdc to 4b7cab157b50 (1 revision) (flutter/engine#49594 )
2024-01-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from I-3hiLjX2DDy6mu22... to 6z4cZ6HUidtgmhvdk... (flutter/engine#49592 )
2024-01-08 matej.knopp@gmail.com Enforce consistent stack size for Flutter threads (flutter/engine#49111 )
2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from 384e08e5fbbe to 272281e56cdc (1 revision) (flutter/engine#49588 )
2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from e2621f417ff5 to 384e08e5fbbe (1 revision) (flutter/engine#49587 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from I-3hiLjX2DDy to 6z4cZ6HUidtg
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-08 16:47:30 +00:00
Zachary Anderson
7859fe3b24
Disable test shuffling in widget_tester_leaks_test.dart ( #141110 )
...
Fails with `flutter test --test-randomize-ordering-seed=20240108`
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20framework_tests_misc/15044/overview
cc @polina-c
2024-01-08 15:54:05 +00:00
engine-flutter-autoroll
12720f0e51
Roll Flutter Engine from 702ae19c0026 to bbebee146508 (1 revision) ( #141088 )
...
702ae19c00...bbebee1465skia-flutter-autoroll@skia.org Roll Skia from 7314a34ea888 to e2621f417ff5 (1 revision) (flutter/engine#49586 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-08 06:53:21 +00:00
engine-flutter-autoroll
65fae87f2f
Roll Flutter Engine from 5e1d18bb51d1 to 702ae19c0026 (1 revision) ( #141084 )
...
5e1d18bb51...702ae19c00skia-flutter-autoroll@skia.org Roll Skia from 8e517817b30b to 7314a34ea888 (1 revision) (flutter/engine#49585 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-08 05:12:26 +00:00
engine-flutter-autoroll
7c6ba1f7ee
Roll Flutter Engine from 845ffd16d228 to 5e1d18bb51d1 (1 revision) ( #141076 )
...
845ffd16d2...5e1d18bb51skia-flutter-autoroll@skia.org Roll Skia from e2bc77be480c to 8e517817b30b (1 revision) (flutter/engine#49584 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-07 16:46:25 +00:00
engine-flutter-autoroll
af50f5c063
Roll Flutter Engine from ffc84af47827 to 845ffd16d228 (1 revision) ( #141075 )
...
ffc84af478...845ffd16d2skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from KC2scOJmW9oBJh4ts... to I-3hiLjX2DDy6mu22... (flutter/engine#49583 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from KC2scOJmW9oB to I-3hiLjX2DDy
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-07 15:14:16 +00:00
engine-flutter-autoroll
29a3746073
Roll Flutter Engine from cc9362752996 to ffc84af47827 (2 revisions) ( #141074 )
...
cc93627529...ffc84af478skia-flutter-autoroll@skia.org Roll Skia from 98240694c57d to e2bc77be480c (1 revision) (flutter/engine#49582 )
2024-01-07 skia-flutter-autoroll@skia.org Roll Skia from 388ef1be2bb8 to 98240694c57d (1 revision) (flutter/engine#49581 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-07 04:09:42 +00:00
engine-flutter-autoroll
5246bcbb4c
Roll Flutter Engine from a5173fe3a912 to cc9362752996 (1 revision) ( #141066 )
...
a5173fe3a9...cc93627529jonahwilliams@google.com [Impeller] remove SamplerLibrary forward declare. (flutter/engine#49573 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-06 21:31:25 +00:00
engine-flutter-autoroll
0809b60aff
Roll Flutter Engine from 1dfcb6967dd1 to a5173fe3a912 (1 revision) ( #141063 )
...
1dfcb6967d...a5173fe3a9skia-flutter-autoroll@skia.org Roll Skia from a6e0b4c6a916 to 388ef1be2bb8 (1 revision) (flutter/engine#49580 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-06 18:26:43 +00:00
engine-flutter-autoroll
95dfde8369
Roll Flutter Engine from 2fd75c06e0bd to 1dfcb6967dd1 (1 revision) ( #141062 )
...
2fd75c06e0...1dfcb6967dskia-flutter-autoroll@skia.org Roll Skia from 3547cf9793f4 to a6e0b4c6a916 (2 revisions) (flutter/engine#49579 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-06 17:35:25 +00:00
engine-flutter-autoroll
ffacacf9c0
Roll Flutter Engine from 7f872b265733 to 2fd75c06e0bd (1 revision) ( #141059 )
...
7f872b2657...2fd75c06e0skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from l0zn1BQFRjNyaZb-v... to KC2scOJmW9oBJh4ts... (flutter/engine#49578 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from l0zn1BQFRjNy to KC2scOJmW9oB
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-06 14:17:27 +00:00
engine-flutter-autoroll
d0482116e7
Roll Flutter Engine from 8d1789a43319 to 7f872b265733 (1 revision) ( #141056 )
...
8d1789a433...7f872b2657skia-flutter-autoroll@skia.org Roll Skia from 514dd58cabfc to 3547cf9793f4 (1 revision) (flutter/engine#49577 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-06 08:26:34 +00:00
engine-flutter-autoroll
e0f9441229
Roll Flutter Engine from fcb40168f159 to 8d1789a43319 (1 revision) ( #141053 )
...
fcb40168f1...8d1789a433skia-flutter-autoroll@skia.org Roll Skia from 38c029ddd665 to 514dd58cabfc (1 revision) (flutter/engine#49575 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-06 06:34:13 +00:00
engine-flutter-autoroll
c6ddb73f97
Roll Flutter Engine from 89ecf7503012 to fcb40168f159 (1 revision) ( #141047 )
...
89ecf75030...fcb40168f1skia-flutter-autoroll@skia.org Roll Skia from 2345b9f2c943 to 38c029ddd665 (1 revision) (flutter/engine#49570 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-06 01:13:22 +00:00
godofredoc
f18e61a5e8
Remove codesign command from conductor. ( #141044 )
...
Codesigning is now automated and the codesigning tests have been migrated to shard tests.
2024-01-06 00:45:26 +00:00
engine-flutter-autoroll
4d97bd7799
Roll Flutter Engine from 470b604b9abf to 89ecf7503012 (2 revisions) ( #141045 )
...
470b604b9a...89ecf75030skia-flutter-autoroll@skia.org Roll Skia from 2cae982f7f2f to 2345b9f2c943 (1 revision) (flutter/engine#49568 )
2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from c59cb89f8d15 to 2cae982f7f2f (3 revisions) (flutter/engine#49567 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-06 00:25:02 +00:00
engine-flutter-autoroll
d97fafa6fa
Roll Flutter Engine from 3fd9c4ee4fc0 to 470b604b9abf (1 revision) ( #141041 )
...
3fd9c4ee4f...470b604b9askia-flutter-autoroll@skia.org Roll Skia from 9ec012033c2b to c59cb89f8d15 (1 revision) (flutter/engine#49565 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 22:36:07 +00:00
Christopher Fujino
6edbce9e07
Manual pub roll pinning web socket channel ( #141040 )
...
Work around https://github.com/flutter/flutter/issues/141032
Otherwise a re-land of https://github.com/flutter/flutter/pull/140979
Fixes https://github.com/flutter/flutter/issues/137163 & https://github.com/flutter/flutter/issues/139181
2024-01-05 22:29:58 +00:00
Andrew Kolos
e90e4888b8
in flutter run, throw tool exit when --flavor is provided but is not supported on the target device ( #139045 )
...
Fixes https://github.com/flutter/flutter/issues/134197
2024-01-05 21:47:58 +00:00
Andrew Kolos
8c11aa030d
add flavor-conditional asset bundling support to flutter test ( #140944 )
...
Fixes https://github.com/flutter/flutter/issues/140932
2024-01-05 21:47:55 +00:00
engine-flutter-autoroll
1a8de105cf
Roll Flutter Engine from f3496a7185c2 to 3fd9c4ee4fc0 (4 revisions) ( #141037 )
...
f3496a7185...3fd9c4ee4fskia-flutter-autoroll@skia.org Roll Skia from 548827f77466 to 9ec012033c2b (1 revision) (flutter/engine#49564 )
2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from a006922df1c5 to 548827f77466 (1 revision) (flutter/engine#49561 )
2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from 52be1b25c3a2 to a006922df1c5 (4 revisions) (flutter/engine#49559 )
2024-01-05 dnfield@google.com Allow spawning additional UI isolates in flutter_tester (flutter/engine#48706 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 21:30:11 +00:00
TabooSun
e8436970e6
Gen l10n add named argument option ( #138663 )
...
Add an option to use named argument for generated method.
Fix #116308
2024-01-05 21:28:08 +00:00
Luke Hutchison
0d6927cb61
Fix refresh cancelation ( #139535 )
...
Changes drag release logic so that an armed refresh is only canceled if the user has scrolled back up beyond the point where the refresh indicator was armed. (Fixes https://github.com/flutter/flutter/issues/138848 .)
This is the minimal change I found could be made to restore something like the behavior that I would expect.
This may still need a bit of work, because it only masks the second issue I mentioned, that releasing a drag can cause the scroll position to be animated back up from the release point. There is actually a bug about that: https://github.com/flutter/flutter/issues/6052 . I would like to see that bug fixed too. This PR doesn't address that, but makes it harder to hit that issue.
@Piinks this is a recreation of #139015 (since I couldn't figure out some issue with a git detached branch, so I fixed the PR and I'm re-submitting it). This version includes one line that was somehow accidentally dropped from the original PR. This will hopefully fix the test failures.
However, I don't have a clue how to write a test for a Flutter UI widget. I'll try to figure that out, but also I don't have a lot of time to work on this. I would appreciate at least some user testing to verify that the new behavior is much more intuitive than the old behavior.
- [?] All existing and new tests are passing.
2024-01-05 21:28:07 +00:00
auto-submit[bot]
c2286a7642
Reverts "manual pub roll to pick up dds fixes" ( #141033 )
...
Reverts flutter/flutter#140979
Initiated by: loic-sharma
This change reverts the following previous change:
Original Description:
Fixes https://github.com/flutter/flutter/issues/137163
Fixes https://github.com/flutter/flutter/issues/139181
2024-01-05 19:10:19 +00:00
engine-flutter-autoroll
e33ad05595
Roll Flutter Engine from ec987365e63c to f3496a7185c2 (1 revision) ( #141027 )
...
ec987365e6...f3496a7185zoujunhua86@gmail.com Add build dependencies for Android Embedder (flutter/engine#48397 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 18:28:06 +00:00
Zachary Anderson
f111459632
Shift some macOS Android tests from Moto G4 to Pixel 7 Pro ( #140912 )
...
Related https://github.com/flutter/flutter/issues/140893
2024-01-05 08:20:49 -08:00
engine-flutter-autoroll
344fcda9e7
Roll Flutter Engine from c3189d767194 to ec987365e63c (1 revision) ( #141023 )
...
c3189d7671...ec987365e6skia-flutter-autoroll@skia.org Roll Skia from 75e2f75aaa20 to 52be1b25c3a2 (2 revisions) (flutter/engine#49556 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 16:14:16 +00:00
engine-flutter-autoroll
1fb12a1361
Roll Packages from 31fc7b5dd000 to b9b6d38e012b (8 revisions) ( #141021 )
...
31fc7b5dd0...b9b6d38e01engine-flutter-autoroll@skia.org Manual roll Flutter from 11def8eff455 to cc40425ddcef (118 revisions) (flutter/packages#5806 )
2024-01-05 magder@google.com [ci] Run 'flutter build --config-only for iOS and macOS during fetch deps (flutter/packages#5804 )
2024-01-05 amirpanahandeh@yahoo.com [image_picker] Remove input element after completion (flutter/packages#5654 )
2024-01-05 stuartmorgan@google.com [video_player] Fix initial frame on macOS (flutter/packages#5781 )
2024-01-05 tarrinneal@gmail.com [pigeon] java non null void (flutter/packages#5786 )
2024-01-04 10687576+bparrishMines@users.noreply.github.com [file_selector_android] Attempt to close system dialogs before integration tests run (flutter/packages#5805 )
2024-01-04 stuartmorgan@google.com [tool] Handle Flutter dev dependencies (flutter/packages#5775 )
2024-01-04 40719830+Alex-Usmanov@users.noreply.github.com [url_launcher] Add `InAppBrowserConfiguration` parameter (flutter/packages#5758 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 15:55:20 +00:00
engine-flutter-autoroll
81ae08df6f
Roll Flutter Engine from 7e6348640940 to c3189d767194 (2 revisions) ( #141016 )
...
7e63486409...c3189d7671skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0Q4I0x-Kt7T6DOE1b... to l0zn1BQFRjNyaZb-v... (flutter/engine#49552 )
2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from bdd1e88f3b83 to 75e2f75aaa20 (4 revisions) (flutter/engine#49551 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 0Q4I0x-Kt7T6 to l0zn1BQFRjNy
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 13:24:24 +00:00
Taha Tesser
88016c11b4
Fix scrollable TabBar expands to full width when the divider is removed ( #140963 )
...
fixes [TabBar Expands to full width of the screen isScrollable: true after upgrading to flutter 3.16.4](https://github.com/flutter/flutter/issues/140338 )
---
## Description
Fixes the scrollable `TabBar` width when the divider is removed. (when the divider height is set to `0` or divider color is set to `Colors.transparent`)
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
const int tabsCount = 2;
return MaterialApp(
home: DefaultTabController(
initialIndex: 1,
length: tabsCount,
child: Scaffold(
appBar: AppBar(
title: const Text('TabBar Sample'),
bottom: PreferredSize(
preferredSize: const Size.fromHeight(48.0),
child: ColoredBox(
color: Theme.of(context).colorScheme.secondaryContainer,
child: TabBar(
// dividerColor: Theme.of(context).colorScheme.onSurface,
dividerColor: Colors.transparent, // remove divider
// dividerHeight: 0, // remove divider
isScrollable: true,
tabAlignment: TabAlignment.center,
tabs: <Widget>[
for (int i = 0; i < tabsCount; i++)
Tab(
text: 'Tab $i',
),
],
),
),
),
),
),
),
);
}
}
```
</details>
### Before
### After
2024-01-05 08:33:26 +00:00
engine-flutter-autoroll
89809bef71
Roll Flutter Engine from 8c951851b14f to 7e6348640940 (1 revision) ( #141004 )
...
8c951851b1...7e63486409skia-flutter-autoroll@skia.org Roll Skia from da75878a3aea to bdd1e88f3b83 (1 revision) (flutter/engine#49547 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 05:15:24 +00:00
engine-flutter-autoroll
43016dd155
Roll Flutter Engine from f2f00a438e40 to 8c951851b14f (1 revision) ( #140997 )
...
f2f00a438e...8c951851b1skia-flutter-autoroll@skia.org Roll Skia from dab831e8dcec to da75878a3aea (1 revision) (flutter/engine#49546 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 02:08:52 +00:00
engine-flutter-autoroll
4ff2396b86
Roll Flutter Engine from f60d9a9a3395 to f2f00a438e40 (1 revision) ( #140995 )
...
f60d9a9a33...f2f00a438eflar@google.com [Impeller] RenderPass now provides the Orthographic matrix (flutter/engine#49544 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 01:23:28 +00:00
engine-flutter-autoroll
cc40425ddc
Roll Flutter Engine from 0bbb4d61ce82 to f60d9a9a3395 (1 revision) ( #140993 )
...
0bbb4d61ce...f60d9a9a3330870216+gaaclarke@users.noreply.github.com [Impeller] migrate blur to calculating coefficients on the cpu (flutter/engine#49512 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-05 00:30:14 +00:00
engine-flutter-autoroll
4db3bbe203
Roll Flutter Engine from b2a9ce88a19e to 0bbb4d61ce82 (3 revisions) ( #140990 )
...
b2a9ce88a1...0bbb4d61ce58190796+MitchellGoodwin@users.noreply.github.com Get the correct iOS system font for each weight (flutter/engine#48937 )
2024-01-04 43054281+camsim99@users.noreply.github.com [Android] Re-land "Re-land 'Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34'" (flutter/engine#49101 )
2024-01-04 godofredoc@google.com Use Mac M1s or x86 wherever possible. (flutter/engine#49540 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 23:44:01 +00:00
Yegor
1fb95ba41b
[web] Fix and unskip a few more CanvasKit tests ( #140821 )
...
Fix and unskip the following CanvasKit tests:
- `test/painting/decoration_test.dart`
- `test/rendering/layers_test.dart`
- `test/widgets/app_overrides_test.dart`
2024-01-04 23:26:38 +00:00
engine-flutter-autoroll
4593e70338
Roll Flutter Engine from bd175aa5e0b6 to b2a9ce88a19e (1 revision) ( #140986 )
...
bd175aa5e0...b2a9ce88a1skia-flutter-autoroll@skia.org Roll Skia from 48ba1246efdf to dab831e8dcec (1 revision) (flutter/engine#49538 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-04 22:57:33 +00:00
Danny Tuppeny
2d3166b7f9
Pin package:vm_service ( #140972 )
...
vm_service 14 should not be used yet (see
https://github.com/flutter/flutter/pull/140916#issuecomment-1877383354 )
but when trying to unpin pkg:test it was upgraded. This pins it to
v13.0.0.
2024-01-04 21:10:44 +00:00
Qun Cheng
be8a1eac73
Add scrollbar for menus ( #140941 )
...
Fixes #140162
This PR is to add a scrollbar for MenuAnchor and DropdownMenu for all platforms when height is limited. Previously, a scrollbar only shows on desktop platforms. This PR also disabled scrollbar's overscroll for MenuAnchor and DropdownMenu.
<img src="https://github.com/flutter/flutter/assets/36861262/9ca3d4d0-415f-43bf-9d2b-df96a42db620 " width="250"/><img src="https://github.com/flutter/flutter/assets/36861262/18da8d02-586b-4aa4-b647-927691542429 " width="350"/>
2024-01-04 21:09:31 +00:00
Christopher Fujino
e256d49117
manual pub roll to pick up dds fixes ( #140979 )
...
Fixes https://github.com/flutter/flutter/issues/137163
Fixes https://github.com/flutter/flutter/issues/139181
2024-01-04 19:43:06 +00:00
