33564 Commits

Author SHA1 Message Date
skia-flutter-autoroll
e75da409b5 Roll Dart SDK from 042dbc146a37 to d6c08fa9bb54 (2 revisions) (flutter/engine#49763)
https://dart.googlesource.com/sdk.git/+log/042dbc146a37..d6c08fa9bb54

2024-01-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-24.0.dev
2024-01-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-23.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 17:48:25 +00:00
zijiehe@
cc3c0eeca9 [Fuchsia] Use chromium test-scripts to download images and execute tests (flutter/engine#49650)
This change requires https://github.com/flutter/buildroot/pull/811, and can be executed from buildroot by

```
python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py
```

Bug: https://github.com/flutter/flutter/issues/140179

- [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
- [V] I listed at least one issue that this PR fixes in the description above.
- [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
- [V] I updated/added relevant documentation (doc comments with `///`).
- [V] I signed the [CLA].
- [V] All existing and new tests are passing.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-12 17:04:31 +00:00
skia-flutter-autoroll
0775befebe Roll Skia from e04ca400c5d8 to 2bc5d2ee9896 (1 revision) (flutter/engine#49761)
https://skia.googlesource.com/skia.git/+log/e04ca400c5d8..2bc5d2ee9896

2024-01-12 bungeman@google.com Allow MSVC "host" builds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 17:00:40 +00:00
skia-flutter-autoroll
543c4d8a45 Roll Skia from 7484d4a2514e to e04ca400c5d8 (2 revisions) (flutter/engine#49759)
https://skia.googlesource.com/skia.git/+log/7484d4a2514e..e04ca400c5d8

2024-01-12 johnstiles@google.com Add output file from new test.
2024-01-12 johnstiles@google.com Report top-level local variables that shadow parameters in SkSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 15:55:10 +00:00
skia-flutter-autoroll
47301fc0ab Roll Skia from 22fa87f32944 to 7484d4a2514e (1 revision) (flutter/engine#49757)
https://skia.googlesource.com/skia.git/+log/22fa87f32944..7484d4a2514e

2024-01-12 johnstiles@google.com Remove FunctionDefinition::parameterSymbolTable.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 15:11:01 +00:00
skia-flutter-autoroll
beb790dde0 Roll Skia from 1871595fecb3 to 22fa87f32944 (1 revision) (flutter/engine#49755)
https://skia.googlesource.com/skia.git/+log/1871595fecb3..22fa87f32944

2024-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3cfac285a67f to 698eee9385e4 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 14:01:00 +00:00
skia-flutter-autoroll
414ffc768c Roll Dart SDK from f61f7d2f57c5 to 042dbc146a37 (1 revision) (flutter/engine#49752)
https://dart.googlesource.com/sdk.git/+log/f61f7d2f57c5..042dbc146a37

2024-01-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-22.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 11:38:27 +00:00
skia-flutter-autoroll
e319fc02d8 Roll Dart SDK from bff80f6c56de to f61f7d2f57c5 (1 revision) (flutter/engine#49748)
https://dart.googlesource.com/sdk.git/+log/bff80f6c56de..f61f7d2f57c5

2024-01-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-21.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 07:54:23 +00:00
skia-flutter-autoroll
e108a0114d Roll Skia from 2bef4f0f8058 to 1871595fecb3 (1 revision) (flutter/engine#49747)
https://skia.googlesource.com/skia.git/+log/2bef4f0f8058..1871595fecb3

2024-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f1fee64d7f04 to 073b651053b3 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 06:17:23 +00:00
skia-flutter-autoroll
51c619538a Roll Skia from e9de42588e54 to 2bef4f0f8058 (2 revisions) (flutter/engine#49745)
https://skia.googlesource.com/skia.git/+log/e9de42588e54..2bef4f0f8058

2024-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 17922a334064 to 1de9b3d66634 (4 revisions)
2024-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e3230c2ab314 to 1de9b3d66634

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 05:39:22 +00:00
skia-flutter-autoroll
949ddfd3c2 Roll Dart SDK from 3245b92a5930 to bff80f6c56de (4 revisions) (flutter/engine#49744)
https://dart.googlesource.com/sdk.git/+log/3245b92a5930..bff80f6c56de

2024-01-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-20.0.dev
2024-01-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-19.0.dev
2024-01-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-18.0.dev
2024-01-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-17.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 04:05:23 +00:00
skia-flutter-autoroll
5386639b8f Roll Skia from d65d18ac1e8d to e9de42588e54 (1 revision) (flutter/engine#49738)
https://skia.googlesource.com/skia.git/+log/d65d18ac1e8d..e9de42588e54

2024-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from de550f45d3fe to 3cfac285a67f (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 01:20:30 +00:00
Matan Lurey
5a61efcfff Add SurfaceTextureSurfaceProducer (flutter/engine#49653)
Unblocks https://github.com/flutter/flutter/issues/139702.

The next step will be local validation that this API works for at least a few of our internal plugins (video_player, camera).
2024-01-11 23:32:54 +00:00
skia-flutter-autoroll
036fa47d94 Roll Skia from b63e5a3c14e1 to d65d18ac1e8d (1 revision) (flutter/engine#49735)
https://skia.googlesource.com/skia.git/+log/b63e5a3c14e1..d65d18ac1e8d

2024-01-11 johnstiles@google.com Add support for SkSL Graphite ES2 program kinds.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 23:20:04 +00:00
Jonah Williams
7b95690be2 [Impeller] Begin migrating to RenderPass command recording API. (flutter/engine#49480)
Part of https://github.com/flutter/flutter/issues/140804 proposes removing the Command object. This demonstrates the new API without changing the implementation, which can be done separately per backend. This also doesn't change every single callsite for reasons...
2024-01-11 22:29:55 +00:00
Victoria Ashworth
ddd6db70ed Run tests on macOS 13 only (flutter/engine#49722)
Release team wants engine tests running exclusively on macOS 13 in main for a while before CP'ing to beta.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-11 22:16:16 +00:00
Jonah Williams
12f4ae6d56 [Impeller] dont accidentally copy shared ptr. (flutter/engine#49731)
Copying the shared ptr when we don't need to results in us incrementing/decrementing the ref count which isn't free.
2024-01-11 22:05:22 +00:00
skia-flutter-autoroll
232ab95af3 Roll Skia from 56f28f137507 to b63e5a3c14e1 (1 revision) (flutter/engine#49733)
https://skia.googlesource.com/skia.git/+log/56f28f137507..b63e5a3c14e1

2024-01-11 johnstiles@google.com Add placeholder files for Graphite ES2 support.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 22:05:20 +00:00
Jason Simmons
36c6968075 Revert Dart SDK to 3245b92a5930 (flutter/engine#49727)
A recent Dart SDK roll included a regression affecting runs of "flutter analyze" on individual files

(see https://dart.googlesource.com/sdk/+/89bd370e95c0695250a4f0111be3134b9936eadd)
2024-01-11 21:57:23 +00:00
skia-flutter-autoroll
6bf9363bd3 Roll Fuchsia Linux SDK from gJuGKaWsKazIrvQeO... to Klxww53tA4-TG5pA9... (flutter/engine#49730)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 21:34:43 +00:00
Jesse Seales
422a7183fc Google GitHub mirrors - reland (flutter/engine#49716)
Reland of https://github.com/flutter/engine/pull/49203 after permissions issue. The googleapis.dart mirror is now verified to be publicly available.

Also remove github dependency variable since there are no more existing uses.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-11 20:30:10 +00:00
skia-flutter-autoroll
574f3471eb Roll Skia from 440f5f849008 to 56f28f137507 (1 revision) (flutter/engine#49723)
https://skia.googlesource.com/skia.git/+log/440f5f849008..56f28f137507

2024-01-11 briansalomon@gmail.com [graphite] Don't call wgpu::ShaderModule::GetCompilationInfo on emsdk < 3.1.51

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 19:21:05 +00:00
Jesse Seales
4fa8327ffe Osv-scanner integration (flutter/engine#49470)
This change integrates directly with osv-scanner rather than using the OSV API to query each dependency for vulnerabilities.

- use [lockfile format](https://github.com/flutter/engine/pull/49203) for third party deps rather than a flat file
- let osv-scanner do the work of checking for vulns rather than API calls to OSV database
- let osv-scanner create and populate the SARIF results 

A successful run of the vulnerability scanner can be seen in the tests of this PR.

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-11 18:59:47 +00:00
Jason Simmons
4610aea866 [Impeller] Add DrawLine/DrawOval/ClipOval operations to the canvas recorder (flutter/engine#49697) 2024-01-11 18:44:03 +00:00
skia-flutter-autoroll
2fb99c5544 Roll Dart SDK from 7f3ea1c3bc27 to 6f5bd26b293d (1 revision) (flutter/engine#49720)
https://dart.googlesource.com/sdk.git/+log/7f3ea1c3bc27..6f5bd26b293d

2024-01-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-18.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 17:49:57 +00:00
Dan Field
90ee2f7711 Try to get GLES tests running... (flutter/engine#49701)
I plan to fix the GLES fragment program reload issue, but first want to make sure this gets some failures for it.

Added a few skips for shaders that require an extension not available on CI (mipmap related ones).

Updated a couple tests that were failing.
2024-01-11 17:32:13 +00:00
skia-flutter-autoroll
aa02bbf822 Roll Skia from 2a5710618fc3 to 440f5f849008 (1 revision) (flutter/engine#49715)
https://skia.googlesource.com/skia.git/+log/2a5710618fc3..440f5f849008

2024-01-11 bungeman@google.com Libgrapheme build to fail when generator fails

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 15:57:22 +00:00
skia-flutter-autoroll
265d6d6b5a Roll Skia from c46008e5a839 to 2a5710618fc3 (1 revision) (flutter/engine#49712)
https://skia.googlesource.com/skia.git/+log/c46008e5a839..2a5710618fc3

2024-01-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 16c36d451859 to de550f45d3fe (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 12:19:28 +00:00
skia-flutter-autoroll
20012247ce Roll Dart SDK from 3245b92a5930 to 7f3ea1c3bc27 (1 revision) (flutter/engine#49710)
https://dart.googlesource.com/sdk.git/+log/3245b92a5930..7f3ea1c3bc27

2024-01-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-17.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 09:47:22 +00:00
skia-flutter-autoroll
5664f0738a Roll Skia from 5d4f12f3f12d to c46008e5a839 (1 revision) (flutter/engine#49708)
https://skia.googlesource.com/skia.git/+log/5d4f12f3f12d..c46008e5a839

2024-01-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2937ee276cf5 to f1fee64d7f04 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 07:37:04 +00:00
skia-flutter-autoroll
00bd1367a9 Roll Skia from e80a6830eb4d to 5d4f12f3f12d (1 revision) (flutter/engine#49706)
https://skia.googlesource.com/skia.git/+log/e80a6830eb4d..5d4f12f3f12d

2024-01-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 939506789cfa to 17922a334064 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 06:54:37 +00:00
skia-flutter-autoroll
c19ee592a8 Roll Skia from ae45496c55e2 to e80a6830eb4d (2 revisions) (flutter/engine#49705)
https://skia.googlesource.com/skia.git/+log/ae45496c55e2..e80a6830eb4d

2024-01-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 2fa7e9b99ae4 to f4819d2276b7 (1 revision)
2024-01-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 8727c3f5ed1f to e3230c2ab314

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 05:58:19 +00:00
Dan Field
4681274469 [Impeller] Vulkan runtime effects/fragment program API (flutter/engine#49543)
Fixes https://github.com/flutter/flutter/issues/122823
Fixes https://github.com/flutter/flutter/issues/129659
Fixes https://github.com/flutter/flutter/issues/123741

This patch makes runtime stage/fragment program stuff work on Vulkan for Android.

It will need flutter/flutter#140976 for that to become a reality for flutter_tools users.

Compiling with relaxed Vulkan semantics still has an issue: shaders that use `sampler2D` with an explicitly set `location` on the `layout` will fail to compile with an error documented in https://github.com/flutter/flutter/issues/141219.

I think there might still be some issues with fragment programs on Vulkan, but this should at least be a good starting point and unblocks ink_sparkle.frag usage in the framework.

I've deleted some runtime_stage related code that would never get used - for example, enum related code that indicates we might support a bunch of data types that we do not and probably never will support in this API.
2024-01-11 02:25:05 +00:00
skia-flutter-autoroll
c975e9b627 Roll Dart SDK from 9f5a6a2ccace to 3245b92a5930 (1 revision) (flutter/engine#49700)
https://dart.googlesource.com/sdk.git/+log/9f5a6a2ccace..3245b92a5930

2024-01-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-16.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 02:09:22 +00:00
skia-flutter-autoroll
61977b23df Roll Skia from 596053dde5f0 to ae45496c55e2 (1 revision) (flutter/engine#49695)
https://skia.googlesource.com/skia.git/+log/596053dde5f0..ae45496c55e2

2024-01-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 02411d24ca96 to 16c36d451859 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 00:32:58 +00:00
skia-flutter-autoroll
eabf9d9cdb Roll Skia from d1fbb9177115 to 596053dde5f0 (1 revision) (flutter/engine#49694)
https://skia.googlesource.com/skia.git/+log/d1fbb9177115..596053dde5f0

2024-01-10 herb@google.com Implement Myers' Sweep-Line algorithm

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 23:37:49 +00:00
skia-flutter-autoroll
5874720d60 Roll Skia from 2f254f5d41f2 to d1fbb9177115 (1 revision) (flutter/engine#49692)
https://skia.googlesource.com/skia.git/+log/2f254f5d41f2..d1fbb9177115

2024-01-10 jvanverth@google.com Revert "[graphite] Have Device submit parent uploads prior to its own."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 22:35:05 +00:00
Jonah Williams
c18d6e3a08 [Impeller] reland: write directly to device buffer. (flutter/engine#49691)
Reland of https://github.com/flutter/engine/pull/49505

---

part of https://github.com/flutter/flutter/issues/140804

We can't use the existing host buffer abstraction as that requires us to collect all allocations up front. By itself, this isn't sufficient for #140804 , because we'll need a way to mark ranges as dirty and/or flush if we don't have host coherent memory. But by itself this change should be beneficial as we'll create fewer device buffers and should do less allocation in general.

The size of the device buffers is 1024 Kb, somewhat arbitrarily chosen.
2024-01-10 22:10:03 +00:00
skia-flutter-autoroll
577ac81725 Roll Dart SDK from c2862d44e108 to 9f5a6a2ccace (1 revision) (flutter/engine#49689)
https://dart.googlesource.com/sdk.git/+log/c2862d44e108..9f5a6a2ccace

2024-01-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-15.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 22:08:04 +00:00
auto-submit[bot]
6236178dac Reverts "[Impeller] have Hostbuffer write directly to block allocated device buffers." (flutter/engine#49688)
Reverts flutter/engine#49505
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
part of https://github.com/flutter/flutter/issues/140804

We can't use the existing host buffer abstraction as that requires us to collect all allocations up front. By itself, this isn't sufficient for #140804 , because we'll need a way to mark ranges as dirty and/or flush if we don't have host coherent memory. But by itself this change should be beneficial as we'll create fewer device buffers and should do less allocation in general.

The size of the device buffers is 1024 Kb, somewhat arbitrarily chosen.
2024-01-10 21:09:18 +00:00
skia-flutter-autoroll
9ec6040596 Roll Skia from 0443e02cdfd3 to 2f254f5d41f2 (1 revision) (flutter/engine#49685)
https://skia.googlesource.com/skia.git/+log/0443e02cdfd3..2f254f5d41f2

2024-01-10 brianosman@google.com Ensure that sk_unaligned_[load|store] and sk_bit_cast are safe on x86

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 21:01:11 +00:00
Jason Simmons
42b65dc4a5 [Impeller] Make the shaders loaded by the GLES playground consistent with other playgrounds (flutter/engine#49684) 2024-01-10 20:30:38 +00:00
skia-flutter-autoroll
bd168b26ba Roll Fuchsia Linux SDK from pUQrgMfXgU8RmLuL4... to gJuGKaWsKazIrvQeO... (flutter/engine#49682)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 20:21:49 +00:00
skia-flutter-autoroll
6bfd10a0ab Roll Skia from 334160c0eede to 0443e02cdfd3 (2 revisions) (flutter/engine#49681)
https://skia.googlesource.com/skia.git/+log/334160c0eede..0443e02cdfd3

2024-01-10 drott@chromium.org Revert^2 "[Fontations-backend] Add COLRv0/v1 support to Fontations backend"
2024-01-10 fmalita@chromium.org [skottie] Fix font fallback in viewer and skottie_tool

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 19:47:13 +00:00
skia-flutter-autoroll
6c62d1a5ae Roll Dart SDK from b3d7097aa10f to c2862d44e108 (1 revision) (flutter/engine#49677)
https://dart.googlesource.com/sdk.git/+log/b3d7097aa10f..c2862d44e108

2024-01-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-14.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 17:59:22 +00:00
Jonah Williams
eaae4c5d1a [Impeller] have Hostbuffer write directly to block allocated device buffers. (flutter/engine#49505)
part of https://github.com/flutter/flutter/issues/140804

We can't use the existing host buffer abstraction as that requires us to collect all allocations up front. By itself, this isn't sufficient for #140804 , because we'll need a way to mark ranges as dirty and/or flush if we don't have host coherent memory. But by itself this change should be beneficial as we'll create fewer device buffers and should do less allocation in general.

The size of the device buffers is 1024 Kb, somewhat arbitrarily chosen.
2024-01-10 17:18:07 +00:00
skia-flutter-autoroll
fe4befbda6 Roll Skia from 9271dcdade42 to 334160c0eede (1 revision) (flutter/engine#49675)
https://skia.googlesource.com/skia.git/+log/9271dcdade42..334160c0eede

2024-01-10 herb@google.com Add brute force crossing detection

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 16:52:22 +00:00
skia-flutter-autoroll
76d5c9f519 Roll Dart SDK from efd053daa2a6 to b3d7097aa10f (1 revision) (flutter/engine#49673)
https://dart.googlesource.com/sdk.git/+log/efd053daa2a6..b3d7097aa10f

2024-01-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-13.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 13:57:04 +00:00
auto-submit[bot]
ba524cfeb7 Reverts "Migrate to Flutter mirrors for Google-owned Github repositories" (flutter/engine#49671)
Reverts flutter/engine#49203
Initiated by: whesse
This change reverts the following previous change:
Original Description:
Flutter dependencies coming from Github origins need to be mirrored so that they are not taken directly from github. This is part of an effort to standardize the dependency sources from third party dependencies.

Google is creating internal mirrors for these public repos, but we would be limited by the relatively strict access placed on those new repos, requiring this solution of Flutter GoB mirrors (as has already been done with non-Google Github repos and also Fuchsia-owned mirrors)

*List which issues are fixed by this PR. You must list at least one issue.*
Addresses b/316597637

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-10 12:04:27 +00:00
skia-flutter-autoroll
fa47817e3a Roll Skia from 51a0ad17b147 to 9271dcdade42 (1 revision) (flutter/engine#49669)
https://skia.googlesource.com/skia.git/+log/51a0ad17b147..9271dcdade42

2024-01-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 544beceafa51 to 02411d24ca96 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 10:41:30 +00:00