Jonah Williams
e4e7a45b0f
[Impeller] rectangle packer actually packs. ( flutter/engine#52781 )
...
Fixes https://github.com/flutter/flutter/issues/148251
Work towards https://github.com/flutter/flutter/issues/138798
The rectangle packer was only filling up the top and right edge of each rectangle, making the atlas super inefficient.
2024-05-13 23:18:06 +00:00
skia-flutter-autoroll
984bfd2149
Roll Skia from 75b3286ecaac to 400c6fbeace8 (6 revisions) ( flutter/engine#52783 )
...
https://skia.googlesource.com/skia.git/+log/75b3286ecaac..400c6fbeace8
2024-05-13 bungeman@google.com Use tilemode for sweep in scaled_tilemode_gradient
2024-05-13 bungeman@google.com [pdf] Clean up make_function_shader
2024-05-13 armansito@google.com Revert "[graphite] Tweaks to atlas path renderer selection"
2024-05-13 bungeman@google.com Remove old "skottie" gm
2024-05-13 skia-autoroll@skia-public.iam.gserviceaccount.com Manually roll Dawn from 94ceac3a5f35 to 1b2d3eb175fd (29 revisions)
2024-05-13 michaelludwig@google.com [graphite] Clean up crash debugging code
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 23:18:04 +00:00
Jenn Magder
ea38b72a0d
ios_external_view_embedder to ARC ( flutter/engine#52782 )
...
`ios_external_view_embedder` is only C++ and there was nothing to migrate.
Also add a few missing `FLUTTER_ASSERT_ARC` macros.
Part of https://github.com/flutter/flutter/issues/137801 .
2024-05-13 23:14:10 +00:00
skia-flutter-autoroll
67b37c1778
Roll Dart SDK from a0a940f07d56 to 7c7767ecc3d7 (2 revisions) ( flutter/engine#52777 )
...
https://dart.googlesource.com/sdk.git/+log/a0a940f07d56..7c7767ecc3d7
2024-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-151.0.dev
2024-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-150.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 22:05:22 +00:00
Chinmay Garde
9553b60725
Remove outdated comment. ( flutter/engine#52778 )
...
The linked issue has been closed as WAI.
2024-05-13 22:05:20 +00:00
Chinmay Garde
f20b17a2ae
[Impeller] Prepare a SkiaGPU-less iOS build. ( flutter/engine#52748 )
...
The size of the LTO build of the engine with the dylib compressed is as follows:
```sh
$ du -k libFlutter*
5236 libFlutter.dylib.tar.gz
4324 libFlutterSlimpeller.dylib.tar.gz
```
Sizes are in KiB. This represents a binary size reduction of 17.41% of the compressed artifacts. The compression ratios will likely differ based on the compression scheme.
Uncompressed, the sizes are:
```sh
$ du -k libFlutter*
16920 libFlutter.dylib
14044 libFlutterSlimpeller.dylib
```
This represents a binary size reduction of 16.99% which is in the same ballpark.
The really mucky bit was backing out the raster cache and persistent cache. I want to clean that up in a later patch so that those TUs are part of a separate submodule.
Opting out of Impeller will lead to a fatal log at startup saying the opt-out is disallowed.
Fixes https://github.com/flutter/flutter/issues/126606
2024-05-13 21:43:47 +00:00
Jenn Magder
4261e6bab1
Remove -[NSNotificationCenter removeObserver:] in deallocs ( flutter/engine#52772 )
...
Removing `NSNotificationCenter` observers in dealloc hasn't been necessary since iOS 8 or macOS 10.10.
> If your app targets iOS 9.0 and later or macOS 10.11 and later, and you used [addObserver:selector:name:object:](https://developer.apple.com/documentation/foundation/nsnotificationcenter/1415360-addobserver ), you do not need to unregister the observer. If you forget or are unable to remove the observer, the system cleans up the next time it would have posted to it.
https://developer.apple.com/documentation/foundation/nsnotificationcenter/1413994-removeobserver
Remove it.
2024-05-13 20:50:42 +00:00
Jenn Magder
48ea1c2f79
Migrate FlutterDartProject and FlutterPluginAppLifeCycleDelegate to ARC ( flutter/engine#52719 )
...
- Migrate `FlutterDartProject` and `FlutterPluginAppLifeCycleDelegate` from MRC to ARC.
- Swap a few dictionary `objectForKey:` to subscripting.
- Header cleanup.
- Cleanup build DEPS.
Part of https://github.com/flutter/flutter/issues/137801 .
2024-05-13 19:16:16 +00:00
skia-flutter-autoroll
bbd546958d
Roll Skia from dde1f5dba183 to 75b3286ecaac (1 revision) ( flutter/engine#52763 )
...
https://skia.googlesource.com/skia.git/+log/dde1f5dba183..75b3286ecaac
2024-05-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a06b82c306ee to f1dcf238ad74 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 15:57:09 +00:00
skia-flutter-autoroll
546316e3e0
Roll Skia from 2a7830d74a8b to dde1f5dba183 (1 revision) ( flutter/engine#52762 )
...
https://skia.googlesource.com/skia.git/+log/2a7830d74a8b..dde1f5dba183
2024-05-13 kjlubick@google.com [bazel] Add some missing dependencies/files to Ganesh Metal Backend
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 14:00:23 +00:00
skia-flutter-autoroll
db39f3da80
Roll Dart SDK from f1a6336d2147 to a0a940f07d56 (1 revision) ( flutter/engine#52761 )
...
https://dart.googlesource.com/sdk.git/+log/f1a6336d2147..a0a940f07d56
2024-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-149.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 13:42:36 +00:00
skia-flutter-autoroll
c0d349859b
Roll Dart SDK from ff786d99b517 to f1a6336d2147 (1 revision) ( flutter/engine#52758 )
...
https://dart.googlesource.com/sdk.git/+log/ff786d99b517..f1a6336d2147
2024-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-148.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 09:47:48 +00:00
skia-flutter-autoroll
0b04738625
Roll Skia from 4bc37d0feedb to 2a7830d74a8b (1 revision) ( flutter/engine#52756 )
...
https://skia.googlesource.com/skia.git/+log/4bc37d0feedb..2a7830d74a8b
2024-05-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 4910599942c0 to 68c060aa3487
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 06:51:24 +00:00
skia-flutter-autoroll
baf00539cd
Roll Skia from cbe627d5ba15 to 4bc37d0feedb (1 revision) ( flutter/engine#52754 )
...
https://skia.googlesource.com/skia.git/+log/cbe627d5ba15..4bc37d0feedb
2024-05-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 14a9c90d4ad7 to 4910599942c0 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 05:58:08 +00:00
skia-flutter-autoroll
a37f883cb1
Roll Skia from 4e9362762a0f to cbe627d5ba15 (1 revision) ( flutter/engine#52752 )
...
https://skia.googlesource.com/skia.git/+log/4e9362762a0f..cbe627d5ba15
2024-05-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 862e523d9e3d to a06b82c306ee (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 03:23:39 +00:00
Chinmay Garde
e844d28955
Detail a gotcha about reproxystatus ( flutter/engine#52714 )
2024-05-12 21:15:27 +00:00
skia-flutter-autoroll
b6ff9c7abd
Roll Skia from d78564aad21d to 4e9362762a0f (1 revision) ( flutter/engine#52739 )
...
https://skia.googlesource.com/skia.git/+log/d78564aad21d..4e9362762a0f
2024-05-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 54d46e9c6097 to 4910599942c0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-12 07:22:29 +00:00
skia-flutter-autoroll
69339a57cc
Roll Skia from 709deddd904f to d78564aad21d (2 revisions) ( flutter/engine#52732 )
...
https://skia.googlesource.com/skia.git/+log/709deddd904f..d78564aad21d
2024-05-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3317f9533df9 to 862e523d9e3d (1 revision)
2024-05-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4a16c5226357 to 3317f9533df9 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-11 18:14:32 +00:00
skia-flutter-autoroll
27280f9e6d
Roll Skia from b6186e1b3995 to 709deddd904f (1 revision) ( flutter/engine#52727 )
...
https://skia.googlesource.com/skia.git/+log/b6186e1b3995..709deddd904f
2024-05-10 armansito@google.com [graphite] Tweaks to atlas path renderer selection
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-11 17:10:20 +00:00
skia-flutter-autoroll
08086a5d3f
Roll Dart SDK from cbfaae24852c to ff786d99b517 (1 revision) ( flutter/engine#52731 )
...
https://dart.googlesource.com/sdk.git/+log/cbfaae24852c..ff786d99b517
2024-05-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-147.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-11 13:53:37 +00:00
skia-flutter-autoroll
2da9b82678
Roll Dart SDK from de30a5dbf169 to cbfaae24852c (2 revisions) ( flutter/engine#52730 )
...
https://dart.googlesource.com/sdk.git/+log/de30a5dbf169..cbfaae24852c
2024-05-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-146.0.dev
2024-05-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-145.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-11 05:58:09 +00:00
Chinmay Garde
c2b3eb1ebd
[Impeller] Followup feedback on "Baby's First Triangle". ( flutter/engine#52718 )
...
Addresses comments made after https://github.com/flutter/engine/pull/52703 landed.
2024-05-11 05:05:33 +00:00
skia-flutter-autoroll
2ff1f9bf27
Roll Dart SDK from 13fc7db956c7 to de30a5dbf169 (1 revision) ( flutter/engine#52728 )
...
https://dart.googlesource.com/sdk.git/+log/13fc7db956c7..de30a5dbf169
2024-05-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-144.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-11 01:55:39 +00:00
skia-flutter-autoroll
023604f04b
Roll Skia from f69e8967610e to b6186e1b3995 (2 revisions) ( flutter/engine#52726 )
...
https://skia.googlesource.com/skia.git/+log/f69e8967610e..b6186e1b3995
2024-05-10 armansito@google.com Reland "[vello] Enable the bump allocation estimator"
2024-05-10 armansito@google.com Roll vello 6c1e8b815b1e...6938a2893d6a (18 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-10 23:17:15 +00:00
Zachary Anderson
a1257de605
Simplify GN pools, use in more places ( flutter/engine#52721 )
...
This PR changes from using a different GN pool for each non-compiler tool, to using one GN pool for everything.
Additionally, since we are no longer linking remotely in any configuration, this PR uses the pool for linking.
ObjC and impellerc tasks also do not (yet) run on RBE, so they are also now governed by the pool.
Needs https://github.com/flutter/buildroot/pull/856
2024-05-10 22:43:23 +00:00
Matan Lurey
70b18ec727
Write dart:ui golden-file tests testing FilterQuality.* ( flutter/engine#52687 )
...
Work towards https://github.com/flutter/flutter/issues/147259 .
Most of this is just me understanding how `FilterQuality.*` feeds into the rest of the engine, and updating our testing documentation so we all understand how to re-run these tests in the future. Here is an example output of both Impeller and non-Impeller output of `image_filter_test`:
<img width="485" alt="Screenshot 2024-05-08 at 2 25 53â¯PM" src="https://github.com/flutter/engine/assets/168174/58e6a4f5-98e2-4b9e-b181-4ff613ad4d29 ">
2024-05-10 22:15:23 +00:00
Jim Graham
fa49f1794a
Revert "DisplayListBuilder internal reorganization with better rendering op overlap detection" ( flutter/engine#52725 )
...
Reverts flutter/engine#52646
Some of the golden changes in G3 as a result of that PR look like bugs in the bounds calculations...
2024-05-10 22:04:40 +00:00
gaaclarke
6a1797edc9
deletes canvas recorder ( flutter/engine#52722 )
...
design doc: https://docs.google.com/document/d/17LiGKlt57R5CZMxcWt9wj9Z7eDihhUaUEg3oeGQAKTc/edit#heading=h.kifztz2gx2n3
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-10 22:00:03 +00:00
skia-flutter-autoroll
2ecd5a720f
Roll Skia from d1118d56853c to f69e8967610e (1 revision) ( flutter/engine#52723 )
...
https://skia.googlesource.com/skia.git/+log/d1118d56853c..f69e8967610e
2024-05-10 petermcneeley@chromium.org [graphite] Detect and apply nearest filtering for image shaders
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-10 21:56:50 +00:00
Jonah Williams
578e769483
[Impeller] treat glyph atlas texture as source of truth, remove copy of SkBitmap. ( flutter/engine#52567 )
...
Work towards part of https://github.com/flutter/flutter/issues/138798
Allow updating single glyphs in the glyph atlas, without replacing the entire bitmap. Required to efficiently append/update to large atlases.
2024-05-10 21:39:47 +00:00
skia-flutter-autoroll
4dba894abc
Roll Dart SDK from 01121c008f4d to 13fc7db956c7 (2 revisions) ( flutter/engine#52716 )
...
https://dart.googlesource.com/sdk.git/+log/01121c008f4d..13fc7db956c7
2024-05-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-143.0.dev
2024-05-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-142.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-10 21:33:45 +00:00
skia-flutter-autoroll
8f9fdd9e07
Roll Skia from 11d892ce49b6 to d1118d56853c (1 revision) ( flutter/engine#52717 )
...
https://skia.googlesource.com/skia.git/+log/11d892ce49b6..d1118d56853c
2024-05-10 bungeman@google.com Add a Test-Mac-PDF job
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-10 20:28:12 +00:00
Harry Terkelsen
740e431a9d
[canvaskit] Clip before applying ColorFilter so it doesn't filter beyond child bounds ( flutter/engine#52704 )
...
When a ColorFilter affects transparent black, it will expand its bounds
to the entire screen, even if the `saveLayer` call is bounded. This
applies a clip before applying the ColorFilter so the filter is bounded
to just the child drawings.
Also fixes bug with ColorFilter being used as an ImageFilter.
Before:
After:
Fixes https://github.com/flutter/flutter/issues/88866
Fixes https://github.com/flutter/flutter/issues/144015
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-05-10 12:48:41 -07:00
Jenn Magder
c24f7454d0
Migrate FlutterView, FlutterPlatformViews, FlutterOverlayView to ARC ( flutter/engine#52535 )
...
Smart pointers support ARC as of
https://github.com/flutter/engine/pull/47612 , and the unit tests were
migrated in https://github.com/flutter/engine/pull/48162 .
Migrate `FlutterView`, `FlutterPlatformViews`, and `FlutterOverlayView`
from MRC to ARC.
Part of https://github.com/flutter/flutter/issues/137801 .
2024-05-10 12:07:30 -07:00
Matan Lurey
0a503306d4
Infer --rbe based on the existence of //flutter/build/rbe ( flutter/engine#52700 )
...
Closes https://github.com/flutter/flutter/issues/148006 .
2024-05-10 11:49:44 -07:00
Jonah Williams
6d4428162a
[Impeller] Disable AHB swapchain. ( flutter/engine#52713 )
...
The AHB swapchain has correctness issues, which can be observed when
running the draw points microbenchmark application. Disable for now
until we figure out the sync fence behavior.
2024-05-10 11:44:53 -07:00
skia-flutter-autoroll
060dc54296
Roll Skia from c7cd1e9690d1 to 11d892ce49b6 (25 revisions) ( flutter/engine#52712 )
...
https://skia.googlesource.com/skia.git/+log/c7cd1e9690d1..11d892ce49b6
2024-05-10 bungeman@google.com [fontations] Test to fail to compare
gracefully
2024-05-10 fmalita@google.com [svg] FEComponentTransfer support
2024-05-10 fmalita@google.com [svg] Add SkSVGFeMerge.cpp to public.bzl
2024-05-10 bungeman@google.com [pdf] Pass typeface, not data, to
subsetter
2024-05-10 kjlubick@google.com Add SkSVGFeMerge.h to public.bzl
2024-05-10 penghuang@chromium.org graphite: add fSetBackendLanels in
ContextOptions
2024-05-10 kjlubick@google.com Reduce timeout threshold for Mac11 tasks
2024-05-10 egdaniel@google.com Revert "GraphiteDawn: use dawn's
LoadResolveTexture extension."
2024-05-10 michaelludwig@google.com Reland "[graphite] Enable basic
texture reuse within a Recording"
2024-05-10 fmalita@chromium.org [svg] Add FEMerge support
2024-05-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from e5cd267adee1 to 4a16c5226357 (1 revision)
2024-05-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK
Tool from 14a9c90d4ad7 to 54d46e9c6097
2024-05-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 996de99d5bf7 to 14a9c90d4ad7 (7 revisions)
2024-05-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 23344086b8f1 to 94ceac3a5f35 (24 revisions)
2024-05-10 michaelludwig@google.com [graphite] Delete redundant
availability check in ScratchResourceManager
2024-05-09 lehoangquyen@chromium.org GraphiteDawn: use dawn's
LoadResolveTexture extension.
2024-05-09 armansito@google.com [graphite] Do not send extremely large
shapes to compute path atlas
2024-05-09 michaelludwig@google.com Revert "[graphite] Enable basic
texture reuse within a Recording"
2024-05-09 michaelludwig@google.com [graphite] Enable basic texture
reuse within a Recording
2024-05-09 kjlubick@google.com Add module for skottie utils
2024-05-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from a99b3c8f05ae to e5cd267adee1 (6 revisions)
2024-05-09 nicolettep@google.com [graphite] Query backends for
additional sampler desc information
2024-05-09 jamesgk@google.com Revert "[graphite] Disable analytic blur
for rrects"
2024-05-09 jvanverth@google.com [graphite] Adjust the distinction
between Paint and Flush timing
2024-05-09 bungeman@google.com Roll FreeType from f42ce255 to a4642422
(30 commits)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brianosman@google.com ,egdaniel@google.com,rmistry@google.com,zra@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-10 11:37:02 -07:00
Chinmay Garde
75217e99fc
[Impeller] Document how to do basic rendering in Impeller. ( flutter/engine#52703 )
...
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2024-05-10 10:54:12 -07:00
gaaclarke
174983b9d7
[impeller] adds experimental canvas docstring ( flutter/engine#52710 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-05-10 10:49:02 -07:00
Byoungchan Lee
2f2c54fa39
Roll third_party/freetype2 from 3bea27612 to af4c2d86d (2 revisions) ( flutter/engine#52689 )
...
3bea27612..af4c2d86ddaniel.l@hpcnt.com Fix macro redefinition warning in macOS
2023-05-04 het@google.com Add support for woff and woff2 fonts
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-05-10 10:47:59 -07:00
skia-flutter-autoroll
b705af88c3
Roll Skia from 2813bc21202e to c7cd1e9690d1 (6 revisions) ( flutter/engine#52701 )
...
https://skia.googlesource.com/skia.git/+log/2813bc21202e..c7cd1e9690d1
2024-05-09 bungeman@google.com Roll HarfBuzz from c053e8f2 to b74a7ecc
(40 commits)
2024-05-09 bungeman@google.com [freetype] Roll script to check for
shallow clone
2024-05-09 johnstiles@google.com Optimize WGSL swizzled assignments.
2024-05-09 johnstiles@google.com Fix signedness of format string.
2024-05-09 bwils@google.com First pass updating our sample skotties to
be compliant with the spec.
2024-05-09 bungeman@google.com [harfbuzz] Roll script handling of
duplicates
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brianosman@google.com ,egdaniel@google.com,rmistry@google.com,zra@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-10 10:19:22 -07:00
skia-flutter-autoroll
ae61fe72c4
Roll Fuchsia Linux SDK from RDVdjRvCxkJh2NLxS... to NbCi2ETfLHPLLB-JV... ( flutter/engine#52702 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-10 10:18:33 -07:00
gaaclarke
2d6f998e85
Fixed constness of display list storage. ( flutter/engine#52705 )
...
Previously you could have a const DisplayListStorage and still have
access to editing it. This fixes that.
testing: refactor only
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-05-10 09:10:33 -07:00
Zachary Anderson
9d6bf0d3b0
Revert "Various documentation improvements ( #52600 )" ( flutter/engine#52709 )
...
Reverts flutter/engine#52623
Reason for revert is noted on the PR.
2024-05-10 07:54:51 -07:00
skia-flutter-autoroll
2251766b0f
Manual roll Dart SDK from b7cad2edae4b to 01121c008f4d (3 revisions) ( flutter/engine#52706 )
...
Manual roll requested by zra@google.com
https://dart.googlesource.com/sdk.git/+log/b7cad2edae4b..01121c008f4d
2024-05-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.5.0-141.0.dev
2024-05-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.5.0-140.0.dev
2024-05-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.5.0-139.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-10 07:02:23 -07:00
Kihara, Takuya
fbab4c0057
[iOS] Fix App crash when use WebView with iOS VoiceOver ( flutter/engine#52484 )
...
This PR fix the issue [flutter/flutter
#140528 ](https://github.com/flutter/flutter/issues/140528 ).
This fix cleans up declarations regarding `retain` and `release`.
`flutterAccessibilityContainer` needs to be managed in
`FlutterPlatformViews.mm`, and problems will occur if `retain` or
`release` is performed in `SemanticsObject.mm`.
This fix is checked by the `testFlutterPlatformViewSemanticsContainer`
function in the `SemanticsObjectTest.mm`.
The result is not changed.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-05-09 20:40:41 -07:00
Ian Hickson
f0f469735d
Various documentation improvements ( #52600 ) ( flutter/engine#52623 )
...
This is a reland of https://github.com/flutter/engine/pull/52600 which
was reverted in https://github.com/flutter/engine/pull/52607 due to a
typo.
2024-05-09 15:33:52 -07:00
Yegor
de5ce1e4dc
[web] scale semantic text elements to match the desired focus ring size ( flutter/engine#52586 )
...
Due to https://g-issues.chromium.org/issues/40875151?pli=1&authuser=0
and a lack of an ARIA role for plain text nodes (after the removal of
`role="text"` in WebKit recently), there is no way to customize the size
of the screen reader focus ring for a plain text element. The focus ring
always tightly hugs the text itself.
A workaround implemented in this PR is to match the size of the text
exactly to the desired focus ring size. This is done by measuring the
size of the text in the DOM, then scaling it both vertically and
horizontally to match the size requested by the framework for the
corresponding semantics node.
To avoid serious performance penalty, the following optimizations were
included:
- Nodes that are satisfiable by just an `aria-label` do not need this
workaround, and are skipped.
- Nodes that must use DOM text (e.g. links, buttons) but have ARIA roles
that size them based on the element, do not need this workaround, and
are skipped.
- Nodes that do need the workaround are first measured in a single
batch, incurring only one page reflow. Then they are all updated in a
single batch without taking any further DOM measurements. This ensures
that no matter how many text spans are rendered, only one reflow is
needed to measure them all.
- Nodes that need the workaround cache the previous label and size, and
if they do not change, the size is not updated.
Other changes:
- Rename `LeafLabelRepresentation` to `LabelRepresentation`, because
labels also apply to non-leaf nodes (e.g. `aria-label` may be applied to
a container).
- Rename `labelRepresentation` to `preferredLabelRepresentation`,
because a particular label representation cannot be guaranteed. A node
that currently looks like a leaf text node may turn out to be an empty
container, and after adding children to it must switch from using DOM
text to an `aria-label`. Therefore, role manager only specify a
preference, but `LabelAndValue` ultimately decides which representation
is usable.
- Introduce `void initState()` in `PrimaryRoleManager` to be used for
one-time initialization of state and DOM structure after all objects
that are in a one-to-one relationship with each other create all the
references needed to establish that relationship (`PrimaryRoleManager`,
`SemanticsObject`, `element`, `owner`, etc). This is not available at
the time the constructors are called.
Fixes https://github.com/flutter/flutter/issues/146774 .
2024-05-09 15:23:22 -07:00
gaaclarke
06ee68755c
[Impeller] Adds impeller display list golden tests ( flutter/engine#52690 )
...
issue https://github.com/flutter/flutter/issues/146941
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-05-09 13:34:46 -07:00
Zachary Anderson
3f5dbd3c2a
Roll buildroot to 70a42312a688 ( flutter/engine#52675 )
...
Roll buildroot to pick up https://github.com/flutter/buildroot/pull/854
2024-05-09 13:08:47 -07:00
