DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
87,954 Commits 882 Branches 1,069 Tags
Commit Graph

87954 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
walley892
e435edfbcd
Account for vec3 padding in Metal (#181563) 
Re-landing of https://github.com/flutter/flutter/pull/181340
incorporating https://github.com/flutter/flutter/pull/181550.

Vec3 uniforms on the metal backend are vec4-aligned. This PR accounts
for that padding.

---------

Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
 2026-01-28 20:50:23 +00:00
Ben Konyi
b6fa57dd2e
[ Tool / Engine ] Cleanup x86 references (#181152) 
Fixes https://github.com/flutter/flutter/issues/170142
 2026-01-28 20:05:26 +00:00
yim
f1a74f4e8f
Fix the issue on macOS where, after a hot restart with multiple windows, unresponsive windows are left behind. (#180287) 
There is currently an issue with multiple windows on macOS: after a hot
restart, new windows are created, but the original windows are not
closed. You can reproduce this by running examples/multiple_windows and
then performing a hot restart.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-01-28 20:04:17 +00:00
engine-flutter-autoroll
6d4aea2a1d
Roll Skia from 675444e94bc9 to 8e09f8a82251 (7 revisions) (#181606) 
https://skia.googlesource.com/skia.git/+log/675444e94bc9..8e09f8a82251

2026-01-28 borenet@google.com [infra] Pixel10 devices have been updated
2026-01-28 bungeman@google.com Fix bounds check for SkIntToFDot6
2026-01-28 michaelludwig@google.com Revert "[graphite] Merge
CommandBuffer::trackResource and ::trackCommandBufferResource"
2026-01-28 kjlubick@google.com Remove unused #defines
2026-01-28 kjlubick@google.com Disable legacy VMA behavior for Graphite
2026-01-28 kjlubick@google.com Disable legacy VMA behavior for Ganesh
2026-01-28 ccameron@chromium.org skhdr::AdaptiveGlobalToneMap: Add
validation and tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-28 20:03:12 +00:00
engine-flutter-autoroll
fef3518fb1
Roll Packages from e37af1148f45 to 1cb2148ade16 (5 revisions) (#181608) 
e37af1148f...1cb2148ade

2026-01-27 engine-flutter-autoroll@skia.org Roll Flutter from
716564969037 to dfd92b773219 (22 revisions) (flutter/packages#10914)
2026-01-27 magder@google.com [shared_preferences_foundation] Migrate
XCTest to Swift Testing (flutter/packages#10766)
2026-01-27 magder@google.com [pigeon] Migrate XCTest to Swift Testing
(flutter/packages#10905)
2026-01-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
8b872868494e to bd7a4a6b5576 (6 revisions) (flutter/packages#10913)
2026-01-27 47866232+chunhtai@users.noreply.github.com [ci] Add post
release label to sync_release_pr workflow (flutter/packages#10864)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-28 18:44:25 +00:00
John "codefu" McDole
588d429c65
fix: swap app and engine version in vk::ApplicationInfo (#181432) 
The driver on PIxel 10 requires Flutter to set the `engine` version to
something higher than 1.0. We had previous set the application version
without effect. With this change, I see we can get a valid vulkan
context.

- ran some testing against reported errors (saw none)
- compiled and ran wonderous with validation layers (runs)
- still researching 

towards: #179812


> On a pixel 10, the Vulkan engine version must be bumped up past 1.0
and any other additional checks gating Vulkan removed. It must be
confirmed that Impeller is able to create a Vulkan context.

Pixel 10 gets a Vulkan context with just the engine version bump.

> The usual sample applications must render accurately.

wonderous and failing code passes and renders correctly

> The reduced test cases in the internal doc must be tested.

it does.

> If testing is successful, the engine version update may be committed.
This is necessary for enabling Vulkan on Pixel 10 but not sufficient to
ensure stability of newer Vulkan enabled Impeller applications on Pixel
10 devices that have not yet been updated.

This PR does that.

> Impeller must detect the driver version and self-reject Vulkan on
device older than the current Pixel 10 GPU driver version. The IHV
reports that a safe conservative driver version is >= 25.1 and any
verification must happen on versions past this. Impeller should still
base its checks on the driver version that we verify correctness on.
What we have today works well and it is not advised to introduce
instability for the sake of enabling Vulkan on this device.

Done - driver_version appears to be a build number, so monotonically
increasing.
 2026-01-28 18:34:17 +00:00
gaaclarke
0c2d316b15
Adds impeller backend to skia gold client (#181503) 
141886358e
made dart tests run against metal as well as vulkan. At the time there
was no reported error. I suspect the vulkan and metal results are
clobbering each other though since the backend was not part of the
dimensions.

test exempt: is test

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-01-28 17:04:33 +00:00
Mouad Debbar
f9d489f9ea
Remove chrome_and_driver dependency where it's not needed (#178174) 
Similar to https://github.com/flutter/flutter/pull/178078
 2026-01-28 16:43:39 +00:00
John "codefu" McDole
2260544e14
chore: Windows_mokey basic_material_app_win__compile !bringup (#180985) 
This test has been green in staging for the last 200 runs at least

Co-authored-by: Ben Konyi <bkonyi@google.com>
 2026-01-28 16:40:17 +00:00
Mohellebi Abdessalem
0bd69d2084
Fix generating both settings.gradle and settings.gradle.kts for plugins (#181592) 
Fixes #181565
Fixes #142685
this was a side effect from #173993

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-01-28 16:09:28 +00:00
engine-flutter-autoroll
439321be30
Roll Skia from 6614f89de521 to 675444e94bc9 (3 revisions) (#181587) 
https://skia.googlesource.com/skia.git/+log/6614f89de521..675444e94bc9

2026-01-28
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 60d944528fcf to a021d3e26e2d (10 revisions)
2026-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 7d18711a101b to 2d0c30fb2b6a (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-28 10:19:44 +00:00
Huy
8268427c5e
Fix todayBorder todayBorder color is incorrectly overridden by todayForegroundColor in CalendarDatePicker (#178792) 
- Fix https://github.com/flutter/flutter/issues/177911
- In this PR:
- Avoid auto-overriding border side color with `dayForegroundColor` when
users specify an explicit border color
    - Improve `todayBorder` documentation to clarify cases can happen.
- Add an opacity check: this is because if we don't respect/specify an
explicit border color, we still need to keep enabled/disabled states
(state-aware) that `dayForegroundColor` always does:


de3f804590/packages/flutter/lib/src/material/date_picker_theme.dart (L1174)

So we need a fallback compatibility here:

```dart
final bool hasCustomBorderColor =
        datePickerTheme.todayBorder != null && datePickerTheme.todayBorder?.color.opacity != 0.0;
    final BorderSide todayBorderSide = hasCustomBorderColor
        ? datePickerTheme.todayBorder!
        : (datePickerTheme.todayBorder ?? defaults.todayBorder!).copyWith(
            color: dayForegroundColor,
          );
```

- Added 3 tests in `calendar_date_picker_test.dart‎`.
- Update test data in `date_picker_theme_test.dart`: Updated todayBorder
from `BorderSide(width: 3)` to `BorderSide(width: 3, color:
Color(0x00000000))` to maintain backward compatible behavior in tests:
after changing color to transparent, it should fall back to
`todayForegroundColor`. This is because the test's real purpose was to
verify theme properties work, and it was expecting foreground color
(which is the bug reported).

<details open>
<summary>Demo</summary>

| Before | After |
| --------------- | --------------- |
<img width="400"
src="https://github.com/user-attachments/assets/59c70071-d278-46f8-a566-40589cf01f9a">
| <img width="400"
src="https://github.com/user-attachments/assets/a4309fb0-7360-4c11-a9c1-dd1f1ebf9190">
</details>

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Signed-off-by: huycozy <huy@nevercode.io>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
 2026-01-28 08:27:34 +00:00
engine-flutter-autoroll
d7afdcb63b
Roll Skia from 8f1695a4b328 to 6614f89de521 (2 revisions) (#181583) 
https://skia.googlesource.com/skia.git/+log/8f1695a4b328..6614f89de521

2026-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from d396079330da to 8556bb0e87c8 (8 revisions)
2026-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 2a05902cae1a to e427e28a231f (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-28 07:55:33 +00:00
Kishan Rathore
e4925ec393
feat: add RoundedSuperellipseInputBorder (#177220) 
# Whats new

* Add RoundedSuperellipseInputBorder

fixes: #176987 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2026-01-28 06:53:58 +00:00
engine-flutter-autoroll
4783b5a8f1
Roll Dart SDK from 38e351498549 to f10dcbfca98f (2 revisions) (#181582) 
https://dart.googlesource.com/sdk.git/+log/38e351498549..f10dcbfca98f

2026-01-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-80.0.dev
2026-01-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-79.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-28 06:46:26 +00:00
engine-flutter-autoroll
ff625c80d8
Roll Skia from f424d58e37a3 to 8f1695a4b328 (6 revisions) (#181577) 
https://skia.googlesource.com/skia.git/+log/f424d58e37a3..8f1695a4b328

2026-01-28
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-01-27 kjlubick@google.com Replace SK_FONT_FILE_PREFIX with
constexpr
2026-01-27 bungeman@google.com Remove SK_SUPPORT_MUTABLE_PATHEFFECT
2026-01-27 ccameron@chromium.org Remove skhdr::Agtm interface
2026-01-27 michaelludwig@google.com [graphite] Re-arrange unassigned,
B2F stencil bits to be drawn later
2026-01-27 michaelludwig@google.com [graphite] Fix InnerFillTest to
account for dst read flushes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-28 03:40:28 +00:00
Mohellebi Abdessalem
2a753c2d9c
Remove unused code paths in PlatformViewsController.java (#181393) 
while creating #181330 
it was discovered that the `enforceMinimumAndroidApiVersion` was used to
ensure that we are in a specific API level and throw an error if not ,
since the min API level is 24 now , that code can be removed
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-01-28 03:24:28 +00:00
Kishan Rathore
3b449c84d3
feat: add onEnd to AnimatedCrossFade (#181455) 
feat: add onEnd to AnimatedCrossFade
fixes: #180682 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2026-01-28 02:26:24 +00:00
Harry Terkelsen
1205220797
Don't pass bounds to saveLayer call when painting ImageFilter (#181353) 
This causes the filter to apply incorrectly with certain TileModes in
Skwasm.

Fixes https://github.com/flutter/flutter/issues/178028

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-01-28 01:04:31 +00:00
Luan Nico
cda9a5f9d5
test: Clarify failure messages on gestures/debug_test.dart (#181109) 
Clarify failure messages on `gestures/debug_test.dart`.

Extracted from https://github.com/flutter/flutter/pull/176968 in an
attempt to keep it simpler.
This just adds a custom error message to all asserts on the `Gesture
details debugFillProperties` test, making it clear _which_ event broke
the test. While we don't expect tests to break, while developing, this
can save several minutes of guesswork.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
 2026-01-28 00:41:06 +00:00
engine-flutter-autoroll
18c05495a1
Roll Fuchsia Linux SDK from akraNGn2lw4T1msgZ... to adhoq9ouVRh0xzkm3... (#181571) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-27 23:45:26 +00:00
engine-flutter-autoroll
e3a91e59d2
Roll Dart SDK from 4c7cb0a1d07d to 38e351498549 (4 revisions) (#181570) 
https://dart.googlesource.com/sdk.git/+log/4c7cb0a1d07d..38e351498549

2026-01-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-78.0.dev
2026-01-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-77.0.dev
2026-01-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-76.0.dev
2026-01-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-75.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-27 23:33:03 +00:00
Ahmed Mohamed Sameh
a01a411a91
Make sure that an AnimatedPadding doesn't crash in 0x0 environment (#181235) 
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the AnimatedPadding
widget.
 2026-01-27 23:05:02 +00:00
Ahmed Mohamed Sameh
7a84ebcc57
Make sure that an ImageFiltered doesn't crash at 0x0 environment (#181067) 
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the ImageFiltered
widget.

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
 2026-01-27 22:13:53 +00:00
Jenn Magder
946e2b10dd
Marks firebase_release_smoke_test to be unflaky (#181308) 
Tests have not failed for [50 consecutive
runs](https://data.corp.google.com/sites/dash_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20firebase_release_smoke_test%22).

Fixes https://github.com/flutter/flutter/issues/176042
 2026-01-27 22:12:05 +00:00
Kazbek Sultanov
31949a0037
Fix remove material import box decoration test (#181253) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Removed material import in `box_decoration_test.dart`. Replaces colors
to consts.

Part of https://github.com/flutter/flutter/issues/177415
        
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md


[![talabat.com](https://img.shields.io/badge/talabat.com-contributions-FF5A00?style=flat&logo=flutter&logoColor=white)](https://www.talabat.com)
[![Talabat Flutter
PRs](https://img.shields.io/badge/Talabat_Flutter_PRs-10%20merged-97ca00?style=flat&logo=flutter&logoColor=white)](https://github.com/search?q=org%3Aflutter+talabat&type=pullrequests)
 2026-01-27 22:12:05 +00:00
engine-flutter-autoroll
2fab4df1f8
Roll Skia from c2754838b077 to f424d58e37a3 (8 revisions) (#181564) 
https://skia.googlesource.com/skia.git/+log/c2754838b077..f424d58e37a3

2026-01-27 jmbetancourt@google.com Revert "introduce new SkLogPriority
and logging macros to skia"
2026-01-27 bungeman@google.com Remove SK_DISABLE_LEGACY_SHADERCONTEXT
2026-01-27 jmbetancourt@google.com introduce new SkLogPriority and
logging macros to skia
2026-01-27 kjlubick@google.com Remove mipmaps from SkBitmap's
implementation
2026-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 54fcc5faac16 to 60d944528fcf (2 revisions)
2026-01-27 kjlubick@google.com Reland "Remove tools/testrunner Bazel
experiment"
2026-01-27 michaelludwig@google.com [graphite] Fix adding inner fill
draw with analytic coverage
2026-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from d22ecf57f2ee to 2a05902cae1a (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-27 22:10:06 +00:00
Ahmed Mohamed Sameh
2e64b79fd9
Make sure that an AnimatedAlign doesn't crash in 0x0 environment (#181361) 
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the AnimatedAlign
widget.
 2026-01-27 22:10:04 +00:00
Ahmed Mohamed Sameh
1c0ccb5ce6
Make sure that an ImageIcon doesn't crash in 0x0 environment (#181099) 
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the ImageIcon widget.

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
 2026-01-27 22:10:03 +00:00
Ahmed Mohamed Sameh
d93e2d4b82
Make sure that an AnimatedContainer doesn't crash in 0x0 environment (#181198) 
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the AnimatedContainer
widget.
 2026-01-27 22:08:04 +00:00
Ahmed Mohamed Sameh
eca46191b0
Make sure that an AnimatedRotation doesn't crash in 0x0 environment (#181486) 
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the AnimatedRotation
widget.

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
 2026-01-27 22:08:04 +00:00
Ahmed Mohamed Sameh
d36957f411
Make sure that an AnimatedPositionedDirectional doesn't crash in 0x0 … (#181451) 
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
AnimatedPositionedDirectional widget.

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
 2026-01-27 22:08:04 +00:00
Jackson Gardner
2c74ab162e
Merge changelog for 3.38.8. (#181558) 
Co-authored-by: Reid Baker <1063596+reidbaker@users.noreply.github.com>
 2026-01-27 19:24:23 +00:00
auto-submit[bot]
dfd92b7732
Reverts "Fixes metal vec3 uniform padding (#181340)" (#181552) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#181340
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: golden failures and known logical errors that
didn't have test coverage
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: gaaclarke
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {walley892, b-luk}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
fixes https://github.com/flutter/flutter/issues/180873

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2026-01-27 17:25:47 +00:00
Reid Baker
d7d35fdd9f
Change update_engine_version documenation (#181508) 
Fixes #181404

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2026-01-27 16:09:28 +00:00
engine-flutter-autoroll
4bff775cc7
Roll Packages from e712bfad5c2b to e37af1148f45 (7 revisions) (#181544) 
e712bfad5c...e37af1148f

2026-01-27 sigurdm@google.com Replace pub run with dart run
(flutter/packages#10849)
2026-01-26 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.squareup.okhttp3:okhttp from 5.3.1 to 5.3.2 in
/packages/espresso/android (flutter/packages#10502)
2026-01-26 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.datastore:datastore from 1.1.7 to 1.2.0 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#10506)
2026-01-26 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.activity:activity from 1.11.0 to 1.12.2 in
/packages/image_picker/image_picker_android/android
(flutter/packages#10662)
2026-01-26 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.maps.android:android-maps-utils from
3.20.1 to 4.0.0 in
/packages/google_maps_flutter/google_maps_flutter_android/android
(flutter/packages#10888)
2026-01-26 engine-flutter-autoroll@skia.org Manual roll Flutter from
def9ca93e2e2 to 716564969037 (6 revisions) (flutter/packages#10903)
2026-01-26 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.android.gms:play-services-maps from 19.2.0
to 20.0.0 in
/packages/google_maps_flutter/google_maps_flutter_android/android
(flutter/packages#10889)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-27 16:05:28 +00:00
Jason Simmons
4d0b927b02
Roll FreeType to 2.14.1 (#181428) 
Fixes https://github.com/flutter/flutter/issues/181492
 2026-01-27 14:27:36 +00:00
engine-flutter-autoroll
bece46a361
Roll Skia from 566d202962d3 to c2754838b077 (3 revisions) (#181536) 
https://skia.googlesource.com/skia.git/+log/566d202962d3..c2754838b077

2026-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 80d15542bf70 to 7d18711a101b (9 revisions)
2026-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 9a99124d0a26 to d396079330da (9 revisions)
2026-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from c90f051cc986 to d22ecf57f2ee (15 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-27 12:20:38 +00:00
Marijua ރ
248bc79d48
[Material] modernize time picker components with Dart 3 switch expressions (#181356) 
Following up on #181041, I took another look at `time_picker.dart` for
any remaining switch statements that could be modernized.

I found that `_timeSelectorSeparatorValue` and the `height` calculation
in `_TimeSelectorSeparator` were great candidates. By using logical OR
patterns and inlining the assignments, I was able to convert them into
clean switch expressions. The logic remains exactly the same, but the
boilerplate is gone.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA]. (I will sign it once the bot prompts me)
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-01-27 08:38:29 +00:00
engine-flutter-autoroll
c150d75032
Roll Skia from 55a87b50a368 to 566d202962d3 (1 revision) (#181528) 
https://skia.googlesource.com/skia.git/+log/55a87b50a368..566d202962d3

2026-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from b0c7e1fb76fc to 374652a342e0 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,bwils@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-27 07:02:27 +00:00
engine-flutter-autoroll
0a3828e801
Roll Dart SDK from f55d4538469a to 4c7cb0a1d07d (2 revisions) (#181526) 
https://dart.googlesource.com/sdk.git/+log/f55d4538469a..4c7cb0a1d07d

2026-01-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-74.0.dev
2026-01-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-73.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-27 06:12:26 +00:00
Sigurd Meldgaard
c909c5801b
Replace pub run mentions with dart run (#181317) 
Following up on https://github.com/dart-lang/pub/issues/4737, this PR
replaces deprecated `pub run` commands with `dart run`.
 2026-01-27 05:47:22 +00:00
engine-flutter-autoroll
055f3e5bf5
Roll Skia from 1a15ed6b17f2 to 55a87b50a368 (1 revision) (#181523) 
https://skia.googlesource.com/skia.git/+log/1a15ed6b17f2..55a87b50a368

2026-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 10e26d62e399 to 54fcc5faac16 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,bwils@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-27 04:49:21 +00:00
Jenn Magder
a4561432d0
Marks linux_chrome_dev_mode to be unflaky (#181352) 
According to
https://github.com/flutter/flutter/issues/173696#issuecomment-3522821072
this should no longer be flaking and should not be `bringup: true`.
 2026-01-27 00:21:22 +00:00
engine-flutter-autoroll
f101e9ef8e
Roll Skia from f2c1aa140b79 to 1a15ed6b17f2 (2 revisions) (#181514) 
https://skia.googlesource.com/skia.git/+log/f2c1aa140b79..1a15ed6b17f2

2026-01-26 bungeman@google.com Allow users to set
SK_ENABLE_LEGACY_SHADERCONTEXT
2026-01-26 bungeman@google.com Remove
SK_DISABLE_LEGACY_NONCONST_SERIAL_PROCS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,bwils@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-27 00:13:21 +00:00
Christoph Prenissl
cba43b9d3f
Fix Range Slider issue where indescrete ranges lead to out of range r… (#181082) 
*These change fixes a problem when during a drag that took the
minThumbSepartionValue into account led to a value outside of the
allowed range of (0.0, 1.0) which caused a exception in rebuild where
assert is used to check for that range.*

Fixes issue #180984 

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
 2026-01-27 00:03:33 +00:00
engine-flutter-autoroll
eeb0544f6d
Roll Dart SDK from ba23b5ed0a97 to f55d4538469a (2 revisions) (#181512) 
https://dart.googlesource.com/sdk.git/+log/ba23b5ed0a97..f55d4538469a

2026-01-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-72.0.dev
2026-01-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-71.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-26 23:23:23 +00:00
Ivone Djaja
a1327012f4
Add alignment to SizeTransition (#177895) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Remove `axisAlignment` and add `alignment` to fix
https://github.com/flutter/flutter/issues/19850

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2026-01-26 21:37:22 +00:00
engine-flutter-autoroll
26bdd372b7
Roll Fuchsia Linux SDK from T4qTEa3T5CCSCIoJY... to akraNGn2lw4T1msgZ... (#181509) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-26 21:35:04 +00:00
engine-flutter-autoroll
6b78264d32
Roll Skia from be280d242a60 to f2c1aa140b79 (3 revisions) (#181504) 
https://skia.googlesource.com/skia.git/+log/be280d242a60..f2c1aa140b79

2026-01-26 kjlubick@google.com Revert "Remove tools/testrunner Bazel
experiment"
2026-01-26 nbilling@google.com [graphite] Merge
CommandBuffer::trackResource and ::trackCommandBufferResource
2026-01-26 michaelludwig@google.com [wgsl] Use f16 for half when not
forced to high precision

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,bwils@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2026-01-26 21:07:08 +00:00