engine-flutter-autoroll
dedbb399b2
Roll Flutter Engine from 576833873c15 to fb2a9c20141e (1 revision) ( #137900 )
...
576833873c...fb2a9c2014flutter/engine#47687 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-04 18:41:32 +00:00
engine-flutter-autoroll
5e3b3e2570
Roll Flutter Engine from 25f5e285f874 to 576833873c15 (1 revision) ( #137898 )
...
25f5e285f8...576833873cgodofredoc@google.com Fix symbols upload (flutter/engine#47669 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-04 17:43:13 +00:00
engine-flutter-autoroll
9085183d4c
Roll Flutter Engine from 7282a5d94ab6 to 25f5e285f874 (2 revisions) ( #137892 )
...
7282a5d94a...25f5e285f8skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8tJt8KJzTzbwwQlUE... to SmJ_8HFjjm55T4ijL... (flutter/engine#47682 )
2023-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 5GLArzquQ4eL56vdy... to ftLug7WGUYrtgHyy6... (flutter/engine#47681 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 8tJt8KJzTzbw to SmJ_8HFjjm55
fuchsia/sdk/core/mac-amd64 from 5GLArzquQ4eL to ftLug7WGUYrt
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-04 11:19:25 +00:00
engine-flutter-autoroll
46d4b11f46
Roll Flutter Engine from b66a87626300 to 7282a5d94ab6 (2 revisions) ( #137887 )
...
b66a876263...7282a5d94askia-flutter-autoroll@skia.org Roll Dart SDK from b9ae53ac4663 to 96664852accc (1 revision) (flutter/engine#47679 )
2023-11-04 skia-flutter-autoroll@skia.org Roll Dart SDK from c52fb4fe2d86 to b9ae53ac4663 (1 revision) (flutter/engine#47674 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-04 07:55:06 +00:00
Kostia Sokolovskyi
e8d9d9bfd5
HeroController should dispatch creation and disposal events. ( #137835 )
2023-11-03 20:42:47 -07:00
engine-flutter-autoroll
0e7ed92988
Roll Flutter Engine from ec20731de6ff to b66a87626300 (1 revision) ( #137877 )
...
ec20731de6...b66a876263kustermann@google.com Fix incorrect C++ return value of PictureRecorder::endRecording() (flutter/engine#47645 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-04 00:04:15 +00:00
Alex Isaienko
b5fb6652d6
InheritedElement.removeDependent() ( #129210 )
...
Call the `dependency.removeDependent(this)` instead of `dependency._dependents.remove(this)` inside the `Element.deactivate()`. This allows `InheritedElements` to know when they can release resources associated with a given dependent `Element`.
Fixes #129207
2023-11-03 23:27:21 +00:00
Michael Goderbauer
8a0f9118ea
Remove unused generic type from BottomSheet ( #137791 )
...
Fixes https://github.com/flutter/flutter/issues/137424 .
The generic type argument was unused.
2023-11-03 22:25:37 +00:00
engine-flutter-autoroll
6f5ca8542c
Roll Flutter Engine from 035740c1f90e to ec20731de6ff (2 revisions) ( #137872 )
...
035740c1f9...ec20731de6skia-flutter-autoroll@skia.org Roll Dart SDK from 529fcd5bdffc to c52fb4fe2d86 (1 revision) (flutter/engine#47668 )
2023-11-03 jacksongardner@google.com Bundle flutter.js via esbuild (flutter/engine#47573 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 22:24:02 +00:00
Daco Harkes
7634609062
Pin dart-lang/native dependencies ( #137601 )
...
Pin the dependencies from dart-lang/native to a specific version during testing (rather than having them auto-upgrade during pub resolution). This will prevent tests using the template to start failing if a bad version is published to pub.
Closes: https://github.com/flutter/flutter/issues/137418
Also bumps dep in flutter_tools.
2023-11-03 22:16:04 +00:00
Chris Bracken
4455e86d90
Send caret rect to embedder on selection update ( #137863 )
...
Background: In the framework, the position of the caret rect is updated on each cursor position change such that if the user initiates composing input, the current cursor position can be used for the first character until the composing rect can be sent.
Previously, no update was sent on selection changes, on the assumption that the most recent cursor position will remain the correct position for the duration of the selection. While this is the case for forward selections, it is an incorrect assumption for reversed selections, where selection.base > selection.extent.
We now update the cursor position during selection changes such that the cursor position sent to the embedder is always the position at which next text input would occur. This is the start position of the selection or min(selection.baseOffset, selection.extentOffset).
Issue: https://github.com/flutter/flutter/issues/137677
2023-11-03 22:09:09 +00:00
engine-flutter-autoroll
71db445c37
Roll Flutter Engine from 677040f10f65 to 035740c1f90e (4 revisions) ( #137871 )
...
677040f10f...035740c1f9skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ho9FqsUD0hxh0b8to... to 8tJt8KJzTzbwwQlUE... (flutter/engine#47666 )
2023-11-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from y-hqwYkPPVT6RwmAS... to 5GLArzquQ4eL56vdy... (flutter/engine#47667 )
2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from c0ca9f2fd828 to 77aeee3b81a5 (1 revision) (flutter/engine#47663 )
2023-11-03 flar@google.com [Impeller] Remove Rect field accesses from aiks subdirectory (flutter/engine#47628 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ho9FqsUD0hxh to 8tJt8KJzTzbw
fuchsia/sdk/core/mac-amd64 from y-hqwYkPPVT6 to 5GLArzquQ4eL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 21:37:58 +00:00
Chris Bobbe
e7f99821cc
Tooltip docs: Recommend setting preferBelow to false in theme ( #135879 )
...
As discussed at https://github.com/flutter/flutter/pull/133007#issuecomment-1743916183 , this is a docs change meant to help people in the absence of a fix for #133006 , which is being closed as WONTFIX.
2023-11-03 20:18:36 +00:00
engine-flutter-autoroll
c51022bc40
Roll Flutter Engine from f363a6e5e093 to 677040f10f65 (2 revisions) ( #137861 )
...
f363a6e5e0...677040f10fskia-flutter-autoroll@skia.org Roll Skia from ee6dbb4e2592 to c0ca9f2fd828 (1 revision) (flutter/engine#47660 )
2023-11-03 zanderso@users.noreply.github.com Move //third_party/benchmark to //flutter/third_party/benchmark (flutter/engine#47652 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 20:14:58 +00:00
auto-submit[bot]
c4ce9479bb
Reverts "[Android] Support Android 34" ( #137865 )
...
Reverts flutter/flutter#137191
Initiated by: camsim99
This change reverts the following previous change:
Original Description:
Adds support for Android 34 in the following ways:
- Bumps integration tests compile SDK versions 33 --> 34
- Bumps template compile SDK version 33 --> 34
- Also changes deprecated `compileSdkVersion` to `compileSdk`
Part of https://github.com/flutter/flutter/issues/134220
2023-11-03 20:14:19 +00:00
Kostia Sokolovskyi
a52f030cda
InkFeature should dispatch creation and disposal events. ( #137793 )
2023-11-03 12:34:16 -07:00
Kostia Sokolovskyi
2369897f09
AppLifecycleListener should dispatch creation and disposal events. ( #137840 )
2023-11-03 12:31:46 -07:00
engine-flutter-autoroll
8375dfdeaa
Roll Flutter Engine from d5ccb5b1b706 to f363a6e5e093 (2 revisions) ( #137858 )
...
d5ccb5b1b7...f363a6e5e0skia-flutter-autoroll@skia.org Roll Skia from 75507da748f9 to ee6dbb4e2592 (1 revision) (flutter/engine#47659 )
2023-11-03 30870216+gaaclarke@users.noreply.github.com [Impeller] removed operator overload (c++ style violation) (flutter/engine#47658 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 19:28:12 +00:00
engine-flutter-autoroll
82c461e0e2
Roll Flutter Engine from 72262a238090 to d5ccb5b1b706 (3 revisions) ( #137857 )
...
72262a2380...d5ccb5b1b7jonahwilliams@google.com [Impeller] add example of testing entity with "real" HAL instead of mocking. (flutter/engine#47631 )
2023-11-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 3c45f68cd7c2 to 529fcd5bdffc (3 revisions) (flutter/engine#47655 )
2023-11-03 zanderso@users.noreply.github.com Reverts specialization constant PR and one change that used it (flutter/engine#47650 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 18:13:30 +00:00
Hans Muller
3479aaba75
Updated the nested navigation NavigationBar example ( #137788 )
...
Updated the NavigationBar API doc that describes
examples/api/lib/material/navigation_bar/navigation_bar.2.dart and made
some cosmetic changes to the example to improve its appearance in
Material 3. Also did a little gratuitous reformatting.
Fixes #136125
2023-11-03 10:46:09 -07:00
engine-flutter-autoroll
dca1f9e5c8
Roll Flutter Engine from 0415a4f5e2a2 to 72262a238090 (2 revisions) ( #137853 )
...
0415a4f5e2...72262a2380godofredoc@google.com Upload debug symbols in engine v2 fuchsia build. (flutter/engine#47626 )
2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from b173066e6f15 to 75507da748f9 (2 revisions) (flutter/engine#47653 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 17:38:46 +00:00
engine-flutter-autoroll
267d5273b8
Roll Flutter Engine from 8531c5935356 to 0415a4f5e2a2 (1 revision) ( #137847 )
...
8531c59353...0415a4f5e2skia-flutter-autoroll@skia.org Roll Skia from e5a6f9e79b0a to b173066e6f15 (1 revision) (flutter/engine#47648 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 16:49:01 +00:00
Jonah Williams
2be9b61309
Roll flutter gallery version forward. ( #137846 )
...
Adds some bottom sheet fixes and resizes oversized images.
2023-11-03 16:43:33 +00:00
engine-flutter-autoroll
ce952e9aa8
Roll Flutter Engine from 43653c5a3ec8 to 8531c5935356 (1 revision) ( #137845 )
...
43653c5a3e...8531c59353matej.knopp@gmail.com Reland: [web] Ensure handled key event is not propagated to IME (flutter/engine#47099 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 16:10:25 +00:00
engine-flutter-autoroll
9d67f9ea80
Roll Packages from 33c2b4e53ad7 to cccf5d24d703 (6 revisions) ( #137841 )
...
33c2b4e53a...cccf5d24d747866232+chunhtai@users.noreply.github.com [go_router] Fixes crashes when dynamically updates routing tables wit⦠(flutter/packages#5242 )
2023-11-02 43054281+camsim99@users.noreply.github.com [camerax] Fix `_getResolutionSelectorFromPreset` NPE (flutter/packages#5287 )
2023-11-02 ybz975218925@live.com [go_router]Fixes the problem what pathParameters is null in redirect when the Router is recreated. (flutter/packages#5258 )
2023-11-02 stuartmorgan@google.com [google_sign_in] Fix Obj-C formatting bug (flutter/packages#5310 )
2023-11-02 goderbauer@google.com Fix mounted checks (flutter/packages#5305 )
2023-11-02 srawlins@google.com [flutter_image] [flutter_markdown] Do not use dynamic in an == operator override (flutter/packages#5298 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 15:42:02 +00:00
Matej Knopp
62bd4874fd
[web] dispatch corresponding keyup events in text editing integrations ( #136874 )
...
https://github.com/flutter/engine/pull/46829 changed event handling
sequence on web so that KeyboardBinding/RawKeyboard handles the text
event first before it reaches IME. That means when dispatching
synthetised events to IME every keydown event must have a corresponding
keyup, otherwise consistency assertions in `KeyboardBindings` are
triggered.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-11-03 14:44:14 +01:00
Binni Goel
8e7fce9813
[leak-tracking] Add more leak tracking in test/painting #3 ( #136170 )
2023-11-03 06:24:38 -07:00
Polina Cherkasova
e1b420cd5b
Upgrade leak_tracker and remove some deps in allow list. ( #137806 )
2023-11-03 06:20:47 -07:00
engine-flutter-autoroll
9c4d155419
Roll Flutter Engine from fc7c3f70c076 to 43653c5a3ec8 (1 revision) ( #137827 )
...
fc7c3f70c0...43653c5a3eskia-flutter-autoroll@skia.org Roll Skia from 3db534b066e0 to e5a6f9e79b0a (1 revision) (flutter/engine#47642 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 09:18:31 +00:00
engine-flutter-autoroll
daad94554b
Roll Flutter Engine from d1b29a1bea0b to fc7c3f70c076 (1 revision) ( #137826 )
...
d1b29a1bea...fc7c3f70c0skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from bhSlAQy4VM3Plrlh4... to y-hqwYkPPVT6RwmAS... (flutter/engine#47641 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from bhSlAQy4VM3P to y-hqwYkPPVT6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 08:40:25 +00:00
engine-flutter-autoroll
35ec26b08f
Roll Flutter Engine from 78e8475ddbd7 to d1b29a1bea0b (2 revisions) ( #137825 )
...
78e8475ddb...d1b29a1beaskia-flutter-autoroll@skia.org Roll Skia from 745825a18444 to 3db534b066e0 (1 revision) (flutter/engine#47640 )
2023-11-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YS7vrarYI-cHvhuBT... to ho9FqsUD0hxh0b8to... (flutter/engine#47638 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from YS7vrarYI-cH to ho9FqsUD0hxh
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 06:54:18 +00:00
engine-flutter-autoroll
ef8deb5d69
Roll Flutter Engine from e3f81ed27cc7 to 78e8475ddbd7 (1 revision) ( #137820 )
...
e3f81ed27c...78e8475ddbskia-flutter-autoroll@skia.org Roll Skia from 525a1487e501 to 745825a18444 (1 revision) (flutter/engine#47636 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 05:11:39 +00:00
engine-flutter-autoroll
284abe2b3d
Roll Flutter Engine from dff66925dcfa to e3f81ed27cc7 (3 revisions) ( #137819 )
...
dff66925dc...e3f81ed27cskia-flutter-autoroll@skia.org Roll Skia from 9f6022736b14 to 525a1487e501 (1 revision) (flutter/engine#47635 )
2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 5b6d295cc39b to 9f6022736b14 (1 revision) (flutter/engine#47633 )
2023-11-03 jonahwilliams@google.com [Impeller] Use specialization constant for blur pipelines decal feature. (flutter/engine#47617 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 04:29:11 +00:00
engine-flutter-autoroll
0b591f2c82
Roll Flutter Engine from 57768e18ed74 to dff66925dcfa (1 revision) ( #137813 )
...
57768e18ed...dff66925dcskia-flutter-autoroll@skia.org Roll Skia from 3b8e2b391d03 to 5b6d295cc39b (1 revision) (flutter/engine#47630 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 02:01:10 +00:00
engine-flutter-autoroll
7802ae1161
Roll Flutter Engine from dd620fcf9af7 to 57768e18ed74 (2 revisions) ( #137811 )
...
dd620fcf9a...57768e18edskia-flutter-autoroll@skia.org Roll Skia from 86d15e651ae0 to 3b8e2b391d03 (1 revision) (flutter/engine#47627 )
2023-11-02 31859944+LongCatIsLooong@users.noreply.github.com Reland "Expose more methods on ui.Paragraph: lines" (#47584 ) (flutter/engine#47623 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 01:14:21 +00:00
Christopher Fujino
b0bc023f24
[flutter_tools] do not try to build tool from dart.sh ( #129186 )
...
Fixes https://github.com/flutter/flutter/issues/121894
2023-11-03 00:42:25 +00:00
engine-flutter-autoroll
1c8c53360d
Roll Flutter Engine from d9b6245d3748 to dd620fcf9af7 (2 revisions) ( #137803 )
...
d9b6245d37...dd620fcf9aflar@google.com [Impeller] Deprecate the exposed Rect fields (flutter/engine#47592 )
2023-11-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from e6df03a57636 to 3c45f68cd7c2 (4 revisions) (flutter/engine#47620 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 23:31:53 +00:00
engine-flutter-autoroll
6821cc6b89
Roll Flutter Engine from ef4ce9294299 to d9b6245d3748 (2 revisions) ( #137799 )
...
ef4ce92942...d9b6245d37skia-flutter-autoroll@skia.org Roll Skia from 66e06117294e to 86d15e651ae0 (1 revision) (flutter/engine#47619 )
2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 94000281b7d6 to 66e06117294e (1 revision) (flutter/engine#47616 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 22:52:56 +00:00
Camille Simon
675fec805a
[Android] Support Android 34 ( #137191 )
...
Adds support for Android 34 in the following ways:
- Bumps integration tests compile SDK versions 33 --> 34
- Bumps template compile SDK version 33 --> 34
- Also changes deprecated `compileSdkVersion` to `compileSdk`
Part of https://github.com/flutter/flutter/issues/134220
2023-11-02 22:18:11 +00:00
engine-flutter-autoroll
15451e49d8
Roll Flutter Engine from 1e2eee05855f to ef4ce9294299 (3 revisions) ( #137795 )
...
1e2eee0585...ef4ce92942skia-flutter-autoroll@skia.org Roll Skia from 306543797674 to 94000281b7d6 (1 revision) (flutter/engine#47614 )
2023-11-02 godofredoc@google.com Remove mirroring workflow from engine. (flutter/engine#47603 )
2023-11-02 athom@google.com Add a temporary fallback to move run_binary_file_analysis.py (flutter/engine#47598 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 21:38:50 +00:00
Reid Baker
4d21a026e5
Protect flutter analyze --suggestions from erroring on missing AGP value. ( #137719 )
...
Fixes #137600
Protect flutter analyze --suggestions from null error when AGP value is missing
Update template with a reference to new agp definition location
Look for AGP version being set in settings.gradle (change to templates happened in dbe0ccd885 (diff-20537fb84ee37894a3f3d9723a06bcf2674290ee25aa83332c2524a1f7546a6d)
2023-11-02 21:14:58 +00:00
Gray Mackall
969a8750a5
Provide more information in 'unsupported class file' gradle error ( #136756 )
...
Fixes https://github.com/flutter/flutter/issues/130808 . Short context is that the migration guide doesn't help when a user has a newer java version than 17, and this tells them how to fix the error in that situation.
This is an alternative to https://github.com/flutter/flutter/pull/131354 , because I think it is a bad idea to introduce branching in how we handle this error with some specialized regexp.
2023-11-02 21:14:56 +00:00
engine-flutter-autoroll
474a8561db
Roll Flutter Engine from b11e318b3690 to 1e2eee05855f (4 revisions) ( #137789 )
...
b11e318b36...1e2eee0585skia-flutter-autoroll@skia.org Roll Skia from 2b3472da9888 to 306543797674 (5 revisions) (flutter/engine#47610 )
2023-11-02 15619084+vashworth@users.noreply.github.com Run tests on either macOS 12 or 13 (flutter/engine#47606 )
2023-11-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 32ukjtetQl4pbXfTw... to bhSlAQy4VM3Plrlh4... (flutter/engine#47611 )
2023-11-02 dnfield@google.com [Impeller] Skia gold for flutter_tester dart tests. (flutter/engine#47066 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 32ukjtetQl4p to bhSlAQy4VM3P
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 20:14:02 +00:00
Sam Rawlins
d796b013b2
Avoid passing a nullable value to potentially non-nullable parameters ( #137359 )
...
Also ignore one case where it is hard to fix.
The code with out the null assertion is legal as per the type signature,
but will throw a runtime exception if the nullable value is null. To
make this exception more explicit, the value must be null-checked before
completing the completer with the value.
The analyzer will soon enforce such checks. See
https://github.com/dart-lang/sdk/issues/53253 .
Fixes https://github.com/flutter/flutter/issues/137294
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-11-02 12:59:23 -07:00
Bartek Pacia
3bc64e8fcf
Chore/gradle remove redundant apply ( #135348 )
...
I'm removing an unneded block of configuration from the `settings.gradle` template. It was introduced by me in #123511 . At that time, I did not know that it's unnecessary, and did not test removing it â sorry about that.
I learned that it's unnecessary recently, when [I asked a question on StackOverflow](https://stackoverflow.com/questions/77073596/whats-the-difference-between-plugins-and-pluginmanagement-plugins-in ). More context there.
2023-11-02 19:48:54 +00:00
engine-flutter-autoroll
5a0ef34dd1
Roll Flutter Engine from 2ec0f74a1e8a to b11e318b3690 (2 revisions) ( #137785 )
...
2ec0f74a1e...b11e318b36skia-flutter-autoroll@skia.org Roll Skia from 70634da5c783 to 2b3472da9888 (5 revisions) (flutter/engine#47608 )
2023-11-02 jonahwilliams@google.com [Impeller] add support for specialization constants. (flutter/engine#47432 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 19:05:49 +00:00
godofredoc
90c73055b2
Migrate api docs from master to main. ( #137726 )
...
This is the first of a series of changes to migrate to remove master-docs-flutter-dev GCP project.
Bug: https://github.com/flutter/flutter/issues/133877
2023-11-02 18:56:47 +00:00
engine-flutter-autoroll
92ea5e0ab3
Roll Flutter Engine from 16d54bda1613 to 2ec0f74a1e8a (1 revision) ( #137777 )
...
16d54bda16...2ec0f74a1eskia-flutter-autoroll@skia.org Roll Skia from 8299245af8a8 to 70634da5c783 (1 revision) (flutter/engine#47604 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-02 18:26:08 +00:00
Michael Goderbauer
b09c70a913
Fix mounted checks ( #137778 )
...
Fixes in preparation for https://dart-review.googlesource.com/c/sdk/+/330561 .
The change referenced above tightens the `use_build_context_synchronously` to ensure that `mounted` is checked on the appropriate `BuildContext` or `State`. This change fixes up the flutter/flutter in preparation of this new enforcement.
2023-11-02 18:21:55 +00:00
Valentin Vignal
f15f2313b9
Fixes DragTarget crash if Draggable.data is null ( #133136 )
...
Makes the `data` parameter of `Draggable` non-nullable.
Fixes https://github.com/flutter/flutter/issues/84816
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-11-02 17:59:16 +00:00
