DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
34,337 Commits 882 Branches 1,069 Tags
Commit Graph

34337 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matan Lurey
dec92d85f2 Better filtering for Android scenario_app runner. (flutter/engine#50937) 
_🍴 'd from https://github.com/flutter/engine/pull/50933, will rebase
when merged._

Closes https://github.com/flutter/flutter/issues/143458.

A picture is a 1000 words:

![Screenshot 2024-02-23 at 7 01
29 PM](https://github.com/flutter/engine/assets/168174/7254b3be-cc49-4bad-ae43-e61ac4a853ad)

This is still noisy, but at least all the output appears to be part of
the execution.

As you recall, the full logs are always available in the
FLUTTER_LOGS_DIR output.
 2024-02-26 11:36:10 -08:00
Jackson Gardner
d1d7c08ce9 Make sure to call setHeightOverride as well on TextStyle and StrutStyle (flutter/engine#50920) 
This fixes https://github.com/flutter/flutter/issues/143877

We apparently need to call `setHeightOverride(true)` on `TextStyle` and `StrutStyle` objects in order to properly apply the height.
 2024-02-26 18:52:59 +00:00
Jackson Gardner
45b0c5ef88 Correctly offset the cull rect of the opacity layer. (flutter/engine#50928) 
This fixes https://github.com/flutter/flutter/issues/140999. Previously, the cull rect would be misplaced causing many elements to not render at all.
 2024-02-26 18:52:56 +00:00
skia-flutter-autoroll
02449cd493 Roll Fuchsia Linux SDK from kLvCWEgbL1VTRW69e... to JCdhkDSFXzHyPuP4I... (flutter/engine#50970) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 18:09:18 +00:00
Zachary Anderson
8a4feb869c [et] Improve the logger for the ninja build, adds a spinner (flutter/engine#50952) 
For https://github.com/flutter/flutter/issues/132807

The spinner is mostly copied from the flutter_tool.
 2024-02-26 09:31:15 -08:00
yaakovschectman
ac3cb8cd7b Add Platform View Manager to Windows shell (flutter/engine#50598) 
Create a manager for platform views accessible to the compositor, handle
the methods that the framework will send.

Addresses https://github.com/flutter/flutter/issues/143375

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2024-02-26 10:13:46 -05:00
skia-flutter-autoroll
fdcef537c2 Roll Skia from cb2a47da08b7 to ba3ed5998af3 (2 revisions) (flutter/engine#50966) 
https://skia.googlesource.com/skia.git/+log/cb2a47da08b7..ba3ed5998af3

2024-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d829c29f43ec to dd6c2371c85d (2 revisions)
2024-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5a4bfd61fd09 to acba61cb3e27 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 14:30:23 +00:00
skia-flutter-autoroll
32aa513a94 Roll Dart SDK from 8a2ca37c39e2 to c479735adcf9 (1 revision) (flutter/engine#50965) 
https://dart.googlesource.com/sdk.git/+log/8a2ca37c39e2..c479735adcf9

2024-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-176.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 13:58:22 +00:00
skia-flutter-autoroll
ac6ab0491c Roll Skia from a79c52feafa4 to cb2a47da08b7 (3 revisions) (flutter/engine#50962) 
https://skia.googlesource.com/skia.git/+log/a79c52feafa4..cb2a47da08b7

2024-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from dd4b27ecbb53 to 78ad8c9c4948
2024-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 88ef1b147e5e to dd4b27ecbb53 (2 revisions)
2024-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 75674438c2f4 to 03f52d4a902b (12 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 07:18:05 +00:00
Zachary Anderson
52ad6e42d2 Move linux_android_emulator_skia builder to prod (flutter/engine#50956) 
Follow-up from https://github.com/flutter/engine/pull/50954
 2024-02-26 07:14:21 +00:00
skia-flutter-autoroll
8236396e9e Roll Skia from 4346b8f4a1e0 to a79c52feafa4 (1 revision) (flutter/engine#50961) 
https://skia.googlesource.com/skia.git/+log/4346b8f4a1e0..a79c52feafa4

2024-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from eb75201a4e03 to 0f69b790c7a4 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 05:34:38 +00:00
skia-flutter-autoroll
c28a0ce504 Roll Skia from d1722af9ebab to 4346b8f4a1e0 (1 revision) (flutter/engine#50958) 
https://skia.googlesource.com/skia.git/+log/d1722af9ebab..4346b8f4a1e0

2024-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fda3fc86e763 to d829c29f43ec (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 02:14:25 +00:00
Zachary Anderson
af1428f011 Further shard Android emulator tests (flutter/engine#50954) 
Even when not flaking anymore, we'll probably want to split these up
into separate shards, and the Linux VMs are plentiful so there's no harm
in doing this.
 2024-02-25 12:46:34 -08:00
skia-flutter-autoroll
8ffc36b8e3 Roll Fuchsia Linux SDK from Oac3MZ5VgZ9g3Q3cL... to kLvCWEgbL1VTRW69e... (flutter/engine#50953) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-25 17:13:11 +00:00
skia-flutter-autoroll
191185a333 Roll Skia from f94b35f33a82 to d1722af9ebab (1 revision) (flutter/engine#50948) 
https://skia.googlesource.com/skia.git/+log/f94b35f33a82..d1722af9ebab

2024-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d0f72e9692c4 to fda3fc86e763 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-24 18:26:26 +00:00
skia-flutter-autoroll
df3d8d22f7 Roll Fuchsia Linux SDK from sO-oG6KoeFlPK2WLR... to Oac3MZ5VgZ9g3Q3cL... (flutter/engine#50946) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-24 15:47:05 +00:00
Dan Field
f235a65897 Avoid reloading font collection for spawned engines with compatible asset managers (flutter/engine#50897) 
@jason-simmons @jiahaog fyi

I need to figure out a test for this still but it seems to work. Hot restart is kind of a mess though, because `Engine::Restart` nulls out the asset manager it ends up reloading the font collection for every engine after a restart. But we separately need to fix hot restart, it's not very usable on the example app 

Fixes https://github.com/flutter/flutter/issues/143701
 2024-02-24 14:58:37 +00:00
skia-flutter-autoroll
283f15aa36 Roll Dart SDK from e5e4aaceaf23 to 8a2ca37c39e2 (2 revisions) (flutter/engine#50944) 
https://dart.googlesource.com/sdk.git/+log/e5e4aaceaf23..8a2ca37c39e2

2024-02-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-175.0.dev
2024-02-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-174.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-24 14:00:37 +00:00
skia-flutter-autoroll
3d1c0f0318 Roll Skia from 45b38664b4ed to f94b35f33a82 (3 revisions) (flutter/engine#50940) 
https://skia.googlesource.com/skia.git/+log/45b38664b4ed..f94b35f33a82

2024-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d85c6c8d1c86 to d0f72e9692c4 (3 revisions)
2024-02-23 johnstiles@google.com Revert "Add Perlin noise stage to Raster Pipeline."
2024-02-23 johnstiles@google.com Revert "Remove matrix from PaintingData."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-24 08:52:08 +00:00
Tong Mu
cb110ebc94 Reland 4: Multiview pipeline (flutter/engine#50931) 
This relands https://github.com/flutter/engine/pull/49950.

Nothing is changed. The error turns out a flake (it passes once),
although this PR might have made the flake more flaky.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-23 20:52:53 -08:00
Matan Lurey
2db47e5a50 Actually list all sources for scenario_app target. (flutter/engine#50933) 
Without this the GN cache can easily become invalid if nothing else
changed.
 2024-02-23 20:27:01 -08:00
skia-flutter-autoroll
807ac0c932 Roll Dart SDK from 9849ca5fcaec to e5e4aaceaf23 (1 revision) (flutter/engine#50934) 
https://dart.googlesource.com/sdk.git/+log/9849ca5fcaec..e5e4aaceaf23

2024-02-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-173.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-24 01:52:04 +00:00
Loïc Sharma
788179d383 [Windows] Refactor the a11y announcement test (flutter/engine#50888) 
This refactors the Windows accessibility announcement test. This will make it easier to add a headless variant of this test as part of https://github.com/flutter/flutter/issues/143765.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-24 00:26:02 +00:00
Dan Field
54689ee475 Avoiding using separate FlutterLoaders in scenario_app (flutter/engine#50927) 
Fixes https://github.com/flutter/flutter/issues/144046

When we use the same FlutterLoader from the injector, the initialization method knows it doesn't have to do as much work - using separate Flutter loaders (in this case for every test that derives from TestActivity, which is basically all of them) causes spurious warning messages to be printed for every test.
 2024-02-23 23:46:19 +00:00
skia-flutter-autoroll
7186299856 Roll Skia from 9d8d3f053775 to 45b38664b4ed (1 revision) (flutter/engine#50926) 
https://skia.googlesource.com/skia.git/+log/9d8d3f053775..45b38664b4ed

2024-02-23 aperez@igalia.com Reland "Add sk_malloc_size() to query usable allocation sizes"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 23:39:47 +00:00
Matan Lurey
5ff7a8bc99 Refactor Android scenario_app to remove shell entrypoint, simplify. (flutter/engine#50922) 
Closes https://github.com/flutter/flutter/issues/144045.

There is still more work I want to do, like pulling args parsing into it's own class, and potentially cleanup the [golden file collection](https://github.com/flutter/flutter/issues/144047), but those seem reasonable for future (lower priority) PRs.
 2024-02-23 23:34:05 +00:00
Loïc Sharma
b73e827969 [Windows] Add helper for headless integration tests (flutter/engine#50885) 
We'll add more headless mode tests as part of https://github.com/flutter/flutter/issues/143765.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-23 23:23:29 +00:00
Zachary Anderson
9f1ed38ee0 Shift //third_party/icu to //flutter/third_party (flutter/engine#50924) 
For https://github.com/flutter/flutter/issues/67373
 2024-02-23 23:23:27 +00:00
auto-submit[bot]
c388fc8bf0 Reverts "Reland 3: Multiview pipeline (#49950)" (flutter/engine#50929) 
Reverts flutter/engine#49950

Initiated by: dkwingsmt

Reason for reverting: Head redness 
```
java.lang.RuntimeException: Timeout waiting for firstFrameLatch to signal
	at dev.flutter.scenarios.ExternalTextureFlutterActivity.waitUntilFlutterRendered(ExternalTextureFlutterActivity.java:98)
	at dev.flutter.scenariosui.ScreenshotUtil.capture(ScreenshotUtil.java:122)
```

Original PR Author: dkwingsmt

Reviewed By: {loic-sharma}

This change reverts the following previous change:
Original Description:
This is the 3rd attempt to land multiview pipeline, following
https://github.com/flutter/engine/pull/47239.

The pipeline now properly implements the required logic for
`scheduleWarmUpFrame` to work in a multi-view setup, following the
preparation in https://github.com/flutter/flutter/pull/143290 and
https://github.com/flutter/engine/pull/50570.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2024-02-23 15:15:00 -08:00
Dan Field
7fd214252c Remove timeouts from CountdownLatch.await in tests (flutter/engine#50930) 
See
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#never-check-if-a-port-is-available-before-using-it-never-add-timeouts-and-other-race-conditions

This may be contributing to flakiness in the Java/Scenario_app tests. We
should just timeout when CI says it's taken too long - on a slow machine
5 or 10 seconds may not be enough time.
 2024-02-23 15:10:16 -08:00
Tong Mu
dd271d0880 Reland 3: Multiview pipeline (flutter/engine#49950) 
This is the 3rd attempt to land multiview pipeline, following
https://github.com/flutter/engine/pull/47239.

The pipeline now properly implements the required logic for
`scheduleWarmUpFrame` to work in a multi-view setup, following the
preparation in https://github.com/flutter/flutter/pull/143290 and
https://github.com/flutter/engine/pull/50570.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-23 13:39:54 -08:00
skia-flutter-autoroll
d7d7eeae4d Roll Skia from fde4d63c5e61 to 9d8d3f053775 (1 revision) (flutter/engine#50921) 
https://skia.googlesource.com/skia.git/+log/fde4d63c5e61..9d8d3f053775

2024-02-23 johnstiles@google.com Reland 'Eliminate unnecessary function parameter copies in SkRP.'

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 21:01:16 +00:00
Jim Graham
4aa93cbf61 [Impeller] Compute UV coordinates lazily in PositionUVWriter (flutter/engine#50879) 
The stroking code was performing texture coordinate conversion on each created vertex. Since there were often very few calculations needed for each vertex, interspersing a coordinate transform with each vertex append was clogging up the code.

This change will defer the calculation of the texture coordinates until the end of the stroking process so that the polyline widening code can do its job efficiently and then later the coordinate conversion code can do its job also efficiently in a tight loop. This change also opened up the opportunity to optimize a common case (no effect transform) even more than before.
 2024-02-23 19:52:19 +00:00
skia-flutter-autoroll
68c773fb26 Roll Skia from 49dd7ed24bec to fde4d63c5e61 (3 revisions) (flutter/engine#50917) 
https://skia.googlesource.com/skia.git/+log/49dd7ed24bec..fde4d63c5e61

2024-02-23 johnstiles@google.com Remove matrix from PaintingData.
2024-02-23 robertphillips@google.com Revert "Implementing Fontations font scanner"
2024-02-23 johnstiles@google.com Add Perlin noise stage to Raster Pipeline.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 19:30:23 +00:00
skia-flutter-autoroll
f1219ae5fd Roll Skia from 037e08e92598 to 49dd7ed24bec (3 revisions) (flutter/engine#50916) 
https://skia.googlesource.com/skia.git/+log/037e08e92598..49dd7ed24bec

2024-02-23 robertphillips@google.com [graphite] Trial balloon of stable keying system for known runtime effects
2024-02-23 kjlubick@google.com Move SkTextBlobTrace from src/core to tools/text
2024-02-23 kjlubick@google.com Address clang-tidy suggestions in src/pathops

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 18:26:05 +00:00
John McCutchan
82dd6cd6e3 Add an initial 'build' command to engine_tool (flutter/engine#50681) 
* Adds a 'build' command to `et`.
* Renamed `query builds` to `query builders` because that seemed to be
more precise(?)

Some extra requests during review:
1. I've left some questions I'd like answers to at the top of
`build_command.dart` I suspect @zanderso and @loic-sharma can give me
(some?) answers.
2. I suspect I'm holding the FakeProcessManager wrong or there is a
better way to write the tests in `build_command_test.dart`. Pointers to
good examples are appreciated.
 2024-02-23 10:02:34 -08:00
skia-flutter-autoroll
487ea360ad Roll Dart SDK from 7f6eccd65255 to 9849ca5fcaec (1 revision) (flutter/engine#50915) 
https://dart.googlesource.com/sdk.git/+log/7f6eccd65255..9849ca5fcaec

2024-02-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-172.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 18:00:20 +00:00
skia-flutter-autoroll
a968a5054d Roll Skia from c7f8e0e6f3c2 to 037e08e92598 (8 revisions) (flutter/engine#50914) 
https://skia.googlesource.com/skia.git/+log/c7f8e0e6f3c2..037e08e92598

2024-02-23 kjlubick@google.com Enforce IWYU on the rest of src/core
2024-02-23 brianosman@google.com Enable -Wextra-semi
2024-02-23 brianosman@google.com Revert "Add sk_malloc_size() to query usable allocation sizes"
2024-02-23 johnstiles@google.com Revert 'Eliminate unnecessary function parameter copies in SkRP.'
2024-02-23 aperez@igalia.com Add sk_malloc_size() to query usable allocation sizes
2024-02-23 jlavrova@google.com Implementing Fontations font scanner
2024-02-23 jvanverth@google.com [graphite] Add uncached PageList to RasterPathAtlas.
2024-02-23 robertphillips@google.com [graphite] Make addition of runtime effects to ShaderCodeDictionary thread safe(r)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 17:29:28 +00:00
skia-flutter-autoroll
075891374f Roll Skia from bb8a7832a6f4 to c7f8e0e6f3c2 (3 revisions) (flutter/engine#50911) 
https://skia.googlesource.com/skia.git/+log/bb8a7832a6f4..c7f8e0e6f3c2

2024-02-23 johnstiles@google.com Expose enum SkPerlinNoiseShaderType to src/opts.
2024-02-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9c43d05064bd to d85c6c8d1c86 (3 revisions)
2024-02-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e47aae228e01 to 4a5a5836c068

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 14:23:06 +00:00
Brian Osman
f1951104cb Replace SkColorSpace::filterColor with filterColor4f (flutter/engine#50821) 
The old API is deprecated. The new one operates on float colors, but is
also explicit about the color space of the source color (and the working
space of the filter).

Bug: b/40040795
 2024-02-23 09:23:00 -05:00
skia-flutter-autoroll
aaf2566641 Roll Dart SDK from 52111952d91b to 7f6eccd65255 (1 revision) (flutter/engine#50910) 
https://dart.googlesource.com/sdk.git/+log/52111952d91b..7f6eccd65255

2024-02-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-171.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 14:03:11 +00:00
skia-flutter-autoroll
9e6dc6ab3c Roll Fuchsia Linux SDK from j9cJ94K-T1i3u5xGh... to sO-oG6KoeFlPK2WLR... (flutter/engine#50907) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 11:23:21 +00:00
Brandon DeRosier
6e313cd781 [Impeller] Make StC work for Position+UV buffers. (flutter/engine#50900) 
The accumulated fixes pulled out of the flag flip PR: https://github.com/flutter/engine/pull/50856

* Also fixes tests to make them resilient to StC being on/off.
* Fix blending for the cover draw.
* Default to depth=1 which is much more reasonable as depth=0 will never draw anything for cover draws. This allows enclosed subpass rendering cases like `Contents::RenderToSnapshot` for filter inputs to work by default and makes mistakes harder.
* Use depth+stencil attachments for `Contents::RenderToSnapshot` subpasses to allow for StC draws.
 2024-02-23 09:51:20 +00:00
skia-flutter-autoroll
7abf583317 Roll Dart SDK from 957130770e7d to 52111952d91b (1 revision) (flutter/engine#50906) 
https://dart.googlesource.com/sdk.git/+log/957130770e7d..52111952d91b

2024-02-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-170.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 09:47:36 +00:00
skia-flutter-autoroll
17308043c7 Roll Skia from 14b5c1a4627a to bb8a7832a6f4 (1 revision) (flutter/engine#50905) 
https://skia.googlesource.com/skia.git/+log/14b5c1a4627a..bb8a7832a6f4

2024-02-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cd63c5d477df to 5a4bfd61fd09 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 08:44:19 +00:00
skia-flutter-autoroll
05ecb1c95e Roll Skia from 5a0a82af7796 to 14b5c1a4627a (1 revision) (flutter/engine#50904) 
https://skia.googlesource.com/skia.git/+log/5a0a82af7796..14b5c1a4627a

2024-02-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c615566d8899 to 88ef1b147e5e (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 06:32:24 +00:00
skia-flutter-autoroll
9a5050f998 Roll Dart SDK from e2f2d9b464e9 to 957130770e7d (2 revisions) (flutter/engine#50903) 
https://dart.googlesource.com/sdk.git/+log/e2f2d9b464e9..957130770e7d

2024-02-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-169.0.dev
2024-02-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-168.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 05:56:07 +00:00
skia-flutter-autoroll
0c463c9e88 Roll Skia from 254b27e90e3c to 5a0a82af7796 (1 revision) (flutter/engine#50902) 
https://skia.googlesource.com/skia.git/+log/254b27e90e3c..5a0a82af7796

2024-02-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from caf589222cb5 to 75674438c2f4 (17 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 05:32:03 +00:00
Matan Lurey
d3f0ddd9ea Move ban-plugin-java script into separate file and improve testing. (flutter/engine#50875) 
Closes https://github.com/flutter/flutter/issues/143962.
 2024-02-23 04:52:11 +00:00
Matan Lurey
4405a2fb57 Provide a subset of adb logcat logs streaming during scenario_app testing (flutter/engine#50886) 
Work towards https://github.com/flutter/flutter/issues/143458.

What this _doesn't_ change:

1. The full output of `adb logcat` is still written to `$FLUTTER_LOGS_DIR/logcat.txt`

Example output:

<img width="580" alt="Screenshot 2024-02-22 at 2 53 51 PM" src="https://github.com/flutter/engine/assets/168174/bef24370-c066-4203-ae0e-552cc0fd73ad">

/cc @dnfield @gaaclarke
 2024-02-23 03:36:16 +00:00