DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
30,754 Commits 882 Branches 1,069 Tags
Commit Graph

30754 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
de69c19fd1 Roll Skia from 586a6309e3a1 to cb3451491f11 (2 revisions) (flutter/engine#44755) 
https://skia.googlesource.com/skia.git/+log/586a6309e3a1..cb3451491f11

2023-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 61a5707f8673 to 152cf62b3887 (10 revisions)
2023-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 716ec65fb647 to a76c1e8f2edc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 07:00:12 +00:00
skia-flutter-autoroll
a06c27de61 Roll Dart SDK from e6bf503b36fe to 80b9a90ae563 (2 revisions) (flutter/engine#44753) 
https://dart.googlesource.com/sdk.git/+log/e6bf503b36fe..80b9a90ae563

2023-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-76.0.dev
2023-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-75.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 06:07:55 +00:00
skia-flutter-autoroll
72f1897469 Roll Fuchsia Linux SDK from orVLXMF7ak2qfFkGs... to GpKKtPGPMiRcY0kcz... (flutter/engine#44751) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 05:33:10 +00:00
skia-flutter-autoroll
15e23723ad Roll Skia from 8f0238837ee4 to 586a6309e3a1 (2 revisions) (flutter/engine#44752) 
https://skia.googlesource.com/skia.git/+log/8f0238837ee4..586a6309e3a1

2023-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 446e642885e7 to 716ec65fb647 (3 revisions)
2023-08-16 armansito@google.com [graphite][compute] Remove draw-specific parameters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 05:33:07 +00:00
skia-flutter-autoroll
3581b5bd43 Roll Skia from 3d2b84e28e79 to 8f0238837ee4 (1 revision) (flutter/engine#44748) 
https://skia.googlesource.com/skia.git/+log/3d2b84e28e79..8f0238837ee4

2023-08-16 lovisolo@google.com //gm/gm.h: Fold GM::onISize() into GM::getISize().

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 03:03:18 +00:00
skia-flutter-autoroll
bf3ddb7b53 Roll Fuchsia Mac SDK from 7iuIq3PsSkuCmuEMr... to Zp9or9YwxZHHPeQbA... (flutter/engine#44747) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 02:35:33 +00:00
godofredoc
23467ff8ba Move cache builders to prod. (flutter/engine#44739) 
These builders have been running as bringup for a very long time with no failures.

Bug: https://github.com/flutter/flutter/issues/132597

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-16 02:34:06 +00:00
Rulong Chen（陈汝龙）
75ac0d3957 Enabling the host application to control the timing of attaching the |FlutterView| to the engine (flutter/engine#43595) 
In the add-to-app scenario where multiple FlutterViews share the same FlutterEngine, the host application desires to determine the timing of attaching the FlutterView to the engine, for example, during the `onResume` instead of the `onCreateView`.

As an example, consider the following scenario: A native page contains multiple tabs, and each tab is a FlutterFragment. During initialization, FlutterFragments of different tabs are created almost simultaneously, but only the one that needs to be displayed currently requires attachment to the engine, while the others need to be attached only when they receive the |onResume| callback.

Partial fix: https://github.com/flutter/flutter/issues/130235

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-16 02:34:04 +00:00
skia-flutter-autoroll
3df865c3fe Roll Skia from 9fc1c628456a to 3d2b84e28e79 (1 revision) (flutter/engine#44746) 
https://skia.googlesource.com/skia.git/+log/9fc1c628456a..3d2b84e28e79

2023-08-15 johnstiles@google.com Perform error-checking when creating a Dawn shader module.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 02:18:15 +00:00
skia-flutter-autoroll
f655d5da85 Roll Dart SDK from b36934aae968 to e6bf503b36fe (1 revision) (flutter/engine#44745) 
https://dart.googlesource.com/sdk.git/+log/b36934aae968..e6bf503b36fe

2023-08-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-74.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 01:09:03 +00:00
Matan Lurey
8567814d32 [Skia] Only respect ui.Paint.dither when the colorSource is a gradient (flutter/engine#44730) 
In the Impeller backend, we **only** support dithering of _gradients_. In addition, it will be the default (and only option).

In the [process of enabling dithering by default](https://github.com/flutter/engine/pull/44705), i.e.
```diff
class Paint {
-  static bool enableDithering = false;
+  static bool enableDithering = true;
}
```

... we realized with internal Google testing this will now apply dithering on more than just gradients, i.e. images in the Skia backend. Since we won't support dithering of images in the Impeller backend, this PR gives a "hint" on whether the `colorSource` (if one is set) can be dithered by the contrived rules we've created.
 2023-08-16 01:07:39 +00:00
Jonah Williams
01c2363b16 [Impeller] Cache render target texture allocations across frames. (flutter/engine#44527) 
When allocating a non-host visible texture for a render target, the allocator will hold onto a reference to this texture descriptor. On the immediate next frame, this texture is made available to replace requested allocations for new render target textures. if this texture is not used, then at the end of the next frame it is discarded.

This removes the vast majority of allocations in most flutter gallery and wonderous. This does not attempt to use different sized textures for the cache.

There are two caveats noted in the PR contents.

Fixes https://github.com/flutter/flutter/issues/131515
 2023-08-16 00:25:08 +00:00
Amir Panahandeh
e9f54512c8 Add more tests for CompositionAwareMixin (flutter/engine#44717) 
Adds missing tests for `CompositionAwareMixin`. Check https://github.com/flutter/engine/pull/44139#discussion_r1288733128 and https://github.com/flutter/engine/pull/44139#discussion_r1288009016

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-16 00:08:42 +00:00
John McCutchan
7bf371d161 Fix clang_tidy lints (flutter/engine#44740) 2023-08-15 16:40:32 -07:00
skia-flutter-autoroll
fdd3eaf715 Roll Skia from b07a6964a1cf to 9fc1c628456a (5 revisions) (flutter/engine#44737) 
https://skia.googlesource.com/skia.git/+log/b07a6964a1cf..9fc1c628456a

2023-08-15 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Simplify how Gold keys are generated.
2023-08-15 brianosman@google.com Remove deprecated Metal GrBackendRenderTarget constructor
2023-08-15 johnstiles@google.com Move SDFTextRenderStep logic into modules.
2023-08-15 johnstiles@google.com Move BitmapTextRenderStep logic into modules.
2023-08-15 lovisolo@google.com //gm/gm.h: Fold GM::onShortName() into GM::getName() and make it const.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 21:44:22 +00:00
godofredoc
6ae25ffa72 Add SLSA L1 badge (flutter/engine#44731) 
Adds the SLSA L1 compliance badge for the engine.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-15 21:33:03 +00:00
John McCutchan
50190fcaa6 Add support for SurfaceTexture based external textures on Android under Impeller/GLES. (flutter/engine#44734) 
- Refactor AndroidExternalTextureGL into SurfaceTextureExternalTexture
base class with two specialized implementations:
- Add SurfaceTextureExternalTextureGL for legacy GL rendering.
- Add SurfaceTextureExternalTextureImpellerGL for Impeller GLES
rendering.

NOTE: There is still no support for SurfaceTextures under Vulkan
rendering.
 2023-08-15 14:25:03 -07:00
skia-flutter-autoroll
4beaef6a06 Roll Skia from c7c9e85a8657 to b07a6964a1cf (2 revisions) (flutter/engine#44733) 
https://skia.googlesource.com/skia.git/+log/c7c9e85a8657..b07a6964a1cf

2023-08-15 johnstiles@google.com Fix Perf issues in non-Graphite builds.
2023-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f7403dbd4918 to f1b7e4fb795d (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 20:16:21 +00:00
Jonah Williams
4367ca66ae [Impeller] Make porter duff blended atlas calls faster. (flutter/engine#44059) 
This implements part of https://github.com/flutter/flutter/issues/131345

---

Makes all porter-duff draw atlas blending avoid subpass creation, by tweaking the existing porter duff shader to support per-vertex colors and output opacity. This requires a small trick: What the blend shaders and what (drawAtlas/drawVertices) consider the source and destination is reversed. That is a blend mode color filter treats the color as the source whereas drawVertices/drawAtlas treat their per-vertex colors as the destination. Therefore I cannot simply make all color inputs per vertex and use the exact same shaders :(

However, for the porter duff blends we should just be able to reverse the blend mode (srcover -> dstOver, xor->xor) (I'm pretty sure I did this correctly) so that the blending is still correct. I don't think we can do this for the advanced blends, but supporting those is less important than the common atlas blending parameters like dstIn.

This PR only updates drawAtlas.
 2023-08-15 19:40:09 +00:00
skia-flutter-autoroll
015275a126 Roll Skia from 4beb6fd05f4f to c7c9e85a8657 (7 revisions) (flutter/engine#44729) 
https://skia.googlesource.com/skia.git/+log/4beb6fd05f4f..c7c9e85a8657

2023-08-15 jmbetancourt@google.com always make image asset if slotID is present
2023-08-15 johnstiles@google.com Add conditional-testing macros for Graphite unit tests.
2023-08-15 scroggo@google.com Update Android Viewer app instructions
2023-08-15 nicolettep@google.com Consider external format when determining whether YCBCR information is valid
2023-08-15 johnstiles@google.com Add nanobench entries for Graphite Metal/WGSL large shaders.
2023-08-15 bungeman@google.com Reland "[skunicode] Consolidate SkUnicode_IcuBidi"
2023-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from d672b19e7eab to 3590e8eac703

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 19:06:28 +00:00
skia-flutter-autoroll
3f8ae3d15b Roll Dart SDK from 19c87486f0a9 to b36934aae968 (1 revision) (flutter/engine#44728) 
https://dart.googlesource.com/sdk.git/+log/19c87486f0a9..b36934aae968

2023-08-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-73.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 18:12:01 +00:00
skia-flutter-autoroll
4c5c178ac5 Roll Fuchsia Linux SDK from -16K9GvYE3a4Bqs0G... to orVLXMF7ak2qfFkGs... (flutter/engine#44726) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 16:45:04 +00:00
Matej Knopp
d4607aa5cb Reset editing delta state when replacing editing state (flutter/engine#44595) 
Fixes https://github.com/flutter/flutter/issues/131023

Likely needs a test.

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-08-15 14:26:49 +02:00
skia-flutter-autoroll
030d126331 Roll Fuchsia Mac SDK from uIGMbDkXoIcpqWjgR... to 7iuIq3PsSkuCmuEMr... (flutter/engine#44721) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 11:19:12 +00:00
skia-flutter-autoroll
99f54728a8 Roll Dart SDK from d1c68769eba0 to 19c87486f0a9 (1 revision) (flutter/engine#44719) 
https://dart.googlesource.com/sdk.git/+log/d1c68769eba0..19c87486f0a9

2023-08-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-72.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 10:34:22 +00:00
skia-flutter-autoroll
7f6ac51d4c Roll Dart SDK from d240bef060ed to d1c68769eba0 (1 revision) (flutter/engine#44715) 
https://dart.googlesource.com/sdk.git/+log/d240bef060ed..d1c68769eba0

2023-08-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-71.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 06:53:35 +00:00
skia-flutter-autoroll
8faea989cb Roll Skia from e137aad081a3 to 4beb6fd05f4f (3 revisions) (flutter/engine#44713) 
https://skia.googlesource.com/skia.git/+log/e137aad081a3..4beb6fd05f4f

2023-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 446e642885e7 to 2ebf1b8d15f2
2023-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3b492bd1f02d to f7403dbd4918 (4 revisions)
2023-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f11c972b52cb to 61a5707f8673 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 06:21:01 +00:00
Jia Hao
1f58484e28 Namespace imports with flutter (flutter/engine#44709) 
For Google3, this makes it easier since we only need to make one source transform (from `#include "flutter` -> `#include "third_party` instead of requiring a source transform for every root directory in this repo.

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-15 06:03:54 +00:00
skia-flutter-autoroll
a82b81e2db Roll Skia from d8d880c560f8 to e137aad081a3 (1 revision) (flutter/engine#44712) 
https://skia.googlesource.com/skia.git/+log/d8d880c560f8..e137aad081a3

2023-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 11084ddef4cb to 446e642885e7 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 05:41:25 +00:00
skia-flutter-autoroll
fe86e9302b Roll Fuchsia Linux SDK from AvjxPvh-niiyQpYoD... to -16K9GvYE3a4Bqs0G... (flutter/engine#44710) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 04:06:21 +00:00
Brian Osman
829b42e044 Stop using deprecated GrBackendRenderTarget constructor (flutter/engine#44694) 
Sample count is part of GrVkImageInfo (and was already being set in both places).
 2023-08-15 03:47:09 +00:00
skia-flutter-autoroll
737340ae1d Roll Skia from 022415d74e73 to d8d880c560f8 (1 revision) (flutter/engine#44708) 
https://skia.googlesource.com/skia.git/+log/022415d74e73..d8d880c560f8

2023-08-15 pkasting@chromium.org Rename definition of VLOG.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 03:05:15 +00:00
skia-flutter-autoroll
c3a9f5bdf9 Roll Dart SDK from 8731e9796eb3 to d240bef060ed (1 revision) (flutter/engine#44707) 
https://dart.googlesource.com/sdk.git/+log/8731e9796eb3..d240bef060ed

2023-08-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-70.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 03:03:05 +00:00
skia-flutter-autoroll
d9b78e8a36 Roll Skia from f636188df4e2 to 022415d74e73 (2 revisions) (flutter/engine#44706) 
https://skia.googlesource.com/skia.git/+log/f636188df4e2..022415d74e73

2023-08-15 scroggo@google.com Fix typo in EncodeAnimated for NDK
2023-08-14 egdaniel@google.com Revert "Fix SurfaceAsyncReadPixels test and non-scaled colorspace transforms."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 01:23:21 +00:00
Caroline Liu
c49236d4c0 [fuchsia] Delete obsolete GFX-specific source files (flutter/engine#44594) 
This change removes 
- GFX source files removed from the BUILD in #44401 
- Extraneous unused Scenic includes in the same directory
(`//shell/platform/fuchsia/flutter/`)
- All remaining uses of the Scenic library from the Fuchsia SDK
- All remaining uses of fuchsia.ui.scenic.*
 2023-08-15 09:47:32 +10:00
skia-flutter-autoroll
cd26dcf508 Roll Skia from 58397bfd9ab6 to f636188df4e2 (1 revision) (flutter/engine#44700) 
https://skia.googlesource.com/skia.git/+log/58397bfd9ab6..f636188df4e2

2023-08-14 penghuang@chromium.org Device: create copy dest texture with the same fmt of src

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 22:39:26 +00:00
skia-flutter-autoroll
633717ccc8 Roll Dart SDK from d445f5a18876 to 8731e9796eb3 (1 revision) (flutter/engine#44699) 
https://dart.googlesource.com/sdk.git/+log/d445f5a18876..8731e9796eb3

2023-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-69.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 22:20:12 +00:00
Zachary Anderson
f8fb1ab5ea Update android_embedding_bundle CIPD instructions (flutter/engine#44644) 
This PR updates the gradle build file for the android_embedding_bundle
cipd package to fetch license information about the dependencies listed
under `tools/androidx/files.json`. The README file for the
android_embedding_bundle now explains how to fetch the license
information and make sure it's correct in the cipd package.

This PR also pulls a new version of android_embedding_dependencies that
includes a `LICENSE` file.

It turns out that Flutter does not re-ship anything from the embedding
bundle to Flutter end-users. These dependencies are only used to create
a classpath against which we build the Android embedder and in-tree
tests. I've updated docs/comments to clarify that since I was initially
confused about how these were used.

I'm not adding a test that compares the license info fetched from maven
against a checked-in golden, yet. Still thinking about the most
effective way to do that in combination with the steps in the README.
 2023-08-14 15:15:26 -07:00
skia-flutter-autoroll
904676a45d Roll Skia from 69ea58157190 to 58397bfd9ab6 (8 revisions) (flutter/engine#44698) 
https://skia.googlesource.com/skia.git/+log/69ea58157190..58397bfd9ab6

2023-08-14 cmumford@google.com [jsfiddle] Create jsfiddle Bazel image build target
2023-08-14 jvanverth@google.com Fix SurfaceAsyncReadPixels test and non-scaled colorspace transforms.
2023-08-14 jvanverth@google.com [ganesh] Fix asyncReadPixels when running on Direct3D
2023-08-14 lovisolo@google.com [bazel] //gm/gm.h: Add method getGoldKeys().
2023-08-14 johnstiles@google.com Add flag for DawnGraphicsPipeline to use WGSL instead of SPIR-V.
2023-08-14 mattleibow@live.com Add the tvOS availability "attributes"
2023-08-14 lovisolo@google.com [bazel] Add the "zip" command to the Linux RBE toolchain container image.
2023-08-14 jmbetancourt@google.com add vec2 slot support to CanvasKit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 21:47:17 +00:00
Matan Lurey
ee235383f8 Update web_ui/** to explicitly pass --local-engine-host to the flutter tool. (flutter/engine#44613) 
Partial work towards https://github.com/flutter/flutter/issues/132245.
 2023-08-14 21:09:22 +00:00
Amir Panahandeh
4c8bde6166 Update CompositionAwareMixin to correctly compute composingBase in Web engine (flutter/engine#44139) 
It fixes an issue in `CompositionAwareMixin` causing wrong deltas being computed and reported to input clients resulting in wrong state when compositing text in rich text editors like [Fleather](https://github.com/fleather-editor/fleather) and possibly others.

Reported deltas on Mac:
```console
TextEditingDeltaInsertion: start: 0, end: 0, data: k
TextEditingDeltaInsertion: start: 1, end: 0, data: y
TextEditingDeltaReplacement: start: 0, end: 2, data: きょ
TextEditingDeltaInsertion: start: 2, end: 0, data: う
TextEditingDeltaInsertion: start: 3, end: 0, data: h
TextEditingDeltaReplacement: start: 0, end: 4, data: きょうは
TextEditingDeltaReplacement: start: 0, end: 4, data: 今日は
```

Reported deltas on Web (Before):
```console
TextEditingDeltaInsertion: start: 0, end: 0, data: k
TextEditingDeltaInsertion: start: 1, end: 0, data: y
TextEditingDeltaReplacement: start: 0, end: 2, data: きょ
TextEditingDeltaInsertion: start: 2, end: 0, data: う
TextEditingDeltaInsertion: start: 3, end: 0, data: h
TextEditingDeltaReplacement: start: 0, end: 4, data: きょうは
TextEditingDeltaInsertion: start: 4, end: 0, data: 今日は
```

Reported deltas on Web (After):
```console
TextEditingDeltaInsertion: start: 0, end: 0, data: k
TextEditingDeltaInsertion: start: 1, end: 0, data: y
TextEditingDeltaReplacement: start: 0, end: 2, data: きょ
TextEditingDeltaInsertion: start: 2, end: 0, data: う
TextEditingDeltaInsertion: start: 3, end: 0, data: h
TextEditingDeltaReplacement: start: 0, end: 4, data: きょうは
TextEditingDeltaReplacement: start: 0, end: 4, data: 今日は
```

* Fixes https://github.com/flutter/flutter/issues/131335
* Fixes https://github.com/fleather-editor/fleather/issues/150

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-14 19:51:19 +00:00
stuartmorgan
1df606ab9d Add application:openURLs: forwarding on macOS (flutter/engine#44689) 
Wires `application:openURLs:` into the exisiting delegation system, allowing plugins to handle URL callbacks (as on iOS).

Since there is no notification-based version of this delegate method, this adds it directly to the app delegate, restructring the helper class slightly to allow internal sharing of the delegate list.

Fixes https://github.com/flutter/flutter/issues/41471

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-14 19:38:03 +00:00
skia-flutter-autoroll
30daf6f9f2 Roll Skia from a4377099b25a to 69ea58157190 (1 revision) (flutter/engine#44692) 
https://skia.googlesource.com/skia.git/+log/a4377099b25a..69ea58157190

2023-08-14 lovisolo@google.com //gm/BazelGMRunner.cpp: Generate surface-related Gold key/value pairs.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 19:22:20 +00:00
Casey Hillers
c3c5b4f7ac Update embedder_semantics_update.h imports to include flutter namespace (flutter/engine#44670) 
Without the flutter namespace, it breaks Google's build of the engine.
 2023-08-14 19:06:54 +00:00
skia-flutter-autoroll
0240df8ba9 Roll Dart SDK from 3295a353980a to d445f5a18876 (1 revision) (flutter/engine#44691) 
https://dart.googlesource.com/sdk.git/+log/3295a353980a..d445f5a18876

2023-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-68.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 18:41:52 +00:00
Dan Field
0d8aebd040 Revert "Make run_tests.py assert that the ios test dylib is at least as new as libFlutter.dylib" (flutter/engine#44690) 
Reverts flutter/engine#41720

Fixes https://github.com/flutter/flutter/issues/131899
 2023-08-14 18:36:02 +00:00
skia-flutter-autoroll
01426417d7 Roll Skia from 1cf6f71c8120 to a4377099b25a (1 revision) (flutter/engine#44688) 
https://skia.googlesource.com/skia.git/+log/1cf6f71c8120..a4377099b25a

2023-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c3ff3250b9e7 to 3b492bd1f02d (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 17:57:07 +00:00
skia-flutter-autoroll
3500d9ebfc Roll Fuchsia Mac SDK from JKTVoxVrHjZjBaxG4... to uIGMbDkXoIcpqWjgR... (flutter/engine#44687) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 17:54:23 +00:00
Jonah Williams
b180b8f66f [Impeller] Conditionally set command debug info. (flutter/engine#44274) 
If IMPELLER_DEBUG is not defined (release mode), then remove the cmd label strings and additional encoding debug info.
 2023-08-14 17:23:05 +00:00
Kevin Lubick
14ece24fcc Migrate more GL calls of GrBackend* (flutter/engine#44682) 
Follow-up to https://github.com/flutter/engine/pull/44334

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-08-14 13:20:23 -04:00