Tess Strickland
ddc0866e8f
Add more entry-point annotations for test-only code. ( #160421 )
...
This change adds entry-point annotations to methods and classes accessed
by native code during Flutter tests. Currently, entry point annotations
are not checked by the Dart VM when running in JIT mode, only in AOT
mode. In order to also enforce entry point annotations in JIT mode,
first tests in Flutter must be appropriately annotated to avoid roll
failures.
Related issues:
* https://github.com/flutter/flutter/issues/118608
* https://github.com/dart-lang/sdk/issues/50649
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-17 11:40:14 +00:00
engine-flutter-autoroll
8631412f25
Roll Flutter Engine from 23731d6a967d to 5a7ccbc4f6fa (1 revision) ( #160408 )
...
23731d6a96...5a7ccbc4f6skia-flutter-autoroll@skia.org Roll Dart SDK from
7ed58b3c462a to 930f66fab234 (1 revision) (flutter/engine#57235 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 06:54:21 +00:00
Matan Lurey
27ef1967b0
Rename and define FlutterManifest.generateLocalizations. ( #160401 )
...
Part of https://github.com/flutter/flutter/issues/102983 .
`<FlutterManifest>.generateSyntheticPackage` _never_ meant generate a
synthetic package 😒 , it only meant "we _might_ need to generate a
synthetic package because localizations are being generated and the
default, unless otherwise specified, is to generate a synthetic
package".
Renamed as `generateLocalizations` and added some strategic TODOs in
places where removing the `package:flutter_gen` feature
(https://github.com/flutter/flutter/issues/102983 ) will allow us to
cleanup this erroneous code and technical debt.
Simplified a bit code (just a refactor) in the process, and fixes a bug
that `flutter packages get` would generate internationalization files
even if `flutter: generate: true` was not present in `pubspec.yaml` that
was revealed as part of fixing this up.
/cc @sigurdm.
2024-12-17 04:29:14 +00:00
Matan Lurey
eb926ea840
Consistently set Cache.flutterRoot in create_test.dart. ( #160403 )
...
Without this change, the order that tests run matter and it's easy to
add tests without remembering this flag.
(There are existing tests that forgot it too, they just happen to work
if shuffled in a way that, well, works)
2024-12-17 03:15:07 +00:00
Matan Lurey
cb8c15c4f3
Replace --no-implicit-pubspec-resolution with flutter config --explicit-package-dependencies. ( #160400 )
...
This was a mistake, and should have already been removed and cleaned up.
Part of https://github.com/flutter/flutter/issues/160257 .
2024-12-17 03:11:07 +00:00
engine-flutter-autoroll
fb67b0c56b
Roll Flutter Engine from 90c9185be6a5 to 23731d6a967d (2 revisions) ( #160404 )
...
90c9185be6...23731d6a96skia-flutter-autoroll@skia.org Roll Skia from 2c5159518cf2 to
fbc41b0b55a1 (1 revision) (flutter/engine#57231 )
2024-12-17 skia-flutter-autoroll@skia.org Roll Dart SDK from
4bfbad776c1a to 7ed58b3c462a (1 revision) (flutter/engine#57230 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 03:07:34 +00:00
engine-flutter-autoroll
0c7f02085e
Roll Flutter Engine from 1d2eb3f6ac5f to 90c9185be6a5 (1 revision) ( #160399 )
...
1d2eb3f6ac...90c9185be6goderbauer@google.com Pre-format licenses script
(flutter/engine#57219 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 02:11:26 +00:00
engine-flutter-autoroll
256a127da3
Roll Flutter Engine from 4944aebc5015 to 1d2eb3f6ac5f (2 revisions) ( #160396 )
...
4944aebc50...1d2eb3f6acgoderbauer@google.com Properly report `dart format` errors
(flutter/engine#57206 )
2024-12-16 skia-flutter-autoroll@skia.org Roll Skia from 7fc6934b2034 to
2c5159518cf2 (1 revision) (flutter/engine#57229 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 01:17:07 +00:00
Michael Goderbauer
9802c1cde7
Normalize localizations with dartfmt in presubmit check ( #160395 )
...
Makes the presubmit check independent of whether the files in the repo
are dartfmt formatted or not.
2024-12-17 01:07:17 +00:00
Michael Goderbauer
79506323b9
Adjust tools tests that would be broken by formatting ( #160393 )
...
These tests depend on line numbers that `dart format` is changing.
Pre-format the files in question and adjust the tests so they continue
to pass when the entire repo is formatted.
2024-12-17 00:34:00 +00:00
Michael Goderbauer
e19e117c37
Fix line-dependent tests for formatting ( #160389 )
...
These tests are dependent on line numbers. This formats them and updates
the line number to take them off the critical path.
2024-12-17 00:29:51 +00:00
engine-flutter-autoroll
43ee8029c9
Roll Flutter Engine from eac3180b2366 to 4944aebc5015 (1 revision) ( #160392 )
...
eac3180b23...4944aebc50skia-flutter-autoroll@skia.org Roll Skia from 8054b098b5cd to
7fc6934b2034 (14 revisions) (flutter/engine#57227 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 00:14:14 +00:00
Michael Goderbauer
06dd9a3525
Properly report dart format errors ( #160364 )
...
This applied the improvements from
https://github.com/flutter/engine/pull/57206 to the flutter/flutter
version of that script (hopefully, we can deduplicate this soon with the
repo merge).
2024-12-16 23:35:01 +00:00
engine-flutter-autoroll
4a6ae1ebab
Roll Flutter Engine from 61616ace5fa8 to eac3180b2366 (3 revisions) ( #160386 )
...
61616ace5f...eac3180b23skia-flutter-autoroll@skia.org Manual roll Dart SDK from
02aa27c6a075 to 4bfbad776c1a (12 revisions) (flutter/engine#57226 )
2024-12-16 skia-flutter-autoroll@skia.org Roll Dart SDK from
02aa27c6a075 to 4bfbad776c1a (12 revisions) (flutter/engine#57224 )
2024-12-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
iYz_WkWk1uPr8BLSZ... to zvsXvTuk-Z1Mgtn34... (flutter/engine#57222 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from iYz_WkWk1uPr to zvsXvTuk-Z1M
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 23:15:23 +00:00
Matan Lurey
81f628f340
Migrate mac_test.dart to explicit-package-dependencies. ( #160375 )
...
Fixes forward <https://github.com/flutter/flutter/issues/160257 > that
will happen when this flag is enabled
([example](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8728366579836767153/+/u/run_test.dart_for_tool_tests_shard_and_subshard_general/stdout )).
2024-12-16 22:59:17 +00:00
Matan Lurey
f177d8aab4
Migrate test/commands.shard (mostly) to explicit-package-dependencies. ( #160288 )
...
Towards https://github.com/flutter/flutter/issues/160257 .
I intentionally skipped `create_test.dart`, as that requires updating
the generated template which uses l10n, a feature changing. I'll do that
in the "big bang" PR that finally enables the feature to avoid getting
us into a bad state.
2024-12-16 22:59:16 +00:00
Kevin Chisholm
abe3f4014f
Merges changes from stable changelog to master. ( #160284 )
...
Merges changes to master to match stable.
2024-12-16 22:49:11 +00:00
Matan Lurey
256ad9f9cb
Move integration_test dependencies to non-dev_dependencies. ( #160380 )
...
First part of https://github.com/flutter/flutter/issues/160379 .
This should be a NOP, because without the
`explicit-package-dependencies` feature flag, all dependencies
(including dev_dependencies) are considered, for the purposes of
plugins, non-dev dependencies.
This change prepares for flipping that flag, so when the flip occurs, it
is _also_ a NOP for these tests.
2024-12-16 22:42:01 +00:00
engine-flutter-autoroll
71f140ee16
Roll Flutter Engine from 0dfbd04106ed to 61616ace5fa8 (3 revisions) ( #160385 )
...
0dfbd04106...61616ace5frobert.ancell@canonical.com Migrate FlBinaryMessenger using
embedder API instead of mock engine. (flutter/engine#57214 )
2024-12-16 brett.morgan@gmail.com Flutter-GPU.md: Fix spelling
(flutter/engine#57216 )
2024-12-16 mdebbar@google.com [web] Don't close image source too early
(flutter/engine#57200 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 22:16:05 +00:00
Matan Lurey
18f56e3224
Refactor TestGoldenComparator to be useful for non-web (Android, iOS) integration tests ( #160215 )
...
Part of https://github.com/flutter/flutter/issues/160043 , makes it
easier to add https://github.com/flutter/flutter/pull/160131 .
This PR has no functional changes to any of the code, but does refactor
both the code and tests:
- Makes a number of always non-null but not migrated to non-null
properties, well, not-null
- Creates two concrete methods (`update` and `compare` versus a
positional nullable boolean)
- Uses type signatures instead of `String?` to explain the possible
results of the methods
- Renames the mysterious `shellPath` variable to `flutterTesterBinPath`
- Expands and rewrites internally-facing doc comments
- Moves `WebRenderer` environment variable setting to
`flutter_web_platform.dart`
- Makes the tests have less duplication, and check for update/compare
cases
After this PR, I can use it in the non-web branch of the Flutter tool
without any hacks or TODOS :)
/cc @eyebrowsoffire (trivial web refactoring), @camsim99 (changes being
made to tool).
2024-12-16 22:08:54 +00:00
Michael Goderbauer
8fee7cb832
Adjust ignores for 'dart format' ( #160382 )
...
When running `dart format` over these lines the `// ignore` ended up on
a line where it wasn't properly ignoring the lint. This adjusts the
placement of `// ignore`s so they will continue to ignore the right
thing even after the code is auto formatted.
I am hoping that if we do this now the large PR that formats the entire
repo will go in smoother without manual intervention.
2024-12-16 22:01:25 +00:00
Ben Konyi
6159f2eef6
Manual pub roll with flutter_tools patch ( #160174 )
...
Fixes: https://github.com/flutter/flutter/issues/160055
2024-12-16 21:41:54 +00:00
Reid Baker
17960e7c1e
Ignore cxx folders for all of flutter/flutter ( #160381 )
...
Related to https://github.com/flutter/flutter/issues/160372
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2024-12-16 21:38:55 +00:00
engine-flutter-autoroll
cff545c9f9
Roll Flutter Engine from d373a934d413 to 0dfbd04106ed (5 revisions) ( #160376 )
...
d373a934d4...0dfbd04106skia-flutter-autoroll@skia.org Roll Skia from 8c1e2bf9492c to
8054b098b5cd (5 revisions) (flutter/engine#57197 )
2024-12-16 goderbauer@google.com Reland 'Delete stale
package_config.json in gclient sync hook' (flutter/engine#57218 )
2024-12-16 MyriadSoft@users.noreply.github.com docs: Fix RGB565 format
documentation and bit masks (flutter/engine#57210 )
2024-12-16 jonahwilliams@google.com [Impeller] disable AHB swapchains on
all platforms. (flutter/engine#57213 )
2024-12-16 jonahwilliams@google.com [Impeller] fix Adreno precision
issue in gaussian downsample. (flutter/engine#57212 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 21:16:21 +00:00
Andrew Kolos
c803c1346f
Remove more references to deprecated package:usage (executable, runner) ( #160369 )
...
Helps https://github.com/flutter/flutter/issues/150575
<details>
<summary> Pre-launch checklist </summary>
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
</details>
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-16 20:39:43 +00:00
Flutter GitHub Bot
98e5ce7ed7
Marks Linux_android_emu android_defines_test to be unflaky ( #159538 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android_emu android_defines_test"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android_emu%20android_defines_test%22 ).
This test can be marked as unflaky.
2024-12-16 20:12:03 +00:00
Gray Mackall
b19b68074f
Fix regression to hardcoded AGP/Kotlin values in Android module templates ( #160108 )
...
https://github.com/flutter/flutter/pull/159770 regressed the module
templates to use a hardcoded `8.7.0` and `1.8.22` as the AGP and Kotlin
versions respectively. This PR returns them to using the template
context values.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2024-12-16 19:59:00 +00:00
Alex Li
a0f2424e2e
🐛 [tool] Do not handle directory arguments implicitly for pub commands ( #160223 )
...
- Resolves https://github.com/flutter/flutter/issues/144898
- Resolves https://github.com/flutter/flutter/issues/160145
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-16 19:55:04 +00:00
Christopher Fujino
2bda0ccc75
re-enable linux packages-autoroller ( #160266 )
...
I fixed the autoroller in https://github.com/flutter/flutter/pull/160059
but forgot to mark the shard non-bring-up. Note, it's currently failing
in post-submit, but only because bringUp shards run in the staging pool,
which does not have access to the GitHub access token necessary for the
roller to operate.
2024-12-16 19:51:25 +00:00
Michael Goderbauer
55d7341a66
Formatter pre-work: Fix syntax in test_fixes ( #160371 )
...
* removes an extra `)` in `app_bar.dart`
* Moves class definitions and getter definition out of the `main` method
in `widget_state.dart` (defining classes/getters inside of methods is
not allowed in Dart)
The formatter was stumbling over these syntax errors.
2024-12-16 19:50:40 +00:00
engine-flutter-autoroll
fbb312169c
Roll Packages from 56886ffe11ad to eb7358231e43 (6 revisions) ( #160351 )
...
56886ffe11...eb7358231eflutter/packages#8306 )
2024-12-14 engine-flutter-autoroll@skia.org Manual roll Flutter from
6966a2eef1e9 to 29a6c648ca4d (16 revisions) (flutter/packages#8295 )
2024-12-13 jessiewong401@gmail.com Bump Camera Example Plugin Apps
Targetsdk Versions (flutter/packages#8193 )
2024-12-13 astivi@users.noreply.github.com [google_adsense] Adds H5
Games Ads support to package. (flutter/packages#7747 )
2024-12-13 cepadilla@google.com [camera_android_camerax] Remove nonnull
annotation from getDefaultPointSize (flutter/packages#8292 )
2024-12-13 tarrinneal@gmail.com [shared_preferences] Adds Shared
preferences as option in shared preferences async android
(flutter/packages#7994 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 19:49:00 +00:00
engine-flutter-autoroll
6b6227e6c3
Roll Flutter Engine from 330210f44aa6 to d373a934d413 (1 revision) ( #160356 )
...
330210f44a...d373a934d4jason-simmons@users.noreply.github.com Disable RBE in the GN
flags for wasm_release builds in the linux_web_engine builder
(flutter/engine#57204 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 19:49:00 +00:00
Matan Lurey
daaceacb30
Fix a bug to skip flutter_gen when synthetic packages are disabled ( #160367 )
...
Without this bug fix, when flipping the flag a lot of things blow up :)
(https://github.com/flutter/flutter/pull/160289 as an example of needing
this)
2024-12-16 19:33:34 +00:00
Matan Lurey
1c52436853
Skip integration tests that consistently OOM on a Windows platform. ( #160368 )
...
Towards https://github.com/flutter/flutter/issues/157640 .
As far as I can tell, these test cases add no value to be running
specifically on Windows (they are testing general tool functionality),
and it's on [Windows specifically that the tests have the most problems
with OOM and
timeout](https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Windows%20tool_integration_tests_2_9 ).
2024-12-16 19:14:58 +00:00
engine-flutter-autoroll
ad4a1212dc
Roll Flutter Engine from 159090f6f40f to 330210f44aa6 (1 revision) ( #160323 )
...
159090f6f4...330210f44arobert.ancell@canonical.com Migrate FlEventChannel tests to
FlMockBinaryMessenger (flutter/engine#57150 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 00:55:26 +00:00
engine-flutter-autoroll
68a57709d8
Roll Flutter Engine from a9f7fa8ca613 to 159090f6f40f (1 revision) ( #160321 )
...
a9f7fa8ca6...159090f6f4robert.ancell@canonical.com Migrate FlMethodChannel tests to
FlMockBinaryMessenger (flutter/engine#57146 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-15 23:18:32 +00:00
Mohammed CHAHBOUN
a4be7cd70a
Added Mohammed Chahboun to authors ( #160311 )
...
Adds [Mohammed
Chahboun](https://github.com/flutter/flutter/pulls/M97Chahboun ) to
authors
2024-12-15 17:46:19 +00:00
engine-flutter-autoroll
7877a076a6
Roll Flutter Engine from 4e4a430bcd0d to a9f7fa8ca613 (1 revision) ( #160294 )
...
4e4a430bcd...a9f7fa8ca6goderbauer@google.com Adjust some ignores for 'dart format'
(flutter/engine#57208 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-14 03:46:08 +00:00
engine-flutter-autoroll
fc9124cb4f
Roll Flutter Engine from c4e3cc27afef to 4e4a430bcd0d (2 revisions) ( #160291 )
...
c4e3cc27af...4e4a430bcdgoderbauer@google.com Fix include path in fuchsia's
analysis_options.yaml files (flutter/engine#57203 )
2024-12-13 goderbauer@google.com Delete stale package_config.json in
gclient sync hook (flutter/engine#57195 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-14 02:47:38 +00:00
engine-flutter-autoroll
e7fcd0d6e6
Roll Flutter Engine from f0ff4f25bda8 to c4e3cc27afef (5 revisions) ( #160290 )
...
f0ff4f25bd...c4e3cc27afjason-simmons@users.noreply.github.com [skwasm] Fix
implementation of SkwasmPath.relativeLineTo (flutter/engine#57201 )
2024-12-13 30870216+gaaclarke@users.noreply.github.com Made compilation
error colors come through et. (flutter/engine#57174 )
2024-12-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
iWMEbVYaNdH8RJmXZ... to iYz_WkWk1uPr8BLSZ... (flutter/engine#57198 )
2024-12-13 yjbanov@google.com [web] allow imports to line-break
(flutter/engine#57170 )
2024-12-13 41930132+hellohuanlin@users.noreply.github.com [ios]limit web
view not tappable workaround to a limited depth (flutter/engine#57193 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from iWMEbVYaNdH8 to iYz_WkWk1uPr
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-14 01:47:26 +00:00
Matan Lurey
0875988f5f
Migrate flutter_command_test.dart to explicit-package-dependencies. ( #160274 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-14 00:08:28 +00:00
Matan Lurey
5e7c856d5b
Migrate test/general.shard/*plugin* tests to explicit-package-dependencies. ( #160279 )
...
Towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 23:18:07 +00:00
Matan Lurey
14177eaa7c
Migrate the rest of general.shard to explicit-package-dependencies. ( #160280 )
...
Towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 23:14:22 +00:00
Matan Lurey
b008e5b60c
Migrate resident_web_runner_test.dart to explicit-package-dependencies. ( #160278 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 22:56:05 +00:00
Matan Lurey
15517f0569
Migrate hot_test.dart to explicit-package-dependencies. ( #160277 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 22:43:21 +00:00
Matan Lurey
6bcb15db63
Migrate cocoapods_test.dart to explicit-package-dependencies. ( #160264 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 22:37:08 +00:00
Matan Lurey
96aeed4591
Migrate test/general.shard/build_system to explicit-package-dependencies. ( #160275 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 22:30:38 +00:00
Matan Lurey
61025ca2dd
Migrate test/general.shard/web to explicit-package-dependencies. ( #160273 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 22:22:21 +00:00
Matan Lurey
5332e696a4
Migrate generate_synthetic_packages_test.dart to explicit-package-dependencies. ( #160267 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
Unlike some of the other PRs, this test explicitly _opts-out_ of the
flag, as the test itself is testing whether the now deprecated feature
works.
2024-12-13 22:22:12 +00:00
Matan Lurey
47403e351e
Migrate test_compiler_test.dart to explicit-package-dependencies. ( #160265 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 22:21:58 +00:00
