19274 Commits

Author SHA1 Message Date
Jia Hao
dd6dd7aef1
Fix tracing of startup events (#59982)
When `retainPriorEvents` is passed as true, the current behavior still limits timeline events to the timestamp after `traceEvents` is called. This can cause startup events to be missing.

This fixes it by passing null to `stopTracingAndDownloadTimeline` for the start and end time.

Related: #58430
2020-06-23 08:07:05 +08:00
Jonah Williams
55abbb6be6
[flutter_tools] track null safety usage (#59822)
* [flutter_tools] track null safety usage

* Update flutter_command_test.dart

* cleanups
2020-06-22 17:05:01 -07:00
Jonah Williams
09f1764d14
[flutter_tools] android test cleanups (#59996)
Fixes several tests that were failing under tester. Minor style cleanups otherwise
2020-06-22 17:04:39 -07:00
Jonah Williams
a734693ff5
[flutter_tools] cleanup iOS test (#59999)
The test needs to look up HOME, but one wasn't provided. This would end up using the real home directory, crashing on windows
2020-06-22 17:04:17 -07:00
Jonah Williams
8e9b78728f
[flutter_tools] switch linux desktop feature on (#60018)
Enable linux desktop feature on dev channel
2020-06-22 17:04:01 -07:00
rami-a
e676024d37
[Material] Redesign Time Picker (#59191) 2020-06-22 17:03:04 -07:00
Jonah Williams
2cd205bb5a
[flutter_tools] cleanup fuchsia tests (#59997)
Cleanup fuchsia tests that failed under tester.
2020-06-22 16:47:28 -07:00
renyou
eaf9ff738a
Revert "Implement Comparable<TimeOfDay> (#59317)" (#59981)
This reverts commit 2933e895e52117bf55b17023767dd6cebf500d86.
2020-06-22 11:53:54 -07:00
renyou
a88e2c8742
Revert "fix the widget span layout when text scale factor != 1 (#59711)" (#59986)
This reverts commit 747fe345f1b0609ea0c9aa32c1719372d0ccc661.
2020-06-22 11:53:14 -07:00
Jonah Williams
04ce9d288c
Revert "Fix outline button solid path when BorderSize.width is used (#51581)" (#60000)
This reverts commit 599566177736e6b30af922a8f06e8a260acafc36.
2020-06-22 10:13:37 -07:00
Ferhat
5995661777
Fix outline button solid path when BorderSize.width is used (#51581) 2020-06-19 16:15:58 -07:00
engine-flutter-autoroll
a732652b94
Roll Engine from f1355815488f to 676cd566f731 (7 revisions) (#59892) 2020-06-19 16:13:01 -07:00
Sam Rawlins
252a3261c4
Remove unused import which shares prefix name with a used import. (#59160)
Due to a bug in analyzer [1], some unused imports are not reported when
multiple import directives share a prefix name, and one or more are unused.

[1] https://github.com/dart-lang/sdk/issues/38784
2020-06-19 15:25:13 -07:00
Anna Gringauze
aac836c6ad
Enabled expression evaluation by default (#59826) 2020-06-19 15:23:03 -07:00
Jonah Williams
fbdc79e448
[versions] update all versions (#59832)
Fixes #59718

Update all versions, specifically dwds which has a hot restart fix
2020-06-19 14:48:57 -07:00
engine-flutter-autoroll
93fde27483
Roll Engine from b5f5e6332cb4 to f1355815488f (5 revisions) (#59818) 2020-06-19 14:03:02 -07:00
Helin Shiah
f7a09bd2df
Add integration tests for structured error (#59809) 2020-06-19 13:58:03 -07:00
Justin McCandless
b9af6551b2
Label unnecessarily ellided (#59807) 2020-06-19 13:53:05 -07:00
Tong Mu
65b1956005
Add benchmark for Mouse region (web) (#59803) 2020-06-19 13:48:04 -07:00
Michael Goderbauer
e48b7e99cd
More word substiturions (#59497) 2020-06-19 13:43:02 -07:00
Jason Simmons
4173881bbf
Fix the paste button label in the new version of the filtered text pasting test (#59865) 2020-06-19 12:41:29 -07:00
Andrew Chen
2933e895e5
Implement Comparable<TimeOfDay> (#59317) 2020-06-19 12:18:03 -07:00
Christopher Fujino
5cfb16b193
Re-land "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59876)
This relands #59120, which was reverted in #59870.
2020-06-19 12:03:38 -07:00
Christopher Fujino
0d7ff7a9e7
Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59870)
This reverts commit 8665e13801fe6b53a0e67866d2ee6cd5ef2083f4.
2020-06-19 10:52:52 -07:00
Ian Hickson
8665e13801
Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120) 2020-06-18 18:08:01 -07:00
Jonah Williams
dec7423b44
Revert "Add the ability to ignore lines depending on comments (#58656)" (#59813)
This reverts commit df02518dc98bd5109dd4a3473884fbce0fc8b837.
2020-06-18 17:15:50 -07:00
Robert Ancell
e6de0de8f7
Fix Linux shell window default size (#59630)
The previous call set the minimum size, not just the initial size.
2020-06-19 11:56:01 +12:00
Jenn Magder
f41f795640
Clean up PollingDeviceDiscovery dispose (#59709) 2020-06-18 16:38:02 -07:00
Justin McCandless
339f0363a6
Reland modernize selection menu appearance (#59617) 2020-06-18 16:33:03 -07:00
Robert Ancell
dd9fd2c851
Use a HeaderBar for Linux applications. (#59714) 2020-06-19 11:30:36 +12:00
Chris Bracken
e0f60918d4
Roll the engine from 965fbbe to b5f5e63 (#59804)
This rolls the engine from:
965fbbed1776545ee681cb57f3fb1d0c2000bbcb to
b5f5e6332cb4987e9e38ffaa267733ec0a8705ba. A Dart SDK roll in this range
changed the format of the compileExpression RPC VMService endpoint,
necessitating a tool patch.
2020-06-18 16:12:54 -07:00
James D. Lin
bdbe6774a3
[flutter tools] Change the desktop device names and IDs (#58812)
In google3, the Linux device is always available, and it has confused
people who run the Flutter doctor and see
"• Linux • Linux • linux-x64 • Linux" listed.

Rename the Linux device name to "Linux desktop" and the device ID to
be "linux". Make similar changes to the Windows and macOS
devices for consistency.  This is also  consistent with the web
devices.

The device ID change shouldn't be break -d usage since that does a
case-insensitive prefix match.
2020-06-18 15:30:00 -07:00
Jonah Williams
e72d26a720
Revert "flutter.gradle: collect list of Android plugins from .flutter-plugins-dependencies (#59294)" (#59810)
This reverts commit 947b48e062b6f2f00aa2f2b995677c0e101ab12d.
2020-06-18 15:19:12 -07:00
Igor Akkerman
947b48e062
flutter.gradle: collect list of Android plugins from .flutter-plugins-dependencies (#59294) 2020-06-18 14:08:01 -07:00
stuartmorgan
e85655c48e
Specify encoding for vswhere output (#59607)
On Windows, Process.run assumes the output uses the system codepage by default. This allows specifying it in our wrapper, and sets the encoding for vswhere to UTF-8 since we're passing a flag that forces it to use UTF-8 output.

Fixes #53515
2020-06-18 14:00:46 -07:00
Michael Goderbauer
32be39bf16
Fix doc for DecoratedBox (#59791) 2020-06-18 13:58:02 -07:00
Greg Spencer
6db22118ad
Make flutter and dart scripts invoke their batch file equivalents on Windows (#59789)
This makes the flutter and dart scripts invoke their batch file equivalents if running under MINGW (i.e. git-bash) on Windows.

This allows for proper locking, and makes sure that people aren't using two different (and non-mutally-aware) locking systems when running flutter on Windows.

I also fixed a couple of places where we look for MINGW32, which fails under MINGW64. It just looks for MINGW now.
2020-06-18 13:29:24 -07:00
Jonah Williams
01e09ea8af
[flutter_tools] add missing null-safety flags (#59773)
Some of the null-safety commands were missing - plumb them through. Ensure that verbose mode shows their output, and clean up the messaging around sound-null-safety.

Fixes #59769

Adds a test that validate each of the null safety supporting build commands has everything plumbed through.
2020-06-18 12:34:35 -07:00
Darren Austin
06de567811
Dismiss modal routes with a keyboard shortcut (#59310) 2020-06-18 11:53:02 -07:00
Jose Alba
c6f6de6d1b
Chips text scaling (#57745) 2020-06-18 11:48:03 -07:00
Jonah Williams
5e77083b8d
[flutter_tools] make parent logger optional (#59786)
The addition of the non-optional parent logger broke the google3 roll. Make it optional so we can roll
2020-06-18 11:44:29 -07:00
Jonah Williams
d4e1448b95
[devicelab] fix concurrent hot reload test: stderr != failure (#59784)
The tool needs to start outputing trace text to stderr to avoid breaking machine mode. This test is bogus, and should use the exit code.
2020-06-18 11:15:45 -07:00
Pasindu De Silva
df02518dc9
Add the ability to ignore lines depending on comments (#58656)
https://github.com/dart-lang/coverage - 0.14.0 added the ability to be able to ignore coverage depending on comments.

// coverage:ignore-line to ignore one line.
// coverage:ignore-start and // coverage:ignore-end to ignore range of lines inclusive.
// coverage:ignore-file to ignore the whole file.
2020-06-18 10:34:42 -07:00
Jonah Williams
447e3d3f38
[flutter_tools] remove globals from compilers (#59184)
Refactors KernelCompiler and ResidentCompiler to no longer use globals (except as a fallback for g3 migration). Improves the compilation error when running flutter test on a package without a flutter_test dependency.

Updates machine mode to output trace text to stderr
2020-06-18 10:33:17 -07:00
Jonah Williams
e1f4cfb4f4
[flutter_tools] add toggle b and service extension to change platform brightness (#59571)
A frequent request from the last Flutter developer survey was for an easier method of testing light/dark mode changes. Currently, a user needs to manually change the theme settings or adjust phone settings to see the difference. Instead we should add a toggle from the CLI, and eventually devtools/Intellij/Vscode that allows developers to override the current setting.

Fixes #59495

Adds flutter.ext.brightnessOverride service protocol which either queries the current platform brightness, or overrides it to a new value. This accepts either Brightness.light or Brightness.dark as a value.

Adds a CLI toggle b which allows the setting to be toggled manually.

Requires an update to the MediaQuery, to conditionally use a debug override when not in release mode
2020-06-18 10:32:43 -07:00
Chris Bracken
f39ab52221
Revert "Manual engine roll to update format of compileExpression RPC response (#59717)" (#59774)
Failing dev/integration_tests/ui/test_driver/keyboard_resize_test.dart
Also timing out on new_gallery_ios__transition_perf

This reverts commit c7a37c72c2d4f74faac718abf7599b1f8d59aaa9.
2020-06-18 09:52:44 -07:00
Ben Konyi
c7a37c72c2
Manual engine roll to update format of compileExpression RPC response (#59717) 2020-06-18 09:18:03 -07:00
chunhtai
747fe345f1
fix the widget span layout when text scale factor != 1 (#59711) 2020-06-18 08:28:03 -07:00
Christopher Fujino
9fe61f7b77
skip fuchsia_precache-linux on release branches (#59705) 2020-06-18 08:23:02 -07:00
Jonah Williams
719ea5a8c0
[flutter_tools] make expando on vm service null safe to handle web stuff (#59624) 2020-06-18 08:18:04 -07:00