DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
29,232 Commits 882 Branches 1,069 Tags
Commit Graph

22462 Commits

Author SHA1 Message Date
Tong Mu
dc666a37db Revert "[Rasterizer] Make resubmit information temporary" (flutter/engine#42455) 
Reverts flutter/engine#42001 due to being the likely culprit to
flakiness https://github.com/flutter/flutter/issues/127936 .
 2023-06-01 21:50:47 -07:00
skia-flutter-autoroll
71b934be4a Roll Skia from f4854a3d009d to 0c75f1877b37 (1 revision) (flutter/engine#42505) 
https://skia.googlesource.com/skia.git/+log/f4854a3d009d..0c75f1877b37

2023-06-02 johnstiles@google.com Add WGSL support for for-loops.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-02 04:48:37 +00:00
skia-flutter-autoroll
859e478628 Roll Dart SDK from 0d3c310fd6d9 to 3d4d29d8f16b (3 revisions) (flutter/engine#42502) 
https://dart.googlesource.com/sdk.git/+log/0d3c310fd6d9..3d4d29d8f16b

2023-06-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-163.0.dev
2023-06-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-162.0.dev
2023-06-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-161.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-02 00:51:22 +00:00
skia-flutter-autoroll
90caff0bbc Roll Skia from 082a7d1f72f7 to f4854a3d009d (4 revisions) (flutter/engine#42500) 
https://skia.googlesource.com/skia.git/+log/082a7d1f72f7..f4854a3d009d

2023-06-01 jamesgk@google.com [ganesh] Use full-width floats when calculating dst read coords
2023-06-01 brianosman@google.com Replace skvx::bit_pun with sk_bit_cast
2023-06-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from dbffa5d3af55 to e21ecd1b59f7 (3 revisions)
2023-06-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from f2d6835ec116 to 01f6b3d42c73 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-02 00:07:10 +00:00
godofredoc
a11ac35035 Do not retry lint or clang tidy tests. (flutter/engine#42498) 
Retries on lints and clang tidy were hiding the issues as timeouts rather than providing the fail signal right away.

Bug: https://github.com/flutter/flutter/issues/128083

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-01 23:48:20 +00:00
Dan Field
bc1510d361 [Impeller] Compute in Vulkan (flutter/engine#42294) 
Fixes https://github.com/flutter/flutter/issues/110622

- Updates capabilities checks for support
- Fixes a bug where SSBOs were being treated as UBOs in render (and does the same work in compute).
- Fixes CommandEncoderVK::Submit so that it takes a completion callback and CommandBufferVK uses it to avoid sending a `kComplete` status to callers when it should really be `kPending`.
 2023-06-01 23:40:51 +00:00
Jonah Williams
b06489fa4b [Impeller] Emplace directly into host buffer (avoid VBB) for text data (flutter/engine#42484) 
From local testing, this shaves off about 0.3-4 ms of pure allocation overhead from https://github.com/flutter/flutter/issues/127760

### Before

![image](https://github.com/flutter/engine/assets/8975114/55701559-fba8-4f11-b606-f819d197626e)

### After

![image](https://github.com/flutter/engine/assets/8975114/b6843c13-d6c7-4364-86b1-c78e216307b3)
 2023-06-01 22:34:58 +00:00
John McCutchan
d72aace3ef Ensure PlatformView engine life cycle callbacks are invoked (flutter/engine#42491) 
- Move some code off of the message handler onto the parent class.
- Call the engine life cycle callbacks on PlatformView regardless of
which mode is used.
- Re-enable and fix test that these callbacks are invoked.

Fixes [#120329](https://github.com/flutter/flutter/issues/120329)

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-01 14:51:25 -07:00
skia-flutter-autoroll
8bcecafd93 Roll Skia from c408e8e9cc96 to 082a7d1f72f7 (8 revisions) (flutter/engine#42496) 
https://skia.googlesource.com/skia.git/+log/c408e8e9cc96..082a7d1f72f7

2023-06-01 cmumford@google.com [infra] temporarily remove RadeonHD8870M-x86_64-Debug-All-Graphite_Metal from CQ
2023-06-01 brianosman@google.com Some SkVx cleanup and safety checks
2023-06-01 brianosman@google.com Refine type-checking in sk_unaligned_load/store
2023-06-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 552e7468f687 to dbffa5d3af55 (2 revisions)
2023-06-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from b07eb69df10e to e9d745270f47 (2 revisions)
2023-06-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 879c15fdcc06 to f2d6835ec116 (4 revisions)
2023-06-01 brianosman@google.com Workaround clang/GCC bug (attributes on re-declared constructors)
2023-06-01 johnstiles@google.com Improve sin/cos algorithm in Raster Pipeline.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-01 21:08:08 +00:00
Bruno Leroux
849e5fb2f6 [Windows - TextInput] Insert new line only when TextInputAction.newline (flutter/engine#42244) 
## Description

This PR updates the Windows text input plugin to avoid adding a new line on a multiline text field when action is not set to `TextInputAction.newline`.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/125879 as Linux and macOS implementations are merged.
Linux PR: https://github.com/flutter/engine/pull/41895
macOS PR: https://github.com/flutter/engine/pull/41977

## Tests

Adds 2 tests.
 2023-06-01 20:59:13 +00:00
Zachary Anderson
8c01f4088b Revert "Move clang tidy v2 build to prod." (flutter/engine#42495) 
Reverts flutter/engine#41985

This is also suffering some the same issue as the Linux clang-tidy shards reverted in https://github.com/flutter/engine/pull/42434.

e.g.
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20mac_clang_tidy/867/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/210269/overview
 2023-06-01 20:54:08 +00:00
林洵锋
54b32090de Add myself to AUTHORS (flutter/engine#42406) 
🎉 [PR](https://github.com/flutter/engine/pulls?q=author%3ALinXunFeng)
 2023-06-01 20:22:12 +00:00
Brandon DeRosier
666563a554 [Impeller] Add Impeller Metal support in the embedder API (flutter/engine#42411) 
Part of https://github.com/flutter/flutter/issues/112230.

Now seemed like the right time to sneak this in:
* We have large desktop refactors on the horizon (multi-window).
* We're starting to land optimizations that complicate the surface behavior such as wide gamut and dirty regions.
* We have plans to migrate the iOS embedder to use the embedder API (https://github.com/flutter/flutter/issues/112232).

![Screenshot 2023-05-30 at 6 59 48 PM](https://github.com/flutter/engine/assets/919017/16616be8-f94e-42ba-8a97-4ce4aa29e662)
 2023-06-01 20:10:58 +00:00
toneyzeng
8c80858576 Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem. (flutter/engine#42153) 
Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem.

![image](https://github.com/flutter/engine/assets/5031712/48bb95c1-10b3-4736-a42e-46281d355cd3)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-01 20:07:18 +00:00
Callum Moffat
7daf5e001c Fix crash getting spell-check suggestions (flutter/engine#42466) 
On some Samsung devices Flutter with spell-check enabled will crash when typing/moving near the ">" character. 

Stack trace is

```
Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'int android.view.textservice.SentenceSuggestionsInfo.getSuggestionsCount()' on a null object reference
       at io.flutter.plugin.editing.SpellCheckPlugin.onGetSentenceSuggestions(SpellCheckPlugin.java:26)
       at android.view.textservice.SpellCheckerSession.lambda$handleOnGetSentenceSuggestionsMultiple$1$android-view-textservice-SpellCheckerSession(SpellCheckerSession.java:224)
       at android.view.textservice.SpellCheckerSession$$ExternalSyntheticLambda0.run(:4)
       at android.os.Handler.handleCallback(Handler.java:942)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:226)
       at android.os.Looper.loop(Looper.java:313)
       at android.app.ActivityThread.main(ActivityThread.java:8747)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)
```
 2023-06-01 19:37:16 +00:00
Brandon DeRosier
205d491371 Fix lint in rectangle packer (flutter/engine#42489) 2023-06-01 11:54:09 -07:00
Jason Simmons
d473f0d24d Wait for GL command completion in the ExternalTextureGLRefreshedTooOften test (flutter/engine#42438) 
This test sometimes caused assertion failures when running on Windows with ANGLE.  The process may be unable to safely clean up global objects if GL commands are pending when the test exits.
 2023-06-01 18:46:16 +00:00
Mouad Debbar
8c89ed143a Reland "[web] Remove the JS API for url strategy (#42134)" (flutter/engine#42486) 
Initially landed in https://github.com/flutter/engine/pull/42134
Then reverted in https://github.com/flutter/engine/pull/42468

It failed because we changed `UrlStrategy` to an `interface` which prevents "extending".

The only change in the reland is the removal of the `interface` keyword.
 2023-06-01 18:22:03 +00:00
skia-flutter-autoroll
d465bbec19 Roll Skia from f5bc3d12f0eb to c408e8e9cc96 (9 revisions) (flutter/engine#42487) 
https://skia.googlesource.com/skia.git/+log/f5bc3d12f0eb..c408e8e9cc96

2023-06-01 michaelludwig@google.com [skif] Remove legacy SkBlendImageFilter impl
2023-06-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a6525fe76b4c to b07eb69df10e (1 revision)
2023-06-01 kjlubick@google.com Remove shim gni filegroups
2023-06-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll SwiftShader from f549d5e6c663 to ae667fe96db9 (2 revisions)
2023-06-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from b0e9bbd79fb6 to 552e7468f687 (5 revisions)
2023-06-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from b251c8aeb681 to 879c15fdcc06 (7 revisions)
2023-06-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 7b0dd4803e80 to a6525fe76b4c (2 revisions)
2023-06-01 johnstiles@google.com Avoid taking the address of a vector-component in WGSL.
2023-06-01 johnstiles@google.com Make Swizzle::MaskString a public method.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-01 18:20:48 +00:00
Kevin Lubick
1df7a98848 Clean up Skia includes around SkSurfaceCharacterization (flutter/engine#42485) 
While contemplating a change to SkSurfaceCharacterization, I was curious
who was using this. Flutter #included it, but never actually seemed to
use it. Thus, I removed includes of it and other unnecessary #includes
in those same files, as well as addressing follow-on compile errors.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-01 14:08:46 -04:00
Jim Graham
a98c1eb274 Reland "add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#42330) 
The original PR caused some golden test failures down the line, likely due to bad analysis of when the combined BlendMode and color would result in a NOP situation.

This PR adds tests that go through every BlandMode and pair it with a variety of colors and Color/ImageFilters to verify that the operations are only omitted when they actually produce no change in the output. It also checks the validity of the "modifies_transparent_black" property of DisplayLists which can be used in place of the current CanvasSpy/DlOpSpy classes.

The description from the [previous PR](https://github.com/flutter/engine/pull/41463) updated with the new name of the DL property:

---------------------------------
This optimization avoids recording unnecessary render operations that will not affect the output and also eliminates the need for "draw detection" mechanisms like `DlOpSpy` and `CanvasSpy` by remembering if any non-transparent operations were included. The `DlOpSpy` unit tests were updated to check if the results from that object match the new `DisplayList::modifies_transparent_black()` method.

Fixes https://github.com/flutter/flutter/issues/125338

In addition, this change will unblock some other Issues:

- https://github.com/flutter/flutter/issues/125318
- https://github.com/flutter/flutter/issues/125403
 2023-06-01 17:44:04 +00:00
skia-flutter-autoroll
02a8fa9b07 Roll Skia from 934d90ab7370 to f5bc3d12f0eb (1 revision) (flutter/engine#42482) 
https://skia.googlesource.com/skia.git/+log/934d90ab7370..f5bc3d12f0eb

2023-06-01 kjlubick@google.com Move all ColorFilter subclasses to src/effects/colorfilters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-01 16:05:06 +00:00
skia-flutter-autoroll
9531266417 Roll Fuchsia Linux SDK from htio0wC3kDb9tB1Wd... to X4Pkixxtt3BkjRW9P... (flutter/engine#42481) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-01 15:59:19 +00:00
skia-flutter-autoroll
e478c5e117 Roll ICU from a2961dc659b4 to 1eea59cabae0 (2 revisions) (flutter/engine#42479) 
a2961dc659..1eea59caba

2023-05-30 dayeung@chromium.org [ICU 73-1] Update main to 73-1
2023-05-26 megjablon@google.com Clean up language filters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter-engine
Please CC jonahwilliams@google.com,tq-i18n-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-01 12:43:30 +00:00
skia-flutter-autoroll
685710b2cf Roll Skia from 1573bd65a399 to 6c7e1bccb539 (2 revisions) (flutter/engine#42475) 
https://skia.googlesource.com/skia.git/+log/1573bd65a399..6c7e1bccb539

2023-06-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 5165b1499e43 to 1798e4052850
2023-06-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from a3d885eb0ff8 to 5165b1499e43 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-01 07:26:25 +00:00
skia-flutter-autoroll
a1b56f1110 Roll Skia from d9f959926dad to f4f569aa5236 (7 revisions) (flutter/engine#42470) 
https://skia.googlesource.com/skia.git/+log/d9f959926dad..f4f569aa5236

2023-05-31 johnstiles@google.com Add runtime-shader entrypoint to WGSL code generator.
2023-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 29ad234a5b18 to 7b07818eb5fa (3 revisions)
2023-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 3ee81bbacfb2 to 7cb5fc8c2da9 (4 revisions)
2023-05-31 brianosman@google.com Add default (zero) initialization to SkRect/SkIRect
2023-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from eaa5327992fd to 29ad234a5b18 (3 revisions)
2023-05-31 lovisolo@google.com [bazel] Add ANDROID_DEVICES dict, and use it everywhere.
2023-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 80f062cd2828 to 54972d957108 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-01 02:23:08 +00:00
Jonah Williams
fd5cbcfe04 Revert "[web] Remove the JS API for url strategy" (flutter/engine#42468) 
Reverts flutter/engine#42134

This is blocking the engine into framework roller:

See: https://cirrus-ci.com/task/5610586755563520

```
Analyzing 3 items...                                            
  error • The class 'UrlStrategy' can't be extended outside of its library because it's an interface class • dev/integration_tests/web_e2e_tests/test_driver/url_strategy_integration.dart:48:31 • invalid_use_of_type_outside_library
1 issue found. (ran in 321.8s)
  🙙  🙛  
  ```
 2023-06-01 01:53:05 +00:00
skia-flutter-autoroll
5b4b7b7c23 Roll Fuchsia Linux SDK from lSKDoGVypQfTMYUZe... to htio0wC3kDb9tB1Wd... (flutter/engine#42463) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-01 00:05:21 +00:00
Mouad Debbar
65b25427f0 [web] Remove the JS API for url strategy (flutter/engine#42134) 
Finally, we can remove this JS global function for customizing the url strategy.

Why I think we don't need to go through an official deprecation process:

1. It was initially made for internal use in Google3, and right now there are no references to it.
2. There's no public documentation of this JS function.
3. External users customize their url strategy through `flutter_web_plugins` which has been [migrated](https://github.com/flutter/flutter/pull/123443) already.
 2023-05-31 21:37:18 +00:00
skia-flutter-autoroll
66cf4b28dc Roll Skia from cb883f64681b to d9f959926dad (11 revisions) (flutter/engine#42458) 
https://skia.googlesource.com/skia.git/+log/cb883f64681b..d9f959926dad

2023-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from e56dae56bf13 to 3ee81bbacfb2 (4 revisions)
2023-05-31 lovisolo@google.com [bazel] Fold skia_test macro into skia_android_unit_test.
2023-05-31 johnstiles@google.com Split PrefixExpressions test into ES2/ES3 parts.
2023-05-31 johnstiles@google.com Add support for ++/-- postfix expressions in WGSL.
2023-05-31 lovisolo@google.com [bazel] skia_android_unit_test rule: Support select() in extra_args attribute.
2023-05-31 johnstiles@google.com Enable PrefixExpressions test in dm.
2023-05-31 johnstiles@google.com Add support for ++/-- prefix expressions in WGSL.
2023-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 0df9b0312c1d to e56dae56bf13 (24 revisions)
2023-05-31 johnstiles@google.com Add WGSL support for array constructors.
2023-05-31 kjlubick@google.com Sketch in gni file lists for moved colorfilter files
2023-05-31 kjlubick@google.com Decouple SkColorFilters and Ganesh GPU code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-31 20:49:01 +00:00
Kevin Lubick
8666e1af8f Register codecs with Skia explicitly (flutter/engine#42320) 
In http://review.skia.org/689016, Skia added an option to explicitly
register codecs to use (instead of relying on #defines set by BUILD.gn
rules.

This uses that mechanism to explicitly register all the codecs that
Flutter was currently using from Skia (at least by my read of
[tools/gn](fee0534882/tools/gn (L292)).

I'm not sure if there is another place I need to put this sort of code,
e.g. for Fuchsia things.

To really test this out, we would want to add a define of
SK_DISABLE_LEGACY_INIT_DECODERS when compiling Skia, but I'm not sure
the best place to do this.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-31 14:15:18 -04:00
Kevin Lubick
16737de589 Replace use of Skia's private GrRectanizer with a copy of the equivalent code (flutter/engine#42430) 
Skia would like clients to not use their private types. This ports the
same functionality into Flutter's codebase with tests.

The implementation was copied from
[Skia](fa87b7c5ba/src/gpu/RectanizerSkyline.cpp)
and then modified to match Flutter's style and have a unit test.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-31 14:10:33 -04:00
skia-flutter-autoroll
e7d8ac98fd Roll Skia from f475d4f5e080 to cb883f64681b (6 revisions) (flutter/engine#42452) 
https://skia.googlesource.com/skia.git/+log/f475d4f5e080..cb883f64681b

2023-05-31 hitawala@chromium.org Change to kAllFlags for RG8Unorm in Dawn/Mtl caps
2023-05-31 johnstiles@google.com Include WGSL source in the error message when validation fails.
2023-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from baa9940928e0 to 80f062cd2828 (2 revisions)
2023-05-31 johnstiles@google.com Add WGSL support for struct constructors.
2023-05-31 michaelludwig@google.com [skif] Remove SkImageFilters::Image factory that did not take SkSamplingOptions
2023-05-31 johnstiles@google.com Fix precedence in writePrefixExpression.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-31 16:46:50 +00:00
Kevin Lubick
88165fc28b Fix bugprone-unchecked-optional-access errors in image_generator_apng (flutter/engine#42450) 
Related to #127701

When landing a seemingly unrelated CL, clang-tidy started failing with:

```
❌ Failures for clang-tidy on /b/s/w/ir/cache/builder/src/flutter/lib/ui/painting/image_generator_apng.cc:
/b/s/w/ir/cache/builder/src/flutter/lib/ui/painting/image_generator_apng.cc:57:10: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
  return images_[image_index].frame_info.value();
         ^
/b/s/w/ir/cache/builder/src/flutter/lib/ui/painting/image_generator_apng.cc:154:13: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
    switch (frame.frame_info->blend_mode) {
            ^
/b/s/w/ir/cache/builder/src/flutter/lib/ui/painting/image_generator_apng.cc:526:7: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
  if (images_.back().frame_info->disposal_method ==
      ^
/b/s/w/ir/cache/builder/src/flutter/lib/ui/painting/image_generator_apng.cc:535:7: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
      images_.back().frame_info->disposal_method ==
      ^
/b/s/w/ir/cache/builder/src/flutter/lib/ui/painting/image_generator_apng.cc:538:5: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
    image->frame_info->required_frame = images_.size() - 1;
    ^
Suppressed 1772 warnings (1772 in non-user code).
```

This addresses those checks by making sure frame_info has a value.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-31 08:56:59 -07:00
Kevin Lubick
35f9c71efd Replace SkSurface::flush methods with GrDirectContext methods (flutter/engine#42425) 
In https://skia-review.googlesource.com/c/skia/+/698237, Skia moved the
SkSurface::flush* methods to GrDirectContext (and skgpu::ganesh::Flush).
This updates Flutter to use those versions, which are drop-in
replacements for the previous functionality.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-31 11:07:44 -04:00
skia-flutter-autoroll
7742099fe4 Roll Skia from 298f0a836149 to f475d4f5e080 (1 revision) (flutter/engine#42449) 
https://skia.googlesource.com/skia.git/+log/298f0a836149..f475d4f5e080

2023-05-31 sunnyps@chromium.org graphite: Print extra debug information on TextureInfo mismatch

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-31 14:48:28 +00:00
skia-flutter-autoroll
f8731fbc25 Roll Fuchsia Linux SDK from Nq-KA7nXfrr1RLDGI... to lSKDoGVypQfTMYUZe... (flutter/engine#42447) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-31 10:16:21 +00:00
skia-flutter-autoroll
6a07a866d8 Roll Skia from 0f92eb8c4bbd to 298f0a836149 (1 revision) (flutter/engine#42446) 
https://skia.googlesource.com/skia.git/+log/0f92eb8c4bbd..298f0a836149

2023-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c721ed541e6d to a3d885eb0ff8 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-31 10:08:29 +00:00
skia-flutter-autoroll
d2c5be62f4 Roll Skia from 870e249c99a7 to 78f3a9a4587c (1 revision) (flutter/engine#42440) 
https://skia.googlesource.com/skia.git/+log/870e249c99a7..78f3a9a4587c

2023-05-31 michaelludwig@google.com Add saturate() to SkBlenders::Arithmetic

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-31 03:15:01 +00:00
Jonah Williams
c77372b552 [Impeller] offload all text computation into vertex shader (flutter/engine#42417) 
TextContents::Render occassionally shows up in the highest CPU functions. We can actually unload most of this computation into the vertex shader.
 2023-05-31 00:30:04 +00:00
Zachary Anderson
9022cac6f8 Enables bugprone-unchecked-optional-access for some files (flutter/engine#42428) 2023-05-30 16:52:58 -07:00
Zachary Anderson
a0d2812b01 Revert "Move linux clang tidy to engine_v2." (flutter/engine#42434) 2023-05-30 16:51:55 -07:00
skia-flutter-autoroll
1768b9050c Roll Skia from fed417995ba9 to 870e249c99a7 (14 revisions) (flutter/engine#42435) 
https://skia.googlesource.com/skia.git/+log/fed417995ba9..870e249c99a7

2023-05-30 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 7c183c4ec0cd to 8447e2792abe (2 revisions)
2023-05-30 jvanverth@google.com [Metal] Fix Caps flag for RG8Unorm.
2023-05-30 scroggo@google.com Change CtsEnforcement for GrGpuBufferTest
2023-05-30 johnstiles@google.com Fix Metal half-precision matrix negation.
2023-05-30 kjlubick@google.com Remove old src/gpu/gl/GrGLDefines.h
2023-05-30 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 2387dc5297cc to 0df9b0312c1d (2 revisions)
2023-05-30 michaelludwig@google.com Skip FilterResult* tests on Intel ANGLE
2023-05-30 michaelludwig@google.com [skif] Update Magnifier impl to use FilterResult::Builder
2023-05-30 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 89228c43bb06 to 7c183c4ec0cd (2 revisions)
2023-05-30 kjlubick@google.com Add CI job for Graphite_Metal_Vello
2023-05-30 lovisolo@google.com BazelTestRunner.cpp: Print timestamps.
2023-05-30 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 7a7bb0e7be36 to 2387dc5297cc (2 revisions)
2023-05-30 michaelludwig@google.com [graphite] Clamp output of cubic sampling
2023-05-30 michaelludwig@google.com SkSamplingOptions ctors not explicit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-30 23:50:22 +00:00
gaaclarke
922c7250bd [Impeller] Fixed TypographerTest.MaybeHasOverlapping (flutter/engine#42429) 
fixes https://github.com/flutter/flutter/issues/127714

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-30 23:33:00 +00:00
hangyu
ab43a145cf Handle a11y focus event on Ios and android (flutter/engine#41777) 
framework change:https://github.com/flutter/flutter/pull/126171
issue: https://github.com/flutter/flutter/issues/94523

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-30 21:50:56 +00:00
Matej Knopp
821bb52e38 Fix unitialized SkRect (flutter/engine#42403) 
Empty SkRect needs to be created with `SkRect::MakeEmpty()` otherwise the default value is undefined (and possibly garbage).

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-30 21:37:12 +00:00
Reid Baker
e927e5488f Update engine testing to use api 33 for android tests. (flutter/engine#42351) 
#flutter/flutter/127682
The plurality of android users are on api 33. We should be testing on our most used android api.
 2023-05-30 20:50:13 +00:00
Greg Spencer
a1b365111f Reland: "Adding app lifecycle notification for macOS and Linux, add hidden state." (#40542) (flutter/engine#42418) 
## Description

This reverts commit 879917b to re-land #40542 to fix the lint warning which caused the original PR to be reverted (the lint warnings were turned on after the original was landed, which is why it wasn't caught earlier).
 2023-05-30 20:45:46 +00:00
gaaclarke
25154333d5 [Impeller] Fixed GlyphAtlasWithLotsOfdUniqueGlyphSize (flutter/engine#42423) 
fixes https://github.com/flutter/flutter/issues/127715

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-30 13:13:36 -07:00
keyonghan
38da048728 Remove legacy xcode properties/dependencies (flutter/engine#42368) 
Now only $flutter/osx_sdk property is being used, and it's safe to remove deprecated entries from ci.yaml.

Part of https://github.com/flutter/flutter/issues/127534
 2023-05-30 20:11:13 +00:00