DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
33,337 Commits 882 Branches 1,069 Tags
Commit Graph

33337 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michael Goderbauer
dbfad3bfed Sync lints with flutter/flutter (flutter/engine#49192) 2023-12-20 01:12:30 +00:00
Harry Terkelsen
50beeb112d [web] Enforce onDrawFrame/onBeginFrame render rule (flutter/engine#49214) 
Also update tests to conform to the render rule.

The render rule is that the call to `render` should only occur in the scope of an `onDrawFrame` or `onBeginFrame` call. As a side effect, this change also fixes a memory leak which occurs in tests using FakeAsync in the `flutter_test` environment (because they don't render anymore).

Fixes https://github.com/flutter/flutter/issues/137073
Fixes https://github.com/flutter/flutter/issues/137669

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-19 23:18:10 +00:00
Bartek Pacia
61a61a8632 [Docs] Add more info about running tests on iOS (flutter/engine#48859) 
I wish this info was there, that'd save me from looking inside the script.
 2023-12-19 22:54:54 +00:00
skia-flutter-autoroll
5991c11dc0 Roll Skia from 48f959a857da to d0f09ad481f7 (3 revisions) (flutter/engine#49264) 
https://skia.googlesource.com/skia.git/+log/48f959a857da..d0f09ad481f7

2023-12-19 johnstiles@google.com Update RTFlip handling to avoid caps-bit checks in the front-end.
2023-12-19 johnstiles@google.com Remove FBFetch/DualSourceBlending caps bit checks from the front-end.
2023-12-19 brianosman@google.com Limit the size of a layer's FilterSpan to 16 filters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 22:53:46 +00:00
Tong Mu
927fd200ed Revert "Reland 2: Multiview Pipeline (#47239)" (flutter/engine#49238) 
This reverts commit 87171e73397f7edfd4c145fbaebdd7208954debf.

Internal performance test shows that this PR negatively affects startup time. I'll reland this PR in parts.

b/307872797

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-19 22:30:01 +00:00
skia-flutter-autoroll
05268a49ed Roll Dart SDK from e8cdc554c598 to 4c59838945d9 (2 revisions) (flutter/engine#49261) 
https://dart.googlesource.com/sdk.git/+log/e8cdc554c598..4c59838945d9

2023-12-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-244.0.dev
2023-12-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-243.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 22:07:00 +00:00
Jim Graham
57c1db2af6 Make sure run_tests.py runs dart tests on Skia (flutter/engine#49260) 
Today the default renderer on hosts is Skia, but if we ever change the default then we will be testing on Impeller+default(Impeller) rather than both Skia and Impeller. Change the flutter_tester launch arguments to explicitly disable Impeller when we want to test Skia so that we will always test on both platforms.
 2023-12-19 21:51:09 +00:00
Zachary Anderson
971c03d9e3 Rolls clang to 725656bdd885483c39f482a01ea25d67acf39c46 (flutter/engine#49248) 
We're on a version of clang that crashes a lot on macOS. This PR rolls
clang forward to a new release from the Fuchsia toolchain team. If it
does not fix the crash, we can roll back with
https://github.com/flutter/engine/pull/49249. Both rolling forward and
back require the fixes to the `.mm` file in this PR.
 2023-12-19 13:35:42 -08:00
Alexander Aprelev
5454a0812d Roll dart to 3.3.0-242.0.dev (flutter/engine#49239) 
Changes since last roll
```
e8cdc554c59 (tag: 3.3.0-242.0.dev, origin/dev) Version 3.3.0-242.0.dev
a5109dc82ba [build] Handle RBE in -fdebug-prefix-map.
2ff976e9e3a [infra] Specify Linux in RBE platform.
12c548d331b [macros] Add first language tests for introspection.
3eeba4a4e2a [cfe] Refactor FunctionNode.futureValueType into emitted value type
8d8c4c61250 [cfe] Handle extension types in *Concatenation nodes
f49c7864436 [cfe/analyzer] Report error on invalid abstract final class modifier combinations
338fd6501b6 [dart2wasm] Make _RecordType use WasmArray<>s instead of List<>s
355d7e02fcf (origin/base) Stop testing nnbd-weak and nnbd-legacy on analyzer.
27892de3497 Adding DTD and DTD_impl owners.
6a9216a46fc Remove Requirements=nnbd-weak from superinterfaces_out_of_order_error_test.dart.
d646c92abe6 Macro. Tests for StaticType.isSubtype()
5881d669f0a Update DevTools rev to c7aa1df42178b054901c36bb1b8ea25b5542be8c
63594497660 Remove dead code in prefer_constructors_over_static_methods.dart
739baa4bc10 Macro. Implement DefinitionPhaseIntrospector.inferType()
794d3adf93d [VM] - Minor cleanups
3e73f10de09 Disable fixes for unawaited_futures in cascades.
8348807c860 stop collecting `strictCasts` settings from options
38e2d34424e [ddc] Erase extension types in as expressions
8d24f7ebd41 [ddc] Erase extension types in string concats
b2cd914227b [ddc] Erase extension types in assertions
66a955b09f1 Fixed typo
48ac398f112 Fix `Directory.current` setter compatibility with `IOOverrides`
c84edaefe9e Check in //third_party/root_certificates.
63f5b1272b1 Discover actual dart-sdk/ and bin/ when running tools/test.py
81dc3f6f6e7 [tests/ffi]: Fix failing pointer arithmetic test.
83ba9fe0a8d [ddc] Enable new runtime types by default
95e049c7e28 Add a test case for #52233
3e2ac6721d5 [linter] Report deprecated_consistency only on constructor name
89381ea4dbe [linter] Simplify 'prefer_mixin' implementation
```

This PR also includes changes to license script to accommodate new
location for `root_certificates` sources.
 2023-12-19 13:15:37 -08:00
skia-flutter-autoroll
5d0a1ab07b Roll Skia from df1a7ccbdc97 to 48f959a857da (1 revision) (flutter/engine#49255) 
https://skia.googlesource.com/skia.git/+log/df1a7ccbdc97..48f959a857da

2023-12-19 lovisolo@google.com Skia: Upgrade Go to 1.21.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 20:34:48 +00:00
skia-flutter-autoroll
e64527dbb0 Roll Skia from 541f16af8b3e to df1a7ccbdc97 (3 revisions) (flutter/engine#49250) 
https://skia.googlesource.com/skia.git/+log/541f16af8b3e..df1a7ccbdc97

2023-12-19 nicolettep@google.com [graphite] Assign kVertexShader a real value
2023-12-19 johnstiles@google.com Add golden test for DualSourceBlendingSupport caps bit.
2023-12-19 jvanverth@google.com Revert "[Fontations-backend] Use new outline API"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 19:49:23 +00:00
skia-flutter-autoroll
c20f2f3fa1 Roll Skia from 0d39fb28b32d to 541f16af8b3e (1 revision) (flutter/engine#49246) 
https://skia.googlesource.com/skia.git/+log/0d39fb28b32d..541f16af8b3e

2023-12-19 brianosman@google.com Reland "Fix color uniforms in SkMesh"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 19:02:09 +00:00
John McCutchan
294a05da81 Use new SurfaceProducer external texture class for rendering platform views (flutter/engine#49201) 
- Fix lots of bugs in the implementation of ImageReaderSurfaceProducer
- Add test that we drop frames produced from the wrong size
- Hookup platform views to use new external texture class

Related: [#139230](https://github.com/flutter/flutter/issues/139230)
Related: [#139702](https://github.com/flutter/flutter/issues/139702)
 2023-12-19 10:08:46 -08:00
skia-flutter-autoroll
bca18006be Roll Skia from 22dad95c218f to 0d39fb28b32d (2 revisions) (flutter/engine#49241) 
https://skia.googlesource.com/skia.git/+log/22dad95c218f..0d39fb28b32d

2023-12-19 jvanverth@google.com [graphite] Have Device submit parent uploads prior to its own.
2023-12-19 johnstiles@google.com Add golden test for fuzzer-discovered issue.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 17:38:49 +00:00
skia-flutter-autoroll
a7c396b412 Roll Skia from 6496c9c5866a to 22dad95c218f (4 revisions) (flutter/engine#49237) 
https://skia.googlesource.com/skia.git/+log/6496c9c5866a..22dad95c218f

2023-12-19 johnstiles@google.com Migrate MustDeclareFragmentFrontFacing workaround out of front-end.
2023-12-19 johnstiles@google.com Ignore ShaderCaps from Setting::Make.
2023-12-19 johnstiles@google.com Add Setting::Make method for use in the Inliner.
2023-12-19 jvanverth@google.com Revert "Compare two segments at a given y"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 16:48:26 +00:00
skia-flutter-autoroll
ca98f62d1c Roll Skia from ed0148ab400d to 6496c9c5866a (6 revisions) (flutter/engine#49234) 
https://skia.googlesource.com/skia.git/+log/ed0148ab400d..6496c9c5866a

2023-12-19 nicolettep@google.com [graphite] Add pipeline stage flags to descriptor data struct, use to determine VkShaderStageFlags
2023-12-19 herb@google.com Compare two segments at a given y
2023-12-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 17b2d54cf88d to abf17e333489 (5 revisions)
2023-12-19 bungeman@google.com Reland "Cache the one SkEmptyTypeface"
2023-12-19 drott@chromium.org [Fontations-backend] Use new outline API
2023-12-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 40f4de8fa1ff to bd5dce9a8e85 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 15:59:21 +00:00
skia-flutter-autoroll
37ac51e652 Roll Skia from c12c2a174327 to ed0148ab400d (1 revision) (flutter/engine#49222) 
https://skia.googlesource.com/skia.git/+log/c12c2a174327..ed0148ab400d

2023-12-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 0b6ca39d3873 to d7465b8b2585 (15 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 08:11:11 +00:00
dependabot[bot]
321b806d08 Bump actions/upload-artifact from 3.1.3 to 4.0.0 (flutter/engine#49220) 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<p>The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.</p>
<p>For more information, see the <a href="https://github.com/actions/toolkit/tree/main/packages/artifact"><code>@​actions/artifact</code></a> documentation.</p>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/vmjoseph"><code>@​vmjoseph</code></a> made their first contribution in <a href="https://redirect.github.com/actions/upload-artifact/pull/464">actions/upload-artifact#464</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v3...v4.0.0">https://github.com/actions/upload-artifact/compare/v3...v4.0.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c7d193f32e"><code>c7d193f</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/466">#466</a> from actions/v4-beta</li>
<li><a href="13131bb095"><code>13131bb</code></a> licensed cache</li>
<li><a href="4a6c273b98"><code>4a6c273</code></a> Merge branch 'main' into v4-beta</li>
<li><a href="f391bb91a3"><code>f391bb9</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/465">#465</a> from actions/robherley/v4-documentation</li>
<li><a href="9653d03c4b"><code>9653d03</code></a> Apply suggestions from code review</li>
<li><a href="875b630764"><code>875b630</code></a> add limitations section</li>
<li><a href="ecb21463e9"><code>ecb2146</code></a> add compression example</li>
<li><a href="5e7604f84a"><code>5e7604f</code></a> trim some repeated info</li>
<li><a href="d6437d0758"><code>d6437d0</code></a> naming</li>
<li><a href="1b56155703"><code>1b56155</code></a> s/v4-beta/v4/g</li>
<li>Additional commits viewable in <a href="a8a3f3ad30...c7d193f32e">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=3.1.3&new-version=4.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2023-12-19 07:20:14 +00:00
skia-flutter-autoroll
df5a0c9afc Roll Skia from 27ab8a8d2a0d to c12c2a174327 (1 revision) (flutter/engine#49218) 
https://skia.googlesource.com/skia.git/+log/27ab8a8d2a0d..c12c2a174327

2023-12-19 jvanverth@google.com Revert "Fix color uniforms in SkMesh"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 07:01:23 +00:00
Code Otaku
7f0343f6fc Makes PlatformViewsController view to use tracked event's action & pointer count (flutter/engine#47424) 
related issue https://github.com/flutter/flutter/issues/111268,
https://github.com/flutter/flutter/issues/106190

### Motivation:
- At https://github.com/flutter/flutter/issues/111268, we found that
Android PlatformView scrolls slowly after #34182 commit

### Modification:
- Makes `PlatformViewsController` view to use `tracked event`'s action &
pointer count

### Result:
- Now PlatformView scrolls not slowly
- Close https://github.com/flutter/flutter/issues/111268,
https://github.com/flutter/flutter/issues/106190


- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

Co-authored-by: John McCutchan <john@johnmccutchan.com>
 2023-12-18 20:41:02 -08:00
skia-flutter-autoroll
86415126ca Roll Skia from 37a60129e019 to 27ab8a8d2a0d (1 revision) (flutter/engine#49213) 
https://skia.googlesource.com/skia.git/+log/37a60129e019..27ab8a8d2a0d

2023-12-19 johnstiles@google.com Add golden test for MustDeclareFragmentFrontFacing caps bit.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 04:12:06 +00:00
skia-flutter-autoroll
30f39c28d5 Roll Skia from e5b0cdc11992 to 37a60129e019 (1 revision) (flutter/engine#49212) 
https://skia.googlesource.com/skia.git/+log/e5b0cdc11992..37a60129e019

2023-12-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8bfc8b0beb54 to 17b2d54cf88d (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 02:36:47 +00:00
skia-flutter-autoroll
cbeebe3457 Roll Skia from fff421ff633e to e5b0cdc11992 (4 revisions) (flutter/engine#49210) 
https://skia.googlesource.com/skia.git/+log/fff421ff633e..e5b0cdc11992

2023-12-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 1c458d95052b to de195edcee5d
2023-12-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 163b07e3ec7b to 2f71d11931d6
2023-12-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 29a7285dc594 to eb442b364123
2023-12-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from f4ecbb1337cf to 270348756990

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 01:31:16 +00:00
skia-flutter-autoroll
e0effcc970 Roll Skia from 63bed826008e to fff421ff633e (1 revision) (flutter/engine#49208) 
https://skia.googlesource.com/skia.git/+log/63bed826008e..fff421ff633e

2023-12-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from ace4d55f4430 to ec331998751e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-19 00:53:24 +00:00
godofredoc
17a954cf78 Double timeout on mac builds. (flutter/engine#49205) 
This is to prevent builds from timing out during the experiment to disable goma on mac post submit builds.

Bug: https://github.com/flutter/flutter/issues/140342

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-19 00:26:32 +00:00
Jim Graham
91806f60d6 [Impeller] Make Rect origin and size fields private (flutter/engine#49168) 
Make the implementation fields of Rect private in preparation for switching its internal operations from XYWH to LTRB fields.
 2023-12-18 22:48:10 +00:00
Matej Knopp
ad2fe1a759 Convert chromium wheel delta to physical pixels on macOS (flutter/engine#49028) 
This has been previously done for Safari in Firefox in
https://github.com/flutter/engine/pull/35428. I'm not entirely sure
since which release, but for past couple of months Chromium seems to be
reporting logical pixels during scroll events as well, which now makes
scrolling on Chrome / macOs 2x slower.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-12-18 22:46:48 +01:00
skia-flutter-autoroll
49a2e806a8 Roll Skia from 3de801338767 to 63bed826008e (1 revision) (flutter/engine#49200) 
https://skia.googlesource.com/skia.git/+log/3de801338767..63bed826008e

2023-12-18 herb@google.com Find insertion point in sweepline for new segment

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 21:41:57 +00:00
skia-flutter-autoroll
e5354564e1 Roll Dart SDK from ff7e92c7886d to b21443096387 (1 revision) (flutter/engine#49199) 
https://dart.googlesource.com/sdk.git/+log/ff7e92c7886d..b21443096387

2023-12-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-241.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 21:33:50 +00:00
skia-flutter-autoroll
f712ddcb03 Roll Skia from 83f8fe8bbcee to 3de801338767 (2 revisions) (flutter/engine#49195) 
https://skia.googlesource.com/skia.git/+log/83f8fe8bbcee..3de801338767

2023-12-18 johnstiles@google.com Handle rewrite-matrix-vector-multiply directly in SPIR-V.
2023-12-18 johnstiles@google.com Expand RewriteMatrixVectorMultiply test to cover non-constants.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 20:46:09 +00:00
skia-flutter-autoroll
9af9edd6b7 Roll Skia from 10e7ee119ea9 to 83f8fe8bbcee (1 revision) (flutter/engine#49193) 
https://skia.googlesource.com/skia.git/+log/10e7ee119ea9..83f8fe8bbcee

2023-12-18 lehoangquyen@chromium.org Revert "Re-enable GraphitePurgeNotUsedSinceResourcesTest"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 19:51:22 +00:00
Bartek Pacia
b87524c6d3 Delete SemanticsUpdateBuilderNew and all references and usages (flutter/engine#49139) 
This PR completest the migration by removing `SemanticsUpdateBuilderNew` from the engine.

This is mainly targeted at https://github.com/flutter/flutter/issues/17988

Steps:
part 1: [engine] add `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/47961
part 2: [flutter] use `SemanticsUpdateBuilderNew` https://github.com/flutter/flutter/pull/138331
part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/48882
part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again https://github.com/flutter/flutter/pull/139942
**part 5: [engine] remove `SemanticsBuilderNew`** <-- we are here
 2023-12-18 19:35:58 +00:00
Chinmay Garde
b29921cf93 Opt into unstable libcxx ABI and add a custom namespace. (flutter/engine#49002) 
We use a statically linked libcxx and don't expose any of the internal symbols. This theoretically allows us to namespace everything to avoid accidentally using the wrong version libcxx. Also, not having to worry about ABI stability allows libcxx to opt into optimized routines.

But, since libcxx uses CMake and we don't, the mechanism to generate the __config_site file doesn't exist in GN. Instead, we check in a file that would have been generated for us by CMake. The file we check in though is a default with additional configuration. This version of the file makes it so that we opt into the unstable ABI (and get optimizations) and also namespace everything for Flutter so collisions are immediately flagged.
 2023-12-18 19:35:56 +00:00
skia-flutter-autoroll
c34bf9ead7 Roll Skia from 4b2639427e7e to 10e7ee119ea9 (10 revisions) (flutter/engine#49191) 
https://skia.googlesource.com/skia.git/+log/4b2639427e7e..10e7ee119ea9

2023-12-18 bungeman@google.com Revert "Cache the one SkEmptyTypeface"
2023-12-18 brianosman@google.com Reland "Support multiple image filters in SaveLayerRec"
2023-12-18 johnstiles@google.com Add Type::columnType.
2023-12-18 herb@google.com Compare the slopes of two segments
2023-12-18 mike@reedtribe.org Limit recursion in contour-measure
2023-12-18 jvanverth@google.com [graphite] Switch to use TokenTracker for RasterAtlas page invalidation.
2023-12-18 bungeman@google.com Cache the one SkEmptyTypeface
2023-12-18 johnstiles@google.com Revert "Allow an SkSL compiler to be created without shader caps."
2023-12-18 johnstiles@google.com Fix fuzzer-discovered issue with inlining.
2023-12-18 bungeman@google.com Document that SkDocument::beginPage calls endPage

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 19:07:21 +00:00
skia-flutter-autoroll
8aed259ac2 Roll Dart SDK from e1a26302800d to ff7e92c7886d (1 revision) (flutter/engine#49185) 
https://dart.googlesource.com/sdk.git/+log/e1a26302800d..ff7e92c7886d

2023-12-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-240.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 17:17:22 +00:00
skia-flutter-autoroll
05558a52ba Roll Skia from 290fefdef726 to 4b2639427e7e (1 revision) (flutter/engine#49183) 
https://skia.googlesource.com/skia.git/+log/290fefdef726..4b2639427e7e

2023-12-18 herb@google.com Myers: Point and Segment

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 16:16:25 +00:00
skia-flutter-autoroll
2d59f91787 Roll Skia from 276075b97567 to 290fefdef726 (1 revision) (flutter/engine#49180) 
https://skia.googlesource.com/skia.git/+log/276075b97567..290fefdef726

2023-12-18 johnstiles@google.com Remove a four-year temporary workaround.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 15:32:03 +00:00
Mouad Debbar
4d71cad1fb [web] Set cursor property on body (flutter/engine#49098) 
This is a temporary workaround to get mouse cursor working in multi-view (until https://github.com/flutter/flutter/issues/140226 is resolved).
 2023-12-18 15:20:04 +00:00
skia-flutter-autoroll
676defd40e Roll Skia from 74e6a355f208 to 276075b97567 (1 revision) (flutter/engine#49177) 
https://skia.googlesource.com/skia.git/+log/74e6a355f208..276075b97567

2023-12-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d7e9d3eb62b9 to 8bfc8b0beb54 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 13:37:16 +00:00
skia-flutter-autoroll
bd522b0d81 Roll Dart SDK from c8106261c9cd to e1a26302800d (1 revision) (flutter/engine#49178) 
https://dart.googlesource.com/sdk.git/+log/c8106261c9cd..e1a26302800d

2023-12-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-239.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 13:31:12 +00:00
skia-flutter-autoroll
0b3485e2c3 Roll Skia from d4b1cc5122f9 to 74e6a355f208 (1 revision) (flutter/engine#49171) 
https://skia.googlesource.com/skia.git/+log/d4b1cc5122f9..74e6a355f208

2023-12-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a9512a9fffdc to 40f4de8fa1ff (12 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 07:35:23 +00:00
skia-flutter-autoroll
9e5f0c4286 Roll Skia from e40b61c3dfef to d4b1cc5122f9 (2 revisions) (flutter/engine#49169) 
https://skia.googlesource.com/skia.git/+log/e40b61c3dfef..d4b1cc5122f9

2023-12-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 77be35e337bb to 2fa7e9b99ae4 (1 revision)
2023-12-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 498189e2dd63 to 0b6ca39d3873 (19 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 06:54:23 +00:00
skia-flutter-autoroll
70c054f90e Roll Skia from 6598d8b28c51 to e40b61c3dfef (1 revision) (flutter/engine#49154) 
https://skia.googlesource.com/skia.git/+log/6598d8b28c51..e40b61c3dfef

2023-12-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-17 11:09:35 +00:00
skia-flutter-autoroll
7e05c48830 Roll Skia from 49cfb91d353f to 6598d8b28c51 (1 revision) (flutter/engine#49153) 
https://skia.googlesource.com/skia.git/+log/49cfb91d353f..6598d8b28c51

2023-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4c54b6ad784d to d7e9d3eb62b9 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-17 09:32:10 +00:00
Matej Knopp
33a6339c63 Add FlutterMetalLayer as optional alternative to CAMetalLayer (flutter/engine#48226) 
This PR implements `FlutterMetalLayer`, a drop-in (as far as Flutter is
concerned) replacement for `CAMetalLayer`. The biggest difference is
that `FlutterMetalLayer` can present frames from background thread
within a `CATransaction`.

`FlutterMetalLayer` is disabled by default. To opt-in, add the following
item to `Info.plist`:

```xml
        <key>FLTUseFlutterMetalLayer</key>
	<true/>
```

The performance seems quite good, consistent 120hz on iPhone 13 Pro.

Benefits
- presenting with transaction from background thread, which, down the
line, would allow for platform views without thread merging.
- fine control over how the surface is displayed - we can display single
surface on multiple `CALayers`, each showing different part, allowing
for performant implementation of unobstructed platform views.
 
Drawbacks
- this not being a metal layer makes working with metal instrument tools
more awkward
 2023-12-16 21:53:32 +01:00
skia-flutter-autoroll
9e4365fe11 Roll Skia from 35d0d7eb991c to 49cfb91d353f (1 revision) (flutter/engine#49141) 
https://skia.googlesource.com/skia.git/+log/35d0d7eb991c..49cfb91d353f

2023-12-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4382b905737a to 4c54b6ad784d (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-16 17:56:07 +00:00
skia-flutter-autoroll
8580ec5d36 Roll Skia from d231faf34f8a to 35d0d7eb991c (1 revision) (flutter/engine#49137) 
https://skia.googlesource.com/skia.git/+log/d231faf34f8a..35d0d7eb991c

2023-12-16 brianosman@google.com Revert "Support multiple image filters in SaveLayerRec"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-16 14:16:39 +00:00
skia-flutter-autoroll
6e5f1c22b6 Roll Skia from 01aa69c38af5 to d231faf34f8a (1 revision) (flutter/engine#49134) 
https://skia.googlesource.com/skia.git/+log/01aa69c38af5..d231faf34f8a

2023-12-16 lehoangquyen@chromium.org GraphiteDawn: support mapping draw buffers directly.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-16 10:16:32 +00:00
skia-flutter-autoroll
1ccb7ba0ae Roll Dart SDK from 620976ef6b80 to c8106261c9cd (1 revision) (flutter/engine#49131) 
https://dart.googlesource.com/sdk.git/+log/620976ef6b80..c8106261c9cd

2023-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-238.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-16 08:07:04 +00:00
skia-flutter-autoroll
587501aae1 Roll Skia from 191943f9c43e to 01aa69c38af5 (4 revisions) (flutter/engine#49128) 
https://skia.googlesource.com/skia.git/+log/191943f9c43e..01aa69c38af5

2023-12-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3a2df0f5a263 to 4382b905737a (2 revisions)
2023-12-16 jvanverth@google.com [graphite] Remove conditional uploads for the text atlas.
2023-12-16 lehoangquyen@chromium.org Re-enable GraphitePurgeNotUsedSinceResourcesTest
2023-12-15 michaelludwig@google.com [skif] Add SrcRectConstraint to SkDevice::drawSpecial

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-16 05:05:37 +00:00