DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
29,392 Commits 882 Branches 1,069 Tags
Commit Graph

29392 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
db34cccf92 Roll Fuchsia Linux SDK from xqQPG9jnWgD1Dj3FL... to 1ODZdNPvGxBrgnCzf... (flutter/engine#42707) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-09 21:16:11 +00:00
skia-flutter-autoroll
32834a51d2 Roll ANGLE from 3e4f4caebcb0 to 72df42832ee4 (2 revisions) (flutter/engine#42703) 
3e4f4caebc..72df42832e

2023-06-09 mark@lunarg.com Tests: Add Lotsa Slots trace
2023-06-09 steven@uplinklabs.net xml: fix enum EGL_SYNC_METAL_SHARED_EVENT_SIGNALED_ANGLE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-09 19:33:05 +00:00
skia-flutter-autoroll
7836779ac5 Manual roll Dart SDK from bbce07ad3944 to d5b39a8385f9 (2 revisions) (flutter/engine#42702) 
Manual roll requested by jacksongardner@google.com

https://dart.googlesource.com/sdk.git/+log/bbce07ad3944..d5b39a8385f9

2023-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-182.0.dev
2023-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-181.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-09 19:06:58 +00:00
gaaclarke
bf5c52d8af [Impeller] Reland: Added a switch to turn on vulkan (flutter/engine#42669) 
relands https://github.com/flutter/engine/pull/42585

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-09 11:35:29 -07:00
skia-flutter-autoroll
73d68604ab Roll ANGLE from a185cb8c8924 to 3e4f4caebcb0 (2 revisions) (flutter/engine#42701) 
a185cb8c89..3e4f4caebc

2023-06-09 romanl@google.com Tests: reduce load on perf bots by collecting less data
2023-06-09 romanl@google.com Tests: disable TraceTest.respawnables on native

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-09 18:26:28 +00:00
Brandon DeRosier
9d1159855f [Impeller] Add CPU implementations for all color filters (flutter/engine#42692) 
Part of https://github.com/flutter/flutter/issues/127232.

Adds a CPU implementation for ColorMatrix and the color space
conversions. Also changes the blend signature for consistency.

These will be necessary to make the mask blur fast path continue working
in the presence of color filters. In general, we can use these to
eliminate a needlessly expensive image-based color filter for the
non-image color sources.
 2023-06-09 11:13:05 -07:00
Jonah Williams
71009220e0 [Impeller] add explicit VMA flush to device memory writes. (flutter/engine#42685) 
According to my read of the documentation for VMA/Vulkan allocation docs, setting VK_MEMORY_PROPERTY_HOST_COHERENT_BIT means we shouldn't need to flush the memory. nevertheless, this fixes the corruption of host buffers observed in https://github.com/flutter/flutter/issues/124040

Fixes https://github.com/flutter/flutter/issues/124040

> VK_MEMORY_PROPERTY_HOST_COHERENT_BIT bit specifies that the host cache management commands [vkFlushMappedMemoryRanges](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkFlushMappedMemoryRanges.html) and [vkInvalidateMappedMemoryRanges](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkInvalidateMappedMemoryRanges.html) are not needed to flush host writes to the device or make device writes visible to the host, respectively.

🤷‍♂️
 2023-06-09 17:23:09 +00:00
gaaclarke
2097506136 [Impeller] Makes validation layers flag work for android (flutter/engine#42625) 
This builds and links in the validation layers for android. They then
can be turned on or off with a manifest field.

fixes https://github.com/flutter/flutter/issues/123788
depends on https://github.com/flutter/buildroot/pull/741

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-09 10:22:21 -07:00
Justin McCandless
986c173094 Platform channel for predictive back (flutter/engine#39208) 
Adds a platform channel method for enabling/disabling Android's predictive back feature.
 2023-06-09 10:06:33 -07:00
skia-flutter-autoroll
13693e412e Roll Fuchsia Mac SDK from romfKfKwgjzAXQSxt... to EInl_eQkJekqc-gfW... (flutter/engine#42698) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-09 16:19:47 +00:00
Jonah Williams
fb0c47c6ec [Impeller] disable buffer to texture blit for Vulkan. (flutter/engine#42686) 
This fixes some f'd up ness in the images. Will need to debug this separately on Android. For now, we can just turn it off in the caps.
 2023-06-09 15:53:56 +00:00
skia-flutter-autoroll
28a75b52ef Roll ANGLE from 980896406d12 to a185cb8c8924 (1 revision) (flutter/engine#42697) 
980896406d..a185cb8c89

2023-06-09 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from b36c4c847faa to ac70ebb575ce (547 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-09 15:53:54 +00:00
skia-flutter-autoroll
54536be3fb Roll ANGLE from e9493542672c to 980896406d12 (1 revision) (flutter/engine#42696) 
e949354267..980896406d

2023-06-09 prashanthsw@google.com Use version-less CIPD path for android_toolchain

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-09 14:15:18 +00:00
skia-flutter-autoroll
2aee3bd644 Roll ANGLE from 8a62b4c44fc9 to e9493542672c (1 revision) (flutter/engine#42695) 
8a62b4c44f..e949354267

2023-06-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c5a1402a455f to 701c5daafb72 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-09 11:31:45 +00:00
Bruno Leroux
0445311a23 [Linux] Return keyboard pressed state (flutter/engine#42346) 
## Description

This PR updates the Linux engine in order to answer to keyboard pressed state queries from the framework (as implemented in https://github.com/flutter/flutter/pull/122885).

## Related Issue

Linux engine implementation for https://github.com/flutter/flutter/issues/87391

## Tests

Adds 2 tests.
 2023-06-09 11:28:15 +00:00
skia-flutter-autoroll
17cf5bf08b Roll Fuchsia Linux SDK from lPCv1NshK-tvjtLgC... to xqQPG9jnWgD1Dj3FL... (flutter/engine#42694) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-09 08:01:09 +00:00
skia-flutter-autoroll
21fab9f036 Roll ANGLE from d8339e78db54 to 8a62b4c44fc9 (1 revision) (flutter/engine#42691) 
d8339e78db..8a62b4c44f

2023-06-09 chonggu@google.com [Fuchsia] Remove qemu from checkouts

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-09 03:50:35 +00:00
skia-flutter-autoroll
08e798d283 Roll Fuchsia Mac SDK from ukXXOXtI7uRIukzF5... to romfKfKwgjzAXQSxt... (flutter/engine#42689) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-09 03:00:28 +00:00
Zachary Anderson
d77fffc227 Revert Dart to 3.1.0-180.0.dev (flutter/engine#42688) 
For https://github.com/flutter/flutter/issues/128546
 2023-06-08 19:21:18 -07:00
Mitchell Kember
b1fa42d81e [fuchsia] Bump the target API level to 12, and pass it to fidlc (flutter/engine#42667) 
This makes the GN build pass the target Fuchsia API level to fidlc.
Currently it relies on the default of HEAD, meaning all FIDL changes are
immediately visible when the SDK rolls. This was never the intention:
flutter should be targeting a specific API level.

This unblocks https://fxrev.dev/864297 which makes the fidlc --available
flag required, and which uncovered this problem.

I also copied the changes to gen_response_file.py from
https://fxrev.dev/865020 to make it forward --available to fidlc.
 2023-06-09 11:56:49 +10:00
Brandon DeRosier
320a689d5e [Impeller] Add tests for foreground blends with mask blurs (flutter/engine#42687) 
Part of https://github.com/flutter/flutter/issues/127232.

Both of these tests should be rendering as a clipped and blurred green circle. Making mask blurs interact correctly with color filters is not going to be trivial... These bugs extend beyond the filter graph itself. Want to get some goldens in to compare against.

ForegroundPorterDuffBlend:
![Screenshot 2023-06-08 at 4 58 54 PM](https://github.com/flutter/engine/assets/919017/e5592b35-1054-48f3-91e4-c97136a2ecfd)

ForegroundAdvancedBlend:
![Screenshot 2023-06-08 at 4 58 38 PM](https://github.com/flutter/engine/assets/919017/8de5d12a-6413-4436-aa35-f3a4ef09615f)
 2023-06-09 01:15:07 +00:00
godofredoc
dcb764b1d3 Document the use of realm in archives. (flutter/engine#42682) 
Add docs for realm propery in the archives of build configuration files.

Bug: https://github.com/flutter/flutter/issues/126121

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-09 00:43:12 +00:00
skia-flutter-autoroll
5da295b8cb Roll ANGLE from 76b0e7f38b44 to d8339e78db54 (1 revision) (flutter/engine#42684) 
76b0e7f38b..d8339e78db

2023-06-08 cnorthrop@google.com FrameCapture: Support EGLSync in MEC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-09 00:05:54 +00:00
godofredoc
0f80fdedc2 Prevent double upload of benchmarks. (flutter/engine#42683) 
The benchmarks have been migrated to v2 but the legacy build is uploading benchmarks even when running on staging.

Bug: https://github.com/flutter/flutter/issues/127678

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-08 23:38:03 +00:00
skia-flutter-autoroll
5e7cb35786 Roll ANGLE from 5215293366f0 to 76b0e7f38b44 (2 revisions) (flutter/engine#42680) 
5215293366..76b0e7f38b

2023-06-08 syoussefi@chromium.org Vulkan: Use reserved SPIR-V ids for internal variables
2023-06-08 romanl@google.com Inline remaining _angle_trace_common* vars

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-08 22:32:30 +00:00
godofredoc
834380cdfa Remove all the uses of master branch in the .ci.yaml file. (flutter/engine#42679) 
Master branch is not the default branch in the engine anymore and we should not run any builds on it.

Bug: https://github.com/flutter/flutter/issues/90476

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-08 22:31:52 +00:00
godofredoc
b58192e6b1 Replace benchmarks with its v2 version. (flutter/engine#42677) 
Benchmarks has been migrated to engine v2 and it is ready to replace the legacy version.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-08 22:18:11 +00:00
Brandon DeRosier
3dd6e55e45 [Impeller] Reorder blend filter checks to avoid unnecessary destination snapshot (flutter/engine#42678) 
Side quest of https://github.com/flutter/flutter/issues/127232.

Tiny reordering to avoid unnecessary input resolution. :) Happened to notice we were hitting this case while going through some frame captures of reported fidelity issues.

Before:
![Screenshot 2023-06-08 at 1 45 48 PM](https://github.com/flutter/engine/assets/919017/aae28b7d-985d-4f16-9801-c689f8dc6f18)

After:
![Screenshot 2023-06-08 at 1 48 49 PM](https://github.com/flutter/engine/assets/919017/b667a4cd-bcf7-4e3a-98f7-0ed182b7a227)
 2023-06-08 22:00:56 +00:00
Brandon DeRosier
81a4a5e34b [Impeller] Specify blend mode on blend filter commands (flutter/engine#42676) 
Side quest of https://github.com/flutter/flutter/issues/127232.

This is particularly useful for debugging pipeline blend variations of the blend filter, since we otherwise have to look at the raw pipeline blend ops and figure out and piece together what the blend mode must've been.
 2023-06-08 21:58:59 +00:00
skia-flutter-autoroll
265c484dc7 Roll ANGLE from c49674d1565c to 5215293366f0 (1 revision) (flutter/engine#42673) 
c49674d156..5215293366

2023-06-08 romanl@google.com Add trace_interface: functions and callbacks for traces

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-08 21:16:12 +00:00
Renzo Olivares
8b7818b946 [Linux] composing delta fixes (flutter/engine#42648) 
Fixes a few issues with the Linux text editing delta implementation that was causing some issues when composing CJK text.

`im_preedit_changed_cb` dispatches a delta with the delta range set as the current composing region causing a crash when composing because the new composing region range might not yet exist in the `oldText` that the delta is applied to. We should instead send the composing region before the change to the text as that will be the correct range that is being modified in the `oldText`.

`im_preedit_end_cb` dispatches a delta with an empty `oldText`, a not empty `deltaText`, and a delta range of `(-1,-1)` causing a crash when composing ends because the delta range will never be within the range of the text. We should instead send the current text value as the `oldText` and not send a `deltaRange` or `deltaText` since a `(-1,-1)` range essentially means nothing in the text changed.

`im_commit_cb` does not account for the case when we were previously composing when the text was committed. This causes the dispatched delta to have a delta range that always inserts at the current the selection, when it should instead replace the previous composing range. We should account for the case when we are previously composing before committing the text, and dispatch a delta with the previous composing region.

Fixes https://github.com/flutter/flutter/issues/113909
 2023-06-08 21:14:01 +00:00
toneyzeng
c659b9a590 Fix: invalid time-point comparison between each from different clock source (flutter/engine#42409) 
Sometimes the time point created late will less than the time point create earlier since the CLOCK SOURCE has changed.

We must make sure the  CLOCK SOURCE (fml::TimePoint) is always keep the same while we are testing. 
Corrects the test case is needed before we fix the problem completely.
 2023-06-08 21:12:12 +00:00
Zachary Anderson
2415136734 Revert Dart to 3.1.0-184.0.dev (flutter/engine#42671) 
Reverting for https://github.com/flutter/flutter/issues/128527
 2023-06-08 12:50:44 -07:00
skia-flutter-autoroll
7a0d498ca6 Roll ANGLE from b5d261ac5c5b to c49674d1565c (2 revisions) (flutter/engine#42670) 
b5d261ac5c..c49674d156

2023-06-08 prashanthsw@google.com Remove stale Android NDK and references [2/2]
2023-06-08 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from 510a3dff2ba2 to b36c4c847faa (64 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-08 19:27:35 +00:00
skia-flutter-autoroll
aef3ad82fd Roll Dart SDK from b7fe6e0c274c to 3a9145a57432 (1 revision) (flutter/engine#42668) 
https://dart.googlesource.com/sdk.git/+log/b7fe6e0c274c..3a9145a57432

2023-06-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-186.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-08 18:14:35 +00:00
Jonah Williams
e448fff0da [Impeller] sort all vertex inputs by location. (flutter/engine#42664) 
Fixes https://github.com/flutter/flutter/issues/128283

Why doesn't this happen elsewhere? might depend on how spirv compiles shaders or the order they run in. Long term fix is https://github.com/flutter/engine/pull/42628 which computes all offset data in the compiler

![flutter_04](https://github.com/flutter/engine/assets/8975114/645c5db6-4f2f-42f7-af8f-6230bba72b2b)
 2023-06-08 17:23:52 +00:00
skia-flutter-autoroll
108840bd57 Roll ANGLE from 05e087658b10 to b5d261ac5c5b (1 revision) (flutter/engine#42662) 
05e087658b..b5d261ac5c

2023-06-08 ynovikov@chromium.org Roll chromium_revision be1b60e248..510a3dff2b (1154868:1154869)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-08 17:08:58 +00:00
Zachary Anderson
8e7fbbb8a7 Revert "[Impeller] Added a switch to turn on vulkan" (flutter/engine#42660) 
Reverts flutter/engine#42585

Reverting to investigate
https://github.com/flutter/flutter/issues/128484
 2023-06-08 09:04:17 -07:00
skia-flutter-autoroll
80ec02d637 Roll ANGLE from 15a29438b099 to 05e087658b10 (6 revisions) (flutter/engine#42659) 
15a29438b0..05e087658b

2023-06-08 prashanthsw@google.com Fix gitignore entries to ignore android_toolchain
2023-06-08 m.maiya@samsung.com Remove thread from mActiveThreads during eglTerminate
2023-06-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a6525fe76b4c to c5a1402a455f (35 revisions)
2023-06-08 prashanthsw@google.com Disable the roll of 'android_ndk'
2023-06-08 ianelliott@google.com Galaxy A23: add end2end expectations for crashing tests
2023-06-08 ianelliott@google.com Android: Galaxy A23 support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-08 15:50:09 +00:00
skia-flutter-autoroll
19017f2c19 Roll Fuchsia Linux SDK from aMTaMP0DdKdJnxSbc... to lPCv1NshK-tvjtLgC... (flutter/engine#42658) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-08 14:02:05 +00:00
skia-flutter-autoroll
0c1b4bd9fb Roll Fuchsia Mac SDK from DL1QQ5eZRVNARqLx-... to ukXXOXtI7uRIukzF5... (flutter/engine#42655) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-08 13:58:08 +00:00
skia-flutter-autoroll
57793db8af Roll Dart SDK from f0ae96d202ca to b7fe6e0c274c (1 revision) (flutter/engine#42657) 
https://dart.googlesource.com/sdk.git/+log/f0ae96d202ca..b7fe6e0c274c

2023-06-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-185.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-08 13:56:28 +00:00
skia-flutter-autoroll
d14e06b99b Roll Dart SDK from 9e633e463902 to f0ae96d202ca (1 revision) (flutter/engine#42651) 
https://dart.googlesource.com/sdk.git/+log/9e633e463902..f0ae96d202ca

2023-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-184.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-08 05:01:58 +00:00
godofredoc
3539afcbb8 Benchmarks configurations for engine v2. (flutter/engine#42622) 
This configuration migrates benchmarks to engine_v2.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-08 03:47:34 +00:00
skia-flutter-autoroll
aad7a69125 Roll Skia from 1a3adf848e61 to 8fdbbca7d35d (1 revision) (flutter/engine#42645) 
https://skia.googlesource.com/skia.git/+log/1a3adf848e61..8fdbbca7d35d

2023-06-07 kjlubick@google.com Decouple SkShaders from Ganesh backend

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-08 00:46:39 +00:00
skia-flutter-autoroll
f47b40cd19 Roll Dart SDK from bbce07ad3944 to 9e633e463902 (3 revisions) (flutter/engine#42646) 
https://dart.googlesource.com/sdk.git/+log/bbce07ad3944..9e633e463902

2023-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-183.0.dev
2023-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-182.0.dev
2023-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-181.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-08 00:46:37 +00:00
Alexander Aprelev
f3c26172de Roll dart to 3.1.0-180.0.dev (flutter/engine#42638) 
Roll dart to 3.1.0-180.0.dev
    
    Changes since last roll
    ```
    bbce07ad394 (tag: 3.1.0-180.0.dev) Version 3.1.0-180.0.dev
    81fc5e710d8 (tag: 3.1.0-179.0.dev) Version 3.1.0-179.0.dev
3b850bb1ace [js-rti] Support legacy types in `is FutureOr` specializer.
    dcac7808518 Update PULL_REQUEST_TEMPLATE.md
    5b3a57908d5 [dart:js_interop] Remove ObjectLiteral
30b9ac9f873 [dds/dap] Don't show skipped tests as passes in debug
adapter output
    79b71c789f6 Use ParameterReference for ChangeParameterType.
bc94e7662be [analyzer] Refactor visitConditionExpression in the const
evaluator.
    cf5168ea339 (tag: 3.1.0-178.0.dev) Version 3.1.0-178.0.dev
7071c65b8c7 Change TransformSetParser.singleKey() to avoid null asserts.
a3399e3616f [analysis_server] Add support for adding imports with
show/hide + update Move to File
    463c7cb5a2f [vm] Support unchecked AsExpressions in the VM
3a598b4c031 [vm, gc] Honor kAllocatablePageSize during promotion and
snapshot reading.
    b84077426ab (tag: 3.1.0-177.0.dev) Version 3.1.0-177.0.dev
    9421ca07994 Delete old debianpackage-linux builder.
    d4c2d659075 Remove unnecessary null check on `initializerType`.
26fd946904e Run CFE presubmit lints with scanner configured for null
safety mode.
    cbd1b8d4943 (tag: 3.1.0-176.0.dev) Version 3.1.0-176.0.dev
    033fa5e684d [build] Remove unused pipes import from vs_toolchain.py
b5ee6fa8885 [vm/ffi] Support native assets in `dart build` with relative
path
    5e8c29e7b68 (tag: 3.1.0-175.0.dev) Version 3.1.0-175.0.dev
    7335116e08a (tag: 3.1.0-174.0.dev) Version 3.1.0-174.0.dev
07f587504b1 Reland "[vm] Migrate FFI callbacks to the new metadata
system."
    369a8312aa4 [ddc] Fix types of constants in legacy libraries
    105f7e17222 (tag: 3.1.0-173.0.dev) Version 3.1.0-173.0.dev
526ce3aba48 Issue 52005. Convert non-exhaustive returning
SwitchStatement to SwitchExpression when followed by throw.
    cc18b250ae8 Bump github/codeql-action from 2.3.5 to 2.3.6
5ff0821b274 [kernel,vm] First-class kernel serialization of FutureOrType
and NullType
8d298292719 Use 'coveringNode' name in RefactoringContext, as it is in
Selection.
    97ec9e95bf8 Convert imported reference completion tests
f92c6da7bf4 [analyzer] Refactor visitAsExpression and visitIsExpression
in the constant evaluator.
    9e196bc7118 Roll gn from 5a004f9427a0 to e3978de3e8da
    7c63a493a22 (tag: 3.1.0-172.0.dev) Version 3.1.0-172.0.dev
88f05965ac4 Issue 52606. Fix AstNodeExtension.nodeCovering() when
selection if at the end of Comment.
09df4e5200b [ddc] Fix dynamic calls of generic methods with new types
    1e1266f8e6c [ddc] Sync dart_library.js from internal
56cb8de9736 Make ParsedUnitResult and ParsedLibraryResult superclasses
of ResolvedUnitResult and ResolvedLibraryResult respectively.
03b2abf78f2 [deps] rev async, dartdoc, ffi, http, leak_tracker, lints,
mockito, test, tools, webdev
29f121126ba [analysis_server] Allow skipping slow benchmarks with env
variable
    ```
 2023-06-07 16:28:03 -07:00
skia-flutter-autoroll
e2ea5e6410 Roll Skia from 156542f8bf13 to 1a3adf848e61 (1 revision) (flutter/engine#42644) 
https://skia.googlesource.com/skia.git/+log/156542f8bf13..1a3adf848e61

2023-06-07 michaelludwig@google.com [skif] Improve magnifier zoom window with missing content

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 23:19:50 +00:00
skia-flutter-autoroll
93b0156c27 Roll Skia from c5a8c4547f59 to 156542f8bf13 (4 revisions) (flutter/engine#42641) 
https://skia.googlesource.com/skia.git/+log/c5a8c4547f59..156542f8bf13

2023-06-07 robertphillips@google.com Disable rotated nearest-neighbor testing in the big image test
2023-06-07 johnstiles@google.com Emit simpler WGSL for-loops when the loop-count is known.
2023-06-07 johnstiles@google.com Add WGSL support for the discard statement.
2023-06-07 johnstiles@google.com Allow assignment to function parameters in WGSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 22:10:20 +00:00
Jason Simmons
08f35fa586 Roll HarfBuzz to 7.3.0 (flutter/engine#42629) 2023-06-07 21:51:10 +00:00