4261 Commits

Author SHA1 Message Date
Alexander Aprelev
db0aabe3ff Roll dart to 52afcba357ad398e8c24f3e3363ac6ff5293df63 (flutter/engine#4905)
* Roll to 59d859645ef0557bc7f8e2ee07957f506b755255

Changes since last roll:
```
59d859645e [fasta] Do new/const insertion in simple cases
4c0a09b79f [vm-service] Add setFlag.
bed5debbeb Callable object support in Analyzer and DDC.
a1e4d8e0bf Don't do implicit new/const code generation with --preview-dart-2 enabled.
49558b9c4c Fixed MessageChannel receiveing messages on ports. Removed pkg browser from tests.
e150bf638c Fix tests for missing required SDK libraries on Windows.
b970d834e1 Update type_representation_test to test strong mode types
85d5812a93 Port type_representation_test to work with kernel
8504808ce3 Remove Dart 2 errors in package:js_ast
a6a2152482 Add runtime type representation for void
477a773cdb [fidl] Port Dart runtime to FIDL2.
d46dd1bd68 fix error message for dcalls on null
af22f6a591 Track calls to 'pub get' from analysis_server
8d689fcca7 step 4 of ??: add omit-implicit-checks and preview-dart-2 flags, strong-mode defaults to include implicit checks.
f201ace7f3 Check for missing required libraries dart:core and dart:async.
d53291d156 Fix MockErrorCode after adding isUnresolvedIdentifier.
b05ba71b0c [VM runtime] Minor clean up of type test with non-function type object.
ce1d52481c Don't remove unused imports when there are unresolved symbols.
ad9afa1656 Add the isUnresolvedIdentifier flag for ErrorCode.
14806df576 Make correction parameter optional named in ErrorCode and subclasses.
98f627f989 Issue 32708. Make GenericFunctionTypeElementForLink implement GenericFunctionTypeElementImpl.
3306aabd82 Fix for type inference from instance creation arguments.
055dfad887 Fix the test to determine whether a library is in the SDK
506ac7f953 Rework linker type inference using ExprBuilder.
494b861d00 Further prep work for #32525.
7d90df42f1 [Kernel, VM runtime] Hook up bool checks in strong mode (fixes #32336). Update kernel status file.
```

* Update license hash. No changes to licenses.

* Roll to pick up SIGTTOU fix.

* Update license hash. No changes to licenses
2018-03-30 14:07:57 -07:00
Alexander Aprelev
912f4fd79d Revert "Roll Dart for FIDL2 (#4906)" (flutter/engine#4907)
This reverts commit 5950b13e3bd8e961b46b285dc3bf2bf60cbd10e9.
2018-03-30 13:56:55 -07:00
Ian McKellar
5950b13e3b Roll Dart for FIDL2 (flutter/engine#4906) 2018-03-30 13:33:51 -07:00
Alexander Aprelev
2f17326a65 Revert pub roll from recent dart roll. (flutter/engine#4904)
pub rolll causes https://github.com/dart-lang/pub/issues/1853.
2018-03-30 07:37:03 -07:00
Jeff Brown
9e40f3e2d3 Port flutter content handler to FIDL2. (flutter/engine#4903) 2018-03-29 21:49:35 -07:00
Alexander Aprelev
fe83adc6fe Roll dart. (flutter/engine#4902)
* Roll dart.

Changes since last roll:

4da52281aa [frontend-server] Return non-zero exit code if there are errors.
d7a540bfe7 Document --enable-asserts in dart2js's help, and remove --checked.
d9c3190e44 [vm] Remove some bin -> vm includes.
3dcdaf9e57 [vm] Check for OOM when allocating a new handle block.
865f52737a [dart:io] Adds IOOverrides.socketConnect
f858e5d539 Replace Token.previous usage in BodyBuilder
f66532b31b Replace more occurrences of token.previous with findPrevious
d46915d239 Bring in the latest pub
7470f410dd Clean up documentation of command-line analyzer options
4b682341d9 [ VM / Dart 2 ] Marked tests that exercise functionality not supported in Dart 2 as SkipByDesign.
859632b439 Fixes for uninitialized fields of Flutter widgets create constructors in Flutter style.
c9e9c1d8e9 Remove dart:isolate runtime support in DDC
0482cf4da1 [fuchsia] Add rules to build gen_snapshot targeting Fuchsia
2de82410e0 Make isolate patch play nice with web workers.
be3baa0b8f Additional ExprBuilder implementation.
42581e4fa6 [VM] Added '--enable-asserts' to the top-level help message.
44dbba2b80 Use offset/length of the import prefix, or empty. Same for constructor names.
85b4c604c5 [VM runtime] Improve type error messages in Dart 2 (fixes #32564). Hide private class _Future and map it to core lib class Future. In Dart 2, show dynamic as type argument(s) of raw generic types.
ebdee7ee0f More prep work to allow the linker to re-use resolution logic.
91e6c8b019 Fix missing_return warning in expr_builder.dart
59de9710ea Complete Flutter's setState() as a whole statement, with a closure, and the caret inside the closure.
b82e5b4704 Replace code completion usage of token.previous with findPrevious
0e8457c8c8 Fix for building sequence of identifiers and several tests.
6a84638d7a Updated for proper failure.
577b168c39 Fix jsinterop bug: we incorrectly added null values for js-interop constructor calls.
8e02ff92db Added @category annotation for Web libraries and removed createCustomUpgrader.
c60199cf86 [vm/kernel/aot] Tree shaking based on results of TFA, take 2.
b217e21907 Mark a few more co19 failures to fix.
70f455351d [kernel] Add field for instantiate-to-bounds algorithm in TypeParameter.
bc75856e54 Update getClientRects, removed xtab, removed bogus entry in dom.json, expose ServiceWorker, removed query and queryAll from in dart:html, added constructor to MessageChannel and removed getCssCanvasContext.
f9e12f1116 step 3 of ??: ignore old options from old FE
c0fa4e2fe3 step 2 of ??: remove unnecessary pattern in -m option
51867f28a2 step 1 of ??: cleaning up options...

* Update license hash. No license changes.
2018-03-29 14:54:24 -07:00
Dan Field
151204edf5 Support Path.addCircle (flutter/engine#4783)
* add Path.addCircle

* docs formatting

* revert path.cc/path.h; remove addCircle and update docs on addOval

* add missing file.
2018-03-28 21:04:47 -07:00
xster
0739f028f4 Add hint to use ninja with goma (flutter/engine#4894) 2018-03-28 15:51:33 -07:00
Ben Konyi
e4cfd10241 Rolled Dart SDK to e3051175192c83fafa3636c0f16d804734bb285a (flutter/engine#4877)
* Rolled Dart SDK to e3051175192c83fafa3636c0f16d804734bb285a
2018-03-28 14:36:58 -07:00
Jason Simmons
f6a5a300d5 libtxt: move to the next run if the current run ends before the start of the line block (flutter/engine#4891)
Fixes https://github.com/flutter/flutter/issues/15975
2018-03-28 14:18:37 -07:00
Zachary Anderson
a3666e8280 Retry fixing vulkan include (flutter/engine#4874) 2018-03-27 10:10:45 -07:00
Ryan Macnak
485d4b795d Make flutter_test on Mac exit on error like Linux and Windows. (flutter/engine#4873) 2018-03-26 20:51:19 -07:00
Ryan Macnak
fcb00ca95b Revert "Fix vulkan include path (#4870)" (flutter/engine#4872)
Breaks Linux and Mac build bots.

This reverts commit 2321c199f0bd35878cd9cecc36d69dbab5245041.
2018-03-26 16:56:00 -07:00
Jason Simmons
b035c5b0f6 Allow FirstFrameListeners to remove themselves from the FlutterView's list (flutter/engine#4871)
Fixes https://github.com/flutter/flutter/issues/15884
2018-03-26 15:43:38 -07:00
Zachary Anderson
2321c199f0 Fix vulkan include path (flutter/engine#4870) 2018-03-26 14:05:25 -07:00
Stanislav Baranov
05943ceb68 Support for decimal and signed numeric keyboard (flutter/engine#4853)
* Support for decimal and signed numeric keyboard

* Comments
2018-03-26 13:14:38 -07:00
Yegor
ee3f5ece99 CONTRIBUTING.md: explain the need for building host with non-host (flutter/engine#4863)
* CONTRIBUTING.md: explain the need for building host with non-host

* address comments

* locally-built
2018-03-23 17:50:52 -07:00
Siva
b5660698e7 - roll Dart to 2f68e82526d59b679a522e25db224d8c7e23d280 (flutter/engine#4864) 2018-03-23 15:33:21 -07:00
Brian Salomon
caccc81f4d Remove declaration for undefined GPUSurfaceGL::SelectPixelConfig (flutter/engine#4857) 2018-03-23 12:38:58 -04:00
Brian Salomon
828875524a Vulkan swap chain setup no longer uses GrPixelConfig and doesn't include from skia/src (flutter/engine#4856) 2018-03-23 12:38:41 -04:00
Alexander Aprelev
81ba175c42 Revert dart roll 20180322 (flutter/engine#4855)
* Revert "Roll back pub upgrade. (#4854)"

This reverts commit 222b6fe552d13a9dee5eb133327db417388629be.

* Revert "Roll flutter 20180322a (#4852)"

This reverts commit e10e11745ac2171acbad2aa20750474f7d95584a.

* Revert "Roll dart to 95e9e890a9 (#4850)"

This reverts commit 4c6f33a0c03f8c20155b07b1d95b5d3ab7e64774.
2018-03-22 22:30:24 -07:00
Alexander Aprelev
222b6fe552 Roll back pub upgrade. (flutter/engine#4854)
New version of pub causes https://github.com/flutter/flutter/issues/15848.
2018-03-22 21:22:04 -07:00
Alexander Aprelev
e10e11745a Roll flutter 20180322a (flutter/engine#4852)
* Roll dart to af1436931b.

Changes since last dart roll:

```
af1436931b (HEAD, origin/master, origin/HEAD) [CFE] Fix for insertion of duplicate NSM forwarders
48644d5f6a [CFE] Fix crash when trying to add NSM forwarder for a field
898260a998 Split dependency on dart:html from dart:js
ef919c5eb3 fix commit queue: update nSM test expectation on ddc too.
d014fce4de Update dartkp NSM expectations.
6bd38cc912 Analysis Server API for 'Extract Widget' refactoring.
123e59c189 Improve for loop recovery
790b7b98fb [kernel] Update more NSM expectations.
696be0ae46 Initial support for extracting methods.
8d669c9d4e [kernel] Update NSM-forwarding test expectations.
edf039d510 [ VM / Dart 2 ] Made StackMapGC test strong-mode clean. Fixes part of 32190.
77239ee1db [fuchsia] Replace use of deprecated fdio_get_vmo with fdio_get_vmo_clone.
```

* Update license hash. No changes to the licenses
2018-03-22 16:20:12 -07:00
Ian Hickson
f8f2558835 Document Window.defaultRouteName a little better. (flutter/engine#4851) 2018-03-22 15:55:59 -07:00
Alexander Aprelev
4c6f33a0c0 Roll dart to 95e9e890a9 (flutter/engine#4850)
* Roll dart to 95e9e890a9

Changes since last roll:

```
95e9e890a9 [kernel/vm] Implement NSM-forwarding in the VM.
7450e2ad60 Fix parsing of invalid interpolation in string literal
cd03f35a0b Prepare for analyzer 0.31.2-alpha.1, front_end 0.1.0-alpha.11, and kernel 0.3.0-alpha.11.
38b0825a55 [kernel] Add target for Flutter on Fuchsia.
2fd9969c96 extend unstable API to pass in the location of the libraries-specification
1caf7b7ecd Revert "Create new AnalysisSession instance on changes."
c90ca298ed Provide a message for InconsistentAnalysisException.
b6944e3165 Make use of environment overrides in fasta's implementation of config specific imports
26c06cdd82 Clean up Dart 2 type issues related to YAML support
4989976a81 Add CFE support for noSuchMethod forwarders
014bd821e6 Retry when fixes cannot be computed because of an inconsistent session (issue 32635)
04f5d1b974 Recover from missing while in do/while statement
dc5a8b2e91 Improve the fix to add an explicit cast
c7cdb72f32 Move CloneWithoutBody to Kernel API
2be1456309 [fasta] Fix not being able to output a program because of erroneousProgram
17a778c9cb Changed AudioScheduledSourceNode.start to start2. Fixes https://github.com/dart-lang/sdk/issues/32624
ae9b76dba6 [kernel] Add flag for NSM-forwarding stubs.
691bb9b299 [vm/compiler] Add a comment about MakeTemporary limitation.
83bfbcdd96 Incremental compilation: computing class hierarchy for reachable things only
0dd2a8dbdb Incremental compiler: Only include libraries loaded from dill if used
b4206bb92c Remove dartk
bb2bf609be Incremental compiler: Deal with disappearing package
2e366e8c9a [fasta] Refactor incremental_load_from_dill_test
4f40e43d7a Incremental compiler: Add test that mixes in something from the sdk
83c0a75564 [fasta] Add failing test to incremental compiler test suite
3a81263fee [ VM / Dart 2] Split DartAPI_PropagateError into DartAPI_PropagateError and DartAPI_PropagateCompileError since the compile time error from the missing semicolon prevented the code from being executed in Dart 2.
4905a2da7c Fix pub issues links from bde48c67ec6bd76a475ead02f45a16c1c0309529
bde48c67ec Update pub dependency
95089a2eeb cleanup CHANGELOG for -dev.39 and -dev.40
068be3b656 [ VM / Dart 2 ] Fixed issue where TokenPosition::kNoSource was being registered as the position of native methods. Fixes DartAPI_CurrentStackTraceInfo
5430010395 Use writeFieldDeclaration() and writeFunctionDeclaration() to write extracted widget.
1d774b7f77 Add "environment_overrides" section to libraries-specification.
36d4fd37a7 Mark test as flaky
f2806ab624 [Corelib, VM runtime] Fix handling of zero operand in Bigint operations (fixes #32465). Fix VM, dart2js, and dcc Bigint implementations. Add shift tests. Re-enable Bigint intrinsics on VM.
9f0e391e28 Rename writeParameterSource() to writeParameter() and make 'type' optional.
8136c957a1 Improve fasta parser library declaration recovery
b3c4b1c2ef Remove pkg/browser from SDK source – use mirror
179db6dc6a Remove usage of pkg:browser from tools/dart2js/sourceMapViewer
a81f4babcc Revert "[ VM / Dart 2 ] Fixed StackTraceFormat test to expect file URIs in stacks generated by the Dart frontend."
ae130bc187 [ VM / Dart 2 ] Fixed StackTraceFormat test to expect file URIs in stacks generated by the Dart frontend.
2546f2235e Fix status lines for html group tests - group was duplicated in logs.
8658a7403e Check for references/writes to superclass members.
15bf72615d Fix for using isFinal/isConst with type in writeFieldDeclaration().
a8986cf45a Support for parameters for extracted widget.
aac5d04198 [infra] Add optimization_counter_threshold builder tag to the test matrix
fe5e2444ad [ VM / Dart 2 ] Fixed DartAPI_InvokeCrossLibrary test.
dddb578fbb Update Safari status for two tests
521846c832 [VM] When generating the token position list for each line (for a [Script]), only scan relevant classes/functions/fields
8630c69c9f Add typeInfo expression accessor
587e4f8723 Parse local function metadata
8493f68271 Adjusted status for lib_2/async/future_or_type_test.dart
7c05f1e608 Add more tests for FutureOr used as a type.
1fc73bf1a6 Compute ClassFunctionType from signature function in Dart 2
ad5f5abb13 Remove dart2js self analysis tests
31dd6683f8 [VM] Optimize performance of dart_boostrap in debug-kernel-strong mode.
38dc57504b [status] Update corelib_2 status for bigint test
6469f4c78a Support for extracting widget from a function.
00ec3b0867 [vm] Fix several kernel-specific memory leaks.
b7c3c32f63 [vm] Do not assign type to phi if it was loaded from a different local
d26c310a27 Rework parsing of local const declarations
06638dd17f [ VM / Dart 2 ] Removed DartAPI_NativeFieldAccess and DartAPI_InjectNativeFields1 as they were using Dart_CreateNativeWrapper which doesn't make sense in the context of Dart 2. Also did some status file cleanup and reorganization.
a5966ad988 Fix dart2js libraries.yaml
ec65830504 [ VM / Dart 2 ] Fixed DartAPI_LookupLibrary test which was treating the script in Dart_LoadScript as kernel instead of source.
8abeb56ebb Basic 'Extract Widget' refactoring.
996277d427 Entity-fy the non-frequence minifier so it can be supported under the CFE.
0e764393f3 A few more Dart2 related fixes
965cb81c0f Add AnalysisSessionHelper and move getClass() into it.
1c5d2e9016 Bump linter to 0.1.45
86b1646475 webSQL is not suported by Firefox fixed test supported should of true should not be expected.
3d34f4d4fe Updated CHANGELOG with Chrome 63 roll changes and fixed status file test now passes.
08d305bbd7 Inline modifiers into endTopLevelFields and endFields events
efab00ce5c Fix type issues caused by running with --preview-dart-2
adb9f8cc0b Inline modifiers into beginClassDeclaration and beginNamedMixinApplication
b75fb574ee Fix async_compiler_input_provider_test for Windows
fd005e17bc Rework parsing of local function declarations
8eb749e032 Fix sourcemaps/name_test for kernel
581c512345 Fixed DOMRectList not having a prototype field.
031ef989ac Provide better error message when a linked dependency doesn't exist
d9878ae0da fix regression in DDC handling of top-level field named 'name'
ac322d0fb4 Move LibraryElement caching to AnalysisSession.
2047d44631 Handle the case where there is no selection(issue 32563)
```

* Update license hash. No changes to licenses.
2018-03-22 13:16:49 -07:00
Jason Simmons
58277dcd62 Fix GPUSurfaceGL includes on Linux (flutter/engine#4849) 2018-03-22 11:40:29 -07:00
Ian Hickson
c8d191401f Slightly improve the docs for the internal _futurize method (flutter/engine#4847) 2018-03-22 10:52:50 -07:00
Chris Bracken
6eb10b4841 Fix supported color type check on iOS simulators (flutter/engine#4846)
Since OS_MACOSX and OS_IOS are both enabled for simulator builds, ensure
we're using constants conistent with our #includes.
2018-03-21 19:31:24 -07:00
Chris Bracken
9dcf4907f6 Fix GPUSurfaceGL includes on macOS (flutter/engine#4844)
macOS doesn't include GLES support.
2018-03-21 16:45:41 -07:00
Chris Bracken
9f169ccfbb Handle Apple-specific GLES headers (flutter/engine#4843)
In 2bd16b8a3bafbb828f994a303db5dfd03e6f68c4, includes were added for
GLES. On macOS/iOS, these headers are named slightly differently.
2018-03-21 16:16:04 -07:00
Brian Salomon
2bd16b8a3b VulkanSurface and GPUSurfaceGL no longer use GrPixelConfig (flutter/engine#4814)
* VulkanSurface and GPUSurfaceGL no longer use GrPixelConfig

* fix 565

* fix gpu_surface_gl changes
2018-03-21 14:13:05 -07:00
skia-flutter-autoroll
2b4e8a5af5 Roll Skia (flutter/engine#4841) 2018-03-21 13:28:32 -07:00
Sarah Zakarias
18fe5d7dec Provide asset lookup key on ios (flutter/engine#4817) 2018-03-21 11:36:49 +01:00
Jason Simmons
53df117523 Load kernel files from the script URI in the isolate create callback (flutter/engine#4828)
Fixes https://github.com/flutter/flutter/issues/15731
2018-03-20 17:25:22 -07:00
Zachary Anderson
fb3456f64f Remove some unneeded profiling flags (flutter/engine#4827) 2018-03-20 15:48:41 -07:00
Jason Simmons
1127f37509 Remove the canvas save/restore calls in Paragraph::Paint (flutter/engine#4822)
This is a workaround for https://github.com/flutter/flutter/issues/15702

Skia was not drawing the paragraph's text blobs in some cases when a
save/restore sequence is done around the canvas->translate call.  The
problem does not occur if an offsetting call to translate is made instead
of the save/restore.  Will need to work with Skia to find the root cause.
2018-03-20 11:30:00 -07:00
Siva
673ab2c34b Roll dart version to 06949dc98556adb807e270c47cbb9407ec781064 (flutter/engine#4816)
Includes the following changes
- Flip analyzer and server to preview-dart-2 by default
- [vm] Move writing snapshot magic value from embedder to VM
- Fix bug in BigInt.from with certain double value
- [vm] Clean up any remaining API scopes in Dart_ShutdownIsolate.
- [analyzer] Don't expect type arguments for class type parameters of static methods.
2018-03-19 17:45:44 -07:00
Michael Goderbauer
b716162f77 Rename isPassword to isObscured (flutter/engine#4815) 2018-03-19 15:52:16 -07:00
Jonah Williams
c407876859 Allow shadows to be colored when physical layer is drawn by engine (flutter/engine#4812)
* pass shadow_color from dart:ui to physical layer

* default shadow color to SK_ColorBLACK

* add doc comments to pushPhysicalShape
2018-03-19 14:16:17 -07:00
Jason Simmons
7c1c5b5280 Fix a missing paren (flutter/engine#4808) 2018-03-19 12:07:28 -07:00
Ryan Macnak
7886e02834 Reapply "Roll Dart to f1ebe2bd5cfcb6b522e5b4fd406cdabb1a2d2091." (flutter/engine#4809) 2018-03-19 11:22:23 -07:00
Michael Goderbauer
e93b5198e7 Support password fields on Android (flutter/engine#4781) 2018-03-19 10:25:09 -07:00
Alhaad Gokhale
ab632603e1 Revert "Roll Dart to f1ebe2bd5cfcb6b522e5b4fd406cdabb1a2d2091. (#4800) (#4805)" (flutter/engine#4807)
This reverts commit 8790a33a0ddfa70635e5dd87d795bb9051e17d3d.
2018-03-19 09:51:41 -07:00
mikejurka
8790a33a0d Roll Dart to f1ebe2bd5cfcb6b522e5b4fd406cdabb1a2d2091. (#4800) (flutter/engine#4805) 2018-03-16 17:08:06 -07:00
Chris Bracken
507f0c79aa Eliminate iOS depth/stencil buffer code (flutter/engine#4802)
As of d5fdb1a189f3bf5973ec3e667c92cb906816946b, depth/stencil buffer
attachments are never used. This patch eliminates generation and binding
of depth/stencil render buffers since these code paths are no longer hit.
2018-03-16 16:47:06 -07:00
mikejurka
713dbf4ca8 Revert "Roll Dart to f1ebe2bd5cfcb6b522e5b4fd406cdabb1a2d2091. (#4800)" (flutter/engine#4803)
This reverts commit e121d45124ba9cf6270427ff46017ea26fc2c8fa.
2018-03-16 16:22:41 -07:00
Chris Bracken
c4d964e1f5 Cache render buffer extents when no depth/stencil buffer (flutter/engine#4801)
Previously iOS render buffer storage width and height were not cached if
not using a depth/stencil buffer. This adds a similar check for
colorBuffer to avoid reallocating render buffer storage.
2018-03-16 15:40:31 -07:00
mikejurka
16892af75c [fuchsia] Updated scenic fidl prefix (flutter/engine#4798) 2018-03-16 14:13:19 -07:00
Ryan Macnak
e121d45124 Roll Dart to f1ebe2bd5cfcb6b522e5b4fd406cdabb1a2d2091. (flutter/engine#4800) 2018-03-16 12:17:38 -07:00
Jason Simmons
332364465f libtxt: retain hard line breaks when calculating maxIntrinsicWidth (flutter/engine#4796)
maxIntrinsicWidth should reflect what the width of the text would be if no
soft line breaks are added.  Hard line breaks should still be incorporated
into the maxIntrinsicWidth.

Fixes https://github.com/flutter/flutter/issues/15588
2018-03-16 10:28:59 -07:00