5326 Commits

Author SHA1 Message Date
Jason Simmons
dabcd4c19c Merge pull request #1837 from jason-simmons/canvas_image_memory_leak
Fix a memory leak in CanvasImageDecoder
2015-10-27 15:11:43 -07:00
Jason Simmons
7983d5f0c5 Fix a memory leak in CanvasImageDecoder
CanvasImageDecoder is instantiated with a callback into a Dart closure.
That closure was holding references to the ImageDecoder and the returned
Image.  The circular reference between the ImageDecoder and the callback
prevented the objects from being GCed, resulting in leakage of the image
buffer.

CanvasImageDecoder will now destroy the callback after it is invoked,
thus releasing its handle to the Dart closure.
2015-10-27 15:05:30 -07:00
Hans Muller
21244bb13a Merge pull request #1810 from HansMuller/modal_bottom_sheet
Adds modal bottom sheets: showModalBottomSheet()
2015-10-27 15:02:25 -07:00
Hans Muller
66d2fc33a3 Adds modal bottom sheets: showModalBottomSheet() 2015-10-27 14:57:18 -07:00
Ian Hickson
cd74be1090 Merge pull request #1836 from Hixie/metrics-changed
Notification of metrics changes.
2015-10-27 14:36:19 -07:00
Hixie
e34aefbd8a Notification of metrics changes.
The Rendering layer binding now multiplexes the dart:ui metrics change
notification so that multiple consumers can all listen to the change.
2015-10-27 14:32:00 -07:00
Adam Barth
5855f72202 Merge pull request #1835 from abarth/drag_start
Add the position at which drags start
2015-10-27 14:31:40 -07:00
Adam Barth
1e51daa530 Add the position at which drags start
Fixes #1807
2015-10-27 14:25:03 -07:00
Adam Barth
d25ff94259 Merge pull request #1832 from abarth/tap_position
Add a position to the onTap callback
2015-10-27 14:20:35 -07:00
Adam Barth
0d1e58072b Add a position to the onTap callback
Fixes #1807
2015-10-27 14:12:54 -07:00
Viktor Lidholt
400ba1799e Merge pull request #1833 from vlidholt/master
Improves physics debug drawing
2015-10-27 14:08:05 -07:00
Ian Hickson
ce83055a17 Merge pull request #1830 from Hixie/track-scroll-position
Track scroll position
2015-10-27 13:50:16 -07:00
Ian Hickson
4b56dd50a0 Track scroll position
- Change RouteArguments to pass the route's BuildContext rather than
  the Navigator. This caused the bulk of the examples/ and .../test/
  changes (those are mostly mechanical changes). It also meant I could
  simplify Navigator.of().

- Make initState() actually get called when the State's Element is in
  the tree, so you can use Foo.of() functions there. Added a test for
  this also.

- Provide a RouteWidget so that routes have a position in the Widget
  tree. The bulk of the route logic is still in a longer-lived Route
  object for now.

- Make Route.setState() only rebuild the actual route, not the whole
  navigator.

- Provided a Route.of().

- Provided a Route.writeState / Route.readState API that tries to
  identify the clients by their runtimeType, their key, and their
  ancestors keys, up to the nearest ancestor with a GlobalKey.

- Made scrollables hook into this API to track state. Added a test to
  make sure this works.

- Fix the debug output of GestureDetector and the hashCode of
  MixedViewport.

- Fixed ScrollableWidgetListState<T> to handle infinite lists.
2015-10-27 13:46:07 -07:00
Viktor Lidholt
6358ddfd62 Updates physics test to draw debug 2015-10-27 13:39:19 -07:00
Viktor Lidholt
851c96d194 Improves physics debug drawing 2015-10-27 13:38:52 -07:00
Viktor Lidholt
872ff30305 Fixes issue with physics collision groups 2015-10-27 13:38:20 -07:00
Adam Barth
0d0f49b4a5 Merge pull request #1829 from abarth/more_void_callback
Use VoidCallback in more places
2015-10-27 11:50:38 -07:00
Adam Barth
9c8196b4d1 Use VoidCallback in more places
We still use special-purpose typedefs in the gesture code for symmetry with
other gesture callbacks.

Fixes #1827
2015-10-27 11:19:44 -07:00
Adam Barth
b507577966 Merge pull request #1822 from abarth/custom_shifted_box
Add CustomOneChildLayout
2015-10-27 11:10:00 -07:00
Adam Barth
c8b9359b7d Merge pull request #1825 from abarth/tap_tracker
Make TapTracker and TapGesture private classes
2015-10-27 11:09:34 -07:00
Adam Barth
fbfbd57f65 Add CustomOneChildLayout
A CustomOneChildLayout is a widget that lets you perform a custom layout in the
simplified setting of sizing and positioning a single child.
2015-10-27 11:04:32 -07:00
Adam Barth
4dc478948c Merge pull request #1826 from abarth/void_callback
Use VoidCallback for onPressed and friends
2015-10-27 10:41:22 -07:00
Adam Barth
e448acb008 Use VoidCallback for onPressed and friends
Previous these callbacks were leaking the implementation detail that they were
triggered by taps. In a later patch, we're going to add a parameter to
GestureTapCallback that these callbacks won't have.

Related to #1807
2015-10-27 10:21:10 -07:00
Adam Barth
1099c7bcd4 Make TapTracker and TapGesture private classes
We don't want to expose these from the gesture package. This patch moves
DoubleTapGestureRecognizer into tap.dart so we can make TapTracker and
TapGesture private to that file.
2015-10-27 10:08:48 -07:00
Ian Hickson
5f2c17b1ff Merge pull request #1819 from Hixie/new-enabled-approach
Use the presence of handler to determine 'enabled'
2015-10-27 09:30:34 -07:00
Adam Barth
b5639a1959 Merge pull request #1814 from abarth/fix_right_align
Right-aligned text paints offscreen sometimes
2015-10-26 19:41:24 -07:00
Ian Hickson
fa75d48ca2 Merge pull request #1813 from Hixie/inkwell-highlight
Make ink wells animate their highlight.
2015-10-26 19:35:27 -07:00
Hixie
6e31784bf4 Use the presence of handler to determine 'enabled'
Instread of an explicit 'enabled' bool, this uses the presence of the
event handler to determine if a widget is enabled or not. This means
that if you've not passed a handler, your widget will be disabled, which
makes sense, since it wouldn't work anyway.

Adds this feature to checkbox, and ports raised button, flat button, and
radio buttons to this new model.

Adds a checkbox to card_collection that can be disabled.

Hide a (basically bogus) hint from the (soon to be disabled) strong hint
mode in the analyzer that this reveals.
2015-10-26 17:35:41 -07:00
Hixie
c0c7f9d412 Make ink wells animate their highlight. 2015-10-26 17:24:14 -07:00
Chinmay Garde
ee995e31a6 Merge pull request #1815 from chinmaygarde/master
On iOS, avoid the unnecessary dependency on sky_snapshot (which generates a script snapshot)
2015-10-26 17:02:09 -07:00
Chinmay Garde
47b52a4d1c On iOS, avoid the unnecessary dependency on sky_snapshot (which generates a script snapshot) 2015-10-26 17:01:48 -07:00
Viktor Lidholt
260f006eff Merge pull request #1818 from vlidholt/master
Fixes warning in sprites
2015-10-26 16:42:47 -07:00
Viktor Lidholt
e72d06b759 Fixes inferred type warning 2015-10-26 16:38:14 -07:00
Viktor Lidholt
8070d343b9 Fixes inferred type warning 2015-10-26 16:32:57 -07:00
Viktor Lidholt
f73b2a188f Fixes warning in sprites 2015-10-26 16:26:48 -07:00
Viktor Lidholt
ba8b8bc4ff Merge pull request #1800 from vlidholt/master
sprite nodes now caches inverse transforms
2015-10-26 15:53:38 -07:00
Viktor Lidholt
cc012ffe25 Adds support for collision categories and masks in sprite physics 2015-10-26 15:49:50 -07:00
Adam Barth
96087ea239 Right-aligned text paints offscreen sometimes
We were assuming that the text extended from 0.0 to its max content width.
That's not correct for right-aligned text. Instead, we need to layout the text
again at the width we want it to occupy.
2015-10-26 15:49:47 -07:00
Chinmay Garde
eb21c4ff20 Merge pull request #1812 from chinmaygarde/master
Add a clang_i386 toolchain definition to build/toolchain/mac
2015-10-26 15:47:58 -07:00
Chinmay Garde
ab05c8b0d0 Add a clang_i386 toolchain definition to build/toolchain/mac 2015-10-26 15:41:56 -07:00
krisgiesing
e3f8f0959f Merge pull request #1809 from krisgiesing/event-fix
Handle mouseover events in pointer event conversion
2015-10-26 15:35:54 -07:00
Ian Hickson
cd6f852cc3 Merge pull request #1805 from Hixie/Radio-Enabled
Radio button 'disabled' state.
2015-10-26 15:29:47 -07:00
Kris Giesing
b681670ed9 Handle mouseover events in pointer event conversion
Fixes #1806
2015-10-26 15:29:43 -07:00
Hixie
800ff311e7 Radio button 'disabled' state.
Also:
 - give card_collection an option to turn on or off the edit widgets
 - give card_collection an option to control text alignment (when not editing)
 - give card_collection a "dump" option to aid debugging
 - make the gesture detector report which gestures it is listening to
2015-10-26 14:49:58 -07:00
Viktor Lidholt
791308a710 sprite nodes now caches inverse transforms 2015-10-26 13:53:01 -07:00
krisgiesing
ff77fbed1e Merge pull request #1799 from krisgiesing/tap-fix
Restore previous tap behaviors: no timeout, one pointer
2015-10-26 13:49:23 -07:00
Adam Barth
1fa881bed1 Merge pull request #1798 from abarth/inherit_text_style
Be explicit about whether text styles inherit
2015-10-26 13:42:01 -07:00
Kris Giesing
e6e77318d0 Restore previous tap behaviors: no timeout, one pointer
Don't use a timeout to cancel tap tracking. Track only one primary pointer
and ignore non-primary pointers. Update tests to reflect desired behaviors.

Fixes #1779, #1780, #1781.
2015-10-26 13:41:29 -07:00
Viktor Lidholt
de8f599a42 Merge pull request #1797 from vlidholt/master
Adds motors to revolute joints and prismatic joints
2015-10-26 13:28:32 -07:00
Adam Barth
ba96347f76 Be explicit about whether text styles inherit
Now TextStyle has a boolean "inherit" value, which controls whether null values
should use should inherit from the current default text style or whether they
should use their initial values.
2015-10-26 13:25:20 -07:00