DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
31,661 Commits 882 Branches 1,069 Tags
Commit Graph

24059 Commits

Author SHA1 Message Date
Zachary Anderson
594738f2d5 In run_tests.py, separate Dart package unit tests from other tests (flutter/engine#46232) 
This PR creates a new test type for `run_tests.py` called `dart-host`.
The tests remaining under the `dart` type are tests that run in
`flutter_tester`. The `dart-host` tests run in the Dart CLI. This allows
`run_tests.py` to be simplified a bit, and while doing this I spotted a
couple of mistakes that were causing some tests not to run.

This PR also makes a couple of small style fixes to the build config
json files, converting tabs to spaces, and moving some "script" fields
before the "parameters" fields.
 2023-09-24 18:22:27 -07:00
skia-flutter-autoroll
09bddccdbe Roll Fuchsia Linux SDK from M-fNM9YP2Lpc8Y_Dj... to SqWjDvrDsMfiisUoA... (flutter/engine#46239) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-24 06:36:25 +00:00
skia-flutter-autoroll
41be46797a Roll Fuchsia Linux SDK from PCEkaltiQ-iEKlmEj... to M-fNM9YP2Lpc8Y_Dj... (flutter/engine#46231) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-23 17:47:24 +00:00
Chris Yang
c889e14d4c [ios] Fix default assets url (flutter/engine#46214) 
When reverting the default asset url code, the old "flutter_assets" path was also copied in https://github.com/flutter/engine/pull/46073
This PR uses the correct URL. Although I'm unsure why the video player test passed before my change for the asset urls. 

I'm going to take another look at it but meanwhile this PR can unblock the roll once rolled into the framework.

fixes of https://github.com/flutter/flutter/issues/135323

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-23 11:43:21 +00:00
Casey Hillers
27e8b0633d Revert "[Impeller] fail if software backend is chosen and Impeller is enabled on iOS" (flutter/engine#46217) 
Reverts flutter/engine#46124

See b/301660190. This is breaking a few Google iOS tests due to test bed configurations. We'll need more time to investigate fixing those tests before relanding.
 2023-09-23 02:15:50 +00:00
skia-flutter-autoroll
ed919c7f54 Roll Fuchsia Linux SDK from QcxgV9KlY7j3o3b4j... to PCEkaltiQ-iEKlmEj... (flutter/engine#46221) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-23 02:15:48 +00:00
Jonah Williams
f570ec1222 [Impeller] dont treat non-rects as rects. (flutter/engine#46218) 
We were going down this branch for all closed paths, but we should only be taking it for closed paths that are also rectangles.
 2023-09-22 23:04:08 +00:00
skia-flutter-autoroll
00d6b50d43 Roll Skia from e9358f92110c to 15ccdeaba011 (1 revision) (flutter/engine#46216) 
https://skia.googlesource.com/skia.git/+log/e9358f92110c..15ccdeaba011

2023-09-22 kjlubick@google.com Reland "Revert "Make SKP deserialize null instead of PNG images by default.""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 22:45:28 +00:00
skia-flutter-autoroll
2c3ea5633c Roll Dart SDK from 4ddff752a6b0 to 692273b46610 (1 revision) (flutter/engine#46212) 
https://dart.googlesource.com/sdk.git/+log/4ddff752a6b0..692273b46610

2023-09-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-191.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 21:32:31 +00:00
skia-flutter-autoroll
aa0a1c3dd8 Roll Skia from 78fced84372d to e9358f92110c (4 revisions) (flutter/engine#46211) 
https://skia.googlesource.com/skia.git/+log/78fced84372d..e9358f92110c

2023-09-22 brianosman@google.com [graphite] Fix lifetime of texture infos when updating descriptor set
2023-09-22 brianosman@google.com [graphite] Make Dawn viewer's swap chain copy/texture-able
2023-09-22 kjlubick@google.com Fix G3
2023-09-22 johnstiles@google.com Allow child effects in SkSL mesh-fragment programs during compile.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 21:27:41 +00:00
Brandon DeRosier
57f9d82f0d [Impeller] Incorporate backdrop filters in subpass coverage. (flutter/engine#46130) 
Resolves https://github.com/flutter/flutter/issues/134775.

Before:

![image](https://github.com/flutter/engine/assets/919017/0e709d09-38bc-458b-850f-ca13f82c269d)

After:

![image](https://github.com/flutter/engine/assets/919017/a30fff08-e6bb-421a-9ed2-39f2cfa53d72)
 2023-09-22 20:56:03 +00:00
skia-flutter-autoroll
05cab9ad58 Roll Skia from 8a1e6e5844d7 to 78fced84372d (4 revisions) (flutter/engine#46207) 
https://skia.googlesource.com/skia.git/+log/8a1e6e5844d7..78fced84372d

2023-09-22 kjlubick@google.com Reland "Enforce IWYU on more src/core files"
2023-09-22 michaelludwig@google.com [skif] Add SkBlender handling to FilterResult::draw
2023-09-22 kjlubick@google.com Extract SkImageGenerator::MakeFromEncoded into own file
2023-09-22 johnstiles@google.com Create error tests to verify existing mesh-program behavior.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 19:36:20 +00:00
skia-flutter-autoroll
c17bc7b25d Roll Skia from fe73688dc40f to 8a1e6e5844d7 (1 revision) (flutter/engine#46205) 
https://skia.googlesource.com/skia.git/+log/fe73688dc40f..8a1e6e5844d7

2023-09-22 armansito@google.com [graphite] Support atlas textures without storage usage

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 18:17:56 +00:00
Jonah Williams
7cd7603dfa [Impeller] Reland: construct text frames on UI thread. (flutter/engine#46115) 
Due to https://github.com/flutter/flutter/issues/127500 , we can get in a state where enable-impeller is true but we're using Skia. We need to either fall back completely to Skia, make this configuration fatal, or remote the check

----------------

Conversion of SkTextBlobs to impeller::TextFrame objects is one of the most expensive operations in display list dispatching. While the rest of the engine and framework makes a reasonable attempt to cache the SkTextBlobs generated during paragraph construction, the design of the dl dispatcher means that these the Impeller backend will always reconstruct all text frames on each frame - even if the display list/picture that contained those text frames was unchanged.

Removing this overhead is one of the goals of https://github.com/flutter/engine/pull/45386 , however this patch is also fairly risky and will be difficult to land. As a more incremental solution, we can instead construct the impeller::TextFrame objects when performing paragraph painting and record them in the display list. This both moves the text frame construction to the UI thread and allows the framework/engine to cache unchanged text frames.

This also does not conflict with the dl_aiks_canvas patch directly, and is fine to land before or after it does. (though I'd argue we should land this first).

To compare the current performance levels, I ran the complex_layout_scroll perf test, since this is fairly text filled. On a Pixel 6 pro. Across several runs this is a fairly consistent ~1ms raster time improvement.

Fixes https://github.com/flutter/flutter/issues/133204
 2023-09-22 17:46:32 +00:00
skia-flutter-autoroll
39d8a0b996 Roll Skia from 8beae2053939 to fe73688dc40f (1 revision) (flutter/engine#46202) 
https://skia.googlesource.com/skia.git/+log/8beae2053939..fe73688dc40f

2023-09-22 jvanverth@google.com Change some more signed uniqueID generators to unsigned.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 17:02:33 +00:00
Matan Lurey
20b6399a38 Enable checking headers with Clang Tidy. (flutter/engine#46009) 
Closes https://github.com/flutter/flutter/issues/134969.

Turns out this was literally 1 line. Tested locally:

```shell
dart tools/clang_tidy/bin/main.dart \
  --target-variant host_debug_unopt_arm64 \
  --lint-all \
  --checks="-*,llvm-header-guard"
```

<details>

<summary>Local Test Results</summary>

Here is a tiny snippet showing this is indeed doing something:

```txt
[0:02] Jobs:   0% done,   0/1033 completed,  7 in progress, 1019 pending,   7 failed.    
❌ Failures for clang-tidy on /Users/matanl/Developer/engine/src/flutter/display_list/dl_blend_mode.cc:
../../flutter/display_list/dl_blend_mode.h:5:9: error: header guard does not follow preferred style [llvm-header-guard,-warnings-as-errors]
    5 | #ifndef FLUTTER_DISPLAY_LIST_DL_BLEND_MODE_H_
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         USERS_MATANL_DEVELOPER_ENGINE_SRC_OUT_HOST_DEBUG_UNOPT_ARM64_______FLUTTER_DISPLAY_LIST_DL_BLEND_MODE_H
    6 | #define FLUTTER_DISPLAY_LIST_DL_BLEND_MODE_H_
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         USERS_MATANL_DEVELOPER_ENGINE_SRC_OUT_HOST_DEBUG_UNOPT_ARM64_______FLUTTER_DISPLAY_LIST_DL_BLEND_MODE_H
^C
```

</details>

This will likely show failures on CI, so I'm following [our published
directions](https://github.com/flutter/flutter/wiki/Engine-Clang-Tidy-Linter#clang-tidy-fix-on-ci)
to get CI to tell me what needs to get fixed, and won't submit until
there are no warnings at HEAD. As such, not seeking LGTM yet (draft).

---------

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
 2023-09-22 09:30:15 -07:00
skia-flutter-autoroll
4894469ba8 Roll Skia from f346a813ffd4 to 8beae2053939 (5 revisions) (flutter/engine#46200) 
https://skia.googlesource.com/skia.git/+log/f346a813ffd4..8beae2053939

2023-09-22 kjlubick@google.com Add some iOS compile jobs to the CQ
2023-09-22 kjlubick@google.com Fix another use of flushAndSubmit
2023-09-22 johnstiles@google.com Add support for mesh programs to skslc.
2023-09-22 kjlubick@google.com Fix GM tests built for WASM
2023-09-22 kjlubick@google.com Remove legacy GrDirectContext flush methods

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 16:00:38 +00:00
skia-flutter-autoroll
03b4119690 Roll Skia from a911bc1352f2 to f346a813ffd4 (1 revision) (flutter/engine#46195) 
https://skia.googlesource.com/skia.git/+log/a911bc1352f2..f346a813ffd4

2023-09-22 brianosman@google.com Add SkColorFilter::makeWithWorkingColorSpace

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 14:05:06 +00:00
skia-flutter-autoroll
03eddcc790 Roll Skia from d0f04adbec5c to a911bc1352f2 (1 revision) (flutter/engine#46194) 
https://skia.googlesource.com/skia.git/+log/d0f04adbec5c..a911bc1352f2

2023-09-22 armansito@google.com [graphite] Fixes to some Caps methods that deal with TextureInfo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 12:27:17 +00:00
skia-flutter-autoroll
ca7fbf5166 Roll Skia from 8d9e2cd32ec7 to 8752f3ac6e99 (1 revision) (flutter/engine#46186) 
https://skia.googlesource.com/skia.git/+log/8d9e2cd32ec7..8752f3ac6e99

2023-09-22 armansito@google.com [graphite] Ensure CoverageMaskShapes are created with a valid proxy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 08:29:46 +00:00
skia-flutter-autoroll
5422cccc4f Roll Skia from 3ae3bb0d40df to a3480a62e438 (1 revision) (flutter/engine#46183) 
https://skia.googlesource.com/skia.git/+log/3ae3bb0d40df..a3480a62e438

2023-09-22 jvanverth@google.com [Graphite] Fix typo in PathAtlasFlags

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 06:59:27 +00:00
skia-flutter-autoroll
eeb6f85a38 Roll Skia from 97ec4dbabd05 to 3ae3bb0d40df (1 revision) (flutter/engine#46182) 
https://skia.googlesource.com/skia.git/+log/97ec4dbabd05..3ae3bb0d40df

2023-09-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from af63cb4763f0 to 8ddc74eefa73 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 06:11:23 +00:00
Bruno Leroux
87139861e6 [iOS] Disable spelling corrections when auto correction is disabled (flutter/engine#46144) 
## Description

This iOS PR disables spellchecking when auto correction is disabled.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/134881.

## Tests

Adds 1 test.
 2023-09-22 06:00:58 +00:00
skia-flutter-autoroll
68c0f17e18 Roll Dart SDK from eaeca487c944 to 5d33f4c85b82 (1 revision) (flutter/engine#46176) 
https://dart.googlesource.com/sdk.git/+log/eaeca487c944..5d33f4c85b82

2023-09-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-188.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 01:36:24 +00:00
Dan Field
3ade44e1c7 [Impeller] fail if software backend is chosen and Impeller is enabled on iOS (flutter/engine#46124) 
Fixes https://github.com/flutter/flutter/issues/127408

This is also related to https://github.com/flutter/engine/pull/44346, which made it fatal to explicitly request both impeller and the software backend.

Before landing this, we need to update some google internal tests that end up in this state to explicitly request Skia (or to get into a mode where they can actually use metal).
 2023-09-22 00:31:00 +00:00
skia-flutter-autoroll
9dec78361a Roll Skia from 611f08987be3 to 5b2dae1a9b54 (2 revisions) (flutter/engine#46168) 
https://skia.googlesource.com/skia.git/+log/611f08987be3..5b2dae1a9b54

2023-09-21 jvanverth@google.com [graphite] Hook up software path renderer.
2023-09-21 jreck@google.com Add missing const

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-21 23:26:06 +00:00
Matan Lurey
6aa20016ac Revert #46131, don't store vkImage, reset vkComandPool synchronously (flutter/engine#46166) 
Closes https://github.com/flutter/flutter/issues/135086.

Reverts https://github.com/flutter/engine/pull/46131.

This PR bundles together 3 changes that removes all validation errors on the `macrobenchmark` apps I could manually find:

1. Reverts https://github.com/flutter/engine/pull/46131, which did not fix the original issue.
2. Added `kResetOnBackgroundThread = false`, which drops performance benefits, but doesn't cause threading issues.
3. Stop tracking `image` for Swapchain presentation (was hitting Vulkan assertion errors about acquired images).

/cc @gaaclarke I'd love to talk about how we could run the macrobenchmarks app on CI, with validation errors, after landing.
 2023-09-21 23:10:37 +00:00
skia-flutter-autoroll
1515f2e53f Roll Skia from a0928a46b9c8 to 611f08987be3 (2 revisions) (flutter/engine#46165) 
https://skia.googlesource.com/skia.git/+log/a0928a46b9c8..611f08987be3

2023-09-21 brianosman@google.com Add working color space shader
2023-09-21 avi@chromium.org Remove deprecated API use

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-21 22:39:04 +00:00
skia-flutter-autoroll
688a066626 Roll Skia from 0cf83a86c56d to a0928a46b9c8 (19 revisions) (flutter/engine#46164) 
https://skia.googlesource.com/skia.git/+log/0cf83a86c56d..a0928a46b9c8

2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 79912a37e72c to b7c710e0c890 (5 revisions)
2023-09-21 jlavrova@google.com Fixing Flutter roll build
2023-09-21 michaelludwig@google.com Remove extra semicolon after macro
2023-09-21 johnstiles@google.com Remove packDouble2x32 intrinsics from SkSL.
2023-09-21 johnstiles@google.com Add SkRuntimeEffectPriv::VarAsChild.
2023-09-21 robertphillips@google.com [graphite] Implement Image and Blend Shaders using the Blend helper
2023-09-21 johnstiles@google.com Split apart MeshSpec tests into separate DEF_TESTs.
2023-09-21 brianosman@google.com [graphite] Return transparent black when evaluating null child shader
2023-09-21 armansito@google.com [graphite][compute] Coverage mask format based on storage binding support
2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from e305459968f2 to 8fcd4a50ab47 (9 revisions)
2023-09-21 michaelludwig@google.com [skif] Combine isCropped() and modifiesPixelsBeyondImage()
2023-09-21 bungeman@google.com [skshaper] Use locale for line breaking
2023-09-21 jlavrova@google.com Set of utilities for Unicode comparison: Skia changes
2023-09-21 robertphillips@google.com [graphite] Implement DstReads w/ Blend helper
2023-09-21 johnstiles@google.com Disable DeadReturnES3 test on Radeon due to crashing.
2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from b4674d1b2f50 to bbf6a30f67f4
2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from f4090760c770 to 3605928905e4
2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from c6e5b668b1a4 to 84356d9e8452
2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from b5dc6c526875 to 72a86e8cc35e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-21 21:54:02 +00:00
John McCutchan
72c674cc1c Re-enable HardwareBuffer backed Platform Views on Android >= 29 (flutter/engine#46071) 2023-09-21 14:40:31 -07:00
Jonah Williams
eaa5fe4b74 [Impeller] Use final cmd buffer to present drawable. (flutter/engine#46023) 
If we're not running with a transaction then we don't need to block on waitUntilScheduled on any platform. I think this should always work, as the problems we had before were due to always using drawable present. But this helper method schedules the drawable presentation after the cmd buffer is scheduled - which is what we're doing with waitUntilScheduled anyway - just non blocking from our perspective.

Fixes https://github.com/flutter/flutter/issues/131520
 2023-09-21 21:16:18 +00:00
Matan Lurey
3cea82e53b More Clang Tidy --fix[es] to header files (flutter/engine#46151) 
More work towards https://github.com/flutter/flutter/issues/134969.

I decided not to touch the `LOG_X` variables since they are just used in macro expansion.
 2023-09-21 21:16:16 +00:00
Tong Mu
38b8ce1c29 Reland: Enforce the rule of calling FlutterView.Render (#45300) (flutter/engine#45555) 
This PR relands #45300 which was reverted in https://github.com/flutter/engine/pull/45525 due to hanging on a windows startup test. The culprit test still calls `FlutterView.render` in the illegal way, which is ignored, causing no frame being ever produced. This has been fixed in https://github.com/flutter/flutter/pull/134245. I've also searched through the framework repo for `render(` to ensure there are no other cases.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-21 21:11:03 +00:00
Yegor
df462f2b6e Revert "[web] fix clicks on merged semantic nodes (#43620)" (flutter/engine#46067) 
This reverts commit 6dee3dd14ebb7e0834d4e533847c05fc3e5a8145.

The commit caused https://github.com/flutter/flutter/issues/134842. I'm going to try again, this time accounting for nested clickables/tappables.
 2023-09-21 19:57:55 +00:00
Matan Lurey
3d3a76280d Move git_repo_tools and process_fakes outside of clang_tidy. (flutter/engine#46017) 
Closes https://github.com/flutter/flutter/issues/134988.
 2023-09-21 12:16:42 -07:00
godofredoc
6fe6f6b086 Remove linux fuchsia from recipes cq. (flutter/engine#46153) 
With some recent changes led builds can only run if they use -real-build. The migration of fuchsia builds to use -real-build as involved as migrating it to engine v2 and we are implementing the second one.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-21 18:56:06 +00:00
skia-flutter-autoroll
e86f8269e5 Roll Dart SDK from d5d05146868a to eaeca487c944 (2 revisions) (flutter/engine#46138) 
https://dart.googlesource.com/sdk.git/+log/d5d05146868a..eaeca487c944

2023-09-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-187.0.dev
2023-09-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-186.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-21 09:31:22 +00:00
skia-flutter-autoroll
9734b3ddba Roll Skia from 81b9c7fd19b2 to c20aeee90da9 (3 revisions) (flutter/engine#46134) 
https://skia.googlesource.com/skia.git/+log/81b9c7fd19b2..c20aeee90da9

2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 918412e0912f to af63cb4763f0 (11 revisions)
2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 881dc3bb55fd to 2eae44a62806 (11 revisions)
2023-09-21 johnstiles@google.com Add new flags to sksl-minify usage string.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-21 05:36:12 +00:00
Jonah Williams
98d9a51a31 [Impeller] temp work around for cmd pool validation issues. (flutter/engine#46131) 
I'm not able to reproduce most validation errors in the macrobenchmark app with this change. THe real fix seems to be to track this last cmd buffer but I'm struggling to find a way to do this.
 2023-09-21 03:48:47 +00:00
Matan Lurey
172411fc8e Tidy up DlPaint and friends. (flutter/engine#46120) 
Closes https://github.com/flutter/flutter/issues/135058.

Work towards https://github.com/flutter/flutter/issues/134969.

All fixes are generated by `clang-tidy --fix`, and manual search/replace
if that wasn't sufficient.
 2023-09-20 18:41:27 -07:00
gaaclarke
6d15ab00ed [Impeller] removed global mutable variable for tessellation allocation function pointers (flutter/engine#46127) 
issue: https://github.com/flutter/flutter/issues/125749

This removes a global mutable variable, instead giving each tesellator its own struct.  I suspect the root cause of the linked  issue is memory corruption but this is good cleanup anyways.  If for some reason libTess2 is mutating that global variable at cleanup, that could be the source of this problem and this would fix the issue.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-21 00:22:05 +00:00
Jonah Williams
9b906fb887 [Impeller] Remove removal of save layer from clip. (flutter/engine#46113) 
Fixes https://github.com/flutter/flutter/issues/134705

The save layer is observable so it isn't safe to optimize out.
 2023-09-20 22:55:51 +00:00
Jason Simmons
32d185de0f [Impeller] Apply the entity transformation when rendering FramebufferBlendContents (flutter/engine#46106) 
Fixes https://github.com/flutter/flutter/issues/134930
 2023-09-20 22:38:04 +00:00
Matan Lurey
2681bee9ca Clang tidy-ify DlColor and friends. (flutter/engine#46122) 
Closes https://github.com/flutter/flutter/issues/135057.

This is a fair bit more involved than previous changes, just due to the sheer number of implicit conversions.

Highlights:

- Made `public uint32_t argb` `private uint32_t argb_`, and added `argb()` instead.
- Added `ToSk(DlColor)` instead of using implicit conversions.

There were a bunch of places where I had to make a judgement call (particularly in tests) to keep the code a bit "messy", i.e. `DlColor(SK_RED)`, just to make the diff as small as possible and to prevent silly copy and paste bugs. I'd be open to filing a follow-up issue to reduce unnecessary wrapping.
 2023-09-20 22:08:07 +00:00
godofredoc
5b6044864e Apply the right tag for linux fuchsia cipd packages. (flutter/engine#46123) 
The cipd packages were all being uploaded and tagged with git:HEAD.

Bug: https://github.com/flutter/flutter/issues/126461

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-20 22:08:05 +00:00
skia-flutter-autoroll
a75aea7d29 Roll Skia from d923bab3d5fa to b78c91996051 (4 revisions) (flutter/engine#46119) 
https://skia.googlesource.com/skia.git/+log/d923bab3d5fa..b78c91996051

2023-09-20 kjlubick@google.com Revert "Revert "Make SKP deserialize null instead of PNG images by default.""
2023-09-20 johnstiles@google.com Remove PackUnorm2x16 from SkSL tests.
2023-09-20 kjlubick@google.com Tidy up public.bzl rules for iOS
2023-09-20 johnstiles@google.com Fix test disables for PowerVR Rogue GE8300.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 21:00:04 +00:00
Matan Lurey
6178baa159 Make dl_color_(filter|source) tidy. (flutter/engine#46111) 
Closes https://github.com/flutter/flutter/issues/135060.
Closes https://github.com/flutter/flutter/issues/135061.

Bundled these two together as they are similar. Pretty boring `instance`
-> `kInstance`, and `explicit`/`std::move`.
 2023-09-20 13:24:59 -07:00
Matan Lurey
59aa61b3f3 Make dl_(image|mask|path)_(filter|effect).h tidy! (flutter/engine#46110) 
Closes https://github.com/flutter/flutter/issues/135064.
Closes https://github.com/flutter/flutter/issues/135063.
Closes https://github.com/flutter/flutter/issues/135062.

I bundled a few of these together because they didn't have side-effects
across the repo (self-contained).

**NOTE**: All changes were auto-generated by `clang-tidy --fix`.
 2023-09-20 13:24:26 -07:00
Matan Lurey
476b46954c Migrate from LOG_X to kLogX. (flutter/engine#46107) 
These should be entirely non-breaking, i.e. 1:1 and same backing `int`
value.

(See https://github.com/flutter/engine/pull/46052)
 2023-09-20 13:24:01 -07:00
skia-flutter-autoroll
002e1a2047 Roll Skia from b3c1f49821d8 to d923bab3d5fa (2 revisions) (flutter/engine#46118) 
https://skia.googlesource.com/skia.git/+log/b3c1f49821d8..d923bab3d5fa

2023-09-20 johnstiles@google.com Add pack/unpack intrinsics to WGSL code generator.
2023-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b8fa58ef74a9 to 2aba50a6944f (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 20:12:03 +00:00