DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make dl_(image|mask|path)_(filter|effect).h tidy! (flutter/engine#46110)

Browse Source 
Closes https://github.com/flutter/flutter/issues/135064.
Closes https://github.com/flutter/flutter/issues/135063.
Closes https://github.com/flutter/flutter/issues/135062.

I bundled a few of these together because they didn't have side-effects
across the repo (self-contained).

**NOTE**: All changes were auto-generated by `clang-tidy --fix`.
This commit is contained in:
Matan Lurey 2023-09-20 13:24:26 -07:00 committed by GitHub
parent 476b46954c
commit 59aa61b3f3
3 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
engine/src/flutter/display_list/effects/dl_image_filter.h
View File

@ -5,6 +5,8 @@
#ifndef FLUTTER_DISPLAY_LIST_EFFECTS_DL_IMAGE_FILTER_H_
#define FLUTTER_DISPLAY_LIST_EFFECTS_DL_IMAGE_FILTER_H_
#include <utility>
#include "flutter/display_list/dl_attributes.h"
#include "flutter/display_list/dl_sampling_options.h"
#include "flutter/display_list/dl_tile_mode.h"
@ -223,7 +225,7 @@ class DlBlurImageFilter final : public DlImageFilter {
: DlBlurImageFilter(filter->sigma_x_,
filter->sigma_y_,
filter->tile_mode_) {}
explicit DlBlurImageFilter(const DlBlurImageFilter& filter)
DlBlurImageFilter(const DlBlurImageFilter& filter)
: DlBlurImageFilter(&filter) {}
static std::shared_ptr<DlImageFilter> Make(SkScalar sigma_x,
@ -295,7 +297,7 @@ class DlDilateImageFilter final : public DlImageFilter {
: radius_x_(radius_x), radius_y_(radius_y) {}
explicit DlDilateImageFilter(const DlDilateImageFilter* filter)
: DlDilateImageFilter(filter->radius_x_, filter->radius_y_) {}
explicit DlDilateImageFilter(const DlDilateImageFilter& filter)
DlDilateImageFilter(const DlDilateImageFilter& filter)
: DlDilateImageFilter(&filter) {}
static std::shared_ptr<DlImageFilter> Make(SkScalar radius_x,
@ -359,7 +361,7 @@ class DlErodeImageFilter final : public DlImageFilter {
: radius_x_(radius_x), radius_y_(radius_y) {}
explicit DlErodeImageFilter(const DlErodeImageFilter* filter)
: DlErodeImageFilter(filter->radius_x_, filter->radius_y_) {}
explicit DlErodeImageFilter(const DlErodeImageFilter& filter)
DlErodeImageFilter(const DlErodeImageFilter& filter)
: DlErodeImageFilter(&filter) {}
static std::shared_ptr<DlImageFilter> Make(SkScalar radius_x,
@ -423,7 +425,7 @@ class DlMatrixImageFilter final : public DlImageFilter {
: matrix_(matrix), sampling_(sampling) {}
explicit DlMatrixImageFilter(const DlMatrixImageFilter* filter)
: DlMatrixImageFilter(filter->matrix_, filter->sampling_) {}
explicit DlMatrixImageFilter(const DlMatrixImageFilter& filter)
DlMatrixImageFilter(const DlMatrixImageFilter& filter)
: DlMatrixImageFilter(&filter) {}
static std::shared_ptr<DlImageFilter> Make(const SkMatrix& matrix,
@ -510,7 +512,7 @@ class DlComposeImageFilter final : public DlImageFilter {
: DlComposeImageFilter(&outer, &inner) {}
explicit DlComposeImageFilter(const DlComposeImageFilter* filter)
: DlComposeImageFilter(filter->outer_, filter->inner_) {}
explicit DlComposeImageFilter(const DlComposeImageFilter& filter)
DlComposeImageFilter(const DlComposeImageFilter& filter)
: DlComposeImageFilter(&filter) {}
static std::shared_ptr<const DlImageFilter> Make(
@ -586,7 +588,7 @@ class DlColorFilterImageFilter final : public DlImageFilter {
: color_filter_(filter.shared()) {}
explicit DlColorFilterImageFilter(const DlColorFilterImageFilter* filter)
: DlColorFilterImageFilter(filter->color_filter_) {}
explicit DlColorFilterImageFilter(const DlColorFilterImageFilter& filter)
DlColorFilterImageFilter(const DlColorFilterImageFilter& filter)
: DlColorFilterImageFilter(&filter) {}
static std::shared_ptr<DlImageFilter> Make(
@ -664,7 +666,7 @@ class DlLocalMatrixImageFilter final : public DlImageFilter {
public:
explicit DlLocalMatrixImageFilter(const SkMatrix& matrix,
std::shared_ptr<DlImageFilter> filter)
: matrix_(matrix), image_filter_(filter) {}
: matrix_(matrix), image_filter_(std::move(filter)) {}
explicit DlLocalMatrixImageFilter(const DlLocalMatrixImageFilter* filter)
: DlLocalMatrixImageFilter(filter->matrix_, filter->image_filter_) {}
DlLocalMatrixImageFilter(const DlLocalMatrixImageFilter& filter)

2
engine/src/flutter/display_list/effects/dl_mask_filter.h
View File

@ -46,7 +46,7 @@ class DlBlurMaskFilter final : public DlMaskFilter {
: style_(style), sigma_(sigma), respect_ctm_(respect_ctm) {}
DlBlurMaskFilter(const DlBlurMaskFilter& filter)
: DlBlurMaskFilter(filter.style_, filter.sigma_, filter.respect_ctm_) {}
DlBlurMaskFilter(const DlBlurMaskFilter* filter)
explicit DlBlurMaskFilter(const DlBlurMaskFilter* filter)
: DlBlurMaskFilter(filter->style_, filter->sigma_, filter->respect_ctm_) {
}

2
engine/src/flutter/display_list/effects/dl_path_effect.h
View File

@ -104,7 +104,7 @@ class DlDashPathEffect final : public DlPathEffect {
}
}
DlDashPathEffect(const DlDashPathEffect* dash_effect)
explicit DlDashPathEffect(const DlDashPathEffect* dash_effect)
: DlDashPathEffect(dash_effect->intervals(),
dash_effect->count_,
dash_effect->phase_) {}