DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
29,804 Commits 882 Branches 1,069 Tags
Commit Graph

29804 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
d7142dbbb2 Roll Skia from 4abc43e2ffcc to 85a3fda32850 (1 revision) (flutter/engine#43393) 
https://skia.googlesource.com/skia.git/+log/4abc43e2ffcc..85a3fda32850

2023-07-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e21365bc9170 to bfb786a7daec (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-04 04:38:36 +00:00
Chinmay Garde
e7964a816f [Impeller] Document impeller::Context. (flutter/engine#43389) 2023-07-04 00:30:23 +00:00
skia-flutter-autoroll
02453b5a59 Roll Dart SDK from a4c5ed075a2b to 604ccea2f5b9 (1 revision) (flutter/engine#43390) 
https://dart.googlesource.com/sdk.git/+log/a4c5ed075a2b..604ccea2f5b9

2023-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-270.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-03 23:50:21 +00:00
skia-flutter-autoroll
75718cf3e2 Roll Dart SDK from c092e09b7e64 to a4c5ed075a2b (1 revision) (flutter/engine#43387) 
https://dart.googlesource.com/sdk.git/+log/c092e09b7e64..a4c5ed075a2b

2023-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-269.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-03 19:30:11 +00:00
skia-flutter-autoroll
2f6643c20c Roll Skia from 6a5ea15c942b to 4abc43e2ffcc (1 revision) (flutter/engine#43386) 
https://skia.googlesource.com/skia.git/+log/6a5ea15c942b..4abc43e2ffcc

2023-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8eda3fc5098a to e21365bc9170 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-03 15:51:21 +00:00
skia-flutter-autoroll
8d67e79b2f Roll Fuchsia Mac SDK from cytps4RRhs8-wbcVJ... to GNWxBcnfjZlyaOw34... (flutter/engine#43373) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-03 15:20:02 +00:00
skia-flutter-autoroll
b3bc31735e Roll Dart SDK from dedff8f0ebd2 to c092e09b7e64 (1 revision) (flutter/engine#43374) 
https://dart.googlesource.com/sdk.git/+log/dedff8f0ebd2..c092e09b7e64

2023-07-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-268.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-03 15:18:02 +00:00
skia-flutter-autoroll
7bb164b6e1 Roll Skia from 94ad507b8959 to 6a5ea15c942b (1 revision) (flutter/engine#43385) 
https://skia.googlesource.com/skia.git/+log/94ad507b8959..6a5ea15c942b

2023-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 20cc4a9bc250 to 25ce3dfec69b (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-03 11:01:05 +00:00
skia-flutter-autoroll
285d749ac5 Roll Skia from e16d5b988a36 to 94ad507b8959 (2 revisions) (flutter/engine#43383) 
https://skia.googlesource.com/skia.git/+log/e16d5b988a36..94ad507b8959

2023-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 414f9688245c to 73aa9bd33f2c
2023-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 4ea8b01e8983 to 414f9688245c (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-03 06:57:23 +00:00
skia-flutter-autoroll
4f3f2de929 Roll Skia from 384b84445a9f to e16d5b988a36 (1 revision) (flutter/engine#43382) 
https://skia.googlesource.com/skia.git/+log/384b84445a9f..e16d5b988a36

2023-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 15d2e87074d6 to 9c78ac0f4327 (37 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-03 05:45:13 +00:00
skia-flutter-autoroll
a42e60e7ce Roll Skia from dbf0829114ee to 384b84445a9f (2 revisions) (flutter/engine#43381) 
https://skia.googlesource.com/skia.git/+log/dbf0829114ee..384b84445a9f

2023-07-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2023-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d2fc29b352fe to 8eda3fc5098a (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-02 14:19:29 +00:00
Brandon DeRosier
a3745e962c [Impeller] Remove blend mode restrictions on clear color optimization (flutter/engine#43348) 
Now that all of the CPU blend modes work, we can allow back-to-back
fullscreen solid color draws to get blended together regardless of their
blend mode/color opacity.
 2023-06-30 21:48:45 -07:00
skia-flutter-autoroll
a0dc7abbe9 Roll Dart SDK from f00f7363f4bf to dedff8f0ebd2 (4 revisions) (flutter/engine#43371) 
https://dart.googlesource.com/sdk.git/+log/f00f7363f4bf..dedff8f0ebd2

2023-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-267.0.dev
2023-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-266.0.dev
2023-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-265.0.dev
2023-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-264.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-01 01:59:23 +00:00
skia-flutter-autoroll
8803d0b50d Roll Skia from ceaeef84b8a3 to dbf0829114ee (15 revisions) (flutter/engine#43370) 
https://skia.googlesource.com/skia.git/+log/ceaeef84b8a3..dbf0829114ee

2023-06-30 bungeman@google.com Allow use of DWriteCore
2023-06-30 kjlubick@google.com Reland "Move GPU specific ImageFilter context factories to src/gpu/"
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 18e68e17ca5c to d2fc29b352fe (8 revisions)
2023-06-30 armansito@google.com [graphite][vello] Better quality hairline strokes
2023-06-30 johnstiles@google.com Remove shared compiler from ResourceProvider.
2023-06-30 jlavrova@google.com Updating SkParagraph test to newer font version
2023-06-30 bungeman@google.com Fix DirectWrite port COLRv1 palette overrides
2023-06-30 robertphillips@google.com Add a tiled-image cache test
2023-06-30 kjlubick@google.com Run buildifier on tools/window/BUILD.bazel
2023-06-30 nicolettep@google.com Revert "[graphite] Reenable tiled image cache size heuristic"
2023-06-30 het@google.com [canvaskit] Add `Picture.cullRect` and `Picture.approximateBytesUsed`.
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 77c4b6779152 to 20cc4a9bc250 (6 revisions)
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 4ea8b01e8983 to c97b5b1d4d66
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 96ae8b91855e to 4ea8b01e8983 (3 revisions)
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 49af09d96379 to 15d2e87074d6 (18 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-01 01:49:05 +00:00
Brandon DeRosier
c90389c9cd [Impeller] Add explicit color filter types to Aiks. (flutter/engine#43342) 
Part of https://github.com/flutter/flutter/issues/127232.

Adds an explicit ColorFilter concept to Aiks which wraps the GPU and CPU
implementations. We're not using the CPU implementations yet, but I'll
be getting it wired up in a follow-up patch.
 2023-06-30 18:42:21 -07:00
skia-flutter-autoroll
847fcdd753 Roll Dart SDK from 2d98d9e27dae to f00f7363f4bf (1 revision) (flutter/engine#43354) 
https://dart.googlesource.com/sdk.git/+log/2d98d9e27dae..f00f7363f4bf

2023-06-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-263.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-01 00:42:02 +00:00
skia-flutter-autoroll
89694d62dd Roll Skia from 2d05e3ec6b67 to ceaeef84b8a3 (1 revision) (flutter/engine#43355) 
https://skia.googlesource.com/skia.git/+log/2d05e3ec6b67..ceaeef84b8a3

2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7ded50742b4c to 18e68e17ca5c (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-01 00:40:14 +00:00
Jonah Williams
cb7fd03312 [Impeller] cache MSAA texture in swapchain for devices that do not support memoryless. (flutter/engine#43349) 
For devices that don't support memoryless textures, the fullscreen MSAA texture adds a substantial amount of memory thrashing when it is allocated and deallocated. For these devices, lets cache the MSAA texture in the swapchain image.

https://github.com/flutter/flutter/issues/129737
 2023-06-30 18:34:29 +00:00
Jonah Williams
70cb44975f [Impeller] Fix validation error in position color shader. (flutter/engine#43356) 
The input was a float16 vec4, so the corresponding output must match or else we get a validation error. Not related to platform view issue.
 2023-06-30 18:34:27 +00:00
yaakovschectman
570578974c Fix inverted boolean in Windows document selection changed a11y event (flutter/engine#43281) 
Fix a typo that inverted an intended condition, and amend a unit test to
check for this. This a11y event should target the focused node, but a
fallback for when the focus returns null was inverted.

https://github.com/flutter/flutter/issues/127789

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2023-06-30 12:10:37 -04:00
Brandon DeRosier
cd52c0ce82 Revert "Reland "add non-rendering operation culling to DisplayListBuilder" (#41463)" (flutter/engine#43358) 
Reverts flutter/engine#42584. (Thanks to @jonahwilliams for bisecting)

With this change, layers are getting clipped incorrectly when rendering
platform views in Wondrous.
 2023-06-30 04:22:21 -07:00
skia-flutter-autoroll
2112b6ae43 Roll Fuchsia Linux SDK from nboAFpQUzwtrESDVo... to iwgWLB4KaXslnaGwK... (flutter/engine#43357) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-30 06:44:17 +00:00
David Iglesias
f1b51a702c [web] Add nonce configuration. (flutter/engine#42829) 
This PR adds a `nonce` JS configuration attribute so users can pass a nonce value to their flutter engine initialization code.

This `nonce` is used to mark all scripts/styles needed by Flutter web that are considered `unsafe-inline` by CSP. In this change, there are only two tags that benefit from this:

* canvaskit.js
* inline styles for text editing

Before this change, the most strict CSP that allows a Flutter Web app to run would look like:

```
script-src 'self' 'nonce-flutter-init-scripts' 'wasm-unsafe-eval' https://www.gstatic.com/flutter-canvaskit/;
font-src https://fonts.gstatic.com;
style-src 'unsafe-inline';
```

After this change, CSP could be tightened to:

```
script-src 'self' 'nonce-YOUR_NONCE_VALUE' 'wasm-unsafe-eval';
font-src https://fonts.gstatic.com;
style-src 'nonce-YOUR_NONCE_VALUE';
```

By initializing the Flutter web app with something like this:

```html
<meta http-equiv="Content-Security-Policy" content="script-src 'self' 'nonce-YOUR_NONCE_VALUE' 'wasm-unsafe-eval'; font-src https://fonts.gstatic.com; style-src 'nonce-YOUR_NONCE_VALUE';">

...

<script nonce="YOUR_NONCE_VALUE">
  _flutter.loader.loadEntrypoint({
    onEntrypointLoaded: async function(engineInitializer) {
      let appRunner = await engineInitializer.initializeEngine({
        nonce: 'YOUR_NONCE_VALUE',
      });
      appRunner.runApp();
    }
  });
</script>
```

## Issues

Fixes https://github.com/flutter/flutter/issues/126977 (does not address `flutter.js`, that's a [different story](https://github.com/flutter/flutter/issues/128061))
Helps with https://github.com/flutter/flutter/issues/80221

---

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-30 01:48:04 +00:00
Brandon DeRosier
46bf003f4a [Impeller] Unwrap optional procs in EntityPass (flutter/engine#43352) 
Whoopsies, I missed a spot... Fix a possible crash where an optional nullptr can be provided as the backdrop filter proc. Related: https://github.com/flutter/engine/pull/43345
 2023-06-30 00:51:28 +00:00
Brandon DeRosier
9e12cf7aca [Impeller] Assign missing user to TODO. (flutter/engine#43351) 
The linter is failing on this in my unrelated PR for some reason: https://github.com/flutter/engine/pull/43348

```
❌ Failures for clang-tidy on /Volumes/Work/s/w/ir/cache/builder/src/flutter/impeller/renderer/backend/metal/vertex_descriptor_mtl.mm:
/Volumes/Work/s/w/ir/cache/builder/src/flutter/impeller/renderer/backend/metal/vertex_descriptor_mtl.mm:177:3: error: missing username/bug in TODO [google-readability-todo,-warnings-as-errors]
  // TODO: its odd that we offset buffers from the max index on metal
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  // TODO(chrome-bot): its odd that we offset buffers from the max index on metal
Suppressed 1476 warnings (1475 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning treated as error
```
 2023-06-30 00:22:10 +00:00
skia-flutter-autoroll
f8ba5d6e6d Roll Skia from a1ae27969207 to 2d05e3ec6b67 (1 revision) (flutter/engine#43350) 
https://skia.googlesource.com/skia.git/+log/a1ae27969207..2d05e3ec6b67

2023-06-29 jvanverth@google.com [graphite] Add rescale support.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-29 23:12:52 +00:00
skia-flutter-autoroll
6f7042adc8 Roll Dart SDK from ecc2440be198 to 2d98d9e27dae (1 revision) (flutter/engine#43347) 
https://dart.googlesource.com/sdk.git/+log/ecc2440be198..2d98d9e27dae

2023-06-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-262.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-29 22:28:19 +00:00
Jonah Williams
eee7308d1f [Impeller] Check for lazy memory support. (flutter/engine#43339) 
Some Android devices do not support the memory type eLazilyAllocated, which we use for MSAA and stencil textures. These textures were falling back to device local in dedicated allocations, which are expensive to both allocate and free. The dedicated allocation is implied by asking for eLazilyAllocated

Instead, perform a check for support for this memory type. Never request dedicated allocations (at least not until we have a compelling use case)

This should fix https://github.com/flutter/flutter/issues/129737

https://github.com/flutter/flutter/issues/129784
 2023-06-29 22:16:57 +00:00
Brandon DeRosier
2523231c29 [Impeller] Remove all double empties (flutter/engine#43345) 
Unwrap optionals that already have an empty state that must be checked, like `std::optional<std::shared_ptr<T>>` and `std::optional<std::function<T>>`.
 2023-06-29 22:04:51 +00:00
skia-flutter-autoroll
d446d15416 Roll Skia from c83f8ba23a80 to a1ae27969207 (8 revisions) (flutter/engine#43343) 
https://skia.googlesource.com/skia.git/+log/c83f8ba23a80..a1ae27969207

2023-06-29 johnstiles@google.com Revert "Move GPU specific ImageFilter context factories to src/gpu/"
2023-06-29 sallyqi@google.com Revert "Fix the way of Alpha8 gainmap support in Skia."
2023-06-29 lovisolo@google.com [bazel] Add android_gm_test macro.
2023-06-29 kjlubick@google.com Move GPU specific ImageFilter context factories to src/gpu/
2023-06-29 johnstiles@google.com Add MD5::Digest methods to create a hex string.
2023-06-29 johnstiles@google.com Fix SkRP implementation of step() intrinsic.
2023-06-29 kjlubick@google.com Remove #ifdefs from SkAndroidCodec.cpp
2023-06-29 robertphillips@google.com [graphite] Reenable tiled image cache size heuristic

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-29 21:50:07 +00:00
Tamir Duberstein
e4d08d4e8c Remove unused constants (flutter/engine#43344) 2023-06-29 21:42:05 +00:00
skia-flutter-autoroll
5603c1beab Roll Skia from a4d0373cd414 to c83f8ba23a80 (3 revisions) (flutter/engine#43340) 
https://skia.googlesource.com/skia.git/+log/a4d0373cd414..c83f8ba23a80

2023-06-29 michaelludwig@google.com [skif] Update Compose to use FilterResult
2023-06-29 wcandillon@gmail.com Add FontMgr.matchFamilyStyle()
2023-06-29 johnstiles@google.com Disable perlinnoise_layered test on Iris Xe.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-29 20:32:05 +00:00
Mouad Debbar
647d4fca2b [web] Move web-only initialization APIs to dart:ui_web (flutter/engine#43111) 
| Old API in `dart:ui` | New API in `dart:ui_web` |
|-|-|
| ~`webOnlyInitializePlatform`~ | ~`ui_web.initializePlatform`~ |
| `webOnlyWarmupEngine` | `ui_web.bootstrapEngine` |
| `debugEmulateFlutterTesterEnvironment` | `ui_web.debugEmulateFlutterTesterEnvironment` |
| `webOnlySetPluginHandler` | `ui_web.setPluginHandler` |

Part of https://github.com/flutter/flutter/issues/126831
 2023-06-29 19:52:48 +00:00
skia-flutter-autoroll
b2ace50e6e Roll Skia from 8ada2c4b2947 to a4d0373cd414 (14 revisions) (flutter/engine#43338) 
https://skia.googlesource.com/skia.git/+log/8ada2c4b2947..a4d0373cd414

2023-06-29 lovisolo@google.com [bazel] Rename skia_android_unit_test -> android_unit_test and reorganize code.
2023-06-29 michaelludwig@google.com Add SK_API to SkColorTable declaration
2023-06-29 bungeman@google.com Fix DirectWrite port COLRv1 clang warnings
2023-06-29 armansito@google.com Roll vello from 12e764d5 to 44353989
2023-06-29 jzern@google.com update libwebp to v1.3.1
2023-06-29 johnstiles@google.com Simplify appendInstruction.
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b5fa16ad27df to 7ded50742b4c (3 revisions)
2023-06-29 johnstiles@google.com Provide a semicolon when invoking the declareFunction callback.
2023-06-29 kjlubick@google.com Remove conditional compilation of SkJpegSourceMgr.cpp
2023-06-29 nicolettep@google.com [graphite] Populate most of Vulkan pipeline layout & creation structs.
2023-06-29 kjlubick@google.com Reland "Remove SkCanvas::flush() from Skia-proper and remove other gpu-specific code"
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 4765e38cdc27 to 49af09d96379 (32 revisions)
2023-06-29 johnstiles@google.com Rename Graphite's MtlTestContext.mm to fix libtool warning.
2023-06-29 bungeman@google.com Move SkPathEnums.h to src/core

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-29 19:19:07 +00:00
skia-flutter-autoroll
ecf928ab40 Roll Dart SDK from 656201921b30 to ecc2440be198 (1 revision) (flutter/engine#43333) 
https://dart.googlesource.com/sdk.git/+log/656201921b30..ecc2440be198

2023-06-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.1.0-261.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-29 10:45:11 -07:00
skia-flutter-autoroll
e1169ee71e Roll Skia from 0c320b3d5b64 to 8ada2c4b2947 (1 revision) (flutter/engine#43332) 
https://skia.googlesource.com/skia.git/+log/0c320b3d5b64..8ada2c4b2947

2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ed391dae33e6 to 77c4b6779152 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-29 10:44:55 -07:00
skia-flutter-autoroll
88997b281e Roll Fuchsia Linux SDK from fxCNy4QivAngZXkvM... to nboAFpQUzwtrESDVo... (flutter/engine#43334) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-29 17:31:04 +00:00
Martin Kustermann
d6f96120e9 Prepare for utf8.encode() to return more precise Uint8List type (flutter/engine#43335) 
To avoid analyzer warnings when utf8.encode() will return the more
precise Uint8List type, we use const Utf8Encoder().convert() which
already returns Uint8List

See https://github.com/dart-lang/sdk/issues/52801
 2023-06-29 19:27:49 +02:00
Jason Simmons
0f55317632 [Impeller] Ensure that the auto-release pool is available when the GoldenPlaygroundTestImpl is destructed (flutter/engine#43322) 2023-06-29 09:33:26 -07:00
Emircan Uysaler
d69d614045 [fuchsia] Remove strict equality check for SkMatrix comparison for Fl… (flutter/engine#43309) 
Flatland version of
010e710512

Bug: fxb/126648
 2023-06-29 12:01:12 -04:00
Jason Simmons
eb4725c362 [Impeller] Add an autorelease pool to the GoldenTests fixture (flutter/engine#43323) 2023-06-29 15:11:47 +00:00
skia-flutter-autoroll
4dfe901363 Roll Skia from 2b30565d0173 to 0c320b3d5b64 (2 revisions) (flutter/engine#43331) 
https://skia.googlesource.com/skia.git/+log/2b30565d0173..0c320b3d5b64

2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 96ae8b91855e to 1761cfde4cbe
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ca7f5660896c to 96ae8b91855e (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-29 07:01:19 +00:00
skia-flutter-autoroll
cd528699ef Roll Skia from 21feae4f3d8b to 2b30565d0173 (1 revision) (flutter/engine#43330) 
https://skia.googlesource.com/skia.git/+log/21feae4f3d8b..2b30565d0173

2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 47b5898a4fa7 to 222e07b368b1 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-29 05:49:14 +00:00
skia-flutter-autoroll
8045b8824d Roll Skia from 26fa4b343fd3 to 21feae4f3d8b (17 revisions) (flutter/engine#43329) 
https://skia.googlesource.com/skia.git/+log/26fa4b343fd3..21feae4f3d8b

2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5e35b0b24e12 to b5fa16ad27df (6 revisions)
2023-06-28 armansito@google.com Roll vello from ef2630ad to 12e764d5
2023-06-28 johnstiles@google.com Remove Win10 + ANGLE + IrisXe test and perf jobs.
2023-06-28 robertphillips@google.com Fail wrapping a protected AHardwareBuffer within an unprotected context
2023-06-28 michaelludwig@google.com Implement normalize as sqrt + divide instead of invsqrt + multiply
2023-06-28 kjlubick@google.com Mark some methods on Runtime Builders as const
2023-06-28 kjlubick@google.com Remove gSkBlobAsSlugTesting
2023-06-28 robertphillips@google.com [graphite] Enable manual image tiling GMs (take 2)
2023-06-28 johnstiles@google.com Add extra parentheses as required by WGSL spec.
2023-06-28 johnstiles@google.com Fix logical-xor operator in WGSL.
2023-06-28 jlavrova@google.com Improve justification algorithm
2023-06-28 johnstiles@google.com Add GM test slide to reproduce Perlin noise issue.
2023-06-28 johnstiles@google.com Add peephole optimization for merge_condition_mask.
2023-06-28 johnstiles@google.com Remove set_current_stack SkRP op.
2023-06-28 johnstiles@google.com Add SkRP builder methods for instruction handling.
2023-06-28 herb@google.com Add builtin_expect to SkASSERT_RELEASE
2023-06-28 nicolettep@google.com [graphite] Improve Vulkan descriptor set lifetime mgmnt.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-29 04:37:57 +00:00
skia-flutter-autoroll
b53a86933c Roll Dart SDK from a7151d73b88d to 656201921b30 (1 revision) (flutter/engine#43328) 
https://dart.googlesource.com/sdk.git/+log/a7151d73b88d..656201921b30

2023-06-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-260.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-29 04:08:03 +00:00
Jason Simmons
a636ee22cf [Impeller] Add a missing method to the Context mock (flutter/engine#43326) 2023-06-28 19:11:58 -07:00
gaaclarke
4f5dfc63c5 [Impeller] Collapse DrawRects into clear colors optimization (flutter/engine#43168) 
design doc: https://docs.google.com/document/d/1Lqf1BRn4uCcUfv9dZlDyAgdSMeQ3FTnPgPjKF9yQ3MI/edit

fixes: https://github.com/flutter/flutter/issues/129292

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-29 00:37:02 +00:00
Chinmay Garde
0098a0b154 [Impeller] Add trace events to Vulkan texture and buffer lifecycle events. (flutter/engine#43321) 2023-06-29 00:32:05 +00:00
skia-flutter-autoroll
be77d166b0 Roll Dart SDK from 5a59cd06e49d to a7151d73b88d (2 revisions) (flutter/engine#43318) 
https://dart.googlesource.com/sdk.git/+log/5a59cd06e49d..a7151d73b88d

2023-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-259.0.dev
2023-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-258.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-29 00:05:56 +00:00
Brandon DeRosier
5533ea8e5c [Impeller] Fix advanced CPU blend modes (flutter/engine#43294) 
Resolves https://github.com/flutter/flutter/issues/128606.

All CPU blends now match the behavior of Impeller's GPU blends, which (after https://github.com/flutter/engine/pull/43283) closely matches Skia's blends! Now we can finally use these.

https://github.com/flutter/engine/assets/919017/f9dc7323-fd14-4cdc-ba8b-930622be4206
 2023-06-28 22:34:26 +00:00