1932 Commits

Author SHA1 Message Date
Adam Barth
d6ddfcaf99 Improve widgets/README.md based on Hixie's feeback
R=ianh@google.com

Review URL: https://codereview.chromium.org/1188163004.
2015-06-17 10:39:47 -07:00
Hans Muller
87e47ef04a Cleaned up a few analyzer warnings
R=ianh@google.com

Review URL: https://codereview.chromium.org/1194583002.
2015-06-17 10:35:47 -07:00
Adam Barth
852989c26c Remove these files from BUILD.gn
They no longer exist but I forgot to remove them in my previous CL.

TBR=ianh@google.com

Review URL: https://codereview.chromium.org/1192603003.
2015-06-17 10:13:59 -07:00
Hans Muller
34c746270d Fix a typo in Dialog
If action: was specified, content: was added twice.

R=jackson@google.com

Review URL: https://codereview.chromium.org/1188303002.
2015-06-17 10:06:44 -07:00
Adam Barth
c4a7aa33d5 Delete sky-element framework
This framework is two generations old and has no clients.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1177843010.
2015-06-17 10:05:04 -07:00
Adam Barth
fd249edff7 Fix typo in RenderParagraph's |inline| getter
R=hansmuller@chromium.org

Review URL: https://codereview.chromium.org/1183603003.
2015-06-17 08:01:00 -07:00
Adam Barth
db1fb68008 Fix event propagation
I missed one rename in my Listener CL.

TBR=ianh@google.com

Review URL: https://codereview.chromium.org/1180243003.
2015-06-17 07:49:06 -07:00
Adam Barth
f49bcdd70f Update README.md
Fixed ` vs ' typo.
2015-06-17 07:43:58 -07:00
Adam Barth
ac12505f60 Add the beginnings of a Sky Widgets README.md
There's lots more ground to cover, but this CL is a start.

TBR=ianh@google.com

Review URL: https://codereview.chromium.org/1187173003.
2015-06-17 07:42:07 -07:00
Adam Barth
bc829ea123 Rename EventListenerNode to Listener
The basic widgets are going to be used many, many times, so we want them to
have short, snappy names.

Also, give the Widget argument to Listener the name |child| for consistency.

TBR=ianh@google.com

Review URL: https://codereview.chromium.org/1193513007.
2015-06-17 07:39:24 -07:00
Collin Jackson
bc68bc5729 Enable render view override for stocks app to enable testing
This fixes the test

TBR=abarth

Review URL: https://codereview.chromium.org/1192533002.
2015-06-16 23:37:29 -07:00
Collin Jackson
f26af0d0c3 Add settings page to Sky’s stocks example app
R=abarth@chromium.org, abarth

Review URL: https://codereview.chromium.org/1191863002.
2015-06-16 17:59:12 -07:00
Chinmay Garde
fd3aa9f29f Add temporary workaround for boringssl attempting to access the auxillary vector
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1185813005.
2015-06-16 17:16:04 -07:00
Adam Barth
252291dc3a Add a basic Dialog
The dialog will need many more features to be complete, but this class is a
basic skeleton of what we'll need.

R=jackson@google.com, jackson@chromium.org

Review URL: https://codereview.chromium.org/1189893002.
2015-06-16 17:11:23 -07:00
Hixie
73d9f88384 Break some lines to make debugging easier.
TBR=abarth,jackson

Review URL: https://codereview.chromium.org/1178323004.
2015-06-16 17:08:37 -07:00
Adam Barth
1d905916a4 Add some basic tests for the material buttons
Specifically, RaisedButton, FlatButton, and FloatingActionButton. These just
test that these classes work in their default configurations.

R=ianh@google.com, jackson@chromium.org

Review URL: https://codereview.chromium.org/1193453005.
2015-06-16 17:02:58 -07:00
Ryan Macnak
9cdd8bb8c7 Track changes to standalone vmservice in mojo and sky embedders.
Standalone changes were in https://codereview.chromium.org/1166433008/

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1183453004.
2015-06-16 16:58:48 -07:00
Hans Muller
61b71a6f32 Styling for text fragments
This is a completion of Eric's WIP patch:
https://codereview.chromium.org/1179663005/

Low level support for creating a paragraph that contains
runs of styled text. The styles may be nested.

The Paragraph and RenderParagraph classes have been
replaced by Inline and RenderInline. Styled text is defined
with a tree of InlineText and InlineStyle objects.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1177833012.
2015-06-16 16:48:08 -07:00
Collin Jackson
a7aa951329 Add back/forward history to navigation
R=abarth@chromium.org, abarth, hixie

Review URL: https://codereview.chromium.org/1181773006.
2015-06-16 16:14:55 -07:00
Chinmay Garde
9b74ec026c iOS: Wire up all gesture types in input_event.mojom
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1183833004.
2015-06-16 13:17:17 -07:00
Adam Barth
5faecb46fe Add FlatButton
I've factored the common code for FlatButton and RaisedButton into
MaterialButton. Also, tweak some of the constants in MaterialButton to better
match the spec.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1187773008.
2015-06-16 12:19:33 -07:00
Hixie
b5d44546c9 Key refactor, part 1: remove the dependence on the runtimeType in keys, otherwise they'll get overly long very quickly.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1185413002.
2015-06-16 11:31:52 -07:00
Hixie
b9426b5069 Forgot to update BUILD.gn when I renamed ui_node.dart.
TBR=abarth

Review URL: https://codereview.chromium.org/1175193005.
2015-06-16 11:10:53 -07:00
Hixie
350f16c93e Rename UINode to Widget.
Also, move a widget example from examples/raw/ to examples/widgets/

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1190793002.
2015-06-16 11:09:16 -07:00
Viktor Lidholt
f18d3d82b6 Places demo game in a OneChildRenderObjectWrapper and adds a star field and nebula for background
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1187153002.
2015-06-16 10:59:24 -07:00
Hixie
10838ffdee Clean the relayout subtree root deeply when removing a child, otherwise the tree ends up in an inconsistent state.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1186123009.
2015-06-16 10:49:33 -07:00
Chinmay Garde
78754cd6a1 Fix offscreen rendering on iOS by not assuming that the default window bound framebuffer is 0
BUG=
R=iansf@google.com

Review URL: https://codereview.chromium.org/1183213007.
2015-06-16 09:51:34 -07:00
Collin Jackson
fd396d024d Simple support for routing in Sky
R=abarth@chromium.org, abarth, hixie

Review URL: https://codereview.chromium.org/1186273002.
2015-06-16 09:47:57 -07:00
Hixie
fc5d7261ec Make PopupMenuItem take a single child instead of an implicitly-flex list of children.
TBR=abarth

Review URL: https://codereview.chromium.org/1187463013.
2015-06-16 09:41:05 -07:00
Hixie
bb53cd828c More minor cleanup around overriding fields to narrow types.
TBR=abarth

Review URL: https://codereview.chromium.org/1189833004.
2015-06-16 09:33:17 -07:00
Hixie
b3f47808bc Create an example app that demonstrates interactive coordination of an fn tree and a raw RenderObject tree.
Sector changes:
- implement the intrinsic sizing box API on RenderBoxToRenderSectorAdapter
- remove some debug print statements
- fix getIntrinsicDimensions() on RenderSolidColor to return true values
- factor out the default demo

RenderObject changes:
- BoxConstraints.isInfinite() now returns true only if both dimensions are infinite

fn changes:
- implement UINodeToRenderBoxAdapter
- rename RenderObjectToUINodeAdapter to RenderBoxToUINodeAdapter

Tests:
- add a test for sector layout
- make TestRenderView support being run without the unit test framework

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1175423007.
2015-06-16 09:28:59 -07:00
Adam Barth
79455270b2 Make UINode's key a String
We need the key to be a String even though we claimed we could support any
Object. Also, clean up some style nits including shortening the |root| getters
on OneChildRenderNodeWrappers.

Fixes https://github.com/domokit/sky_sdk/issues/26.

TBR=ianh@google.com

Review URL: https://codereview.chromium.org/1173293005.
2015-06-15 21:39:09 -07:00
Adam Barth
71c7be5ebc Give ParentDataNodes snappier names
FlexExpandingChild -> Flexible
StackPositionedChild -> Positioned

Also, name the child argument |child| for consistency.

TBR=ianh@google.com

Review URL: https://codereview.chromium.org/1179763009.
2015-06-15 21:03:28 -07:00
Adam Barth
883f673a6b Update Dart dependency and patch dart_controller to account for non-backwards compatible API update
Patch originally by chinmaygarde.

R=chinmaygarde@google.com

Review URL: https://codereview.chromium.org/1185233002.
2015-06-15 18:34:27 -07:00
Hixie
2b4cf61644 Make RaisedButton support being disabled.
R=jackson@google.com

Review URL: https://codereview.chromium.org/1179943005.
2015-06-15 17:32:13 -07:00
Hixie
a22064a7a3 Remove RenderSizedBox.
Make old users of RenderSizedBox use RenderConstrainedBox.
Change the semantics of BoxDecoration.apply* to actually apply the provided constraints to the current constraints, rather than the previous behaviour of merging them neutrally.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1189603003.
2015-06-15 15:51:56 -07:00
Chinmay Garde
9bf2fe7f3a Revert "Update Dart dependency and patch dart_controller to account for"
This reverts commit 42bb335967d4d9cbeb1a745111dd0fff985465f2.
2015-06-15 15:32:28 -07:00
Chinmay Garde
e027c6b874 Update Dart dependency and patch dart_controller to account for
non-backwards compatible API update

BUG=
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1183253002.
2015-06-15 15:11:31 -07:00
Collin Jackson
7530ed4643 Remove unneeded import and fix analyzer warnings
R=ianh@google.com, hixie

Review URL: https://codereview.chromium.org/1190573002.
2015-06-15 15:11:14 -07:00
Chinmay Garde
2ccb9b778f Fix iOS builds after ShellView refactor on Android
BUG=
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1188633002.
2015-06-15 15:10:48 -07:00
Adam Barth
5f733de41c Don't build sky_packager on Mac hosts
sky_packager requires C++11 and the Mac host toolchain can't handle C++11.

R=cstout@chromium.org, cstout@google.com

Review URL: https://codereview.chromium.org/1183223003.
2015-06-15 15:04:53 -07:00
Collin Jackson
5566f08831 Fix stocks app usage of checkbox
TBR=hixie

Review URL: https://codereview.chromium.org/1188573004.
2015-06-15 13:17:50 -07:00
Collin Jackson
8758e72da5 Really basic Switch implementation in Sky. Could definitely use some polish
R=abarth@chromium.org, abarth

Review URL: https://codereview.chromium.org/1185173002.
2015-06-15 12:53:44 -07:00
Hans Muller
f8efd9c96f StockRow height, background color updates
Make stock2 exactly match the original stock demo.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1187563006.
2015-06-15 12:09:37 -07:00
Viet-Trung Luu
d887d2cd7e Fix sky/tools/packager/BUILD.gn.
scopes.h -> scope.h.

TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/1177123005.
2015-06-15 11:16:17 -07:00
Adam Barth
15fab09ab2 Introduce sky_packager
sky_packager is a tool that generates a Dart script snapshot for Dart files
intended to run with dart:sky. I plan to use this tool to experiment with
startup performance.

R=jackson@google.com

Review URL: https://codereview.chromium.org/1178213003.
2015-06-15 10:42:17 -07:00
Viktor Lidholt
5dc39bace7 Updates game for new AppView API
Deletes old test game

Demo game is now playable

Updates demo game with steering and changes in sprites

Fixes smaller bugs in sprites

Refactor class names in game demo

Strips Box2D from game

Fixes ordering in game node

Adds frameRate property to SpriteBox and improves update methods.

Fixes node to box transformations for hit tests

Fixes minor code issues

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1179333002.
2015-06-15 09:11:16 -07:00
Adam Barth
5e5b220f8f Fix two minor issues with sky/sdk
1) BUILD.gn was missing internals.dart.
2) generators.dart was importing scheduler.dart from the wrong directory.

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1189523003.
2015-06-15 01:10:12 -07:00
Adam Barth
773a0ddfa1 Fix typo in README.md
https://github.com/domokit/sky_sdk/pull/19

Patch by @danrubel

Review URL: https://codereview.chromium.org/1182873003.
2015-06-13 10:35:27 -07:00
Adam Barth
4fb2c9ffb0 Add missing dependency to the build
We've had a number of reports of a missing dependency in the build. I managed
to reproduce the issue locally today and this patch fixed the issue I was
seeing. Hopefully it fixes the issues other folks were seeing too.

The problem was that the C++ code we generate from IDL files depended on
various event classes in core, which in turn depended on the generated event
names files. This CL ensures that the event names files are created before we
try to build the C++ code generated from the IDL files.

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1178173004.
2015-06-13 09:47:36 -07:00