If the mapping callback is not set or it the callback returns invalid data, ICU initialization will be embedder responsibility.
This affects all embedders and the following have been audited:
* Android: Via a symbol mapping.
* iOS: Via a file mapping.
* Embedder: Via a file mapping.
* Fuchsia: Via a VMO mapping
* Test shells and Flutter tester: Via file mapping with ICU data needing to be next to the executable.
The GetMapping calls removed in this patch had the same code and had to be repeated across different test harnesses as well as in dart_snapshot.cc. Just make this a factory method so the code is less verbose.
As long as the Mac SDK is i386 ready, engine developers should be able to use the latest version of Xcode to build all artifacts. This issue goes away when gen_snapshot migrates to x64.
This reverts commit 1c06891c101f530c1f46337b457ba02e0f6c8633.
Windows depends on referencing the snapshot symbols directly instead of
via dlsym. Something in the way these symbolsa are generated in
bin_to_assembly.py is causing them to be inaccessible at runtime.
cf4444b803 Revert "[ VM / Service ] Temporarily disable VM service auth codes by default"
f8491950fe Create List<TypeParameterElement>, not Impl.
fa7485f28e Build types for not simply bounded elements using dynamic type arguments.
9d376de55a [vm] Remove code collection.
0c0e49cd11 update keyword list to include "late" modifier
3cf3e4edde [dart/vm] Reduce trip count of osr test
503e20946c [vm] Start logging if shutdown takes too long.
2b9f968d2f Convert engine.dart to triple-slash comment style
73b917c014 [vm/compiler] Do not generate unnecessary field length guards
20fde9a6a8 Don't overwrite inherited types of fields with types of initializers.
e6e2a196a3 Issue 36667. Check for unresolved URI in getLibraryByUri().
6ac38a926c The synthetic default constructor should have reference.
92729e0cd3 Remove UndefinedTypeImpl.
cf77b82f52 [analyzer] handle youtube and animation dartdoc directives
6384f629c0 new conflicting-modifiers error code
f3703c1bce change "late" from built-in to keyword
af9c01432c Remove unused import
7b6b8f8c43 Restore 'parameters' and 'typeParameters' for ParameterElementImpl.
bc58bf598e Add summary serialization support for nullability suffixes.
8093f73424 [vm/dbc] Add UNREACHABLE() stubs to simulator_dbc.cc in 32-bit mode to make 32-build work
336fc9001c Fix for getting type of a DefaultFormalParameter during building types.
e93c6b7ce1 Add AST representation of the late keyword
43eebea5a3 [kernel_worker] retry on failure
284a299543 Fix mustCallSuper for mixins; fixes#36492
5a824581b7 Read directive annotations before returning offset.
703ccc974b Support for TypeParameter metadata.
242ed77040 Fix for FormalParameter without name.
92dd37081d Write / read Annotation element.
d8a0d68bd6 Rename devcompiler to ddc
6d91643073 [vm, interpreter] Handle closure case of invoke-field-dispatchers as bytecode.
b8a9711489 Update AstBuilder to handle "required" modifier
ca28e2c8ce forward "required" modifier to parser listeners
250d931ecc When URI cannot be resolved, the library is null.
2491767a33 Use correct CompilationUnitElement for annotations.
4ef18fdb96 Fix nameOffset for Export/ImportElement.
7873dbdc1d Fix for duplicate declarations.
38049f3cb6 [vm, interpreter] Handle implicit static getters as bytecode.
714a082a5d Minimal integration of summary2 into AnalysisDriver.
dd3530450d make "late" and "required" builtin keywords
836efd6520 Add a language_2 test for having an invalid type in an on clause
81e554ea43 parse "required" modifier for NNBD
1eab04ed3f Reland "[VM-debugger] resolve column breakpoint tokenposition into a single value"
ec27b09e68 [vm, service] Fix deferral of service extension invocation to not be mislead by other OOB messages.
1e30bb90dc [vm/dbc] Support unboxed Int64 on DBC
The raw pointer isn't a reliable id as the allocator can reuse an
address that's just been released for another layer.
This will fix Fuchsia bug FL-216.
This problem was not affecting non-Fuchsia Flutter probably because
non-Fuchsia Flutter purges the raster cache key much more frequently so
we won't see a key collision. In Fuchsia, as the key has to wait for the
Vulkan surface to render asynchronously, this suddenly becomes an issue.
`//flutter/runtime: runtime_lifecycle_unittests` was added because the these assumed that there was no VM already running in the process. Running other tests in the base target would mess up that assumption. Now that all test targets have been updated to make sure the VM instance does not leak, the tests in this target can be merged.
LUCI bots don’t need to be patched as these tests were only ever run on the trybots.
Reland "Add a unit test for PhysicalShapeLayer (#8616)"
This reverts commit 3e1caa0959c5d9f673b2d7c7ed0d9befb1b42353.
The only change is the namespace.
currentLineWidth is the width passed into Paragraph layout, which comes
from the maxIntrinsicWidth returned by a previous call to Paragraph layout.
That width is calculated by Layout::measureText.
postBreak is calculated from the character widths in the LineBreaker.
A slight mismatch between these two widths may unnecessarily cause the
insertion of desperate breaks in addWordBreak. Adding some slack to
currentLineWidth works around this.
Fixes https://github.com/flutter/flutter/issues/30347
Almost all of the python build files in the flutter project work if
`python` is `python2` or `python3`. This is the only area where print is
incorrectly used (for `python3`).
Related issue: https://fuchsia-review.googlesource.com/c/fuchsia/+/272925
An unnecessary PrerollContext copy is also removed. The added unit test will catch the error if we forget to subtract the elevation after the copy removal.
This change has been tested with the framework (`flutter test --local-engine=host_debug_unopt`).
There is a possibility for a VM launch to not have a requisite shutdown if a previous launch asked to leak the VM instance in the process. Embedders have to ensure (via their Embedding APIs) that all instances of VM launch use consistent settings.
714a082a5d Minimal integration of summary2 into AnalysisDriver.
dd3530450d make "late" and "required" builtin keywords
836efd6520 Add a language_2 test for having an invalid type in an on clause
81e554ea43 parse "required" modifier for NNBD
1eab04ed3f Reland "[VM-debugger] resolve column breakpoint tokenposition into a single value"
ec27b09e68 [vm, service] Fix deferral of service extension invocation to not be mislead by other OOB messages.
1e30bb90dc [vm/dbc] Support unboxed Int64 on DBC
7b9ab9f353 Add error ranges to more diagnostic tests
3782197e95 Sort summary_common.dart
37285467db Improvements to null_assertion_ambiguous_test
b0c98d57fa Add the new manifest error codes to error codes list
ebdefa3f5f add new "late" and "required" modifiers
