15463 Commits

Author SHA1 Message Date
Casey Hillers
d64af4e311 [ci.yaml] Update engine enabled branches (flutter/engine#29820) 2021-11-19 15:23:02 -08:00
skia-flutter-autoroll
90f5c1d9ab Roll Skia from 62392f624f39 to 940086c81587 (7 revisions) (flutter/engine#29845)
https://skia.googlesource.com/skia.git/+log/62392f624f39..940086c81587

2021-11-19 michaelludwig@google.com [graphite] Include offset in Writers returned by DrawBufferManager
2021-11-19 herb@google.com refactor checking for direct glyph situations
2021-11-19 jvanverth@google.com Add SkSL::ShaderCaps and use as base class for GrShaderCaps
2021-11-19 scroggo@google.com Add minimal GL support for protected backend textures
2021-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4c687cc2f8ea to f5cf2d08ff9c (2 revisions)
2021-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ca9862fcfe55 to e7ac7694e638 (463 revisions)
2021-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 67e1e9c199cc to 53db01bf1e64 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2021-11-19 14:21:08 -08:00
gaaclarke
7ab226eaf4 iOS Background Platform Channels (flutter/engine#29665) 2021-11-19 14:14:45 -08:00
skia-flutter-autoroll
a610124ea5 Roll Fuchsia Linux SDK from Gc37iAM6P... to Ii-fFcsGk... (flutter/engine#29850) 2021-11-19 13:58:01 -08:00
gaaclarke
431731da40 Mentioned that replies can be invoked on any thread now that that is supported. (flutter/engine#29816) 2021-11-19 13:43:31 -08:00
Jenn Magder
7b792c087d Wrap format script diff in patch command (flutter/engine#29833) 2021-11-19 12:22:04 -08:00
David Worsham
40d0af4eb2 fuchsia: Fix Flatland opacity (flutter/engine#29844) 2021-11-19 11:58:20 -08:00
skia-flutter-autoroll
4d13aa4829 Roll Dart SDK from 91e3fa160432 to f0f78da08ff2 (8 revisions) (flutter/engine#29846) 2021-11-19 11:23:05 -08:00
Jenn Magder
c08aa6c73d Add 'explicit' to darwin embedder constructors (flutter/engine#29827) 2021-11-19 10:54:29 -08:00
Dan Field
edb87942de Use eglPresentationTimeANDROID to avoid bogging down the GPU (flutter/engine#29727)
Fixes flutter/flutter#93352

Improves Android benchmarks on both Pixel 4 and a lower end Android Go device for 99th percentile and average raster times.

This works by telling the system compositor what timestamp we intended to show this frame for. This way, if we end up with a frame that gets submitted right at the beginning of a vsync and then a second frame submitted on the same vsync, the compositor will only try to show the second frame on the screen and save the GPU some work.

Without this, a situation like that results in an "avalanche" of calls where the GPU is behind the CPU and keeps delaying CPU work until we finally stop submitting frames. This can be observed as a lengthy dequeuBuffer in a systrace enabled trace, as shown in the linked issue. This avalanche is often triggered by a frame that does a shader compile through a couple vsyncs and then is followed by a bunch of very fast frames that take less than a vsync to render - the first of those fast frames gets delivered before the end of the vsync that the slow frame ended in.

We cannot implement this ourselves because we don't know how long the swap buffers call will take on the system side, and if we try to guess we can very well get it wrong.

I've filed issues to look into adding this for Vulkan and Metal, although we should also first take traces there to make sure it's warranted.

See also: https://android-developers.googleblog.com/2020/04/high-refresh-rate-rendering-on-android.html
2021-11-19 09:29:51 -08:00
skia-flutter-autoroll
e7954e3f62 Roll Skia from a5261995416e to 62392f624f39 (12 revisions) (flutter/engine#29823)
https://skia.googlesource.com/skia.git/+log/a5261995416e..62392f624f39

2021-11-18 brianosman@google.com Remove old (unused) values from LayoutToken enum
2021-11-18 johnstiles@google.com Improve redundant trace_var elimination.
2021-11-18 bsalomon@google.com Remove drawPatch/Vertices helpers that don't take SkBlendMode
2021-11-18 robertphillips@google.com Improve handling of degenerate paths in AAHairLinePathRenderer::bloat_quad
2021-11-18 drott@chromium.org Fall back to type 3 embedding for fonts with COLR table
2021-11-18 johnstiles@google.com Optimize commutative operations in SkVM.
2021-11-18 johnstiles@google.com Add test for commutative operations in SkVM.
2021-11-18 herb@google.com make drawMatrix use more explicit
2021-11-18 robertphillips@google.com Allow the Triangulator to fail
2021-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 8e6bab5320de to 4f4d765e4e51
2021-11-18 brianosman@google.com Reland "Remove layer-coverage-tracking experiment"
2021-11-18 kjlubick@google.com [infra] Use Bazel transitions to allow cc_binary to set their own flags

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2021-11-19 08:37:04 -08:00
Jason Simmons
b92dab5c1f Roll expat and buildroot (flutter/engine#29813)
Update license script for new expat

Fixes https://github.com/flutter/flutter/issues/91384
2021-11-19 07:57:58 -08:00
Dan Field
3942c6c9f7 Make it less likely to GC during application startup on Android (flutter/engine#29825) 2021-11-18 22:22:22 -08:00
Jenn Magder
b39436f7e5 Fix darwin namespace-comments and brace lint issues (flutter/engine#29828) 2021-11-18 21:06:56 -08:00
Jenn Magder
5291ff4193 Add 'explicit' to Android embedder constructors (flutter/engine#29830) 2021-11-18 21:06:44 -08:00
ColdPaleLight
9ecd4c1899 Make FlutterEngineGroup support dart entrypoint args (flutter/engine#29096) 2021-11-18 18:08:03 -08:00
Tong Mu
5183c56533 [Embedder] Send key data through message channel (flutter/engine#29795)
This PR changes how embedder API's SendKeyData sends ui.KeyData to the framework. The packets are now sent over the existing platform messenger, reusing the entirety of its code path and functionalities while keeping the embedder API unchanged
2021-11-18 17:53:28 -08:00
Tong Mu
5077f867cf [Linux, Keyboard] Fix synthesization upon different logical keys (flutter/engine#29768)
This PR fixes an assertion error when the physical-logical map changes during key synthesization. This error will lead to irregular key sequences, and might occur during an extremely rare edge case described in the unit test in this PR.
2021-11-18 17:52:14 -08:00
Yegor
2626d20f22 [web] move browser installation to BrowserEnvironment.prepare (flutter/engine#29801)
* [web] move browser installation to BrowserEnvironment.prepare

* reject attempts to install Chromium on LUCI
2021-11-18 15:23:36 -08:00
skia-flutter-autoroll
2908f68c01 Roll Skia from 0774db13d24c to a5261995416e (10 revisions) (flutter/engine#29810) 2021-11-18 13:13:02 -08:00
Dan Field
0a6301d5ca Listen for display refresh changes and report them correctly (flutter/engine#29800)
This makes sure the frame timings recorder and vsync waiter implementations get
the correct refresh rate if or when it adjusts at runtime. This should be OK
because we'll only query the refresh rate when the display metrics actually
change, which is much less frequent than every frame. I experimented with an NDK
implementation in the previous patch, but that vastly restricts the API levels
we can support, and currently on API 30 and 31 it just calls Java methods
through JNI anyway.

I've refactored the way Display updates are reported so that AndroidDisplay can
just dynamically get the refresh rate correctly. These values are used by a
service protocol extension and by some Stopwatches on the CompositorContext.

See also #29765

Fixes flutter/flutter#93688
Fixes flutter/flutter#93698
2021-11-18 13:09:26 -08:00
Zachary Anderson
78d9e276e2 Fix some clang-tidy lints for Linux host_debug (flutter/engine#29734) 2021-11-18 13:08:01 -08:00
Niklas Schulze
1306ea59ec winuwp: Add multi-touch support (flutter/engine#28067) 2021-11-18 13:03:03 -08:00
skia-flutter-autoroll
9bc7689ded Roll Fuchsia Linux SDK from 8wLWcmqi8... to Gc37iAM6P... (flutter/engine#29807) 2021-11-18 10:34:32 -08:00
skia-flutter-autoroll
628a004c26 Roll Skia from 688cb15faa64 to 0774db13d24c (5 revisions) (flutter/engine#29805) 2021-11-18 10:33:02 -08:00
Yegor
9a75a379aa [web] feature-detect and use ImageDecoder for all image decoding (flutter/engine#29419) 2021-11-18 10:01:02 -08:00
Justin McCandless
3d60f36a21 TextEditingDelta Mac (flutter/engine#29036)
Enables the TextEditingDelta API for Mac, and abstracts iOS's TextEditingDelta class for multi-platfor reuse.
2021-11-18 08:44:44 -08:00
gaaclarke
99b17af458 Stopped creating the shell inside of a sync_switch when spawning. (flutter/engine#29798)
* Stopped creating the shell inside of a sync_switch when spawning.

* jason feedback
2021-11-17 17:34:48 -08:00
skia-flutter-autoroll
2ac1465d0e Roll Skia from e136c31fe49d to 688cb15faa64 (11 revisions) (flutter/engine#29799) 2021-11-17 17:28:02 -08:00
chunhtai
2a4d9bb696 Fixes the accessibilityContainer of FlutterScrollableSemanticsObject (flutter/engine#29771) 2021-11-17 17:01:31 -08:00
skia-flutter-autoroll
313956aabf Roll Fuchsia Linux SDK from Vxe912PZC... to 8wLWcmqi8... (flutter/engine#29785) 2021-11-17 16:53:02 -08:00
Jenn Magder
49d561e0e1 Fix "google-objc-*" clang analyzer warning in macOS and iOS (flutter/engine#29764) 2021-11-17 16:48:04 -08:00
skia-flutter-autoroll
1f49c7c11d Roll Skia from 12e786730f7d to e136c31fe49d (9 revisions) (flutter/engine#29787)
https://skia.googlesource.com/skia.git/+log/12e786730f7d..e136c31fe49d

2021-11-17 jvanverth@google.com [graphite] Add rasterization state methods to CommandBuffer
2021-11-17 johnstiles@google.com Fix fuzzer-discovered error with child calls.
2021-11-17 johnstiles@google.com Remove void from the list of opaque types.
2021-11-17 johnstiles@google.com Add test for void type in struct.
2021-11-17 borenet@google.com Revert "[python3] More Recipes -> Python 3 fixes"
2021-11-17 borenet@google.com Revert "[recipes] Fix Android failures after Python3 update"
2021-11-17 johnstiles@google.com Disallow variables of type 'void'.
2021-11-17 johnstiles@google.com Add test for variables of type void.
2021-11-17 borenet@google.com [recipes] Fix Android failures after Python3 update

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2021-11-17 16:08:37 -08:00
Yegor
2df67fa9d4 Roll to CanvasKit 0.31.0 (flutter/engine#29772)
* [web] roll CanvasKit to version 0.31.0
2021-11-17 15:53:58 -08:00
godofredoc
44164d408e Revert 29789 revert 29542 freiling view ref (flutter/engine#29793) 2021-11-17 12:58:02 -08:00
Zachary Anderson
03c0f7e453 Add 'explicit' to header files (flutter/engine#29741) 2021-11-17 12:49:16 -08:00
Chris Bracken
dd669f3631 Acquire context reference at the correct time for FlGlArea. (flutter/engine#29791)
This is a reland of flutter/engine#29178 onto the main branch. The
original patch was landed on the master branch during the branch switch
from master to main.
2021-11-17 11:04:33 -08:00
skia-flutter-autoroll
baab0c1ca8 Roll Skia from cf1e959c657b to 12e786730f7d (1 revision) (flutter/engine#29786) 2021-11-17 07:48:01 -08:00
skia-flutter-autoroll
566cb8de91 Roll Skia from fa2edac74af8 to cf1e959c657b (2 revisions) (flutter/engine#29784) 2021-11-17 06:28:02 -08:00
Matej Knopp
0134f93710 PhysicalShapeLayer: Only push cull rect during diff if clipping (flutter/engine#29783) 2021-11-17 14:46:52 +01:00
skia-flutter-autoroll
ed2897366d Roll Skia from 2211c2c4bd69 to fa2edac74af8 (4 revisions) (flutter/engine#29779) 2021-11-16 23:37:31 -08:00
skia-flutter-autoroll
6e652efc35 Roll Skia from 686ccec13fc5 to 2211c2c4bd69 (25 revisions) (flutter/engine#29770) 2021-11-16 19:13:01 -08:00
Greg Spencer
a079a95ef7 Fix Kanji switch in Japanese IME on WIndows (flutter/engine#29761) 2021-11-16 19:08:01 -08:00
Brandon DeRosier
4136d0117f Enable Skia's Vulkan backend on all non-mobile platforms, and test SwiftShader Vulkan on all GL unittests platforms (flutter/engine#29520) 2021-11-16 15:27:25 -08:00
skia-flutter-autoroll
c839dc8664 Roll Fuchsia Linux SDK from ghwyDtFSJ... to Vxe912PZC... (flutter/engine#29762) 2021-11-16 14:23:02 -08:00
skia-flutter-autoroll
94b541fe98 Roll Skia from 7fab38d97ace to 686ccec13fc5 (9 revisions) (flutter/engine#29757) 2021-11-16 14:22:32 -08:00
Jim Graham
6c74b3f717 Call DisplayList builder methods directly from dart canvas (flutter/engine#29714) 2021-11-16 14:18:04 -08:00
Jenn Magder
a11ae85afd Treat clang-analyzer-osx warnings as errors (flutter/engine#29755) 2021-11-15 16:06:01 -08:00
Mouad Debbar
e784b12872 [web] Start support for Skia Gold (flutter/engine#29139) 2021-11-15 16:05:31 -08:00
godofredoc
71b4205800 Reverse order of branch mirroring. (flutter/engine#29754)
Bug: https://github.com/flutter/flutter/issues/90476
2021-11-15 10:40:37 -08:00