DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add 'explicit' to Android embedder constructors (flutter/engine#29830)

Browse Source
This commit is contained in:
Jenn Magder 2021-11-18 21:06:44 -08:00 committed by GitHub
parent 9ecd4c1899
commit 5291ff4193
7 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
engine/src/flutter/fml/platform/android/scoped_java_ref.h
View File

@ -164,6 +164,7 @@ class ScopedJavaGlobalRef : public JavaRef<T> {
public:
ScopedJavaGlobalRef() {}
// NOLINTNEXTLINE(google-explicit-constructor)
explicit ScopedJavaGlobalRef(const ScopedJavaGlobalRef<T>& other) {
this->Reset(other);
}

2
engine/src/flutter/shell/platform/android/android_image_generator.h
View File

@ -16,7 +16,7 @@ namespace flutter {
class AndroidImageGenerator : public ImageGenerator {
private:
AndroidImageGenerator(sk_sp<SkData> buffer);
explicit AndroidImageGenerator(sk_sp<SkData> buffer);
public:
~AndroidImageGenerator();

2
engine/src/flutter/shell/platform/android/apk_asset_provider.cc
View File

@ -38,7 +38,7 @@ AssetResolver::AssetResolverType APKAssetProvider::GetType() const {
class APKAssetMapping : public fml::Mapping {
public:
APKAssetMapping(AAsset* asset) : asset_(asset) {}
explicit APKAssetMapping(AAsset* asset) : asset_(asset) {}
~APKAssetMapping() override { AAsset_close(asset_); }

2
engine/src/flutter/shell/platform/android/flutter_main.h
View File

@ -27,7 +27,7 @@ class FlutterMain {
const flutter::Settings settings_;
DartServiceIsolate::CallbackHandle observatory_uri_callback_;
FlutterMain(flutter::Settings settings);
explicit FlutterMain(flutter::Settings settings);
static void Init(JNIEnv* env,
jclass clazz,

2
engine/src/flutter/shell/platform/android/platform_message_handler_android.h
View File

@ -17,7 +17,7 @@
namespace flutter {
class PlatformMessageHandlerAndroid : public PlatformMessageHandler {
public:
PlatformMessageHandlerAndroid(
explicit PlatformMessageHandlerAndroid(
const std::shared_ptr<PlatformViewAndroidJNI>& jni_facade);
void HandlePlatformMessage(std::unique_ptr<PlatformMessage> message) override;
void InvokePlatformMessageResponseCallback(

3
engine/src/flutter/shell/platform/android/platform_view_android_jni_impl.h
View File

@ -16,7 +16,8 @@ namespace flutter {
///
class PlatformViewAndroidJNIImpl final : public PlatformViewAndroidJNI {
public:
PlatformViewAndroidJNIImpl(fml::jni::JavaObjectWeakGlobalRef java_object);
explicit PlatformViewAndroidJNIImpl(
fml::jni::JavaObjectWeakGlobalRef java_object);
~PlatformViewAndroidJNIImpl() override;

2
engine/src/flutter/shell/platform/android/vsync_waiter_android.h
View File

@ -18,7 +18,7 @@ class VsyncWaiterAndroid final : public VsyncWaiter {
public:
static bool Register(JNIEnv* env);
VsyncWaiterAndroid(flutter::TaskRunners task_runners);
explicit VsyncWaiterAndroid(flutter::TaskRunners task_runners);
~VsyncWaiterAndroid() override;