DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
30,056 Commits 882 Branches 1,069 Tags
Commit Graph

30056 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
d6490c08eb Roll Fuchsia Linux SDK from DEENqWMCYI1SMYsYH... to rmzZN2ZAgpbjAFi5_... (flutter/engine#43722) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-15 15:22:22 +00:00
Zachary Anderson
6237207218 Revert "Reland "add non-rendering operation culling to DisplayListBuilder" (#41463)" (flutter/engine#43721) 
Reverts flutter/engine#43698

A framework tree test started failing on the engine roll with this PR: https://github.com/flutter/flutter/pull/130643

The test failure is in https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20hybrid_android_views_integration_test/8517/overview

```
[2023-07-14 19:33:21.980926] [STDOUT] stdout: [   +6 ms] I/PlatformViewsController( 9988): Using hybrid composition for platform view: 5
[2023-07-14 19:33:22.767236] [STDOUT] stdout: [ +786 ms] 00:19 +4 -1: Flutter surface with hybrid composition Uses FlutterImageView when Android view is on the screen [E]
[2023-07-14 19:33:22.767765] [STDOUT] stdout: [        ]   Expected: '|-FlutterView\n'
[2023-07-14 19:33:22.767815] [STDOUT] stdout: [        ]               '  |-FlutterSurfaceView\n'
[2023-07-14 19:33:22.767924] [STDOUT] stdout: [        ]               '  |-FlutterImageView\n'
[2023-07-14 19:33:22.768084] [STDOUT] stdout: [        ]               '  |-ViewGroup\n'
[2023-07-14 19:33:22.768162] [STDOUT] stdout: [        ]               '    |-ViewGroup\n'
[2023-07-14 19:33:22.768800] [STDOUT] stdout: [        ]               '  |-FlutterImageView\n'
[2023-07-14 19:33:22.768835] [STDOUT] stdout: [        ]               ''
[2023-07-14 19:33:22.768853] [STDOUT] stdout: [        ]     Actual: '|-FlutterView\n'
[2023-07-14 19:33:22.768882] [STDOUT] stdout: [        ]               '  |-FlutterSurfaceView\n'
[2023-07-14 19:33:22.768900] [STDOUT] stdout: [        ]               '  |-FlutterImageView\n'
[2023-07-14 19:33:22.768917] [STDOUT] stdout: [        ]               '  |-ViewGroup\n'
[2023-07-14 19:33:22.768956] [STDOUT] stdout: [        ]               '    |-ViewGroup\n'
[2023-07-14 19:33:22.769119] [STDOUT] stdout: [        ]               ''
[2023-07-14 19:33:22.769156] [STDOUT] stdout: [        ]      Which: is different. Both strings start the same, but the actual value is missing the following trailing characters:   |-Flutte ...
[2023-07-14 19:33:22.779280] [STDOUT] stdout: [  +10 ms]   package:matcher/src/expect/expect.dart 149:31     fail
[2023-07-14 19:33:22.779326] [STDOUT] stdout: [        ]   package:matcher/src/expect/expect.dart 144:3      _expect
[2023-07-14 19:33:22.780315] [STDOUT] stdout: [        ]   package:matcher/src/expect/expect.dart 56:3       expect
[2023-07-14 19:33:22.780345] [STDOUT] stdout: [        ]   test_driver/main_test.dart 124:7                  main.<fn>.<fn>
[2023-07-14 19:33:22.780356] [STDOUT] stdout: [        ]   ===== asynchronous gap ===========================
[2023-07-14 19:33:22.780365] [STDOUT] stdout: [        ]   package:test_api/src/backend/declarer.dart 215:9  Declarer.test.<fn>.<fn>
[2023-07-14 19:33:22.780376] [STDOUT] stdout: [        ]   ===== asynchronous gap ===========================
[2023-07-14 19:33:22.780385] [STDOUT] stdout: [        ]   package:test_api/src/backend/declarer.dart 213:7  Declarer.test.<fn>
[2023-07-14 19:33:22.780395] [STDOUT] stdout: [        ]   ===== asynchronous gap ===========================
[2023-07-14 19:33:22.780405] [STDOUT] stdout: [        ]   package:test_api/src/backend/invoker.dart 258:9   Invoker._waitForOutstandingCallbacks.<fn>
[2023-07-14 19:33:22.780415] [STDOUT] stdout: [        ] 00:19 +4 -1: Flutter surface with hybrid composition (tearDownAll)
[2023-07-14 19:33:22.907295] [STDOUT] stdout: [ +126 ms] 00:19 +4 -1: (tearDownAll)
[2023-07-14 19:33:22.947855] [STDOUT] stdout: [  +41 ms] 00:19 +4 -1: Some tests failed.
```

This change in that roll looks like it may be related.
 2023-07-15 14:14:10 +00:00
skia-flutter-autoroll
a7a6ecc923 Roll Clang from 6d667d4b261e to ebd0b8a0472b (flutter/engine#43673) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/clang-flutter-engine
Please CC rmistry@google.com,zanderso@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Clang:
https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-15 06:33:12 -07:00
skia-flutter-autoroll
1218403e3d Roll Dart SDK from 671bbdf6c542 to 0bd185c282d2 (1 revision) (flutter/engine#43719) 
https://dart.googlesource.com/sdk.git/+log/671bbdf6c542..0bd185c282d2

2023-07-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-315.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-15 12:24:59 +00:00
Rulong Chen（陈汝龙）
b761cc404b Optimizing performance by avoiding multiple GC operations caused by multiple surface destruction notifications (flutter/engine#43587) 
Fixes: https://github.com/flutter/flutter/issues/130379

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-15 08:44:04 +00:00
skia-flutter-autoroll
9e98b682c5 Roll Skia from 975eb1250431 to 6fb535aede4e (1 revision) (flutter/engine#43716) 
https://skia.googlesource.com/skia.git/+log/975eb1250431..6fb535aede4e

2023-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fcbe6bbcf4a8 to 831910dbe1f3 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-15 05:47:08 +00:00
skia-flutter-autoroll
0a1d2a7cea Roll Dart SDK from d1fcadf22aad to 671bbdf6c542 (2 revisions) (flutter/engine#43715) 
https://dart.googlesource.com/sdk.git/+log/d1fcadf22aad..671bbdf6c542

2023-07-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-314.0.dev
2023-07-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-313.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-15 05:42:14 +00:00
skia-flutter-autoroll
ee773d72eb Roll Fuchsia Mac SDK from Z-1lzZAOYHvVrdjQ8... to oeYLDNShuD-FTgGwU... (flutter/engine#43714) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-15 04:52:04 +00:00
skia-flutter-autoroll
e34ae42c1e Roll Skia from 271b2b6d5aaa to 975eb1250431 (2 revisions) (flutter/engine#43712) 
https://skia.googlesource.com/skia.git/+log/271b2b6d5aaa..975eb1250431

2023-07-15 johnstiles@google.com Fix error on tree about unused backbuffer variable.
2023-07-14 nigeltao@google.com SkWuffsCodec: allow Wuffs versions >= v0.3.1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-15 01:43:17 +00:00
Michael Goderbauer
40c304099d Move ViewConfiguration ownership to FlutterView (flutter/engine#43701) 
This makes the FlutterView object a little bit less brittle by not depending on the PlatformDispatcher so much.
 2023-07-15 01:21:09 +00:00
Yegor
7413bfb203 [web] always add secondary role managers (flutter/engine#43663) 
Always add secondary role managers irrespective of the initial state of the semantic node, and have role manager decide whether it applies to the node or not.

Fixes https://github.com/flutter/flutter/issues/130546
 2023-07-14 23:59:04 +00:00
Dan Field
6c1b2e158b [Impeller] Fix text scaling issues again, this time with perspective when a save layer is involved (flutter/engine#43695) 
Alternative to https://github.com/flutter/engine/pull/43662

Records the basis vector of the current CTM into text contents and reuses that rather than trying to get it again at render time. That method breaks if perspective is involved in the CTM and a subpass gets translated, which can modify the scale (and rotation) of the matrix.

We're definitely not doing things quite right with perspective here, but the real fix to that is to either record the fully transformed glyph into the atlas or to use SDF/path based rendering.

Fixes https://github.com/flutter/flutter/issues/130476

I still have some concerns about how `EntityPass::Render` is a mix of mutations and constness but we can try to address that independently. 

I expect this to re-improve the regression noted in https://github.com/flutter/flutter/issues/130594
 2023-07-14 22:41:02 +00:00
Jim Graham
405d8ce369 Reland "add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#43698) 
Fixes https://github.com/flutter/flutter/issues/129862

This reverts commit cd52c0ce82b37bc9d16bea26fbd1753174c49e42.

These changes were exposing an underlying bug in the DisplayListMatrixClipTracker that has now been fixed independently (https://github.com/flutter/engine/pull/43664). There are no changes to the commit being relanded here, it has been tested on the Wondrous app which demonstrated the regression before the NOP culling feature was reverted and it now works fine due to the fix of the underlying cause.
 2023-07-14 22:34:50 +00:00
skia-flutter-autoroll
b29cefd205 Roll Skia from 5f6578398870 to 271b2b6d5aaa (2 revisions) (flutter/engine#43706) 
https://skia.googlesource.com/skia.git/+log/5f6578398870..271b2b6d5aaa

2023-07-14 kjlubick@google.com Add forgotten more drawMesh implementations
2023-07-14 johnstiles@google.com Add GM slide demonstrating ripple effect.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 22:33:04 +00:00
Jonah Williams
4698c6b307 [Impeller] Ensure that missing color attachment 0u does not cause crash in embedder API (flutter/engine#43705) 
https://github.com/flutter/flutter/issues/130619
 2023-07-14 22:17:56 +00:00
skia-flutter-autoroll
389b81e4ac Roll Skia from 315c7f08c731 to 5f6578398870 (4 revisions) (flutter/engine#43704) 
https://skia.googlesource.com/skia.git/+log/315c7f08c731..5f6578398870

2023-07-14 jvanverth@google.com [graphite] Add Vulkan wrapped texture support
2023-07-14 kjlubick@google.com Decouple SkMesh from Ganesh backend
2023-07-14 kjlubick@google.com Remove #ifdefs related to SkMesh and SkSL-dependent code.
2023-07-14 kjlubick@google.com Remove unnecessary #include in SkFloatingPoint.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 21:49:05 +00:00
Jonah Williams
7c5060aa68 [Impeller] defer construction of VkCommandBuffer until encoding begins. (flutter/engine#43605) 
VkCommandBuffers are allocated out of a thread local VkCommandPool. THis command buffer is only safe to use on the thread which allocates it.

We'd like to attempt concurrent encoding on Vulkan like we've done for iOS, which means the worker threads will be accessing the VkCommandBuffer. In order for this to be safe, the VkCommandBuffer must be allocated out of a VkCommandPool from that worker thread. As a simple fix, we make the Impeller CommandBuffer defer construction of the VkCommandBuffer object, allowing us to record impeller commands on the raster thread, move the command buffer to a worker thread, create the VkCommandBuffer, and then begin encoding.
 2023-07-14 21:21:02 +00:00
skia-flutter-autoroll
034b8c01fe Roll Fuchsia Linux SDK from LZPMbHnVPFdbXndcX... to DEENqWMCYI1SMYsYH... (flutter/engine#43702) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 21:18:57 +00:00
Kevin Lubick
bdc24b3d18 Remove calls to SkCanvas::flush() (flutter/engine#43684) 
In https://skia-review.googlesource.com/c/skia/+/716476, Skia removed
calls to SkCanvas::flush(). This replaces those calls that Flutter was
making with what had been going on - calling GrDirectContext::flush() if
the canvas was backed by a Ganesh backend. Raster-backed canvases did
not need flushing.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-07-14 16:34:22 -04:00
skia-flutter-autoroll
7dcc10184a Roll Skia from c14fda1cb615 to 315c7f08c731 (3 revisions) (flutter/engine#43700) 
https://skia.googlesource.com/skia.git/+log/c14fda1cb615..315c7f08c731

2023-07-14 johnstiles@google.com Add RippleShader runtime shader to our test corpus.
2023-07-14 michaelludwig@google.com [graphite] Fix bounds used to order clip draws
2023-07-14 johnstiles@google.com Another fix for Clang format-specifier warning.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 20:33:19 +00:00
Jonah Williams
672ca7c24e [Impeller] remove requests for dedicated allocations. (flutter/engine#43686) 
This change never improved performance (in fact I think it regressed it slightly), so lets revert it and see if things change.
 2023-07-14 18:43:02 +00:00
skia-flutter-autoroll
6900920705 Roll Dart SDK from 3701605e0abf to d1fcadf22aad (1 revision) (flutter/engine#43692) 
https://dart.googlesource.com/sdk.git/+log/3701605e0abf..d1fcadf22aad

2023-07-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-312.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 18:12:05 +00:00
Jason Simmons
9196510ed8 More fixes for the new clang-tidy roll on iOS targets (flutter/engine#43688) 
See https://github.com/flutter/engine/pull/43661
 2023-07-14 17:44:52 +00:00
Kevin Lubick
27192d3743 Add missing Skia #includes (flutter/engine#43680) 
When trying to land
https://skia-review.googlesource.com/c/skia/+/721978, I ran into some
issues where Flutter was transitively depending on some Skia headers.
This adds those explicitly to the necessary files.

I noticed a few of these were missing from dl_sk_types.h (i.e. they were
referenced in dl_sk_conversions.h, but not included in dl_sk_types.h),
so I added them in.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-07-14 13:29:39 -04:00
skia-flutter-autoroll
72ed127c92 Roll Skia from de6099518f90 to c14fda1cb615 (1 revision) (flutter/engine#43689) 
https://skia.googlesource.com/skia.git/+log/de6099518f90..c14fda1cb615

2023-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e1b8f324086e to fcbe6bbcf4a8 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 17:23:06 +00:00
Jim Graham
d4c1a9b6ee Fix DisplayListMatrixClipTracker handling of diff clips (flutter/engine#43664) 
Fixes root cause for https://github.com/flutter/flutter/issues/129816

Logic for reducing the cull_rect for a diff clip had a number of errors. The new test should cover all cases.
 2023-07-14 17:14:15 +00:00
skia-flutter-autoroll
fd24060357 Roll Skia from b4b9c76206f3 to de6099518f90 (4 revisions) (flutter/engine#43687) 
https://skia.googlesource.com/skia.git/+log/b4b9c76206f3..de6099518f90

2023-07-14 robertphillips@google.com Roll Vulkan Memory Allocator to v3.0.1
2023-07-14 johnstiles@google.com Fix format specifier for backend enum.
2023-07-14 jvanverth@google.com [graphite] Add Vulkan semaphore support.
2023-07-14 kjlubick@google.com Move most of the Ganesh-specific logic out of SkSpecialImage.cpp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 16:45:53 +00:00
skia-flutter-autoroll
a5be79cd52 Roll Fuchsia Mac SDK from J0oxaSt651gKgDreU... to Z-1lzZAOYHvVrdjQ8... (flutter/engine#43685) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 16:12:18 +00:00
skia-flutter-autoroll
b66abab13c Roll Skia from 7990401d716a to b4b9c76206f3 (1 revision) (flutter/engine#43681) 
https://skia.googlesource.com/skia.git/+log/7990401d716a..b4b9c76206f3

2023-07-14 johnstiles@google.com Reland "Fix swizzled compound assignment with lvalue side-effects in Metal."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 14:41:10 +00:00
skia-flutter-autoroll
5bbfa363d3 Roll Dart SDK from 8e4eac435b49 to 3701605e0abf (1 revision) (flutter/engine#43679) 
https://dart.googlesource.com/sdk.git/+log/8e4eac435b49..3701605e0abf

2023-07-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-311.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 14:20:07 +00:00
skia-flutter-autoroll
037ef5f81e Roll Skia from 8192de1efc1b to 7990401d716a (1 revision) (flutter/engine#43678) 
https://skia.googlesource.com/skia.git/+log/8192de1efc1b..7990401d716a

2023-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 845e8105edb3 to e8bb3adbe077

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 12:31:31 +00:00
Martin Kustermann
0e369e0e4e Use utf8.encode() instead of longer const Utf8Encoder.convert() (flutter/engine#43675) 
The change in [0] has propagated now everywhere, so we can use 
`utf8.encode()` instead of the longer `const Utf8Encoder.convert()`.

Also it cleans up code like

```
  Uint8List bytes;
  bytes.buffer.asByteData();
```

as that is not guaranteed to be correct, the correct version would be

```
  Uint8List bytes;
  bytes.buffer.asByteData(bytes.offsetInBytes, bytes.length);
```

a shorter hand for that is:

```
  Uint8List bytes;
  ByteData.sublistView(bytes);
```

[0] https://github.com/dart-lang/sdk/issues/52801
 2023-07-14 13:44:54 +02:00
skia-flutter-autoroll
53b9d2172b Roll Skia from 2848267f631d to 8192de1efc1b (1 revision) (flutter/engine#43672) 
https://skia.googlesource.com/skia.git/+log/2848267f631d..8192de1efc1b

2023-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8ae9f28d7af2 to 6ffd0d20684d (22 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 06:20:02 +00:00
skia-flutter-autoroll
7c472f4779 Roll Dart SDK from 8f49edfb6989 to 8e4eac435b49 (1 revision) (flutter/engine#43671) 
https://dart.googlesource.com/sdk.git/+log/8f49edfb6989..8e4eac435b49

2023-07-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-310.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 05:49:04 +00:00
skia-flutter-autoroll
f686a37e84 Roll Skia from ffed127e8974 to 2848267f631d (3 revisions) (flutter/engine#43670) 
https://skia.googlesource.com/skia.git/+log/ffed127e8974..2848267f631d

2023-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 7a6604d0564b to eb355bb3edcf (21 revisions)
2023-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c7cba4b06eab to 845e8105edb3 (8 revisions)
2023-07-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ad8a66bf7d69 to e1b8f324086e (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 05:41:04 +00:00
skia-flutter-autoroll
3cc1a574a4 Roll Fuchsia Linux SDK from -csWUV7Dv3hETOoDw... to LZPMbHnVPFdbXndcX... (flutter/engine#43669) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 05:37:22 +00:00
skia-flutter-autoroll
f2b24ac444 Roll Fuchsia Mac SDK from rRUd41Mv9NI0n3Iyc... to J0oxaSt651gKgDreU... (flutter/engine#43667) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 03:21:49 +00:00
skia-flutter-autoroll
b360d27007 Roll Skia from 9e4f5cc3aeb4 to ffed127e8974 (1 revision) (flutter/engine#43666) 
https://skia.googlesource.com/skia.git/+log/9e4f5cc3aeb4..ffed127e8974

2023-07-14 johnstiles@google.com Revert "Fix swizzled compound assignment with lvalue side-effects in Metal."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 03:15:01 +00:00
skia-flutter-autoroll
3c72cf65d9 Roll Dart SDK from 9506d0c9f5ef to 8f49edfb6989 (1 revision) (flutter/engine#43665) 
https://dart.googlesource.com/sdk.git/+log/9506d0c9f5ef..8f49edfb6989

2023-07-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-309.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-14 02:10:51 +00:00
Ian Hickson
34c0f686c5 Add more points to [MediaQuery]. (flutter/engine#43649) 
See https://github.com/flutter/flutter/issues/11697
 2023-07-14 00:34:14 +00:00
Ian Hickson
1ca3a2c32a Remove unimplemented API call saveCompilationTrace (flutter/engine#43656) 
Fixes https://github.com/flutter/flutter/issues/59205
 2023-07-14 00:34:12 +00:00
Jason Simmons
db4c5360bf Fix a clang-tidy warning about a potentially nil value in the editingState dictionary (flutter/engine#43660) 2023-07-13 23:09:26 +00:00
skia-flutter-autoroll
417cee5b50 Roll Skia from 52613fcc0780 to 9e4f5cc3aeb4 (1 revision) (flutter/engine#43659) 
https://skia.googlesource.com/skia.git/+log/52613fcc0780..9e4f5cc3aeb4

2023-07-13 johnstiles@google.com Fix WGSL codegen for compound assignment with swizzles.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 22:53:48 +00:00
Jonah Williams
70c3a7f8d3 [Impeller] no-op fragment program on Android until it works. (flutter/engine#43657) 
The framework has switched into mat3 by default, which means the fragment program ink sparkle has replaced the default ink splash. Since this is not implemented, all of the impeller benchmarks are crashign.

No-op this so we at least get benchmark numbers until its implemented.
 2023-07-13 22:43:16 +00:00
LongCatIsLooong
b7472f9a45 Reland #43118 "Add a flag to ParagraphBuilder for rounding hack migration" (flutter/engine#43647) 
real diff: aedc37a3e0

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-13 22:30:32 +00:00
Chris Yang
4e696fc84d Unmerge threads if the current merger is the only one that's merged. (flutter/engine#43652) 
`UnMergeNowIfLastOne` is called during shell destruction. When there are other shells with threads unmerged and the current destroying shell with thread merged. `UnMergeNowIfLastOne` should unmerge the threads. 

This PR Make `UnMergeNowIfLastOne` not only unmerge if the current merger is the last merger, but also unmerge if the current merger is the last merger that is merged.

Fixes https://github.com/flutter/flutter/issues/127168

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-13 22:17:21 +00:00
Dan Field
6fdde7e901 Revert https://github.com/flutter/engine/pull/43533 (flutter/engine#43654) 
Reverts  https://github.com/flutter/engine/pull/43533
Cause of https://github.com/flutter/flutter/issues/130476

I was trying to add a test for this but it's taking me a while to get a working test so here's the revert.
 2023-07-13 22:13:45 +00:00
skia-flutter-autoroll
b69b3b6f9e Roll Skia from 743ad92f5de2 to 52613fcc0780 (9 revisions) (flutter/engine#43655) 
https://skia.googlesource.com/skia.git/+log/743ad92f5de2..52613fcc0780

2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for GL/Ganesh.
2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for specifying a config via --config.
2023-07-13 johnstiles@google.com Fix swizzled compound assignment with lvalue side-effects in Metal.
2023-07-13 johnstiles@google.com Ensure index-substitution expressions are initialized before use.
2023-07-13 brianosman@google.com Remove SkOpts_skx.cpp completely
2023-07-13 ayzhao@google.com Fix some missing C++ standard library includes
2023-07-13 robertphillips@google.com Merge Ganesh and Graphite TiledTextureUtils::DrawImageRect implementations
2023-07-13 robertphillips@google.com Switch DrawImageRect_Ganesh to work at the SkCanvas level
2023-07-13 johnstiles@google.com Add unit test for lvalue side-effects in swizzled compound assignment.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 22:05:37 +00:00
Jason Simmons
4f384979af Fix a Fuchsia formatter type mismatch flagged by the pending Clang roll (flutter/engine#43651) 2023-07-13 20:13:55 +00:00
skia-flutter-autoroll
036fbf256d Roll Dart SDK from 16ddfe8d08e0 to 9506d0c9f5ef (1 revision) (flutter/engine#43646) 
https://dart.googlesource.com/sdk.git/+log/16ddfe8d08e0..9506d0c9f5ef

2023-07-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-308.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 18:41:54 +00:00