Xilai Zhang
d4b4f3e830
[flutter roll] Revert "ios: remove shared_application and support app extension build" ( flutter/engine#45250 )
...
Reverts flutter/engine#44732
context: b/297654739
Synced with Chris and the error message is related to the PR
2023-08-29 23:15:04 +00:00
skia-flutter-autoroll
0293da1f4c
Roll Skia from 8a2754a1ae60 to e6eb56d9b074 (3 revisions) ( flutter/engine#45248 )
...
https://skia.googlesource.com/skia.git/+log/8a2754a1ae60..e6eb56d9b074
2023-08-29 johnstiles@google.com Add paint-params key info to Shaders pane in Viewer.
2023-08-29 lovisolo@google.com [bazel] bazel_test_gm.go task driver: Upload PNGs to Gold.
2023-08-29 robertphillips@google.com Split the skif::Context's Functors out into their own object
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 23:09:44 +00:00
Matan Lurey
b3bb59e4b5
Refactor Stopwatch into StopwatchVisualizer and SkStopwatchVisualizer ( flutter/engine#45200 )
...
Partial work towards https://github.com/flutter/flutter/issues/126009 .
Still working as before:
<img width="1210" alt="Screenshot 2023-08-28 at 6 32 45 PM"
src="https://github.com/flutter/engine/assets/168174/38728015-d0d4-4933-bd31-d2326c76aeee ">
(There are some `PerformanceOverlayLayerDefault.*` tests that don't run
locally, so I guess I'll let CI run those)
2023-08-29 16:04:22 -07:00
Zachary Anderson
9ea8a110c7
Roll buildroot ( flutter/engine#45249 )
...
To pick up https://github.com/flutter/buildroot/pull/757 , which makes some sysroot paths relative.
2023-08-29 23:03:49 +00:00
Brandon DeRosier
2ec44fd6ce
[Impeller] Add GetDefaultDepthStencil to capabilities. ( flutter/engine#45240 )
...
Resolves https://github.com/flutter/flutter/issues/133194 .
And use it for building the Impeller Scene pipelines.
2023-08-29 23:03:46 +00:00
skia-flutter-autoroll
012104fa6a
Roll Dart SDK from a4e0e792ef9a to 0cea73a8d3c3 (1 revision) ( flutter/engine#45245 )
...
https://dart.googlesource.com/sdk.git/+log/a4e0e792ef9a..0cea73a8d3c3
2023-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-122.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 21:48:53 +00:00
Brandon DeRosier
c4be226879
[Impeller] Remove unused HasThreadingRestrictions capability. ( flutter/engine#45242 )
...
Noticed this while working through documenting all of the capabilities.
I guess we don't need this one anymore?
2023-08-29 14:29:59 -07:00
skia-flutter-autoroll
c2c776faa7
Roll Skia from fb09020ce62d to 8a2754a1ae60 (6 revisions) ( flutter/engine#45241 )
...
https://skia.googlesource.com/skia.git/+log/fb09020ce62d..8a2754a1ae60
2023-08-29 bungeman@google.com Fix Paragraph6 Sample
2023-08-29 michaelludwig@google.com Bucket 2D blur effects based on radius
2023-08-29 brianosman@google.com Migrate deprecated Vk GrBackendSurface related functions in AHB helpers
2023-08-29 jvanverth@google.com Disable yet more AsyncReadPixels tests
2023-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5857bae969d5 to 356ddfc69865 (8 revisions)
2023-08-29 fmalita@chromium.org [skottie] Move text editor sources to utils
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 21:27:54 +00:00
chunhtai
c667836eeb
[Impeller] Update xcode_frame_capture.md ( flutter/engine#45230 )
...
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-29 21:16:34 +00:00
yaakovschectman
292ac863fe
Update documentation for updater callback. ( flutter/engine#45239 )
...
Fix a mistake in the documentation regarding the thread on which the
channel update callback is called.
https://github.com/flutter/flutter/issues/131616
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-29 17:04:19 -04:00
yaakovschectman
e2908808b6
Add callback to Embedder API to respond to new channel listeners, and use for Windows lifecycle ( flutter/engine#44827 )
...
Supplant the temporary solution
https://github.com/flutter/engine/pull/44238 with a more elegant
solution with am embedder API callback. The windows engine provides a
callback that enables graceful exit and app lifecycle when the platform
and lifecycle channels are listened to, respectively.
https://github.com/flutter/flutter/issues/131616
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Chris Bracken <chris@bracken.jp>
2023-08-29 16:12:35 -04:00
skia-flutter-autoroll
2e8e99e339
Roll Skia from 15de7f9c3b3b to fb09020ce62d (3 revisions) ( flutter/engine#45233 )
...
https://skia.googlesource.com/skia.git/+log/15de7f9c3b3b..fb09020ce62d
2023-08-29 lovisolo@google.com [bazel] Add Bazel-only GM for testing purposes.
2023-08-29 bungeman@google.com Remove SK_IGNORE_COLRV1_GRADIENT_COLORSPACE_FIX
2023-08-29 drott@chromium.org [Fontations] Move wrappers to sk_fontations namespace
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 18:44:22 +00:00
Matan Lurey
69fd1ebf92
Use runIfNot: ... to avoid running Fuchsia try-jobs for some changes. ( flutter/engine#45134 )
...
Closes https://github.com/flutter/flutter/issues/93261 .
I probably could have been more clever with a regular-expression but
this seems easier to read.
---------
Co-authored-by: godofredoc <godofredoc@google.com>
2023-08-29 11:34:14 -07:00
Zachary Anderson
f127ba2c14
Clean up engine repo Dart code ( flutter/engine#45203 )
...
Also adds a test to ensure that all packages are accounted for.
2023-08-29 11:19:42 -07:00
skia-flutter-autoroll
58cf45060f
Roll Skia from b7e826d5324f to 15de7f9c3b3b (3 revisions) ( flutter/engine#45231 )
...
https://skia.googlesource.com/skia.git/+log/b7e826d5324f..15de7f9c3b3b
2023-08-29 bungeman@google.com Roll HarfBuzz from f94508ed to f380a328 (164 commits)
2023-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from d5998642c25b to 3e2b0ed75e49
2023-08-29 michaelludwig@google.com Reland "[skif] Add FilterResult::Builder::blur() to wrap per-backend blur impls"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 17:52:22 +00:00
Jonah Williams
283b68440b
[Impeller] its not safe to presentWithTransaction from a background thread. ( flutter/engine#45182 )
...
Sad Trombone. Because Flutter runs from a background thread, if we touch a CATransaction while there is a main thread transaction occuring then we'll trigger a framework error.
Fixes https://github.com/flutter/flutter/issues/133147
2023-08-29 17:34:14 +00:00
skia-flutter-autoroll
f618d4b1cf
Roll Skia from b0c1b2868129 to b7e826d5324f (4 revisions) ( flutter/engine#45229 )
...
https://skia.googlesource.com/skia.git/+log/b0c1b2868129..b7e826d5324f
2023-08-29 michaelludwig@google.com [skif] Update testing-only matrix validation image filter to new API
2023-08-29 bungeman@google.com Roll FreeType from 5769f13a to 2d9fce53 (22 commits)
2023-08-29 drott@chromium.org [Fontations] Simplify glyph path based on overlap flag, sanitize paths
2023-08-29 kjlubick@google.com Enforce IWYU on SkResourceCache etc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 16:55:59 +00:00
skia-flutter-autoroll
5021a9123b
Roll Skia from 4048262b9b21 to b0c1b2868129 (2 revisions) ( flutter/engine#45227 )
...
https://skia.googlesource.com/skia.git/+log/4048262b9b21..b0c1b2868129
2023-08-29 kjlubick@google.com One more SkSwizzlePriv change
2023-08-29 jamesgk@google.com [graphite] Account for coverage when deciding to do in-shader blending
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 16:11:20 +00:00
Mouad Debbar
e2e1b979c4
[web] Make devicePixelRatio ready for multi-view ( flutter/engine#44783 )
...
This PR moves the source of truth for`devicePixelRatio` to the `EngineFlutterDisplay` singleton.
Main things that this PR is trying to do:
- `EngineFlutterDisplay` is a singleton that represents information about the display.
- The `devicePixelRatio` can be overriden in tests.
- The `browserDevicePixelRatio` gets the value directly from the browser and can't be overriden.
- Remove `EngineSingletonFlutterWindow` and incorporate it into `EngineFlutterWindow`.
2023-08-29 15:51:05 +00:00
skia-flutter-autoroll
bf6f6b6b80
Roll Skia from 7675f886f884 to 4048262b9b21 (2 revisions) ( flutter/engine#45225 )
...
https://skia.googlesource.com/skia.git/+log/7675f886f884..4048262b9b21
2023-08-29 jvanverth@google.com [graphite] Move contents of ImageUtils to TextureUtils.
2023-08-29 kjlubick@google.com Move SkOpts things around for easier modularization
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 15:23:53 +00:00
skia-flutter-autoroll
e13add979c
Roll Skia from 85377eca700d to 7675f886f884 (7 revisions) ( flutter/engine#45224 )
...
https://skia.googlesource.com/skia.git/+log/85377eca700d..7675f886f884
2023-08-29 michaelludwig@google.com Revert "[skif] Add FilterResult::Builder::blur() to wrap per-backend blur impls"
2023-08-29 jvanverth@google.com Some minor readPixels cleanups.
2023-08-29 jvanverth@google.com Re-enable *AsyncReadPixels on Adreno GL.
2023-08-29 johnstiles@google.com Reland "Pass colorspace-transform coefficients in a 4x4 matrix."
2023-08-29 robertphillips@google.com Consolidate onCreateFilterContext implementations
2023-08-29 michaelludwig@google.com [skif] Update testing-only PDF image filter to new API
2023-08-29 michaelludwig@google.com [skif] Add FilterResult::Builder::blur() to wrap per-backend blur impls
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 14:37:22 +00:00
skia-flutter-autoroll
dd9f324581
Roll Dart SDK from 70066300aa83 to a4e0e792ef9a (1 revision) ( flutter/engine#45221 )
...
https://dart.googlesource.com/sdk.git/+log/70066300aa83..a4e0e792ef9a
2023-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-121.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 13:56:59 +00:00
skia-flutter-autoroll
4f708ce2cb
Roll Fuchsia Mac SDK from 68DESTl_q6I45UJyb... to QKekosWnIY_ObKstn... ( flutter/engine#45217 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 12:55:05 +00:00
skia-flutter-autoroll
7e822bf78b
Roll Fuchsia Linux SDK from Ys38QMyFZToJxnXrF... to z9uQ0mXwjKFQF05Xl... ( flutter/engine#45216 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 12:33:33 +00:00
skia-flutter-autoroll
b0bc7d08de
Roll Skia from e9e4d0dacc9d to 85377eca700d (1 revision) ( flutter/engine#45215 )
...
https://skia.googlesource.com/skia.git/+log/e9e4d0dacc9d..85377eca700d
2023-08-29 drott@chromium.org [Fontations] Roll Fontations libraries
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 12:18:15 +00:00
skia-flutter-autoroll
5f6f4b6bac
Roll Skia from 5dd678aebdaf to e9e4d0dacc9d (1 revision) ( flutter/engine#45214 )
...
https://skia.googlesource.com/skia.git/+log/5dd678aebdaf..e9e4d0dacc9d
2023-08-29 johnstiles@google.com Use #if defined(GRAPHITE_TEST_UTILS) to check if enabled.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 11:40:33 +00:00
skia-flutter-autoroll
fd1f8295fa
Roll Dart SDK from f6c11801db41 to 70066300aa83 (1 revision) ( flutter/engine#45212 )
...
https://dart.googlesource.com/sdk.git/+log/f6c11801db41..70066300aa83
2023-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-120.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 10:19:37 +00:00
skia-flutter-autoroll
298e243162
Roll Skia from 01ee493cc113 to 5dd678aebdaf (1 revision) ( flutter/engine#45210 )
...
https://skia.googlesource.com/skia.git/+log/01ee493cc113..5dd678aebdaf
2023-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6587ca5b6e44 to d779093a7a96 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 09:10:05 +00:00
skia-flutter-autoroll
59e51bf7f2
Roll Skia from f576668bfe99 to 01ee493cc113 (1 revision) ( flutter/engine#45208 )
...
https://skia.googlesource.com/skia.git/+log/f576668bfe99..01ee493cc113
2023-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 57388ab2e24d to d6fd7eafb2f7 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 07:27:19 +00:00
Wu Zhong
5c3efc3707
[iOS] Don't call App lifecycle resumed when device is locked ( flutter/engine#44947 )
...
Fixed https://github.com/flutter/flutter/issues/130055 .
We can cancel the `resumed` life cycle notification if we received `inactive` notification in the same runloop.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-29 06:59:05 +00:00
skia-flutter-autoroll
1dd53f28b5
Roll Dart SDK from 60a3bb84fa6d to f6c11801db41 (1 revision) ( flutter/engine#45207 )
...
https://dart.googlesource.com/sdk.git/+log/60a3bb84fa6d..f6c11801db41
2023-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-119.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 06:39:06 +00:00
skia-flutter-autoroll
0dfe5a3ec4
Roll Skia from b27fecd52899 to f576668bfe99 (1 revision) ( flutter/engine#45206 )
...
https://skia.googlesource.com/skia.git/+log/b27fecd52899..f576668bfe99
2023-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b847b1b89c33 to 5857bae969d5 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 06:33:04 +00:00
dependabot[bot]
d2c0b5ae7b
Bump actions/checkout from 3.5.3 to 3.6.0 ( flutter/engine#45205 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.5.3 to 3.6.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases ">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v3.6.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Mark test scripts with Bash'isms to be run via Bash by <a href="https://github.com/dscho "><code>@âdscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1377 ">actions/checkout#1377</a></li>
<li>Add option to fetch tags even if fetch-depth > 0 by <a href="https://github.com/RobertWieczoreck "><code>@âRobertWieczoreck</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/579 ">actions/checkout#579</a></li>
<li>Release 3.6.0 by <a href="https://github.com/luketomlinson "><code>@âluketomlinson</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1437 ">actions/checkout#1437</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/RobertWieczoreck "><code>@âRobertWieczoreck</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/579 ">actions/checkout#579</a></li>
<li><a href="https://github.com/luketomlinson "><code>@âluketomlinson</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1437 ">actions/checkout#1437</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3.5.3...v3.6.0 ">https://github.com/actions/checkout/compare/v3.5.3...v3.6.0 </a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md ">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1377 ">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/579 ">Add option to fetch tags even if fetch-depth > 0</a></li>
</ul>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1196 ">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1287 ">Fix typos found by codespell</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1369 ">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1289 ">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1246 ">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1237 ">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1209 ">Upgrade codeql actions to v2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1210 ">Upgrade dependencies</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1225 ">Upgrade <code>@âactions/io</code></a></li>
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1045 ">Implement branch list using callbacks from exec function</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1050 ">Add in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770 ">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057 ">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/942 ">Add GitHub Action to perform release</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/967 ">Fix status badge</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1002 ">Replace datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/964 ">Wrap pipeline commands for submoduleForeach in quotes</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1029 ">Update <code>@âactions/io</code> to 1.1.2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1039 ">Upgrading version to 3.2.0</a></li>
</ul>
<h2>v3.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/939 ">Use <code>@âactions/core</code> <code>saveState</code> and <code>getState</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/922 ">Add <code>github-server-url</code> input</a></li>
</ul>
<h2>v3.0.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/770 ">Add input <code>set-safe-directory</code></a></li>
</ul>
<h2>v3.0.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/762 ">Fixed an issue where checkout failed to run in container jobs due to the new git setting <code>safe.directory</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/744 ">Bumped various npm package versions</a></li>
</ul>
<h2>v3.0.0</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="f43a0e5ff2 "><code>f43a0e5</code></a> Release 3.6.0 (<a href="https://redirect.github.com/actions/checkout/issues/1437 ">#1437</a>)</li>
<li><a href="7739b9ba2e "><code>7739b9b</code></a> Add option to fetch tags even if fetch-depth > 0 (<a href="https://redirect.github.com/actions/checkout/issues/579 ">#579</a>)</li>
<li><a href="96f53100ba "><code>96f5310</code></a> Mark test scripts with Bash'isms to be run via Bash (<a href="https://redirect.github.com/actions/checkout/issues/1377 ">#1377</a>)</li>
<li>See full diff in <a href="c85c95e3d7...f43a0e5ff2 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-08-29 06:00:08 +00:00
skia-flutter-autoroll
9eef957ff6
Roll Skia from 66e367b12e96 to b27fecd52899 (1 revision) ( flutter/engine#45204 )
...
https://skia.googlesource.com/skia.git/+log/66e367b12e96..b27fecd52899
2023-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d779093a7a96 to 9f1fad0fdc31
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 05:51:17 +00:00
skia-flutter-autoroll
34740db344
Roll Dart SDK from 2900ad211f38 to 60a3bb84fa6d (1 revision) ( flutter/engine#45201 )
...
https://dart.googlesource.com/sdk.git/+log/2900ad211f38..60a3bb84fa6d
2023-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-118.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 03:02:35 +00:00
Matan Lurey
b5eb6ab69a
A minimal engine_tools_lib to use for local-repo Dart tooling ( flutter/engine#45154 )
...
Partial work towards re-landing #44936 .
Both the `clang_tidy` and `githooks` passage could benefit from being
able to automatically find the latest `compile_commands.json` output,
which means that some common code should exist in the `tools/`
directory.
This is a very minimal (but tested) library for doing exactly that.
2023-08-28 19:25:56 -07:00
Jackson Gardner
4552f351b3
Fix scene view canvas/platform view placement. ( flutter/engine#45199 )
...
I wasn't adjusting the `left` and `top` css styles based on the device pixel ratio. This fixes that and also sets up unit tests for `SceneView`.
2023-08-29 01:43:07 +00:00
skia-flutter-autoroll
76d4ed070d
Roll Fuchsia Mac SDK from u44zzvYd85WSDMpS3... to 68DESTl_q6I45UJyb... ( flutter/engine#45197 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 00:15:27 +00:00
Matan Lurey
5ce3aadec1
Rename instrumentation to stopwatch ( flutter/engine#45196 )
...
... since that's what the code is/does.
Partial work towards https://github.com/flutter/flutter/issues/126009 .
2023-08-28 17:11:49 -07:00
Jonah Williams
199e8abb3f
[Impeller] Sync presentation when rendering into FlutterImageView. ( flutter/engine#44881 )
...
Fixes https://github.com/flutter/flutter/issues/131730
When the Android embedder starts rendering into a FlutterImageView, notify the Impeller context to block on submitKHR.
2023-08-29 00:00:54 +00:00
skia-flutter-autoroll
a62803495b
Roll Fuchsia Linux SDK from AQZddYgKiWrQL8vny... to Ys38QMyFZToJxnXrF... ( flutter/engine#45195 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-28 23:45:59 +00:00
Jackson Gardner
fd9e7e8e8f
[skwasm] encode PNGs using browser APIs ( flutter/engine#45187 )
...
This allows us to remove libpng from skia entirely, which saves us about 25kb brotli compressed.
Note, this should not change any functionality. The existing functionality is covered by the unit tests here: bfcb9d08e8/lib/web_ui/test/ui/image_golden_test.dart (L197-L197)
2023-08-28 23:08:46 +00:00
skia-flutter-autoroll
bbc8869c1c
Roll Dart SDK from 5d3ab5db5037 to 2900ad211f38 (3 revisions) ( flutter/engine#45192 )
...
https://dart.googlesource.com/sdk.git/+log/5d3ab5db5037..2900ad211f38
2023-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-117.0.dev
2023-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-116.0.dev
2023-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-115.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-28 22:40:01 +00:00
skia-flutter-autoroll
bfcb9d08e8
Roll Skia from 335f748463db to 66e367b12e96 (1 revision) ( flutter/engine#45189 )
...
https://skia.googlesource.com/skia.git/+log/335f748463db..66e367b12e96
2023-08-28 johnstiles@google.com Change extraneous sampler/texture check to an assertion.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-28 22:20:47 +00:00
Jonah Williams
089cb17e97
[Impeller] Cache Skia text bounds computation. ( flutter/engine#45150 )
...
Fixes https://github.com/flutter/flutter/issues/133388
Just use the TextBounds that Skia gives us. These are slightly larger but already computed. If the larger bounds are a problem we can go back to Impeller computed bounds, but using a cached computation.
### Skia

### Impeller

2023-08-28 21:49:41 +00:00
skia-flutter-autoroll
ec6964204d
Roll Skia from 83f6fbad8a38 to 335f748463db (1 revision) ( flutter/engine#45186 )
...
https://skia.googlesource.com/skia.git/+log/83f6fbad8a38..335f748463db
2023-08-28 johnstiles@google.com Fix loop-unrolling for single-iteration inclusive reverse loops.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-28 21:33:04 +00:00
Matan Lurey
fd931a48e5
Explain how to update the embedder/fixtures golden outputs. ( flutter/engine#45184 )
...
Closes https://github.com/flutter/flutter/issues/133375 .
2023-08-28 20:54:43 +00:00
skia-flutter-autoroll
5f2a0a7679
Roll Skia from ded5d08a9999 to 83f6fbad8a38 (1 revision) ( flutter/engine#45183 )
...
https://skia.googlesource.com/skia.git/+log/ded5d08a9999..83f6fbad8a38
2023-08-28 bungeman@google.com Specify COLRv1 gradient interpolation
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-28 20:30:20 +00:00
Jonah Williams
e4d3c07fa5
[Impeller] Simplify color source + text with new Skia API. ( flutter/engine#45090 )
...
The original implementation of arbitrary color source + text was quite complicated due to the fact that I had to use blending to emulate this functionality. Now that we can get paths from a given text data, I can instead make non solid color color sources and text just use the regular geometry + color source pipelines.
Fixes https://github.com/flutter/flutter/issues/132928
Fixes https://github.com/flutter/flutter/issues/132972
2023-08-28 20:15:04 +00:00
Matan Lurey
254401dca0
Re-write docs for DlSkCanvas{Adapter|Dispatcher}. ( flutter/engine#44961 )
...
Closes https://github.com/flutter/flutter/issues/132994 .
I suspect this is imperfect, so please suggest any changes or additions (either using GitHub's tooling or as a review comment).
/cc @dnfield
2023-08-28 20:06:14 +00:00