682 Commits

Author SHA1 Message Date
Ben Konyi
d3f45828bf Reland "Remove references to Observatory (#38919)" (flutter/engine#39139)
This reverts commit 5dd945442b230a2c0549ee6d798fda71e031a4a9.
2023-01-30 09:50:09 -05:00
Miguel
f1bbb90589 [fuchsia] Diagnostics directory rights are R* (flutter/engine#39203) 2023-01-27 17:44:24 -05:00
Tamir Duberstein
15f53d515e [fuchsia] Migrate to new RealmBuilder API (flutter/engine#39205)
See https://fxrev.dev/793422.

Missed in 92fca42e0667969b3a78815c77afca9c6acd1c83,
3bfa5c5b1db5391d49cc58f9a23f1b4cd802d3e3 and
d429b674f1dd60590fda077fd893a4493c2b5455.
2023-01-27 15:42:15 -05:00
Tamir Duberstein
d429b674f1 [fuchsia] Migrate to new RealmBuilder API (flutter/engine#39196)
See https://fxrev.dev/793422.

Missed in 92fca42e0667969b3a78815c77afca9c6acd1c83 and
3bfa5c5b1db5391d49cc58f9a23f1b4cd802d3e3.
2023-01-27 13:01:28 -05:00
Tamir Duberstein
3bfa5c5b1d [fuchsia] Migrate to new RealmBuilder API (flutter/engine#39175)
See https://fxrev.dev/793422.

Missed in 92fca42e0667969b3a78815c77afca9c6acd1c83.
2023-01-26 17:54:43 -08:00
Tamir Duberstein
92fca42e06 [fuchsia] Migrate to new RealmBuilder API (flutter/engine#39163)
See https://fxrev.dev/793422.
2023-01-26 11:15:23 -08:00
Ahmed Ashour
51c0a9ec65 Remove superfluous words from comments (flutter/engine#39068)
* Remove superfluous words.

* Format

* Duplicate in consecutive lines.
2023-01-24 09:54:19 -08:00
Ben Konyi
002fce29e0 Revert "Remove references to Observatory (#38919)" (flutter/engine#39035)
Reason for revert: breaking Flutter -> plugins roll

This reverts commit 1f603711c7b7afe52dff3872a5035789e3ddba02.
2023-01-20 12:33:40 -05:00
Ben Konyi
1f603711c7 Remove references to Observatory (flutter/engine#38919)
Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags.

See https://github.com/dart-lang/sdk/issues/50233
2023-01-19 09:20:46 -05:00
Rich Kadel
e43616416f [fuchsia] Replace deprecated AddLocalChild (flutter/engine#38788)
`AddLocalChild(LocalComponent*)` is deprecated.

It was replaced by:

`AddLocalChild(LocalComponentFactory)`, which is a type alias for a
lambda that returns a `std::unique_ptr<LocalComponentImpl>`.

This change addresses problems that arised due to object lifetime
management of the components, and allows RealmBuilder to model the
component lifecycle of local components in a way that's more consistent
with other components.

The RealmBuilder-built `Realm` now owns the lifetime of the local
components, instead of the client, and those objects are valid until
the `Realm` is destroyed.

Bug: fxbug.dev/109804
2023-01-11 16:54:22 -05:00
Jaeheon Yi
0720c7f6dc [fuchsia][scenic] Use infinite hit region (flutter/engine#38647)
fxbug.dev/118729
2023-01-09 15:40:51 +00:00
Erik
010e710512 Remove strict equality check for SkMatrix comparison (flutter/engine#38665)
* Remove strict equality check for SkMatrix comparison

* Address PR comments
2023-01-05 21:44:50 +00:00
Jason Simmons
226cf8354c Roll quiver to 3.2.1 (flutter/engine#38617)
Need to roll quiver to a version that doesn't depend on BidirectionalIterator, which is being removed in https://dart-review.googlesource.com/c/sdk/+/276741?tab=checks.
2023-01-04 02:04:38 +00:00
Emircan Uysaler
8528d4f572 [fuchsia] Add trace flow for Flatland::Present (flutter/engine#38565) 2022-12-29 15:52:09 -05:00
Emircan Uysaler
4667a310d0 [fuchsia] Set presentation interval (flutter/engine#38549) 2022-12-29 13:02:56 -05:00
Alexander Biggs
72c5b1eee5 [fuchsia] Debugging code for crash. (flutter/engine#38518) 2022-12-27 20:26:47 +00:00
Erik
5262e76f26 Port touch-based tests from embedder integration test (flutter/engine#38234)
* Port touch-based tests from embedder integration test

* Remove RegisterTouchScreen and related variables

* Update embedded child view size
2022-12-16 20:54:07 +00:00
Erik
b7bf0a3155 Full implementation of text-input-test (flutter/engine#37986)
Implements text-input-test, validates that we're able to receive the correct platform messages through the flutter/keyevent channel
2022-12-07 12:17:51 -05:00
Siva
aac2690ea4 Roll Dart SDK from 35a9facce191 to e517487c5679 (Dart 3.0) (flutter/engine#38105)
* Remove uses of --no-sound-null-safety in preparation for the Dart 3.0
roll.

* Update quiver package to latest.

* Run Fuchsia engine in null safe mode.

* Run Fuchsia engine in non null safe mode.

* Update Dart version to 3.0

* Address review comments.
2022-12-06 20:38:02 -08:00
Emircan Uysaler
8a3da8a9d5 [flatland] Update bug numbers. (flutter/engine#37880) 2022-11-23 16:14:48 -08:00
Emircan Uysaler
326622e3f1 Set nested clip nodes (flutter/engine#37850) 2022-11-22 17:07:36 -05:00
cfontas
02f77a716e fix pixel ratio (flutter/engine#37268) 2022-11-22 16:32:20 -05:00
Dan Field
6be3cc1572 [Impeller] Format shader sources. (flutter/engine#37770)
* Update format.dart to include glsl, format repo

* format more
2022-11-21 17:21:02 +00:00
Alexander Brusher
42fb1ed9d7 [fuchsia][a11y] Set explicit hit regions in flatland embedder (flutter/engine#37338) 2022-11-18 18:16:14 +00:00
Josh Gargus
a1255b6105 [fuchsia] Fix shader warmup. (flutter/engine#37662)
Before, ~VulkanSurface() invokes a potentially empty std::function.
Now, checks if it is empty before invoking it.
2022-11-16 13:35:13 -05:00
Chris Johnson
b8f5767b7f Remove usage of deprecated Fuchsia event source (flutter/engine#37641)
This capability is being removed by the Fuchsia platform (https://fuchsia-review.git.corp.google.com/c/fuchsia/+/758606), but is currently blocked on this usage.

This change simply removes the capability from this tests, where it doesn't seem to be used at all.
2022-11-15 15:53:26 -08:00
Naud Ghebre
318ac378b8 mouse-input-view nit and add mouse-input-test to integration test script (flutter/engine#37441)
* Use fuchsia_component

* [mouse-input] mouse-input-view doc nits and add mouse-input-test to the run_integration_test.sh script

Co-authored-by: Erik <erkln@google.com>
2022-11-10 21:10:06 +00:00
fzyzcjy
3ac82e66e3 Eliminate duplicated code when dealing with pointer data (flutter/engine#36822)
* add methods

* add empty test

* add unit test

* Update licenses_flutter

* add const

* size -> get length

* add boundary checks

* add tests

* remove death test since it says "Death tests use fork(), which is unsafe particularly in a threaded context."
2022-11-10 21:05:20 +00:00
Naud Ghebre
ffbedf21c4 [sdk_roll_failure] add facet to allowlist test_manager and other packages. (flutter/engine#37479) 2022-11-09 20:00:52 +00:00
gaaclarke
8fed30cc77 Revert "Sdk roll failure - add facet to allowlist test_manager and other packages. (#37395)" (flutter/engine#37449)
This reverts commit 1b143c26e9e748d682326bbf35172dfaa1b24e21.
2022-11-08 14:44:17 -08:00
Naud Ghebre
1b143c26e9 Sdk roll failure - add facet to allowlist test_manager and other packages. (flutter/engine#37395)
* Use fuchsia_component

* [fuchsia-sdk-roll] Hermetic packaging is flipped on by default. Add
test_manager package to the tests facets.

Co-authored-by: Erik <erkln@google.com>
2022-11-08 21:58:02 +00:00
Erik
fd9e9ccd63 [fuchsia] embedding-flutter test (flutter/engine#37052)
* Add embedding-flutter test

* Lint CC files

* GN formatting

* Remove changes to embedder

* Minor refactor

* Remove unused dependencies

* Lint CC files

* Remove comments

* Rename pubspec
2022-11-07 22:04:58 +00:00
Erik
81605481de [fuchsia] mouse-input test (flutter/engine#37221)
Introduces the `mouse-input` test, a straight port from fuchsia.git
2022-11-02 15:53:22 -04:00
Martin Kustermann
725ac26098 Remove usages of deprecated old native "<name>" syntax. (flutter/engine#37104)
The old native "<name>" syntax is being replaced with external functions that
have a @pragma("external-name", "<name>").

See https://github.com/dart-lang/sdk/issues/28791
2022-10-28 12:30:44 +02:00
Shivesh Ganju
a7e49f6030 [fuchsia][scenic] Fix logical size in flatland platform view. (flutter/engine#37053)
This PR fixes a bug identified after DPR feature was added in flatland
where currently we do not multiple the logical size of the view by the
pixel ratio.

This change is getting tested in input tests like mouse-input-test,
touch-input-test
2022-10-27 17:46:19 -04:00
Kaushik Iska
1941c2ca48 [Impeller] Wire Flutter's own VulkanMemoryAllocator implementation (flutter/engine#37018) 2022-10-27 20:57:54 +00:00
Shivesh Ganju
ccd247833e [fuchsia][scenic] Add input shield flag support in Flatland. (flutter/engine#36880)
This CL adds support for "intercept_all_input" flag in
flutter_runner_config for flatland.

Test: flutter-embedder-test
2022-10-25 15:34:00 -04:00
Jason Simmons
2d961993e4 Update the language version used by Fuchsia's wrapper for the Dart args package (flutter/engine#36986) 2022-10-25 02:41:39 +00:00
Erik
5eb07a1f2f Update pubspec.yaml for parent-view and touch-input-view (flutter/engine#36974)
* Update pubspec.yaml for parent-view and touch-input-view

* Add changes for text-input-view
2022-10-24 15:57:26 -04:00
Erik
0e283234ab Add test view for touch-input-test (flutter/engine#36879)
This PR adds a touch-input-view for use in the touch-input-test to validate touch input. The view will be attached to the test, and a touch event will be injected. The test asserts that a correct response is sent back from the view (the location of the touch as well as the name of the view).
2022-10-20 13:26:41 -04:00
Sébastien Marchand
1d08f089d0 [fuchsia] Bump the Fuchsia target API level to 10 (flutter/engine#36858) 2022-10-19 13:40:37 -07:00
Jaeheon Yi
3d0562260f [fuchsia][input] Delete legacy pointer handler (flutter/engine#36857) 2022-10-19 17:04:15 +00:00
Shivesh Ganju
19b7b0eb02 [fuchsia][scenic] Fix invalid viewRef error in pointer injection. (flutter/engine#36850)
This CL fixes the bug in pointer injector delegate where the viewRef is
incorrectly cloned in the flatland platform view, causing an invalid
viewRef to be passed in the Fidl request.

Test: flutter-embedder-test
2022-10-19 02:33:25 -04:00
Yegor Pomortsev
7281766810 [fuchsia] Use root-ssl-certificates in v2 runner manifests (flutter/engine#36703)
* Add a `use` for the `root-ssl-certificates` to ensure BoringSSL
  can read the certificates at /config/ssl
* Reformat manifest with `cmc format`

Fixes `HandshakeException`s when establishing a secure connection:

```
HandshakeException: Handshake error in client (OS Error:
        CERTIFICATE_VERIFY_FAILED: unable to get local issuer certificate(handshake.cc:393))
<asynchronous suspension>
```

Depends on changes that offer this directory to the runners,
e.g. https://fxrev.dev/737597

Bug: https://fxbug.dev/111712
2022-10-10 18:46:12 -07:00
Erik
9f4d9ff82a Add Dart AOT integration test (flutter/engine#36460) 2022-10-07 22:59:15 +00:00
Erik
b797d69385 Port over C++ components of the one-flutter test (flutter/engine#36546) 2022-10-03 18:31:03 +00:00
cfontas
b203597bab Add DPR To Flatland Embedder (flutter/engine#36449)
* add dpr field to flatland

* format

* more dpr updates

* add inverse

* fix error

* fix error

* fix formatting

* formatting again

* one more formatting fix

* update metrics

* fix build errors

* formatting

* test

* formatting

* test

* test

* fix typo

* clean up a bit

* format

* fix metrics

* remove line

* fix test

* remove prints

* fix formatting

* update checks

* format
2022-09-30 16:37:14 -04:00
Alexander Biggs
16d5012361 [fuchsia] Add --gtest-filter flag for unit tests. (flutter/engine#36509) 2022-09-29 19:57:05 +00:00
Erik
75d2baf5fe Add Dart JIT runner integration test (flutter/engine#36420) 2022-09-27 20:14:16 +00:00
SahilMadan
84766334f6 [flatland] Reduce size of hit-region. (flutter/engine#36447)
Currently, the hit-region is size FLT_MAX which is susceptible to
numerical overflow when rotating or translating (or any other
modification to the value).
2022-09-27 15:21:10 -04:00