DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[flatland] Update bug numbers. (flutter/engine#37880)

Browse Source
This commit is contained in:
Emircan Uysaler 2022-11-23 19:14:48 -05:00 committed by GitHub
parent 81a42073f6
commit 8a3da8a9d5
4 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/shell/platform/fuchsia/flutter/engine.cc
View File

@ -744,7 +744,7 @@ void Engine::Terminate() {
void Engine::DebugWireframeSettingsChanged(bool enabled) {
FML_CHECK(shell_);
// TODO(fxbug.dev/94000): Investigate if we can add flatland wireframe code
// TODO(fxbug.dev/116000): Investigate if we can add flatland wireframe code
// for debugging.
shell_->GetTaskRunners().GetRasterTaskRunner()->PostTask([this, enabled]() {
if (external_view_embedder_) {

6
engine/src/flutter/shell/platform/fuchsia/flutter/flatland_connection.cc
View File

@ -54,7 +54,7 @@ void FlatlandConnection::DoPresent() {
--present_credits_;
fuchsia::ui::composition::PresentArgs present_args;
// TODO(fxbug.dev/94000): compute a better presentation time;
// TODO(fxbug.dev/114588): compute a better presentation time;
present_args.set_requested_presentation_time(0);
present_args.set_acquire_fences(std::move(acquire_fences_));
present_args.set_release_fences(std::move(previous_present_release_fences_));
@ -86,7 +86,7 @@ void FlatlandConnection::AwaitVsync(FireCallbackCallback callback) {
if (threadsafe_state_.fire_callback_pending_) {
fml::TimePoint now = fml::TimePoint::Now();
// TODO(fxbug.dev/94000): Calculate correct frame times.
// TODO(fxbug.dev/114588): Calculate correct frame times.
threadsafe_state_.fire_callback_(
now, now + kDefaultFlatlandPresentationInterval);
threadsafe_state_.fire_callback_ = nullptr;
@ -121,7 +121,7 @@ void FlatlandConnection::OnNextFrameBegin(
std::scoped_lock<std::mutex> lock(threadsafe_state_.mutex_);
if (threadsafe_state_.fire_callback_) {
fml::TimePoint now = fml::TimePoint::Now();
// TODO(fxbug.dev/94000): Calculate correct frame times.
// TODO(fxbug.dev/114588): Calculate correct frame times.
threadsafe_state_.fire_callback_(
now, now + kDefaultFlatlandPresentationInterval);
threadsafe_state_.fire_callback_ = nullptr;

2
engine/src/flutter/shell/platform/fuchsia/flutter/flatland_external_view_embedder.cc
View File

@ -288,8 +288,6 @@ void FlatlandExternalViewEmbedder::SubmitFrame(
viewport.mutators.transform = view_mutators.transform;
}
// TODO(fxbug.dev/94000): Set HitTestBehavior.
// Set clip regions.
if (view_mutators.clips != viewport.mutators.clips) {
// Expand the clip_transforms array to fit any new transforms.

2
engine/src/flutter/shell/platform/fuchsia/flutter/flatland_platform_view.cc
View File

@ -113,7 +113,7 @@ void FlatlandPlatformView::OnGetLayout(
void FlatlandPlatformView::OnParentViewportStatus(
fuchsia::ui::composition::ParentViewportStatus status) {
// TODO(fxbug.dev/94000): Investigate if it is useful to send hidden/shown
// TODO(fxbug.dev/116001): Investigate if it is useful to send hidden/shown
// signals.
parent_viewport_status_ = status;
parent_viewport_watcher_->GetStatus(