engine-flutter-autoroll
d393fcbc50
Roll Flutter Engine from 20e53614c16c to 5b89189b8b5f (2 revisions) ( #142640 )
...
20e53614c1...5b89189b8bskia-flutter-autoroll@skia.org Roll Skia from 647271c1b744 to 0ad5b2a9cebd (2 revisions) (flutter/engine#50208 )
2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from 053848101c10 to 647271c1b744 (2 revisions) (flutter/engine#50206 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 21:41:22 +00:00
Dan Field
c417c4623c
Refactor ShaderTarget to not explicitly mention impeller or Skia ( #141460 )
...
Refactors `ShaderTarget` to make it opaque as to whether it's using Impeller or SkSL and instead has it focus on the target platform it's generating for.
ImpellerC includes SkSL right now whether you ask for it or not.
The tester target also might need SkSL or Vulkan depending on whether `--enable-impeller` is passed.
2024-01-31 21:30:02 +00:00
engine-flutter-autoroll
ceab0e005f
Roll Flutter Engine from 9ccd81d7595b to 20e53614c16c (3 revisions) ( #142628 )
...
9ccd81d759...20e53614c1skia-flutter-autoroll@skia.org Roll Dart SDK from fbf1d8ebceb4 to 1f136c7b962d (1 revision) (flutter/engine#50203 )
2024-01-31 magder@google.com Log FlutterJSONMessageCodec decode errors before asserting (flutter/engine#50163 )
2024-01-31 mdebbar@google.com [web] Final nail in FlutterViewEmbedder's coffin (flutter/engine#49769 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 19:40:07 +00:00
LouiseHsu
42317804ee
Show Mac Designed For iPad in 'flutter devices' ( #141718 )
...
Addresses https://github.com/flutter/flutter/issues/141290 by allow Mac Designed For IPad Devices to appear with 'flutter devices'.
<img width="573" alt="Screenshot 2024-01-29 at 12 23 24â¯AM" src="https://github.com/flutter/flutter/assets/36148254/35709a93-56fc-44c9-98d5-cf45afce967d ">
<img width="725" alt="Screenshot 2024-01-29 at 12 26 01â¯AM" src="https://github.com/flutter/flutter/assets/36148254/b6cbcfce-44db-42c6-ac01-0ab716d30373 ">
2024-01-31 19:34:07 +00:00
Flutter GitHub Bot
071830663a
Marks Mac_arm64_ios basic_material_app_ios__compile to be unflaky ( #142594 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64_ios basic_material_app_ios__compile"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64_ios%20basic_material_app_ios__compile%22 ).
This test can be marked as unflaky.
2024-01-31 19:24:05 +00:00
Michael Goderbauer
3da5ff5490
Fix ParentDataWidget crash for multi view scenarios ( #142486 )
...
Fixes https://github.com/flutter/flutter/issues/142480 .
This fixes a crash occurring during hot reload when a `ViewAnchor` is used between a `ParentDataWidget` (like `Positioned`) and its closest `RenderObject` descendant. Prior to the fix, the `ParentDataWidget` was accidentally applying its parent data to the render object in the `ViewAnchor.view` slot, which crashed because that render object wasn't (and shouldn't be) setup to accept parent data (after all, it is in a different render tree). Instead, the parent data should only be applied to the render object in the `ViewAnchor.child` slot. Luckily, with `Element.renderObjectAttachingChild` we already have API in place to walk the widget tree such as that only `RenderObjectWidgets` from the same render tree are considered.
2024-01-31 19:22:07 +00:00
engine-flutter-autoroll
efca21c0fb
Roll Flutter Engine from e0d8f472a1b6 to 9ccd81d7595b (1 revision) ( #142625 )
...
e0d8f472a1...9ccd81d759skia-flutter-autoroll@skia.org Roll Skia from 439a6aae5036 to 053848101c10 (2 revisions) (flutter/engine#50202 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 18:59:07 +00:00
Flutter GitHub Bot
9c107801ed
Marks Mac_arm64 tool_tests_commands to be unflaky ( #142593 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64 tool_tests_commands"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20tool_tests_commands%22 ).
This test can be marked as unflaky.
2024-01-31 18:55:25 +00:00
Justin McCandless
9c2c487e02
"System back gesture" explanation ( #142254 )
...
Improve docs around PopScope and its interaction with back gestures on Android and iOS.
2024-01-31 10:46:52 -08:00
Flutter GitHub Bot
1d48b60d48
Marks Mac_x64 tool_tests_commands to be unflaky ( #142592 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64 tool_tests_commands"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20tool_tests_commands%22 ).
This test can be marked as unflaky.
2024-01-31 18:45:34 +00:00
Flutter GitHub Bot
0e274f5c7b
Marks Mac_x64_ios integration_test_test_ios to be unflaky ( #142595 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64_ios integration_test_test_ios"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64_ios%20integration_test_test_ios%22 ).
This test can be marked as unflaky.
2024-01-31 18:42:28 +00:00
Flutter GitHub Bot
62fcc15887
Marks Mac_x64 native_ui_tests_macos to be unflaky ( #142598 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64 native_ui_tests_macos"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20native_ui_tests_macos%22 ).
This test can be marked as unflaky.
2024-01-31 18:34:01 +00:00
Flutter GitHub Bot
2dc7c92205
Marks Mac_x64_ios hot_mode_dev_cycle_ios__benchmark to be unflaky ( #142597 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64_ios hot_mode_dev_cycle_ios__benchmark"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64_ios%20hot_mode_dev_cycle_ios__benchmark%22 ).
This test can be marked as unflaky.
2024-01-31 18:30:47 +00:00
Flutter GitHub Bot
5efcfba66c
Marks Mac_arm64 native_ui_tests_macos to be unflaky ( #142599 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64 native_ui_tests_macos"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20native_ui_tests_macos%22 ).
This test can be marked as unflaky.
2024-01-31 18:27:46 +00:00
Flutter GitHub Bot
8629dfa283
Marks Windows_android hot_mode_dev_cycle_win__benchmark to be flaky ( #142609 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_android hot_mode_dev_cycle_win__benchmark"
}
-->
Issue link: https://github.com/flutter/flutter/issues/142608
2024-01-31 18:27:44 +00:00
Flutter GitHub Bot
5f2961d2dd
Marks Mac_arm64_ios integration_test_test_ios to be unflaky ( #142596 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64_ios integration_test_test_ios"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64_ios%20integration_test_test_ios%22 ).
This test can be marked as unflaky.
2024-01-31 18:01:22 +00:00
Polina Cherkasova
6d8aa4afaa
Mark test that leaks image. ( #142539 )
2024-01-31 09:58:00 -08:00
engine-flutter-autoroll
50dbcc48d4
Roll Flutter Engine from b9bc256156b8 to e0d8f472a1b6 (1 revision) ( #142623 )
...
b9bc256156...e0d8f472a1skia-flutter-autoroll@skia.org Roll Skia from f916aedaa69b to 439a6aae5036 (4 revisions) (flutter/engine#50201 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 17:55:23 +00:00
LongCatIsLooong
43aee92e61
Fix unresponsive mouse tooltip ( #142282 )
...
Fixes https://github.com/flutter/flutter/issues/142045
The intent of using `??=` was that if the tooltip is already scheduled for showing, rescheduling another show does nothing. But if the tooltip is already scheduled for dismissing, the `??=` won't cancel the dismiss timer and as a result the tooltip won't show. So the `??=` is now replaced by `=` to keep it consistent with the `_scheduleDismissTooltip` implementation.
2024-01-31 17:17:53 +00:00
Flutter GitHub Bot
347403f2ea
Marks Linux_android_emu android_defines_test to be unflaky ( #142591 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android_emu android_defines_test"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android_emu%20android_defines_test%22 ).
This test can be marked as unflaky.
2024-01-31 17:08:54 +00:00
engine-flutter-autoroll
3652206c63
Roll Flutter Engine from 447dd212447e to b9bc256156b8 (6 revisions) ( #142617 )
...
447dd21244...b9bc256156skia-flutter-autoroll@skia.org Roll Dart SDK from cd834c2ade57 to fbf1d8ebceb4 (1 revision) (flutter/engine#50199 )
2024-01-31 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Z-xFM2ILZJw22eU8q... to nymRxHV9Shod7cyLe... (flutter/engine#50197 )
2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from ef48b123d2d1 to f916aedaa69b (1 revision) (flutter/engine#50196 )
2024-01-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 488e33cd39de to cd834c2ade57 (2 revisions) (flutter/engine#50195 )
2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from eb1d9b467596 to ef48b123d2d1 (1 revision) (flutter/engine#50194 )
2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from fec9deb3d8c6 to eb1d9b467596 (1 revision) (flutter/engine#50193 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Z-xFM2ILZJw2 to nymRxHV9Shod
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 17:00:06 +00:00
engine-flutter-autoroll
9480e889c6
Roll Packages from 25abb5d1e0de to 5b48c446976f (4 revisions) ( #142616 )
...
25abb5d1e0...5b48c44697ian@hixie.ch [rfw] Enable subscribing to the root of a DynamicContent (flutter/packages#5848 )
2024-01-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Adds ProxyApi to AST generation (flutter/packages#5861 )
2024-01-30 stuartmorgan@google.com [tool] Exempt federated impl examples from CHANGELOG (flutter/packages#6018 )
2024-01-30 engine-flutter-autoroll@skia.org Manual roll Flutter from 2f6fdf2650d4 to ace9181172b6 (57 revisions) (flutter/packages#6013 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 16:21:51 +00:00
Jude Selase Kwashie
4a6cbefe34
Fix null operator error when tapping on 'MenuItemButton' ( #142230 )
...
This PR fixes null operator error when you change focus node of a 'MenuItemButton' to null.
fixes: [issue142095](https://github.com/flutter/flutter/issues/142095 )
2024-01-31 16:21:50 +00:00
engine-flutter-autoroll
d93e7ae971
Roll Flutter Engine from 8e7df85f7d11 to 447dd212447e (2 revisions) ( #142587 )
...
8e7df85f7d...447dd21244skia-flutter-autoroll@skia.org Roll Skia from 1fbb575f968d to fec9deb3d8c6 (1 revision) (flutter/engine#50192 )
2024-01-31 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds (flutter/engine#50058 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 16:13:19 +00:00
Kate Lovett
42add0f8fa
Split out AppBar/SliverAppBar material tests ( #142560 )
...
While looking into resolving https://github.com/flutter/flutter/issues/117903 , I found the massive test file `app_bar_test.dart` and found it unwieldy to work with. So before proposing a solution to #117903 , which would touch many of these tests, I figured a clean up would be best first.
This splits up `app_bar_test.dart` with a new file `app_bar_sliver_test.dart`, and adds `app_bar_utils.dart` for shared test methods.
It basically moves all SliverAppBar tests into their own file, leaving just AppBar tests in the original file.
2024-01-31 16:13:17 +00:00
engine-flutter-autoroll
c65ab4d513
Roll Flutter Engine from 2d2d88068a23 to 8e7df85f7d11 (2 revisions) ( #142583 )
...
2d2d88068a...8e7df85f7dskia-flutter-autoroll@skia.org Roll Skia from bf27636582c7 to 1fbb575f968d (1 revision) (flutter/engine#50190 )
2024-01-31 kustermann@google.com More correctly name methods regarding event loop that are currently named microtask (flutter/engine#50138 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 06:46:07 +00:00
Ian Hickson
16e014e884
Add DropdownMenu.focusNode ( #142516 )
...
fixes [`DropdownMenu` doesn't have a focusNode](https://github.com/flutter/flutter/issues/142384 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
enum TShirtSize {
s('S'),
m('M'),
l('L'),
xl('XL'),
xxl('XXL'),
;
const TShirtSize(this.label);
final String label;
}
void main() => runApp(const MyApp());
class MyApp extends StatefulWidget {
const MyApp({super.key});
@override
State<MyApp> createState() => _MyAppState();
}
class _MyAppState extends State<MyApp> {
final FocusNode _focusNode = FocusNode();
@override
void dispose() {
_focusNode.dispose();
super.dispose();
}
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
appBar: AppBar(
title: const Text('DropdownMenu Sample'),
),
body: Center(
child: DropdownMenu<TShirtSize>(
focusNode: _focusNode,
initialSelection: TShirtSize.m,
label: const Text('T-Shirt Size'),
dropdownMenuEntries: TShirtSize.values.map((e) {
return DropdownMenuEntry<TShirtSize>(
value: e,
label: e.label,
);
}).toList(),
),
),
floatingActionButton: FloatingActionButton.extended(
onPressed: () {
_focusNode.requestFocus();
},
label: const Text('Request Focus on DropdownMenu'),
),
),
);
}
}
```
</details>
2024-01-31 06:12:20 +00:00
Flutter GitHub Bot
4af2051f8e
Marks Windows_android native_assets_android to be unflaky ( #140042 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_android native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_android%20native_assets_android%22 ).
This test can be marked as unflaky.
2024-01-31 04:13:30 +00:00
Flutter GitHub Bot
3a442ab4e5
Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller_gles__timeline_summary to be unflaky ( #140039 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro complex_layout_scroll_perf_impeller_gles__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20complex_layout_scroll_perf_impeller_gles__timeline_summary%22 ).
This test can be marked as unflaky.
2024-01-31 04:01:29 +00:00
Flutter GitHub Bot
19aa1ed95f
Marks Linux_android native_assets_android to be unflaky ( #140040 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20native_assets_android%22 ).
This test can be marked as unflaky.
2024-01-31 03:53:32 +00:00
Flutter GitHub Bot
ae49afa417
Marks Mac_android native_assets_android to be unflaky ( #140041 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_android native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_android%20native_assets_android%22 ).
This test can be marked as unflaky.
2024-01-31 03:45:10 +00:00
Flutter GitHub Bot
6379378c88
Marks Mac flavors_test_macos to be unflaky ( #140647 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac flavors_test_macos"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac%20flavors_test_macos%22 ).
This test can be marked as unflaky.
2024-01-31 03:08:36 +00:00
engine-flutter-autoroll
daf8d5fe4e
Roll Flutter Engine from 588f06b02664 to 2d2d88068a23 (1 revision) ( #142569 )
...
588f06b026...2d2d88068askia-flutter-autoroll@skia.org Roll Skia from 76da7ec3e106 to bf27636582c7 (1 revision) (flutter/engine#50187 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 01:46:34 +00:00
engine-flutter-autoroll
1e8c7519e1
Roll Flutter Engine from e6e1d6b3d035 to 588f06b02664 (1 revision) ( #142566 )
...
e6e1d6b3d0...588f06b026skia-flutter-autoroll@skia.org Roll Skia from 62cab132c9ad to 76da7ec3e106 (1 revision) (flutter/engine#50186 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 01:05:12 +00:00
David Martos
20dc5cbc6c
M3 - Fix Chip icon and label colors ( #140573 )
2024-01-30 16:28:31 -08:00
engine-flutter-autoroll
1f573e022e
Roll Flutter Engine from d20ed240ace9 to e6e1d6b3d035 (3 revisions) ( #142564 )
...
d20ed240ac...e6e1d6b3d0skia-flutter-autoroll@skia.org Roll Dart SDK from 734aae9604e8 to 488e33cd39de (1 revision) (flutter/engine#50185 )
2024-01-30 jonahwilliams@google.com [Impeller] Reland: add interface for submitting multiple command buffers at once. (flutter/engine#50180 )
2024-01-30 iinozemtsev@google.com Support running sound null safe kernels from flutter_jit_runner (flutter/engine#50002 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-31 00:24:26 +00:00
Ian Hickson
cd4445345c
Be less verbose in CI for customer_testing, and revert old timeout hack ( #139611 )
...
This PR does two things. First, it reduces the verbosity in the customer_testing shard. We want to be less verbose because it's nigh on impossible to find anything when there's a failure in the verbose logs. Also, some additional comments are added to make following the breadcrumbs easier for the next person.
Second, it reverts a timeout that had been set to 90 minutes a while ago. It's no longer needed.
Fixes https://github.com/flutter/flutter/issues/120901 .
2024-01-30 23:37:23 +00:00
Kohei Seino
9ed650aee5
use PDI to end the isolated scope for RLI ( #141345 )
...
will fix https://github.com/flutter/flutter/issues/141344
https://unicode.org/reports/tr9/#Explicit_Directional_Isolates
https://api.flutter.dev/flutter/foundation/Unicode/RLI-constant.html
2024-01-30 23:16:01 +00:00
Ian Hickson
abebd340d7
Style correctness improvements for toStrings and related fixes ( #142485 )
...
Children should be omitted from debugFillProperties (if they really need to be included they should be in debugDescribeChildren, but in general for widgets we don't bother including them since they are eventually included anyway).
toStrings should not contain newlines (or, ideally, should use Diagnosticable).
Also some minor tweaks to match grammar and style guide conventions.
2024-01-30 22:41:15 +00:00
engine-flutter-autoroll
176b439d67
Roll Flutter Engine from 500ae6c4d947 to d20ed240ace9 (1 revision) ( #142554 )
...
500ae6c4d9...d20ed240acskia-flutter-autoroll@skia.org Roll Skia from 739b66191c66 to 62cab132c9ad (2 revisions) (flutter/engine#50181 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 22:33:22 +00:00
dependabot[bot]
c40acdad15
Bump codecov/codecov-action from 3.1.5 to 3.1.6 ( #142553 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.1.5 to 3.1.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v3.1.6</h2>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v3.1.5...v3.1.6 ">https://github.com/codecov/codecov-action/compare/v3.1.5...v3.1.6 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="ab904c41d6a8c374ae46https://redirect.github.com/codecov/codecov-action/issues/1228 ">#1228</a>)"</li>
<li>See full diff in <a href="4fe8c5f003...ab904c41d6https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=3.1.5&new-version=3.1.6 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-01-30 22:03:07 +00:00
engine-flutter-autoroll
d35c08e9cf
Roll Flutter Engine from cd12316a0883 to 500ae6c4d947 (1 revision) ( #142551 )
...
cd12316a08...500ae6c4d935989475+MeandNi@users.noreply.github.com Revert "Close connection on keyboard close (#41500 )" (flutter/engine#49366 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 21:47:25 +00:00
engine-flutter-autoroll
b23b3da935
Roll Flutter Engine from 0e4342c5a1f2 to cd12316a0883 (6 revisions) ( #142548 )
...
0e4342c5a1...cd12316a08skia-flutter-autoroll@skia.org Roll Dart SDK from 10bbb376de7e to 734aae9604e8 (1 revision) (flutter/engine#50179 )
2024-01-30 30870216+gaaclarke@users.noreply.github.com [Impeller] added mipmaps to subpasses directly on a draw call (flutter/engine#50157 )
2024-01-30 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d0b48a008559 to 10bbb376de7e (8 revisions) (flutter/engine#50172 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 7df4d35e11cf to 739b66191c66 (1 revision) (flutter/engine#50175 )
2024-01-30 jonahwilliams@google.com [Android] Reland: recycle hardware buffer textures. (flutter/engine#50122 )
2024-01-30 mk12360@gmail.com Roll buildroot to 52689fe8955a9a4916a38f0b8ae5ea3e217037f4 (flutter/engine#50160 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 20:55:07 +00:00
engine-flutter-autoroll
4b110de996
Roll Flutter Engine from 438e9b4d7d4e to 0e4342c5a1f2 (11 revisions) ( #142543 )
...
438e9b4d7d...0e4342c5a1flutter/engine#50174 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from a3d46fac53be to 7df4d35e11cf (3 revisions) (flutter/engine#50173 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from c2fada52fdc4 to a3d46fac53be (2 revisions) (flutter/engine#50171 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 7dc9ba2e8c90 to c2fada52fdc4 (1 revision) (flutter/engine#50170 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 1c0eae94fc09 to 7dc9ba2e8c90 (1 revision) (flutter/engine#50169 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 4e992fb3a9db to 1c0eae94fc09 (3 revisions) (flutter/engine#50167 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Hqi_x_A9lYsY58VSn... to Z-xFM2ILZJw22eU8q... (flutter/engine#50166 )
2024-01-30 jonahwilliams@google.com [Impeller] Add interface for submitting multiple command buffers at once. (flutter/engine#50139 )
2024-01-30 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.3.0 (flutter/engine#50165 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 083c1a4d9767 to 4e992fb3a9db (1 revision) (flutter/engine#50164 )
2024-01-30 mbrase@google.com Use structured logging on Fuchsia (flutter/engine#49918 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Hqi_x_A9lYsY to Z-xFM2ILZJw2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 19:57:25 +00:00
Renzo Olivares
1daac1b875
Fix: selection handles do not inherit color from local Theme widget ( #142476 )
...
This change uses `CapturedTheme`s to capture the themes from the context the selection handles were built in and wraps the handles with them so they can correctly inherit `Theme`s from local `Theme` widgets.
`CapturedTheme`s only captures `InheritedTheme`s, so this change also makes `_InheritedCupertinoTheme` an `InheritedTheme`. This is so we can capture themes declared under a `CupertinoTheme`, for example `primaryColor` is used as the selection handle color.
Fixes #74890
2024-01-30 18:12:18 +00:00
Flutter GitHub Bot
bd715036b5
Marks Windows_arm64 plugin_test_windows to be unflaky ( #137675 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 plugin_test_windows"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20plugin_test_windows%22 ).
This test can be marked as unflaky.
2024-01-30 18:02:52 +00:00
Jonah Williams
75b3c8ec9a
Revert "Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions)" ( #142533 )
...
Reverts flutter/flutter#142528
2024-01-30 09:33:52 -08:00
Aizat Azhar
75a2e5b493
Reset framesEnabled to default value at the end of each test ( #141844 )
...
Reset `framesEnabled` to `true` at the end of each test as otherwise subsequent tests may fail when pumping a widget
Fixes #141835
2024-01-30 16:04:15 +00:00
Kate Lovett
e8cb029583
Fix SliverMainAxisGroup geometry cacheExtent ( #142482 )
...
Fixes https://github.com/flutter/flutter/issues/142183
This fixes a bug in the SliverGeometry of SliverMainAxisGroup. The cacheExtent represents how many pixels the sliver has consumed in the SliverConstraints.remainingCacheExtent. Since it was not set, slivers that came after a SliverMainAxisGroup that filled the whole screen did not properly lay out their own children, in some cases making lazy sliver more eager than they should be.
2024-01-30 16:04:13 +00:00
engine-flutter-autoroll
5bb4fa35f3
Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions) ( #142528 )
...
0e586d1c28...f02a4a80a7skia-flutter-autoroll@skia.org Roll Skia from 1c0eae94fc09 to 7dc9ba2e8c90 (1 revision) (flutter/engine#50169 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 4e992fb3a9db to 1c0eae94fc09 (3 revisions) (flutter/engine#50167 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Hqi_x_A9lYsY58VSn... to Z-xFM2ILZJw22eU8q... (flutter/engine#50166 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Hqi_x_A9lYsY to Z-xFM2ILZJw2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 15:57:08 +00:00
