38206 Commits

Author SHA1 Message Date
Elias Yishak
d35e14bb11
[CP] beta 138434 flutter tools pathnotfoundexception (#140005)
Fixes:
- https://github.com/flutter/flutter/issues/138434

Cherry pick into Beta issue:
- https://github.com/flutter/flutter/issues/140006
2023-12-14 19:12:59 +00:00
Casey Hillers
fed06b31d9
[flutter_releases] Flutter beta 3.18.0-0.2.pre Framework Cherrypicks (#140097)
# Flutter beta 3.18.0-0.2.pre Framework

## Scheduled Cherrypicks
3.18.0-0.2.pre
2023-12-13 22:53:33 +00:00
Andrew Kolos
f5a2ca0b9d
[CP (beta)] have Java.version return null if java --version fails or cannot be run (#139838)
cherry-picks changes from https://github.com/flutter/flutter/pull/139614 onto the beta channel
2023-12-12 15:03:08 +00:00
Casey Hillers
593a031efb
[flutter_releases] Flutter beta 3.18.0-0.0.pre Framework Cherrypicks (#139515)
# Flutter beta 3.18.0-0.0.pre Framework

## Scheduled Cherrypicks

https://github.com/flutter/flutter/issues/139400
3.18.0-0.1.pre
2023-12-05 00:55:27 +00:00
engine-flutter-autoroll
e5762baf24
Roll Flutter Engine from 51ef7642750f to 69f0e5550702 (1 revision) (#139348)
51ef764275...69f0e55507

2023-12-01 skia-flutter-autoroll@skia.org Roll Skia from b7b02ebaf770 to 57c6a5a97dc5 (1 revision) (flutter/engine#48561)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3.18.0-0.0.pre
2023-12-01 08:00:26 +00:00
engine-flutter-autoroll
8f518573af
Roll Flutter Engine from 894360cca1ec to 51ef7642750f (1 revision) (#139346)
894360cca1...51ef764275

2023-12-01 skia-flutter-autoroll@skia.org Roll Skia from 0a90c366ff87 to b7b02ebaf770 (3 revisions) (flutter/engine#48559)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-01 07:19:09 +00:00
engine-flutter-autoroll
fb6a88adb1
Roll Flutter Engine from c26e6ced11df to 894360cca1ec (1 revision) (#139345)
c26e6ced11...894360cca1

2023-12-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Bb2k375udWIltCEAx... to oPdJSBgOI25vZ9Jby... (flutter/engine#48558)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Bb2k375udWIl to oPdJSBgOI25v

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-01 06:44:33 +00:00
engine-flutter-autoroll
be268ebde2
Roll Flutter Engine from 74d2df52514a to c26e6ced11df (26 revisions) (#139342)
74d2df5251...c26e6ced11

2023-12-01 matanlurey@users.noreply.github.com Roll a new version of googletest (2021->2023). (flutter/engine#48285)
2023-12-01 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add ImageFilter.compose (flutter/engine#48546)
2023-12-01 dnfield@google.com Avoid reloading the kernel snapshot when spawning an isolate in the same group (flutter/engine#48478)
2023-12-01 43054281+camsim99@users.noreply.github.com [Android] Check for text to paste before trying to retrieve data from URI (flutter/engine#48166)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 88a1bcb9e43e to 0a90c366ff87 (3 revisions) (flutter/engine#48549)
2023-11-30 skia-flutter-autoroll@skia.org Manual roll Dart SDK to 3.3.0-174.2.beta (4 revisions) (flutter/engine#48538)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from db3399a541f3 to 88a1bcb9e43e (1 revision) (flutter/engine#48545)
2023-11-30 737941+loic-sharma@users.noreply.github.com [Windows] Begin decoupling text input plugin from the view (flutter/engine#47833)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 2d236de89898 to db3399a541f3 (3 revisions) (flutter/engine#48543)
2023-11-30 flar@google.com [Impeller] Add direct tesselation of circles for DrawCircle and Round end caps (flutter/engine#48103)
2023-11-30 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Revert to `drawImage` rendering on Chrome 110 or earlier (flutter/engine#48515)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 6b4bdebaab88 to 2d236de89898 (1 revision) (flutter/engine#48537)
2023-11-30 30870216+gaaclarke@users.noreply.github.com [Impeller] Started expanding the blur clip region (flutter/engine#48535)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 0e479728cc1f to 6b4bdebaab88 (1 revision) (flutter/engine#48536)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 0968fe18ff75 to 0e479728cc1f (1 revision) (flutter/engine#48534)
2023-11-30 103135467+sealesj@users.noreply.github.com Use Chromium mirror for archive dependency (flutter/engine#48509)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 2f01d500a352 to 0968fe18ff75 (2 revisions) (flutter/engine#48531)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 11a15444a3aa to 2f01d500a352 (1 revision) (flutter/engine#48524)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 84fdd36b1eea to 11a15444a3aa (1 revision) (flutter/engine#48523)
2023-11-30 leroux_bruno@yahoo.fr [Android] Add support for the PlatformChannel  "Share.invoke" command (flutter/engine#48265)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 5d64b1322879 to 84fdd36b1eea (1 revision) (flutter/engine#48521)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 23721750e433 to 5d64b1322879 (1 revision) (flutter/engine#48520)
2023-11-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8wu5EgBh1yJPNOd5W... to Bb2k375udWIltCEAx... (flutter/engine#48519)
2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 5a635f2211ce to 23721750e433 (1 revision) (flutter/engine#48514)
2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 928e8950e8e3 to 5a635f2211ce (1 revision) (flutter/engine#48511)
2023-11-29 mdebbar@google.com [web] No implicit view in multi-view mode (flutter/engine#48505)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 8wu5EgBh1yJP to Bb2k375udWIl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-01 03:07:26 +00:00
engine-flutter-autoroll
b24f2fbf80
Roll Flutter Engine from 35939ca8534f to 74d2df52514a (1 revision) (#139264)
35939ca853...74d2df5251

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 010883e6572c to
928e8950e8e3 (1 revision) (flutter/engine#48507)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-30 16:48:58 -08:00
Renzo Olivares
75011b252d
Add undoStackModifier to UndoHistory (#138674)
This change adds a feature to `UndoHistory` that allows the user to modify the value being pushed onto the undo stack.

This is used by the framework to ignore the composing region when pushing history entries to the Undo stack on Android. This is so an undo does not trigger an input connection restart by the Android TextInputPlugin, which occurs when the framework changes the composing region. This is also the native platform behavior observed in Google Keep app on Android, where doing an undo during composing reverts to the previous state but with composing inactive and a subsequent redo does not bring back the composing region.

Fixes #130881
Partial fix for #134398
2023-11-30 21:41:26 +00:00
godofredoc
8412adb981
Migrate docs_test to shard. (#139282)
This is part of the deprecation of adhoc tests.

Bug: https://github.com/flutter/flutter/issues/139153
2023-11-30 21:29:41 +00:00
Tirth
c10787bc6a
Write Tests for API Examples of cupertino_text_field.0, data_table.0, icon_button.2 & ink_well.0 (#139258)
Write Tests for API Examples of `cupertino_text_field.0`, `data_table.0`, `icon_button.2` & `ink_well.0`

Note: test for `cupertino_text_field.0` was already there but it was named `cupertino_text_field.0.dart`. I renamed it to `cupertino_text_field.0_test.dart`.

Part of #130459
2023-11-30 20:07:00 +00:00
Christopher Fujino
88710972da
Refactor prepare_package.dart (#139277)
I plan to extend the prepare_package.dart script to upload the flutter preview device ([design doc](https://docs.google.com/document/d/1AzI-_Uk2v1LA2kKKFJ7gVD4xcakXJ6yVZiS5Ek6RHtg/edit#heading=h.byp03plw7mg9)).

However, given that that script is one large >1k line file, I decided to organize it into smaller libraries in this PR. There should be no behavioral change in this PR, this is a cleanup only. I made the following changes:

1. Created a //dev/bots/prepare_package/ directory to contain helper libraries
2. Moved everything but the `main()` function in //dev/bots/prepare_package.dart into one of 4 helper libraries under the new directory from step 1:
  a. archive_creator.dart which contains the code that creates archive directory locally on disk
  b. archive_publisher.dart which contains the code that uploads the archive to cloud storage
  c. common.dart for shared constants and definitions
  d. process_runner.dart for an abstraction over running sub-processes
3. Changed all definitions to `File` and `Directory` from `dart:io` to use the testable versions from `package:file`. This allowed me to use the `MemoryFileSystem` in the unit tests, rather than creating real temp file system directories.
2023-11-30 19:25:50 +00:00
engine-flutter-autoroll
995a020e48
Roll Packages from e4aaba833261 to bc72d15c95a5 (4 revisions) (#139307)
e4aaba8332...bc72d15c95

2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add platform interface" (flutter/packages#5524)
2023-11-30 louisehsu@google.com [pointer_interceptor] Add platform interface (flutter/packages#5499)
2023-11-29 engine-flutter-autoroll@skia.org Roll Flutter from 6bf3ccd47d5d to 5e5b5292f739 (58 revisions) (flutter/packages#5519)
2023-11-29 john@johnmccutchan.com Fix Google Maps rendering issues in TLHC mode when using LATEST renderer (flutter/packages#5408)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-30 15:45:21 +00:00
Zachary Anderson
918e336014
Move Impeller tests on Pixel 7 Pro from staging to prod (#139280)
These tests are now expected to be reasonably stable, and increases in
flakiness should be reported as part of the regular flaky test triage
process.
2023-11-30 06:47:12 -08:00
xubaolin
d49dcaa697
Introduce multi-touch drag strategies for DragGestureRecognizer (#136708)
Fixes #11884

As #38926 pointed out, the current Flutter implementation of multi-finger drag behavior is different from iOS and Android.
This change introduces the `MultitouchDragStrategy` attribute, which implements the Android behavior and can be controlled through `ScrollBehavior`, while retaining the ability to extend iOS behavior in the future.
2023-11-30 09:22:19 +00:00
godofredoc
cae47c4641
Use the correct recipe on fuchsia_precache. (#139279)
To run shard tests we need to use flutter_drone recipe.


## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-11-29 18:19:30 -08:00
auto-submit[bot]
6c4475e72d
Reverts "Migration for the sendTiming events for package:unified_analytics" (#139278)
Reverts flutter/flutter#138896
Initiated by: CaseyHillers
This change reverts the following previous change:
Original Description:
Related to tracker issue:
- https://github.com/flutter/flutter/issues/128251

<img width="278" alt="image" src="https://github.com/flutter/flutter/assets/42216813/cee7b9be-48d6-48e5-8c39-de28d0a1f0de">

The image above shows all of the instances where we have `sendTiming`. All of the call sites have been updated to use the new `Event.timing` event from `package:unified_analytics`.
3.17.0-19.0.pre
2023-11-30 01:16:19 +00:00
godofredoc
c8101b56a9
Migrate fuchsia_precache to shard tests. (#139202)
Adhoc tests are being deprecated and existing tests are being migrated to shard tests.

Bug: https://github.com/flutter/flutter/issues/139153
2023-11-30 00:03:23 +00:00
Taha Tesser
4648f54430
Fix chips onDeleted callback don't show the delete button when disabled (#137685)
fixes [Chips with `onDeleted` callback should show the delete button in the `disabled` state](https://github.com/flutter/flutter/issues/136638)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            RawChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('RawChip'),
              onSelected: null,
              isEnabled: false,
              onDeleted: () {},
            ),
            InputChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('InputChip'),
              isEnabled: false,
              onPressed: null,
              onDeleted: () {},
            ),
            FilterChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('FilterChip'),
              onSelected: null,
              onDeleted: () {},
            ),
          ],
        ),
      ),
    );
  }
}
```

</details>

| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/8bd458de-cfd2-44f0-a0dd-a8298938c61f" /> | <img src="https://github.com/flutter/flutter/assets/48603081/afca0684-b061-416b-b029-5316588c6888" /> |
2023-11-29 23:57:05 +00:00
engine-flutter-autoroll
023e5addaa
Roll Flutter Engine from 9a7e49d75411 to 35939ca8534f (5 revisions) (#139259)
9a7e49d754...35939ca853

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from eb6fc55a3bc5 to 010883e6572c (1 revision) (flutter/engine#48506)
2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 830111a2c7d6 to eb6fc55a3bc5 (1 revision) (flutter/engine#48503)
2023-11-29 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Disable createImageBitmap support on Chrome 110 or older on Windows. (flutter/engine#48475)
2023-11-29 jonnywang@google.com [fuchsia] Update Fuchsia API level to 15 (flutter/engine#48233)
2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 8931060e9ab5 to 830111a2c7d6 (1 revision) (flutter/engine#48501)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-29 21:16:25 +00:00
Mitchell Goodwin
e84f1296ac
Refactor to use Apple system fonts (#137275)
Addresses #63507, and is a follow up to the engine PR https://github.com/flutter/engine/pull/46857

Changes the font family string when attempting to use Apple system fonts to the new proxies added by the engine. For the "Text" font this will be more secure in the future against possible changes to Apple's API. For the "Display" font, this will now work correctly when it didn't before.

I checked the letter spacing values against a native app for all font sizes between 17-28. I made a few adjustments to better match native, but especially for the "Text" font we were either really close, or close enough to not make a large breaking change to default fonts worth it.

| Before  | After |
| ------------- | ------------- |
| <img width="466" alt="Screenshot 2023-11-02 at 11 45 12 AM" src="https://github.com/flutter/flutter/assets/58190796/627ed8ac-d848-4f71-aa62-a467b8aac62d"> | <img width="383" alt="Screenshot 2023-11-02 at 11 46 25 AM" src="https://github.com/flutter/flutter/assets/58190796/9a502021-7d2b-4e14-98f1-86971b3830a5"> |

The smaller text in both the before and after should be the same. The large system font that Flutter used before was incorrect, which caused it to look more spread out. Now we use the correct font.
2023-11-29 21:03:32 +00:00
Michael Goderbauer
4f8a99147a
Dynamic view sizing (#138648)
Towards https://github.com/flutter/flutter/issues/134501.

This change is based on https://github.com/flutter/engine/pull/48090. It changes the `RenderView` to be dynamically sized based on its content if the `FlutterView` it is configured with allows it (i.e. the `FlutterView` has loose `FlutterView.physicalConstraints`). For that, it uses those `physicalConstraints` as input to the layout algorithm by passing them on to its child (after translating them to logical constraints via the device pixel ratio). The resulting `Size` that the `RenderView` would like to be is then communicated back to the engine by passing it to the `FlutterView.render` call.

Tests will fail until https://github.com/flutter/engine/pull/48090 has rolled into the framework.
2023-11-29 20:45:18 +00:00
Ian Hickson
b417812547
Roll dependencies (#139203)
Removes video_player and scoped_model pins, rolls everything else to latest.
2023-11-29 20:12:59 +00:00
yakagami
443d8617f7
add sourceTimeStamp to ScaleUpdateDetails (#135936)
This PR adds the ability to get the `sourceTimeStamp` from `ScaleUpdateDetails` in a `GestureScaleUpdateCallback` like so:

```dart
onScaleUpdate: (ScaleUpdateDetails details){
  print(details.sourceTimeStamp);
}
```

`sourceTimeStamp` is necessary when tracking velocity eg.

```dart
VelocityTracker tracker = VelocityTracker.withKind(PointerDeviceKind.touch);
///...
onScaleUpdate: (ScaleUpdateDetails details){
  tracker.addPosition(details.sourceTimeStamp!, details.focalPoint);
}
```

The docs say:

>Having both a pan gesture recognizer and a scale gesture recognizer is redundant; scale is a superset of pan. Just use the scale gesture recognizer.

Currently this is not entirely accurate, and should be fixed, as noted in https://github.com/flutter/flutter/issues/43833#issuecomment-548133779. This PR does not add `sourceTimeStamp` to `ScaleStartDetails` because it is more involved. Specifically, `ScaleStartDetails` can be created in `acceptGesture` which does not have access to the `PointerEvent` to get the `event.timeStamp` (54fa255432/packages/flutter/lib/src/gestures/scale.dart (L730C5-L730C5)).

fixes https://github.com/flutter/flutter/issues/135873. See also https://github.com/flutter/flutter/issues/43833 which added delta and https://github.com/flutter/flutter/issues/49025 which added `numPointers` to `ScaleUpdateDetails` for the reason given above. `sourceTimeStamp` should probably be added to `ScaleStartDetails` as well because it exists in `DragStartDetails` and therefore in `onPanStart`.

I am not sure how to add tests for this, any input about this PR would be appreciated.

- [] All existing and new tests are passing.
2023-11-29 20:09:21 +00:00
engine-flutter-autoroll
c864a556bb
Roll Flutter Engine from 222beb28a8eb to 9a7e49d75411 (1 revision) (#139250)
222beb28a8...9a7e49d754

2023-11-29 jonahwilliams@google.com [Impeller] fix order of operations in SkSL generated texture lookup. (flutter/engine#48488)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-29 18:17:37 +00:00
Greg Spencer
6295289163
Remove deprecated PlatformMenuBar.body (#138509)
Part of https://github.com/flutter/flutter/issues/139243

## Description

This removes the `PlatformMenuBar.body` attribute and constructor parameter, since its deprecation period has elapsed.

## Tests
 - No tests were using the deprecated attribute, so no tests were removed.

#FlutterDeprecations
2023-11-29 18:13:50 +00:00
Elias Yishak
60d5c8abc5
Migration for the sendTiming events for package:unified_analytics (#138896)
Related to tracker issue:
- https://github.com/flutter/flutter/issues/128251

<img width="278" alt="image" src="https://github.com/flutter/flutter/assets/42216813/cee7b9be-48d6-48e5-8c39-de28d0a1f0de">

The image above shows all of the instances where we have `sendTiming`. All of the call sites have been updated to use the new `Event.timing` event from `package:unified_analytics`.
2023-11-29 17:42:52 +00:00
engine-flutter-autoroll
5e5b5292f7
Roll Flutter Engine from 60b963930202 to 222beb28a8eb (2 revisions) (#139242)
60b9639302...222beb28a8

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from b9e2514a6fb6 to 8931060e9ab5 (1 revision) (flutter/engine#48498)
2023-11-29 34871572+gmackall@users.noreply.github.com Fix new lint from android 14 upgrade, and remove it from the baseline (flutter/engine#47817)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-29 17:39:15 +00:00
engine-flutter-autoroll
f53e68a11a
Roll Flutter Engine from eebbe7e15c7d to 60b963930202 (2 revisions) (#139237)
eebbe7e15c...60b9639302

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from ca84147b3e4e to b9e2514a6fb6 (1 revision) (flutter/engine#48497)
2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 19fbbf73fa33 to ca84147b3e4e (1 revision) (flutter/engine#48496)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-29 16:54:21 +00:00
engine-flutter-autoroll
85d311d632
Roll Packages from 3c054661a3a6 to e4aaba833261 (5 revisions) (#139232)
3c054661a3...e4aaba8332

2023-11-28 ian@hixie.ch [rfw, flutter_markdown] Prepare for removing dart:ui imports. (flutter/packages#5471)
2023-11-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.20 to 1.9.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5483)
2023-11-28 70025277+Nitin-Poojary@users.noreply.github.com [flutter image] Changed image link to use image within package (flutter/packages#5326)
2023-11-28 PROGrand@users.noreply.github.com camera_android: Camera.java pausePreview null check (flutter/packages#5265)
2023-11-28 ltv.luongthevinh@gmail.com [webview_flutter] Add listener for content offset (Platform Interface) (flutter/packages#5427)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-29 15:44:07 +00:00
Kate Lovett
8ba459ce9f
Update VelocityTracker (4) (#139166)
This updates the implementation to use the stopwatch from the Clock object and pipes it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.

Relands https://github.com/flutter/flutter/pull/138843 attempted to reland https://github.com/flutter/flutter/pull/137381 which attempted to reland #132291
Fixes https://github.com/flutter/flutter/issues/97761

1. The original change was reverted due to flakiness it introduced in tests that use fling gestures.
  * Using a mocked clock through the test binding fixes this now
2. It was reverted a second time because a change at tip of tree broke it, exposing memory leaks, but it was not rebased before landing. 
  * These leaks are now fixed
3. It was reverted a third time, because we were so excellently quick to revert those other times, that we did not notice the broken benchmark that only runs in postsubmit.
  * The benchmark is now fixed
2023-11-29 14:59:13 +00:00
Kate Lovett
133711ba9a
Analyze against using Stopwatches in the framework (#138507) 2023-11-29 08:49:35 -06:00
engine-flutter-autoroll
4d8ae570b5
Roll Flutter Engine from ecc9c7b6be7d to eebbe7e15c7d (1 revision) (#139225)
ecc9c7b6be...eebbe7e15c

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 89e844f3fc87 to 19fbbf73fa33 (1 revision) (flutter/engine#48494)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-29 13:44:25 +00:00
engine-flutter-autoroll
2c93b999e8
Roll Flutter Engine from 28aae2d29822 to ecc9c7b6be7d (1 revision) (#139210)
28aae2d298...ecc9c7b6be

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 8489b2c37f73 to 89e844f3fc87 (1 revision) (flutter/engine#48490)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-29 10:51:21 +00:00
Fré Dumazy
1d4d002592
Improve documentation of CardTheme.shape (#139096)
The previous documentation did not point out the difference between the default corner radius for Material 2 and Material 3.

Fixes: https://github.com/flutter/flutter/issues/139093
3.17.0-18.0.pre
2023-11-29 09:54:59 +00:00
Ian Hickson
5e216d44ca
Simplify devicelab logic and fix tests (#139122)
- fix https://github.com/flutter/flutter/issues/53707 by having the test not expect a timeout but instead actually look for the retry message
- simplify the `--task` option to only accept task names rather than also accepting paths
- remove some obsolete options that referred to the manifest which no longer seems to exist
2023-11-29 08:41:27 +00:00
Veli Bacik
c5328650f1
implemented leadingWidth and automaticallyImplyLeading options (#136165)
Before:
![Screenshot 2023-10-09 at 01 32 33](https://github.com/flutter/flutter/assets/17102578/cb90423c-8d8d-40d5-afd0-5aab23b9930b)

After:

![Screenshot 2023-10-09 at 01 33 01](https://github.com/flutter/flutter/assets/17102578/3ba84243-42b8-4e02-b064-70618e21a305)

![Screenshot 2023-10-09 at 01 32 49](https://github.com/flutter/flutter/assets/17102578/4f311d74-f6a8-4f32-9974-109bd7f55812)

Fixed #136164
2023-11-29 08:29:06 +00:00
Renzo Olivares
178130b169
TextField and TextFormField can use a MaterialStatesController (#133977)
This change adds support for a `MaterialStatesController` in `TextField` and `TextFormField`. With this change a user can listen to `MaterialState` changes in an input field by passing a `MaterialStatesController` to `TextField` or `TextFormField`.

Fixes #133273
2023-11-29 08:25:20 +00:00
Mateus Felipe C. C. Pinto
49632fc374
Provide parameter to Icon and IconThemeData for they to consider the context's text scaler (#135708)
Provide a parameter `applyTextScaling` to both `Icon` and `IconDataTheme`. When `true`, the context's `TextScaler` will apply it's `scale` method to the icon size.

Fixes #115466
2023-11-29 07:44:21 +00:00
engine-flutter-autoroll
44981755c0
Roll Flutter Engine from be4d7c8b760c to 28aae2d29822 (1 revision) (#139204)
be4d7c8b76...28aae2d298

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 539aba7d8539 to 8489b2c37f73 (1 revision) (flutter/engine#48489)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-29 07:21:38 +00:00
LongCatIsLooong
075b9f763f
Update ButtonStyleButton.scaledPadding documentation. Migrate callers in flutter/flutter (#139014)
Fixes https://github.com/flutter/flutter/issues/138547. 

It makes more sense to me for the default padding values to use the scaled font sizes instead of the `textScaleFactor`.
2023-11-29 07:05:42 +00:00
engine-flutter-autoroll
716b34c502
Roll Flutter Engine from de99c71c598f to be4d7c8b760c (1 revision) (#139199)
de99c71c59...be4d7c8b76

2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from fa5d6165e4d8 to 539aba7d8539 (1 revision) (flutter/engine#48486)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-29 06:34:10 +00:00
engine-flutter-autoroll
27f644b5eb
Roll Flutter Engine from 9a840e8dba40 to de99c71c598f (2 revisions) (#139195)
9a840e8dba...de99c71c59

2023-11-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Vqcs_2rbtDfbmu3WX... to 8wu5EgBh1yJPNOd5W... (flutter/engine#48485)
2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 6ad886e9593a to fa5d6165e4d8 (2 revisions) (flutter/engine#48484)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Vqcs_2rbtDfb to 8wu5EgBh1yJP

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-29 05:09:14 +00:00
engine-flutter-autoroll
0233e93853
Roll Flutter Engine from fbb2b1e880fa to 9a840e8dba40 (1 revision) (#139192)
fbb2b1e880...9a840e8dba

2023-11-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "binary_messenger missing cstdint" (flutter/engine#48483)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-29 04:30:21 +00:00
engine-flutter-autoroll
54ecad9f16
Roll Flutter Engine from 4beaa1195b74 to fbb2b1e880fa (1 revision) (#139191)
4beaa1195b...fbb2b1e880

2023-11-29 joel.winarske@gmail.com binary_messenger missing cstdint (flutter/engine#48481)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-29 03:44:02 +00:00
engine-flutter-autoroll
7a0508e5de
Roll Flutter Engine from 570fec4fa92c to 4beaa1195b74 (3 revisions) (#139190)
570fec4fa9...4beaa1195b

2023-11-29 jonahwilliams@google.com [Impeller] fix descriptor pool recycler test flake. (flutter/engine#48479)
2023-11-29 robert.ancell@canonical.com Fix the application not disposing by breaking circular references on quit (flutter/engine#47684)
2023-11-28 dnfield@google.com Fix CanonicalizeURL for file schema (flutter/engine#48466)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-29 03:01:04 +00:00
auto-submit[bot]
20eb3ea131
Reverts "Reland Add platform view wide gamut test" (#139189)
Reverts flutter/flutter#139101
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
Reland of https://github.com/flutter/flutter/pull/138837

I reverted too many config files, the app needed the pbx project file in order to find the new class I added. Instead, just put the new platform view in the app delegate so it builds.
2023-11-29 00:58:17 +00:00
godofredoc
8b6277e638
Move analysis test to shard tests. (#139161)
This is part of the effort to deprecated adhoc tests.

Bug: https://github.com/flutter/flutter/issues/139153
2023-11-28 23:58:55 +00:00
Tirth
a49ee534c6
Write Tests for API Examples of snack_bar.0, elevated_button.0, stepper.0, radio.0, filled_button.0, outlined_button.0 & card.0 (#138987)
Write Tests for API Examples of `snack_bar.0`, `elevated_button.0`, `stepper.0`, `radio.0`, `filled_button.0`, `outlined_button.0` & `card.0`

Part of #130459
2023-11-28 23:57:10 +00:00