Currently, these places are picking it up via some include chain
involving interface_impl.h, which is bad since I'm going to delete that
file (since InterfaceImpl<> is deprecated and no longer used) -- I'll do
this separately.
R=rudominer@chromium.org
Review URL: https://codereview.chromium.org/1214633009 .
This isn't quite perfect since we seem to do a second layout as the
activity switcher is brought up which is shifting down our
toolbar and making it bleed slightly below the Activity Switcher's
Task description bar. But at least we're the right color now.
R=abarth@chromium.org, abarth@google.com
Review URL: https://codereview.chromium.org/1209423008 .
Previously, if a subclass of FixedHeightScrollable didn't set itemCount,
everything would silently work except that you wouldn't actully be able to
scroll. This CL makes it harder to forget to provide the itemCount by making it
an abstract getter. Now the analyzer will flag it as missing in subclasses and
we'll throw an exception at runtime if you forget it.
R=ianh@google.com, tonyg@google.com
Review URL: https://codereview.chromium.org/1219933004 .
This does way more than a single CL should do, sorry.
- Fixed a bunch of logging/error reporting during loads.
- Made it possible for --package-root to be absolute.
- Fixed (hypothetically) parts of iOS build to be clang-plugin-compliant.
- Made all tests pass in sky_shell
- Removed a bunch of layout_tests including windows support.
I'll remove all the mojo test harness stuff in a follow-up patch.
R=abarth@chromium.org, abarth@google.com
Review URL: https://codereview.chromium.org/1215953006.
The initial fix was updating Image to NetworkImage, which is the new
name for the Widget that takes a URL to an image.
However, this exposed an underlying bug: slots given to
MultiChildRenderObjectWrapper children were not getting updated in the
initial build. Initially, we don't have a next sibling for any of the
children's roots, since we haven't yet synced anyone after the one
we're syncing. So we pass null. However, as soon as we build the next
one, the previous one now has an out of date slot: null means
"append", but it needs to be "insert before the newly inserted root of
the next child". So now we update the slot after each insertion.
This returned the spinning_mixed demo to its original state, but that
state was buggy: the image would expand to fit the button and push the
text out of the button. To resolve that, this patch changes how
RenderImage sizes an image that has no desired dimensions but has some
constraints that make it impossible to show the image at full size:
now, we try to maintain the aspect ratio and honour the constraints
all at the same time.
Also, if the constraints are tight we skip all that logic, because
it'd be a waste of time.
To help with the slot issue above, I needed to see the widget tree and
the render tree and compare them (to see where the nodes were getting
out of order), so I also extended Widget.toString() to dump a deep
tree of the widget hierarchy.
Also, while debugging all this I noticed we sometimes walk the tree
into nodes that are null, which causes crashes. So to avoid that I
added null-checks to certain walkChildren() functions.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1212943007.
This:
- Adds asserts all over the place to make sure things are working
right with respect to the parent pointer.
- Fixes the bugs those asserts uncovered. It turns out we were failing
to update the parent pointer in a couple of cases: when the child
hadn't changed (but the parent had), and when the node was replaced.
- Remove the operator[] nonsense in scaffold.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1218183009.
This is done by the following steps:
- Make Inherited classes notify their descendants when their state
changes.
- Make Components track which Inherited classes they looked at.
- Make Components handle being notified of state changes by rebuilding
if the changed ancestor is of a type we've looked at.
- Refactor setState() and scheduleBuild().
- Make the "buildDirtyComponents" phase support incrementally building
more components as each one finds it needs to update itself.
The way this works is that when the menu item updates its color, it
does so by changing a DefaultTextStyle (Inherited) node in its tree.
That node then notifies its ancestors, which include in particular the
Text component, which uses DefaultTextStyle. The notification is
received, and, even though we're already in the rebuild phase, the
Text queues itself up to be rebuilt as well. Since we now support
adding people to the rebuild phase while it's active, it gets rebuilt
as well, and all is well.
This CL depends on the fix in https://codereview.chromium.org/1218183009R=abarth@chromium.org
Review URL: https://codereview.chromium.org/1222823004.
Rather than hardcoding the size and presence of the notification area in Dart,
we now expose padding values on the view. These values are set to non-zero
values when there are UI elements that overlap the view. We currently respect
only the top padding, but this CL paves the way to respect padding in other
directions.
We still hardcode the size of the notification area in Java. A future CL will
retrieve this value from the Android framework.
Fixes#257R=ianh@google.com
Review URL: https://codereview.chromium.org/1220353002.
