8690 Commits

Author SHA1 Message Date
Michael Klimushyn
d2e8a2d635 Check Java formatting in format.sh (flutter/engine#16500)
Uses google-java-format, a tool that's already in place in
flutter/plugins. This should take care of minor style guide issues and
unresolved imports.
2020-02-07 16:05:08 -08:00
skia-flutter-autoroll
c69d282dba Roll src/third_party/skia 9f3eef796f63..b2031d4255e2 (12 commits) (flutter/engine#16499) 2020-02-07 14:58:03 -08:00
Matt Carroll
7a8e698211 Fix safe area reporting with transparent FlutterActivitys. (#46060) (flutter/engine#16208) 2020-02-07 14:57:06 -08:00
Jason Simmons
504c378cd2 [SkParagraph] Text layout benchmarks using SkParagraph (flutter/engine#16373)
Imported from @Rusino's branch
2020-02-07 14:17:57 -08:00
Michael Goderbauer
6af1f304fa Doc fixes in BoxHeightStyle (flutter/engine#16424) 2020-02-07 13:41:50 -08:00
Alexander Brusher
82ffcd8ee8 Update node fields fix (flutter/engine#16428)
* Modifies accessibility bridge to populate new node fields in semantics API.

* Adds additional UTs and fixes logic for breaking up updates for nodes with large values.

* Chaged tests to set node flags using bitwise-or instead of addition.

* Address bug in update size arithmetic.

* Fixes issue in TruncatesLargeValue unit test causing unexpected deletes.

* Fixes expected number of updates in BatchesLargeMessages unit test to reflect expected values now that node states are populated.
2020-02-07 13:24:36 -08:00
skia-flutter-autoroll
6a80a4b4e6 Roll src/third_party/skia 87e3bef6f82f..9f3eef796f63 (7 commits) (flutter/engine#16493) 2020-02-07 13:18:03 -08:00
George Wright
f9d5564332 Disable ShellTest.WaitForFirstFrameTimeout on Fuchsia (flutter/engine#16495) 2020-02-07 13:13:59 -08:00
Chris Bracken
b9545c70c0 Fix unused import in Android embedder (flutter/engine#16494)
android.os.Parcelable was added in commit
177353d759452c998879b3ac7a05d9dc6e437466 but never used.
2020-02-07 12:26:50 -08:00
Dan Field
21f6cef10b Fix text range logic for a11y (flutter/engine#16496)
Make sure that a text range at the end of the string is still valid.
2020-02-07 12:20:30 -08:00
Kaushik Iska
d8390d3f38 Simplify task queues locking mechanism (flutter/engine#16477)
We now have one mutex guarding all accesses to
the underlying task heaps. This simplifies the more granular
but bug prone mechanism of having striped locks.

This also re-enables GPUThreadMerger tests that are currently
disabled due to their flaky nature. The scenario that gets fixed by this
change is as follows:

1. Thread-1: We lock `queue_meta_mutex_` and grab locks on `queue_1` and release the meta mutex.
2. Thread-1: We add an Observer on `queues` object.
3. Thread-2: We lock `queue_meta_mutex_` and grab locks on `queue_2`.
4. Thread-2: We try to dispose all the pending tasks on `queue_2` which calls `erase` on `queues`.

The above situation is not thread safe without having 1 lock.

Note: This increases the contention on one lock and could potentially be bad for perf. We are
explicitly making this trade-off towards reducing the complexity.

Fixes: https://github.com/flutter/flutter/issues/49007
2020-02-07 10:24:05 -08:00
sjindel-google
d4baabd022 Ensure fields of Rect and OffsetBase classes are optimized as non-null. (flutter/engine#16465)
* Ensure fields of Rect and OffsetBase classes are optimized as non-null.

* Update web_ui and formatting
2020-02-07 19:06:20 +01:00
skia-flutter-autoroll
bccf32142d Roll src/third_party/skia 77fdf66946d2..87e3bef6f82f (2 commits) (flutter/engine#16492) 2020-02-07 08:53:02 -08:00
skia-flutter-autoroll
cfed60421f Roll src/third_party/dart d765d237460d..514a8d4c8417 (7 commits) (flutter/engine#16491) 2020-02-07 07:28:04 -08:00
skia-flutter-autoroll
e84dc9caae Roll src/third_party/skia f3560b680e35..77fdf66946d2 (1 commits) (flutter/engine#16490) 2020-02-07 07:18:03 -08:00
skia-flutter-autoroll
31c837a8bf Roll fuchsia/sdk/core/linux-amd64 from g2s3c... to LvSlH... (flutter/engine#16489) 2020-02-07 07:03:03 -08:00
skia-flutter-autoroll
3ea7fa8c9b Roll src/third_party/skia 97bf6578796c..f3560b680e35 (1 commits) (flutter/engine#16487) 2020-02-06 23:58:02 -08:00
skia-flutter-autoroll
56871365b6 Roll src/third_party/skia 046f9893b953..97bf6578796c (1 commits) (flutter/engine#16486) 2020-02-06 22:18:02 -08:00
skia-flutter-autoroll
69aaef3d03 Roll src/third_party/dart 49850e6919f7..16782e6c171f (16 commits) (flutter/engine#16485) 2020-02-06 20:18:03 -08:00
skia-flutter-autoroll
291207c072 Roll fuchsia/sdk/core/linux-amd64 from A9STP... to g2s3c... (flutter/engine#16484) 2020-02-06 17:33:03 -08:00
Francisco Magdaleno
40c7f488e9 Code cleanup on destructors (flutter/engine#16481) 2020-02-06 16:53:02 -08:00
skia-flutter-autoroll
0fae445981 Roll src/third_party/skia 121750c2efff..046f9893b953 (4 commits) (flutter/engine#16482) 2020-02-06 16:33:02 -08:00
Mouad Debbar
bdeb972d43 Run Flutter framework tests against the web engine in Cirrus (flutter/engine#16343) 2020-02-06 16:17:25 -08:00
skia-flutter-autoroll
0e6648c7b4 Roll src/third_party/dart b3396cbdcae1..49850e6919f7 (45 commits) (flutter/engine#16480) 2020-02-06 15:08:04 -08:00
George Wright
69e635c0fc Enable shell_unittests on Fuchsia with Vulkan dependencies. (flutter/engine#16376)
This also adds a dependency on SwiftShader's Vulkan frontend.
2020-02-06 15:07:01 -08:00
skia-flutter-autoroll
8e358801f6 Roll src/third_party/skia c0360582d211..121750c2efff (7 commits) (flutter/engine#16479) 2020-02-06 14:58:03 -08:00
Harry Terkelsen
f2839e3a3f Various fixes in CanvasKit (flutter/engine#16433)
- Enable dynamically loaded fonts
- Fix addOval
- Fix getBoxesForRange for negative ranges
2020-02-06 14:51:12 -08:00
stuartmorgan
f9ebc8e2dc Add noexcept annotations to EnableValue moves (flutter/engine#16478)
Fixes a warning when compiling in Visual Studio on Windows.
2020-02-06 14:28:31 -08:00
George Wright
36f5f76944 Enable runtime_unittests on Fuchsia 2020-02-06 13:52:33 -08:00
George Wright
10e7d17444 Fix elf_loader.cc on Fuchsia, add a TODO for proper fix 2020-02-06 13:52:33 -08:00
Anna Gringauze
1382e25796 Fix analyzer warnings for frontend_server change (flutter/engine#16470)
- added temporary ignore for annotate_overrides analyzer warning,
  will remove the ignore in a follow-up PR after the SDK change
  https://dart-review.googlesource.com/c/sdk/+/134561 lands.
- run dartfmt
2020-02-06 13:37:20 -08:00
skia-flutter-autoroll
a8adde9be6 Roll src/third_party/skia 7f36405ea3ec..c0360582d211 (6 commits) (flutter/engine#16476) 2020-02-06 13:23:03 -08:00
Sebastian Jeltsch
e7e1637bd9 Fix RasterCache LRU logic, opportunistic simplifications. (flutter/engine#16434)
RasterCache::Get() methods were not updating the RasterCache::Entry
access_count and used_this_frame fields, as is done in
RasterCache::Prepare(). This can result in onscreen images being evicted
from the cache as new entries are created (e.g. as new elements scroll
onscreen).
2020-02-06 13:15:51 -08:00
George Wright
bc12e7c8ab Disable unit tests using --gtest-filter instead of at compile time (flutter/engine#16472) 2020-02-06 13:01:14 -08:00
Chinmay Garde
f0ded2e849 Relax timing restrictions on WakeUpTimersAreSingletons. (flutter/engine#16446)
We don’t run this test on bots because we don’t want timeouts on any tests. This
only runs locally as a sanity check for timers.
2020-02-06 12:35:36 -08:00
Ferhat
0b3f68c172 Reset width/height before deallocation for Safari allocation bug. (flutter/engine#16469) 2020-02-06 12:30:27 -08:00
skia-flutter-autoroll
95393f6543 Roll src/third_party/skia 116b33e8ab21..7f36405ea3ec (3 commits) (flutter/engine#16471) 2020-02-06 11:43:04 -08:00
skia-flutter-autoroll
5fdf36f4cc Roll src/third_party/skia cc21d0c1f2ce..116b33e8ab21 (3 commits) (flutter/engine#16466) 2020-02-06 09:58:01 -08:00
skia-flutter-autoroll
ecedef91dd Roll src/third_party/skia f6e3eaf05150..cc21d0c1f2ce (1 commits) (flutter/engine#16463) 2020-02-06 08:13:03 -08:00
skia-flutter-autoroll
591ecae6f5 Roll src/third_party/skia cbf79b95c2d4..4721e067812f (1 commits) (flutter/engine#16459) 2020-02-06 04:38:02 -08:00
skia-flutter-autoroll
24103e4599 Roll fuchsia/sdk/core/linux-amd64 from VJv0H... to A9STP... (flutter/engine#16457) 2020-02-06 03:53:03 -08:00
Lau Ching Jun
2b914aa0dc Include <memory> in hb_wrapper.h because unique_ptr is used. (flutter/engine#16442) 2020-02-06 00:54:56 -08:00
stuartmorgan
86e0af1222 Roll rapidjson (flutter/engine#16347)
Rolls rapidjson forward to the next mirrored version. This is needed to
pick up fixes to building with clang on Windows, to support
https://github.com/flutter/flutter/issues/16256.
2020-02-05 22:35:02 -08:00
stuartmorgan
9c3b20b923 Wrap strdup to use compliant name on Windows (flutter/engine#16372)
A number of POSIX methods were renamed on Windows to match standards
requirements, giving deprecation warnings when calling strdup on Windows.
This adds a wrapper, to allow calling _strdup on Windows instead.

Part of #16256
2020-02-05 22:32:56 -08:00
stuartmorgan
91424efae5 Add explicit casts to printing of function pointers (flutter/engine#16370)
Compiling with clang on Windows fails here with a warning about implicit
cast from function pointer to object pointer. Rather than disable that
warning, this makes it an explicit cast. Since this is just test output,
it's not critical that this be a completely safe operation.

Part of #16256
2020-02-05 22:31:22 -08:00
skia-flutter-autoroll
1a72bb4b43 Roll src/third_party/skia ebc00f97fab1..cbf79b95c2d4 (4 commits) (flutter/engine#16456) 2020-02-05 22:23:04 -08:00
stuartmorgan
69e4ea885f Suppress some deprecation warnings on Windows (flutter/engine#16416)
Targeted suppression of some deprecation warnings that are build errors under
clang:
- Ignore the deprecation of codecvt's unicode conversion until we decide on
  a replacement strategy.
- Allow the deprecated posix names of functions in third_party/txt.

Part of https://github.com/flutter/flutter/issues/16256
2020-02-05 21:10:25 -08:00
Felipe Archondo
4884bd75f9 [fuchsia] change kMaxFramesInFlight to 3 (flutter/engine#16425)
To give more flexibility in scheduling, we change the number of frames
in flight we can have at one time to 3. We also introduce an offset from
VSync that Flutter can use to begin its work at. It is currently set at
0ms, matching previous behavior.
2020-02-05 23:58:05 -05:00
Mouad Debbar
efca62703f Reland #16206: "[web] Correct getPositionForOffset for multi-line paragraphs" (flutter/engine#16365) 2020-02-05 19:53:03 -08:00
Yegor
617582e744 fix bad reference to maxDiffRatePercent (flutter/engine#16440)
* fix bad reference to maxDiffRatePercent

* back to 10%
2020-02-05 18:49:10 -08:00