DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Ensure fields of Rect and OffsetBase classes are optimized as non-null. (flutter/engine#16465)

Browse Source 
* Ensure fields of Rect and OffsetBase classes are optimized as non-null.

* Update web_ui and formatting
This commit is contained in:
sjindel-google 2020-02-07 19:06:20 +01:00 committed by GitHub
parent bccf32142d
commit d4baabd022
2 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
engine/src/flutter/lib/ui/geometry.dart
View File

@ -12,7 +12,11 @@ abstract class OffsetBase {
///
/// The first argument sets the horizontal component, and the second the
/// vertical component.
const OffsetBase(this._dx, this._dy);
const OffsetBase(double dx, double dy)
: _dx = dx ?? 0.0,
_dy = dy ?? 0.0,
assert(dx != null),
assert(dy != null);
final double _dx;
final double _dy;
@ -615,11 +619,15 @@ class Size extends OffsetBase {
class Rect {
/// Construct a rectangle from its left, top, right, and bottom edges.
@pragma('vm:entry-point')
const Rect.fromLTRB(this.left, this.top, this.right, this.bottom)
: assert(left != null),
assert(top != null),
assert(right != null),
assert(bottom != null);
const Rect.fromLTRB(double left, double top, double right, double bottom)
: left = left ?? 0.0,
right = right ?? 0.0,
top = top ?? 0.0,
bottom = bottom ?? 0.0,
assert(left != null),
assert(top != null),
assert(right != null),
assert(bottom != null);
/// Construct a rectangle from its left and top edges, its width, and its
/// height.

3
engine/src/flutter/lib/web_ui/lib/src/ui/geometry.dart
View File

@ -12,7 +12,8 @@ abstract class OffsetBase {
///
/// The first argument sets the horizontal component, and the second the
/// vertical component.
const OffsetBase(this._dx, this._dy);
const OffsetBase(double dx, double dy)
: _dx = dx, _dy = dy;
final double _dx;
final double _dy;