5520 Commits

Author SHA1 Message Date
Ian Hickson
d2c8c82f4b Some cleanup of the test framework (#4001)
* Add a "build" phase to EnginePhase for completeness.
* Ignore events from the device during test execution.
* More dartdocs
* Slightly more helpful messages about Timers in verifyInvariants.
* Add widgetList, elementList, stateList, renderObjectList.
* Send test events asynchronously for consistency with other APIs.
* Fix a test that was depending on test events being synchronous (or
  rather, scheduled in a microtask that came before the microtask for
  the completer of the future that the tap() function returned).
2016-05-17 17:12:03 -07:00
Adam Barth
0dafe1a480 Add dartdoc to Tooltip (#3957)
Also, remove several unused configuration options and fix an animation
leak.
2016-05-17 16:02:12 -07:00
Adam Barth
0e8e8bbb24 Finish dartdoc for gestures.dart (#3994) 2016-05-17 15:39:46 -07:00
Jason Simmons
833942788d Update the engine (#3997) 2016-05-17 15:19:41 -07:00
Ian Hickson
b803d187ca Catch async functions passed to setState(). (#3992) 2016-05-17 14:53:17 -07:00
Jason Simmons
fc61060421 Log an error if the Android intent fails during flutter refresh (#3988) 2016-05-17 14:35:11 -07:00
Ian Hickson
f284c1a049 Fix tests (#3977)
Also, make sure that broken tests actually break the bots.

And add a test to make sure that keeps happening.
2016-05-17 12:45:37 -07:00
Jason Simmons
c192a7e4ca Replace the checked flag in DebuggingOptions with the build mode (#3901)
This also fixes some related problems affecting "flutter run":
  * FLXes built during AndroidDevice.startApp need to match the build mode
  * APKs should always be rebuilt if the build mode uses AOT compilation
2016-05-17 12:38:25 -07:00
Matt Perry
0628c64b79 Use KeyboardType.phone for the Gallery app's text demo. (#3983)
BUG=https://github.com/flutter/flutter/issues/3970
2016-05-17 15:36:59 -04:00
Hans Muller
ee3db6e61a Tweaks (#3975)
* ScrollableBuilder tweaks
2016-05-17 12:27:13 -07:00
Adam Barth
e9fe39e5e5 Explicitly specify linear curves (#3973)
We now required the curve parameter for CurvedAnimation.
2016-05-17 11:15:58 -07:00
Phil Quitslund
d6548133ce Merge pull request #3972 from pq/implementation_imports
Re-enable `implementation_imports` lint rule.
2016-05-17 11:15:41 -07:00
Adam Barth
355a1d8ecf Add some docs to gestures.dart (#3966)
Also, add some missing docs to http.dart and widgets.dart.
2016-05-17 11:14:15 -07:00
pq
97ba6a1e0b Re-enable implementation_imports lint rule. 2016-05-17 11:02:10 -07:00
Adam Barth
fa22cf5337 Finish dartdocs for animation.dart and foundation.dart (#3963)
Everything now has dartdocs except one setter whose getter already has
docs.
2016-05-17 10:49:20 -07:00
Phil Quitslund
a6b8980d3e Merge pull request #3954 from pq/summaries_off
Back out SDK summaries.
2016-05-17 09:03:15 -07:00
Phil Quitslund
04cdf71add Merge pull request #3955 from pq/type_annotate_public_apis_off
Remove redundant type annotation lint.
2016-05-17 09:02:27 -07:00
Collin Jackson
b4313b04b0 Merge pull request #3946 from collinjackson/apk
Make flutter run generate identical apks to flutter build apk
2016-05-17 07:30:10 -07:00
Collin Jackson
a312db482d remove the add-files argument to flutter run 2016-05-16 18:33:59 -07:00
Hans Muller
bec3fdefd1 Add a Scrollable builder, refactor ScrollableList, et al (#3950)
* Add a Scrollable builder, refactor ScrollableList, et al

* Add space between the dialog demo buttons

* removed vestigial code
2016-05-16 17:32:01 -07:00
Chinmay Garde
0e8f26dd6c Use the correct host toolchain when building from a local engine checkout on Mac. (#3956) 2016-05-16 17:05:39 -07:00
Adam Barth
0f3bd3ae84 Speed up compositing by 5x (#3948)
According to the profile for the flow manual test, we're spending the vast
majority of our time recording timeline traces. This patch removes the timeline
traces, which greatly improves performance.

Also, optimize TransformLayer to avoid one matrix memcpy. I filed
https://github.com/google/vector_math.dart/issues/166 about an API that would
make this even faster.
2016-05-16 16:41:13 -07:00
pq
464ccdfcac Remove redundant type annotation lint.
SInce this is a subset of `always_specify_types` I think we can safely remove it.

In practice, if you violate you get doubly nagged:
```
[lint] Type annotate public APIs. (packages/flutter_tools/lib/src/dart/runner.dart, line 5, col 1)
[lint] Declare method return types. (packages/flutter_tools/lib/src/dart/runner.dart, line 5, col 1)
```

One warning is probably enough to get the message across? ;)
2016-05-16 16:02:18 -07:00
pq
fddab5d800 Back out SDK summaries.
Net-net: SDK summaries are not safe in the presence of SDK library embedders.

Context (and bug to track re-enablement) here: https://github.com/dart-lang/sdk/issues/26467.
2016-05-16 15:57:45 -07:00
Collin Jackson
00e22284f2 Fix #3891 by making flutter run generate identical apks to flutter build apk 2016-05-16 15:53:18 -07:00
Viktor Lidholt
e1e773af4f Fixes crash in Flutter Sprites label (#3942) 2016-05-16 13:40:14 -07:00
Ian Hickson
7d2519f073 Make it easier to disable print throttling. (#3941)
This exposes the default throttling implementation, and an alternative
non-throttling implementation, of `debugPrint`.
2016-05-16 13:24:06 -07:00
Seth Ladd
a03c8f77ad gracefully handle generating docs twice (#3939)
* gracefully handle generating docs twice

* silently handle if directory doesn't exist
2016-05-16 13:05:13 -07:00
Ian Hickson
3252701753 Make it possible to run tests live on a device (#3936)
This makes it possible to substitute 'flutter run' for 'flutter test'
and actually watch a test run on a device.

For any test that depends on flutter_test:

1. Remove any import of 'package:test/test.dart'.

2. Replace `testWidgets('...', (WidgetTester tester) {`
      with `testWidgets('...', (WidgetTester tester) async {`

3. Add an "await" in front of calls to any of the following:
    * tap()
    * tapAt()
    * fling()
    * flingFrom()
    * scroll()
    * scrollAt()
    * pump()
    * pumpWidget()

4. Replace any calls to `tester.flushMicrotasks()` with calls to
   `await tester.idle()`.

There's a guarding API that you can use, if you have particularly
complicated tests, to get better error messages. Search for
TestAsyncUtils.
2016-05-16 12:53:13 -07:00
Matt Perry
5fa6c0e9b0 Remove the unimplemented more option from the copy/paste toolbar. (#3934)
Remove the unimplemented `more` option from the copy/paste toolbar.

Punting this feature for the near time, so I'm removing the dead option
from the toolbar.
2016-05-16 15:18:28 -04:00
Adam Barth
9e7311fedf Add dartdocs to asset_bundle.dart (#3922)
Fixes #3077
2016-05-16 12:18:13 -07:00
Ian Hickson
c5ff156f24 Revert "Rename DefaultTextStyle constructor to explicit (#3920)" (#3930)
This reverts commit 55f9145ef4fb7a7f4b4738740d5848ff745ae076.

Turns out that this commit breaks apps that use the material library,
because of the _errorTextStyle DefaultTextStyle which has inherit:true.
Just setting it to false doesn't work, unfortunately, because then you
hit some sort of issue with merging that text style with others that
have inherit:true.
2016-05-16 11:08:07 -07:00
Adam Barth
a078994ac9 Remove last old-style asserts-with-string (#3923)
Use the FlutterError hotness instead.

Fixes #1290
2016-05-16 10:37:58 -07:00
Adam Barth
55f9145ef4 Rename DefaultTextStyle constructor to explicit (#3920)
To make it clear that this constructor requires an explicit style. Also
throw a descriptive error recommending the inherit constructor for
styles with the inherit bit set.

Fixes #3842
2016-05-16 10:35:35 -07:00
Seth Ladd
707fe582a6 Docs homepage (#3908)
* put an index at root of API docs bucket

* ignore all of dev/docs/doc dir, fix a bug, remove private names from doc gen script

* tweaks from review
2016-05-16 08:28:58 -07:00
Devon Carew
483922d15c allow per-command analytics suppression (#3919)
* allow per-command analytics suppression

* rev the usage package dep
2016-05-15 20:06:27 -07:00
Devon Carew
4db64ace96 send debug events for flutter lifecycle events (#3903)
* send debug events for flutter lifecycle events

* remove the route event
2016-05-15 17:39:45 -07:00
Michael McLennan
baaa7a0370 Added performance instrumentation for compositing addToScene() calls (#3885)
* Added performance instrumentation for compositing addToScene() calls.

* Switched to non-callback versions of the Timeline API.

* Fixed Dart formatting nit.
2016-05-15 14:19:52 -07:00
Chinmay Garde
a21dedc16f Enable targetting AOTC Android builds from Mac hosts. (#3911) 2016-05-13 17:03:03 -07:00
Devon Carew
cc5d1adcfc handle an exit code from android n (#3914)
* handle an exit code from android n

* review comments
2016-05-13 16:47:30 -07:00
Yegor
15decfca6e reenable --checked option in flutter drive (#3916) 2016-05-13 16:42:28 -07:00
Phil Quitslund
d406bb99f3 Merge pull request #3909 from pq/one_member_abstracts
Re-enable `one_member_abstracts` lint (#3608).
2016-05-13 15:47:06 -07:00
pq
a9d5a7b30c Added space to ignore. 2016-05-13 15:35:27 -07:00
pq
4dd548578f Re-enable one_member_abstracts lint (#3608). 2016-05-13 14:28:21 -07:00
Devon Carew
2f642ce908 updates from the flutter gallery rename (#3898)
* updates from the flutter gallery rename

* rename ids to io.flutter.gallery
2016-05-13 12:46:50 -07:00
Seth Ladd
7e4a91f340 add a webmaster tools verification file (#3902)
* add a webmaster tools verification file

* also put the verification file at the root of our bucket

* add comment for when we can simplify this script
2016-05-13 12:27:06 -07:00
Matt Perry
6fd7987b4b Text selection UI matches behavior on Android. (#3886)
- Handles appear with tap or long press.
- Toolbar appears with long press on text, or tap on handle.
- Correct toolbar items shown depending on context.
2016-05-13 14:30:53 -04:00
Hans Muller
7de612add0 Increase fling-sensitivity of scrollable tabs (#3897) 2016-05-13 11:07:09 -07:00
Seth Ladd
20897c3f66 Box too big (#3884)
* shrink analytics message to < 80 chars

* catch line ending
2016-05-13 09:44:36 -07:00
Devon Carew
40c0d6ea12 Consolidate observatory code (#3892)
* rename service_protocol.dart to protocol_discovery.dart

* add a wrapper around the obs. protocol

* use json-rpc in run

* consolidate obs. code; implement flutter run --benchmark

* review comments
2016-05-12 18:15:23 -07:00