22271 Commits

Author SHA1 Message Date
engine-flutter-autoroll
cfc01bbb73
Roll Plugins from faa26ec364cd to 07cf89a08b88 (5 revisions) (#74426) 2021-01-21 17:39:03 -08:00
Kate Lovett
eb9bac6489
ScaffoldMessenger only shows to root nested Scaffold (#74093) 2021-01-21 17:34:05 -08:00
xubaolin
4bdea117a4
fix a tap gesture exception (#73846) 2021-01-21 17:29:04 -08:00
Romain Rastel
0a668b9804
Add details to the iOS part integration_test (#74428) 2021-01-21 17:26:07 -08:00
Kate Lovett
550a85dabd
Remove deprecated Element methods (#72903) 2021-01-21 17:24:05 -08:00
Zain Ur Rehman
45cf27923a
[showModalBottomSheet] fix: showModalBottomSheet does not move along keyboard (#71636) 2021-01-21 17:19:04 -08:00
Christopher Fujino
6a2dfa9f4f
Revert "Manually close tree while devicelab staging is failing (#74434)" (#74438)
This reverts commit 444c954f439bb5dce0e9c130c7a37a424ccb5927.
2021-01-21 17:09:38 -08:00
Christopher Fujino
97c1dedef9
Revert "Add removeListenerWhileNotifying benchmark for ChangeNotifier (#71986)" (#74450)
This reverts commit 831ee22b065688e925a99412a2fa062f6d255981.
2021-01-21 15:56:38 -08:00
godofredoc
3c27a567f4
Block the tree on mac_android test failures running on luci. (#74441)
* Block the tree on  mac_android test failures running on luci.

Bug: https://github.com/flutter/flutter/issues/74431

* Set android_semantics and android_hot_mode as non flaky.

* Set microbenchmarks as non flaky.
2021-01-21 14:55:21 -08:00
Jonah Williams
cecb7f3b58
Revert "Update PopupMenuButton to match Material Design spec (#70160)" (#74439)
This reverts commit 79d0358ece1ea00d7007e83dacb4343c7db5b419.
2021-01-21 12:51:53 -08:00
Kenzie Schmoll
75dc45aba3
Fix bugs with ext.flutter.activeDevToolsServerAddress (#74423) 2021-01-21 11:51:02 -08:00
Jenn Magder
444c954f43
Manually close tree while devicelab staging is failing (#74434) 2021-01-21 11:31:09 -08:00
engine-flutter-autoroll
afe3d0d297
Roll Engine from 30bb7452f8f0 to 30486859d161 (2 revisions) (#74420) 2021-01-21 10:09:04 -08:00
Pierre-Louis
fe87bc69b6
Add material icons golden test (#74131)
* Create icons golden test

* Update icons_test.dart

* Update icons_test.dart

* Update icons_test.dart

* change test name

* Add ability to load material icon font for golden tests

* formatting

* Skip test for browser

* Add end of file newline

* Rewrite with different method

* Add skip for browser
2021-01-21 17:31:35 +01:00
engine-flutter-autoroll
5b0f69f961
Roll Engine from a05fc88f8f39 to 30bb7452f8f0 (2 revisions) (#74396) 2021-01-21 04:49:03 -08:00
engine-flutter-autoroll
d44fbb6468
Roll Engine from dde6b7e8ea0a to a05fc88f8f39 (2 revisions) (#74375) 2021-01-21 03:04:04 -08:00
Kenzie Schmoll
b45088c0cf
Print DevTools inspector links in RenderFlex Overflow errors (#74251) 2021-01-21 02:59:04 -08:00
engine-flutter-autoroll
eeb7c261f2
dde6b7e8e Roll Dart SDK from 0265477b0534 to 970d74c42472 (1 revision) (flutter/engine#23811) (#74371) 2021-01-20 20:04:03 -08:00
stuartmorgan
5aa6cba31d
Adjust desktop feature flag (#74348)
Prep to make https://github.com/flutter/flutter/issues/73857 easier in the future.
2021-01-20 19:22:08 -08:00
engine-flutter-autoroll
84722e6552
Roll Engine from ced7bff0c28b to 920a33a0fc3a (4 revisions) (#74369) 2021-01-20 18:59:04 -08:00
Justin McCandless
a8471a61f8
Material Desktop Context Menu (#74286)
Very simple right-click context menu for Windows and Linux in a Material-esque style.
2021-01-20 16:29:01 -08:00
Kate Lovett
aed4518569
Remove deprecated WaitUntil[NoTransientCallbacks, NoPendingFrame, FirstFrameRasterized] methods from flutter_driver (#73754) 2021-01-20 16:19:03 -08:00
engine-flutter-autoroll
a9b937479e
Roll Engine from 0c79393dde01 to ced7bff0c28b (12 revisions) (#74362) 2021-01-20 16:14:03 -08:00
Kate Lovett
97481e125a
Remove deprecated Layer.findAll (#73749) 2021-01-20 15:44:02 -08:00
Muskan Jain
d57512ce08
AdoptAWidget: ColorFiltered (#71093) 2021-01-20 15:34:03 -08:00
Jonah Williams
851ff68788
[flutter_tools] throwToolExit from archive failure (#74259) 2021-01-20 15:17:58 -08:00
Ian Hickson
80142d4560
Update the alt text to match recommendations in https://html.spec.whatwg.org/multipage/images.html#alt (#74089) 2021-01-20 15:14:03 -08:00
Jenn Magder
57d695a5df
Skip flutter_immediately_exit_test (#74359) 2021-01-20 15:07:37 -08:00
LongCatIsLooong
a4b27cbf63
Update CupertinoSlidingSegmentedControl (#73772) 2021-01-20 14:54:03 -08:00
LongCatIsLooong
e21344faa5
minor streetAddressLine2 documentation update (#73370) 2021-01-20 14:49:03 -08:00
LongCatIsLooong
61299b1621
Revert "[text_input] prepare for custom text input sources (#72803)" (#74349) 2021-01-20 13:54:06 -08:00
Michael Goderbauer
def31b42b1
Improve DebugCreator docs (#74341) 2021-01-20 13:42:21 -08:00
stuartmorgan
48b3e8bf3a
Don't use iOS font names for the macOS theme (#74342)
macOS was sharing the iOS font theme, but the names of the underlying
fonts differ between the two platforms, so this was actually using the
fallback font from the engine. Instead of using the underlying font
names on macOS, which is no longer allowed by CoreText, use the
meta-font returned by systemFontOfSize:

This has been verified on 10.15; older versions of macOS may need
different font names as the handling of these fonts have changed over
time. Fixing older versions as necessary will be handled in a follow-up.

See https://github.com/flutter/flutter/issues/57805
2021-01-20 13:21:07 -08:00
Justin McCandless
24e195d918
Mac context menu (#73882)
A very minimal right-click menu for Mac desktop.
2021-01-20 13:18:25 -08:00
Hans Muller
c66596e595
Removed uses of AppBarTheme.color in packages/flutter (#74273) 2021-01-20 12:19:18 -08:00
engine-flutter-autoroll
3b7e3d4b3a
Roll Engine from b58dbc88fce9 to 0c79393dde01 (14 revisions) (#74329)
* d4a735835 Roll Dart SDK from c4214e6daaac to 4a6764bf28c2 (4 revisions) (flutter/engine#23770)

* 9bc776a84 [web] Add --watch flag to 'felt test' (flutter/engine#23727)

* 247ebc2dc Roll Skia from bde06cc511d2 to f3087d8297fe (7 revisions) (flutter/engine#23772)

* 8b27e6fb4 skip flaky test (flutter/engine#23775)

* 2927e9fb4 block thread merging with shared engines (flutter/engine#23733)

* df5f3b086 Implement handling of framework-handled key events (flutter/engine#23655)

* f205ceda2 Roll Skia from f3087d8297fe to e0fe62adaa3e (9 revisions) (flutter/engine#23781)

* fa7aebf1e Roll Skia from e0fe62adaa3e to 18aeb5731b51 (1 revision) (flutter/engine#23784)

* 9acfb7d59 Fix JNI void vs object method call (flutter/engine#23785)

* df13ccf44 Roll Skia from 18aeb5731b51 to 7aa7f039b9ee (1 revision) (flutter/engine#23786)

* e3e3b2b6e Roll Fuchsia Mac SDK from pc_veLlry... to xYraItnQp... (flutter/engine#23787)

* 8a096d641 ci: Print output in case of compile error (flutter/engine#23522)

* f1c3ced54 Roll Fuchsia Linux SDK from fByXAJ76e... to vs54lOVoj... (flutter/engine#23788)

* 0c79393dd Revert "Roll Dart SDK from c4214e6daaac to 4a6764bf28c2 (4 revisions) (#23770)" (flutter/engine#23791)
2021-01-20 12:02:32 -08:00
RomanJos
2a2e0cf100
Add clipBehavior to InteractiveViewer (#73281)
More intuitive control over whether the child can overflow out of InteractiveViewer, deterring a lot of confusion we were seeing.
2021-01-20 11:57:37 -08:00
Greg Spencer
2e3d3e6522
Revert "ListTile Material Ripple and Shape Patch (#73618)" (#74335)
This reverts commit 024c49da856918bfa6e65bb622a5bc9df91a276d because it breaks Google internal tests.
2021-01-20 11:42:48 -08:00
Ben Konyi
e2e3976a12
Roll package:dds to 1.7.3 and add error handling for VM service disappearing (#74272) 2021-01-20 10:49:13 -08:00
Michael Thomsen
914c9aa304
Rephrase null safety mode (#74306) 2021-01-20 19:42:16 +01:00
Kenzie Schmoll
118f61230a
Return the existing DevTools server from DevToolsLauncher.serve if one is already running. (#74271)
* Return the existing DevTools server from DevToolsLauncher.serve if one is already running.
2021-01-20 10:38:49 -08:00
Romain Rastel
831ee22b06
Add removeListenerWhileNotifying benchmark for ChangeNotifier (#71986) 2021-01-20 10:29:03 -08:00
Nate Bosch
dcc4fdd558
Pass only Uri to package:http APIs (#74285) 2021-01-20 09:59:03 -08:00
Dan Field
5318782ac8
Use package:vm_service instead of json_rpc_2 (#74215) 2021-01-20 09:29:18 -08:00
Sigurd Meldgaard
178c87cc27
Avoid relative paths in .dart_tool/package_config.json when generate:true (#73944)
Instead of using package:package_config to write the .dart_tool/package_config the original json is modified and rewritten.

The .dart_tool/package_config.json file is read twice to simplify control flow.

This also avoids the issue of package:package_config writing directly to local filesystem.
2021-01-20 14:53:49 +01:00
Jia Hao
b362d6f480
[flutter_tools] Fix ignoring of Flutter tester exitCode (#74293) 2021-01-20 18:47:51 +08:00
Ben Konyi
913d5933c1
Check VM service URI is valid before attempting to start DDS (Re-upload #73998) (#74280) 2021-01-19 22:34:03 -08:00
Nathan Walker
024c49da85
ListTile Material Ripple and Shape Patch (#73618)
This PR replaces the ColoredBox that ListTile uses with an Ink widget. That Ink widget is given a ShapeDecoration with the ListTile's color and shape. This fixes issues where the ListTile color would obscure material ripple effects, and cause the specified shape to not be respected.

List which issues are fixed by this PR. You must list at least one issue.

Fixes #73616
Fixes #63877
Fixes #67117

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

I modified a handful of tests related to ListTiles. The tests I changed had implementation-specific ways of checking the ListTile color. I have rewritten those so that instead of checking for a ColoredBox with a specific color, they check that a path is painted with the correct color.

I added the following tests to list_tile_test.dart:

"ListTile shows Material ripple effects on top of tileColor" (Regression test for #73616)
"ListTile shape is painted correctly" (Regression test for #63877)
I added the following test to sliver_prototype_item_extent_test.dart:

"SliverPrototypeExtentList prototypeItem paint transform is zero" (Regression test for #67117)
2021-01-19 19:28:13 -08:00
Todd Volkert
5322c6f860
Fix RenderCustomPaint intrinsics (#72103)
Make RenderCustomPaint consult its preferred size for intrinsics when it has no child. Currently, it returns 0 for its intrinsics, even if it has a non-zero preferred size.
2021-01-19 16:24:34 -08:00
Kate Lovett
80f88a7981
Remove deprecated Scaffold.resizeToAvoidBottomPadding (#72890) 2021-01-19 16:14:05 -08:00