DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
31,228 Commits 882 Branches 1,069 Tags
Commit Graph

23758 Commits

Author SHA1 Message Date
skia-flutter-autoroll
cc1a7262e1 Roll Skia from 596a1f192faa to 4468ef79f3d7 (2 revisions) (flutter/engine#45493) 
https://skia.googlesource.com/skia.git/+log/596a1f192faa..4468ef79f3d7

2023-09-06 herb@google.com Int96 intro and basic operations
2023-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from cba82c7c6f4a to d18edfe2c435

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 15:07:09 +00:00
skia-flutter-autoroll
e667f19c76 Roll Skia from a74a98890cc1 to 596a1f192faa (1 revision) (flutter/engine#45492) 
https://skia.googlesource.com/skia.git/+log/a74a98890cc1..596a1f192faa

2023-09-06 fmalita@chromium.org [skottie] Expose WYSIWYG editing functionality in WASM/CK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 14:21:48 +00:00
skia-flutter-autoroll
28202e1440 Roll Skia from 72d57724bcb8 to 619eef2d0d67 (1 revision) (flutter/engine#45481) 
https://skia.googlesource.com/skia.git/+log/72d57724bcb8..619eef2d0d67

2023-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f5590cb5133d to cba82c7c6f4a (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 05:38:04 +00:00
skia-flutter-autoroll
ff543afd47 Roll Skia from 3a3a64670e08 to 72d57724bcb8 (1 revision) (flutter/engine#45476) 
https://skia.googlesource.com/skia.git/+log/3a3a64670e08..72d57724bcb8

2023-09-06 johnstiles@google.com Add support for write-only storage texture types in WGSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 02:29:04 +00:00
skia-flutter-autoroll
aacaf98197 Roll Skia from ce2da423cb5d to 3a3a64670e08 (1 revision) (flutter/engine#45475) 
https://skia.googlesource.com/skia.git/+log/ce2da423cb5d..3a3a64670e08

2023-09-06 johnstiles@google.com Add support for pixel-format flags in SPIR-V backend.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 01:44:48 +00:00
skia-flutter-autoroll
1b9c7351c3 Roll Skia from 0a253625a76a to ce2da423cb5d (1 revision) (flutter/engine#45473) 
https://skia.googlesource.com/skia.git/+log/0a253625a76a..ce2da423cb5d

2023-09-06 johnstiles@google.com Add WGSL support for compute barrier intrinsics.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 01:01:24 +00:00
Jonah Williams
62031173dd [Impeller] construct text frames on UI thread. (flutter/engine#45418) 
Conversion of SkTextBlobs to impeller::TextFrame objects is one of the most expensive operations in display list dispatching. While the rest of the engine and framework makes a reasonable attempt to cache the SkTextBlobs generated during paragraph construction, the design of the dl dispatcher means that these the Impeller backend will always reconstruct all text frames on each frame - even if the display list/picture that contained those text frames was unchanged.

Removing this overhead is one of the goals of https://github.com/flutter/engine/pull/45386 , however this patch is also fairly risky and will be difficult to land. As a more incremental solution, we can instead construct the impeller::TextFrame objects when performing paragraph painting and record them in the display list. This both moves the text frame construction to the UI thread and allows the framework/engine to cache unchanged text frames.

This also does not conflict with the dl_aiks_canvas patch directly, and is fine to land before or after it does. (though I'd argue we should land this first).

To compare the current performance levels, I ran the complex_layout_scroll perf test, since this is fairly text filled. On a Pixel 6 pro.   Across several runs this is a fairly consistent ~1ms raster time improvement.

### Skia
```
  "average_frame_build_time_millis": 1.497333333333333,
  "90th_percentile_frame_build_time_millis": 2.038,
  "99th_percentile_frame_build_time_millis": 17.686,
  "worst_frame_build_time_millis": 23.095,
  "missed_frame_build_budget_count": 3,
  "average_frame_rasterizer_time_millis": 5.5078589743589745,
  "stddev_frame_rasterizer_time_millis": 2.226343414420338,
  "90th_percentile_frame_rasterizer_time_millis": 7.481,
  "99th_percentile_frame_rasterizer_time_millis": 19.11,
  "worst_frame_rasterizer_time_millis": 79.799,
  "missed_frame_rasterizer_budget_count": 7,
  "frame_count": 234,
  "frame_rasterizer_count": 234,
  "new_gen_gc_count": 10,
  "old_gen_gc_count": 2,
 ```
 
 ### Impeller (ToT)
 
 ```
   "average_frame_build_time_millis": 1.431575000000001,
  "90th_percentile_frame_build_time_millis": 2.196,
  "99th_percentile_frame_build_time_millis": 14.486,
  "worst_frame_build_time_millis": 23.728,
  "missed_frame_build_budget_count": 2,
  "average_frame_rasterizer_time_millis": 6.536087499999999,
  "stddev_frame_rasterizer_time_millis": 1.9902712500000004,
  "90th_percentile_frame_rasterizer_time_millis": 9.705,
  "99th_percentile_frame_rasterizer_time_millis": 14.727,
  "worst_frame_rasterizer_time_millis": 17.838,
  "missed_frame_rasterizer_budget_count": 1,
  "frame_count": 240,
  "frame_rasterizer_count": 240,
  "new_gen_gc_count": 10,
  "old_gen_gc_count": 2,
  ```
  
  ### Impeller (Patched)
  
  ```
    "average_frame_build_time_millis": 1.4500167364016743,
  "90th_percentile_frame_build_time_millis": 2.478,
  "99th_percentile_frame_build_time_millis": 14.883,
  "worst_frame_build_time_millis": 18.782,
  "missed_frame_build_budget_count": 1,
  "average_frame_rasterizer_time_millis": 5.023033333333336,
  "stddev_frame_rasterizer_time_millis": 1.6445388888888894,
  "90th_percentile_frame_rasterizer_time_millis": 7.814,
  "99th_percentile_frame_rasterizer_time_millis": 13.497,
  "worst_frame_rasterizer_time_millis": 15.008,
  "missed_frame_rasterizer_budget_count": 0,
  "frame_count": 239,
  "frame_rasterizer_count": 240,
  "new_gen_gc_count": 8,
  "old_gen_gc_count": 0,
  ```
 2023-09-06 00:50:48 +00:00
Jia Hao
6aec1aa55e Add import for <unordered_map> to fix the g3 build (flutter/engine#45471) 
Fixes the following in G3 (b/299185514):

```
impeller/typographer/font_glyph_pair.h:27:27: error: no template named 'unordered_map' in namespace 'std'; did you mean 'unordered_set'?
using FontGlyphMap = std::unordered_map<ScaledFont, std::unordered_set<Glyph>>;
                     ~~~~~^
```

I don't really know why the lack of this import only breaks the g3 build, but not here. My guess is that it's being imported transitively in some other import that's being ifdef-ed out in g3. 

But since we're already using it in ee18450664/impeller/typographer/font_glyph_pair.h (L27), we probably want to use the import in this file anyway.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-06 00:12:39 +00:00
skia-flutter-autoroll
ee18450664 Roll Skia from 1019c10a2d38 to af473004622f (2 revisions) (flutter/engine#45469) 
https://skia.googlesource.com/skia.git/+log/1019c10a2d38..af473004622f

2023-09-05 briansalomon@gmail.com Port GrMemoryPool emscripten alignment fix to SkSL::MemoryPool
2023-09-05 johnstiles@google.com Reject local-size qualifier of zero.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-05 23:16:19 +00:00
Zachary Anderson
b672497bc9 Adds a comment on clang_arm64_apilevel26 toolchain usage (flutter/engine#45467) 
Companion comment to the one in https://github.com/flutter/buildroot/pull/761
 2023-09-05 22:56:47 +00:00
Chris Yang
a101546179 [iOS ] Fix errors in unittest and scenario tests running against iOS 17 simulators (details in the description) (flutter/engine#45391) 
1. New Mac version seems to have updated the locale data, to match the mac change, we can dynamically read the data when testing instead of hard coding.

2. "we are sending a UIImage type as parameter to `XCTAttachment attachmentWithScreenshot:`, which takes a `XCUIScreenshot` as parameter, this is not supposed to pass in old iOS versions." In this PR we updated the parameter to use the `XCUIScreenshot` type.

Fixes https://github.com/flutter/flutter/issues/133783

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-05 22:45:22 +00:00
skia-flutter-autoroll
702d8bce4f Roll Skia from 2b9fc6a2c250 to 1019c10a2d38 (2 revisions) (flutter/engine#45466) 
https://skia.googlesource.com/skia.git/+log/2b9fc6a2c250..1019c10a2d38

2023-09-05 johnstiles@google.com Add support for @workgroup_size to WGSL code generator.
2023-09-05 michaelludwig@google.com Remove unnecessary semicolon in SkTime.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-05 22:32:31 +00:00
Chris Yang
59ce383ddb Fix iOS unittests leak in shared.invoke method channel that causes crash (flutter/engine#45416) 
Fixes https://github.com/flutter/flutter/issues/133776

"The crash is due to testShareScreenInvoked presents the activityViewController, which prevents the engineViewController to be dealloc'd in the test: https://github.com/flutter/engine/blob/main/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm#L161C4-L161C24"

This fix stubbing the presentViewController call, which prevents the viewController being alloc'd, thus preventing the leak. It is probably sufficient for this test.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-05 22:08:10 +00:00
skia-flutter-autoroll
e481f3e851 Roll Skia from a0572041af8e to 72c56fab439c (1 revision) (flutter/engine#45463) 
https://skia.googlesource.com/skia.git/+log/a0572041af8e..72c56fab439c

2023-09-05 jvanverth@google.com [graphite] Revise test methods in Recording and Recorder.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-05 20:12:40 +00:00
skia-flutter-autoroll
1afafd337a Roll Skia from c07fbf4c1d67 to a0572041af8e (3 revisions) (flutter/engine#45460) 
https://skia.googlesource.com/skia.git/+log/c07fbf4c1d67..a0572041af8e

2023-09-05 kjlubick@google.com Remove SkTime from the public API
2023-09-05 michaelludwig@google.com [skif] Check dstEnd in loop iteration
2023-09-05 bungeman@google.com Roll FreeType from 2d9fce53 to 45903920 (6 commits)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-05 19:23:00 +00:00
Jonah Williams
ccb41f292c [Impeller] compute path bounds once, use Skia computed bounds where possible. (flutter/engine#45456) 
Now that Paths are externally immutable, we can compute the bounds once at construction. This also allows the Skia conversions to set the already computed bounds.
 2023-09-05 17:44:35 +00:00
skia-flutter-autoroll
d98faa8d1c Roll Skia from d8ea902500a3 to c07fbf4c1d67 (2 revisions) (flutter/engine#45451) 
https://skia.googlesource.com/skia.git/+log/d8ea902500a3..c07fbf4c1d67

2023-09-05 johnstiles@google.com Require a pixel format on all storage textures.
2023-09-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from f5590cb5133d to eca28238b5a3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-05 17:36:17 +00:00
Zachary Anderson
81534e8ace Adds a Dart library for loading and parsing build configs (flutter/engine#45390) 
Also adds a test that the build configs in the repo are valid json that
matches the spec.

Fleshed out @christopherfujino's code from here
https://github.com/christopherfujino/flutter-engine-runner/blob/main/main.dart
 2023-09-05 10:00:44 -07:00
skia-flutter-autoroll
e5a4f45dd8 Roll Skia from 9ef0225b5f8a to 055b26152483 (1 revision) (flutter/engine#45446) 
https://skia.googlesource.com/skia.git/+log/9ef0225b5f8a..055b26152483

2023-09-05 johnstiles@google.com Fix external-texture assertion discovered by the fuzzer.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-05 15:01:20 +00:00
skia-flutter-autoroll
9cd820c20b Roll Skia from 8206402f3c35 to 7d0e33e32427 (2 revisions) (flutter/engine#45440) 
https://skia.googlesource.com/skia.git/+log/8206402f3c35..7d0e33e32427

2023-09-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ebf1e7163216 to e691a4edb19a (3 revisions)
2023-09-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 959bb251c386 to f5590cb5133d (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,armansito@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-05 07:36:40 +00:00
skia-flutter-autoroll
aad1c31bf4 Roll Dart SDK from 671cf059e4b6 to 43d4b1373788 (2 revisions) (flutter/engine#45435) 
https://dart.googlesource.com/sdk.git/+log/671cf059e4b6..43d4b1373788

2023-09-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-134.0.dev
2023-09-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-133.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-04 23:55:27 +00:00
Robert Ancell
e0006ade23 Fix building on Pango 1.49.4 (flutter/engine#45098) 
This version added the autoptr macros which we no longer need to define.

https://github.com/flutter/flutter/issues/132881
 2023-09-05 08:03:28 +12:00
skia-flutter-autoroll
ee1a541fd7 Roll Skia from 15f77147a3ec to 4d0501380011 (1 revision) (flutter/engine#45421) 
https://skia.googlesource.com/skia.git/+log/15f77147a3ec..4d0501380011

2023-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2b76b0e00861 to 959bb251c386 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,armansito@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-04 05:33:32 +00:00
Tong Mu
f0eb04206a Remove --disable-service-auth-codes (flutter/engine#45356) 
Discovered by a leakage as described in https://github.com/flutter/flutter/issues/133824, this arg has likely been removed by Dart. Removing this arg eliminates the leakage warning.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-02 06:06:10 +00:00
Brandon DeRosier
7f84662294 [Impeller] Import cstring for memcpy. (flutter/engine#45408) 
Fixes builds against some STLs (detected in impeller-cmake [ubuntu
build](https://github.com/bdero/impeller-cmake/actions/runs/6020031888/job/16330726595)).
 2023-09-01 22:11:02 -07:00
skia-flutter-autoroll
47500f589f Roll Dart SDK from cdf1ce0c6d7e to a5c7102af509 (1 revision) (flutter/engine#45412) 
https://dart.googlesource.com/sdk.git/+log/cdf1ce0c6d7e..a5c7102af509

2023-09-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-131.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-02 04:42:22 +00:00
Tong Mu
a443c671d0 Remove deprecated MOCK_METHODx calls (flutter/engine#45307) 
The issue that blocks these mocking methods have been resolved.

However, there is [one more mention of this issue in `run_tests.py`](1410d8beaa/testing/run_tests.py (L400)) and I have no idea why it was marked so. It was originally added [here](https://github.com/flutter/engine/pull/19033/files#diff-521d7c59c3f721b259f094c760c2613e16e889b0f24702280924466109e3b0b0R137).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-02 01:42:21 +00:00
Jonah Williams
17b261d8f5 [Impeller] Better demonstrate blur and draw picture? (flutter/engine#45388) 
The current goldens are changing a lot, this should be stabler. though not sure if it looks quite right.
 2023-09-02 01:01:06 +00:00
Jonah Williams
be8bb23633 [Impeller] Make paths externally immutable, update all tests to use PathBuilder to create Path. (flutter/engine#45393) 
This is a design problem in the Flutter API, that in general you can't assume a Path hasn't changed from the last time you used it. We're so close, so just move the mutation methods to PathBuilder :)

Fixes https://github.com/flutter/flutter/issues/133880
 2023-09-02 01:01:04 +00:00
Jim Graham
00c1242837 Cull the RTree bounds when they are forwarded in DrawDisplayList (flutter/engine#45358) 
Fixes https://github.com/flutter/flutter/issues/133437

With this fix, the [benchmarks](https://github.com/flutter/flutter/pull/133434) for pictures with huge bounds become runnable under more conditions. Currently those benchmarks only run on platforms where we don't run into this issue. The performance on those platforms/conditions will not change much, but with this fix we can run them on Impeller and add a variant that has a platform view on the display.
 2023-09-02 00:53:19 +00:00
skia-flutter-autoroll
3cf7d6052c Roll Skia from fedff79a6afc to 2d8849f9f0cc (3 revisions) (flutter/engine#45407) 
https://skia.googlesource.com/skia.git/+log/fedff79a6afc..2d8849f9f0cc

2023-09-01 armansito@google.com [graphite][compute] Dynamically assemble resource declarations from snippets
2023-09-01 armansito@google.com [graphite][compute] Combined "SampledTexture" resource
2023-09-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 15007d22798e to 8643aba2c123 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-02 00:23:20 +00:00
Jonah Williams
26d612bbf4 [impeller] premultiply vertices colors. (flutter/engine#45406) 
Lost this after the transition.

### After

![image](https://github.com/flutter/engine/assets/8975114/cec40045-581a-4bc4-8470-fbc201a0773b)

### Before

![image](https://github.com/flutter/engine/assets/8975114/23229175-54db-4aac-8605-cfe8568be436)
 2023-09-02 00:18:05 +00:00
skia-flutter-autoroll
26ce6e9354 Roll ANGLE from 6a09e41ce6ea to 962fdf7b7882 (224 revisions) (flutter/engine#45400) 
Roll ANGLE from 6a09e41ce6ea to 962fdf7b7882 (224 revisions)

6a09e41ce6..962fdf7b78

2023-09-01 cclao@google.com Add templated BinaryOutputStream::writeVector and writeStruct
2023-09-01 mark@lunarg.com Tests: Limit CapturedTest to Vulkan backend
2023-09-01 romanl@google.com Traces: temporary patch to log zlib message on failure
2023-09-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from a745d5c29c56 to 385ae8bed1f9 (7 revisions)
2023-09-01 romanl@google.com Revert "Gold tests: add temporary logging of angledata hashes"
2023-09-01 romanl@google.com Revert "Traces: add temporary debug info to LoadBinaryData"
2023-09-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 988fe1c529b0 to 15007d22798e (6 revisions)
2023-09-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f59e85c23631 to 613933d34730 (499 revisions)
2023-09-01 lexa.knyazev@gmail.com Validate missing fragment outputs for dual-source blending
2023-09-01 cclao@google.com Add more test for GL_SRGB8 format
2023-08-31 ynovikov@chromium.org Skip 2 DrawCallPerfBenchmark tests on Pixel 6
2023-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from a446c6320b6b to 988fe1c529b0 (28 revisions)
2023-08-31 syoussefi@chromium.org Move transform feedback buffer mode to program state
2023-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from 90200ab2e92a to f59e85c23631 (744 revisions)
2023-08-31 syoussefi@chromium.org Clean up InfoLog usage during link
2023-08-31 jiawei.shao@intel.com D3D11: Fix register index of read-only storage images
2023-08-31 syoussefi@chromium.org Remove link results from program hash
2023-08-31 ynovikov@chromium.org Don't sync reclient on linux arm64
2023-08-31 romanl@google.com Cleanup: remove tests.csv
2023-08-31 steven@uplinklabs.net d3d11: avoid exit-time-destructor warning
2023-08-31 geofflang@chromium.org Handle Qualcomm's Windows vendor ID.
2023-08-31 jiawei.shao@intel.com D3D11: Fix the compilation of vertex shader with storage image
2023-08-31 romanl@google.com Tests: EGLMakeCurrentPerfTest loads GLES
2023-08-31 zzyiwei@chromium.org Vulkan: disallow pbo copies when offset is incompatible with vulkan
2023-08-30 cclao@google.com Add GL_RGBX8_SRGB_ANGLEX and GL_BGRX8_SRGB_ANGLEX formats
2023-08-30 geofflang@chromium.org Check that postTask is non-null before calling it.
2023-08-30 sokcevic@chromium.org [DEPS] Use Var instead of {} in DEPS
2023-08-30 jonahr@google.com Metal: Fix dropped out arguments from functions with many args.
2023-08-30 m.maiya@samsung.com Vulkan: Support EGL_EXT_gl_colorspace_bt2020
2023-08-30 phanquangminh217@gmail.com Add support for EGL_MESA_platfrom_surfaceless extension
2023-08-30 phanquangminh217@gmail.com egl: Fix device fallback if native display eglInitialize fails
2023-08-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e2ad2e99dc98 to 90200ab2e92a (420 revisions)
2023-08-30 syoussefi@chromium.org Move pre-link program state to ProgramState
2023-08-30 lexa.knyazev@gmail.com Validate active draw buffers for dual-source blending
2023-08-30 syoussefi@chromium.org Vulkan: Stop passing both ProgramExecutable and ...Vk around
2023-08-30 syoussefi@chromium.org Metal: Move program state to ProgramExecutableMtl
2023-08-30 syoussefi@chromium.org GL: Move program state to ProgramExecutableGL
2023-08-30 syoussefi@chromium.org Move left over link state to ProgramExecutable
2023-08-29 geofflang@chromium.org Return the vendor string as hex when it is unknown.
2023-08-29 mikes@lunarg.com Add build overrides for Vulkan Utility Libraries
2023-08-29 syoussefi@chromium.org D3D: Move program state to ProgramExecutableD3D
2023-08-29 m.maiya@samsung.com EGL: Update EGL headers
2023-08-29 syoussefi@chromium.org Make ProgramExecutableImpl managed by ProgramExecutable
2023-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from 2f13938f5894 to e2ad2e99dc98 (165 revisions)
2023-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d213632452c2 to a446c6320b6b (9 revisions)
2023-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 92b28610c8f3 to 2f13938f5894 (510 revisions)
...
 2023-09-01 23:57:51 +00:00
skia-flutter-autoroll
b6ad1bc8a5 Roll Skia from 22ae23891e8e to fedff79a6afc (1 revision) (flutter/engine#45405) 
https://skia.googlesource.com/skia.git/+log/22ae23891e8e..fedff79a6afc

2023-09-01 johnstiles@google.com Move assertion about samplers out of SPIRVCodeGenerator.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-01 23:37:06 +00:00
gaaclarke
d23968a976 [Impeller] turned on validations for all debug builds (flutter/engine#45350) 
fixes https://github.com/flutter/flutter/issues/133794

This adds the following shared libraries to the flutter.jar for debug builds on arm64:
```
lib/arm64-v8a/libVkLayer_khronos_validation.so
lib/arm64-v8a/libc++_shared.so
```

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-01 23:29:22 +00:00
skia-flutter-autoroll
48966a7f06 Roll Skia from 2c0405489966 to 22ae23891e8e (1 revision) (flutter/engine#45402) 
https://skia.googlesource.com/skia.git/+log/2c0405489966..22ae23891e8e

2023-09-01 johnstiles@google.com Enforce backend flags on push_constant layout.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-01 22:52:38 +00:00
Loïc Sharma
2bec12f0b4 [Windows] Update vsync on raster thread (flutter/engine#45310) 
## Background

If the Windows system compositor is enabled, the Windows embedder disables the swap interval so that presenting to a surface does not block until the v-blank. If the Windows system compositor is disabled (which is possible on Windows 7), the Windows embedder enables swap interval to prevent screen tearing.

Updating the swap interval requires making the GL surface current, which we currently do on the platform thread. However, the raster thread also needs the GL surface for rendering. Our current version of ANGLE allows making a GL surface current on multiple threads. However, the latest version of ANGLE errors if a GL context is made current on multiple threads. This is causing the ANGLE roll to fail ([example](https://ci.chromium.org/ui/p/flutter/builders/try/Windows%20Engine%20Drone/203788/overview)).

## Solution

There's two fixes:

1. The GL context is released once the swap interval is updated. This allows the platform thread to set the initial swap interval at start up, before the raster thread is started. This fixes the ANGLE roll.
3. When the system compositor changes, the Windows embedder now switches to the raster thread before updating the swap interval. This ensures that the GL surface is only made current on the raster thread once the raster thread has started. I updated unit tests to cover this scenario and tested this manually on a Windows 7 machine.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-01 22:33:01 +00:00
skia-flutter-autoroll
d58cef0f45 Roll Skia from f3f6c733c7e6 to 2c0405489966 (1 revision) (flutter/engine#45396) 
https://skia.googlesource.com/skia.git/+log/f3f6c733c7e6..2c0405489966

2023-09-01 kjlubick@google.com Reland "Roll Dawn from beaf20f90f1b to b9afa50913de (668 revisions)"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-01 21:06:47 +00:00
skia-flutter-autoroll
4712ec69ef Roll Skia from 02fa14799c6c to f3f6c733c7e6 (1 revision) (flutter/engine#45394) 
https://skia.googlesource.com/skia.git/+log/02fa14799c6c..f3f6c733c7e6

2023-09-01 kjlubick@google.com Revert "Roll Dawn from beaf20f90f1b to b9afa50913de (668 revisions)"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-01 20:23:57 +00:00
skia-flutter-autoroll
48d41d0aa3 Roll Skia from d5d3b0d4ee77 to 02fa14799c6c (2 revisions) (flutter/engine#45392) 
https://skia.googlesource.com/skia.git/+log/d5d3b0d4ee77..02fa14799c6c

2023-09-01 kjlubick@google.com Fix unintentional cpu_sync=true and deprecate sk_sp<SkSurface> APIs
2023-09-01 johnstiles@google.com Enforce matching pixel-format when passing texture2D arguments.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-01 19:40:02 +00:00
hellohuanlin
ef55ffaa9b [ios][ios17][text_input]fix text input system highlight in iOS 17 Beta 7 with firstRectForRange (flutter/engine#45303) 
Design doc with more details: https://docs.google.com/document/d/1sM3HMv-SQin39yX1aPUU7vtGv7Hcef1Quc3QhRXBl6A/edit?resourcekey=0-SFYD8vmOIkXiXCZvB1Wlcw#heading=h.tul5o3hopauh

Just to be safe, for now we only change for iOS 17. However, the same logic should apply to older iOS as well. So will update in a separate PR. 

Basically we were using `firstRectForRange` incorrectly. According to [the API doc](https://developer.apple.com/documentation/uikit/uitextinput/1614570-firstrectforrange), `firstRectForRange` should return **the rect for the queried range, or a subrange through the end of line, if the range encompasses multiple lines**.

For LTR language: 

```
0,  1,  2,  3
4,  5,  6,  7
```
Query: `[1, 2, 3, 4]`
Returns the following rect denoted by `[ ]`: 
```
0,  [1,  2,  3]
4,  5,   6,   7
```

Similarly, for RTL language (Arabic): 

```
 3,   2,   1,   0
 7,    6,   5,   4
```

Query: `[1, 2, 3, 4]`
Returns the following rect denoted by `[ ]`: 
```
[3,  2,  1],  0
 7,   6,  5,   4
```

*List which issues are fixed by this PR. You must list at least one issue.*

https://github.com/flutter/flutter/issues/131622

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-01 19:03:48 +00:00
skia-flutter-autoroll
78f1c64cb8 Roll Skia from d6266ef14a7e to d5d3b0d4ee77 (2 revisions) (flutter/engine#45389) 
https://skia.googlesource.com/skia.git/+log/d6266ef14a7e..d5d3b0d4ee77

2023-09-01 johnstiles@google.com Require that texture2D function parameters include a pixel format.
2023-09-01 kjlubick@google.com Roll Dawn from beaf20f90f1b to b9afa50913de (668 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-01 18:21:14 +00:00
skia-flutter-autoroll
cc05cef18d Roll Dart SDK from 0c121a6431cc to a2ea759c16cc (1 revision) (flutter/engine#45384) 
https://dart.googlesource.com/sdk.git/+log/0c121a6431cc..a2ea759c16cc

2023-09-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-129.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-01 17:32:04 +00:00
Matan Lurey
a330c4ff97 Update (flipping the default from false -> true) and deprecate Paint.enableDithering. (flutter/engine#44705) 
Update: Blocked on https://github.com/flutter/engine/pull/44912 landing,
and merging into google3.

---

Partial work towards https://github.com/flutter/flutter/issues/112498.

_**tl;dr**: In Impeller's backend we intend to _always_ dither
gradients, and never allow any changes long-term (i.e., write your own
shader if you want different behavior) with the assumption that dithered
gradients look better most of the time, and don't typically hurt
elsewhere._

Note that, at the time of this writing, I couldn't find a single case of
this being set explicitly to `true` inside Google, and there are between
[100 and 200 publicly accessible on
GitHub](https://github.com/search?q=%22Paint.enableDithering%22+language%3ADart&type=code&l=Dart),
of which virtually all are setting it explicitly to `true`.

There are some (valid) concerns this would cause a lot of golden-file
image diffs, so I'm going to seek explicit approval from the Google
testing team as well as someone from the framework team before landing
this commit.
 2023-09-01 10:19:59 -07:00
Jonah Williams
baa288096b [Impeller] EntityPass::Clone needs to clone harder (flutter/engine#45313) 
Fixes https://github.com/flutter/flutter/issues/133731
 2023-09-01 17:19:03 +00:00
Chris Yang
b3fc48b91b Reland "ios: remove shared_application and support app extension build #44732" (flutter/engine#45351) 
Relands https://github.com/flutter/engine/pull/44732 with fix. 

The original PR returns nil when the assets is not reachable, in some cases, the assets are not loaded yet but will be loaded later, so we should return the asset URL regardless. 

Also added a fallback to main bundle to match the previous implementation. 

The original PR was failed in internal tests in b/297654739
Now with the fix, all tests passed: cl/561449914

fixes https://github.com/flutter/flutter/issues/124289

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-01 16:56:49 +00:00
Brian Osman
19d37a310c Migrate Fuchsia VK calls of GrBackend* (flutter/engine#45380) 
Follow-up to https://github.com/flutter/engine/pull/45325

No functional change.
 2023-09-01 15:41:43 +00:00
Bruno Leroux
1dc91d901e [Linux] Fix channel buffers control commands error handling (flutter/engine#45056) 
## Description

This PR fixes a mistake I made on https://github.com/flutter/engine/pull/44636 where the error handling code wrongly relied on `fl_method_channel_invoke_method_finish` instead of  `fl_binary_messenger_send_on_channel_finish`.
The error handling code was not called when running the tests added in https://github.com/flutter/engine/pull/44636 so this mistake did not pop up.

@robert-ancell I added a test that simulates an error response and I had to rely on `g_idle_add` to make it works. Is this approach ok?

## Related Issue

Linux implementation for https://github.com/flutter/flutter/issues/132386

## Tests

Adds one test.
 2023-09-01 07:40:25 +00:00
skia-flutter-autoroll
47242f91e0 Roll Skia from e585fdc18134 to 2916365d0fa6 (1 revision) (flutter/engine#45366) 
https://skia.googlesource.com/skia.git/+log/e585fdc18134..2916365d0fa6

2023-09-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 4d381b7718fd to 2b76b0e00861 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-01 05:29:47 +00:00
Jonah Williams
bad97b052b [Impeller] use correct blend mode for performance overlay (flutter/engine#45365) 
Man this is a sharp 🔪 

I literally pointed this out in the review and failed to notice the wrong parameter had the blend mode.
 2023-09-01 03:47:52 +00:00